From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 17:23:54 2013 Received: (at submit) by debbugs.gnu.org; 22 Nov 2013 22:23:54 +0000 Received: from localhost ([127.0.0.1]:39065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vjz8j-0000k9-KC for submit@debbugs.gnu.org; Fri, 22 Nov 2013 17:23:54 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52726) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vjz8g-0000jq-Bq for submit@debbugs.gnu.org; Fri, 22 Nov 2013 17:23:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vjz8Z-0005Ov-8V for submit@debbugs.gnu.org; Fri, 22 Nov 2013 17:23:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID,T_FRT_FOLLOW1 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjz8Z-0005Op-4m for submit@debbugs.gnu.org; Fri, 22 Nov 2013 17:23:43 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54440) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjz8X-0004lN-FM for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2013 17:23:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vjz8V-0005OX-KF for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2013 17:23:41 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:49655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vjz8V-0005OM-8g for bug-gnu-emacs@gnu.org; Fri, 22 Nov 2013 17:23:39 -0500 Received: by mail-wg0-f42.google.com with SMTP id k14so1875269wgh.1 for ; Fri, 22 Nov 2013 14:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=5dpl+7Niufe1o8j7RPdE2KjKUtE3AIauc8ARInspRpw=; b=TUHObSr0cIJ+pFRuiWg0ngLFp/9BgDuWHf4OnIMxKRq4dKyfIXHYaiyROTUeQkcDeP XOuDrsBxM1sPM0mA/tf75vWvsbyUrMwmNg2S/7sOqBRtJ1guduQMzUV9T8ljNnfxci7p OAogdHwGVTKTn6jwsHKX+d2Gs+0xFKiq1SqebrrzTiz0xfhASRrB0EOAZRHiPkjB1lr4 HfE7xzU0NQvoNf5mAVW1agrM+oxlvAnGzzCV8l7erjZWE4+Xo2BEh8anyatotYXkulqV N7ds40aEpVLxhqf/+X+FWA4TTCSGfs3u2Dgo/FB4XD+jRTdHez9IzKnJTelcPbHHalb2 MyUw== MIME-Version: 1.0 X-Received: by 10.194.205.37 with SMTP id ld5mr83493wjc.67.1385159017918; Fri, 22 Nov 2013 14:23:37 -0800 (PST) Received: by 10.216.124.76 with HTTP; Fri, 22 Nov 2013 14:23:37 -0800 (PST) Date: Fri, 22 Nov 2013 23:23:37 +0100 Message-ID: Subject: 24.3.50; Follow mode scrolling broken on Emacs trunk From: Anders Lindgren To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=047d7bb70c5838750104ebcb77d2 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --047d7bb70c5838750104ebcb77d2 Content-Type: text/plain; charset=ISO-8859-1 Hi! Scrolling multiple pages when Follow mode is enabled sometimes fails. Steps to repeat: Emacs -Q C-h t ESC : (set-frame-size (selected-frame) 200 70) RET M-x follow-delete-other-windows-and-split RET C-c . C-v The intent is to scroll the entire document two pages down, the left window should still be selected (this causes Follow mode to arrange the right window after it). Instead, the right window is selected, which causes the left to be arranged after it, effectively undoing the scroll. The problem seems to be sometimes intermittent, sometimes the scroll works, sometimes it don't. An interesting effect is that the problem only occurs when follow-scroll-up is bound to a key. When issuing M-x follow-scroll-up RET, the command seems to be working properly. By the way, I'm the original author of Follow mode, even tough I haven't touched it for many years. Sincerely, Anders Lindgren In GNU Emacs 24.3.50.11 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00) of 2013-11-21 on macpro.lan Bzr revision: 115156 rgm@gnu.org-20131120081620-w7c04v1rspm8i0dr Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --with-ns' Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Fundamental Minor modes in effect: follow-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: C-x C-g C-h t x C-x u x f o l l o w - d e C-c . C-v x r e p o r t - b Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. C-x C-g is undefined Preparing tutorial ... Undo! Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils follow tutorial help-mode easymenu time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) --047d7bb70c5838750104ebcb77d2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi!

Scrolling multiple p= ages when Follow mode is enabled sometimes fails.

= Steps to repeat:

=A0 =A0 Emacs -Q
=A0 = =A0 C-h t
=A0 =A0 ESC : (set-frame-size (selected-frame) 200 70) RET
= =A0 =A0 M-x follow-delete-other-windows-and-split RET
=A0 =A0 C-c= . C-v

The intent is to scroll the entire document= two pages down, the left
window should still be selected (this causes Follow mode to arrange th= e
right window after it). Instead, the right window is selected, = which causes
the left to be arranged after it, effectively undoin= g the scroll.

The problem seems to be sometimes intermittent, sometim= es the scroll works,
sometimes it don't.

=
An interesting effect is that the problem only occurs when
follow-scroll-up is bound to a key. When issuing M-x follow-scroll-up
=
RET, the command seems to be working properly.

By the way, I'm the original author of Follow mode, even tough I have= n't
touched it for many years.

Sincerely,
=A0 =A0 Anders Lindgren


In GNU E= macs 24.3.50.11 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
<= div> =A0of 2013-11-21 on macpro.lan
Bzr revision: 115156 rgm@gnu.org-2= 0131120081620-w7c04v1rspm8i0dr
Windowing system distributor `Appl= e', version 10.3.1265
Configured using:
=A0`configu= re --with-ns'

Important settings:
=A0 value of $LC_CTYPE: U= TF-8
=A0 locale-coding-system: utf-8-unix
=A0 default e= nable-multibyte-characters: t

Major mode: Fundamen= tal

Minor modes in effect:
=A0 follow-mode: t
=A0 tooltip-mode: t
=A0 mouse-wheel-mode: t
=A0 = tool-bar-mode: t
=A0 menu-bar-mode: t
=A0 file-name-sha= dow-mode: t
=A0 global-font-lock-mode: t
=A0 blink-cursor-mode: t
<= div>=A0 auto-composition-mode: t
=A0 auto-encryption-mode: t
=A0 auto-compression-mode: t
=A0 line-number-mode: t
<= div>=A0 transient-mark-mode: t

Recent input:
<help-echo> C-x C-g C-h t= x C-x u <escape> x f o l=A0
l o w - d e <tab> <re= turn> C-c . C-v <escape> x r e=A0
p o r t - b <tab>= ; <return>

Recent messages:
For information about GNU Em= acs and the GNU system, type C-h C-a.
C-x C-g is undefined
<= div>Preparing tutorial ...
Undo!

Load-pa= th shadows:
None found.

Features:
(shadow sort = gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-s= ec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
= mail-prsvr mail-utils follow tutorial help-mode easymenu time-date
tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-ba= r
mouse jit-lock font-lock syntax facemenu font-core frame cham g= eorgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
=
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abb= rev
minibuffer nadvice loaddefs button faces cus-face macroexp files
=
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-proces= s
cocoa ns multi-tty emacs)

--047d7bb70c5838750104ebcb77d2-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 06:59:04 2013 Received: (at 15957) by debbugs.gnu.org; 23 Nov 2013 11:59:04 +0000 Received: from localhost ([127.0.0.1]:39539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkBrb-0000tZ-2Z for submit@debbugs.gnu.org; Sat, 23 Nov 2013 06:59:03 -0500 Received: from mout.gmx.net ([212.227.15.15]:62983) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkBrX-0000t2-Ae for 15957@debbugs.gnu.org; Sat, 23 Nov 2013 06:59:00 -0500 Received: from [62.47.47.218] ([62.47.47.218]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Ma1pn-1W5ytv2w63-00LnqS for <15957@debbugs.gnu.org>; Sat, 23 Nov 2013 12:58:52 +0100 Message-ID: <52909877.1070203@gmx.at> Date: Sat, 23 Nov 2013 12:58:47 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:KGPISzMlPyT2UjfatAr+tMrVAdZ9cQVC+gUPArfEgCmux1hFOyP jEGPHOAgL0vLDLuVnGUkJ2NcjuzGE0zW3x/WuRLdntqBqZFmn3cTyo94UPu+3elwMAi3iTZ Mpkt7JDG1n9x6CZLFArXTKe4OUyI6OTST6BNe3cVRRhRZEj9vJctpAXZ2ujSD1BjwFJEkOF lvUgTzUEXbEtNS1EQiUdQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Hi Anders > Scrolling multiple pages when Follow mode is enabled sometimes fails. > > Steps to repeat: > > Emacs -Q > C-h t > ESC : (set-frame-size (selected-frame) 200 70) RET Is this really necessary? 70 lines means I can't see my echo area any more. > M-x follow-delete-other-windows-and-split RET > C-c . C-v > > The intent is to scroll the entire document two pages down, the left > window should still be selected (this causes Follow mode to arrange the > right window after it). Instead, the right window is selected, Can you tell when and where the window on the right is selected? > which causes > the left to be arranged after it, effectively undoing the scroll. IIUC `follow-scroll-up' should select the proper window via (let* ((windows (follow-all-followers)) (end (window-end (car (reverse windows))))) (if (eq end (point-max)) (signal 'end-of-buffer nil) (select-window (car windows)) which seems to imply that `follow-all-followers' doesn't return what it is supposed to. Am I correct that the first window returned by the latter should be `frame-first-window'? In that case try to replace the last line of `follow-all-followers' by something like (prog1 (setq windows (sort windows 'follow--window-sorter)) (unless (eq (car windows) (frame-first-window (window-frame win))) (error "Bad windows %s" windows))))) and maybe this way we can find out whether the problem is there. > The problem seems to be sometimes intermittent, sometimes the scroll works, > sometimes it don't. > > An interesting effect is that the problem only occurs when > follow-scroll-up is bound to a key. When issuing M-x follow-scroll-up > RET, the command seems to be working properly. I have no idea why this could change the course of things because ARG should be nil in both cases. > By the way, I'm the original author of Follow mode, even tough I haven't > touched it for many years. I suppose you should touch it again ;-) martin From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 17:01:34 2013 Received: (at 15957) by debbugs.gnu.org; 23 Nov 2013 22:01:34 +0000 Received: from localhost ([127.0.0.1]:40611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkLGf-0000Fv-P8 for submit@debbugs.gnu.org; Sat, 23 Nov 2013 17:01:34 -0500 Received: from mail-we0-f172.google.com ([74.125.82.172]:39675) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkLGc-0000Fg-QV for 15957@debbugs.gnu.org; Sat, 23 Nov 2013 17:01:31 -0500 Received: by mail-we0-f172.google.com with SMTP id t60so2480446wes.31 for <15957@debbugs.gnu.org>; Sat, 23 Nov 2013 14:01:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=WWjgGbYRmsJH4AgfyJSGQOJz7mUmWQRyPk6FAt3dLEg=; b=W4dhdMQ8PQ4w8zn9EkfucN+EpyF9g+ioExl2fLcvohJkkpJDB6cqr0vaTe/DFRVKug hVwfb+mO+jR54l5x3Mc7ilyMHeXIlCbd+EgJYWuhPeI16u3bXQIb15DPY5dYIDonMdAR iduKH6RHqgl/DPf/tM5n6HAxmOH5cwoBJJBJWYATslqmkcMg/BOuc7Eihsufpfdr5CTK /blxy5d7Sf5ZYetc3AnzTAg9JXe5DI4pYlOuw+KB6CfjiBDrXNr9ps/kAL7ljmyA/YMo CWGQag+ET22S6vstx4zLLvgOCKpazAo51TTkbAWx42ewJ6gO5OprpzUw40WmY6/00P9F NjdQ== MIME-Version: 1.0 X-Received: by 10.180.20.102 with SMTP id m6mr7933679wie.22.1385244084471; Sat, 23 Nov 2013 14:01:24 -0800 (PST) Received: by 10.216.124.76 with HTTP; Sat, 23 Nov 2013 14:01:24 -0800 (PST) In-Reply-To: <52909877.1070203@gmx.at> References: <52909877.1070203@gmx.at> Date: Sat, 23 Nov 2013 23:01:24 +0100 Message-ID: Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk From: Anders Lindgren To: martin rudalics Content-Type: multipart/alternative; boundary=bcaec53f382f950bfb04ebdf4567 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15957 Cc: 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --bcaec53f382f950bfb04ebdf4567 Content-Type: text/plain; charset=ISO-8859-1 Hi! No, the actual numbers don't appear to be important. I simply picked some numbers to make sure the frame was wide enough for two side-by-side windows. I tried 40 instead of 70 and you get the same effect. I really doubt that the code in `follow-scroll-up' is broken. Follow-mode is designed so that the rearrangement of the other windows (the ones that follow the selected window) occur in the post-command hook (to allow Follow-mode to act upon all Emacs commands, not only it's special function). It appears that something has changed in the display engine, or in the way that post-command-hook is called, that makes this mechanism fail. This could also account for the difference we see when the function is called via a key sequence as compared to via M-x. This is also the reason why reported this as a bug, rather than digging into the code myself. However, I could try to add log code to Follow mode, to check if I could try to figure out what is going on. -- Anders On Sat, Nov 23, 2013 at 12:58 PM, martin rudalics wrote: > Hi Anders > > > Scrolling multiple pages when Follow mode is enabled sometimes fails. > > > > Steps to repeat: > > > > Emacs -Q > > C-h t > > ESC : (set-frame-size (selected-frame) 200 70) RET > > Is this really necessary? 70 lines means I can't see my echo area any > more. > > > M-x follow-delete-other-windows-and-split RET > > C-c . C-v > > > > The intent is to scroll the entire document two pages down, the left > > window should still be selected (this causes Follow mode to arrange the > > right window after it). Instead, the right window is selected, > > Can you tell when and where the window on the right is selected? > > > which causes > > the left to be arranged after it, effectively undoing the scroll. > > IIUC `follow-scroll-up' should select the proper window via > > (let* ((windows (follow-all-followers)) > (end (window-end (car (reverse windows))))) > (if (eq end (point-max)) > (signal 'end-of-buffer nil) > (select-window (car windows)) > > which seems to imply that `follow-all-followers' doesn't return what it > is supposed to. Am I correct that the first window returned by the > latter should be `frame-first-window'? In that case try to replace the > last line of `follow-all-followers' by something like > > (prog1 > (setq windows (sort windows 'follow--window-sorter)) > (unless (eq (car windows) (frame-first-window (window-frame win))) > (error "Bad windows %s" windows))))) > > and maybe this way we can find out whether the problem is there. > > > The problem seems to be sometimes intermittent, sometimes the scroll > works, > > sometimes it don't. > > > > An interesting effect is that the problem only occurs when > > follow-scroll-up is bound to a key. When issuing M-x follow-scroll-up > > RET, the command seems to be working properly. > > I have no idea why this could change the course of things because ARG > should be nil in both cases. > > > By the way, I'm the original author of Follow mode, even tough I haven't > > touched it for many years. > > I suppose you should touch it again ;-) > > martin > --bcaec53f382f950bfb04ebdf4567 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi!

No, the actual numbers don't ap= pear to be important. I simply picked some numbers to make sure the frame w= as wide enough for two side-by-side windows. I tried 40 instead of 70 and y= ou get the same effect.

I really doubt that the code in `follow-scroll-up' = is broken. Follow-mode is designed so that the rearrangement of the other w= indows (the ones that follow the selected window) occur in the post-command= hook (to allow Follow-mode to act upon all Emacs commands, not only it'= ;s special function). It appears that something has changed in the display = engine, or in the way that post-command-hook is called, that makes this mec= hanism fail. This could also account for the difference we see when the fun= ction is called via a key sequence as compared to via M-x.

This is also the reason why reported this as a bug, rat= her than digging into the code myself. However, I could try to add log code= to Follow mode, to check if I could try to figure out what is going on.

=A0 =A0 -- Anders





On Sat, Nov 23, 2013 at 12:58 PM, martin rudalics &= lt;rudalics@gmx.at= > wrote:
Hi Anders

> Scrolling multiple pages when Follow mode is enabled sometimes fails.<= br> >
> Steps to repeat:
>
> =A0 =A0 Emacs -Q
> =A0 =A0 C-h t
> =A0 =A0 ESC : (set-frame-size (selected-frame) 200 70) RET

Is this really necessary? =A070 lines means I can't see my echo area an= y
more.

> =A0 =A0 M-x follow-delete-other-windows-and-split RET
> =A0 =A0 C-c . C-v
>
> The intent is to scroll the entire document two pages down, the left > window should still be selected (this causes Follow mode to arrange th= e
> right window after it). Instead, the right window is selected,

Can you tell when and where the window on the right is selected?

> which causes
> the left to be arranged after it, effectively undoing the scroll.

IIUC `follow-scroll-up' should select the proper window via

=A0 =A0 =A0 =A0 =A0(let* ((windows (follow-all-followers))
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (end (window-end (car (reverse windows)))))=
=A0 =A0 =A0 =A0 =A0 =A0(if (eq end (point-max))
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(signal 'end-of-buffer nil)
=A0 =A0 =A0 =A0 =A0 =A0 =A0(select-window (car windows))

which seems to imply that `follow-all-followers' doesn't return wha= t it
is supposed to. =A0Am I correct that the first window returned by the
latter should be `frame-first-window'? =A0In that case try to replace t= he
last line of `follow-all-followers' by something like

=A0 =A0 (prog1
=A0 =A0 =A0 =A0 (setq windows (sort windows 'follow--window-sorter)) =A0 =A0 =A0 (unless (eq (car windows) (frame-first-window (window-frame win= )))
=A0 =A0 =A0 =A0 (error "Bad windows %s" windows)))))

and maybe this way we can find out whether the problem is there.

> The problem seems to be sometimes intermittent, sometimes the scroll w= orks,
> sometimes it don't.
>
> An interesting effect is that the problem only occurs when
> follow-scroll-up is bound to a key. When issuing M-x follow-scroll-up<= br> > RET, the command seems to be working properly.

I have no idea why this could change the course of things because ARG
should be nil in both cases.

> By the way, I'm the original author of Follow mode, even tough I h= aven't
> touched it for many years.

I suppose you should touch it again ;-)

martin

--bcaec53f382f950bfb04ebdf4567-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 05:10:48 2013 Received: (at 15957) by debbugs.gnu.org; 24 Nov 2013 10:10:48 +0000 Received: from localhost ([127.0.0.1]:41591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkWeO-0002dU-6L for submit@debbugs.gnu.org; Sun, 24 Nov 2013 05:10:48 -0500 Received: from mout.gmx.net ([212.227.15.19]:49452) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkWeL-0002dG-6M for 15957@debbugs.gnu.org; Sun, 24 Nov 2013 05:10:46 -0500 Received: from [62.47.38.99] ([62.47.38.99]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0Lp7d2-1V7sRG1va0-00esxy for <15957@debbugs.gnu.org>; Sun, 24 Nov 2013 11:10:39 +0100 Message-ID: <5291D098.10507@gmx.at> Date: Sun, 24 Nov 2013 11:10:32 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:uyo8l4TQ0wVqrdaeElkBBZLZC4SElKpGWAP/TruhWLiHnzVtcSt Si9fTo3mDEJHWtHkbFUJV/L9QJUuQMngUS+cIeZsXAlwhSpscixPaXTofBVNLQO/zrIZbSz C57RYscha8iNAIJTrvF4wouP5iWJra1zLfH6Zw0N9sCttrPnoMB5+l8Ccu437JcCu59MyLz fOd9AYY4CzOHBYTHxWUOw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > I really doubt that the code in `follow-scroll-up' is broken. I didn't say so. > Follow-mode > is designed so that the rearrangement of the other windows (the ones that > follow the selected window) occur in the post-command hook (to allow > Follow-mode to act upon all Emacs commands, not only it's special > function). It appears that something has changed in the display engine, or > in the way that post-command-hook is called, that makes this mechanism > fail. This could also account for the difference we see when the function > is called via a key sequence as compared to via M-x. IIUC we'd have to find out when and where follow-mode expects the selected window to be a certain window and why this sometimes fails. So maybe you should try the change I suggested. > This is also the reason why reported this as a bug, rather than digging > into the code myself. However, I could try to add log code to Follow mode, > to check if I could try to figure out what is going on. Please do that. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 04:19:47 2013 Received: (at 15957) by debbugs.gnu.org; 25 Nov 2013 09:19:47 +0000 Received: from localhost ([127.0.0.1]:43480 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VksKY-0005v6-OK for submit@debbugs.gnu.org; Mon, 25 Nov 2013 04:19:47 -0500 Received: from mail-we0-f173.google.com ([74.125.82.173]:42044) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VksKW-0005um-6b for 15957@debbugs.gnu.org; Mon, 25 Nov 2013 04:19:45 -0500 Received: by mail-we0-f173.google.com with SMTP id t61so3510893wes.18 for <15957@debbugs.gnu.org>; Mon, 25 Nov 2013 01:19:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=+SVnFXHaMAH71HH2FHGmMJuM942nMKkTl56Cn0QaZ3o=; b=bRVB3kxiJ1qxxCi+cpXPg2abe+Rh/J2ahxOOGxn56PAiB4kuw9AnwGW5fnar0PvvOt Ib5bLMrGsPK+8D1AsdPmkomCMP+YJCKIEOgM+Bh/Xu2E1xRxU90WvxppWNWLyfczYzRi ktc39I/i9MNy26UaecDdoVY6uuOj5DoYhShA+dIQSJVxX+Hc9cWUgeKf7it7fg88Tora SWn6XhX9vqSMDK8/AXCpDEWdyK8ndRDRy1u8t8UsG9yRxbHqfvtIdXi8fixRXfym2WQz vvTfS8XW95gjwUtw8h0OHz3elQN81TIM/22yrfDVa3/IkxwYHt/fJybNC7NlOY+fvBlr Re9g== MIME-Version: 1.0 X-Received: by 10.180.208.49 with SMTP id mb17mr12787765wic.64.1385371178344; Mon, 25 Nov 2013 01:19:38 -0800 (PST) Received: by 10.216.124.76 with HTTP; Mon, 25 Nov 2013 01:19:38 -0800 (PST) In-Reply-To: <5291D098.10507@gmx.at> References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> Date: Mon, 25 Nov 2013 10:19:38 +0100 Message-ID: Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk From: Anders Lindgren To: martin rudalics Content-Type: multipart/alternative; boundary=001a11c37e30f7a56304ebfcdcd4 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15957 Cc: 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c37e30f7a56304ebfcdcd4 Content-Type: text/plain; charset=ISO-8859-1 Hi! I tried something similar to the code you suggested. The code I tried checked both `follow-scroll-up' and `follow-post-command-hook'. It appears as though the selected window is changed somewhere in the post-command hook. This, however, does not occur when I call the post-command hook as a plain function. Also, I noticed that an old Emacs trunk I had laying around worked correctly, so I have spent some time to do a binary search of the bzr archive and found out that this broke in revision 113753, with the following log message: revno: 113753 committer: Dmitry Antipov branch nick: trunk timestamp: Thu 2013-08-08 08:42:40 +0400 message: Do not reset window modification event counters excessively. These leftovers and poor man's tricky methods to catch extra redisplay's attention are no longer needed. * frame.c (set_menu_bar_lines_1): * minibuf.c (read_minibuf_unwind): * window.c (Fset_window_start, set_window_buffer, window_resize_apply) (grow_mini_window, shrink_mini_window, window_scroll_pixel_based) (window_scroll_line_based, Fset_window_configuration): * xdisp.c (redisplay_window): Do not reset last_modified and last_overlay_modified counters. I will continue to narrow down the problem in the post-command hook, I'll let you know when I'm done. Sincerely, Anders Lindgren On Sun, Nov 24, 2013 at 11:10 AM, martin rudalics wrote: > > I really doubt that the code in `follow-scroll-up' is broken. > > I didn't say so. > > > > Follow-mode > > is designed so that the rearrangement of the other windows (the ones that > > follow the selected window) occur in the post-command hook (to allow > > Follow-mode to act upon all Emacs commands, not only it's special > > function). It appears that something has changed in the display engine, > or > > in the way that post-command-hook is called, that makes this mechanism > > fail. This could also account for the difference we see when the function > > is called via a key sequence as compared to via M-x. > > IIUC we'd have to find out when and where follow-mode expects the > selected window to be a certain window and why this sometimes fails. So > maybe you should try the change I suggested. > > > > This is also the reason why reported this as a bug, rather than digging > > into the code myself. However, I could try to add log code to Follow > mode, > > to check if I could try to figure out what is going on. > > Please do that. > > Thanks, martin > --001a11c37e30f7a56304ebfcdcd4 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi!

I tried something similar to the co= de you suggested. The code I tried checked both `follow-scroll-up' and = `follow-post-command-hook'. It appears as though the selected window is= changed somewhere in the post-command hook. This, however, does not occur = when I call the post-command hook as a plain function.

Also, I noticed that an old Emacs trunk I had laying ar= ound worked correctly, so I have spent some time to do a binary search of t= he bzr archive and found out that this broke in revision=A0113753, with the= following log message:

revno: 113753

committer: Dmitry Antipov <dmantipov@yandex.ru>

branch nick: trunk

timestamp: Thu 2013-08-08 08:42:40 +0400

message:

=A0 Do not reset window modification event counters excessive= ly.

=A0 These leftovers and poor man's tricky methods to catc= h extra

=A0 redisplay's attention are no longer needed.

=A0 * frame.c (set_menu_bar_lines_1):

=A0 * minibuf.c (read_minibuf_unwind):

=A0 * window.c (Fset_window_start, set_window_buffer, window_= resize_apply)

=A0 (grow_mini_window, shrink_mini_window, window_scroll_pixe= l_based)

=A0 (window_scroll_line_based, Fset_window_configuration):

=A0 * xdisp.c (redisplay_window): Do not reset last_modified = and

=A0 last_overlay_modified counters.


=

I will continue to narrow down the problem in the post-comman= d hook, I'll let you know when I'm done.


<= p class=3D""> Sincerely,

=A0 =A0 Anders Lindgren




On Sun, Nov 24, 2013 at 11:10 AM, martin rudalics <rudalics@gmx.at><= /span> wrote:
> I really doubt that t= he code in `follow-scroll-up' is broken.

I didn't say so.


> Follow-mode
> is designed so that the rearrangement of the other windows (the ones t= hat
> follow the selected window) occur in the post-command hook (to allow > Follow-mode to act upon all Emacs commands, not only it's special<= br> > function). It appears that something has changed in the display engine= , or
> in the way that post-command-hook is called, that makes this mechanism=
> fail. This could also account for the difference we see when the funct= ion
> is called via a key sequence as compared to via M-x.

IIUC we'd have to find out when and where follow-mode expects the
selected window to be a certain window and why this sometimes fails. =A0So<= br> maybe you should try the change I suggested.


> This is also the reason why reported this as a bug, rather than diggin= g
> into the code myself. However, I could try to add log code to Follow m= ode,
> to check if I could try to figure out what is going on.

Please do that.

Thanks, martin

--001a11c37e30f7a56304ebfcdcd4-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 11:42:39 2013 Received: (at 15957) by debbugs.gnu.org; 25 Nov 2013 16:42:39 +0000 Received: from localhost ([127.0.0.1]:44772 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkzF8-0001ze-6V for submit@debbugs.gnu.org; Mon, 25 Nov 2013 11:42:38 -0500 Received: from mout.gmx.net ([212.227.17.21]:51728) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkzF5-0001zM-1g for 15957@debbugs.gnu.org; Mon, 25 Nov 2013 11:42:36 -0500 Received: from [62.47.62.195] ([62.47.62.195]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0LkxLZ-1VCkHg06Uf-00aixT for <15957@debbugs.gnu.org>; Mon, 25 Nov 2013 17:42:29 +0100 Message-ID: <52937DED.9070304@gmx.at> Date: Mon, 25 Nov 2013 17:42:21 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:R52vnh/ItwvKCnPTgtZ/FqaMHeej6EfP7htXJ27RoDFj26HtN4h P9IU0cxUOI/hrxeofK4lwHydEYvgsMMM/BWVRYQzgGEwhFO6ylQaOv1tailaIOGSIdmxilF BwMFG4pBgXCB58y5284imgjjvovhH5dF8CYsAjjJ58prJIrwiULdXdLmkXLY5KnaQEzeDzl M8ap5EpY28HiMv82pEAGg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: Dmitry Antipov , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Forwarding Anders Lindgren's mail to 15957@debbugs.gnu.org and Dmitry Antipov. > Hi! > > I believe that I have found the problem. In `follow-calc-win-end', there is > a call to `(window-end win t)'. The `t' means "compute the up-to-date > position > if it isn't already recorded." The return value from this function is > clearly incorrect. The fact that the wrong window is selected is simply a > consequence of this. > > In the older Emacs (up to bzr revision 113752), this seems to work > correctly. However, in the newer (starting from bzt revision 113753) this > is broken. > > You can verify this using the (somewhat crude) package I've attached below. > It adds logging to some Follow mode functions that triggers when you run a > special variant of the scroll command, which it binds to Ctrl-z. Once the > command has been executed, you can view the result by invoking > `check-follow-report-log'. > > As `window-end' is part of the display engine, which I have no knowledge > about, I hand it over to you to address the problem. > > Sincerely, > Anders Lindgren > > Ps. Below is the logs which I have recorded. > > Revision 113752: > > (Start #) > (Start (inside w-c-b) #) > (follow-calc-win-end #) > ( edges # (12 2 747 450)) > ( ht # 448) > ( last-line-pos # 3594) > ( Pos visible #) > ( end # 3632) > <------- Correct > ... > > Revision 113753: > > (Start #) > (Start (inside w-c-b) #) > (follow-calc-win-end #) > ( edges # (12 2 726 450)) > ( ht # 448) > ( last-line-pos # 3594) > ( Pos visible #) > ( end # 873) > <-------- Incorrect > > > > > > On Mon, Nov 25, 2013 at 10:19 AM, Anders Lindgren wrote: > >> Hi! >> >> I tried something similar to the code you suggested. The code I tried >> checked both `follow-scroll-up' and `follow-post-command-hook'. It appears >> as though the selected window is changed somewhere in the post-command >> hook. This, however, does not occur when I call the post-command hook as a >> plain function. >> >> Also, I noticed that an old Emacs trunk I had laying around worked >> correctly, so I have spent some time to do a binary search of the bzr >> archive and found out that this broke in revision 113753, with the >> following log message: >> >> revno: 113753 >> >> committer: Dmitry Antipov >> >> branch nick: trunk >> >> timestamp: Thu 2013-08-08 08:42:40 +0400 >> >> message: >> >> Do not reset window modification event counters excessively. >> >> These leftovers and poor man's tricky methods to catch extra >> >> redisplay's attention are no longer needed. >> >> * frame.c (set_menu_bar_lines_1): >> >> * minibuf.c (read_minibuf_unwind): >> >> * window.c (Fset_window_start, set_window_buffer, window_resize_apply) >> >> (grow_mini_window, shrink_mini_window, window_scroll_pixel_based) >> >> (window_scroll_line_based, Fset_window_configuration): >> >> * xdisp.c (redisplay_window): Do not reset last_modified and >> >> last_overlay_modified counters. >> >> >> I will continue to narrow down the problem in the post-command hook, I'll >> let you know when I'm done. >> >> >> Sincerely, >> >> Anders Lindgren >> >> >> >> >> On Sun, Nov 24, 2013 at 11:10 AM, martin rudalics wrote: >> >>>> I really doubt that the code in `follow-scroll-up' is broken. >>> I didn't say so. >>> >>> >>>> Follow-mode >>>> is designed so that the rearrangement of the other windows (the ones >>> that >>>> follow the selected window) occur in the post-command hook (to allow >>>> Follow-mode to act upon all Emacs commands, not only it's special >>>> function). It appears that something has changed in the display engine, >>> or >>>> in the way that post-command-hook is called, that makes this mechanism >>>> fail. This could also account for the difference we see when the >>> function >>>> is called via a key sequence as compared to via M-x. >>> IIUC we'd have to find out when and where follow-mode expects the >>> selected window to be a certain window and why this sometimes fails. So >>> maybe you should try the change I suggested. >>> >>> >>>> This is also the reason why reported this as a bug, rather than digging >>>> into the code myself. However, I could try to add log code to Follow >>> mode, >>>> to check if I could try to figure out what is going on. >>> Please do that. >>> >>> Thanks, martin >>> >> > From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 01:33:31 2013 Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 06:33:31 +0000 Received: from localhost ([127.0.0.1]:45333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlCDC-0001JD-Dc for submit@debbugs.gnu.org; Tue, 26 Nov 2013 01:33:30 -0500 Received: from forward5l.mail.yandex.net ([84.201.143.138]:54658) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlCD7-0001Ir-L9 for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 01:33:26 -0500 Received: from smtp3o.mail.yandex.net (smtp3o.mail.yandex.net [37.140.190.28]) by forward5l.mail.yandex.net (Yandex) with ESMTP id 88181C4110F; Tue, 26 Nov 2013 10:33:18 +0400 (MSK) Received: from smtp3o.mail.yandex.net (localhost [127.0.0.1]) by smtp3o.mail.yandex.net (Yandex) with ESMTP id 21BB51E07C9; Tue, 26 Nov 2013 10:33:18 +0400 (MSK) Received: from unknown (unknown [37.139.80.10]) by smtp3o.mail.yandex.net (nwsmtp/Yandex) with ESMTP id nkJS7CuUtN-XH2WWmFq; Tue, 26 Nov 2013 10:33:17 +0400 (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1385447597; bh=YBdvxiOFhlhUyocPEuo0fHeK7eaBWFD6mZgudlvW9bE=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=B7lMEj1p5Iv+vKp7XA7zI8dDCizEpLr0QLrd4p9ZagQlpiemsvaw3n7bIUTP+fB+v H40f+BE5d5+LI47q8PFWrFM00cTi3h+oNFd7G/bbDqHbIkSeQA+mC/hqYZeypCsJId R1zrvxfLcW0PmzfcJqab7xeWh8if/P3ZBrbnsWtY= Authentication-Results: smtp3o.mail.yandex.net; dkim=pass header.i=@yandex.ru Message-ID: <529440AD.6060505@yandex.ru> Date: Tue, 26 Nov 2013 10:33:17 +0400 From: Dmitry Antipov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: martin rudalics , Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> In-Reply-To: <52937DED.9070304@gmx.at> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 11/25/2013 08:42 PM, martin rudalics wrote: > Forwarding Anders Lindgren's mail to 15957@debbugs.gnu.org and Dmitry Antipov. > >> Hi! >> >> I believe that I have found the problem. In `follow-calc-win-end', there is >> a call to `(window-end win t)'. The `t' means "compute the up-to-date >> position >> if it isn't already recorded." The return value from this function is >> clearly incorrect. The fact that the wrong window is selected is simply a >> consequence of this. >> >> In the older Emacs (up to bzr revision 113752), this seems to work >> correctly. However, in the newer (starting from bzt revision 113753) this >> is broken. Hm...I just add debug printf() at the end of Fwindow_end, and see an identical output for 24.3 and r115239 for this simple example: ./src/emacs -Q -font 6x10 -geometry 200x65 C-h t M-x follow-delete-other-windows-and-split C-c . C-v So if someone has a elisp code that clearly shows that window-end is broken, please attach it to this bug at least. Dmitry From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 06:01:23 2013 Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 11:01:23 +0000 Received: from localhost ([127.0.0.1]:45439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlGOQ-00089A-V0 for submit@debbugs.gnu.org; Tue, 26 Nov 2013 06:01:23 -0500 Received: from mail-wi0-f180.google.com ([209.85.212.180]:60448) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlGOO-00088v-5q for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 06:01:21 -0500 Received: by mail-wi0-f180.google.com with SMTP id hm4so6841849wib.1 for <15957@debbugs.gnu.org>; Tue, 26 Nov 2013 03:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=cJsFBNuW7zhmJjX49teNGDgs7zmuFNUieqt08Gn5d0I=; b=zLxnqPlpgnWU9uyXu7sW/KVmjHz+wGRML1A0eboSeNQuEcGwK02QFoCppRHSOS9Qnm /Y2OBzT/r2GktQ9iBOQFn5HrRiHpNRhIpvRS6OKAoazvuHCZikGM1YQkCBsHQOsUWre+ hzKtSxoCHJIkYXVL7BdlsISUT+X4Zzc8ccoeladydPEtiYgqKLzU9XXVQK+XdOPOdLVF OzIi2aE/YckdxfHQkNRWnUqR2dSMNKO947ryJQBkSMTXIfUXrOzfozR0su+Mk5MB7glh +/r9Cv8laHhuMDdeMhQxbRNmSJ3RJqDKRNnbJ2TlilrV0hiPq6lRAMJ6BzR4LPXjHqbp /tMA== MIME-Version: 1.0 X-Received: by 10.194.193.4 with SMTP id hk4mr1103149wjc.71.1385463673794; Tue, 26 Nov 2013 03:01:13 -0800 (PST) Received: by 10.216.124.76 with HTTP; Tue, 26 Nov 2013 03:01:13 -0800 (PST) In-Reply-To: <529440AD.6060505@yandex.ru> References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> Date: Tue, 26 Nov 2013 12:01:13 +0100 Message-ID: Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk From: Anders Lindgren To: Dmitry Antipov Content-Type: multipart/mixed; boundary=047d7bb039462046a504ec12661c X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15957 Cc: martin rudalics , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bb039462046a504ec12661c Content-Type: multipart/alternative; boundary=047d7bb039462046a104ec12661a --047d7bb039462046a104ec12661a Content-Type: text/plain; charset=ISO-8859-1 Hi Dmitry! The problem only occurs under certain circumstances. `window-end' must called from a post-command hook and the command that started it must be bound to a key (not using M-x). Also, sometimes it seems to work correctly, sometimes not, like every second time. (Take "must" with a grain of salt, it might be possible to trigger the bug under other circumstances as well.) I have attached a piece of lisp code which basically is the follow-mode code plus log commands, so that you clearly can see the return value of different functions, including the call to `windows-end'. I'm sure it would be possible to cut down the code to a minimal, now when we know that it's `window-end' that returns the incorrect value. (The logs I referred to in the previous mails were generated by this package.) I'm not familiar with the bug tracking system, but feel free to add this code to it. In case you are not familiar with follow-mode, it is a package that creates the illusion that you have one large window spread out over several side-by-side windows, you can move between the windows using the normal cursor keys, and when you scroll one window, the others follow (hence the name "Follow mode"). Technically, this is accomplished by a using a post-command hook that performs all the repositioning, plus a handful of new function performing operations that didn't exist before (like scrolling X pages, where X equal the number of windows the buffer is shown in). Do you think that you have everything that you need to find and fix the bug, or is there anything else that I can help you with? Sincerely, Anders Lindgren On Tue, Nov 26, 2013 at 7:33 AM, Dmitry Antipov wrote: > On 11/25/2013 08:42 PM, martin rudalics wrote: > >> Forwarding Anders Lindgren's mail to 15957@debbugs.gnu.org and Dmitry >> Antipov. >> >> Hi! >>> >>> I believe that I have found the problem. In `follow-calc-win-end', there >>> is >>> a call to `(window-end win t)'. The `t' means "compute the up-to-date >>> position >>> if it isn't already recorded." The return value from this function is >>> clearly incorrect. The fact that the wrong window is selected is simply a >>> consequence of this. >>> >>> In the older Emacs (up to bzr revision 113752), this seems to work >>> correctly. However, in the newer (starting from bzt revision 113753) this >>> is broken. >>> >> > Hm...I just add debug printf() at the end of Fwindow_end, and see an > identical output for 24.3 and r115239 for this simple example: > > ./src/emacs -Q -font 6x10 -geometry 200x65 > C-h t > M-x follow-delete-other-windows-and-split > C-c . C-v > > So if someone has a elisp code that clearly shows that window-end is > broken, > please attach it to this bug at least. > > Dmitry > > > --047d7bb039462046a104ec12661a Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Dmitry!

The problem only occurs unde= r certain circumstances. `window-end' must called from a post-command h= ook and the command that started it must be bound to a key (not using M-x).= Also, sometimes it seems to work correctly, sometimes not, like every seco= nd time. (Take "must" with a grain of salt, it might be possible = to trigger the bug under other circumstances as well.)=A0

I have attached a piece of lisp code which basically is= the follow-mode code plus log commands, so that you clearly can see the re= turn value of different functions, including the call to `windows-end'.= I'm sure it would be possible to cut down the code to a minimal, now w= hen we know that it's `window-end' that returns the incorrect value= . (The logs I referred to in the previous mails were generated by this pack= age.) I'm not familiar with the bug tracking system, but feel free to a= dd this code to it.

In case you are not familiar with follow-mode, it is a = package that creates the illusion that you have one large window spread out= over several side-by-side windows, you can move between the windows using = the normal cursor keys, and when you scroll one window, the others follow (= hence the name "Follow mode"). Technically, this is accomplished = by a using a post-command hook that performs all the repositioning, plus a = handful of new function performing operations that didn't exist before = (like scrolling X pages, where X equal the number of windows the buffer is = shown in).

Do you think that you have everything that you need to = find and fix the bug, or is there anything else that I can help you with?

Sincerely,
=A0 =A0 Anders Lindgren


On Tue, Nov 26, 2013 at 7:33 AM, Dmitry Antipov = <dmantipov@yand= ex.ru> wrote:
On 11/25/2013 08:42 PM, martin rudalics wrote:
Forwarding Anders Lindgren's mail to 15957@debbugs.gnu.org and Dmitry Antipov.

Hi!

I believe that I have found the problem. In `follow-calc-win-end', ther= e is
a call to `(window-end win t)'. The `t' means "compute the up-= to-date
position
if it isn't already recorded." The return value from this function= is
clearly incorrect. The fact that the wrong window is selected is simply a consequence of this.

In the older Emacs (up to bzr revision 113752), this seems to work
correctly. However, in the newer (starting from bzt revision 113753) this is broken.

Hm...I just add debug printf() at the end of Fwindow_end, and see an
identical output for 24.3 and r115239 for this simple example:

./src/emacs -Q -font 6x10 -geometry 200x65
C-h t
M-x follow-delete-other-windows-and-split
C-c . C-v

So if someone has a elisp code that clearly shows that window-end is broken= ,
please attach it to this bug at least.

Dmitry



--047d7bb039462046a104ec12661a-- --047d7bb039462046a504ec12661c Content-Type: application/octet-stream; name="check-follow-scroll-bug.el" Content-Disposition: attachment; filename="check-follow-scroll-bug.el" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hoh0asi00 OzsgUXVpY2tuJ2RpcnR5IGZvbGxvdy1tb2RlIGRlYnVnIGxvZyBwYWNrYWdlLgoKKHJlcXVpcmUg J2ZvbGxvdykKCihkZWZ1biBteS13cmFwLWZvbGxvdy1zY3JvbGwtdXAgKCZvcHRpb25hbCBhcmcp CiAgKGludGVyYWN0aXZlICJQIikKICAoc2V0cSBteS1mMSAoc2VsZWN0ZWQtd2luZG93KSkKICAo Zm9sbG93LXNjcm9sbC11cCBhcmcpCiAgKHNldHEgbXktZjIgKHNlbGVjdGVkLXdpbmRvdykpKQoK OzsgVGhlIHByb2JsZW0gb2JseSBtYW5pZmVzdHMgaXRzZWxmIHdoZW4gYm91bmQgdG8gYSBrZXku CihnbG9iYWwtc2V0LWtleSAoa2JkICJDLXoiKSAnbXktd3JhcC1mb2xsb3ctc2Nyb2xsLXVwKQoK KGRlZnZhciBteS1wb3N0LWxvZyBuaWwpCihkZWZ2YXIgbXktcG9zdC1kby1sb2cgbmlsKQoKKGRl ZnVuIGNoZWNrLWZvbGxvdy1sb2cgKHdoYXQgJnJlc3QgZXh0cmEpCiAgKGlmIG15LXBvc3QtZG8t bG9nCiAgICAgIChzZXRxIG15LXBvc3QtbG9nIChjb25zIChjb25zIHdoYXQgKGNvbnMgKHNlbGVj dGVkLXdpbmRvdykgZXh0cmEpKSBteS1wb3N0LWxvZykpKSkKCihkZWZ1biBjaGVjay1mb2xsb3ct cmVwb3J0LWxvZyAoKQogIChpbnRlcmFjdGl2ZSkKICAod2l0aC1vdXRwdXQtdG8tdGVtcC1idWZm ZXIgIipGb2xsb3cgbG9nKiIKICAgIChkb2xpc3QgKHggKHJldmVyc2UgbXktcG9zdC1sb2cpKQog ICAgICAocHJpbmMgeCkKICAgICAgKHRlcnByaSkpKSkKCjs7IE1vZGlmaWVkIHRvIHN1cHBvcnQg bG9nZ2luZy4KKGRlZnVuIGZvbGxvdy1jYWxjLXdpbi1lbmQgKCZvcHRpb25hbCB3aW4pCiAgIkNh bGN1bGF0ZSB0aGUgZW5kIHBvc2l0aW9uIGZvciB3aW5kb3cgV0lOLgpSZXR1cm4gKEVORC1QT1Mg RU5ELU9GLUJVRkZFUikuCgpBY3R1YWxseSwgdGhlIHBvc2l0aW9uIHJldHVybmVkIGlzIHRoZSBz dGFydCBvZiB0aGUgbGluZSBhZnRlcgp0aGUgbGFzdCBmdWxseS12aXNpYmxlIGxpbmUgaW4gV0lO LiAgSWYgV0lOIGlzIG5pbCwgdGhlIHNlbGVjdGVkCndpbmRvdyBpcyB1c2VkLiIKICAoY2hlY2st Zm9sbG93LWxvZyAiZm9sbG93LWNhbGMtd2luLWVuZCIpCiAgKGxldCAoKHdpbiAob3Igd2luIChz ZWxlY3RlZC13aW5kb3cpKSkpCiAgICAobGV0ICgoZWRnZXMgKHdpbmRvdy1pbnNpZGUtcGl4ZWwt ZWRnZXMgd2luKSkpCiAgICAgIChjaGVjay1mb2xsb3ctbG9nICIgIGVkZ2VzIiBlZGdlcykKICAg ICAgKGxldCAoKGh0ICgtIChudGggMyBlZGdlcykgKG50aCAxIGVkZ2VzKSkpKQoJKGNoZWNrLWZv bGxvdy1sb2cgIiAgaHQiIGh0KQoJKGxldCAoKGxhc3QtbGluZS1wb3MgKHBvc24tcG9pbnQgKHBv c24tYXQteC15IDAgKDEtIGh0KSB3aW4pKSkpCgkgIChjaGVjay1mb2xsb3ctbG9nICIgIGxhc3Qt bGluZS1wb3MiIGxhc3QtbGluZS1wb3MpCgkgIChpZiAocG9zLXZpc2libGUtaW4td2luZG93LXAg bGFzdC1saW5lLXBvcyB3aW4pCgkgICAgICAocHJvZ24KCQkoY2hlY2stZm9sbG93LWxvZyAiICBQ b3MgdmlzaWJsZSIpCgkJKGxldCAoKGVuZCAod2luZG93LWVuZCB3aW4gdCkpKQoJCSAgKGNoZWNr LWZvbGxvdy1sb2cgIiAgZW5kIiBlbmQpCgkJICAobGlzdCBlbmQgKD0gZW5kIChwb2ludC1tYXgp KSkpKQoJICAgIChjaGVjay1mb2xsb3ctbG9nICIgIFBvcyBub3QgdmlzaWJsZSIpCgkgICAgKGxp c3QgbGFzdC1saW5lLXBvcyBuaWwpKSkpKSkpCgo7OyBNb2RpZmllZCB0byBzdXBwb3J0IGxvZ2dp bmcuCihkZWZ1biBmb2xsb3ctcG9zdC1jb21tYW5kLWhvb2sgKCkKICAiRW5zdXJlIHRoYXQgdGhl IHdpbmRvd3MgaW4gRm9sbG93IG1vZGUgYXJlIGFkamFjZW50IGFmdGVyIGVhY2ggY29tbWFuZC4i CiAgKHVubGVzcyAoaW5wdXQtcGVuZGluZy1wKQogICAgKGxldCAoKGZvbGxvdy1pbnNpZGUtcG9z dC1jb21tYW5kLWhvb2sgdCkKCSAgKHdpbiAoc2VsZWN0ZWQtd2luZG93KSkpCiAgICAgIDs7IFdv cmsgaW4gdGhlIHNlbGVjdGVkIHdpbmRvdywgbm90IGluIHRoZSBjdXJyZW50IGJ1ZmZlci4KICAg ICAgKHdpdGgtY3VycmVudC1idWZmZXIgKHdpbmRvdy1idWZmZXIgd2luKQoJKHVubGVzcyAoYW5k IChzeW1ib2xwIHRoaXMtY29tbWFuZCkKCQkgICAgIChnZXQgdGhpcy1jb21tYW5kICdmb2xsb3ct bW9kZS11c2UtY2FjaGUpKQoJICAoc2V0cSBmb2xsb3ctd2luZG93cy1zdGFydC1lbmQtY2FjaGUg bmlsKSkpCiAgICAgIChzZXRxIG15LXBvc3QtZG8tbG9nIChlcSB0aGlzLWNvbW1hbmQgJ215LXdy YXAtZm9sbG93LXNjcm9sbC11cCkpCiAgICAgIChpZiBteS1wb3N0LWRvLWxvZwoJICAoc2V0cSBt eS1wb3N0LWxvZyAnKCkpKQogICAgICAoY2hlY2stZm9sbG93LWFkanVzdC13aW5kb3cgd2luIChw b2ludCkpKSkpCgo7OyBTcGVjaWFsIHZlcnNpb24gb2YgYGZvbGxvdy1hZGp1c3Qtd2luZG93Jy4K KGRlZnVuIGNoZWNrLWZvbGxvdy1hZGp1c3Qtd2luZG93ICh3aW4gZGVzdCkKICA7OyBBZGp1c3Qg dGhlIHdpbmRvdyBXSU4gYW5kIGl0cyBmb2xsb3dlcnMuCiAgKGNoZWNrLWZvbGxvdy1sb2cgIlN0 YXJ0IikKICAod2l0aC1jdXJyZW50LWJ1ZmZlciAod2luZG93LWJ1ZmZlciB3aW4pCiAgICAoY2hl Y2stZm9sbG93LWxvZyAiU3RhcnQgKGluc2lkZSB3LWMtYikiKQogICAgKHdoZW4gKGFuZCBmb2xs b3ctbW9kZQoJICAgICAgIChub3QgKHdpbmRvdy1taW5pYnVmZmVyLXAgd2luKSkpCjsgICAgICAo Y2hlY2stZm9sbG93LWxvZyAid2luZG93LXN0YXJ0IiAod2luZG93LXN0YXJ0IChjYXIgKGZvbGxv dy1hbGwtZm9sbG93ZXJzKSkpKQo7ICAgICAgKGNoZWNrLWZvbGxvdy1sb2cgIndpbmRvdy1lbmQi ICh3aW5kb3ctZW5kIChjYXIgKGZvbGxvdy1hbGwtZm9sbG93ZXJzKSkpKQo7ICAgICAgKGNoZWNr LWZvbGxvdy1sb2cgImZvbGxvdy1jYWxjLXdpbi1lbmQiIChmb2xsb3ctY2FsYy13aW4tZW5kIChj YXIgKGZvbGxvdy1hbGwtZm9sbG93ZXJzKSkpKQo7ICAgICAgKGNoZWNrLWZvbGxvdy1sb2cgImZv bGxvdy13aW5kb3dzLXN0YXJ0LWVuZCIgKGZvbGxvdy13aW5kb3dzLXN0YXJ0LWVuZCAoZm9sbG93 LWFsbC1mb2xsb3dlcnMpKSkKICAgICAgKGxldCogKCh3aW5kb3dzIChmb2xsb3ctYWxsLWZvbGxv d2VycyB3aW4pKQoJICAgICAod2luLXN0YXJ0LWVuZCAocHJvZ24KCQkJICAgICAgKGZvbGxvdy11 cGRhdGUtd2luZG93LXN0YXJ0IChjYXIgd2luZG93cykpCgkJCSAgICAgIChmb2xsb3ctd2luZG93 cy1zdGFydC1lbmQgd2luZG93cykpKQoJICAgICAoYWxpZ25lZCAoZm9sbG93LXdpbmRvd3MtYWxp Z25lZC1wIHdpbi1zdGFydC1lbmQpKQoJICAgICAodmlzaWJsZSAoZm9sbG93LXBvcy12aXNpYmxl IGRlc3Qgd2luIHdpbi1zdGFydC1lbmQpKQoJICAgICBzZWxlY3RlZC13aW5kb3ctdXAtdG8tZGF0 ZSkKCShjaGVjay1mb2xsb3ctbG9nICJWaXNpYmxlIiB2aXNpYmxlKQoJKGNoZWNrLWZvbGxvdy1s b2cgIndpbi1zdGFydC1lbmQiIHdpbi1zdGFydC1lbmQpCgkodW5sZXNzIChhbmQgYWxpZ25lZCB2 aXNpYmxlKQoJICAoc2V0cSBmb2xsb3ctd2luZG93cy1zdGFydC1lbmQtY2FjaGUgbmlsKSkKCgko Y2hlY2stZm9sbG93LWxvZyAiQmVmb3JlIGludGVybmFsLWZvcmVjZS1yZWRpc3BsYXkgY2hlY2si KQoJOzsgU2VsZWN0IGEgd2luZG93IHRvIGRpc3BsYXkgcG9pbnQuCgkodW5sZXNzIGZvbGxvdy1p bnRlcm5hbC1mb3JjZS1yZWRpc3BsYXkKCSAgKGlmIChlcSBkZXN0IChwb2ludC1tYXgpKQoJICAg ICAgOzsgQmUgY2FyZWZ1bCBhdCBwb2ludC1tYXg6IHRoZSBkaXNwbGF5IGNhbiBiZSBhbGlnbmVk CgkgICAgICA7OyB3aGlsZSBERVNUIGNhbiBiZSB2aXNpYmxlIGluIHNldmVyYWwgd2luZG93cy4K CSAgICAgIChjb25kCgkgICAgICAgOzsgU2VsZWN0IHRoZSBjdXJyZW50IHdpbmRvdywgYnV0IG9u bHkgd2hlbiB0aGUgZGlzcGxheQoJICAgICAgIDs7IGlzIGNvcnJlY3QuIChXaGVuIGluc2VydGlu ZyBjaGFyYWN0ZXJzIGluIGEgdGFpbAoJICAgICAgIDs7IHdpbmRvdywgdGhlIGRpc3BsYXkgaXMg bm90IGNvcnJlY3QsIGFzIHRoZXkgYXJlCgkgICAgICAgOzsgc2hvd24gdHdpY2UuKQoJICAgICAg IDs7CgkgICAgICAgOzsgTmV2ZXIgc3RpY2sgdG8gdGhlIGN1cnJlbnQgd2luZG93IGFmdGVyIGEg ZGVsZXRpb24uCgkgICAgICAgOzsgT3RoZXJ3aXNlLCB3aGVuIHR5cGluZyBgREVMJyBpbiBhIHdp bmRvdyBzaG93aW5nCgkgICAgICAgOzsgb25seSB0aGUgZW5kIG9mIHRoZSBmaWxlLCBhIGNoYXJh Y3RlciB3b3VsZCBiZQoJICAgICAgIDs7IHJlbW92ZWQgZnJvbSB0aGUgd2luZG93IGFib3ZlLCB3 aGljaCBpcyB2ZXJ5CgkgICAgICAgOzsgdW5pbnR1aXRpdmUuCgkgICAgICAgKChhbmQgdmlzaWJs ZQoJCSAgICAgYWxpZ25lZAoJCSAgICAgKG5vdCAobWVtcSB0aGlzLWNvbW1hbmQKCQkJCScoYmFj a3dhcmQtZGVsZXRlLWNoYXIKCQkJCSAgZGVsZXRlLWJhY2t3YXJkLWNoYXIKCQkJCSAgYmFja3dh cmQtZGVsZXRlLWNoYXItdW50YWJpZnkKCQkJCSAga2lsbC1yZWdpb24pKSkpCgkJKGNoZWNrLWZv bGxvdy1sb2cgIkNhc2UgMSIpCgkJKGZvbGxvdy1kZWJ1Zy1tZXNzYWdlICJNYXg6IHNhbWUiKSkK CSAgICAgICA7OyBJZiB0aGUgZW5kIGlzIHZpc2libGUsIGFuZCB0aGUgd2luZG93IGRvZXNuJ3QK CSAgICAgICA7OyBzZWVtcyBsaWtlIGl0IGp1c3QgaGFzIGJlZW4gbW92ZWQsIHNlbGVjdCBpdC4K CSAgICAgICAoKGZvbGxvdy1zZWxlY3QtaWYtZW5kLXZpc2libGUgd2luLXN0YXJ0LWVuZCkKCQko Y2hlY2stZm9sbG93LWxvZyAiQ2FzZSAyIikKCQkoZm9sbG93LWRlYnVnLW1lc3NhZ2UgIk1heDog ZW5kIHZpc2libGUiKQoJCShzZXRxIHZpc2libGUgdCBhbGlnbmVkIG5pbCkKCQkoZ290by1jaGFy IGRlc3QpKQoJICAgICAgIDs7IEp1c3Qgc2hvdyB0aGUgZW5kLi4uCgkgICAgICAgKHQKCQkoY2hl Y2stZm9sbG93LWxvZyAiQ2FzZSAzIikKCQkoZm9sbG93LWRlYnVnLW1lc3NhZ2UgIk1heDogZGVm YXVsdCIpCgkJKHNlbGVjdC13aW5kb3cgKGNhciAobGFzdCB3aW5kb3dzKSkpCgkJKGdvdG8tY2hh ciBkZXN0KQoJCShzZXRxIHZpc2libGUgbmlsIGFsaWduZWQgbmlsKSkpCgoJICAgIDs7IFdlJ3Jl IG5vdCBhdCB0aGUgZW5kLCBoZXJlIGxpZmUgaXMgbXVjaCBzaW1wbGVyLgoJICAgIChjb25kCgkg ICAgIDs7IFRoaXMgaXMgdGhlIG5vcm1hbCBjYXNlIQoJICAgICA7OyBJdCBzaG91bGQgYmUgb3B0 aW1pemVkIGZvciBzcGVlZC4KCSAgICAgKChhbmQgdmlzaWJsZSBhbGlnbmVkKQoJICAgICAgKGNo ZWNrLWZvbGxvdy1sb2cgIkNhc2UgNCIpCgkgICAgICAoZm9sbG93LWRlYnVnLW1lc3NhZ2UgInNh bWUiKSkKCSAgICAgOzsgUGljayBhIHBvc2l0aW9uIGluIGFueSB3aW5kb3cuICBJZiB0aGUgZGlz cGxheSBpcyBvaywKCSAgICAgOzsgdGhpcyBwaWNrcyB0aGUgYGNvcnJlY3QnIHdpbmRvdy4KCSAg ICAgKChmb2xsb3ctc2VsZWN0LWlmLXZpc2libGUgZGVzdCB3aW4tc3RhcnQtZW5kKQoJICAgICAg KGNoZWNrLWZvbGxvdy1sb2cgIkNhc2UgNSIpCgkgICAgICAoZm9sbG93LWRlYnVnLW1lc3NhZ2Ug InZpc2libGUiKQoJICAgICAgKGdvdG8tY2hhciBkZXN0KQoJICAgICAgOzsgUGVyZm9ybSByZWRp c3BsYXksIGluIGNhc2UgbGluZSBpcyBwYXJ0aWFsbHkgdmlzaWJsZS4KCSAgICAgIChzZXRxIHZp c2libGUgbmlsKSkKCSAgICAgOzsgTm90IHZpc2libGUgYW55d2hlcmUgZWxzZSwgbGV0cyBwaWNr IHRoaXMgb25lLgoJICAgICAodmlzaWJsZQoJICAgICAgKGNoZWNrLWZvbGxvdy1sb2cgIkNhc2Ug NiIpCgkgICAgICAoZm9sbG93LWRlYnVnLW1lc3NhZ2UgInZpc2libGUgaW4gc2VsZWN0ZWQuIikp CgkgICAgIDs7IElmIERFU1QgaXMgYmVmb3JlIHRoZSBmaXJzdCB3aW5kb3cgc3RhcnQsIHNlbGVj dCB0aGUKCSAgICAgOzsgZmlyc3Qgd2luZG93LgoJICAgICAoKDwgZGVzdCAobnRoIDEgKGNhciB3 aW4tc3RhcnQtZW5kKSkpCgkgICAgICAoY2hlY2stZm9sbG93LWxvZyAiQ2FzZSA3IikKCSAgICAg IChmb2xsb3ctZGVidWctbWVzc2FnZSAiYmVmb3JlIGZpcnN0IikKCSAgICAgIChzZWxlY3Qtd2lu ZG93IChjYXIgd2luZG93cykpCgkgICAgICAoZ290by1jaGFyIGRlc3QpCgkgICAgICAoc2V0cSB2 aXNpYmxlIG5pbCBhbGlnbmVkIG5pbCkpCgkgICAgIDs7IElmIHdlIGNhbiBwb3NpdGlvbiB0aGUg Y3Vyc29yIHdpdGhvdXQgbW92aW5nIHRoZSBmaXJzdAoJICAgICA7OyB3aW5kb3csIGRvIGl0LiBU aGlzIGlzIHRoZSBjYXNlIHRoYXQgY2F0Y2hlcyBgUkVUJyBhdAoJICAgICA7OyB0aGUgYm90dG9t IG9mIGEgd2luZG93LgoJICAgICAoKGZvbGxvdy1zZWxlY3QtaWYtdmlzaWJsZS1mcm9tLWZpcnN0 IGRlc3Qgd2luZG93cykKCSAgICAgIChjaGVjay1mb2xsb3ctbG9nICJDYXNlIDciKQoJICAgICAg KGZvbGxvdy1kZWJ1Zy1tZXNzYWdlICJCZWxvdyBmaXJzdCIpCgkgICAgICAoc2V0cSB2aXNpYmxl IHQgYWxpZ25lZCB0KSkKCSAgICAgOzsgTm9uZSBvZiB0aGUgYWJvdmUuICBTdGljayB0byB0aGUg c2VsZWN0ZWQgd2luZG93LgoJICAgICAodAoJICAgICAgKGNoZWNrLWZvbGxvdy1sb2cgIkNhc2Ug OCIpCgkgICAgICAoZm9sbG93LWRlYnVnLW1lc3NhZ2UgIk5vbmUiKQoJICAgICAgKHNldHEgdmlz aWJsZSBuaWwgYWxpZ25lZCBuaWwpKSkpCgoJICAoY2hlY2stZm9sbG93LWxvZyAiQmVmb3JlIHNl bGVjdGVkIHdpbmRvdyBjaGVjayIpCgkgIDs7IElmIGEgbmV3IHdpbmRvdyB3YXMgc2VsZWN0ZWQs IG1ha2Ugc3VyZSB0aGF0IHRoZSBvbGQgaXMKCSAgOzsgbm90IHNjcm9sbGVkIHdoZW4gdGhlIHBv aW50IGlzIG91dHNpZGUgdGhlIHdpbmRvdy4KCSAgKHVubGVzcyAoZXEgd2luIChzZWxlY3RlZC13 aW5kb3cpKQoJICAgIChsZXQgKChwICh3aW5kb3ctcG9pbnQgd2luKSkpCgkgICAgICAoc2V0LXdp bmRvdy1zdGFydCB3aW4gKHdpbmRvdy1zdGFydCB3aW4pIG5pbCkKCSAgICAgIChzZXQtd2luZG93 LXBvaW50IHdpbiBwKSkpKQoKCSh1bmxlc3MgdmlzaWJsZQoJICA7OyBJZiBwb2ludCBtYXkgbm90 IGJlIHZpc2libGUgaW4gdGhlIHNlbGVjdGVkIHdpbmRvdywKCSAgOzsgcGVyZm9ybSBhIHJlZGlz cGxheTsgdGhpcyBlbnN1cmVzIHNjcm9sbGluZy4KCSAgKGxldCAoKG9wb2ludCAocG9pbnQpKSkK CSAgICAocmVkaXNwbGF5KQoJICAgIDs7IElmIHRoaXMgYHJlZGlzcGxheScgbW92ZWQgcG9pbnQs IHdlIGdvdCBjbG9iYmVyZWQgYnkgYQoJICAgIDs7IHByZXZpb3VzIGNhbGwgdG8gYHNldC13aW5k b3ctc3RhcnQnLiAgVHJ5IGFnYWluLgoJICAgICh3aGVuICgvPSAocG9pbnQpIG9wb2ludCkKCSAg ICAgIChnb3RvLWNoYXIgb3BvaW50KQoJICAgICAgKHJlZGlzcGxheSkpKQoKCSAgKHNldHEgc2Vs ZWN0ZWQtd2luZG93LXVwLXRvLWRhdGUgdCkKCSAgKGNoZWNrLWZvbGxvdy1sb2cgIkFBQSIpCgoJ ICAoZm9sbG93LWF2b2lkLXRhaWwtcmVjZW50ZXIpCgkgIChzZXRxIHdpbi1zdGFydC1lbmQgKGZv bGxvdy13aW5kb3dzLXN0YXJ0LWVuZCB3aW5kb3dzKQoJCWZvbGxvdy13aW5kb3dzLXN0YXJ0LWVu ZC1jYWNoZSBuaWwKCQlhbGlnbmVkIG5pbCkpCgoJOzsgTm93IHJlZHJhdyB0aGUgd2luZG93cyBh cm91bmQgdGhlIHNlbGVjdGVkIHdpbmRvdy4KCShjaGVjay1mb2xsb3ctbG9nICJCQkIiKQoJKHVu bGVzcyAoYW5kIChub3QgZm9sbG93LWludGVybmFsLWZvcmNlLXJlZGlzcGxheSkKCQkgICAgIChv ciBhbGlnbmVkCgkJCSAoZm9sbG93LXdpbmRvd3MtYWxpZ25lZC1wIHdpbi1zdGFydC1lbmQpKQoJ CSAgICAgKGZvbGxvdy1wb2ludC12aXNpYmxlLWFsbC13aW5kb3dzLXAgd2luLXN0YXJ0LWVuZCkp CgkgIChzZXRxIGZvbGxvdy1pbnRlcm5hbC1mb3JjZS1yZWRpc3BsYXkgbmlsKQoJICAoZm9sbG93 LXJlZGlzcGxheSB3aW5kb3dzIChzZWxlY3RlZC13aW5kb3cpCgkJCSAgICBzZWxlY3RlZC13aW5k b3ctdXAtdG8tZGF0ZSkKCSAgKHNldHEgd2luLXN0YXJ0LWVuZCAoZm9sbG93LXdpbmRvd3Mtc3Rh cnQtZW5kIHdpbmRvd3MpCgkJZm9sbG93LXdpbmRvd3Mtc3RhcnQtZW5kLWNhY2hlIG5pbCkKCSAg OzsgVGhlIHBvaW50IGNhbiBlbmRzIHVwIGluIGFub3RoZXIgd2luZG93IHdoZW4gREVTVCBpcyBh dAoJICA7OyB0aGUgYmVnaW5uaW5nIG9mIHRoZSBidWZmZXIgYW5kIHRoZSBzZWxlY3RlZCB3aW5k b3cgaXMKCSAgOzsgbm90IHRoZSBmaXJzdC4gIEl0IGNhbiBhbHNvIGhhcHBlbiB3aGVuIGxvbmcg bGluZXMgYXJlCgkgIDs7IHVzZWQgYW5kIHRoZXJlIGlzIGEgYmlnIGRpZmZlcmVuY2UgYmV0d2Vl biB0aGUgd2lkdGggb2YKCSAgOzsgdGhlIHdpbmRvd3MuICAoV2hlbiBzY3JvbGxpbmcgb25lIGxp bmUgaW4gYSB3aWRlIHdpbmRvdwoJICA7OyB3aGljaCB3aWxsIGNhdXNlIGEgbW92ZSBsYXJnZXIg dGhhdCBhbiBlbnRpcmUgc21hbGwKCSAgOzsgd2luZG93LikKCSAgKHVubGVzcyAoZm9sbG93LXBv cy12aXNpYmxlIGRlc3Qgd2luIHdpbi1zdGFydC1lbmQpCgkgICAgKGZvbGxvdy1zZWxlY3QtaWYt dmlzaWJsZSBkZXN0IHdpbi1zdGFydC1lbmQpCgkgICAgKGdvdG8tY2hhciBkZXN0KSkpCgoJKGNo ZWNrLWZvbGxvdy1sb2cgIkNDQyIpCgoJOzsgSWYgdGhlIHJlZ2lvbiBpcyB2aXNpYmxlLCBtYWtl IGl0IGxvb2sgZ29vZCB3aGVuIHNwYW5uaW5nCgk7OyBtdWx0aXBsZSB3aW5kb3dzLgoKCTs7IEZJ WE1FOiBXaHkgbm90IHVzZSBgdXNlLXJlZ2lvbi1wJyBoZXJlPwoJKHdoZW4gKHJlZ2lvbi1hY3Rp dmUtcCkKCSAgKGZvbGxvdy1tYXhpbWl6ZS1yZWdpb24KCSAgIChzZWxlY3RlZC13aW5kb3cpIHdp bmRvd3Mgd2luLXN0YXJ0LWVuZCkpKQoKICAgICAgKGNoZWNrLWZvbGxvdy1sb2cgIkRERCIpCiAg ICAgIDs7IFdoZXRoZXIgb3Igbm90IHRoZSBidWZmZXIgd2FzIGluIGZvbGxvdyBtb2RlLCB1cGRh dGUgd2luZG93cwogICAgICA7OyBkaXNwbGF5aW5nIHRoZSB0YWlsIHNvIHRoYXQgRW1hY3Mgd29u J3QgcmVjZW50ZXIgdGhlbS4KICAgICAgKGZvbGxvdy1hdm9pZC10YWlsLXJlY2VudGVyKSkKICAg IChjaGVjay1mb2xsb3ctbG9nICJFbmQgKGluc2lkZSB3LWMtYikiKSkKICAoY2hlY2stZm9sbG93 LWxvZyAiRW5kIikpCg== --047d7bb039462046a504ec12661c-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 09:13:04 2013 Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 14:13:04 +0000 Received: from localhost ([127.0.0.1]:45579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlJNw-0005ip-2c for submit@debbugs.gnu.org; Tue, 26 Nov 2013 09:13:04 -0500 Received: from mout.gmx.net ([212.227.15.18]:56760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlJNt-0005iI-7d for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 09:13:02 -0500 Received: from [62.47.53.240] ([62.47.53.240]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0Lu874-1VbrCS3Ty2-011Qfv for <15957@debbugs.gnu.org>; Tue, 26 Nov 2013 15:12:55 +0100 Message-ID: <5294AC5D.3050602@gmx.at> Date: Tue, 26 Nov 2013 15:12:45 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YpJuRAVVnt/jXL38CS4/qh5qMR0oyegu3bmo/3/IlkWYdS01lZD 00mOEQjIg9jYsXhnOieEQqF8Y11yvYEsKcTmWswsKtb4smR/52+KeW3LnugHjfvNONKl370 odzrKF543UXkjPLm4mWk/FGVXdXo3aOtCtvrSA7xpw2O6oiA5secLPHxceLtLi6j8G5UMR6 rNTqTKkOGdZQsYKvCkwHA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: Dmitry Antipov , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > The problem only occurs under certain circumstances. `window-end' must > called from a post-command hook and the command that started it must be > bound to a key (not using M-x). Also, sometimes it seems to work correctly, > sometimes not, like every second time. (Take "must" with a grain of salt, > it might be possible to trigger the bug under other circumstances as well.) From what you found out so far I suppose that these changes * window.c (window_scroll_pixel_based) (window_scroll_line_based): Do not reset last_modified and last_overlay_modified counters. are responsible. Could you try to resetting window_end_valid in window_scroll like === modified file 'src/window.c' --- src/window.c 2013-11-06 18:41:31 +0000 +++ src/window.c 2013-11-26 14:07:05 +0000 @@ -4286,6 +4286,7 @@ else window_scroll_line_based (window, n, whole, noerror); + XWINDOW (window)->window_end_valid = 0; immediate_quit = 0; } and see what happens? martin From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 09:25:58 2013 Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 14:25:58 +0000 Received: from localhost ([127.0.0.1]:45608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlJaP-00063R-DD for submit@debbugs.gnu.org; Tue, 26 Nov 2013 09:25:58 -0500 Received: from mail-we0-f174.google.com ([74.125.82.174]:50610) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlJaM-00063A-6S for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 09:25:55 -0500 Received: by mail-we0-f174.google.com with SMTP id q58so5358840wes.5 for <15957@debbugs.gnu.org>; Tue, 26 Nov 2013 06:25:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=UVRL8PizRFgjOt9ShKm+l6VD/QRa6DbvipFqPoe6qSU=; b=kbPceM0OGhgznuXTbaZtuaPhrkz5pKBM77UpLvmelAHX9ICCckG1IgtoavhTGXo0tZ 5N7f769fvH134BI9dsupoKlYJRb/jN92hqIspjeGXdMmbWsRCNw8el4HBsgv9d8zx3VG dpdshJGUeq4B+pEWeFPO3yGd9WmlEVDcYheTv0tkibyCaPR0z/OcxX6IA73h0GHxmphm MXlqSgecDWTsiu5Kx9KCCiZl3LXJ3J5+0QkVgchE8bBn+Fuafwf2QPN2/gNVTiq2UNoF DtlSxnmECxaAJjedF5AgN5zyN8i1Z8neAfxDHZxb+s5Y6Mh5IAW53dSH8amR816p6Q9a rjrQ== MIME-Version: 1.0 X-Received: by 10.180.208.49 with SMTP id mb17mr18452345wic.64.1385475948100; Tue, 26 Nov 2013 06:25:48 -0800 (PST) Received: by 10.216.124.76 with HTTP; Tue, 26 Nov 2013 06:25:48 -0800 (PST) In-Reply-To: <5294AC5D.3050602@gmx.at> References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> <5294AC5D.3050602@gmx.at> Date: Tue, 26 Nov 2013 15:25:48 +0100 Message-ID: Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk From: Anders Lindgren To: martin rudalics Content-Type: multipart/alternative; boundary=001a11c37e30bb401704ec154189 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15957 Cc: Dmitry Antipov , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c37e30bb401704ec154189 Content-Type: text/plain; charset=ISO-8859-1 Hi! Unfortunately, the problem is still there, as far as I can see. -- Anders On Tue, Nov 26, 2013 at 3:12 PM, martin rudalics wrote: > > The problem only occurs under certain circumstances. `window-end' must > > called from a post-command hook and the command that started it must be > > bound to a key (not using M-x). Also, sometimes it seems to work > correctly, > > sometimes not, like every second time. (Take "must" with a grain of salt, > > it might be possible to trigger the bug under other circumstances as > well.) > > From what you found out so far I suppose that these changes > > * window.c (window_scroll_pixel_based) > > (window_scroll_line_based): Do not reset last_modified and > > last_overlay_modified counters. > > are responsible. Could you try to resetting window_end_valid in > window_scroll like > > === modified file 'src/window.c' > --- src/window.c 2013-11-06 18:41:31 +0000 > +++ src/window.c 2013-11-26 14:07:05 +0000 > @@ -4286,6 +4286,7 @@ > else > window_scroll_line_based (window, n, whole, noerror); > > + XWINDOW (window)->window_end_valid = 0; > immediate_quit = 0; > } > > and see what happens? > > martin > --001a11c37e30bb401704ec154189 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi!

Unfortunately, the problem is still= there, as far as I can see.

=A0 =A0 =A0-- Anders<= /div>


On= Tue, Nov 26, 2013 at 3:12 PM, martin rudalics <rudalics@gmx.at> wrote:
> The problem only occu= rs under certain circumstances. `window-end' must
> called from a post-command hook and the command that started it must b= e
> bound to a key (not using M-x). Also, sometimes it seems to work corre= ctly,
> sometimes not, like every second time. (Take "must" with a g= rain of salt,
> it might be possible to trigger the bug under other circumstances as w= ell.)

>From what you found out so far I suppose that these changes

=A0 * window.c (window_scroll_pixel_based)

=A0 (window_scroll_line_based): Do not reset last_modified and

=A0 last_overlay_modified counters.

are responsible. =A0Could you try to resetting window_end_valid in
window_scroll like

=3D=3D=3D modified file 'src/window.c'
--- src/window.c =A0 =A0 =A0 =A02013-11-06 18:41:31 +0000
+++ src/window.c =A0 =A0 =A0 =A02013-11-26 14:07:05 +0000
@@ -4286,6 +4286,7 @@
=A0 =A0else
=A0 =A0 =A0window_scroll_line_based (window, n, whole, noerror);

+ =A0XWINDOW (window)->window_end_valid =3D 0;
=A0 =A0immediate_quit =3D 0;
=A0}

and see what happens?

martin

--001a11c37e30bb401704ec154189-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 11:19:56 2013 Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 16:19:56 +0000 Received: from localhost ([127.0.0.1]:46171 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlLMi-0000ZY-Gj for submit@debbugs.gnu.org; Tue, 26 Nov 2013 11:19:56 -0500 Received: from mout.gmx.net ([212.227.17.21]:51519) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlLMf-0000ZH-IO for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 11:19:54 -0500 Received: from [62.47.53.240] ([62.47.53.240]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0Ln897-1V8zwk0siT-00hKr9 for <15957@debbugs.gnu.org>; Tue, 26 Nov 2013 17:19:47 +0100 Message-ID: <5294CA19.7020605@gmx.at> Date: Tue, 26 Nov 2013 17:19:37 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> <5294AC5D.3050602@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:/J95q4XdCB2ynbY8z6TcSikvNIu9ncOdb9xd+2r4m2TKgCN9K3o mFo6lhVirvSC9hWXLIBHqRWTJ2jxk4Yjq1cTBOrb4PrEAptKaXwzWxjiKr9aZDtHG7L70m4 sxPxLXEJRM/+4nyR8WdLK2kfeokLOEfd3HhDptULkFv3MrcHYu+nnRWIYQOWsWv4e7QdC/f yzXTakCuDGSGRBOHtI2BA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: Dmitry Antipov , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > Unfortunately, the problem is still there, as far as I can see. Too bad. And if you applied the below? martin === modified file 'src/window.c' --- src/window.c 2013-11-06 18:41:31 +0000 +++ src/window.c 2013-11-26 16:14:03 +0000 @@ -1574,6 +1574,7 @@ if (NILP (noforce)) w->force_start = 1; w->update_mode_line = 1; + w->window_end_valid = 0; if (w != XWINDOW (selected_window)) /* Enforce full redisplay. FIXME: make it more selective. */ windows_or_buffers_changed = 26; @@ -4286,6 +4287,7 @@ else window_scroll_line_based (window, n, whole, noerror); + XWINDOW (window)->window_end_valid = 0; immediate_quit = 0; } From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:03:47 2013 Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 17:03:47 +0000 Received: from localhost ([127.0.0.1]:46199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlM39-0002ml-Az for submit@debbugs.gnu.org; Tue, 26 Nov 2013 12:03:47 -0500 Received: from mail-wi0-f169.google.com ([209.85.212.169]:55520) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlM36-0002mW-PJ for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 12:03:45 -0500 Received: by mail-wi0-f169.google.com with SMTP id hm6so6169935wib.0 for <15957@debbugs.gnu.org>; Tue, 26 Nov 2013 09:03:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7gl91aiSpkRctQbuyIXt6mQX0ik+vvmzScHyZG8c0s4=; b=e/YjHlltNdtKtrV5NAIHOHWW1+3Bt65JL+CSdVcFZSNSgmYEHrSQHZhhl5/razG1P8 J2vmf96elovB0qJkEQsnTGj7hMuB3K4XMh3qnU6hijxnoZaNZ2BnjcgqvYj9XyipjTO9 XVFO34pJIUiEosGMFsxOckxh21CYTyLmaNyXE/1/NnKloSrwddDh7or+PolHT2GwcpXS P1rMiDMfBBscvKWn4cBwnu2e8SKGnCA89USf2bhRNlMPmSWRmmax7aQIXMqK4RkyVkFN AtydHz+jjNegsjR5Ho1oH33oDVLvEg6ON36zmpgB0WBvsmsD8YmpItvmEJRU6m4a1X9i kvyA== MIME-Version: 1.0 X-Received: by 10.194.109.68 with SMTP id hq4mr27876929wjb.12.1385485418764; Tue, 26 Nov 2013 09:03:38 -0800 (PST) Received: by 10.216.124.76 with HTTP; Tue, 26 Nov 2013 09:03:38 -0800 (PST) In-Reply-To: <5294CA19.7020605@gmx.at> References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> <5294AC5D.3050602@gmx.at> <5294CA19.7020605@gmx.at> Date: Tue, 26 Nov 2013 18:03:38 +0100 Message-ID: Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk From: Anders Lindgren To: martin rudalics Content-Type: multipart/alternative; boundary=089e0102e6da3a212104ec177627 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15957 Cc: Dmitry Antipov , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e0102e6da3a212104ec177627 Content-Type: text/plain; charset=ISO-8859-1 YES!!! That did the trick! When it comes to the first patch you sent, I just realized that it do fix another problem I've experienced (but not yet reported). When scrolling with a simple C-v and follow-mode is enabled, the other window only followed every second time the command was issued. In other words, I think that both patches should be applied. Thanks a bunch, I really appreciate it! -- Anders On Tue, Nov 26, 2013 at 5:19 PM, martin rudalics wrote: > Unfortunately, the problem is still there, as far as I can see. >> > > Too bad. And if you applied the below? > > martin > > > > === modified file 'src/window.c' > --- src/window.c 2013-11-06 18:41:31 +0000 > +++ src/window.c 2013-11-26 16:14:03 +0000 > @@ -1574,6 +1574,7 @@ > if (NILP (noforce)) > w->force_start = 1; > w->update_mode_line = 1; > + w->window_end_valid = 0; > if (w != XWINDOW (selected_window)) > /* Enforce full redisplay. FIXME: make it more selective. */ > windows_or_buffers_changed = 26; > @@ -4286,6 +4287,7 @@ > > else > window_scroll_line_based (window, n, whole, noerror); > > + XWINDOW (window)->window_end_valid = 0; > immediate_quit = 0; > } > > > > > --089e0102e6da3a212104ec177627 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
YES!!!

That did the trick!
When it comes to the first patch you sent, I just realized tha= t it do fix another problem I've experienced (but not yet reported). Wh= en scrolling with a simple C-v and follow-mode is enabled, the other window= only followed every second time the command was issued.

In other words, I think that both patches should be app= lied.

Thanks a bunch, I really appreciate it!

=A0 =A0 -- Anders


On Tue, Nov 26, 2013 at 5:19 PM, martin = rudalics <rudalics@gmx.at> wrote:
Unfortunately, the problem is still there, as far as I can see.

Too bad. =A0And if you applied the below?

martin



=3D=3D=3D modified file 'src/window.c'
--- src/window.c =A0 =A0 =A0 =A02013-11-06 18:41:31 +0000
+++ src/window.c =A0 =A0 =A0 =A02013-11-26 16:14:03 +0000
@@ -1574,6 +1574,7 @@
=A0 =A0if (NILP (noforce))
=A0 =A0 =A0w->force_start =3D 1;
=A0 =A0w->update_mode_line =3D 1;
+ =A0w->window_end_valid =3D 0;
=A0 =A0if (w !=3D XWINDOW (selected_window))
=A0 =A0 =A0/* Enforce full redisplay. =A0FIXME: make it more selective. =A0= */
=A0 =A0 =A0windows_or_buffers_changed =3D 26;
@@ -4286,6 +4287,7 @@

=A0 =A0else
=A0 =A0 =A0window_scroll_line_based (window, n, whole, noerror);

+ =A0XWINDOW (window)->window_end_valid =3D 0;
=A0 =A0immediate_quit =3D 0;
=A0}





--089e0102e6da3a212104ec177627-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 12:22:06 2013 Received: (at 15957) by debbugs.gnu.org; 26 Nov 2013 17:22:06 +0000 Received: from localhost ([127.0.0.1]:46222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlMKs-0003Gg-3W for submit@debbugs.gnu.org; Tue, 26 Nov 2013 12:22:06 -0500 Received: from mout.gmx.net ([212.227.17.20]:63030) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlMKp-0003G7-Qi for 15957@debbugs.gnu.org; Tue, 26 Nov 2013 12:22:04 -0500 Received: from [62.47.53.240] ([62.47.53.240]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0LkPBT-1VF2is25Qx-00cN0I for <15957@debbugs.gnu.org>; Tue, 26 Nov 2013 18:21:57 +0100 Message-ID: <5294D8AC.2070006@gmx.at> Date: Tue, 26 Nov 2013 18:21:48 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> <5294AC5D.3050602@gmx.at> <5294CA19.7020605@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:IvwtlGJpEMn4LpdgcOed4IRtHAZQ+5wgJelCJgoxqPF4G5ubxse 33wwZB+WnFg+FkPnNn2XVmliDAUx0Xt4B2pH0yZx39HiT2tHF68GB8lhK5vHQygBT5Bv4hJ F0szVA0ZzjHKhv024tAnvCPP1moLQCxMMmHgLV1n1800l11gkiuUDdZHI9B40u5sDzvwh+i Z3dvVqCObqMpSBrIRXjcg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: Dmitry Antipov , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > When it comes to the first patch you sent, I just realized that it do fix > another problem I've experienced (but not yet reported). When scrolling > with a simple C-v and follow-mode is enabled, the other window only > followed every second time the command was issued. > > In other words, I think that both patches should be applied. The second one includes the first one ;-) Anyway, I'm afraid that this is not yet the whole story. Dmitry, please look again at your changes - maybe you can spot additional locations where some weaker resets (weaker in a sense like "the buffer might not have changed but the window end position did") are needed. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 27 02:49:11 2013 Received: (at 15957) by debbugs.gnu.org; 27 Nov 2013 07:49:11 +0000 Received: from localhost ([127.0.0.1]:46919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlZrz-00005c-27 for submit@debbugs.gnu.org; Wed, 27 Nov 2013 02:49:11 -0500 Received: from mout.gmx.net ([212.227.17.20]:60701) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlZrw-00005O-4z for 15957@debbugs.gnu.org; Wed, 27 Nov 2013 02:49:09 -0500 Received: from [62.47.39.170] ([62.47.39.170]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0ME33j-1VrLQ906PP-00HNYh for <15957@debbugs.gnu.org>; Wed, 27 Nov 2013 08:49:02 +0100 Message-ID: <5295A3E2.5040101@gmx.at> Date: Wed, 27 Nov 2013 08:48:50 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> <5294AC5D.3050602@gmx.at> <5294CA19.7020605@gmx.at> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:G211odR7Y0Nhr8e+Xc48eeVWBuLrVquysqzMnLJmbf2uDh4j3is UyhOfjYuwzbe+B9YUHnvq+Mh51J2u+HqF1uSC18gNhm1boxJB6n/tPwZo2tE7beOp7GV+EV rgJbA0ALK2/HunQYkQNq+SN5lneNMlWF/n2JeMbIEf6DUsynplpWnA2xuNmp6Jx7mrOpl8d 37NbUzMbIcD5kqtNNr9QA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957 Cc: Dmitry Antipov , 15957@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > In other words, I think that both patches should be applied. Done in revision#115255 on trunk. Thanks for the invaluable recipe, martin From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 04 09:12:36 2014 Received: (at 15957-done) by debbugs.gnu.org; 4 Jan 2014 14:12:36 +0000 Received: from localhost ([127.0.0.1]:33308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzRxr-0008Lj-VW for submit@debbugs.gnu.org; Sat, 04 Jan 2014 09:12:36 -0500 Received: from mout.gmx.net ([212.227.15.18]:64742) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzRxp-0008LZ-DL for 15957-done@debbugs.gnu.org; Sat, 04 Jan 2014 09:12:33 -0500 Received: from [62.47.40.146] ([62.47.40.146]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0M0tr1-1V8aSt3HVX-00v4Mj for <15957-done@debbugs.gnu.org>; Sat, 04 Jan 2014 15:12:32 +0100 Message-ID: <52C816CD.4060401@gmx.at> Date: Sat, 04 Jan 2014 15:12:29 +0100 From: martin rudalics MIME-Version: 1.0 To: Anders Lindgren Subject: Re: bug#15957: 24.3.50; Follow mode scrolling broken on Emacs trunk References: <52909877.1070203@gmx.at> <5291D098.10507@gmx.at> <52937DED.9070304@gmx.at> <529440AD.6060505@yandex.ru> <5294AC5D.3050602@gmx.at> <5294CA19.7020605@gmx.at> <5295A3E2.5040101@gmx.at> In-Reply-To: <5295A3E2.5040101@gmx.at> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:oZFkWa2Ud9QhNBKhxmcO1wv5+Ph9x7V1c/4OPo3inqF/IhshpNr MJ02lKPrOEbAEJseMiGgBVqwylj4PHIBHgzb9LlN7jOZDqNobEnn6bJ1PGWKnTo95xodF5K Op5DtNsL58Cv1C05iNt781UBCS6QKcZ3shqG7LMB4ad7s+GaX7Q+9xS5awV4gzk+oCb1aaB vHfmjhnHI7rzlQ8GVhJDw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15957-done Cc: Dmitry Antipov , 15957-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> In other words, I think that both patches should be applied. > > Done in revision#115255 on trunk. Bug closed. Thanks, martin From unknown Tue Jun 17 03:39:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 02 Feb 2014 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator