Subject: bug#15938: closed (Re: bug#15938: diff-mode mishandles diff-default-read-only)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 23 Nov 2013 02:58:05 +0000

Your bug report

#15938: diff-mode mishandles diff-default-read-only 

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
15938: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15938
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#15938: diff-mode mishandles diff-default-read-only
From: Glenn Morris <[email-masked]>
To: [email-masked]
Date: Fri, 22 Nov 2013 21:57:03 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 24.4

Thanks; applied.

(BTW, we'd probably need a copyright assignment to accept anything more
than 2-3 lines more from you in future. So maybe think about starting
that process if you expect to contribute more.)

Subject: diff-mode mishandles diff-default-read-only
From: Ivan Shmakov <[email-masked]>
To: [email-masked]
Date: Wed, 20 Nov 2013 19:47:29 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

	In addition to making the -*- Diff -*- buffers read-only when
	diff-default-read-only is non-nil, diff-mode also makes such
	buffers /writable/ when diff-default-read-only is nil, while per
	the documentation, I’d expect for diff-mode to have no effect on
	buffer-read-only in this latter case.

	Please consider the patch below, which seems to fix the issue.

--- diff-mode.el.~1~
+++ diff-mode.el	2013-11-20 19:42:41.000000000 +0000
@@ -1366,7 +1366,8 @@ (define-derived-mode diff-mode fundamental-mode "Diff"
 
   (diff-setup-whitespace)
 
-  (setq buffer-read-only diff-default-read-only)
+  (when diff-default-read-only
+    (setq buffer-read-only t))
   ;; setup change hooks
   (if (not diff-update-on-the-fly)
       (add-hook 'write-contents-functions 'diff-write-contents-hooks nil t)

-- 
FSF associate member #7257