From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 15:19:24 2013 Received: (at submit) by debbugs.gnu.org; 20 Nov 2013 20:19:24 +0000 Received: from localhost ([127.0.0.1]:35191 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjEFA-0002Us-9p for submit@debbugs.gnu.org; Wed, 20 Nov 2013 15:19:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43835) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjEF8-0002Ud-RJ for submit@debbugs.gnu.org; Wed, 20 Nov 2013 15:19:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjEEy-0002VQ-An for submit@debbugs.gnu.org; Wed, 20 Nov 2013 15:19:17 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51473) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjEEy-0002UW-7g for submit@debbugs.gnu.org; Wed, 20 Nov 2013 15:19:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjEEt-0007eO-Ah for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2013 15:19:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VjEEm-0002Pk-PN for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2013 15:19:07 -0500 Received: from fely.am-1.org ([78.47.74.50]:47645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VjEEm-0002PG-JQ for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2013 15:19:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Sender:Date:Subject:To:From; bh=sw0VbT/P6KIzDFi70eul9Ep/UvIFJ0mU30CxoROqwho=; b=V8cJC+oPOBSXz4AYnWb6f2IV72zHBD8I6n4jdbGfIBsYZtMmmNNOIg7Z/xlmr6+l7ymlOdI5HFWA0ZSdfzavy6kbGOJCftf330wUhOcW4AY/8ydfq+aD0Nt0r/1bPpotNRlLOegwpQ9+E//vpTBLJ3sBinRowUYGUfTHP3umnl8=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VjEEl-0007Sr-3w for bug-gnu-emacs@gnu.org; Wed, 20 Nov 2013 20:18:59 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VjEEe-0003BR-63 for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2013 03:18:52 +0700 From: Ivan Shmakov To: bug-gnu-emacs@gnu.org Subject: diff-mode mishandles diff-default-read-only Date: Wed, 20 Nov 2013 19:47:29 +0000 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) Message-ID: <87vbzmomhg.fsf@violet.siamics.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) In addition to making the -*- Diff -*- buffers read-only when diff-default-read-only is non-nil, diff-mode also makes such buffers /writable/ when diff-default-read-only is nil, while per the documentation, I=E2=80=99d expect for diff-mode to have no effect on buffer-read-only in this latter case. Please consider the patch below, which seems to fix the issue. --- diff-mode.el.~1~ +++ diff-mode.el 2013-11-20 19:42:41.000000000 +0000 @@ -1366,7 +1366,8 @@ (define-derived-mode diff-mode fundamental-mode "Diff" =20 (diff-setup-whitespace) =20 - (setq buffer-read-only diff-default-read-only) + (when diff-default-read-only + (setq buffer-read-only t)) ;; setup change hooks (if (not diff-update-on-the-fly) (add-hook 'write-contents-functions 'diff-write-contents-hooks nil t) --=20 FSF associate member #7257 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 21:57:08 2013 Received: (at 15938-done) by debbugs.gnu.org; 23 Nov 2013 02:57:08 +0000 Received: from localhost ([127.0.0.1]:39166 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vk3P9-0000a3-98 for submit@debbugs.gnu.org; Fri, 22 Nov 2013 21:57:07 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:39590 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vk3P6-0000Zt-KI for 15938-done@debbugs.gnu.org; Fri, 22 Nov 2013 21:57:05 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vk3P5-0005PY-EQ; Fri, 22 Nov 2013 21:57:03 -0500 From: Glenn Morris To: 15938-done@debbugs.gnu.org Subject: Re: bug#15938: diff-mode mishandles diff-default-read-only References: <87vbzmomhg.fsf@violet.siamics.net> X-Spook: munitions plutonium Janet Reno SAFE UNSCOM AUTODIN X-Ran: w<@}U?;p.e[3VZ%\Ia!$&#*9X/Wn7)28_EX5k}-.8y]{30k~A+nXXQoKzv/Mxf%1-@\VQy X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 22 Nov 2013 21:57:03 -0500 In-Reply-To: <87vbzmomhg.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 20 Nov 2013 19:47:29 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15938-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) Version: 24.4 Thanks; applied. (BTW, we'd probably need a copyright assignment to accept anything more than 2-3 lines more from you in future. So maybe think about starting that process if you expect to contribute more.) From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 03:15:13 2013 Received: (at 15938) by debbugs.gnu.org; 23 Nov 2013 08:15:13 +0000 Received: from localhost ([127.0.0.1]:39306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vk8Mz-0003g0-13 for submit@debbugs.gnu.org; Sat, 23 Nov 2013 03:15:13 -0500 Received: from fely.am-1.org ([78.47.74.50]:39116) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vk8Mv-0003fp-IV for 15938@debbugs.gnu.org; Sat, 23 Nov 2013 03:15:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=jmQmWOG+4Na/Y45F921apLalzhmKpt5hDBY5BfWZJZc=; b=fZ1FTly23Mh/xsJsi0F+g6FQkLRdAXmKcYUlH60FW5BrFWrKsEuRHRN9boO2sjs3+s1n75BWB6VEVtLEl1AceFOxtBLTgTIE1HMGEUT4ETEfklQK+E7luAqBSAvjVj8d+N60xegkrR/R/Yw6MPS7EPE2TXa8xwVV52QWhuK9dDc=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Vk8Mt-0006wm-GG for 15938@debbugs.gnu.org; Sat, 23 Nov 2013 08:15:08 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Vk8Mj-00014y-D8 for 15938@debbugs.gnu.org; Sat, 23 Nov 2013 15:14:57 +0700 From: Ivan Shmakov To: 15938@debbugs.gnu.org Subject: Re: bug#15938: diff-mode mishandles diff-default-read-only References: <87vbzmomhg.fsf@violet.siamics.net> Date: Sat, 23 Nov 2013 08:14:56 +0000 In-Reply-To: (Glenn Morris's message of "Fri, 22 Nov 2013 21:57:03 -0500") Message-ID: <87mwkvlekf.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 15938 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Glenn Morris writes: > Version: 24.4 Thanks; applied. > (BTW, we'd probably need a copyright assignment to accept anything > more than 2-3 lines more from you in future. So maybe think about > starting that process if you expect to contribute more.) JFTR, does that mean 2=E2=80=933 LoC /in total/, or 2=E2=80=933 LoC /per change/? I have no plans on working on substantial changes to Emacs at this moment, though I hope to contribute some more trivial bug fixes, just like those I=E2=80=99ve sent recently. --=20 FSF associate member #7257 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 23 13:54:32 2013 Received: (at 15938) by debbugs.gnu.org; 23 Nov 2013 18:54:32 +0000 Received: from localhost ([127.0.0.1]:40384 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkILf-000449-6X for submit@debbugs.gnu.org; Sat, 23 Nov 2013 13:54:31 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56230 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkILc-00043w-51 for 15938@debbugs.gnu.org; Sat, 23 Nov 2013 13:54:28 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VkILZ-0004Es-Sg; Sat, 23 Nov 2013 13:54:25 -0500 From: Glenn Morris To: Ivan Shmakov Subject: Re: bug#15938: diff-mode mishandles diff-default-read-only References: <87vbzmomhg.fsf@violet.siamics.net> <87mwkvlekf.fsf@violet.siamics.net> X-Spook: Steve Case undercover Al-Qaeda Centro monarchist ANDVT X-Ran: +^w?iz%*!D1@wQ:D$,ev1E!iFb- (Ivan Shmakov's message of "Sat, 23 Nov 2013 08:14:56 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15938 Cc: 15938@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) Ivan Shmakov wrote: > > (BTW, we'd probably need a copyright assignment to accept anything > > more than 2-3 lines more from you in future. So maybe think about > > starting that process if you expect to contribute more.) > > JFTR, does that mean 2=E2=80=933 LoC /in total/, or 2=E2=80=933 LoC > /per change/? I have no plans on working on substantial changes > to Emacs at this moment, though I hope to contribute some more > trivial bug fixes, just like those I've sent recently. 2-3 lines in total. So if you prefer not to do an assignment, it's best if future reports just describe what the problem is, without including patches. From unknown Fri Aug 15 15:37:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 22 Dec 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator