GNU bug report logs - #15926
RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

Previous Next

Full log

View this message in rfc822 format

From: Jim Meyering <jim <at> meyering.net>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 15926 <15926 <at> debbugs.gnu.org>, Eric Blake <eblake <at> redhat.com>, Bob Proulx <bob <at> proulx.com>
Subject: bug#15926: RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call
Date: Thu, 21 Nov 2013 08:11:02 -0800

On Wed, Nov 20, 2013 at 4:03 PM, Bernhard Voelker
<mail <at> bernhard-voelker.de> wrote:
> On 11/20/2013 02:44 PM, Eric Blake wrote:
>> On 11/19/2013 11:45 PM, Bernhard Voelker wrote:
>>> Maybe "cannot remove directory" is a bit weak - it's more like
>>> "refusing to remove dot|dot-dot|root directory".
>>
>> Indeed, a clearer error message would be possible.
>
> What about the following?
>
>   $ src/rm -r src/.
>   src/rm: refusing to remove '.' or '..' directory: skipping 'src/.'
>
> I didn't want to explicitly mention POSIX here ... it's just to clarify
> that rm(1) does not swallow errors from the kernel like EPERM, etc.
>
> The texinfo file is enhanced in the patch below, too.
...
> ---
>  doc/coreutils.texi |  3 ++-
>  src/remove.c       | 12 ++++++++----

Thanks for doing that.
I was a little surprised to see an rm diagnostic change, but no
corresponding change in any test.  Perhaps an opportunity for
increased test coverage?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.