GNU bug report logs - #15926
RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

Previous Next

Package: coreutils;

Reported by: Linda Walsh <coreutils <at> tlinx.org>

Date: Tue, 19 Nov 2013 11:58:02 UTC

Severity: normal

Tags: notabug, patch

Merged with 15943

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #209 received at 15926 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Bob Proulx <bob <at> proulx.com>
Cc: 15926 <15926 <at> debbugs.gnu.org>
Subject: Re: bug#15926: RFE: unlink command already uses 'unlink' call; make
 'rm' use 'remove' call
Date: Sat, 30 Nov 2013 01:48:31 +0000
On 11/29/2013 07:57 PM, Bob Proulx wrote:
> Eric Blake wrote:
>> Bernhard Voelker wrote:
>>> Bob Proulx wrote:
>>> +# Exercise "rm -rf /" without the --preserve-root and --no-preserve-root option.
>>> +# Expect a non-Zero exist status.
>>> +exercise_rm_rf_root \
>>> +  && fail=1
>>
>> Maybe you should favor 'rm -r /' rather than 'rm -rf /'.  That way, even
>> if all the failsafes are bypassed, you at least have better logging of
>> what started to go wrong rather than silence.
> 
> I still think this is a very scary test and isn't worth the return on
> investment.  It is the kind of thing that makes me think I could never
> recommend building coreutils anywhere but in a throwaway chroot.
> Because the risk of a failure is just so very extremely high.  That
> would be a shame.

To summarize, it,
only runs with: make EXPENSIVE=yes check,
only runs as non root,
ensures file & dir removal bypass work in a safe context first

Do you still think it's too dangerous?

Pádraig.




This bug report was last modified 6 years and 225 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.