GNU bug report logs - #15926
RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

Previous Next

Package: coreutils;

Reported by: Linda Walsh <coreutils <at> tlinx.org>

Date: Tue, 19 Nov 2013 11:58:02 UTC

Severity: normal

Tags: notabug, patch

Merged with 15943

Done: Assaf Gordon <assafgordon <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #170 received at 15926 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>, Bob Proulx <bob <at> proulx.com>
Cc: 15926 <15926 <at> debbugs.gnu.org>,
 Pádraig Brady <P <at> draigbrady.com>,
 Jim Meyering <jim <at> meyering.net>
Subject: Re: bug#15926: RFE: unlink command already uses 'unlink' call; make
 'rm' use 'remove' call
Date: Fri, 22 Nov 2013 19:28:51 -0700

[Message part 1 (text/plain, inline)]
On 11/22/2013 06:02 PM, Bernhard Voelker wrote:
> On 11/22/2013 06:39 PM, Bob Proulx wrote:

> +#-------------------------------------------------------------------------------
> +# Exercise "rm -rf /" without the --preserve-root and --no-preserve-root option.
> +# Expect a non-Zero exist status.
> +exercise_rm_rf_root \
> +  && fail=1

Maybe you should favor 'rm -r /' rather than 'rm -rf /'.  That way, even
if all the failsafes are bypassed, you at least have better logging of
what started to go wrong rather than silence.

Also, probably worth testing:

rm -r / a

to make sure that 'a' DOES get deleted, even though we skipped over the
/ argument, and that we still get the final exit status representing
failure to remove /.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[signature.asc (application/pgp-signature, attachment)]
This bug report was last modified 6 years and 225 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.