Subject: Re: bug#15926: RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

From: Eric Blake <[email-masked]>
Date: Thu, 21 Nov 2013 09:25:14 -0700

On 11/21/2013 09:18 AM, Bernhard Voelker wrote:
> On 11/21/2013 04:06 PM, Eric Blake wrote:
>> Hard to say that it is considerable bloat without seeing a patch; we
>> already know when the top-level arguments are directories thanks to
>> 'rm -d'.
> 
> Here's a draft - not tested more than this:

> +++ b/src/remove.h
> @@ -52,6 +52,10 @@ struct rm_options
>    /* If true, remove empty directories.  */
>    bool remove_empty_directories;
> 
> +  /* If true (and the -r option is also specified), remove all children
> +     of directory arguments, yet retaining the directory itself.  */
> +  bool children_only;

Should --children-only imply -r, rather than being a no-op when -r is
missing?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org