Subject: bug#15926: RFE: unlink command already uses 'unlink' call; make 'rm' use 'remove' call

From: Eric Blake <[email-masked]>
Date: Fri, 22 Nov 2013 08:42:04 -0700

On 11/22/2013 08:36 AM, Bernhard Voelker wrote:
> On 11/22/2013 04:14 PM, Eric Blake wrote:
>> Just noticing this context...
>>
>>>
>>>   # This test is too dangerous -- if there's a bug you're wiped out!
>>>   # rm -fr / 2>/dev/null && fail=1
>>
>> What if we use chroot to create a safer /, where failing the test would
>> only wipe out the chroot?
> 
> That's not that easy.
> Alternatively, that test could be secured by "skip_if_root_"
> plus intercepting the unlinkat() call via LD_PRELOAD.

Indeed, LD_PRELOAD is great for this - since the test passes when no
unlink/rmdir occurs, you just make the intercepts fail loudly if they
are invoked.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org