From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 20:55:31 2013 Received: (at submit) by debbugs.gnu.org; 19 Nov 2013 01:55:31 +0000 Received: from localhost ([127.0.0.1]:60600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViaXL-0005BE-8I for submit@debbugs.gnu.org; Mon, 18 Nov 2013 20:55:31 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38370) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViaXI-0005Az-3L for submit@debbugs.gnu.org; Mon, 18 Nov 2013 20:55:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViaXB-00006H-Cp for submit@debbugs.gnu.org; Mon, 18 Nov 2013 20:55:22 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViaXB-00006B-9S for submit@debbugs.gnu.org; Mon, 18 Nov 2013 20:55:21 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40089) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViaX9-0002fw-NZ for bug-grep@gnu.org; Mon, 18 Nov 2013 20:55:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ViaX8-00005s-BA for bug-grep@gnu.org; Mon, 18 Nov 2013 20:55:19 -0500 Received: from mail-pa0-x22a.google.com ([2607:f8b0:400e:c03::22a]:58364) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ViaX8-00005h-3t for bug-grep@gnu.org; Mon, 18 Nov 2013 20:55:18 -0500 Received: by mail-pa0-f42.google.com with SMTP id lj1so1816695pab.29 for ; Mon, 18 Nov 2013 17:55:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=6r+xuAIdpiMplA2GiR9ujdyELuRu73s6V1AVJQ1x5MY=; b=SB6DW8cvGZdqcdPwaz0+jB0wFy9hXuOcZ9RYeBdGJ13OULJCTVMgvk4cGQuIKvrkxR 839qRjjcbxzeAe/zjOnx+Tge3GSs+LWuP44Ps8w7p4hoC8XqNlWF8U1RcLsjHbpkIJeJ e8+rQkbJJClLeoKfPMvFdY7eDIwFM/2J8axHOW4+LEL2IzqUiqJA7ry1OenZgUvpSPa0 EcQfuyATNvCsSGkafi30+0j8Se4xp9X7BaKCUod1pBGhWruyivFCKL1JhvvNb2U8LEG8 99xuS6HjhZFkzskrJj6rf3claLo2IpvnHkJJIrr1Q2/ctF2EwgOJthInENpEV4QgWo08 EC3w== X-Received: by 10.66.122.100 with SMTP id lr4mr167940pab.164.1384826116934; Mon, 18 Nov 2013 17:55:16 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Mon, 18 Nov 2013 17:54:56 -0800 (PST) From: Jim Meyering Date: Mon, 18 Nov 2013 17:54:56 -0800 X-Google-Sender-Auth: cQiEDquq-5IRQVp9AYe2EeURvcY Message-ID: Subject: [PATCH] dfa: avoid undefined behavior of "1 << 31" To: bug-grep@gnu.org Content-Type: multipart/mixed; boundary=047d7b2e0de7c743ac04eb7df422 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --047d7b2e0de7c743ac04eb7df422 Content-Type: text/plain; charset=ISO-8859-1 FYI: --047d7b2e0de7c743ac04eb7df422 Content-Type: text/plain; charset=US-ASCII; name="k.txt" Content-Disposition: attachment; filename="k.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ho6hp4p00 RnJvbSA2ZTYxOGQ1ZjU3OTE2ZDUzZjcwZDc3MTg2ZmVlYTViMjY1NzUxYWIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog TW9uLCAxOCBOb3YgMjAxMyAxNzo1MzozMyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGRmYTogYXZv aWQgdW5kZWZpbmVkIGJlaGF2aW9yIG9mICIxIDw8IDMxIgoKKiBzcmMvZGZhLmMgKHRzdGJpdCwg c2V0Yml0LCBjbHJiaXQsIGRmYXN0YXRlKTogRG9uJ3Qgc2hpZnQgIjEiCihha2EgKGludCkxKSBs ZWZ0IGJ5IDMxIGJpdHMuICBJbnN0ZWFkLCB1c2UgIjFVIiBhcyB0aGUgb3BlcmFuZCwKdG8gYXZv aWQgdW5kZWZpbmVkIGJlaGF2aW9yLiAgU3BvdHRlZCBieSBnY2MncyBuZXcgLWZzYW5pdGl6ZT11 bmRlZmluZWQuCi0tLQogc3JjL2RmYS5jIHwgOCArKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQg aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvZGZhLmMgYi9z cmMvZGZhLmMKaW5kZXggOTJjNDEwZS4uMWZhZTU1OCAxMDA2NDQKLS0tIGEvc3JjL2RmYS5jCisr KyBiL3NyYy9kZmEuYwpAQCAtNTUwLDE5ICs1NTAsMTkgQEAgcHJ0b2sgKHRva2VuIHQpCiBzdGF0 aWMgaW50CiB0c3RiaXQgKHVuc2lnbmVkIGludCBiLCBjaGFyY2xhc3MgY29uc3QgYykKIHsKLSAg cmV0dXJuIGNbYiAvIElOVEJJVFNdICYgMSA8PCBiICUgSU5UQklUUzsKKyAgcmV0dXJuIGNbYiAv IElOVEJJVFNdICYgMVUgPDwgYiAlIElOVEJJVFM7CiB9Cgogc3RhdGljIHZvaWQKIHNldGJpdCAo dW5zaWduZWQgaW50IGIsIGNoYXJjbGFzcyBjKQogewotICBjW2IgLyBJTlRCSVRTXSB8PSAxIDw8 IGIgJSBJTlRCSVRTOworICBjW2IgLyBJTlRCSVRTXSB8PSAxVSA8PCBiICUgSU5UQklUUzsKIH0K CiBzdGF0aWMgdm9pZAogY2xyYml0ICh1bnNpZ25lZCBpbnQgYiwgY2hhcmNsYXNzIGMpCiB7Ci0g IGNbYiAvIElOVEJJVFNdICY9IH4oMSA8PCBiICUgSU5UQklUUyk7CisgIGNbYiAvIElOVEJJVFNd ICY9IH4oMVUgPDwgYiAlIElOVEJJVFMpOwogfQoKIHN0YXRpYyB2b2lkCkBAIC0yNzM4LDcgKzI3 MzgsNyBAQCBkZmFzdGF0ZSAoc3RhdGVfbnVtIHMsIHN0cnVjdCBkZmEgKmQsIHN0YXRlX251bSB0 cmFuc1tdKQogICAgICAgLyogU2V0IHRoZSB0cmFuc2l0aW9ucyBmb3IgZWFjaCBjaGFyYWN0ZXIg aW4gdGhlIGN1cnJlbnQgbGFiZWwuICAqLwogICAgICAgZm9yIChqID0gMDsgaiA8IENIQVJDTEFT U19JTlRTOyArK2opCiAgICAgICAgIGZvciAoayA9IDA7IGsgPCBJTlRCSVRTOyArK2spCi0gICAg ICAgICAgaWYgKGxhYmVsc1tpXVtqXSAmIDEgPDwgaykKKyAgICAgICAgICBpZiAobGFiZWxzW2ld W2pdICYgMVUgPDwgaykKICAgICAgICAgICAgIHsKICAgICAgICAgICAgICAgaW50IGMgPSBqICog SU5UQklUUyArIGs7CgotLQoxLjguNC5yYzAuMTEuZzM1ZjVlYWEKCg== --047d7b2e0de7c743ac04eb7df422-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 21:16:22 2013 Received: (at 15924) by debbugs.gnu.org; 19 Nov 2013 02:16:22 +0000 Received: from localhost ([127.0.0.1]:60618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViarW-0005iO-FX for submit@debbugs.gnu.org; Mon, 18 Nov 2013 21:16:22 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:35440) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViarT-0005iB-RV for 15924@debbugs.gnu.org; Mon, 18 Nov 2013 21:16:20 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id DD75939E8100; Mon, 18 Nov 2013 18:16:13 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5qHIHUYEHS+G; Mon, 18 Nov 2013 18:16:13 -0800 (PST) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 72B3C39E80FF; Mon, 18 Nov 2013 18:16:13 -0800 (PST) Message-ID: <528AC9EA.6030703@cs.ucla.edu> Date: Mon, 18 Nov 2013 18:16:10 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Jim Meyering , 15924@debbugs.gnu.org Subject: Re: bug#15924: [PATCH] dfa: avoid undefined behavior of "1 << 31" References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 15924 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Jim Meyering wrote: > static int > tstbit (unsigned int b, charclass const c) > { > - return c[b / INTBITS] & 1 << b % INTBITS; > + return c[b / INTBITS] & 1U << b % INTBITS; > } On a machine with 32-bit int and where b % INTBITS is 31, the expression c[b / INTBITS] & 1U << b % INTBITS is of type 'unsigned' and can have the value 2**31, and this will overflow when tstbit converts that value as an int, leading to implementation-defined behavior, which can include raising a signal. Better would be something like this: static bool tstbit (unsigned int b, charclass const c) { return c[b / INTBITS] >> b % INTBITS & 1; } and it'd probably be better to encourage this style in other places where the problem occurs, e.g., quotearg. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 19 00:25:56 2013 Received: (at 15924) by debbugs.gnu.org; 19 Nov 2013 05:25:56 +0000 Received: from localhost ([127.0.0.1]:60756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vidox-00022w-IJ for submit@debbugs.gnu.org; Tue, 19 Nov 2013 00:25:56 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:52489) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vidou-00022i-2f for 15924@debbugs.gnu.org; Tue, 19 Nov 2013 00:25:52 -0500 Received: by mail-pb0-f52.google.com with SMTP id uo5so1351005pbc.25 for <15924@debbugs.gnu.org>; Mon, 18 Nov 2013 21:25:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=QlL4Ai8z3ujQcoYLwWy8rrFtXdA7TCsklZzz5xhAkiY=; b=U2nHfQioBrXdjorVfZM5M7wLe6aZQqgkXkMIS619RgG61hYIT3pdY9UOBjsLc2Qp3/ NfTvc+fhnHaEdICeCdkSl9eEM+4aUQxNaAi3P5UmzMi40qMiQNZF/saAw7tCctl7Xy5w dKFXEg1qIZw8N+DllRbKlPSrkZA8Un/YPmcb1GUj/e48Qhal+utw2PJOIuInMmHM3LVm BmJ1W+yvysTZdLMWwApkgtyNetiEH72klJptm35Vj+Zz5+PkXGNiTtceiRSlTB4+bJcw aEE0ulxgYd9QT1shbIXC9a162TjYmflGYq1zjEyLBjVlXYLIbXRTqmVoIks+mUOcHtF0 DErw== X-Received: by 10.66.65.165 with SMTP id y5mr5183486pas.101.1384838746076; Mon, 18 Nov 2013 21:25:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Mon, 18 Nov 2013 21:25:25 -0800 (PST) In-Reply-To: <528AC9EA.6030703@cs.ucla.edu> References: <528AC9EA.6030703@cs.ucla.edu> From: Jim Meyering Date: Mon, 18 Nov 2013 21:25:25 -0800 X-Google-Sender-Auth: Zn07p9mLFa1wyubWagxdT2iUhbg Message-ID: Subject: Re: bug#15924: [PATCH] dfa: avoid undefined behavior of "1 << 31" To: Paul Eggert Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15924 Cc: 15924@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Nov 18, 2013 at 6:16 PM, Paul Eggert wrote: > Jim Meyering wrote: >> static int >> tstbit (unsigned int b, charclass const c) >> { >> - return c[b / INTBITS] & 1 << b % INTBITS; >> + return c[b / INTBITS] & 1U << b % INTBITS; >> } > > On a machine with 32-bit int and where b % INTBITS is 31, > the expression c[b / INTBITS] & 1U << b % INTBITS > is of type 'unsigned' and can have the value 2**31, and > this will overflow when tstbit converts that value as an int, > leading to implementation-defined behavior, which can include > raising a signal. > > Better would be something like this: > > static bool > tstbit (unsigned int b, charclass const c) > { > return c[b / INTBITS] >> b % INTBITS & 1; > } > > and it'd probably be better to encourage this style in > other places where the problem occurs, e.g., quotearg. Good point. "bool" is a better return type, too. I will adjust. Thanks, Paul. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 00:04:12 2013 Received: (at 15924) by debbugs.gnu.org; 21 Nov 2013 05:04:12 +0000 Received: from localhost ([127.0.0.1]:35628 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjMR1-0002Oq-O5 for submit@debbugs.gnu.org; Thu, 21 Nov 2013 00:04:12 -0500 Received: from mail-pd0-f181.google.com ([209.85.192.181]:65378) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjMQz-0002Oa-9t for 15924@debbugs.gnu.org; Thu, 21 Nov 2013 00:04:10 -0500 Received: by mail-pd0-f181.google.com with SMTP id p10so2974843pdj.26 for <15924@debbugs.gnu.org>; Wed, 20 Nov 2013 21:04:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ZSOJgnMPMKb2LQt3w2sUUt8YDIdW8AFC7DoeLgZt3y8=; b=ZvRhqVaVgmbFdSfSspRQzwHR6SHyE0e44fr1CeN7peJK6vdgZ1WcECBzbIGaUWUuvM PImwm0Q84ejCV1iSegVh45Z/yKhk9QH5Jxn0ynCWmTnXmBogGhgtgB40LYCMX86ate8A HTaHDof+NWdLtTyqcQlqPIskW91aU2u5WvdjO6w2IQza0pxqPRIQLDflk+cqEhgUmpGX si5Z+IZR9VH8xZrKDTfURDonNwHETVZvyNE+ytVVyWXTVsrEFfqfvhyXC9lHMcGO5NTH /uHxxTzSbrweE4PjD9pCmWrPsjHcdZ97hQOTUGVvrIzM40ciJh6qt7+21M9ByDlZWMc0 qnnQ== X-Received: by 10.66.121.201 with SMTP id lm9mr4375696pab.80.1385010243276; Wed, 20 Nov 2013 21:04:03 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Wed, 20 Nov 2013 21:03:42 -0800 (PST) In-Reply-To: References: <528AC9EA.6030703@cs.ucla.edu> From: Jim Meyering Date: Wed, 20 Nov 2013 21:03:42 -0800 X-Google-Sender-Auth: zHvShlL48-FgHiOLxAJw9LX2TJ0 Message-ID: Subject: Re: bug#15924: [PATCH] dfa: avoid undefined behavior of "1 << 31" To: Paul Eggert Content-Type: multipart/mixed; boundary=047d7b2e4ca48feb1104eba8d3b2 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15924 Cc: 15924@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --047d7b2e4ca48feb1104eba8d3b2 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Nov 18, 2013 at 9:25 PM, Jim Meyering wrote: > On Mon, Nov 18, 2013 at 6:16 PM, Paul Eggert wrote: >> Jim Meyering wrote: >>> static int >>> tstbit (unsigned int b, charclass const c) >>> { >>> - return c[b / INTBITS] & 1 << b % INTBITS; >>> + return c[b / INTBITS] & 1U << b % INTBITS; >>> } >> >> On a machine with 32-bit int and where b % INTBITS is 31, >> the expression c[b / INTBITS] & 1U << b % INTBITS >> is of type 'unsigned' and can have the value 2**31, and >> this will overflow when tstbit converts that value as an int, >> leading to implementation-defined behavior, which can include >> raising a signal. >> >> Better would be something like this: >> >> static bool >> tstbit (unsigned int b, charclass const c) >> { >> return c[b / INTBITS] >> b % INTBITS & 1; >> } >> >> and it'd probably be better to encourage this style in >> other places where the problem occurs, e.g., quotearg. > > Good point. "bool" is a better return type, too. > I will adjust. Here's an updated patch: --047d7b2e4ca48feb1104eba8d3b2 Content-Type: text/plain; charset=US-ASCII; name="k.txt" Content-Disposition: attachment; filename="k.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ho9ja3th0 RnJvbSBiMDQxZjhiYzM5ODZkMWFkY2JhOGQyZWExYzQ4ZjM3YzQzNWZjYzYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog TW9uLCAxOCBOb3YgMjAxMyAxNzo1MzozMyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIGRmYTogYXZv aWQgdW5kZWZpbmVkIGJlaGF2aW9yIG9mICIxIDw8IDMxIgoKKiBzcmMvZGZhLmMgKGNoYXJjbGFz cyk6IENoYW5nZSB0eXBlIGZyb20gImludCIgdG8gInVuc2lnbmVkIGludCIuCih0c3RiaXQpOiBS YXRoZXIgdGhhbiBzaGlmdGluZyAiMSIgbGVmdCB0byBmb3JtIGEgbWFzaywgc2hpZnQgdGhlCkxI UyBiaXRzIHRoZSByaWdodCBhbmQgdXNlICIxIiBhcyB0aGUgbWFzay4gIEFsc28sIHJldHVybiBi b29sLCByYXRoZXIKdGhhbiAiaW50Ii4KKHNldGJpdCwgY2xyYml0LCBkZmFzdGF0ZSk6IERvbid0 IHNoaWZ0ICIxIiAoYWthIChpbnQpMSkgbGVmdCBieSAzMSBiaXRzLgpJbnN0ZWFkLCB1c2UgIjFV IiBhcyB0aGUgb3BlcmFuZCwgdG8gYXZvaWQgdW5kZWZpbmVkIGJlaGF2aW9yLgpTcG90dGVkIGJ5 IGdjYydzIG5ldyAtZnNhbml0aXplPXVuZGVmaW5lZC4KQ28tYXV0aG9yZWQtYnk6IFBhdWwgRWdn ZXJ0IDxlZ2dlcnRAY3MudWNsYS5lZHU+Ci0tLQogc3JjL2RmYS5jIHwgMTIgKysrKysrLS0tLS0t CiAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlmZiAt LWdpdCBhL3NyYy9kZmEuYyBiL3NyYy9kZmEuYwppbmRleCA5MmM0MTBlLi5mMTk2YjhhIDEwMDY0 NAotLS0gYS9zcmMvZGZhLmMKKysrIGIvc3JjL2RmYS5jCkBAIC04OCw3ICs4OCw3IEBACiAjZGVm aW5lIENIQVJDTEFTU19JTlRTICgoTk9UQ0hBUiArIElOVEJJVFMgLSAxKSAvIElOVEJJVFMpCgog LyogU2V0cyBvZiB1bnNpZ25lZCBjaGFyYWN0ZXJzIGFyZSBzdG9yZWQgYXMgYml0IHZlY3RvcnMg aW4gYXJyYXlzIG9mIGludHMuICAqLwotdHlwZWRlZiBpbnQgY2hhcmNsYXNzW0NIQVJDTEFTU19J TlRTXTsKK3R5cGVkZWYgdW5zaWduZWQgaW50IGNoYXJjbGFzc1tDSEFSQ0xBU1NfSU5UU107Cgog LyogQ29udmVydCBhIHBvc3NpYmx5LXNpZ25lZCBjaGFyYWN0ZXIgdG8gYW4gdW5zaWduZWQgY2hh cmFjdGVyLiAgVGhpcyBpcwogICAgYSBiaXQgc2FmZXIgdGhhbiBjYXN0aW5nIHRvIHVuc2lnbmVk IGNoYXIsIHNpbmNlIGl0IGNhdGNoZXMgc29tZSB0eXBlCkBAIC01NDcsMjIgKzU0NywyMiBAQCBw cnRvayAodG9rZW4gdCkKCiAvKiBTdHVmZiBwZXJ0YWluaW5nIHRvIGNoYXJjbGFzc2VzLiAgKi8K Ci1zdGF0aWMgaW50CitzdGF0aWMgYm9vbAogdHN0Yml0ICh1bnNpZ25lZCBpbnQgYiwgY2hhcmNs YXNzIGNvbnN0IGMpCiB7Ci0gIHJldHVybiBjW2IgLyBJTlRCSVRTXSAmIDEgPDwgYiAlIElOVEJJ VFM7CisgIHJldHVybiBjW2IgLyBJTlRCSVRTXSA+PiBiICUgSU5UQklUUyAmIDE7CiB9Cgogc3Rh dGljIHZvaWQKIHNldGJpdCAodW5zaWduZWQgaW50IGIsIGNoYXJjbGFzcyBjKQogewotICBjW2Ig LyBJTlRCSVRTXSB8PSAxIDw8IGIgJSBJTlRCSVRTOworICBjW2IgLyBJTlRCSVRTXSB8PSAxVSA8 PCBiICUgSU5UQklUUzsKIH0KCiBzdGF0aWMgdm9pZAogY2xyYml0ICh1bnNpZ25lZCBpbnQgYiwg Y2hhcmNsYXNzIGMpCiB7Ci0gIGNbYiAvIElOVEJJVFNdICY9IH4oMSA8PCBiICUgSU5UQklUUyk7 CisgIGNbYiAvIElOVEJJVFNdICY9IH4oMVUgPDwgYiAlIElOVEJJVFMpOwogfQoKIHN0YXRpYyB2 b2lkCkBAIC0yNzM4LDcgKzI3MzgsNyBAQCBkZmFzdGF0ZSAoc3RhdGVfbnVtIHMsIHN0cnVjdCBk ZmEgKmQsIHN0YXRlX251bSB0cmFuc1tdKQogICAgICAgLyogU2V0IHRoZSB0cmFuc2l0aW9ucyBm b3IgZWFjaCBjaGFyYWN0ZXIgaW4gdGhlIGN1cnJlbnQgbGFiZWwuICAqLwogICAgICAgZm9yIChq ID0gMDsgaiA8IENIQVJDTEFTU19JTlRTOyArK2opCiAgICAgICAgIGZvciAoayA9IDA7IGsgPCBJ TlRCSVRTOyArK2spCi0gICAgICAgICAgaWYgKGxhYmVsc1tpXVtqXSAmIDEgPDwgaykKKyAgICAg ICAgICBpZiAobGFiZWxzW2ldW2pdICYgMVUgPDwgaykKICAgICAgICAgICAgIHsKICAgICAgICAg ICAgICAgaW50IGMgPSBqICogSU5UQklUUyArIGs7CgotLQoxLjguNC5yYzAuMTEuZzM1ZjVlYWEK Cg== --047d7b2e4ca48feb1104eba8d3b2-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 11:57:09 2013 Received: (at 15924-done) by debbugs.gnu.org; 22 Nov 2013 16:57:09 +0000 Received: from localhost ([127.0.0.1]:38982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vju2X-0000ii-GE for submit@debbugs.gnu.org; Fri, 22 Nov 2013 11:57:09 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:63436) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vju2V-0000iR-V4 for 15924-done@debbugs.gnu.org; Fri, 22 Nov 2013 11:57:08 -0500 Received: by mail-pa0-f46.google.com with SMTP id kl14so1562373pab.33 for <15924-done@debbugs.gnu.org>; Fri, 22 Nov 2013 08:57:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=VVq+h8jXkV+MBeouq2MXGAiNS01Tjvr0RhG71JqezJ4=; b=jKerxcbyOvZZeQL1fFq+PigQUKcIe7L7kh3DaSgYh0u5zfMTP5IdpBMG0bLLF0y78M RhW0pPJt9xE7WEJzwlqXqVkUC+iLeFpv0C+Txt9/hMsTpH2em1KmNkvZpsltfdZYA0D6 JRWTh8FZfQQ3al+JOH2lU7KtbcVEj8D+rRrj6aOdZMlHXCzyqrGwHPQkIKOCOT9HvRDO 2QheAyWo4ZZJvLNafYhjcHTkW9KKo/G3duFEMlD/o36Zh9vVNR0+HQeoidnHq14Q1XRa Hdq2W0Trctpz4YOHkjj4xrkR6P5aOZ8eRLtRMpBClKI0BzZ1mxF85H91nU0P+KJ5sjTS UHFw== X-Received: by 10.68.196.227 with SMTP id ip3mr3717067pbc.163.1385139421754; Fri, 22 Nov 2013 08:57:01 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Fri, 22 Nov 2013 08:56:40 -0800 (PST) In-Reply-To: References: <528AC9EA.6030703@cs.ucla.edu> From: Jim Meyering Date: Fri, 22 Nov 2013 08:56:40 -0800 X-Google-Sender-Auth: QSGSKqjexWLVgs1VRD5ZNn8-MJk Message-ID: Subject: Re: bug#15924: [PATCH] dfa: avoid undefined behavior of "1 << 31" To: Paul Eggert Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15924-done Cc: 15924-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Pushed. From unknown Sat Jun 21 10:45:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Dec 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator