From unknown Sat Aug 16 21:12:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15910 <15910@debbugs.gnu.org> To: bug#15910 <15910@debbugs.gnu.org> Subject: Status: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. Reply-To: bug#15910 <15910@debbugs.gnu.org> Date: Sun, 17 Aug 2025 04:12:50 +0000 retitle 15910 24.3.50; [PATCH] eww: Current URL is not entered automaticall= y, after eww starts. reassign 15910 emacs submitter 15910 Kenjiro NAKAYAMA severity 15910 wishlist tag 15910 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 06:03:51 2013 Received: (at submit) by debbugs.gnu.org; 16 Nov 2013 11:03:51 +0000 Received: from localhost ([127.0.0.1]:56748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhdfL-0002Yv-A3 for submit@debbugs.gnu.org; Sat, 16 Nov 2013 06:03:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39628) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhdfI-0002Yf-Aw for submit@debbugs.gnu.org; Sat, 16 Nov 2013 06:03:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhdf4-0007Ps-IU for submit@debbugs.gnu.org; Sat, 16 Nov 2013 06:03:42 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhdf4-0007Po-G2 for submit@debbugs.gnu.org; Sat, 16 Nov 2013 06:03:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhdev-0003oF-Lp for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 06:03:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhden-0007Lv-7v for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 06:03:25 -0500 Received: from mail-pb0-x22f.google.com ([2607:f8b0:400e:c01::22f]:56134) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhden-0007LS-0V for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 06:03:17 -0500 Received: by mail-pb0-f47.google.com with SMTP id rr4so3232626pbb.34 for ; Sat, 16 Nov 2013 03:03:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:from:to:subject:date:message-id:mime-version :content-type; bh=JdFKrNGVYUNOQWlnkwPf1bH22aT0Zp74S/U6S8Ct1Z4=; b=cEAjw+Q7IPy1Cgu+pPT3wciQE4Vhz3Nxtez0NQMlPe0CXp2uiWKEktBQT+H9GVF/5M ue1JlothJol8kKJiZOudh71k8z5CCzqU/Kp3Tiw/u7NJbUxYE4YeFIyXeNQaDcf6K7CF CdNoOFBTOxY1IPYnF6mpyn9ElpnMB/8HYnau/5Xb1ZeeTrhmbupIidsGx17CWDeq2+6o ilXGuOY7uJnfyqecYutCdgGdJp4bvhLXw+VAcSpA2gn+4qCz1J+b3vkbaJeB066A7OQ4 SGmEJNot76DwWGi9t1LHFV0xtLE3CmJd8yIrF9NP1BjdU/zpX9wWQ0iwFpCtzNcRTsAV 237g== X-Received: by 10.66.228.38 with SMTP id sf6mr11377090pac.21.1384599795597; Sat, 16 Nov 2013 03:03:15 -0800 (PST) Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id ry4sm11725375pab.4.2013.11.16.03.03.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Nov 2013 03:03:14 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 From: Kenjiro NAKAYAMA To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. Date: Sat, 16 Nov 2013 20:03:11 +0900 Message-ID: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) After the start of eww, if I try to jump to another URL (by M-x eww again), eww asks to enter the URL entirely again. If eww enters the current URL automatically, it is very useful. And if the current URL is not necessary, it is easy to delete the URL. Signed-off-by: Kenjiro Nakayama --- lisp/net/eww.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 573715e..d835560 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -106,7 +106,7 @@ "Fetch URL and render the page. If the input doesn't look like an URL or a domain name, the word(s) will be searched for via `eww-search-prefix'." - (interactive "sEnter URL or keywords: ") + (interactive (list (read-string "sEnter URL or keywords: " eww-current-url))) (if (and (= (length (split-string url)) 1) (> (length (split-string url "\\.")) 1)) (progn -- 1.8.3.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 11:46:43 2013 Received: (at 15910) by debbugs.gnu.org; 21 Nov 2013 16:46:43 +0000 Received: from localhost ([127.0.0.1]:37052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjXOs-0000nN-Qc for submit@debbugs.gnu.org; Thu, 21 Nov 2013 11:46:43 -0500 Received: from mail-qc0-f176.google.com ([209.85.216.176]:34171) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjXOq-0000n3-HA for 15910@debbugs.gnu.org; Thu, 21 Nov 2013 11:46:41 -0500 Received: by mail-qc0-f176.google.com with SMTP id n9so1370364qcw.35 for <15910@debbugs.gnu.org>; Thu, 21 Nov 2013 08:46:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=AbBu5WeDtlYkH2zdfxXaxz/vYmEWIBXjTX2LBFH7EVQ=; b=KGiiaWAxDTEDvRfH1kIStYWG+WhjftlyLTMpKu01L5FDlqMQ2H//joJOq1LTAI1Dt7 U9AZ4SIIKZk6aCcSOH/Spj78X5N5YcK39+ix0SWWoDzGhznKxmdA33hbI4OgEs61TjGR bAKGHF3Iz3hZt+yUyUFTnF3dAUxxX8U/pbqpc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=AbBu5WeDtlYkH2zdfxXaxz/vYmEWIBXjTX2LBFH7EVQ=; b=hs823vON+4l1DDbwnLRB2l0l57L/O+kIn3tICXdpJ4lV9IlkUhDnL+zWJdZxx3SiC3 TozgwNAip3xCAgvkMhFczpnecXDPgEEkWnd7anX39roG/EPW7Co/qzWMOvyu5ALYSTRe V0TDTeX99OXz0YFsRq2SSE2idhSe8FPEPnQpMUbNPXpPh78Fr/mlkBMn8TWkmbEV6HJv GqI7CgXeNh+FfCGv8mSfh3n2gAUJpE1b16Ib5RZlVFVwZsUXdAPBEK9z5XRAgEr17tLY GxlNKLOAOUc/zIvuUpDBs03RwzQHFrSbmeuDy7a2lBvOIwbJtCWPLk9Wp0YZqeoDzSuv pCng== X-Gm-Message-State: ALoCoQmtxP0Ke13eUHuidr5z2H9sDpIaTIxqQWfKgAXYu/sgJJy4X2jlwwIKGCp1Qb6R/BDOHBLz X-Received: by 10.49.27.226 with SMTP id w2mr12932366qeg.32.1385052395051; Thu, 21 Nov 2013 08:46:35 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id k11sm36480483qab.3.2013.11.21.08.46.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2013 08:46:34 -0800 (PST) From: Ted Zlatanov To: Kenjiro NAKAYAMA Subject: Re: bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Thu, 21 Nov 2013 11:47:25 -0500 In-Reply-To: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Sat, 16 Nov 2013 20:03:11 +0900") Message-ID: <8738mpbt2a.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15910 Cc: 15910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, 16 Nov 2013 20:03:11 +0900 Kenjiro NAKAYAMA wrote: KN> After the start of eww, if I try to jump to another URL (by M-x eww again), eww asks to enter the URL entirely again. KN> If eww enters the current URL automatically, it is very useful. KN> And if the current URL is not necessary, it is easy to delete the URL. I like the idea. But I'm not sure it's necessary, since simply `up' or `M-p' will normally bring up the input history. I'll take any opinions... Thanks Ted From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 22:27:07 2013 Received: (at 15910) by debbugs.gnu.org; 22 Nov 2013 03:27:07 +0000 Received: from localhost ([127.0.0.1]:37689 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjhOc-00031Z-GC for submit@debbugs.gnu.org; Thu, 21 Nov 2013 22:27:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7127) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjhOZ-00031N-2M for 15910@debbugs.gnu.org; Thu, 21 Nov 2013 22:27:04 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAM3R1xD017493 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <15910@debbugs.gnu.org>; Thu, 21 Nov 2013 22:27:01 -0500 Received: from localhost (dhcp-193-176.nrt.redhat.com [10.64.193.176]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAM3R0H9017106 for <15910@debbugs.gnu.org>; Thu, 21 Nov 2013 22:27:01 -0500 Date: Fri, 22 Nov 2013 12:26:59 +0900 (JST) Message-Id: <20131122.122659.378621581576481664.yamato@redhat.com> To: 15910@debbugs.gnu.org Subject: Re: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. From: Masatake YAMATO Organization: Red Hat Japan, Inc. Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15910 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) eww() takes URL only. So I think eww should have its own history stack. However, if the current page is opened via non-interactive call of emm(), the url for the page will not be stored to history stack. As the result the user cannot retrieve the url via \M-p. So I think both the initial value, which Kenjiro proposed, and emm own history stack are needed in read-string. BTW, I recommend you to put ChangeLog entry to the report when you propose a patch. Masatake YAMATO From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 11:14:41 2013 Received: (at 15910) by debbugs.gnu.org; 22 Nov 2013 16:14:41 +0000 Received: from localhost ([127.0.0.1]:38964 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjtNN-00081c-8T for submit@debbugs.gnu.org; Fri, 22 Nov 2013 11:14:41 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:35873) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjtNG-00081J-MS for 15910@debbugs.gnu.org; Fri, 22 Nov 2013 11:14:34 -0500 Received: by mail-qa0-f54.google.com with SMTP id f11so5144897qae.20 for <15910@debbugs.gnu.org>; Fri, 22 Nov 2013 08:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=yx5jQDWQ4xO7DBla2pFFADTLQobJIpbsX9Fi+GR0Y9M=; b=i5++5vcZoDXEV+ZE++VQp7f52gy1GR99IqQMzYMP9CvLyi278CGTQaVbc8Nkz8DBDr y5zCSxdVaKqk0D8A3d/qI+0KtyCJ+hsuML9VqVx8n/e69S0wkMsafwG7EI4mcF+KZwJ9 1JwkxJRMqns3O/dEOQrdIqHiC0/rHgzwkHDoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=yx5jQDWQ4xO7DBla2pFFADTLQobJIpbsX9Fi+GR0Y9M=; b=ETe/XqirnfbSGrfSFmb157E2BQ83/ICFnrceylab1gnb5T5Jy0pxlSQJU/S3pHL8Xg Ix+twfaLesdzN7rva21IRFGIF7BD+PYuGay4CqBIxC+u2cRD+OPuxGl5JC5ZpOnpis9Y rWYo5qqYHcF8xA43WY1cexj3ave6UaMT7nAnBfU1jbq6gUpBzWQAIgFbVt3ujE+Ha2AK 56IWcRzCoIVu+sRrInCin1Ul3Eiu8wp3PVY0HoOCF2e4YvuSp3W/G5yWMLRwKL2BbWh7 nxyE5F1vfyP+szEwzVBmBkETlEx5Xl/i6CBm5+eGxDWX4oJNL/UzmAX0ofBoomGXCdKC 2LOg== X-Gm-Message-State: ALoCoQk8GttWp9BvN7VBoAZ8+Hk4oMlwKH7BYj/CVpUD4lyR0k5gPufNLbG0rKKRcD17H3p/unDx X-Received: by 10.224.29.66 with SMTP id p2mr4282743qac.82.1385136865069; Fri, 22 Nov 2013 08:14:25 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id 4sm5182645qak.11.2013.11.22.08.14.24 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Nov 2013 08:14:24 -0800 (PST) From: Ted Zlatanov To: Masatake YAMATO Subject: Re: bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after eww starts. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Fri, 22 Nov 2013 11:15:16 -0500 In-Reply-To: <20131122.122659.378621581576481664.yamato@redhat.com> (Masatake YAMATO's message of "Fri, 22 Nov 2013 12:26:59 +0900 (JST)") Message-ID: <87r4a88lbf.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15910 Cc: 15910@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Fri, 22 Nov 2013 12:26:59 +0900 (JST) Masatake YAMATO wrote: MY> eww() takes URL only. So I think eww should have its own MY> history stack. However, if the current page is opened via MY> non-interactive call of emm(), the url for the page will MY> not be stored to history stack. As the result the user cannot MY> retrieve the url via \M-p. Good point. s/emm/eww/. MY> So I think both the initial value, which Kenjiro proposed, and emm own MY> history stack are needed in read-string. Yes. Furthermore, followed links within `eww' should be added to the history stack. That would be valuable. MY> BTW, I recommend you to put ChangeLog entry to the report when MY> you propose a patch. Yes, please :) Ted From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 24 10:57:46 2013 Received: (at 15910) by debbugs.gnu.org; 24 Nov 2013 15:57:46 +0000 Received: from localhost ([127.0.0.1]:42273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vkc4A-00040C-Cl for submit@debbugs.gnu.org; Sun, 24 Nov 2013 10:57:46 -0500 Received: from mail-pd0-f178.google.com ([209.85.192.178]:55185) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vkc48-0003zw-EE for 15910@debbugs.gnu.org; Sun, 24 Nov 2013 10:57:44 -0500 Received: by mail-pd0-f178.google.com with SMTP id y10so3934100pdj.9 for <15910@debbugs.gnu.org>; Sun, 24 Nov 2013 07:57:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:date:message-id :mime-version:content-type; bh=aL2oi5X99YAiccB2lASiCeemAo94n51IUJDxiX/dYpU=; b=BSb0CRh3eoyru3IpPH9ziDQhYKvHlPTn/8P4BXPRAqIOw6oU1z7kpYYA66h3fxg0C4 4em1l9z5Bg8nc2l3DS3Gxp513HUAU797STxrFcUFPLJdkj+4j4nLaIdZ3LiSvVXysxDb 638xGQ/d9Q5yNK0vduw9fLOYOlW2ueQUP0PsI06RLOTkUWAKp8L9D5w8vDro4qxMbyDT rPuD01c4DfZ07Y0QerDvduTydqTwG9bk2QGcR9X/Zls3UdQaimYeoVbA2h5gx60D4XQj 8/wn8pMIC7jH8QyCJ7qpkdx1H6sgPtsu2yyaisc65qAUhtiZscnE8QjT4S/XqziSGZYc pj3g== X-Received: by 10.68.130.169 with SMTP id of9mr13547074pbb.79.1385308658275; Sun, 24 Nov 2013 07:57:38 -0800 (PST) Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-u1.redhat.com. [66.187.238.11]) by mx.google.com with ESMTPSA id qz9sm65852408pbc.3.2013.11.24.07.57.36 for <15910@debbugs.gnu.org> (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Nov 2013 07:57:37 -0800 (PST) References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3 From: Kenjiro NAKAYAMA To: 15910@debbugs.gnu.org Subject: Re: bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Date: Mon, 25 Nov 2013 00:57:33 +0900 Message-ID: <87r4a5iyhe.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15910 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Thank you for your review, Ted, Masatake. OK, I try to revise the patch to add eww own history stack. And I put ChangeLog entry to my report next time. Kenjiro From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 25 09:53:58 2013 Received: (at 15910) by debbugs.gnu.org; 25 Nov 2013 14:53:58 +0000 Received: from localhost ([127.0.0.1]:43910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkxXx-0007WW-5p for submit@debbugs.gnu.org; Mon, 25 Nov 2013 09:53:57 -0500 Received: from mail-qa0-f49.google.com ([209.85.216.49]:36144) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkxXk-0007VU-Kc for 15910@debbugs.gnu.org; Mon, 25 Nov 2013 09:53:50 -0500 Received: by mail-qa0-f49.google.com with SMTP id ii20so6391396qab.1 for <15910@debbugs.gnu.org>; Mon, 25 Nov 2013 06:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=qWUNK7tujuvY1LeWael8BAImYMcDGKq1z4bF0sqq/HQ=; b=K+ruOlrRhxTtrsMfUMCmYSr6vdZxEl19MxXAaluBAvrXrfowd3t4mSU77UWUkhd3la qaIVtTCRbdrZMWqZA7iYZkhq6FbrlWrWhUdCusgW74ZAMwnY29uDu8qyS657txjexA9a EHKigiWVus+rMKNfk2P8DUBrCYX0tUcoPsMrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=qWUNK7tujuvY1LeWael8BAImYMcDGKq1z4bF0sqq/HQ=; b=IFrygoGOfxcW3aDizWyFvOZj+eInoem4vtpL1cWrclhWTCiz3Vr86YIbB6FucRA+ms 2jwqUu2WedELwojTSEU7QRNZmZS2lostQqyAb9rSZWLsync82d/0N85wEMJQ9Ko9WyZl q7RmEDFa9w73R9ev/uJGXj6wtp6VE48/yyhR6kNhOpShz8J7uYk/j8z2qDqlcNijcqeG WZKcldUhIBOhKxpxzCKhRJAXpjJzlOU4X0vdSiZVo2Nk+LklJLBTnfslb8+rGKjf2MTP ytY5fHV8f0xF0TTcqtukh6VUcNMjpK2pd28aRsBCWL5qEA3Mj8n4c6Uck8d63FTgUG3O 7AVQ== X-Gm-Message-State: ALoCoQloYxDr5ShfSo+vuHUqu8KS834WDd6s66qgXyFol160hORVkvmSOc1cXdnbX97/3xqBihI2 X-Received: by 10.229.182.69 with SMTP id cb5mr46240214qcb.19.1385391218892; Mon, 25 Nov 2013 06:53:38 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id b4sm8193641qai.7.2013.11.25.06.53.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2013 06:53:38 -0800 (PST) From: Ted Zlatanov To: Kenjiro NAKAYAMA Subject: Re: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Mon, 25 Nov 2013 09:54:32 -0500 In-Reply-To: <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Mon, 25 Nov 2013 00:15:52 +0900, Sun, 24 Nov 2013 23:41:44 +0900, Sun, 24 Nov 2013 23:12:47 +0900, Mon, 25 Nov 2013 00:57:33 +0900") Message-ID: <87bo18351z.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15910 Cc: 15910@debbugs.gnu.org, Kenjiro NAKAYAMA , 15966@debbugs.gnu.org, 15967@debbugs.gnu.org, 15965@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thank you for the patches. All of them are OK to go in IMO (and tiny changes). Could you consolidate them in a single patch with a ChangeLog please? It can wait for your eww history stack changes or can be submitted sooner. Thanks Ted On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA wrote: KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it KN> doesn't save current URL in eww-history. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA wrote: KN> eww should ask "yes or no" when add current page to bookmarks, since KN> only "b" key to add bookmarks is easy to mistake. KN> (My bookmarklist has amazingly increased.) KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA wrote: KN> eww should ask "yes or no" before quitting, since only "q" key to quit is KN> easy to mistake. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-quit): ask confirmation before quitting eww On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA wrote: KN> Thank you for your review, Ted, Masatake. KN> OK, I try to revise the patch to add eww own history stack. KN> And I put ChangeLog entry to my report next time. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 06:52:08 2013 Received: (at 15910) by debbugs.gnu.org; 26 Nov 2013 11:52:08 +0000 Received: from localhost ([127.0.0.1]:45469 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlHBX-00010q-Rj for submit@debbugs.gnu.org; Tue, 26 Nov 2013 06:52:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28909) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlHBT-00010D-90; Tue, 26 Nov 2013 06:52:04 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQBq0r8023039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Nov 2013 06:52:00 -0500 Received: from dhcp-193-97.nrt.redhat.com (ovpn-116-21.sin2.redhat.com [10.67.116.21]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAQBpoPU016999 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 26 Nov 2013 06:51:57 -0500 References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> <87bo18351z.fsf@flea.lifelogs.com> User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3 From: Kenjiro NAKAYAMA To: Ted Zlatanov Subject: Re: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. In-reply-to: <87bo18351z.fsf@flea.lifelogs.com> Date: Tue, 26 Nov 2013 20:51:49 +0900 Message-ID: <87haazxtwq.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 15910 Cc: Kenjiro NAKAYAMA , 15966@debbugs.gnu.org, 15967@debbugs.gnu.org, 15965@debbugs.gnu.org, 15910@debbugs.gnu.org, Kenjiro NAKAYAMA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Thanks, Ted. I consolidated the patches, please include the patch if appreciated. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. (eww-add-bookmark): ask confirmation when add to bookmarks (eww-quit): ask confirmation before quitting eww --- lisp/net/eww.el | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 86e0977..4b8b067 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'." (defun eww-quit () "Exit the Emacs Web Wowser." (interactive) - (setq eww-history nil) - (kill-buffer (current-buffer))) + (if (y-or-n-p "quit eww? ") + (progn + (setq eww-history nil) + (kill-buffer (current-buffer))))) (defun eww-back-url () "Go to the previously displayed page." @@ -964,14 +966,16 @@ The browser to used is specified by the `shr-external-browser' variable." (when (equal eww-current-url (plist-get bookmark :url)) (error "Already bookmarked"))) - (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) - (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) - (push (list :url eww-current-url - :title title - :time (current-time-string)) - eww-bookmarks)) - (eww-write-bookmarks) - (message "Bookmarked %s (%s)" eww-current-url eww-current-title)) + (if (y-or-n-p "add bookmark this page? ") + (progn + (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) + (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) + (push (list :url eww-current-url + :title title + :time (current-time-string)) + eww-bookmarks)) + (eww-write-bookmarks) + (message "Bookmarked %s (%s)" eww-current-url eww-current-title)))) (defun eww-write-bookmarks () (with-temp-file (expand-file-name "eww-bookmarks" user-emacs-directory) @@ -1063,7 +1067,7 @@ The browser to used is specified by the `shr-external-browser' variable." ;; just let it remain. (ignore-errors (delete-window)) - (eww (plist-get bookmark :url)))) + (eww-browse-url (plist-get bookmark :url)))) (defun eww-next-bookmark () "Go to the next bookmark in the list." -- 1.8.3.1 Thanks, Kenjiro Nakayama tzz@lifelogs.com writes: > Thank you for the patches. All of them are OK to go in IMO (and tiny > changes). Could you consolidate them in a single patch with a ChangeLog > please? It can wait for your eww history stack changes or can be > submitted sooner. > > Thanks > Ted > > On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA wrote: > > KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it > KN> doesn't save current URL in eww-history. > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. > > On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA wrote: > > KN> eww should ask "yes or no" when add current page to bookmarks, since > KN> only "b" key to add bookmarks is easy to mistake. > KN> (My bookmarklist has amazingly increased.) > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks > > On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA wrote: > > KN> eww should ask "yes or no" before quitting, since only "q" key to quit is > KN> easy to mistake. > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-quit): ask confirmation before quitting eww > > On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA wrote: > > KN> Thank you for your review, Ted, Masatake. > > KN> OK, I try to revise the patch to add eww own history stack. > KN> And I put ChangeLog entry to my report next time. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 15:09:44 2013 Received: (at 15910-done) by debbugs.gnu.org; 26 Nov 2013 20:09:44 +0000 Received: from localhost ([127.0.0.1]:46406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlOx6-0007cE-4w for submit@debbugs.gnu.org; Tue, 26 Nov 2013 15:09:44 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:43197) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlOx3-0007be-BB for 15910-done@debbugs.gnu.org; Tue, 26 Nov 2013 15:09:41 -0500 Received: by mail-qa0-f54.google.com with SMTP id f11so9406355qae.20 for <15910-done@debbugs.gnu.org>; Tue, 26 Nov 2013 12:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=lbS17yWHObDqu32QyHYDdVN/OFwbTByvzNzVziwMtAY=; b=Hkb6PKwxO57q0L8wnH6hCAY9qabknhoGuYsxUeddCYb4tZQL/IR5MzsFt60OXyTTcx E+e6jlKR4EGptjbPqv/uIygBPGvVoue7h1szabW6LfF6dXnukieihEpVt3i6fWFet8Cz SUeK17WED0r6cnEWcunPD87sAlgi7v8DDG4xU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=lbS17yWHObDqu32QyHYDdVN/OFwbTByvzNzVziwMtAY=; b=PRqkGw232FF/TBWz5SQjpDnJy6gkPuZgb6N7Q4T6SChoLkA+ciQ/rOH+tesmEBQkg8 D7Ww5NPysdrXM7+Amp3dGbTZ+GqfaKT3aJIhjnFpwESe3M2Sw8Wg3rEINopLfMWUwAWn CMhxT1gptNoGqH2qXT5jTUOc+O0OP3xGLWCMe2+mK6IUUvhj7QE9ydHSlZjHQp/1ekNT C1Dmb1o/y0eCGeAor1MVZEMbObgJgbcH2tvT1Mcy49WmYunXKAgX8PTEQSs4nS9hRncv /MhxjXy+6xeh5GKrP02gEj9YRPGU+QTCO6aMGGqkueMLFkfpNbK8F0fO2ANjfbDeB8kl nN+w== X-Gm-Message-State: ALoCoQmpKPkALY/JKtEc9x5rDBd+f2QrXE8IyOurDvCfnBIYGl2CPqbbqLuJvVLyLbPQfjFR0XZH X-Received: by 10.224.72.15 with SMTP id k15mr59681105qaj.58.1385496575754; Tue, 26 Nov 2013 12:09:35 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id m7sm25993436qax.8.2013.11.26.12.09.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2013 12:09:35 -0800 (PST) From: Ted Zlatanov To: Kenjiro NAKAYAMA Subject: Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> <87bo18351z.fsf@flea.lifelogs.com> <87haazxtwq.fsf@dhcp-193-97.nrt.redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 26 Nov 2013 15:10:31 -0500 In-Reply-To: <87haazxtwq.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Tue, 26 Nov 2013 20:51:49 +0900") Message-ID: <8761rezzyg.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15910-done Cc: 15965-done@debbugs.gnu.org, Kenjiro NAKAYAMA , 15966-done@debbugs.gnu.org, 15910-done@debbugs.gnu.org, 15967-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA wrote: KN> I consolidated the patches, please include the patch if appreciated. OK; done. I changed "add bookmark this page?" to "bookmark this page?" but otherwise had no issues. Thanks! Ted From unknown Sat Aug 16 21:12:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Dec 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator