From unknown Tue Jun 17 22:28:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15895: describe-package inserts invalid buffer when readme buffer killed in after-save-hook Resent-From: Kazuhiro NISHIYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Nov 2013 16:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15895 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 15895@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138444797030796 (code B ref -1); Thu, 14 Nov 2013 16:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Nov 2013 16:52:50 +0000 Received: from localhost ([127.0.0.1]:52326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vh09v-00080b-1V for submit@debbugs.gnu.org; Thu, 14 Nov 2013 11:52:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54109) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vgy2S-0004Va-CP for submit@debbugs.gnu.org; Thu, 14 Nov 2013 09:36:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vgy2D-00027x-GC for submit@debbugs.gnu.org; Thu, 14 Nov 2013 09:36:50 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00, RCVD_IN_BL_SPAMCOP_NET autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgy2D-00027r-Df for submit@debbugs.gnu.org; Thu, 14 Nov 2013 09:36:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55741) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgy25-00007L-V7 for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2013 09:36:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vgy1y-00024W-An for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2013 09:36:33 -0500 Received: from msag502.nifty.com ([202.248.238.123]:61787) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgy1x-00022k-QV for bug-gnu-emacs@gnu.org; Thu, 14 Nov 2013 09:36:26 -0500 Received: from ns6.n-z.jp (ns6.n-z.jp [49.212.131.170]) (authenticated) by msag502.nifty.com with ESMTP id rAEEaJp5015432; Thu, 14 Nov 2013 23:36:19 +0900 X-Nifty-SrcIP: [49.212.131.170] Date: Thu, 14 Nov 2013 23:36:19 +0900 Message-ID: From: Kazuhiro NISHIYAMA User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL/10.8 Emacs/23.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -2.8 (--) X-Mailman-Approved-At: Thu, 14 Nov 2013 11:52:45 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I use delete-file-if-no-contents in after-save-hook, and open git-gutter-fringe or git-gutter-fringe+ from *Packages* buffer, the hook asks me "Delete file and kill buffer?". When I answer "y", the buffer for *-readme.txt killed, and buffer-string after save-buffer in describe-package-1 returns from invalid buffer's content. I think that buffer-string should be before save-buffer. From unknown Tue Jun 17 22:28:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15895: describe-package inserts invalid buffer when readme buffer killed in after-save-hook In-Reply-To: Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Nov 2013 22:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15895 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Kazuhiro NISHIYAMA Cc: 15895@debbugs.gnu.org Received: via spool by 15895-submit@debbugs.gnu.org id=B15895.138464215022611 (code B ref 15895); Sat, 16 Nov 2013 22:50:01 +0000 Received: (at 15895) by debbugs.gnu.org; 16 Nov 2013 22:49:10 +0000 Received: from localhost ([127.0.0.1]:57577 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhoft-0005sb-K4 for submit@debbugs.gnu.org; Sat, 16 Nov 2013 17:49:10 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:58775 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhofr-0005sU-Ra for 15895@debbugs.gnu.org; Sat, 16 Nov 2013 17:49:08 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vhofp-0004uu-T7; Sat, 16 Nov 2013 17:49:05 -0500 From: Glenn Morris References: X-Spook: Fedayeen bomb oil Mahmoud Ahmadinejad crypto anarchy X-Ran: 9ZReT3*}sJsta2\=brU'tTfop8kIkT\@hTlItaO7k'[',oM(DT8rzh'lOJDR,8Tn{*BARh X-Hue: cyan X-Attribution: GM Date: Sat, 16 Nov 2013 17:49:05 -0500 Message-ID: <3w4n7caroe.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Kazuhiro NISHIYAMA wrote: > I use delete-file-if-no-contents in after-save-hook, and open > git-gutter-fringe or git-gutter-fringe+ from *Packages* buffer, the > hook asks me "Delete file and kill buffer?". When I answer "y", the > buffer for *-readme.txt killed, and buffer-string after save-buffer in > describe-package-1 returns from invalid buffer's content. I'm going to say: "don't do that then". There are ~ 200 calls to save-buffer in the Emacs sources, and I imagine none of them expect save-buffer to kill the buffer in question. Maybe some of them should be using something lower-level like write-region, but I'm not going to bother to check them. I suggest you make your delete-file-if-no-contents thing only take effect in _interactive_ calls to save-buffer. > I think that buffer-string should be before save-buffer. Then it would not get the (minor) benefit of require-final-newline. Obviously, we could reimplement that, but I don't think we should have to bother. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 28 14:45:44 2013 Received: (at control) by debbugs.gnu.org; 28 Nov 2013 19:45:44 +0000 Received: from localhost ([127.0.0.1]:49168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vm7Wx-00016i-G2 for submit@debbugs.gnu.org; Thu, 28 Nov 2013 14:45:43 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:43500 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vm7Wt-00016W-C6 for control@debbugs.gnu.org; Thu, 28 Nov 2013 14:45:40 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vm7Ws-0006W8-Nj for control@debbugs.gnu.org; Thu, 28 Nov 2013 14:45:38 -0500 Date: Thu, 28 Nov 2013 14:45:38 -0500 Message-Id: Subject: control message for bug 15895 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) tag 15895 wontfix close 15895