GNU bug report logs - #15892
24.3.50; Cygw32 build break

Previous Next

Package: emacs;

Reported by: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>

Date: Thu, 14 Nov 2013 11:31:02 UTC

Severity: important

Tags: patch

Found in version 24.3.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15892: closed (24.3.50; Cygw32 build break)
Date: Thu, 14 Nov 2013 17:46:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Thu, 14 Nov 2013 19:45:15 +0200
with message-id <83habezxlg.fsf <at> gnu.org>
and subject line Re: bug#15892: 24.3.50; Cygw32 build break
has caused the debbugs.gnu.org bug report #15892,
regarding 24.3.50; Cygw32 build break
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15892: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15892
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Cygw32 build break
Date: Thu, 14 Nov 2013 20:30:07 +0900
Because make_ctrl_char and erase_phys_cursor are defined as static
functions on Cygw32, Cygw32 can't be built on trunk.
Please see the below patch.

=== modified file 'src/keyboard.c'
--- src/keyboard.c	2013-11-11 05:18:53 +0000
+++ src/keyboard.c	2013-11-12 23:43:34 +0000
@@ -2086,7 +2086,7 @@
 
 /* Apply the control modifier to CHARACTER.  */
 
-#ifndef WINDOWSNT
+#ifndef HAVE_NTGUI
 static
 #endif
 int

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2013-11-08 10:21:35 +0000
+++ src/xdisp.c	2013-11-10 23:28:15 +0000
@@ -26345,7 +26345,7 @@
 
 /* Erase the image of a cursor of window W from the screen.  */
 
-#ifndef WINDOWSNT
+#ifndef HAVE_NTGUI
 static
 #endif
 void


-- 
Kazuhiro Ito


[Message part 3 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Cc: 15892-done <at> debbugs.gnu.org
Subject: Re: bug#15892: 24.3.50; Cygw32 build break
Date: Thu, 14 Nov 2013 19:45:15 +0200
> Date: Thu, 14 Nov 2013 20:30:07 +0900
> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
> From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
> 
> Because make_ctrl_char and erase_phys_cursor are defined as static
> functions on Cygw32, Cygw32 can't be built on trunk.
> Please see the below patch.

Thanks, installed.


This bug report was last modified 11 years and 192 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.