GNU bug report logs - #1589
23.0.60; vc-dir erroneously reports "No changes between working revision and workfile"

Previous Next

Package: emacs;

Reported by: Eric Hanchrow <eric.hanchrow <at> gmail.com>

Date: Wed, 17 Dec 2008 06:55:39 UTC

Severity: normal

Tags: patch

Merged with 2055, 2641, 3088, 3359, 4207

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: bug-gnu-emacs <at> gnu.org (Emacs bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: emacs-bug-tracker <at> debbugs.gnu.org
Subject: bug#2055: marked as done (23.0.60; vc-dired doesn't work right
 with Git)
Date: Wed, 27 Jan 2010 20:37:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 27 Jan 2010 15:36:29 -0500
with message-id <65bpgfmgj6.fsf <at> fencepost.gnu.org>
and subject line Re: bug#1589: vc-dir erroneously reports "No changes between working revision and workfile"
has caused the Emacs bug report #1589,
regarding 23.0.60; vc-dired doesn't work right with Git
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs <at> gnu.org
immediately.)


-- 
1589: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1589
Emacs Bug Tracking System
Contact bug-gnu-emacs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ian Eure <ian <at> digg.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; vc-dired doesn't work right with Git
Date: Sun, 25 Jan 2009 11:05:40 -0800
If you run vc-dired in a directory below the top of a Git working
copy, vc-dired gets confused.

e.g.:

project-a
project-a/lib

If you run vc-dired in lib, the paths in the buffer are relative to
the root, project-a. Subsequent commands on the dired buffer fail to
run, since they pass a nonexistent path to git.

The issue seems to be that vc-dired calls git diff-index, which shows
all paths relative to the WC root rather than the CWD.

In GNU Emacs 23.0.60.1 (i386-apple-darwin9.6.0, NS
apple-appkit-949.43)
 of 2009-01-20 on neutron.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL:
  value of $LC_COLLATE: en_US.UTF-8
  value of $LC_CTYPE: en_US.UTF-8
  value of $LC_MESSAGES: en_US.UTF-8
  value of $LC_MONETARY: en_US.UTF-8
  value of $LC_NUMERIC: en_US.UTF-8
  value of $LC_TIME: en_US.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: VC dir

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-b C-b <return> M-( <tab> m a p c o n c a t SPC M-(
l a m b d a SPC f i l e M-b M-1 M-( M-f C-f SPC f i
l e C-f <return> <tab> f o ; e s <backspace> <backspace>
<backspace> <backspace> i l e s SPC M-" " SPC " C-e
C-x C-e C-x v d ~ / P { r <tab> <backspace> <backspace>
r <tab> t i n <tab> <return> C-x 5 b * M e s s a g
e s * <return> M-` <escape> C-g <switch-frame> <down-mouse-1>
<mouse-movement> <mouse-1> C-SPC C-M-f M-w C-p C-p
C-b C-b C-e C-x o C-x v d t i n <tab> <return> M-`
C-g C-x o C-x b s h e l C-g M-x s h e l <return> g
i t SPC l s - f i l e s SPC - z SPC - o SPC - - d i
r e c t o r y SPC - - n o <M-backspace> <M-backspace>
<M-backspace> <M-backspace> <backspace> M-` C-g <help-echo>
<help-echo> <help-echo> <switch-frame> <down-mouse-1>
<mouse-movement> <mouse-1> C-SPC C-e C-b C-b M-w <switch-frame>
<backspace> <backspace> <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> C-y
<return> <return> c d SPC t i n <tab> <return> M-p
M-p <return> <switch-frame> <down-mouse-1> <mouse-movement>
<mouse-1> C-SPC C-e C-b C-b M-w <switch-frame> g i
t SPC C-y <return> M-x k <backspace> m a n <return>
g i t - d i f f - i n t e <backspace> <backspace> d
e x <return> <help-echo> <down-mouse-1> <mouse-1> <wheel-down>
<down-mouse-1> <mouse-1> M-p <help-echo> <help-echo>
<down-mouse-1> <mouse-1> M-p SPC . <return> C-x o C-x
b <return> C-n C-n C-n C-n C-n C-n C-n C-n C-n C-e
C-b = <help-echo> <help-echo> <help-echo> <help-echo>
<switch-frame> <switch-frame> <help-echo> <help-echo>
<down-mouse-1> <mouse-1> <menu-bar> <help-menu> <s
end-emacs-bug-report>

Recent messages:
History item: 2
Mark set [2 times]
Invoking man git-diff-index in the background
Please wait: formatting the git-diff-index man page...
git-diff-index man page formatted
comint-search-arg: Not at command line
History item: 1
Finding changes in
/Users/ieure/Projects/tinymetalhands.com/tinymetalhands/tinymetalhands/ 
products/models.py...
git (diff-index --exit-code -p HEAD nil --)
/Users/ieure/Projects/tinymetalhands.com/tinymetalhands/tinymetalhands/ 
products/models.py
No changes between working revision and workfile


[Message part 3 (message/rfc822, inline)]
From: Glenn Morris <rgm <at> gnu.org>
To: 1589-done <at> debbugs.gnu.org
Subject: Re: bug#1589: vc-dir erroneously reports "No changes between working
	revision and workfile"
Date: Wed, 27 Jan 2010 15:36:29 -0500
It seems this patch was installed, thanks.

2010-01-25  Eric Hanchrow  <eric.hanchrow at gmail.com>  (tiny change)

  * vc-git.el (vc-git-dir-status-goto-stage): Pass --relative to the
  diff-index command.  This requires at least git-1.5.5.


This bug report was last modified 15 years and 114 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.