GNU bug report logs - #15887
Possibly incorrect custom :types

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15887 in the body.
You can then email your comments to 15887 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: Possibly incorrect custom :types
Date: Wed, 13 Nov 2013 15:19:35 -0500

Package: org-mode

cus-test.el suggests the following variables may have incorrect
custom :types. (There may be some false positives.)
This refers to Org mode in current Emacs trunk.

Eg, org-texinfo-filename does not have "nil" as an option.

org-agenda-deadline-leaders
org-agenda-search-view-max-outline-level
org-ascii-format-drawer-function
org-ascii-format-inlinetask-function
org-babel-latex-htlatex
org-babel-latex-htlatex-packages
org-babel-lob-files
org-babel-python-None-to
org-babel-python-mode
org-babel-ruby-nil-to
org-export-async-init-file
org-export-with-creator
org-html-format-drawer-function
org-html-format-headline-function
org-html-format-inlinetask-function
org-html-with-latex
org-latex-format-drawer-function
org-latex-format-inlinetask-function
org-log-note-headings
org-mouse-1-follows-link
org-odt-format-drawer-function
org-odt-format-headline-function
org-odt-format-inlinetask-function
org-odt-with-latex
org-plantuml-jar-path
org-texinfo-filename
org-texinfo-format-drawer-function
org-texinfo-format-headline-function
org-texinfo-format-inlinetask-function
orgstruct-heading-prefix-regexp

Message #6 received at 15887 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 15887 <at> debbugs.gnu.org
Subject: Re: bug#15887: Possibly incorrect custom :types
Date: Thu, 14 Nov 2013 14:11:54 +0100

Glenn Morris <rgm <at> gnu.org> writes:

> Package: org-mode
>
> cus-test.el suggests the following variables may have incorrect
> custom :types. (There may be some false positives.)
> This refers to Org mode in current Emacs trunk.
>
> Eg, org-texinfo-filename does not have "nil" as an option.
>
> org-agenda-deadline-leaders
> org-agenda-search-view-max-outline-level
> org-ascii-format-drawer-function
> org-ascii-format-inlinetask-function
> org-babel-latex-htlatex
> org-babel-latex-htlatex-packages
> org-babel-lob-files
> org-babel-python-None-to
> org-babel-python-mode
> org-babel-ruby-nil-to
> org-export-async-init-file
> org-export-with-creator
> org-html-format-drawer-function
> org-html-format-headline-function
> org-html-format-inlinetask-function
> org-html-with-latex
> org-latex-format-drawer-function
> org-latex-format-inlinetask-function
> org-log-note-headings
> org-mouse-1-follows-link
> org-odt-format-drawer-function
> org-odt-format-headline-function
> org-odt-format-inlinetask-function
> org-odt-with-latex
> org-plantuml-jar-path
> org-texinfo-filename
> org-texinfo-format-drawer-function
> org-texinfo-format-headline-function
> org-texinfo-format-inlinetask-function
> orgstruct-heading-prefix-regexp

I fixed those problems in Org's maintainance branch, this will be part
of the next merge.  Thanks!

-- 
 Bastien

Message #11 received at 15887 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Bastien <bzg <at> gnu.org>
Cc: 15887 <at> debbugs.gnu.org
Subject: Re: bug#15887: Possibly incorrect custom :types
Date: Thu, 14 Nov 2013 12:18:04 -0500

I glanced at the diff. I'm not sure the :set changes are correct.
Won't this make it impossible to customize these options?
Those cases may have been some of the false positives I mentioned.
Eg

(if (or (featurep 'xemacs) (featurep 'python-mode)) 'python-mode 'python)

is fine for :type 'function, but cus-test is simple-minded and
doesn't realize that the result of the expression will always be a
function, so it gives a bogus warning.

Message #14 received at 15887 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 15887 <at> debbugs.gnu.org
Subject: Re: bug#15887: Possibly incorrect custom :types
Date: Fri, 15 Nov 2013 06:25:48 +0100

Hi Glenn,

Glenn Morris <rgm <at> gnu.org> writes:

> I glanced at the diff. I'm not sure the :set changes are correct.
> Won't this make it impossible to customize these options?
> Those cases may have been some of the false positives I mentioned.
> Eg
>
> (if (or (featurep 'xemacs) (featurep 'python-mode)) 'python-mode 'python)
>
> is fine for :type 'function, but cus-test is simple-minded and
> doesn't realize that the result of the expression will always be a
> function, so it gives a bogus warning.

Thanks for pointing this, I misunderstood the purpose of :set.
This is fixed in the maint branch.

-- 
 Bastien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.