From unknown Fri Aug 08 19:52:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15879: [PATCH 1/9] parted: fix EOF and ctrl-c handling Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Tue, 12 Nov 2013 21:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15879 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: bcl@redhat.com, 15879@debbugs.gnu.org X-Debbugs-Original-To: "Brian C. Lane" , bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138429163020529 (code B ref -1); Tue, 12 Nov 2013 21:28:01 +0000 Received: (at submit) by debbugs.gnu.org; 12 Nov 2013 21:27:10 +0000 Received: from localhost ([127.0.0.1]:49244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgLUL-0005L2-Vf for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:27:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50926) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgLUK-0005Kq-3W for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:27:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgLU7-0008QV-QA for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:27:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgLU7-0008QR-NY for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:26:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgLU1-0004mR-JF for bug-parted@gnu.org; Tue, 12 Nov 2013 16:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgLTv-0008OK-J6 for bug-parted@gnu.org; Tue, 12 Nov 2013 16:26:49 -0500 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:35417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgLTv-0008OD-Fa for bug-parted@gnu.org; Tue, 12 Nov 2013 16:26:43 -0500 X-Authority-Analysis: v=2.0 cv=FKiZNpUs c=1 sm=0 a=/DbS/tiKggfTkRRHPZEB4g==:17 a=Qsx_du5GiBkA:10 a=1YbsQLIiAAQA:10 a=NT4lqMBm0uwA:10 a=S1A5HrydsesA:10 a=8nJEP1OIZ-IA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=FCrHShHBedcA:10 a=QfKxxUxMAAAA:8 a=3WdplfwBV8liNTXC2b0A:9 a=wPNLvfGTeEIA:10 a=/DbS/tiKggfTkRRHPZEB4g==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.78.168.186 Received: from [67.78.168.186] ([67.78.168.186:55151] helo=[10.1.1.236]) by cdptpa-oedge03.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id DB/B0-01931-21D92825; Tue, 12 Nov 2013 21:26:42 +0000 Message-ID: <52829D12.3010201@ubuntu.com> Date: Tue, 12 Nov 2013 16:26:42 -0500 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 References: <1372648321-1631-1-git-send-email-psusi@ubuntu.com> <20130809004517.GQ3094@lister.brianlane.com> In-Reply-To: <20130809004517.GQ3094@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 It has been a while again Brian so I thought I'd touch base again and hope to push some patches this week and get on making a release. I agreed your patch was better than #4, fixed #5, agreed to table #7 for now, and made sure #8 does not allow the user to create the errors. I just wanted to make sure that you came around on #6 and #9 before I push them. On 8/8/2013 8:45 PM, Brian C. Lane wrote: > 1/9 - Ack. 2/9 - Ack. 3/9 - Ack. 0 sized data area just doesn't > make sense anyway. 4/9 - Nak. I have a more general patch for this > -- not everything inserts DMRAID in there. 5/9 - Shouldn't it use > disk->dev->sector_size instead of hard-coded 512/1024? The logic > seems a bit messy, using an if block instead of the == 1 ? 512 : > 1024 may clean it up a little. If it is already set to 512 (or > really ->sector_size) we don't need to walk the other partitions. > One place where a tab snuck in. Looks pretty ok other than that. > 6/9 - Nak. I'm not sure if this is the right way to handle things. > 7/9 - Nak. I really don't like the giant pile of changes for a > problem that is only in the gpt code. 8/9 - Nak. It looks to me > like removing some of these checks is going to allow user (ui or > library) checks that should fail on new data to pass. I'm ok with > letting us run with these errors so we can fix them, but you > shouldn't be able to enter bad numbers after the warnings. 9/9 - > Nak. I need more details here. The reasoning in the original commit > seems sound to me, and I'd be more worried about busy devices than > the filesystem not matching (I'm not sure we should even be in the > fs detection business anymore). > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSgp0SAAoJEJrBOlT6nu75HNUH/jYmQ2kGYxFieCyFx/E2K69O whNsuxt0Zwo8QHllTnWSrZJ6AEUcmXG2NJDmUUHZQ6SsZWxvyGRmkpD+495up148 KQEVBBtvkQg06Ku3+iOeYC8k0eh+mIzy97JghQQeEDPr6WibCxrSKwT9KTE8Sxur UJ8gJkL/qsJW5hLW4J3B4G/zFHsDNyDbP0kDNaZQI6eRyHSvwh0dczZuRuTC4B5A ahcdFaSpZCy1cx7BLQCHlH2h7wF4+GMa1mtSqVchpAk3WMzF5mYhSWJk0+e0udJg vf0HbnGkCITE5wPnEjs4LgjTErk8BxveMG6maH+dIPfqFjlU+pygIboq2S6zFZI= =EJhI -----END PGP SIGNATURE----- From unknown Fri Aug 08 19:52:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15879: [PATCH 1/9] parted: fix EOF and ctrl-c handling Resent-From: "Brian C. Lane" Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Wed, 13 Nov 2013 20:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15879 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: Phillip Susi Cc: 15879@debbugs.gnu.org X-Debbugs-Original-Cc: bug-parted@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13843738272800 (code B ref -1); Wed, 13 Nov 2013 20:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Nov 2013 20:17:07 +0000 Received: from localhost ([127.0.0.1]:50550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vggs6-0000j5-J2 for submit@debbugs.gnu.org; Wed, 13 Nov 2013 15:17:07 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48799) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vggs3-0000iX-4M for submit@debbugs.gnu.org; Wed, 13 Nov 2013 15:17:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vggrp-0007RK-Hl for submit@debbugs.gnu.org; Wed, 13 Nov 2013 15:16:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vggrp-0007RC-EF for submit@debbugs.gnu.org; Wed, 13 Nov 2013 15:16:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vggrj-0004C8-5u for bug-parted@gnu.org; Wed, 13 Nov 2013 15:16:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vggrd-0007CP-5U for bug-parted@gnu.org; Wed, 13 Nov 2013 15:16:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vggrc-0007B7-UV for bug-parted@gnu.org; Wed, 13 Nov 2013 15:16:37 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rADKGY55007147 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Nov 2013 15:16:35 -0500 Received: from lister.brianlane.com (ovpn-113-22.phx2.redhat.com [10.3.113.22]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rADKGXwG012604 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 13 Nov 2013 15:16:34 -0500 Date: Wed, 13 Nov 2013 12:16:33 -0800 From: "Brian C. Lane" Message-ID: <20131113201633.GJ32221@lister.brianlane.com> References: <1372648321-1631-1-git-send-email-psusi@ubuntu.com> <20130809004517.GQ3094@lister.brianlane.com> <52829D12.3010201@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <52829D12.3010201@ubuntu.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On Tue, Nov 12, 2013 at 04:26:42PM -0500, Phillip Susi wrote: > It has been a while again Brian so I thought I'd touch base again and > hope to push some patches this week and get on making a release. I > agreed your patch was better than #4, fixed #5, agreed to table #7 for > now, and made sure #8 does not allow the user to create the errors. I > just wanted to make sure that you came around on #6 and #9 before I > push them. Yes, I think those should be ok. -- Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT) From unknown Fri Aug 08 19:52:16 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Phillip Susi Subject: bug#15879: closed ([PATCH 1/9] parted: fix EOF and ctrl-c handling) Message-ID: References: <529DF330.1010605@ubuntu.com> <52829D12.3010201@ubuntu.com> X-Gnu-PR-Message: they-closed 15879 X-Gnu-PR-Package: parted X-Gnu-PR-Keywords: patch Reply-To: 15879@debbugs.gnu.org Date: Tue, 03 Dec 2013 15:06:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1386083163-30010-1" This is a multi-part message in MIME format... ------------=_1386083163-30010-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #15879: [PATCH 1/9] parted: fix EOF and ctrl-c handling which was filed against the parted package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 15879@debbugs.gnu.org. --=20 15879: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15879 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1386083163-30010-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 15879-done) by debbugs.gnu.org; 3 Dec 2013 15:05:29 +0000 Received: from localhost ([127.0.0.1]:56522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnrXV-0007nD-Bj for submit@debbugs.gnu.org; Tue, 03 Dec 2013 10:05:29 -0500 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:34485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnrXS-0007mh-NY for 15879-done@debbugs.gnu.org; Tue, 03 Dec 2013 10:05:27 -0500 X-Authority-Analysis: v=2.0 cv=cq4ZYiEi c=1 sm=0 a=/DbS/tiKggfTkRRHPZEB4g==:17 a=h_Sp9wbh10QA:10 a=XFizzuffRhoA:10 a=S1A5HrydsesA:10 a=Qsx_du5GiBkA:10 a=8nJEP1OIZ-IA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=Nb1BsIEDQYMA:10 a=QfKxxUxMAAAA:8 a=sW_dMt8da1swUmqmE4MA:9 a=wPNLvfGTeEIA:10 a=/DbS/tiKggfTkRRHPZEB4g==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.78.168.186 Received: from [67.78.168.186] ([67.78.168.186:55465] helo=[10.1.1.236]) by cdptpa-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id 57/1E-25023-033FD925; Tue, 03 Dec 2013 15:05:21 +0000 Message-ID: <529DF330.1010605@ubuntu.com> Date: Tue, 03 Dec 2013 10:05:20 -0500 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: 15879-done@debbugs.gnu.org Subject: [PATCH 1/9] parted: fix EOF and ctrl-c handling X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15879-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Duplicate, patch applied. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSnfMwAAoJEI5FoCIzSKrw97gIAIKI06b6gngW1QZ1tEBTFpL+ DJ/gtFnyuhQNNI5qXmpz7AW/rnN7yivuy/T+ZaWXJx4PplnvwyicnAp6AWUm1eXz zEe4O7sR8yEmlZaeC3ImQwVNX+VqRAwpRL9z/iV1pI6F8SxclltuxlOS6PRrw+Mq RGyQEKk/CTRtre5NUVf9fVv7625b6CdOyMQ6sSzlO5SjuOkXmHfsIuFyBt67zxQB PNUKtr78hPOSAeOe4XvDICtde5SmXmoW77Ex2HvKENVH8QUi3wadvd+hUtpNlGTY figChjO5n4reIDJZYQETj5gaTDOaHaQmXWCnbNRfSstZ1UziVEW2fSTVadX4Ohw= =EFtQ -----END PGP SIGNATURE----- ------------=_1386083163-30010-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 12 Nov 2013 21:27:10 +0000 Received: from localhost ([127.0.0.1]:49244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgLUL-0005L2-Vf for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:27:10 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50926) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgLUK-0005Kq-3W for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:27:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgLU7-0008QV-QA for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:27:02 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgLU7-0008QR-NY for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:26:55 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgLU1-0004mR-JF for bug-parted@gnu.org; Tue, 12 Nov 2013 16:26:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VgLTv-0008OK-J6 for bug-parted@gnu.org; Tue, 12 Nov 2013 16:26:49 -0500 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:35417) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VgLTv-0008OD-Fa for bug-parted@gnu.org; Tue, 12 Nov 2013 16:26:43 -0500 X-Authority-Analysis: v=2.0 cv=FKiZNpUs c=1 sm=0 a=/DbS/tiKggfTkRRHPZEB4g==:17 a=Qsx_du5GiBkA:10 a=1YbsQLIiAAQA:10 a=NT4lqMBm0uwA:10 a=S1A5HrydsesA:10 a=8nJEP1OIZ-IA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=FCrHShHBedcA:10 a=QfKxxUxMAAAA:8 a=3WdplfwBV8liNTXC2b0A:9 a=wPNLvfGTeEIA:10 a=/DbS/tiKggfTkRRHPZEB4g==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 67.78.168.186 Received: from [67.78.168.186] ([67.78.168.186:55151] helo=[10.1.1.236]) by cdptpa-oedge03.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id DB/B0-01931-21D92825; Tue, 12 Nov 2013 21:26:42 +0000 Message-ID: <52829D12.3010201@ubuntu.com> Date: Tue, 12 Nov 2013 16:26:42 -0500 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: "Brian C. Lane" , bug-parted@gnu.org Subject: Re: [PATCH 1/9] parted: fix EOF and ctrl-c handling References: <1372648321-1631-1-git-send-email-psusi@ubuntu.com> <20130809004517.GQ3094@lister.brianlane.com> In-Reply-To: <20130809004517.GQ3094@lister.brianlane.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 It has been a while again Brian so I thought I'd touch base again and hope to push some patches this week and get on making a release. I agreed your patch was better than #4, fixed #5, agreed to table #7 for now, and made sure #8 does not allow the user to create the errors. I just wanted to make sure that you came around on #6 and #9 before I push them. On 8/8/2013 8:45 PM, Brian C. Lane wrote: > 1/9 - Ack. 2/9 - Ack. 3/9 - Ack. 0 sized data area just doesn't > make sense anyway. 4/9 - Nak. I have a more general patch for this > -- not everything inserts DMRAID in there. 5/9 - Shouldn't it use > disk->dev->sector_size instead of hard-coded 512/1024? The logic > seems a bit messy, using an if block instead of the == 1 ? 512 : > 1024 may clean it up a little. If it is already set to 512 (or > really ->sector_size) we don't need to walk the other partitions. > One place where a tab snuck in. Looks pretty ok other than that. > 6/9 - Nak. I'm not sure if this is the right way to handle things. > 7/9 - Nak. I really don't like the giant pile of changes for a > problem that is only in the gpt code. 8/9 - Nak. It looks to me > like removing some of these checks is going to allow user (ui or > library) checks that should fail on new data to pass. I'm ok with > letting us run with these errors so we can fix them, but you > shouldn't be able to enter bad numbers after the warnings. 9/9 - > Nak. I need more details here. The reasoning in the original commit > seems sound to me, and I'd be more worried about busy devices than > the filesystem not matching (I'm not sure we should even be in the > fs detection business anymore). > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJSgp0SAAoJEJrBOlT6nu75HNUH/jYmQ2kGYxFieCyFx/E2K69O whNsuxt0Zwo8QHllTnWSrZJ6AEUcmXG2NJDmUUHZQ6SsZWxvyGRmkpD+495up148 KQEVBBtvkQg06Ku3+iOeYC8k0eh+mIzy97JghQQeEDPr6WibCxrSKwT9KTE8Sxur UJ8gJkL/qsJW5hLW4J3B4G/zFHsDNyDbP0kDNaZQI6eRyHSvwh0dczZuRuTC4B5A ahcdFaSpZCy1cx7BLQCHlH2h7wF4+GMa1mtSqVchpAk3WMzF5mYhSWJk0+e0udJg vf0HbnGkCITE5wPnEjs4LgjTErk8BxveMG6maH+dIPfqFjlU+pygIboq2S6zFZI= =EJhI -----END PGP SIGNATURE----- ------------=_1386083163-30010-1-- From unknown Fri Aug 08 19:52:16 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15879: [PATCH 1/9] parted: fix EOF and ctrl-c handling References: <52829D12.3010201@ubuntu.com> In-Reply-To: <52829D12.3010201@ubuntu.com> Resent-From: Phillip Susi Original-Sender: "Debbugs-submit" Resent-CC: bug-parted@gnu.org Resent-Date: Tue, 03 Dec 2013 22:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15879 X-GNU-PR-Package: parted X-GNU-PR-Keywords: patch To: <15879-done@debbugs.gnu.org> Received: via spool by 15879-done@debbugs.gnu.org id=D15879.138611103626601 (code D ref 15879); Tue, 03 Dec 2013 22:51:01 +0000 Received: (at 15879-done) by debbugs.gnu.org; 3 Dec 2013 22:50:36 +0000 Received: from localhost ([127.0.0.1]:56946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vnyna-0006ux-Cx for submit@debbugs.gnu.org; Tue, 03 Dec 2013 17:50:36 -0500 Received: from hub027-nj-1.exch027.serverdata.net ([206.225.167.245]:16446) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnrXM-0007mK-A0 for 15879-done@debbugs.gnu.org; Tue, 03 Dec 2013 10:05:20 -0500 Received: from [10.1.1.236] (67.78.168.186) by east.exch027.serverdata.net (10.240.16.31) with Microsoft SMTP Server (TLS) id 14.3.158.1; Tue, 3 Dec 2013 07:05:06 -0800 Message-ID: <529DF322.3000801@iradimed.com> Date: Tue, 3 Dec 2013 10:05:06 -0500 From: Phillip Susi User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Tue, 03 Dec 2013 17:50:32 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Duplicate, patch applied.