GNU bug report logs - #15879
[PATCH 1/9] parted: fix EOF and ctrl-c handling

Previous Next

Package: parted;

Reported by: Phillip Susi <psusi <at> ubuntu.com>

Date: Tue, 12 Nov 2013 21:28:01 UTC

Severity: normal

Tags: patch

Done: Phillip Susi <psusi <at> ubuntu.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15879 in the body.
You can then email your comments to 15879 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-parted <at> gnu.org:
bug#15879; Package parted. (Tue, 12 Nov 2013 21:28:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Phillip Susi <psusi <at> ubuntu.com>:
New bug report received and forwarded. Copy sent to bug-parted <at> gnu.org. (Tue, 12 Nov 2013 21:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: "Brian C. Lane" <bcl <at> redhat.com>, bug-parted <at> gnu.org
Subject: Re: [PATCH 1/9] parted: fix EOF and ctrl-c handling
Date: Tue, 12 Nov 2013 16:26:42 -0500
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

It has been a while again Brian so I thought I'd touch base again and
hope to push some patches this week and get on making a release.  I
agreed your patch was better than #4, fixed #5, agreed to table #7 for
now, and made sure #8 does not allow the user to create the errors.  I
just wanted to make sure that you came around on #6 and #9 before I
push them.

On 8/8/2013 8:45 PM, Brian C. Lane wrote:
> 1/9 - Ack. 2/9 - Ack. 3/9 - Ack. 0 sized data area just doesn't
> make sense anyway. 4/9 - Nak. I have a more general patch for this
> -- not everything inserts DMRAID in there. 5/9 - Shouldn't it use
> disk->dev->sector_size instead of hard-coded 512/1024? The logic
> seems a bit messy, using an if block instead of the == 1 ? 512 :
> 1024 may clean it up a little. If it is already set to 512 (or
> really ->sector_size) we don't need to walk the other partitions.
> One place where a tab snuck in. Looks pretty ok other than that. 
> 6/9 - Nak. I'm not sure if this is the right way to handle things. 
> 7/9 - Nak. I really don't like the giant pile of changes for a
> problem that is only in the gpt code. 8/9 - Nak. It looks to me
> like removing some of these checks is going to allow user (ui or
> library) checks that should fail on new data to pass. I'm ok with
> letting us run with these errors so we can fix them, but you
> shouldn't be able to enter bad numbers after the warnings. 9/9 -
> Nak. I need more details here. The reasoning in the original commit
> seems sound to me, and I'd be more worried about busy devices than
> the filesystem not matching (I'm not sure we should even be in the
> fs detection business anymore).
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSgp0SAAoJEJrBOlT6nu75HNUH/jYmQ2kGYxFieCyFx/E2K69O
whNsuxt0Zwo8QHllTnWSrZJ6AEUcmXG2NJDmUUHZQ6SsZWxvyGRmkpD+495up148
KQEVBBtvkQg06Ku3+iOeYC8k0eh+mIzy97JghQQeEDPr6WibCxrSKwT9KTE8Sxur
UJ8gJkL/qsJW5hLW4J3B4G/zFHsDNyDbP0kDNaZQI6eRyHSvwh0dczZuRuTC4B5A
ahcdFaSpZCy1cx7BLQCHlH2h7wF4+GMa1mtSqVchpAk3WMzF5mYhSWJk0+e0udJg
vf0HbnGkCITE5wPnEjs4LgjTErk8BxveMG6maH+dIPfqFjlU+pygIboq2S6zFZI=
=EJhI
-----END PGP SIGNATURE-----




Information forwarded to bug-parted <at> gnu.org:
bug#15879; Package parted. (Wed, 13 Nov 2013 20:18:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: bug-parted <at> gnu.org
Subject: Re: [PATCH 1/9] parted: fix EOF and ctrl-c handling
Date: Wed, 13 Nov 2013 12:16:33 -0800
On Tue, Nov 12, 2013 at 04:26:42PM -0500, Phillip Susi wrote:
> It has been a while again Brian so I thought I'd touch base again and
> hope to push some patches this week and get on making a release.  I
> agreed your patch was better than #4, fixed #5, agreed to table #7 for
> now, and made sure #8 does not allow the user to create the errors.  I
> just wanted to make sure that you came around on #6 and #9 before I
> push them.

Yes, I think those should be ok.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)




Reply sent to Phillip Susi <psusi <at> ubuntu.com>:
You have taken responsibility. (Tue, 03 Dec 2013 15:06:02 GMT) Full text and rfc822 format available.

Notification sent to Phillip Susi <psusi <at> ubuntu.com>:
bug acknowledged by developer. (Tue, 03 Dec 2013 15:06:03 GMT) Full text and rfc822 format available.

Message #13 received at 15879-done <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: 15879-done <at> debbugs.gnu.org
Subject: [PATCH 1/9] parted: fix EOF and ctrl-c handling
Date: Tue, 03 Dec 2013 10:05:20 -0500
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Duplicate, patch applied.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSnfMwAAoJEI5FoCIzSKrw97gIAIKI06b6gngW1QZ1tEBTFpL+
DJ/gtFnyuhQNNI5qXmpz7AW/rnN7yivuy/T+ZaWXJx4PplnvwyicnAp6AWUm1eXz
zEe4O7sR8yEmlZaeC3ImQwVNX+VqRAwpRL9z/iV1pI6F8SxclltuxlOS6PRrw+Mq
RGyQEKk/CTRtre5NUVf9fVv7625b6CdOyMQ6sSzlO5SjuOkXmHfsIuFyBt67zxQB
PNUKtr78hPOSAeOe4XvDICtde5SmXmoW77Ex2HvKENVH8QUi3wadvd+hUtpNlGTY
figChjO5n4reIDJZYQETj5gaTDOaHaQmXWCnbNRfSstZ1UziVEW2fSTVadX4Ohw=
=EFtQ
-----END PGP SIGNATURE-----




Information forwarded to bug-parted <at> gnu.org:
bug#15879; Package parted. (Tue, 03 Dec 2013 22:51:01 GMT) Full text and rfc822 format available.

Message #16 received at 15879-done <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> iradimed.com>
To: <15879-done <at> debbugs.gnu.org>
Subject: [PATCH 1/9] parted: fix EOF and ctrl-c handling
Date: Tue, 3 Dec 2013 10:05:06 -0500
Duplicate, patch applied.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 01 Jan 2014 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 11 years and 222 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.