From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 19:21:05 2013 Received: (at submit) by debbugs.gnu.org; 12 Nov 2013 00:21:05 +0000 Received: from localhost ([127.0.0.1]:47582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vg1j6-0006h2-8b for submit@debbugs.gnu.org; Mon, 11 Nov 2013 19:21:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33538) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vg1j4-0006gU-3D for submit@debbugs.gnu.org; Mon, 11 Nov 2013 19:21:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vg1ip-0005BD-6R for submit@debbugs.gnu.org; Mon, 11 Nov 2013 19:20:56 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_50,FROM_BLANK_NAME, T_MANY_HDRS_LCASE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vg1ip-0005B9-3G for submit@debbugs.gnu.org; Mon, 11 Nov 2013 19:20:47 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vg1ih-0001Mz-Lg for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2013 19:20:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vg1ia-00058z-5q for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2013 19:20:39 -0500 Received: from vms173015pub.verizon.net ([206.46.173.15]:53862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vg1iZ-00058l-Tu for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2013 19:20:32 -0500 Received: from consult.pretender ([unknown] [72.93.211.153]) by vms173015.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MW400H2SJLLP860@vms173015.mailsrvcs.net> for bug-gnu-emacs@gnu.org; Mon, 11 Nov 2013 18:20:10 -0600 (CST) Received: from consult.pretender (consult.pretender [127.0.0.1]) by consult.pretender (8.14.4/8.14.4) with ESMTP id rAC0K8T3025141 for ; Mon, 11 Nov 2013 19:20:09 -0500 MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Message-id: <21121.29752.814965.329395@consult.pretender> Date: Mon, 11 Nov 2013 19:20:08 -0500 To: bug-gnu-emacs@gnu.org Subject: Gnutls elisp code doesn't properly check for file existence X-Mailer: VM 8.2.0b under 23.1.1 (i386-redhat-linux-gnu) From: "" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) The function gnutls-negotiate uses the (potentially) magic-file-enabled predicate file-exists-p to check for the "existence" of files in the gnutls-trustfiles list before passing the raw file paths on as-is to the gnutls c-code. The elements of the problem are as follows 1. The predicate file-exists-p potentially references magic-file-handler(s) so that we really are only testing for the existence of the magic-modified file path. At the same time the c-code is unaware of magic-file-handlers and assumes the raw path is a standard OS-accessible path without any magic modification. In particular, I have encountered this inconsistency with the cygwin-mount magic file handler, but the same problem will occur with *any* magic file handler that causes a non-OS recognizable path to test as existing with file-exists-p. 2. When the gnutls c-code is passed a file path that the OS can't find, it crashes the gnutls calling function without any human-readable or understandable error message. The error code passed back is "-64" whic presumably must mean something like "file not found" 3. Gnutls.el implicitly supports cygwin since a cygwin-style trustfile is included in gnutls-trustfiles and labeled as such. This presumably works fine in a cygwin-compiled version of emacs but if one uses a generic windows-native version of Emacs with cygwin-mount as the magic file handler then problems (1) & (2) cause gnutls to crash every time. Luckily, there is a near trivial patch that does the following: i] If the function 'expand-file-name' has an associated magic file handler, the function expand-file-name is called to convert it "to absolute, and canonicalize it" (quoted from the function definition). ii] The test for file-exists-p is then wrapped in a 'let' construct with file-name-handler-alist set to nil. This effectively shuts off magic file handling and ensures that file-exists-p now checks for true OS existence of the now potentially expanded path. iii]The function gnutls-trustfiles is now assured that it will be passed an OS-valid path. --- gnutls.el 2013-03-17 13:52:40.000000000 -0400 +++ gnutls.el.new 2013-10-23 12:47:36.503554500 -0400 @@ -174,7 +174,8 @@ (let* ((type (or type 'gnutls-x509pki)) (trustfiles (or trustfiles (delq nil - (mapcar (lambda (f) (and f (file-exists-p f) f)) + (mapcar (lambda (f) + (and f + (if (find-file-name-handler f 'expand-file-name) + (setq f (expand-file-name f))) + (let (file-name-handler-alist) + (file-exists-p f)) f)) (if (functionp gnutls-trustfiles) (funcall gnutls-trustfiles) gnutls-trustfiles))))) The patch could of course be extended to 'catch' any error and display an error message like "Error: gntuls trustfile xxxxx not found" rather than crashing if somehow there is still a file access issue. I generate the error using the following: (require 'cygwin-mount) (require 'gnutls) (open-gnutls-stream "tls" "tls-buffer" "imap.gmail.com" "imaps") The emacs debugger, gives the following results: Debugger entered--Lisp error: (gnutls-error # -64) signal(gnutls-error (# -64)) gnutls-negotiate(:process # :type gnutls-x509pki :hostname "imap.gmail.com") open-gnutls-stream("tls" "tls-buffer" "imap.gmail.com" "imaps") eval-region(19 83 t #[257 "\300\242b\210\301\207" [(83) (open-gnutls-stream "tls" "tls-buffer" "imap.gmail.com" "imaps")] 2 "\n\n(fn IGNORE)"]) ; Reading at buffer position 83 eval-defun-2() eval-defun(nil) call-interactively(eval-defun nil nil) command-execute(eval-defun) -------------------------------------------------------------------------- In GNU Emacs 24.3.1 (i386-mingw-nt6.1.7601) of 2013-03-17 on MARVIN Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-gcc (4.7) --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' Important settings: value of $LANG: ENU locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: Text Minor modes in effect: shell-dirtrack-mode: t display-time-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t abbrev-mode: t Recent input: r Recent messages: Quit Deleting...done (No files need saving) Marking holidays...done Marking holidays...done Undo! Mark saved where search started [2 times] Making completion list... [3 times] delete-backward-char: Text is read-only [2 times] Making completion list... Load-path shadows: None found. Features: (shadow sort emacsbug echistory chistory solar cal-dst cal-julian cal-hebrew holidays hol-loaddefs cal-move cal-tex jjk-calendar cal-menu calendar cal-loaddefs dired-aux browse-url url-util url-parse url-vars ruler-mode hl-line hexl eldoc mule-util tramp-cmds noutline outline easy-mmode tramp-cache tramp-sh tramp tramp-compat tramp-loaddefs shell pcomplete find-func ebuff-menu pp misearch multi-isearch nxml-uchnm rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok network-stream starttls tls message idna format-spec mml mml-sec mm-decode mm-bodies mm-encode gmm-utils mailheader vm-imap bbdb-gui help-mode flyspell ispell cl-macs gv vm-reply easymenu jjk-vm dired vm-mime-display-internal-application vm-ps-print bbdb-vm vm-autoload bbdb-snarf mail-extr rfc822 bbdb-autoloads bbdb-hooks mail-parse rfc2231 bbdb-com mailabbrev cl vcard vm-vcard vm-pine smtpmail bbdb timezone sendmail rfc2047 rfc2045 ietf-drums mail-utils vm-rfaddons vm-menu vm-window vm-toolbar vm-folder vm-mime vm-undo vm-virtual vm-summary-faces vm-summary vm-mouse vm-page vm-motion vm-minibuf vm-message vm-misc vm-macro vm-autoloads vm-vars vm-version vm jjk-comments jjk-load ps-print ps-def lpr jjk-print ibm-keymaps jjk-frames jjk-hooks jjk-keymaps ehelp electric uniquify warnings arc-mode archive-mode jjk-lib epa-file epa derived epg epg-config advice help-fns cl-lib advice-preload auth-source eieio byte-opt bytecomp byte-compile cconv gnus-util mm-util mail-prsvr password-cache cygwin-mount ange-ftp comint ansi-color ring server time time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32 multi-tty emacs) In GNU Emacs 24.3.1 (i386-mingw-nt6.1.7601) of 2013-03-17 on MARVIN Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-gcc (4.7) --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' Important settings: value of $LANG: ENU locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: Text Minor modes in effect: shell-dirtrack-mode: t display-time-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t auto-fill-function: do-auto-fill transient-mark-mode: t abbrev-mode: t Recent input: r Recent messages: Quit Deleting...done Undo! Mark saved where search started [2 times] Making completion list... [3 times] delete-backward-char: Text is read-only [2 times] Making completion list... Load-path shadows: None found. Features: (shadow sort emacsbug echistory chistory solar cal-dst cal-julian cal-hebrew holidays hol-loaddefs cal-move cal-tex jjk-calendar cal-menu calendar cal-loaddefs dired-aux browse-url url-util url-parse url-vars ruler-mode hl-line hexl eldoc mule-util tramp-cmds noutline outline easy-mmode tramp-cache tramp-sh tramp tramp-compat tramp-loaddefs shell pcomplete find-func ebuff-menu pp misearch multi-isearch nxml-uchnm rng-xsd xsd-regexp rng-cmpct rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok network-stream starttls tls message idna format-spec mml mml-sec mm-decode mm-bodies mm-encode gmm-utils mailheader vm-imap bbdb-gui help-mode flyspell ispell cl-macs gv vm-reply easymenu jjk-vm dired vm-mime-display-internal-application vm-ps-print bbdb-vm vm-autoload bbdb-snarf mail-extr rfc822 bbdb-autoloads bbdb-hooks mail-parse rfc2231 bbdb-com mailabbrev cl vcard vm-vcard vm-pine smtpmail bbdb timezone sendmail rfc2047 rfc2045 ietf-drums mail-utils vm-rfaddons vm-menu vm-window vm-toolbar vm-folder vm-mime vm-undo vm-virtual vm-summary-faces vm-summary vm-mouse vm-page vm-motion vm-minibuf vm-message vm-misc vm-macro vm-autoloads vm-vars vm-version vm ehelp electric uniquify warnings arc-mode archive-mode epa-file epa derived epg epg-config advice help-fns cl-lib advice-preload auth-source eieio byte-opt bytecomp byte-compile cconv gnus-util mm-util mail-prsvr password-cache cygwin-mount ange-ftp comint ansi-color ring server time time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32 multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 12:48:31 2013 Received: (at 15866) by debbugs.gnu.org; 12 Nov 2013 17:48:31 +0000 Received: from localhost ([127.0.0.1]:49072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgI4k-0008SD-BM for submit@debbugs.gnu.org; Tue, 12 Nov 2013 12:48:30 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:57547) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgI4h-0008Rx-8z for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 12:48:28 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MW500J00VTWPI00@a-mtaout22.012.net.il> for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 19:48:20 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW500JK6W4KID50@a-mtaout22.012.net.il>; Tue, 12 Nov 2013 19:48:20 +0200 (IST) Date: Tue, 12 Nov 2013 19:48:18 +0200 From: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence In-reply-to: <21121.29752.814965.329395@consult.pretender> X-012-Sender: halo1@inter.net.il To: emacs@kosowsky.org Message-id: <83ob5p1pgd.fsf@gnu.org> References: <21121.29752.814965.329395@consult.pretender> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Mon, 11 Nov 2013 19:20:08 -0500 > From: "" > > i] If the function 'expand-file-name' has an associated magic file > handler, the function expand-file-name is called to convert it "to > absolute, and canonicalize it" (quoted from the function > definition). > > ii] The test for file-exists-p is then wrapped in a 'let' construct > with file-name-handler-alist set to nil. This effectively shuts > off magic file handling and ensures that file-exists-p now checks > for true OS existence of the now potentially expanded path. > > iii]The function gnutls-trustfiles is now assured that it will be > passed an OS-valid path. Thanks. As I wrote elsewhere, I agree that gnutls.el should ignore file handlers when it looks for certificate files. But then _not_ ignoring the expand-file-name handler makes little sense to me: the result could exist as a local file name that has no relation whatsoever to certificates, which will again fail in strange ways inside the GnuTLS library. So I think we should do ii], but not i]. Btw, I think many Emacs packages don't make sense with remote files, so they should also ignore file handlers. IOW, this is not specific to gnutls.el. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 13:13:43 2013 Received: (at 15866) by debbugs.gnu.org; 12 Nov 2013 18:13:43 +0000 Received: from localhost ([127.0.0.1]:49096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgIT9-0000dC-AD for submit@debbugs.gnu.org; Tue, 12 Nov 2013 13:13:43 -0500 Received: from vms173011pub.verizon.net ([206.46.173.11]:50651) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgIT7-0000cw-4m for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 13:13:41 -0500 Received: from consult.pretender ([unknown] [96.237.159.120]) by vms173011.mailsrvcs.net (Sun Java(tm) System Messaging Server 7u2-7.02 32bit (built Apr 16 2009)) with ESMTPA id <0MW50000XX9HX2U1@vms173011.mailsrvcs.net> for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 12:13:09 -0600 (CST) Received: from consult.pretender (consult.pretender [127.0.0.1]) by consult.pretender (8.14.4/8.14.4) with ESMTP id rACICq2C006781; Tue, 12 Nov 2013 13:12:53 -0500 From: MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit Message-id: <21122.28580.612896.572445@consult.pretender> Date: Tue, 12 Nov 2013 13:12:52 -0500 To: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence In-reply-to: <83ob5p1pgd.fsf@gnu.org> References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> X-Mailer: VM 8.2.0b under 23.1.1 (i386-redhat-linux-gnu) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii wrote at about 19:48:18 +0200 on Tuesday, November 12, 2013: > > Date: Mon, 11 Nov 2013 19:20:08 -0500 > > From: "" > > > > i] If the function 'expand-file-name' has an associated magic file > > handler, the function expand-file-name is called to convert it "to > > absolute, and canonicalize it" (quoted from the function > > definition). > > > > ii] The test for file-exists-p is then wrapped in a 'let' construct > > with file-name-handler-alist set to nil. This effectively shuts > > off magic file handling and ensures that file-exists-p now checks > > for true OS existence of the now potentially expanded path. > > > > iii]The function gnutls-trustfiles is now assured that it will be > > passed an OS-valid path. > > Thanks. > > As I wrote elsewhere, I agree that gnutls.el should ignore file > handlers when it looks for certificate files. > > But then _not_ ignoring the expand-file-name handler makes little > sense to me: the result could exist as a local file name that has no > relation whatsoever to certificates, which will again fail in strange > ways inside the GnuTLS library. > > So I think we should do ii], but not i]. As I mentioned many times, I would find that an acceptable even if minimal and non-ideal (for me) solution - provided that it also were documented in the elisp file and probably also in the gnutls-trustfiles variable that magic file handling is shut off for this variable. I am ok with that. I also think that the following two usability messages should be added: 1. Warning message (but perhaps not error) triggered if no elements of gnutls-trustfiles are valid files 2. Trapping of error if for some reason file-exists-p shows the file to exist but for some reason gnutls still can't access it. In summary, my primary issue was with you declaring the bug summarily closed when the code clearly was inconsistent in allowing magic file handling for file-exists-p while not passing on such handling to the c-routines that actually access the file. Indeed, while one can disagree with *how* a bug is fixed and to what extent one goes to fix it, one shouldn't ignore the presence of a bug or sloppy code when such a simple fix exists. While it might make little (logical) sense to put ange-ftp or tramp style paths in gnutls-trustfiles, if one did, they too would cause this routine to error out. Hence the coding inconsistency is not limited to cygwin-mount even though the chances of it surfacing outside of cygwin-mount may be quite small. So, let's at least agree to the minimal fix for now... I will address my comments on the pluses/minuses of persistence of cygwin-mount in response to your other message... > Btw, I think many Emacs packages don't make sense with remote files, > so they should also ignore file handlers. IOW, this is not specific > to gnutls.el. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 14:40:53 2013 Received: (at 15866) by debbugs.gnu.org; 12 Nov 2013 19:40:53 +0000 Received: from localhost ([127.0.0.1]:49144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgJpT-0002kp-Lf for submit@debbugs.gnu.org; Tue, 12 Nov 2013 14:40:52 -0500 Received: from mail-qc0-f181.google.com ([209.85.216.181]:47506) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgJpM-0002kS-Eh for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 14:40:45 -0500 Received: by mail-qc0-f181.google.com with SMTP id w4so5365411qcr.40 for <15866@debbugs.gnu.org>; Tue, 12 Nov 2013 11:40:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=XhSYEteCuNFJMB7dYFg66T0Bafs2jatjeJwbLhD0wrk=; b=QpxFTlNP10gk0dW7l5V5YzG8NsAsF61O8llpm3vdryDTMxQhZOpd6WBzWYDVDOtNWv fZKLo8S7EaYsUiX1snKzsc13eA2zdrARrDYtSpZGSdTRjnvLC2qAgy4gTn962+4myzrs kpVvB7fd/NYJFY+M2GiACkE70qOtQvOKfqA8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=XhSYEteCuNFJMB7dYFg66T0Bafs2jatjeJwbLhD0wrk=; b=MJWfP7UCm52W/PX4WM1I/mIKo3KmGk4Mz8uxHvrA/a2SR4N9GDXwuy6ZEJWp8CtAIr ZV+zZshGHLmmz/opWRRs8bnfxTDX+69Y20/OiA6R2hSqRi5nXR7IKpwTHH+NK3YhZWUX awR/roGUMB9rWc8SxWiKNcqNEqwTHh3+tYjEvH/m1G/z3ZlhhFFwb5WUzm3NxaAFZsmp xi8Y3cJZewozLEF5yQv+uCJWCGKkJ49dz2xZx6p5nboXjmXVnVxFo9DoiaFTnAAwyn2j SgmppvW79DmLH/nIFuQGfjh+vaI9nWiAnVcK3oPVOQq45vIeioFCj/Pl6iDklVfo9ScF 6CYA== X-Gm-Message-State: ALoCoQku0IqpRK5L/G15YBzxycB4l7CuP5FfsRN/8gpAgChWk8vQtgvS/mX5Jg+7We6CwgcVBBW+ X-Received: by 10.229.101.136 with SMTP id c8mr59305157qco.17.1384285238732; Tue, 12 Nov 2013 11:40:38 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id h9sm73845652qaq.9.2013.11.12.11.40.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Nov 2013 11:40:38 -0800 (PST) From: Ted Zlatanov To: Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <21122.28580.612896.572445@consult.pretender> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 12 Nov 2013 14:41:20 -0500 In-Reply-To: <21122.28580.612896.572445@consult.pretender> (emacs@kosowsky.org's message of "Tue, 12 Nov 2013 13:12:52 -0500") Message-ID: <87mwl9h0gv.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 12 Nov 2013 13:12:52 -0500 wrote: > Eli Zaretskii wrote at about 19:48:18 +0200 on Tuesday, November 12, 2013: >> > Date: Mon, 11 Nov 2013 19:20:08 -0500 >> > From: "" >> > >> > i] If the function 'expand-file-name' has an associated magic file >> > handler, the function expand-file-name is called to convert it "to >> > absolute, and canonicalize it" (quoted from the function >> > definition). >> > >> > ii] The test for file-exists-p is then wrapped in a 'let' construct >> > with file-name-handler-alist set to nil. This effectively shuts >> > off magic file handling and ensures that file-exists-p now checks >> > for true OS existence of the now potentially expanded path. >> > >> > iii]The function gnutls-trustfiles is now assured that it will be >> > passed an OS-valid path. >> >> Thanks. >> >> As I wrote elsewhere, I agree that gnutls.el should ignore file >> handlers when it looks for certificate files. >> >> But then _not_ ignoring the expand-file-name handler makes little >> sense to me: the result could exist as a local file name that has no >> relation whatsoever to certificates, which will again fail in strange >> ways inside the GnuTLS library. >> >> So I think we should do ii], but not i]. > As I mentioned many times, I would find that an acceptable even if > minimal and non-ideal (for me) solution - provided that it also were > documented in the elisp file and probably also in the > gnutls-trustfiles variable that magic file handling is shut off for > this variable. I am ok with that. Great. Could you test and submit the patch with just that piece [ii] and I'll commit it, then add the documentation? > I also think that the following two usability messages should be > added: > 1. Warning message (but perhaps not error) triggered if no elements of > gnutls-trustfiles are valid files Good idea, I'll add it with the docs. > 2. Trapping of error if for some reason file-exists-p shows the file > to exist but for some reason gnutls still can't access it. I'm not sure this should be trapped at that level. It feels like something that should be bounced up to the user, as it could indicate serious system problems or some suspicious (possibly malicious) tinkering with the file calls. >> Btw, I think many Emacs packages don't make sense with remote files, >> so they should also ignore file handlers. IOW, this is not specific >> to gnutls.el. Right, hence my concern about doing these fixes just for gnutls.el. It seems like a general problem. Ted From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 14:52:59 2013 Received: (at 15866) by debbugs.gnu.org; 12 Nov 2013 19:52:59 +0000 Received: from localhost ([127.0.0.1]:49172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgK1D-00033P-1Z for submit@debbugs.gnu.org; Tue, 12 Nov 2013 14:52:59 -0500 Received: from mout.gmx.net ([212.227.17.20]:59512) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgK1B-00033B-2I for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 14:52:57 -0500 Received: from detlef.gmx.de ([87.146.62.146]) by mail.gmx.com (mrgmx001) with ESMTPS (Nemesis) id 0MHXXo-1VjcsA13ro-003J65 for <15866@debbugs.gnu.org>; Tue, 12 Nov 2013 20:52:50 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> Date: Tue, 12 Nov 2013 20:52:46 +0100 In-Reply-To: <83ob5p1pgd.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Nov 2013 19:48:18 +0200") Message-ID: <87bo1po0s1.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:KBnc3vliHhPR4FwfgGrGJO4AWIh3FkzE9Cem4nz9eDXKe6DB2oy ywXDF2eHxZQnmzf20gXlDdgzn+it7b13G4iCDo0xyWqkykPPV7QU9HVuswULQxvoNXLL4wX Vjb60ieBhAYUE5ss59dJmJN5AbK2hvy/pqCWaARcQHJWgvR4m5O1/5DK1yjsp4VtDQrFz0v 8kqo7f6IRgT/tuZCSgwZA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > As I wrote elsewhere, I agree that gnutls.el should ignore file > handlers when it looks for certificate files. The canonical way to ignore any file name handler is to prefix the file name with "/:", see (info "(emacs)Quoted File Names") Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 15:02:49 2013 Received: (at 15866) by debbugs.gnu.org; 12 Nov 2013 20:02:49 +0000 Received: from localhost ([127.0.0.1]:49178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgKAj-0003Ig-0h for submit@debbugs.gnu.org; Tue, 12 Nov 2013 15:02:49 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:61338) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgKAg-0003IS-VX for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 15:02:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCqr1/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IPAS-Result: Av4EABK/CFFMCqr1/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37712827" Received: from 76-10-170-245.dsl.teksavvy.com (HELO pastel.home) ([76.10.170.245]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Nov 2013 15:02:40 -0500 Received: by pastel.home (Postfix, from userid 20848) id A2DF5630BF; Tue, 12 Nov 2013 15:02:40 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence Message-ID: References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> Date: Tue, 12 Nov 2013 15:02:40 -0500 In-Reply-To: <83ob5p1pgd.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Nov 2013 19:48:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > So I think we should do ii], but not i]. Please go ahead, yes. > Btw, I think many Emacs packages don't make sense with remote files, > so they should also ignore file handlers. IOW, this is not specific > to gnutls.el. Not sure how widespread this problem is. At least the gnutls case is rather special since most other C calls that manipulate files are wrapped with a magic file handler. But please do submit the other cases you bump into for consideration. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 15:27:33 2013 Received: (at 15866) by debbugs.gnu.org; 12 Nov 2013 20:27:33 +0000 Received: from localhost ([127.0.0.1]:49201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgKYf-0003uG-2Q for submit@debbugs.gnu.org; Tue, 12 Nov 2013 15:27:33 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:65339) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgKYd-0003u1-2s for 15866@debbugs.gnu.org; Tue, 12 Nov 2013 15:27:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCqr1/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IPAS-Result: Av4EABK/CFFMCqr1/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37715350" Received: from 76-10-170-245.dsl.teksavvy.com (HELO pastel.home) ([76.10.170.245]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 12 Nov 2013 15:27:25 -0500 Received: by pastel.home (Postfix, from userid 20848) id 2447E630BF; Tue, 12 Nov 2013 15:27:25 -0500 (EST) From: Stefan Monnier To: Michael Albinus Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence Message-ID: References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> Date: Tue, 12 Nov 2013 15:27:25 -0500 In-Reply-To: <87bo1po0s1.fsf@gmx.de> (Michael Albinus's message of "Tue, 12 Nov 2013 20:52:46 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, Eli Zaretskii , emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> As I wrote elsewhere, I agree that gnutls.el should ignore file >> handlers when it looks for certificate files. > The canonical way to ignore any file name handler is to prefix the file > name with "/:", see (info "(emacs)Quoted File Names") That's the canonical way *for the user* to write a file that bypasses file name handlers (useful when you want to access a local file named /ssh:foo:bar, for example). Whereas in gnutls.el the issue is for the *code* to check that the libgnutls C code (which will not have access to the file name handlers) will be able to use the file name provided by the user. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 18:34:09 2013 Received: (at 15866) by debbugs.gnu.org; 16 Nov 2013 23:34:09 +0000 Received: from localhost ([127.0.0.1]:57600 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhpNQ-00070N-TD for submit@debbugs.gnu.org; Sat, 16 Nov 2013 18:34:09 -0500 Received: from mail-qe0-f52.google.com ([209.85.128.52]:53681) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhpNO-0006zs-Bg for 15866@debbugs.gnu.org; Sat, 16 Nov 2013 18:34:06 -0500 Received: by mail-qe0-f52.google.com with SMTP id cz11so2661450qeb.25 for <15866@debbugs.gnu.org>; Sat, 16 Nov 2013 15:34:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=wM1kekPov57IRVfHUKGUCTFv2t5zwMAtaPZ7Zybh68I=; b=BGqjI84WBvFKHRh1nNs/SEPl5wHhZFvok+LykPOP/HnR5uTkMU6sOhG6kZUhT5x/Ee kGvTvYVVdB01nA3M6j4hE9/hWjVnlAZ3TIT5CEGwqo41IAliB6vNTvn3LJSNBJGEa3sp 8YMV2XRhp0jkDeTyk6f32Q0cPxiLqSmwO8syc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=wM1kekPov57IRVfHUKGUCTFv2t5zwMAtaPZ7Zybh68I=; b=TEeFCrqIDt1sym++9Gxsob/W5im9XOa11mvKZqScrlXeeyhn6doBrMzbJndO91cUmR h4/QoIOuC6UkNH8rjYNX0gHU+qUe4HPtwR/QUw0oHRiFAVtVwYiPj3wJBnsGghiCLwaz m1hL/r7xufv32WEbI7iG6eyS5/HV63FTQdGOmbNRFiF6dRS2HBq1CVGimfSc+APbOw76 iuDiXtf6Afiy6cSVpaf93J4GxpyJpjTWUY89pNfskAwsBegavaIq5IZUXLaTyLobPbYM BLIZBtB3Ud7HjGkFmMJPjQxhH6fVOfRcobC/HIWJhnNMO3xE/KiW1i/jWoR6zzFD5hHj zEqA== X-Gm-Message-State: ALoCoQkR+Vh4Za0AQZp7SX4E557kjlEnRcjFgUXd7x0oK4lKcO3o34kDoCWHs2fhrzsxxTz9FnLk X-Received: by 10.224.49.69 with SMTP id u5mr5972842qaf.96.1384644840824; Sat, 16 Nov 2013 15:34:00 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id j15sm22805257qaa.6.2013.11.16.15.34.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Nov 2013 15:34:00 -0800 (PST) From: Ted Zlatanov To: Stefan Monnier Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Sat, 16 Nov 2013 18:34:46 -0500 In-Reply-To: (Stefan Monnier's message of "Tue, 12 Nov 2013 15:02:40 -0500") Message-ID: <87y54ngbu1.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, Eli Zaretskii , emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 12 Nov 2013 15:02:40 -0500 Stefan Monnier wrote: >> So I think we should do ii], but not i]. SM> Please go ahead, yes. >> Btw, I think many Emacs packages don't make sense with remote files, >> so they should also ignore file handlers. IOW, this is not specific >> to gnutls.el. SM> Not sure how widespread this problem is. At least the gnutls case is SM> rather special since most other C calls that manipulate files are SM> wrapped with a magic file handler. I am also thinking now about the FFI work (yes, it's somewhere on my TODO list) and how these issues will be handled there. It seems that the FFI glue may have to tag filenames distinctly from plain strings and may even have some file existence checks and hooks. Ted From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 20:51:27 2013 Received: (at 15866) by debbugs.gnu.org; 17 Nov 2013 01:51:27 +0000 Received: from localhost ([127.0.0.1]:57693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhrWI-0001y5-EW for submit@debbugs.gnu.org; Sat, 16 Nov 2013 20:51:26 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:51510) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhrWF-0001xo-TN for 15866@debbugs.gnu.org; Sat, 16 Nov 2013 20:51:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+LP0/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kLodwBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFHO+LP0/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kLodwBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="38089028" Received: from 206-248-179-244.dsl.teksavvy.com (HELO fmsmemgm.homelinux.net) ([206.248.179.244]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Nov 2013 20:51:17 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 92AE5AE1D0; Sat, 16 Nov 2013 20:51:17 -0500 (EST) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence Message-ID: References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87y54ngbu1.fsf@flea.lifelogs.com> Date: Sat, 16 Nov 2013 20:51:17 -0500 In-Reply-To: <87y54ngbu1.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Sat, 16 Nov 2013 18:34:46 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I am also thinking now about the FFI work (yes, it's somewhere on my > TODO list) and how these issues will be handled there. It seems that > the FFI glue may have to tag filenames distinctly from plain strings and > may even have some file existence checks and hooks. I don't think the FFI should do that, no. At least, for starters we'll let each and every binding for a particular library deal with the problem on a case-by-case basis. And if/when this shows up repeatedly, we can provide helper functions that give a "standard solution". Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 07 15:17:47 2014 Received: (at 15866) by debbugs.gnu.org; 7 Dec 2014 20:17:47 +0000 Received: from localhost ([127.0.0.1]:56595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxiH4-0004Zk-OK for submit@debbugs.gnu.org; Sun, 07 Dec 2014 15:17:46 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37221) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxiH2-0004Zc-NW for 15866@debbugs.gnu.org; Sun, 07 Dec 2014 15:17:45 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XxiGg-0007cV-21; Sun, 07 Dec 2014 21:17:22 +0100 From: Lars Magne Ingebrigtsen To: Stefan Monnier Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> X-Now-Playing: X-TG's _The Final Report_: "E.H.S." X-Hashcash: 1:23:141207:emacs@kosowsky.org::H0olQ4bC6NHJbAmc:00000000000000000000000000000000000000000001MZA X-Hashcash: 1:23:141207:15866@debbugs.gnu.org::K0ZjpPeKjODZu7r+:0000000000000000000000000000000000000000AHlT X-Hashcash: 1:23:141207:eliz@gnu.org::gdcoYb4kH63cf7ct:00000QcN6 X-Hashcash: 1:23:141207:michael.albinus@gmx.de::i/oJRbHKovis6a+P:000000000000000000000000000000000000000MSk/ X-Hashcash: 1:23:141207:monnier@iro.umontreal.ca::NsLu/uqzkQnbJSOT:0000000000000000000000000000000000001bivS Date: Sun, 07 Dec 2014 21:17:21 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 12 Nov 2013 15:27:25 -0500") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XxiGg-0007cV-21 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418588242.12143@putuHT4W2GTOZqK5h5S+7A X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, Eli Zaretskii , Michael Albinus , emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: > Whereas in gnutls.el the issue is for the *code* to check that the > libgnutls C code (which will not have access to the file name handlers) > will be able to use the file name provided by the user. Wouldn't a solution here be to introduce a variable like `inhibit-file-handlers' that would really inhibit all Lisp-level file handlers? Doesn't Emacs have that already? Hm... `inhibit-file-name-handlers' doesn't quite seem to do the trick, I guess? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 07 16:08:55 2014 Received: (at 15866) by debbugs.gnu.org; 7 Dec 2014 21:08:55 +0000 Received: from localhost ([127.0.0.1]:56609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxj4W-0007X2-4V for submit@debbugs.gnu.org; Sun, 07 Dec 2014 16:08:55 -0500 Received: from mtaout28.012.net.il ([80.179.55.184]:52594) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxj4Q-0007We-QU for 15866@debbugs.gnu.org; Sun, 07 Dec 2014 16:08:50 -0500 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NG800L00CVTX600@mtaout28.012.net.il> for 15866@debbugs.gnu.org; Sun, 07 Dec 2014 23:06:22 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NG800CV5DAML690@mtaout28.012.net.il>; Sun, 07 Dec 2014 23:06:22 +0200 (IST) Date: Sun, 07 Dec 2014 23:08:34 +0200 From: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence In-reply-to: X-012-Sender: halo1@inter.net.il To: Lars Magne Ingebrigtsen Message-id: <837fy3yxpp.fsf@gnu.org> References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, michael.albinus@gmx.de, monnier@iro.umontreal.ca, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Lars Magne Ingebrigtsen > Cc: Michael Albinus , 15866@debbugs.gnu.org, Eli Zaretskii , emacs@kosowsky.org > Date: Sun, 07 Dec 2014 21:17:21 +0100 > > Stefan Monnier writes: > > > Whereas in gnutls.el the issue is for the *code* to check that the > > libgnutls C code (which will not have access to the file name handlers) > > will be able to use the file name provided by the user. > > Wouldn't a solution here be to introduce a variable like > `inhibit-file-handlers' that would really inhibit all Lisp-level file > handlers? How is that different from binding file-name-handler-alist to nil? And btw, most file handlers are invoked on the C level, not the Lisp level. > `inhibit-file-name-handlers' doesn't quite seem to do the trick, I > guess? Not conveniently, no. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 07 16:15:47 2014 Received: (at 15866) by debbugs.gnu.org; 7 Dec 2014 21:15:47 +0000 Received: from localhost ([127.0.0.1]:56614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxjBD-0007mx-8H for submit@debbugs.gnu.org; Sun, 07 Dec 2014 16:15:47 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:45710) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxjBA-0007mi-8z for 15866@debbugs.gnu.org; Sun, 07 Dec 2014 16:15:45 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XxjAq-00089L-3I; Sun, 07 Dec 2014 22:15:24 +0100 From: Lars Magne Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> <837fy3yxpp.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAALVBMVEWcmo/g39jw8Or+//f+ //rn5+AlJB7V1c7+/vllY1X39/H////Jx8D8/PX+/v294C4IAAABRElEQVQ4jWNY2+Li927f7t27 X+9GBhsYbu/GCnBK7GHoxiXhjUvCmmQdr3FJQOh9RBu1HWYUuokbGbBrAErgsHwjA4a1JBj1tubQ a2wSW8/oLj8Od+BWhFGC4eVzrp6D8TbBJTaqLr4wc0INpsTSVtsFM2emVWNICCvdrUxLS+NGl9gX HGzLNm3mtCwofxdEYt/uvcrBt9LSZmamQyX2wnTsWnr5zrSEaWlzYCbAJPYuFQ9ly5yWlggLaLjl uqF3FSakpc2C8eES67aEnkybMO00kgQkfG+93qR6ICkmGkPHpnVbZILCxXdjSOzWer31jFA1Fold oe/aD+7GIrH7laDQa6wSqJkEV9SCJbCmB5DELlwS2I3CkeDw6MCR2qkkAXYP9lwL9DJ6AQAOhXsg HavRxGH+wlVkQCXABrx+BwLQEN0HAJY2LWL8GdVoAAAAAElFTkSuQmCC X-Now-Playing: Jan Jelinek's _Music for Fragments_: "Forest Weaver" X-Hashcash: 1:23:141207:monnier@iro.umontreal.ca::8xBTb3Oem1/Egzmu:00000000000000000000000000000000000001EiF X-Hashcash: 1:23:141207:eliz@gnu.org::2+3gnQLD5qNhN5fL:000006PQu X-Hashcash: 1:23:141207:15866@debbugs.gnu.org::9xqpovEswaXOJdJ5:0000000000000000000000000000000000000000CSG7 X-Hashcash: 1:23:141207:michael.albinus@gmx.de::3QtxxV+A/T/Dasnd:000000000000000000000000000000000000000ZG0O X-Hashcash: 1:23:141207:emacs@kosowsky.org::O3sdT/Y/yOqM0f+B:0000000000000000000000000000000000000000001AB0c Date: Sun, 07 Dec 2014 22:15:23 +0100 In-Reply-To: <837fy3yxpp.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 07 Dec 2014 23:08:34 +0200") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XxjAq-00089L-3I X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418591725.17309@0SVsUP0hTnMYrky+qm6psA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, michael.albinus@gmx.de, monnier@iro.umontreal.ca, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> Wouldn't a solution here be to introduce a variable like >> `inhibit-file-handlers' that would really inhibit all Lisp-level file >> handlers? > > How is that different from binding file-name-handler-alist to nil? I guess it isn't. Wouldn't that solve this problem? The patch presented did some stuff with (if (find-file-name-handler f 'expand-file-name) ... but perhaps just binding that variable to nil unconditionally would be the right thing here? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 07 22:32:46 2014 Received: (at 15866) by debbugs.gnu.org; 8 Dec 2014 03:32:46 +0000 Received: from localhost ([127.0.0.1]:56760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxp3y-0004hU-CH for submit@debbugs.gnu.org; Sun, 07 Dec 2014 22:32:45 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:52508) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxp3s-0004hH-Vv for 15866@debbugs.gnu.org; Sun, 07 Dec 2014 22:32:40 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NG800C00U6UHF00@a-mtaout23.012.net.il> for 15866@debbugs.gnu.org; Mon, 08 Dec 2014 05:32:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NG800CB8V6AJ100@a-mtaout23.012.net.il>; Mon, 08 Dec 2014 05:32:34 +0200 (IST) Date: Mon, 08 Dec 2014 05:32:24 +0200 From: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence In-reply-to: X-012-Sender: halo1@inter.net.il To: Lars Magne Ingebrigtsen Message-id: <8361dmzuif.fsf@gnu.org> References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> <837fy3yxpp.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, michael.albinus@gmx.de, monnier@iro.umontreal.ca, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Lars Magne Ingebrigtsen > Cc: monnier@iro.umontreal.ca, michael.albinus@gmx.de, 15866@debbugs.gnu.org, emacs@kosowsky.org > Date: Sun, 07 Dec 2014 22:15:23 +0100 > > perhaps just binding that variable to nil unconditionally would be > the right thing here? AFAIR, that was the conclusion. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 08 02:35:20 2014 Received: (at 15866) by debbugs.gnu.org; 8 Dec 2014 07:35:21 +0000 Received: from localhost ([127.0.0.1]:56805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxsqi-0002LW-OB for submit@debbugs.gnu.org; Mon, 08 Dec 2014 02:35:20 -0500 Received: from mout.gmx.net ([212.227.17.21]:58479) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xxsqc-0002LJ-AR for 15866@debbugs.gnu.org; Mon, 08 Dec 2014 02:35:14 -0500 Received: from detlef.gmx.de ([87.146.38.161]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MCwbX-1Y6znN1elf-009ite; Mon, 08 Dec 2014 08:34:50 +0100 From: Michael Albinus To: Lars Magne Ingebrigtsen Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> Date: Mon, 08 Dec 2014 08:34:48 +0100 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 07 Dec 2014 21:17:21 +0100") Message-ID: <87mw6ya92f.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:VvsBblpF/2Dg9TFF3cV57w/BUClihurZUBKxqvlHW/Iex/yrdlX vhF6XcfjzPI5GsqKCJBJjGDDzNbwC/bLUUYIOS/0x/l45DNVPYrf5DJbsbcVOft3mtjsjLX AtGdDF33/Rq0b6trBPeYrqD3FAs1mWTjtyphekYjoi8agnPe6CKtvo/uulLOwlM5v7kVJlB 10qoy+Nrj6MkAqGmFVjrA== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier , emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Magne Ingebrigtsen writes: > Wouldn't a solution here be to introduce a variable like > `inhibit-file-handlers' that would really inhibit all Lisp-level file > handlers? Doesn't Emacs have that already? Hm... > `inhibit-file-name-handlers' doesn't quite seem to do the trick, I > guess? `inhibit-file-name-handlers' is always used in conjunction with `inhibit-file-name-operation'. Their purpose is to prevent recursive call of a file name handler. So it isn't appropriate here. Just for the records ... Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 08 02:41:11 2014 Received: (at 15866) by debbugs.gnu.org; 8 Dec 2014 07:41:11 +0000 Received: from localhost ([127.0.0.1]:56809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxswN-0002WZ-B1 for submit@debbugs.gnu.org; Mon, 08 Dec 2014 02:41:10 -0500 Received: from mout.gmx.net ([212.227.17.21]:54247) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XxswG-0002Vu-Ia for 15866@debbugs.gnu.org; Mon, 08 Dec 2014 02:41:01 -0500 Received: from detlef.gmx.de ([87.146.38.161]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MYKGj-1YSM4T1HHN-00V7Rh; Mon, 08 Dec 2014 08:40:44 +0100 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> <837fy3yxpp.fsf@gnu.org> <8361dmzuif.fsf@gnu.org> Date: Mon, 08 Dec 2014 08:40:40 +0100 In-Reply-To: <8361dmzuif.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Dec 2014 05:32:24 +0200") Message-ID: <87iohma8sn.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:+0rdOLefQ213jTQyQYlQ37llwHDV+P982bPLZaacWAn2jcPbYtS OX85wgJGpZ5oVy2wuHFlxxz7mHSAyM+mN8ogwfv/i7+mfO/jGrALSAMENZXZxIM1bNhkRe7 e09oq+b5latpyIWRoakIuzmH2EZWRash3kwbSI9PbvY1x9e27O5svabnoScN3OMXFhYTInJ RkEnoVWq7ejgMkhXTlS4g== X-UI-Out-Filterresults: notjunk:1; X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, Lars Magne Ingebrigtsen , monnier@iro.umontreal.ca, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> From: Lars Magne Ingebrigtsen >> Cc: monnier@iro.umontreal.ca, michael.albinus@gmx.de, >> 15866@debbugs.gnu.org, emacs@kosowsky.org >> Date: Sun, 07 Dec 2014 22:15:23 +0100 >> >> perhaps just binding that variable to nil unconditionally would be >> the right thing here? > > AFAIR, that was the conclusion. Likely, yes. I don't know whether there will be a certificate file ca.gpg, which is protected by GPG, and which would not be accessible then. But due to the nature of certificates they shall be readable, so maybe we can ignore such a case. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 08 13:14:47 2014 Received: (at 15866) by debbugs.gnu.org; 8 Dec 2014 18:14:47 +0000 Received: from localhost ([127.0.0.1]:57923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xy2pY-0005g0-1m for submit@debbugs.gnu.org; Mon, 08 Dec 2014 13:14:47 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:43133) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xy2pS-0005fc-UO for 15866@debbugs.gnu.org; Mon, 08 Dec 2014 13:14:42 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Xy2p4-0004fS-R5; Mon, 08 Dec 2014 19:14:14 +0100 From: Lars Magne Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#15866: Gnutls elisp code doesn't properly check for file existence References: <21121.29752.814965.329395@consult.pretender> <83ob5p1pgd.fsf@gnu.org> <87bo1po0s1.fsf@gmx.de> <837fy3yxpp.fsf@gnu.org> <8361dmzuif.fsf@gnu.org> X-Now-Playing: Pixel's _Mantle_: "Steel Tape" X-Hashcash: 1:23:141208:emacs@kosowsky.org::FUwGoTg+A6bHHcqV:00000000000000000000000000000000000000000006u2e X-Hashcash: 1:23:141208:eliz@gnu.org::Xahn98lETj8D3iUh:000006fa3 X-Hashcash: 1:23:141208:michael.albinus@gmx.de::mSFt3A8IPb+J03/d:000000000000000000000000000000000000000ec3z X-Hashcash: 1:23:141208:15866@debbugs.gnu.org::twGxVEJ0Rkz5j5Td:0000000000000000000000000000000000000001IUct X-Hashcash: 1:23:141208:monnier@iro.umontreal.ca::9k9undDQI+12U3re:0000000000000000000000000000000000001YEJM Date: Mon, 08 Dec 2014 19:14:14 +0100 In-Reply-To: <8361dmzuif.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 08 Dec 2014 05:32:24 +0200") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Xy2p4-0004fS-R5 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418667256.11343@YpHy0FL9RyvfO0IeeVuECQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15866 Cc: 15866@debbugs.gnu.org, michael.albinus@gmx.de, monnier@iro.umontreal.ca, emacs@kosowsky.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: >> From: Lars Magne Ingebrigtsen >> Cc: monnier@iro.umontreal.ca, michael.albinus@gmx.de, >> 15866@debbugs.gnu.org, emacs@kosowsky.org >> Date: Sun, 07 Dec 2014 22:15:23 +0100 >> >> perhaps just binding that variable to nil unconditionally would be >> the right thing here? > > AFAIR, that was the conclusion. Ok; I've now applied something that binds that variable. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 08 13:14:41 2014 Received: (at control) by debbugs.gnu.org; 8 Dec 2014 18:14:41 +0000 Received: from localhost ([127.0.0.1]:57921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xy2pU-0005fl-QG for submit@debbugs.gnu.org; Mon, 08 Dec 2014 13:14:40 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:43138) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xy2pT-0005fe-Ew for control@debbugs.gnu.org; Mon, 08 Dec 2014 13:14:39 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Xy2pA-0004fb-K8 for control@debbugs.gnu.org; Mon, 08 Dec 2014 19:14:20 +0100 Date: Mon, 08 Dec 2014 19:14:20 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #15866 X-MailScanner-ID: 1Xy2pA-0004fb-K8 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1418667262.13403@xL4P5NQAjdLUHbRKTy2dbA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 15866 fixed close 15866 25.1 From unknown Sat Jun 21 05:19:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 06 Jan 2015 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator