GNU bug report logs - #15857
24.3.50; semantic-symref-hide-buffer should use quit-window

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15857 in the body.
You can then email your comments to 15857 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Darren Hoo <darren.hoo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; semantic-symref-hide-buffer should use quit-window
Date: Sun, 10 Nov 2013 22:21:58 +0800

C-c , g  then press q on the *Symref buffer should close window as
describe-function does, the behavior should be consistent across
different packages.


=== modified file 'lisp/cedet/semantic/symref/list.el'
--- lisp/cedet/semantic/symref/list.el	2013-09-17 15:50:33 +0000
+++ lisp/cedet/semantic/symref/list.el	2013-11-10 14:12:59 +0000
@@ -192,7 +192,7 @@
 (defun semantic-symref-hide-buffer ()
   "Hide buffer with semantic-symref results."
   (interactive)
-  (bury-buffer))
+  (quit-window))
 
 (defcustom semantic-symref-results-summary-function 'semantic-format-tag-prototype
   "Function to use when creating items in Imenu.


In GNU Emacs 24.3.50.8 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
 of 2013-11-09 on Darren-rMBP.local
Bzr revision: 115046 xfq.free <at> gmail.com-20131109023646-nqoo2uv3hfjwoxiw
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns'

Message #8 received at 15857 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Darren Hoo <darren.hoo <at> gmail.com>
Cc: 15857 <at> debbugs.gnu.org
Subject: Re: bug#15857: 24.3.50;
 semantic-symref-hide-buffer should use quit-window
Date: Sun, 10 Nov 2013 13:06:14 -0500

>  (defun semantic-symref-hide-buffer ()
>    "Hide buffer with semantic-symref results."
>    (interactive)
> -  (bury-buffer))
> +  (quit-window))
 
Aka (defalias 'semantic-symref-hide-buffer 'quit-window)


        Stefan

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Darren Hoo <darren.hoo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#15857: 24.3.50;
 semantic-symref-hide-buffer should use quit-window
Date: Mon, 11 Nov 2013 13:57:04 +0800

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>  (defun semantic-symref-hide-buffer ()
>>    "Hide buffer with semantic-symref results."
>>    (interactive)
>> -  (bury-buffer))
>> +  (quit-window))
>  
> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>

or just 
    (define-key km "q" 'quit-window)

Message #14 received at 15857 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Darren Hoo <darren.hoo <at> gmail.com>
Cc: 15857 <at> debbugs.gnu.org
Subject: Re: bug#15857: 24.3.50;
 semantic-symref-hide-buffer should use quit-window
Date: Mon, 11 Nov 2013 08:35:35 -0500

> or just 
>     (define-key km "q" 'quit-window)

Which would code for free if the mode derived from special-mode.


        Stefan

Message #17 received at 15857 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Darren Hoo <darren.hoo <at> gmail.com>
Cc: 15857 <at> debbugs.gnu.org
Subject: Re: bug#15857: 24.3.50;
 semantic-symref-hide-buffer should use quit-window
Date: Sun, 15 Apr 2018 23:45:06 +0200

Darren Hoo <darren.hoo <at> gmail.com> writes:

> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>
>>>  (defun semantic-symref-hide-buffer ()
>>>    "Hide buffer with semantic-symref results."
>>>    (interactive)
>>> -  (bury-buffer))
>>> +  (quit-window))
>>  
>> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>>
>
> or just 
>     (define-key km "q" 'quit-window)

I've now done this in Emacs 27.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #22 received at 15857 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, Darren Hoo <darren.hoo <at> gmail.com>
Cc: 15857 <at> debbugs.gnu.org
Subject: Re: bug#15857: 24.3.50;
 semantic-symref-hide-buffer should use quit-window
Date: Mon, 16 Apr 2018 08:06:48 +0200

>>> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>>>
>>
>> or just
>>      (define-key km "q" 'quit-window)
>
> I've now done this in Emacs 27.1.

I'm afraid not.

-    (define-key km "q" 'semantic-symref-hide-buffer)
+    (define-key km "q" 'quit-buffer)

The function is called 'quit-window' not 'quit-buffer'.

martin

Message #25 received at 15857 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 15857 <at> debbugs.gnu.org, Darren Hoo <darren.hoo <at> gmail.com>
Subject: Re: bug#15857: 24.3.50;
 semantic-symref-hide-buffer should use quit-window
Date: Mon, 16 Apr 2018 13:48:14 +0200

martin rudalics <rudalics <at> gmx.at> writes:

>>>> Aka (defalias 'semantic-symref-hide-buffer 'quit-window)
>>>>
>>>
>>> or just
>>>      (define-key km "q" 'quit-window)
>>
>> I've now done this in Emacs 27.1.
>
> I'm afraid not.
>
> -    (define-key km "q" 'semantic-symref-hide-buffer)
> +    (define-key km "q" 'quit-buffer)
>
> The function is called 'quit-window' not 'quit-buffer'.

Oops, thanks.  I've pushed a fix now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.