From unknown Sat Jun 14 18:01:31 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15841 <15841@debbugs.gnu.org> To: bug#15841 <15841@debbugs.gnu.org> Subject: Status: Display bugs with cache-long-lines non-nil Reply-To: bug#15841 <15841@debbugs.gnu.org> Date: Sun, 15 Jun 2025 01:01:31 +0000 retitle 15841 Display bugs with cache-long-lines non-nil reassign 15841 emacs submitter 15841 Eli Zaretskii severity 15841 normal tag 15841 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 03:19:06 2013 Received: (at submit) by debbugs.gnu.org; 9 Nov 2013 08:19:06 +0000 Received: from localhost ([127.0.0.1]:43528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf3l3-0007t4-FV for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:19:06 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43842) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf3l0-0007sb-SH for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:19:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vf3kq-00044E-H7 for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:18:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39793) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vf3kq-000448-Dg for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:18:52 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vf3kl-0006z4-JS for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2013 03:18:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vf3kg-00042h-Dz for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2013 03:18:47 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:37275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vf3kg-00042Y-5j for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2013 03:18:42 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MVZ00500LO94100@a-mtaout20.012.net.il> for bug-gnu-emacs@gnu.org; Sat, 09 Nov 2013 10:18:40 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVZ0046SLR3X690@a-mtaout20.012.net.il>; Sat, 09 Nov 2013 10:18:40 +0200 (IST) Date: Sat, 09 Nov 2013 10:18:28 +0200 From: Eli Zaretskii Subject: Display bugs with cache-long-lines non-nil In-reply-to: <87r4aqww3j.fsf@nbtrap.com> X-012-Sender: halo1@inter.net.il To: Nathan Trapuzzano Message-id: <83r4aq3s4r.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Redirected to a new bug report, please use this one in the future. > From: Nathan Trapuzzano > Cc: Eli Zaretskii , Michael Heerdegen , 15797@debbugs.gnu.org, kjambunathan@gmail.com > Date: Fri, 08 Nov 2013 14:07:44 -0500 > > Stefan Monnier writes: > > >> I wonder if we should simply turn it on by default, and leave it > >> there. That way, any bugs that it exposes will be flushed out very > >> quickly. Stefan? > > > > Let's try it. > > Sorry I'm late to the party, but this broke linum and nlinum for me, > using the defaults. Any time I insert a new line, the line numbers get > totally messed up--most of them don't even display any more. And then > using motion commands sometimes results in really bizarre behavior > (apparently only with linum/nlinum so far), such as when I do > forwad-sexp and point goes to the end of some sexp other than the one at > point. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 03:32:08 2013 Received: (at 15841) by debbugs.gnu.org; 9 Nov 2013 08:32:08 +0000 Received: from localhost ([127.0.0.1]:43540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf3xf-0008DJ-Fq for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:32:07 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:47982) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf3xc-0008Cl-6c for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 03:32:05 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MVZ00L00M6CZB00@a-mtaout22.012.net.il> for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 10:31:57 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVZ00LIDMD9QG90@a-mtaout22.012.net.il>; Sat, 09 Nov 2013 10:31:57 +0200 (IST) Date: Sat, 09 Nov 2013 10:31:45 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <83r4aq3s4r.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83ppqa3rim.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Date: Sat, 09 Nov 2013 03:37:49 +0100 > Cc: 15797@debbugs.gnu.org, kjambunathan@gmail.com > > I see something probably related. Sometimes, evaluating > > (line-number-at-pos) > > at the end of my .emacs (10000 lines) needs over a second. Doing > > (setq cache-long-scans nil) > > immediately fixes this. Dunno yet how to provoke the problem. Please do try to find a recipe. I just did that with xdisp.c (almost 30000 lines), and couldn't reproduce this. line-number-at-pos is instantaneous, whether I try it at the beginning, the end, or the middle of the file. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 03:51:49 2013 Received: (at 15841) by debbugs.gnu.org; 9 Nov 2013 08:51:49 +0000 Received: from localhost ([127.0.0.1]:43562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf4Gj-0000Fs-6L for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:51:49 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:51458) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf4Gg-0000Fe-SQ for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 03:51:47 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MVZ00M00N2T3700@a-mtaout22.012.net.il> for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 10:51:40 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVZ00ML5NA43T00@a-mtaout22.012.net.il>; Sat, 09 Nov 2013 10:51:40 +0200 (IST) Date: Sat, 09 Nov 2013 10:51:29 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <83r4aq3s4r.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: nbtrap@nbtrap.com Message-id: <83mwle3qlq.fsf@gnu.org> MIME-version: 1.0 Content-type: multipart/mixed; boundary="Boundary_(ID_sSowmJl8x3ZAX4Bf9J0WZQ)" References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) --Boundary_(ID_sSowmJl8x3ZAX4Bf9J0WZQ) Content-type: text/plain Redirecting to a new bug report. > From: Nathan Trapuzzano > Cc: Eli Zaretskii , Michael Heerdegen , 15797@debbugs.gnu.org, kjambunathan@gmail.com > Date: Fri, 08 Nov 2013 16:36:50 -0500 > > Stefan Monnier writes: > > > I tried: > > > > src/emacs -Q src/xdisp.c -l .../nlinum.el -f nlinum-mode > > > > and then moved about in the buffer, but I didn't notice any problem. > > Try this with the attached file: > > src/emacs -nw -Q foo.el > > M-x linum-mode (you may notice the problem already here) > M-x goto-line 10 > C-o > > The numbers in the margin get messed up. I haven't figured out a > consistent way to screw up the motion commands yet. --Boundary_(ID_sSowmJl8x3ZAX4Bf9J0WZQ) Content-type: application/emacs-lisp Content-transfer-encoding: quoted-printable Content-disposition: attachment; filename=foo.el (defun my-kill-ring-save () "Like `kill-ring-save', but don't deactivate the mark." (interactive) (when (called-interactively-p 'any) (call-interactively 'kill-ring-save) (setq deactivate-mark nil))) (add-hook 'ielm-mode-hook (=CE=BB () (eldoc-mode) (setq lexical-binding t) (setq ielm-dynamic-return nil) (local-set-key (kbd "C-j") (=CE=BB () "Call `ielm-return' and indent." (interactive) (ielm-return) (indent-according-to-mode))) (local-set-key (kbd "RET") (=CE=BB () (interactive) (push-mark) (goto-char (point-max)) (ielm-send-input))) (local-set-key (kbd "C-c RET") 'elisp-macroexpand-next-sexp) (local-set-key (kbd "C-c M-m") (=CE=BB () (interactive) (elisp-macroexpand-next-sexp t))) (local-set-key (kbd "M-.") 'goto-definition-at-point) (local-set-key (kbd "M-*") 'pop-goto-definition))) --Boundary_(ID_sSowmJl8x3ZAX4Bf9J0WZQ)-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 03:52:53 2013 Received: (at 15841) by debbugs.gnu.org; 9 Nov 2013 08:52:53 +0000 Received: from localhost ([127.0.0.1]:43567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf4Hk-0000Ha-On for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:52:53 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:51682) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf4Hi-0000HN-Jl for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 03:52:50 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MVZ00M00N2T3700@a-mtaout22.012.net.il> for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 10:52:44 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVZ00MZ7NBW3T00@a-mtaout22.012.net.il>; Sat, 09 Nov 2013 10:52:44 +0200 (IST) Date: Sat, 09 Nov 2013 10:52:33 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <83ppqa3rim.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: nbtrap@nbtrap.com Message-id: <83li0y3qjy.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: michael_heerdegen@web.de, 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Redirecting to a new bug report. > From: Nathan Trapuzzano > Date: Fri, 08 Nov 2013 18:11:44 -0500 > Cc: Michael Heerdegen , 15797@debbugs.gnu.org, > kjambunathan@gmail.com > > Nathan Trapuzzano writes: > > > I haven't figured out a consistent way to screw up the motion commands > > yet. > > Here we go. Visit the same file and do: > > M-x linum-mode > C-o > C-n > C-e > > Cursor moves almost to end of entire file. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 06:18:52 2013 Received: (at 15841) by debbugs.gnu.org; 9 Nov 2013 11:18:52 +0000 Received: from localhost ([127.0.0.1]:43703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf6Z1-0003wg-LL for submit@debbugs.gnu.org; Sat, 09 Nov 2013 06:18:51 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:44260) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf6Yz-0003wR-GT for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 06:18:50 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MVZ00N00TXU4T00@a-mtaout22.012.net.il> for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 13:18:42 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MVZ00MCAU34V580@a-mtaout22.012.net.il>; Sat, 09 Nov 2013 13:18:40 +0200 (IST) Date: Sat, 09 Nov 2013 13:18:29 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <83ppqa3rim.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: nbtrap@nbtrap.com Message-id: <83k3gh4yd6.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: michael_heerdegen@web.de, 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Redirecting to a new bug report. > From: Nathan Trapuzzano > Date: Fri, 08 Nov 2013 18:11:44 -0500 > Cc: Michael Heerdegen , 15797@debbugs.gnu.org, > kjambunathan@gmail.com > > Nathan Trapuzzano writes: > > > I haven't figured out a consistent way to screw up the motion commands > > yet. > > Here we go. Visit the same file and do: > > M-x linum-mode > C-o > C-n > C-e > > Cursor moves almost to end of entire file. Should be fixed in trunk revision 115050. However, there are still problems which can be seen with this recipe: emacs -Q --eval "(setq-default cache-long-scans nil)" C-x C-f src/xdisp.c M-: (setq cache-long-scans t) RET M-x linum-mode RET M-> Many line numbers near the end of the buffer are not shown in the margin. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 09:02:43 2013 Received: (at 15841) by debbugs.gnu.org; 9 Nov 2013 14:02:43 +0000 Received: from localhost ([127.0.0.1]:43912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf97a-0000k3-NZ for submit@debbugs.gnu.org; Sat, 09 Nov 2013 09:02:42 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:50871) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf97X-0000jn-5v for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 09:02:40 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MW000M001CNTF00@a-mtaout23.012.net.il> for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 16:02:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW000MOH1O8SC50@a-mtaout23.012.net.il>; Sat, 09 Nov 2013 16:02:32 +0200 (IST) Date: Sat, 09 Nov 2013 16:02:21 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <83k3gh4yd6.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: nbtrap@nbtrap.com Message-id: <83fvr54qs2.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> <83k3gh4yd6.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: michael_heerdegen@web.de, 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 09 Nov 2013 13:18:29 +0200 > From: Eli Zaretskii > Cc: michael_heerdegen@web.de, 15841@debbugs.gnu.org > > emacs -Q --eval "(setq-default cache-long-scans nil)" > C-x C-f src/xdisp.c > M-: (setq cache-long-scans t) RET > M-x linum-mode RET > M-> > > Many line numbers near the end of the buffer are not shown in the > margin. This seems to be related to font-lock: turning off global-font-lock-mode makes the problems go away. Manually invoking font-lock-fontify-buffer before turning on linum-mode also eliminates the problems, so it looks like JIT Font Lock is the prime suspect. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 16:28:30 2013 Received: (at 15841) by debbugs.gnu.org; 9 Nov 2013 21:28:30 +0000 Received: from localhost ([127.0.0.1]:44691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfG4z-0003lA-L6 for submit@debbugs.gnu.org; Sat, 09 Nov 2013 16:28:29 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:58349) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfG4w-0003kv-Iu for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 16:28:27 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MW000L00M685X00@a-mtaout21.012.net.il> for 15841@debbugs.gnu.org; Sat, 09 Nov 2013 23:27:11 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW000LHTM9B5Z00@a-mtaout21.012.net.il>; Sat, 09 Nov 2013 23:27:11 +0200 (IST) Date: Sat, 09 Nov 2013 23:27:01 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <83fvr54qs2.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: nbtrap@nbtrap.com Message-id: <83d2m9466y.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> <83k3gh4yd6.fsf@gnu.org> <83fvr54qs2.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: michael_heerdegen@web.de, 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 09 Nov 2013 16:02:21 +0200 > From: Eli Zaretskii > Cc: michael_heerdegen@web.de, 15841@debbugs.gnu.org > > > Date: Sat, 09 Nov 2013 13:18:29 +0200 > > From: Eli Zaretskii > > Cc: michael_heerdegen@web.de, 15841@debbugs.gnu.org > > > > emacs -Q --eval "(setq-default cache-long-scans nil)" > > C-x C-f src/xdisp.c > > M-: (setq cache-long-scans t) RET > > M-x linum-mode RET > > M-> > > > > Many line numbers near the end of the buffer are not shown in the > > margin. > > This seems to be related to font-lock: turning off > global-font-lock-mode makes the problems go away. Manually invoking > font-lock-fontify-buffer before turning on linum-mode also eliminates > the problems, so it looks like JIT Font Lock is the prime suspect. The problem was that while the "dumb loop" in find_newline was running, memory allocation in know_region_cache could have caused relocation of buffer text, so C pointers needed to be adjusted, but weren't. Fixed in trunk revision 115052. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 13:20:34 2013 Received: (at 15841) by debbugs.gnu.org; 10 Nov 2013 18:20:34 +0000 Received: from localhost ([127.0.0.1]:45781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfZcf-0001YE-Jj for submit@debbugs.gnu.org; Sun, 10 Nov 2013 13:20:33 -0500 Received: from mout.web.de ([212.227.17.11]:49494) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfZcW-0001Xq-5g for 15841@debbugs.gnu.org; Sun, 10 Nov 2013 13:20:28 -0500 Received: from drachen.dragon ([90.186.249.242]) by smtp.web.de (mrweb002) with ESMTPA (Nemesis) id 0McFcd-1VLyXH48Pv-00JX1S for <15841@debbugs.gnu.org>; Sun, 10 Nov 2013 19:20:17 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-Reply-To: <83ppqa3rim.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Nov 2013 10:31:45 +0200") References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Sun, 10 Nov 2013 19:20:13 +0100 Message-ID: <87eh6o6rvm.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:73FavlaFNhRSFS5rmhZ1PVMolvaespc23d6u82yg7xxAtnfl44f wxy0bdqSbBBpbiPt1dex8xB03C0XeX1POro0GC9AzhZdugYZ6IJi3mdhrvGCPL/U5VF+50C Ar8fASObO2cqah91m8U415rpoCIxnAtyBKwOysgseiQnVWEHAY8JwD/hh4r5mabuKjXfVmy aWyDZaO1TnoejuOIEWr3Q== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > > I see something probably related. Sometimes, evaluating > > > > (line-number-at-pos) > > > > at the end of my .emacs (10000 lines) needs over a second. Doing > > > > (setq cache-long-scans nil) > > > > immediately fixes this. Dunno yet how to provoke the problem. > > Please do try to find a recipe. I just did that with xdisp.c (almost > 30000 lines), and couldn't reproduce this. line-number-at-pos is > instantaneous, whether I try it at the beginning, the end, or the > middle of the file. Sorry, I was misguided. What was slow wasn't `line-number-at-pos' but redisplay (so only the result of evaluation showed up delayed). This long time for redisplay does only happen with some code I'm currently developing, but also only when cache-long-scans is non-nil. Anyway, I'll tell you when I have a recipe. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 13:31:28 2013 Received: (at 15841) by debbugs.gnu.org; 10 Nov 2013 18:31:28 +0000 Received: from localhost ([127.0.0.1]:45791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfZnE-0001od-32 for submit@debbugs.gnu.org; Sun, 10 Nov 2013 13:31:28 -0500 Received: from mtaout21.012.net.il ([80.179.55.169]:37255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfZnA-0001oO-NP for 15841@debbugs.gnu.org; Sun, 10 Nov 2013 13:31:26 -0500 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MW2005008MQMS00@a-mtaout21.012.net.il> for 15841@debbugs.gnu.org; Sun, 10 Nov 2013 20:31:18 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW2005M88S5CYC0@a-mtaout21.012.net.il>; Sun, 10 Nov 2013 20:31:18 +0200 (IST) Date: Sun, 10 Nov 2013 20:31:10 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <87eh6o6rvm.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83y54w2jo1.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> <87eh6o6rvm.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com > Date: Sun, 10 Nov 2013 19:20:13 +0100 > > Sorry, I was misguided. What was slow wasn't `line-number-at-pos' but > redisplay (so only the result of evaluation showed up delayed). This > long time for redisplay does only happen with some code I'm currently > developing, but also only when cache-long-scans is non-nil. Thanks for clarifying. > Anyway, I'll tell you when I have a recipe. Please do, and thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 22:40:16 2013 Received: (at 15841) by debbugs.gnu.org; 11 Nov 2013 03:40:16 +0000 Received: from localhost ([127.0.0.1]:46120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfiMJ-00006b-R9 for submit@debbugs.gnu.org; Sun, 10 Nov 2013 22:40:16 -0500 Received: from mout.web.de ([212.227.17.12]:50972) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfiMF-00006D-0P for 15841@debbugs.gnu.org; Sun, 10 Nov 2013 22:40:12 -0500 Received: from drachen.dragon ([90.186.249.242]) by smtp.web.de (mrweb102) with ESMTPA (Nemesis) id 0Lrruc-1VasnM1wGk-013dvw for <15841@debbugs.gnu.org>; Mon, 11 Nov 2013 04:40:04 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> <87eh6o6rvm.fsf@web.de> <83y54w2jo1.fsf@gnu.org> Date: Mon, 11 Nov 2013 04:39:56 +0100 In-Reply-To: <83y54w2jo1.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Nov 2013 20:31:10 +0200") Message-ID: <87li0vppwz.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:SZcyNdizjt1kNF7US/lV5sX6Vg+5lr5r/4RF4laVlYfkcbSBJUw 3yI2BBgspVUi8y0xDptO/v/QJGLsySVcESXltoLOlWbTFrNq0aCGLerFUR1tnbnLkileF6U Q3QKetoG3gr8jAofsQLisDQ8k1SE9Qep2ck4f1T3Dee+EmBP3afhPHa91anENB/2HYVkynh caeReVpLuSDfHAOangIUw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > > Anyway, I'll tell you when I have a recipe. Some elaborations, feel free to ignore. The culprit was my own code: it placed myriads of invisible overlays with no properties into the buffer. Under these extreme circumstances, `line-number-at-pos' indeed gets extremely slow at the end of my 10000 lines buffer: one invocation needs over a second. I saw that with elp as well as with profiler. Setting `cache-long-scans' to nil (or removing the overlays) cures this. Although this is a corner case, I wonder why overlays slow down `line-number-at-pos' so much for `cache-long-scans' non-nil - is that expected? Or can the profiler times I saw span redisplay times? Because, when I use this: (defmacro my-measure-time (expr) "Eval EXPR, display how much time it took." (with-gensyms (time) `(let ((,time (current-time))) ,expr (message "%s secs" (float-time (time-subtract (current-time) ,time)))))) and evaluate (my-measure-time (line-number-at-pos)) manually with M-: (in the same situation), it shows a very tiny value. But I'm sure that from code, `line-number-at-pos' really lasts over a second. Strange, I don't understand it. Regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 09:12:27 2013 Received: (at 15841) by debbugs.gnu.org; 11 Nov 2013 14:12:27 +0000 Received: from localhost ([127.0.0.1]:46759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfsE6-0008SW-Oo for submit@debbugs.gnu.org; Mon, 11 Nov 2013 09:12:27 -0500 Received: from mout.gmx.net ([212.227.17.21]:64881) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfsE3-0008SD-C9 for 15841@debbugs.gnu.org; Mon, 11 Nov 2013 09:12:24 -0500 Received: from rosalinde.fritz.box ([89.245.114.196]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0Ld0E0-1VFIqe2NQ8-00iC57 for <15841@debbugs.gnu.org>; Mon, 11 Nov 2013 15:12:16 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> Date: Mon, 11 Nov 2013 15:12:15 +0100 In-Reply-To: <83r4aq3s4r.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 09 Nov 2013 10:18:28 +0200") Message-ID: <87fvr3ni2o.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:MwEzbZ5Ze9bEM+M0zj4pZT0MxzcwUBLjzNeRpoFhtJhaxGc4U3X jGn/uvIFxffd3trA3f0khwJ49Ozp9QVqE2gSpl8xfRURZjVNHN6n2evwN7lZenmW7WROVlH p2miY/3YWYLOA/WDc0p5pRNgAD5jurtzwKu80wtctBT0+IjsnDrVEgxyVZg4RMWj2zNGnHV ptshLfSAJLIJ1x2HwLT/w== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This change broke dired-maybe-insert-subdir. Perhaps this should be a new bug number, but since part of the breakage is display-related, I decided to report it here. To reproduce: 0. emacs -Q (built from trunk bzr 115033 or later) 1. Open a directory in Dired, e.g. the Emacs source tree root. 2. Put point on an entry listing a directory, e.g. admin. 3. Type `i'. => Emacs hangs. If I repeat the recipe but after step 1 type `M-: (setq cache-long-lines nil)', then at step 3, `i' works as expected. Here are more details of the breakage: Typing `C-g' releases the hang and shows the admin subdirectory, but its display is corrupted: (i) the "available" blocks information, which should appear at the end of the "total" line, instead appears to the right of the first entry `.' and is fontified with dired-directory face; (ii) while all the entries of admin are listed below the `..' entry, the entire line of each entry is fontified with dired-directory face, and these lines cannot be accessed by vertical motion commands like `C-n' or `C-p', though they can be with horizontal motion commands like `C-f' and `C-p'. In fact, all of these entries appear to Dired to be part of the line of the `..' entry, and AFACT this is what causes the hang: Emacs infloops in dired-move-to-filename because, when point appears to be at eof, beginning-of-line moves it back to the start of the `..' entry. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 11:23:28 2013 Received: (at 15841) by debbugs.gnu.org; 11 Nov 2013 16:23:28 +0000 Received: from localhost ([127.0.0.1]:47202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfuGt-0003Ko-NP for submit@debbugs.gnu.org; Mon, 11 Nov 2013 11:23:28 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:52796) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfuGo-0003KW-L6 for 15841@debbugs.gnu.org; Mon, 11 Nov 2013 11:23:26 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MW300A00XGIK700@a-mtaout23.012.net.il> for 15841@debbugs.gnu.org; Mon, 11 Nov 2013 18:23:15 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW300A5NXIRJW10@a-mtaout23.012.net.il>; Mon, 11 Nov 2013 18:23:15 +0200 (IST) Date: Mon, 11 Nov 2013 18:23:10 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <87li0vppwz.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83li0u3o29.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> <87eh6o6rvm.fsf@web.de> <83y54w2jo1.fsf@gnu.org> <87li0vppwz.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com > Date: Mon, 11 Nov 2013 04:39:56 +0100 > > The culprit was my own code: it placed myriads of invisible overlays > with no properties into the buffer. Under these extreme circumstances, > `line-number-at-pos' indeed gets extremely slow at the end of my 10000 > lines buffer: one invocation needs over a second. I saw that with elp > as well as with profiler. Setting `cache-long-scans' to nil (or > removing the overlays) cures this. Can you show some simple enough code that puts so many overlays, and has this effect? It sounds like some optimization is in order. > Although this is a corner case, I wonder why overlays slow down > `line-number-at-pos' so much for `cache-long-scans' non-nil - is that > expected? I don't know. Armed with a simple test case, I will look into this and see what I find. > Because, when I use this: > > (defmacro my-measure-time (expr) > "Eval EXPR, display how much time it took." > (with-gensyms (time) > `(let ((,time (current-time))) > ,expr > (message "%s secs" > (float-time (time-subtract (current-time) ,time)))))) > > and evaluate (my-measure-time (line-number-at-pos)) manually with M-: > (in the same situation), it shows a very tiny value. But I'm sure that > from code, `line-number-at-pos' really lasts over a second. Strange, I > don't understand it. Redisplay is indeed a likely suspect, but still cache-long-scans somehow comes into play. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 15:13:50 2013 Received: (at 15841) by debbugs.gnu.org; 11 Nov 2013 20:13:50 +0000 Received: from localhost ([127.0.0.1]:47438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vfxrp-0000iu-M2 for submit@debbugs.gnu.org; Mon, 11 Nov 2013 15:13:50 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:38235) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vfxrm-0000id-UL for 15841@debbugs.gnu.org; Mon, 11 Nov 2013 15:13:47 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MW400B00857MR00@a-mtaout20.012.net.il> for 15841@debbugs.gnu.org; Mon, 11 Nov 2013 22:13:40 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW400BKF86SK040@a-mtaout20.012.net.il>; Mon, 11 Nov 2013 22:13:40 +0200 (IST) Date: Mon, 11 Nov 2013 22:13:36 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <87fvr3ni2o.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <838uwu3de7.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stephen Berman > Cc: 15841@debbugs.gnu.org > Date: Mon, 11 Nov 2013 15:12:15 +0100 > > This change broke dired-maybe-insert-subdir. Perhaps this should be a > new bug number, but since part of the breakage is display-related, I > decided to report it here. To reproduce: > > 0. emacs -Q (built from trunk bzr 115033 or later) > 1. Open a directory in Dired, e.g. the Emacs source tree root. > 2. Put point on an entry listing a directory, e.g. admin. > 3. Type `i'. > => Emacs hangs. Actually, if you rebuild with assertions (--enable-checking), Emacs hits an assertion violation before it starts inflooping, and aborts. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 15:39:09 2013 Received: (at 15841) by debbugs.gnu.org; 11 Nov 2013 20:39:09 +0000 Received: from localhost ([127.0.0.1]:47459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfyGL-0001M3-6X for submit@debbugs.gnu.org; Mon, 11 Nov 2013 15:39:09 -0500 Received: from mout.gmx.net ([212.227.15.15]:59739) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfyGH-0001LU-KH for 15841@debbugs.gnu.org; Mon, 11 Nov 2013 15:39:06 -0500 Received: from rosalinde.fritz.box ([89.245.114.196]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MWCKz-1WCgax36AD-00XNRL for <15841@debbugs.gnu.org>; Mon, 11 Nov 2013 21:38:59 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <838uwu3de7.fsf@gnu.org> Date: Mon, 11 Nov 2013 21:38:58 +0100 In-Reply-To: <838uwu3de7.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Nov 2013 22:13:36 +0200") Message-ID: <87bo1qoeql.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:gGTobRHKNGRfZAg4O4XtG5mqSo2aY8HzV7jrt8zz4qG0HXyksJu 4khMWw6zc3/FYx2UCuvGpE3N6ImPVZM+rPwvTkhRGtlVrXPWJtt/IfpCrOCiL2PkyJU9kSS kv/7bFlLqOIcEgEUw1RjF1Zb4tXnLDpn/8tut4hp/JM/xJgVMQhdItLqFnRXshkHnhfIBUn 3DiP/XAvh+2o0jRBcHDVA== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Mon, 11 Nov 2013 22:13:36 +0200 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: 15841@debbugs.gnu.org >> Date: Mon, 11 Nov 2013 15:12:15 +0100 >> >> This change broke dired-maybe-insert-subdir. Perhaps this should be a >> new bug number, but since part of the breakage is display-related, I >> decided to report it here. To reproduce: >> >> 0. emacs -Q (built from trunk bzr 115033 or later) >> 1. Open a directory in Dired, e.g. the Emacs source tree root. >> 2. Put point on an entry listing a directory, e.g. admin. >> 3. Type `i'. >> => Emacs hangs. > > Actually, if you rebuild with assertions (--enable-checking), Emacs > hits an assertion violation before it starts inflooping, and aborts. As a matter of fact, I've also gotten an abort a couple of times while trying to track down this bug, though I did not build with --enable-checking; unfortunately, I don't remember exactly what I what doing, nor was I running under gdb, so no backtrace. I also have another observation, which seems to be reproducible, though I haven't tested it extensively: if I type `i' on any directory entry in Dired, which makes Emacs hang, then type `C-g' to unhang Emacs, then type `i' on a *higher* directory entry in the same Dired buffer, whose name begins with `.' (e.g. `.bzr'), then `i' works as expected. This appears to hold for all higher dotted (and only dotted) directory entries; but if I type `i' on a *lower* dotted directory entry, then Emacs again hangs. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 19:38:45 2013 Received: (at 15841) by debbugs.gnu.org; 12 Nov 2013 00:38:45 +0000 Received: from localhost ([127.0.0.1]:47591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vg20C-00077N-Ld for submit@debbugs.gnu.org; Mon, 11 Nov 2013 19:38:44 -0500 Received: from mout.gmx.net ([212.227.17.22]:49714) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vg20A-000777-5a for 15841@debbugs.gnu.org; Mon, 11 Nov 2013 19:38:43 -0500 Received: from rosalinde.fritz.box ([89.245.67.18]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MPYqL-1Vk8jq1MFV-004jHi for <15841@debbugs.gnu.org>; Tue, 12 Nov 2013 01:38:35 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> Date: Tue, 12 Nov 2013 01:38:34 +0100 In-Reply-To: <87fvr3ni2o.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Mon, 11 Nov 2013 15:12:15 +0100") Message-ID: <877gceo3n9.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:ir0f2/mdrGqlVH0XDKoFH471OBJIIyA3KbkumP6xZdGzfEjt48b 1RFjEL7QSaKRJ0CooERIpjkPiBfULYaA2KQZXzz7DR/YcecdBvFR6k/4un0BLordVa2EBJ4 l6pzBhkKzC3m0bR93n1eTOZFeoKFL8hfdN/rXjm2+EypDPCtKs94yw9zQPV2mLR2/C671dl 4dN1KB60gy+Z7SL4mRZlg== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Mon, 11 Nov 2013 15:12:15 +0100 Stephen Berman wrote: > This change broke dired-maybe-insert-subdir. Perhaps this should be a > new bug number, but since part of the breakage is display-related, I > decided to report it here. To reproduce: > > 0. emacs -Q (built from trunk bzr 115033 or later) > 1. Open a directory in Dired, e.g. the Emacs source tree root. > 2. Put point on an entry listing a directory, e.g. admin. > 3. Type `i'. > => Emacs hangs. > > If I repeat the recipe but after step 1 type `M-: (setq cache-long-lines > nil)', then at step 3, `i' works as expected. > > Here are more details of the breakage: > > Typing `C-g' releases the hang and shows the admin subdirectory, but its > display is corrupted: (i) the "available" blocks information, which > should appear at the end of the "total" line, instead appears to the > right of the first entry `.' and is fontified with dired-directory face; > (ii) while all the entries of admin are listed below the `..' entry, the > entire line of each entry is fontified with dired-directory face, and > these lines cannot be accessed by vertical motion commands like `C-n' or > `C-p', though they can be with horizontal motion commands like `C-f' and > `C-p'. In fact, all of these entries appear to Dired to be part of the > line of the `..' entry, and AFACT this is what causes the hang: Emacs > infloops in dired-move-to-filename because, when point appears to be at > eof, beginning-of-line moves it back to the start of the `..' entry. I tracked the problematic fontification and motion behavior to insert-directory in files.el: it happens during the loop when decode-coding-region is called on the file names of the subdirectory entries. I stepped through the code with Edebug but could not tell why it goes wrong here, and I'm too tired to pursue it further now. Also, when I step through this code, the "available" information is added at the end of the entire subdirectory listing, unlike what I observed above when just invoking `i' and then `C-g'. I guess this is due to the interaction of redisplay with stepping through the code; it's still clear that the subdirectory listing is being treated as part of the line containing the `..' entry. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 05:03:59 2013 Received: (at 15841) by debbugs.gnu.org; 12 Nov 2013 10:03:59 +0000 Received: from localhost ([127.0.0.1]:48125 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgApC-0006ev-Os for submit@debbugs.gnu.org; Tue, 12 Nov 2013 05:03:59 -0500 Received: from mout.gmx.net ([212.227.15.18]:62319) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgAp9-0006ee-EO for 15841@debbugs.gnu.org; Tue, 12 Nov 2013 05:03:56 -0500 Received: from rosalinde.fritz.box ([89.245.100.165]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0LiTF6-1VA7rM30Zg-00cgIE for <15841@debbugs.gnu.org>; Tue, 12 Nov 2013 11:03:49 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> Date: Tue, 12 Nov 2013 11:03:47 +0100 In-Reply-To: <877gceo3n9.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Tue, 12 Nov 2013 01:38:34 +0100") Message-ID: <87mwla6inw.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:BJL81Txdhv1P86QUMJ+g7WT3bWY2IPUquSyzYWcwg9r71s+NLP4 cPRAgOYyY57deOjq3ap6oxvAO5Nj3wgLYhl6AWiNzg8hTX+nzovRaVE7Eh83mjHtEts/y3Q Wm16ja3urLAo3IX4o6jjY9wbiVGzpH6zpcIXbOayeQGWLQmfsyKZiBoTQofg5XR642KZD9H vZxvkG8v0AyRohfo1t1qA== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, 12 Nov 2013 01:38:34 +0100 Stephen Berman wrote: > On Mon, 11 Nov 2013 15:12:15 +0100 Stephen Berman wrote: > >> This change broke dired-maybe-insert-subdir. Perhaps this should be a >> new bug number, but since part of the breakage is display-related, I >> decided to report it here. To reproduce: >> >> 0. emacs -Q (built from trunk bzr 115033 or later) >> 1. Open a directory in Dired, e.g. the Emacs source tree root. >> 2. Put point on an entry listing a directory, e.g. admin. >> 3. Type `i'. >> => Emacs hangs. >> >> If I repeat the recipe but after step 1 type `M-: (setq cache-long-lines >> nil)', then at step 3, `i' works as expected. >> >> Here are more details of the breakage: >> >> Typing `C-g' releases the hang and shows the admin subdirectory, but its >> display is corrupted: (i) the "available" blocks information, which >> should appear at the end of the "total" line, instead appears to the >> right of the first entry `.' and is fontified with dired-directory face; >> (ii) while all the entries of admin are listed below the `..' entry, the >> entire line of each entry is fontified with dired-directory face, and >> these lines cannot be accessed by vertical motion commands like `C-n' or >> `C-p', though they can be with horizontal motion commands like `C-f' and >> `C-p'. In fact, all of these entries appear to Dired to be part of the >> line of the `..' entry, and AFACT this is what causes the hang: Emacs >> infloops in dired-move-to-filename because, when point appears to be at >> eof, beginning-of-line moves it back to the start of the `..' entry. > > I tracked the problematic fontification and motion behavior to > insert-directory in files.el: it happens during the loop when > decode-coding-region is called on the file names of the subdirectory > entries. I stepped through the code with Edebug but could not tell why > it goes wrong here, and I'm too tired to pursue it further now. Also, > when I step through this code, the "available" information is added at > the end of the entire subdirectory listing, unlike what I observed above > when just invoking `i' and then `C-g'. I guess this is due to the > interaction of redisplay with stepping through the code; it's still > clear that the subdirectory listing is being treated as part of the line > containing the `..' entry. I set a breakpoint on decode_coding_object and stepped through it after invoking `i', but the Dired display changed to show the problematic fontification only upon exiting decode_coding_object. I don't know how to find out when cache_long_scans is checked other than manually tracing the call chains of each subroutine of decode_coding_object, which is too laborious. Is it possible to have execution halt when cache_long_scans is checked, and if so, how? Or is there a better way to try to track down this bug? Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 11:32:25 2013 Received: (at 15841) by debbugs.gnu.org; 12 Nov 2013 16:32:26 +0000 Received: from localhost ([127.0.0.1]:48994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgGt6-0006Yl-1e for submit@debbugs.gnu.org; Tue, 12 Nov 2013 11:32:25 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:39424) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgGt3-0006YV-B1 for 15841@debbugs.gnu.org; Tue, 12 Nov 2013 11:32:22 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MW500J00SIK5B00@a-mtaout22.012.net.il> for 15841@debbugs.gnu.org; Tue, 12 Nov 2013 18:31:35 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW500IKTSKNSFC0@a-mtaout22.012.net.il>; Tue, 12 Nov 2013 18:31:35 +0200 (IST) Date: Tue, 12 Nov 2013 18:31:32 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <87mwla6inw.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <83txfh1t0b.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> <87mwla6inw.fsf@rosalinde.fritz.box> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stephen Berman > Cc: 15841@debbugs.gnu.org > Date: Tue, 12 Nov 2013 11:03:47 +0100 > > > I tracked the problematic fontification and motion behavior to > > insert-directory in files.el: it happens during the loop when > > decode-coding-region is called on the file names of the subdirectory > > entries. I stepped through the code with Edebug but could not tell why > > it goes wrong here, and I'm too tired to pursue it further now. Also, > > when I step through this code, the "available" information is added at > > the end of the entire subdirectory listing, unlike what I observed above > > when just invoking `i' and then `C-g'. I guess this is due to the > > interaction of redisplay with stepping through the code; it's still > > clear that the subdirectory listing is being treated as part of the line > > containing the `..' entry. > > I set a breakpoint on decode_coding_object and stepped through it after > invoking `i', but the Dired display changed to show the problematic > fontification only upon exiting decode_coding_object. I don't know how > to find out when cache_long_scans is checked other than manually tracing > the call chains of each subroutine of decode_coding_object, which is too > laborious. There's no need: I already established that, as you point out, the changes to the buffer that cause the problem are indeed made by decode-coding-region. The problem becomes visible when redisplay, entered after decode-coding-region finishes its job, re-fontifies portions of the buffer that were affected by the changes. The way this affects redisplay is through forward-line and line-beginning-position, of which JIT Font Lock is a heavy user. That's why you only see the effect after decode-coding-region returns. > Is it possible to have execution halt when cache_long_scans is > checked, and if so, how? Watchpoints are the answer. But in this case, there's only one place in the whole Emacs where this variable is consulted: in search.c, around line 610, so you could just put a breakpoint there. In any case, I already traced through the code that is involved, and the immediate reason for the assertion violation is that the cache isn't being updated wrt changes in buffer size (which are caused by decoding the stuff brought in by 'ls'). However, a naive attempt to force such updates didn't solve the whole problem: the aborts are gone, but the infloop is still there, and also other minor display issues. So I guess there's another factor at work there... I also need to figure out how to keep the cache up to date without penalizing performance, which would render the cache worthless. > Or is there a better way to try to track down this bug? The cache has only 3 public interfaces (see region-cache.c), so it is easy to put breakpoints in all of them and see what happens. That's what I did. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 12 16:34:55 2013 Received: (at 15841) by debbugs.gnu.org; 12 Nov 2013 21:34:55 +0000 Received: from localhost ([127.0.0.1]:49252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgLbq-0005Xq-6Y for submit@debbugs.gnu.org; Tue, 12 Nov 2013 16:34:54 -0500 Received: from mout.gmx.net ([212.227.15.18]:55829) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VgLbn-0005Xb-9Q for 15841@debbugs.gnu.org; Tue, 12 Nov 2013 16:34:52 -0500 Received: from rosalinde.fritz.box ([89.245.100.165]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MCtut-1VouBD0CSh-009dUZ for <15841@debbugs.gnu.org>; Tue, 12 Nov 2013 22:34:44 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> <87mwla6inw.fsf@rosalinde.fritz.box> <83txfh1t0b.fsf@gnu.org> Date: Tue, 12 Nov 2013 22:34:43 +0100 In-Reply-To: <83txfh1t0b.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 12 Nov 2013 18:31:32 +0200") Message-ID: <87iovx718s.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:xEif644bRGnk8ApXAxlIBJT87KIjgt8mKiIlJt6m0+bCWumtS+I fuNFmUDlsk3PiIi3mg2/KKJYS/BkVfUGEeAvRA4WKfKeL8FYw3wwmTkc1kSDJ9Ojq/YLgPo eXeZAVVcMAzDj+DKJt3K/DVTdjYj3LBmBDo5kGBxJeFYmSLXjMUYU9mBMwrzscHDaQW7EyO cRvHkjlbruQn+XUQq4esA== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, 12 Nov 2013 18:31:32 +0200 Eli Zaretskii wrote: > I already established that, as you point out, the > changes to the buffer that cause the problem are indeed made by > decode-coding-region. The problem becomes visible when redisplay, > entered after decode-coding-region finishes its job, re-fontifies > portions of the buffer that were affected by the changes. The way > this affects redisplay is through forward-line and > line-beginning-position, of which JIT Font Lock is a heavy user. > That's why you only see the effect after decode-coding-region returns. Thanks for the explanation. >> Is it possible to have execution halt when cache_long_scans is >> checked, and if so, how? > > Watchpoints are the answer. But in this case, there's only one place > in the whole Emacs where this variable is consulted: in search.c, > around line 610, so you could just put a breakpoint there. > > In any case, I already traced through the code that is involved, and > the immediate reason for the assertion violation is that the cache > isn't being updated wrt changes in buffer size (which are caused by > decoding the stuff brought in by 'ls'). However, a naive attempt to > force such updates didn't solve the whole problem: the aborts are > gone, but the infloop is still there, and also other minor display > issues. So I guess there's another factor at work there... Fascinating, what unsuspected and apparently unrelated effects can be brought to the surface by toggling the value of a variable! > I also need to figure out how to keep the cache up to date without > penalizing performance, which would render the cache worthless. > >> Or is there a better way to try to track down this bug? > > The cache has only 3 public interfaces (see region-cache.c), so it is > easy to put breakpoints in all of them and see what happens. That's > what I did. Thanks for the advice and for working on this bug. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 13 18:45:31 2013 Received: (at 15841) by debbugs.gnu.org; 13 Nov 2013 23:45:31 +0000 Received: from localhost ([127.0.0.1]:50836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vgk7n-0006WG-BV for submit@debbugs.gnu.org; Wed, 13 Nov 2013 18:45:31 -0500 Received: from mout.web.de ([212.227.15.4]:64868) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vgk7j-0006Vw-At for 15841@debbugs.gnu.org; Wed, 13 Nov 2013 18:45:28 -0500 Received: from drachen.dragon ([90.187.136.19]) by smtp.web.de (mrweb102) with ESMTPA (Nemesis) id 0MOilO-1VkbTV1ipK-006AiG for <15841@debbugs.gnu.org>; Thu, 14 Nov 2013 00:45:20 +0100 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> <87eh6o6rvm.fsf@web.de> <83y54w2jo1.fsf@gnu.org> <87li0vppwz.fsf@web.de> <83li0u3o29.fsf@gnu.org> Date: Thu, 14 Nov 2013 00:45:17 +0100 In-Reply-To: <83li0u3o29.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 11 Nov 2013 18:23:10 +0200") Message-ID: <87a9h7c1de.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:zglTIo299q5Wb6Nadv0ZENcCaw9OCB3fosmaa4M1mhK0FMPV2W5 qbS5qsLDErNTVGoKbdlXHpiumpzK1fOQIjs5adJEBipSQmuCC5zYrdpjwLuFb9g2WgJbJS2 3Dr/D6YwKNOO9A744nAmDwi6i4X4SfORcjTDarJhsQ9dRP6R0wn3y6WaXc1b90QYrt4JlAY vsji4A0VTqg8qmCDfMSvg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Eli Zaretskii writes: > > From: Michael Heerdegen > > Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com > > Date: Mon, 11 Nov 2013 04:39:56 +0100 > > > > The culprit was my own code: it placed myriads of invisible overlays > > with no properties into the buffer. Under these extreme circumstances, > > `line-number-at-pos' indeed gets extremely slow at the end of my 10000 > > lines buffer: one invocation needs over a second. I saw that with elp > > as well as with profiler. Setting `cache-long-scans' to nil (or > > removing the overlays) cures this. > > Can you show some simple enough code that puts so many overlays, and > has this effect? It sounds like some optimization is in order. Sorry, I did not find an easy test case. I tried to simplify the essence of what my code does, but the effect didn't occur. Seems that lots of different things must come together to provoke this symptom. Given the fact that my code was really broken, I don't think it's worth the time to follow this up. It would cost me many hours to compile some test code for emacs -Q. Or do you think it would be worth it? If you think it could be very important, I would do it, but it would be very time intensive. My code works well now with `cache-long-scans' t after the right fixes, btw. Regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 13 22:51:53 2013 Received: (at 15841) by debbugs.gnu.org; 14 Nov 2013 03:51:53 +0000 Received: from localhost ([127.0.0.1]:51081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vgny8-00046V-UY for submit@debbugs.gnu.org; Wed, 13 Nov 2013 22:51:53 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:42282) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vgny7-00046I-D4 for 15841@debbugs.gnu.org; Wed, 13 Nov 2013 22:51:48 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MW800F00INOVH00@a-mtaout20.012.net.il> for 15841@debbugs.gnu.org; Thu, 14 Nov 2013 05:51:41 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW800FMJIQ5MGC0@a-mtaout20.012.net.il>; Thu, 14 Nov 2013 05:51:41 +0200 (IST) Date: Thu, 14 Nov 2013 05:51:26 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <87a9h7c1de.fsf@web.de> X-012-Sender: halo1@inter.net.il To: Michael Heerdegen Message-id: <83y54rzlmp.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <83ppqa3rim.fsf@gnu.org> <87eh6o6rvm.fsf@web.de> <83y54w2jo1.fsf@gnu.org> <87li0vppwz.fsf@web.de> <83li0u3o29.fsf@gnu.org> <87a9h7c1de.fsf@web.de> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Michael Heerdegen > Cc: 15841@debbugs.gnu.org, nbtrap@nbtrap.com > Date: Thu, 14 Nov 2013 00:45:17 +0100 > > > Can you show some simple enough code that puts so many overlays, and > > has this effect? It sounds like some optimization is in order. > > Sorry, I did not find an easy test case. I tried to simplify the > essence of what my code does, but the effect didn't occur. Seems that > lots of different things must come together to provoke this symptom. > Given the fact that my code was really broken, I don't think it's worth > the time to follow this up. It would cost me many hours to compile some > test code for emacs -Q. Or do you think it would be worth it? If you > think it could be very important, I would do it, but it would be very > time intensive. My code works well now with `cache-long-scans' t after > the right fixes, btw. If the bug isn't reproducible, it isn't worth working on. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 14 11:45:15 2013 Received: (at control) by debbugs.gnu.org; 14 Nov 2013 16:45:15 +0000 Received: from localhost ([127.0.0.1]:52310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vh02c-0007oU-RJ for submit@debbugs.gnu.org; Thu, 14 Nov 2013 11:45:15 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:37770) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vh02a-0007oA-4S; Thu, 14 Nov 2013 11:45:13 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MW900000IEB9800@a-mtaout20.012.net.il>; Thu, 14 Nov 2013 18:44:44 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW900NRFIIK48C0@a-mtaout20.012.net.il>; Thu, 14 Nov 2013 18:44:44 +0200 (IST) Date: Thu, 14 Nov 2013 18:44:28 +0200 From: Eli Zaretskii Subject: Re: bug#15893: 24.3.50; emacs_backtrace In-reply-to: X-012-Sender: halo1@inter.net.il To: Dani Moncayo Message-id: <83ppq3ylub.fsf@gnu.org> References: X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control Cc: 15893@debbugs.gnu.org, control@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 15893 15841 thanks > Date: Thu, 14 Nov 2013 14:27:36 +0100 > From: Dani Moncayo > > w32_backtrace at w32fns.c:7958 > emacs_abort at w32fns.c:7990 > terminate_due_to_signal at emacs.c:377 > die at alloc.c:6737 > set_cache_region at region-cache.c:363 > revalidate_region_cache at region-cache.c:588 > invalidate_region_cache at region-cache.c:477 > prepare_to_modify_buffer at insdel.c:1874 > insert_from_buffer_1 at insdel.c:1096 > insert_from_buffer at insdel.c:1043 > Finsert_file_contents at fileio.c:4044 This is a duplicate of 15841. If you can recall what were you doing when this happened, please tell. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 15 11:34:31 2013 Received: (at 15841) by debbugs.gnu.org; 15 Nov 2013 16:34:31 +0000 Received: from localhost ([127.0.0.1]:56124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhMLn-0007YX-3n for submit@debbugs.gnu.org; Fri, 15 Nov 2013 11:34:31 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:36891) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhMLk-0007YJ-4u for 15841@debbugs.gnu.org; Fri, 15 Nov 2013 11:34:29 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MWB00200CAWCA00@a-mtaout23.012.net.il> for 15841@debbugs.gnu.org; Fri, 15 Nov 2013 18:34:21 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MWB00244CP79E80@a-mtaout23.012.net.il>; Fri, 15 Nov 2013 18:34:20 +0200 (IST) Date: Fri, 15 Nov 2013 18:34:05 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <83txfh1t0b.fsf@gnu.org> X-012-Sender: halo1@inter.net.il To: stephen.berman@gmx.net Message-id: <838uwpipz6.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> <87mwla6inw.fsf@rosalinde.fritz.box> <83txfh1t0b.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Tue, 12 Nov 2013 18:31:32 +0200 > From: Eli Zaretskii > Cc: 15841@debbugs.gnu.org > > In any case, I already traced through the code that is involved, and > the immediate reason for the assertion violation is that the cache > isn't being updated wrt changes in buffer size (which are caused by > decoding the stuff brought in by 'ls'). However, a naive attempt to > force such updates didn't solve the whole problem: the aborts are > gone, but the infloop is still there, and also other minor display > issues. So I guess there's another factor at work there... I think I might have found a solution for this. Could you please run with the patch below for a while, and see if it gives good results? === modified file 'src/coding.c' --- src/coding.c 2013-10-08 06:40:09 +0000 +++ src/coding.c 2013-11-15 16:27:56 +0000 @@ -9358,6 +9358,14 @@ code_convert_region (Lisp_Object start, setup_coding_system (coding_system, &coding); coding.mode |= CODING_MODE_LAST_BLOCK; + if (BUFFERP (dst_object) && !EQ (dst_object, src_object)) + { + struct buffer *buf = XBUFFER (dst_object); + ptrdiff_t buf_pt = BUF_PT (buf); + + invalidate_buffer_caches (buf, buf_pt, buf_pt); + } + if (encodep) encode_coding_object (&coding, src_object, from, from_byte, to, to_byte, dst_object); @@ -9447,6 +9455,15 @@ code_convert_string (Lisp_Object string, coding.mode |= CODING_MODE_LAST_BLOCK; chars = SCHARS (string); bytes = SBYTES (string); + + if (BUFFERP (dst_object)) + { + struct buffer *buf = XBUFFER (dst_object); + ptrdiff_t buf_pt = BUF_PT (buf); + + invalidate_buffer_caches (buf, buf_pt, buf_pt); + } + if (encodep) encode_coding_object (&coding, string, 0, 0, chars, bytes, dst_object); else === modified file 'src/insdel.c' --- src/insdel.c 2013-11-11 05:18:53 +0000 +++ src/insdel.c 2013-11-15 16:27:56 +0000 @@ -993,6 +993,11 @@ insert_from_gap (ptrdiff_t nchars, ptrdi if (NILP (BVAR (current_buffer, enable_multibyte_characters))) nchars = nbytes; + /* No need to call prepare_to_modify_buffer, since this is called + from places that replace some region with a different text, so + prepare_to_modify_buffer was already called by the deletion part + of this dance. */ + invalidate_buffer_caches (current_buffer, GPT, GPT); record_insert (GPT, nchars); MODIFF++; @@ -1869,19 +1874,26 @@ prepare_to_modify_buffer (ptrdiff_t star ptrdiff_t *preserve_ptr) { prepare_to_modify_buffer_1 (start, end, preserve_ptr); + invalidate_buffer_caches (current_buffer, start, end); +} - if (current_buffer->newline_cache) - invalidate_region_cache (current_buffer, - current_buffer->newline_cache, - start - BEG, Z - end); - if (current_buffer->width_run_cache) - invalidate_region_cache (current_buffer, - current_buffer->width_run_cache, - start - BEG, Z - end); - if (current_buffer->bidi_paragraph_cache) - invalidate_region_cache (current_buffer, - current_buffer->bidi_paragraph_cache, - start - BEG, Z - end); +/* Invalidate the caches maintained by the buffer BUF, if any, for the + region between buffer positions START and END. */ +void +invalidate_buffer_caches (struct buffer *buf, ptrdiff_t start, ptrdiff_t end) +{ + if (buf->newline_cache) + invalidate_region_cache (buf, + buf->newline_cache, + start - BUF_BEG (buf), BUF_Z (buf) - end); + if (buf->width_run_cache) + invalidate_region_cache (buf, + buf->width_run_cache, + start - BUF_BEG (buf), BUF_Z (buf) - end); + if (buf->bidi_paragraph_cache) + invalidate_region_cache (buf, + buf->bidi_paragraph_cache, + start - BUF_BEG (buf), BUF_Z (buf) - end); } /* These macros work with an argument named `preserve_ptr' === modified file 'src/lisp.h' --- src/lisp.h 2013-11-15 08:18:37 +0000 +++ src/lisp.h 2013-11-15 16:27:56 +0000 @@ -3486,6 +3486,7 @@ extern Lisp_Object del_range_2 (ptrdiff_ extern void modify_text (ptrdiff_t, ptrdiff_t); extern void prepare_to_modify_buffer (ptrdiff_t, ptrdiff_t, ptrdiff_t *); extern void prepare_to_modify_buffer_1 (ptrdiff_t, ptrdiff_t, ptrdiff_t *); +extern void invalidate_buffer_caches (struct buffer *, ptrdiff_t, ptrdiff_t); extern void signal_after_change (ptrdiff_t, ptrdiff_t, ptrdiff_t); extern void adjust_after_insert (ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t); From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 15 11:39:43 2013 Received: (at control) by debbugs.gnu.org; 15 Nov 2013 16:39:43 +0000 Received: from localhost ([127.0.0.1]:56130 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhMQo-0007g9-Iv for submit@debbugs.gnu.org; Fri, 15 Nov 2013 11:39:42 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:51801) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhMQl-0007fn-6K; Fri, 15 Nov 2013 11:39:40 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MWB00900CI54200@a-mtaout22.012.net.il>; Fri, 15 Nov 2013 18:39:32 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MWB008MCCXWXY80@a-mtaout22.012.net.il>; Fri, 15 Nov 2013 18:39:32 +0200 (IST) Date: Fri, 15 Nov 2013 18:39:18 +0200 From: Eli Zaretskii Subject: Re: bug#15898: Emacs aborts in buf_charpos_to_bytepos In-reply-to: X-012-Sender: halo1@inter.net.il To: Barry OReilly Message-id: <8361rtipqh.fsf@gnu.org> References: <83ppq2i06d.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: control Cc: 15898@debbugs.gnu.org, control@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 15898 15841 thanks > Date: Fri, 15 Nov 2013 10:25:16 -0500 > From: Barry OReilly > Cc: 15898@debbugs.gnu.org > > > This looks like another duplicate of 15841, but that would imply > > that your previous update was before revno 115033, which was > > committed quite some time ago. Can you tell if that was indeed so? > > That's correct, I updated from before revno 115033 to after it. Thanks. In that case, perhaps you, too, could try the patch I suggested there just a few minutes ago. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 15 13:05:53 2013 Received: (at 15841) by debbugs.gnu.org; 15 Nov 2013 18:05:53 +0000 Received: from localhost ([127.0.0.1]:56195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhNmC-0002V4-RT for submit@debbugs.gnu.org; Fri, 15 Nov 2013 13:05:53 -0500 Received: from mout.gmx.net ([212.227.15.19]:54274) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhNm9-0002Un-Tv for 15841@debbugs.gnu.org; Fri, 15 Nov 2013 13:05:51 -0500 Received: from rosalinde.fritz.box ([89.245.123.210]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MFu0Y-1Vsusi45DS-00Evfr for <15841@debbugs.gnu.org>; Fri, 15 Nov 2013 19:05:43 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> <87mwla6inw.fsf@rosalinde.fritz.box> <83txfh1t0b.fsf@gnu.org> <838uwpipz6.fsf@gnu.org> Date: Fri, 15 Nov 2013 19:05:42 +0100 In-Reply-To: <838uwpipz6.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 15 Nov 2013 18:34:05 +0200") Message-ID: <8738mxmtft.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:yTuO7A855uQtnnkZDVGtFbkf7pn1Ey8i5PDHnSc/6n8clOm4BVS v89V6h4PYqEjYWMXNSk1Jmh8KDSPjDsiNNb6jMXc1f8t5ec41zaSbY4j8MGYSSI89KnELKp duTJnn+G1ZVB3gfZ2Xh8KNt0HGVn3B2+xgfZCOQ+JyBa9hScA8eOOSP4kvW6A1ZQy4Eje5d grCRv1Aa0I5jQoGPnlrLQ== X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Fri, 15 Nov 2013 18:34:05 +0200 Eli Zaretskii wrote: >> Date: Tue, 12 Nov 2013 18:31:32 +0200 >> From: Eli Zaretskii >> Cc: 15841@debbugs.gnu.org >> >> In any case, I already traced through the code that is involved, and >> the immediate reason for the assertion violation is that the cache >> isn't being updated wrt changes in buffer size (which are caused by >> decoding the stuff brought in by 'ls'). However, a naive attempt to >> force such updates didn't solve the whole problem: the aborts are >> gone, but the infloop is still there, and also other minor display >> issues. So I guess there's another factor at work there... > > I think I might have found a solution for this. Could you please run > with the patch below for a while, and see if it gives good results? Initial tests succeeded: `i' in Dired works as expected and there is no infloop or display oddities. I'll report back if any problems crop up on further use. Otherwise, thanks for fixing this! Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 13:54:29 2013 Received: (at submit) by debbugs.gnu.org; 16 Nov 2013 18:54:29 +0000 Received: from localhost ([127.0.0.1]:57445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhl0l-0007EK-Qt for submit@debbugs.gnu.org; Sat, 16 Nov 2013 13:54:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:56500) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhl0j-0007E0-Go for submit@debbugs.gnu.org; Sat, 16 Nov 2013 13:54:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhl0X-000673-H1 for submit@debbugs.gnu.org; Sat, 16 Nov 2013 13:54:20 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhl0X-00066D-4f for submit@debbugs.gnu.org; Sat, 16 Nov 2013 13:54:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58186) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhl0R-0008Fb-0C for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 13:54:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vhl0L-0005oc-5W for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 13:54:06 -0500 Received: from plane.gmane.org ([80.91.229.3]:50620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vhl0K-0005oN-Ug for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 13:54:01 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Vhl09-0002DM-7w for bug-gnu-emacs@gnu.org; Sat, 16 Nov 2013 19:53:49 +0100 Received: from 82-69-64-228.dsl.in-addr.zen.co.uk ([82.69.64.228]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 Nov 2013 19:53:49 +0100 Received: from andrewjmoreton by 82-69-64-228.dsl.in-addr.zen.co.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 Nov 2013 19:53:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Andy Moreton Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil Date: Sat, 16 Nov 2013 18:53:31 +0000 Lines: 21 Message-ID: <82habc6uvo.fsf@gmail.com> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> <87mwla6inw.fsf@rosalinde.fritz.box> <83txfh1t0b.fsf@gnu.org> <838uwpipz6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 82-69-64-228.dsl.in-addr.zen.co.uk User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (windows-nt) Cancel-Lock: sha1:DO4775E0omFEDPyGLrGqE0KyyyA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) On Fri 15 Nov 2013, Eli Zaretskii wrote: >> Date: Tue, 12 Nov 2013 18:31:32 +0200 >> From: Eli Zaretskii >> Cc: 15841@debbugs.gnu.org >> >> In any case, I already traced through the code that is involved, and >> the immediate reason for the assertion violation is that the cache >> isn't being updated wrt changes in buffer size (which are caused by >> decoding the stuff brought in by 'ls'). However, a naive attempt to >> force such updates didn't solve the whole problem: the aborts are >> gone, but the infloop is still there, and also other minor display >> issues. So I guess there's another factor at work there... > > I think I might have found a solution for this. Could you please run > with the patch below for a while, and see if it gives good results? Thanks Eli - I've seen the same problem with inserting a subdirectory in a dired buffer. Applying your patch to r115122 fixed dired for me. AndyM From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 14:03:00 2013 Received: (at 15841) by debbugs.gnu.org; 16 Nov 2013 19:03:00 +0000 Received: from localhost ([127.0.0.1]:57455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhl91-0007Sl-Rt for submit@debbugs.gnu.org; Sat, 16 Nov 2013 14:03:00 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:59255) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vhl8y-0007SU-If for 15841@debbugs.gnu.org; Sat, 16 Nov 2013 14:02:57 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MWD00500DY40700@a-mtaout23.012.net.il> for 15841@debbugs.gnu.org; Sat, 16 Nov 2013 21:02:49 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MWD004X2E8OY260@a-mtaout23.012.net.il>; Sat, 16 Nov 2013 21:02:49 +0200 (IST) Date: Sat, 16 Nov 2013 21:02:38 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <82habc6uvo.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: Andy Moreton Message-id: <83habcgofl.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> <87mwla6inw.fsf@rosalinde.fritz.box> <83txfh1t0b.fsf@gnu.org> <838uwpipz6.fsf@gnu.org> <82habc6uvo.fsf@gmail.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841 Cc: 15841@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Andy Moreton > Date: Sat, 16 Nov 2013 18:53:31 +0000 > > Thanks Eli - I've seen the same problem with inserting a subdirectory in > a dired buffer. Applying your patch to r115122 fixed dired for me. Thanks for trying. I will wait till Monday, to see if no adverse effects pop up, then commit those changes. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 16 14:12:41 2013 Received: (at control) by debbugs.gnu.org; 16 Nov 2013 19:12:41 +0000 Received: from localhost ([127.0.0.1]:57467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhlIO-0007iy-V4 for submit@debbugs.gnu.org; Sat, 16 Nov 2013 14:12:41 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:55282 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VhlIM-0007iq-UF for control@debbugs.gnu.org; Sat, 16 Nov 2013 14:12:39 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VhlIM-0000dv-El for control@debbugs.gnu.org; Sat, 16 Nov 2013 14:12:38 -0500 Date: Sat, 16 Nov 2013 14:12:38 -0500 Message-Id: Subject: control message for bug 15901 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) merge 15841 15901 From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 18 11:32:22 2013 Received: (at 15841-done) by debbugs.gnu.org; 18 Nov 2013 16:32:22 +0000 Received: from localhost ([127.0.0.1]:60257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViRkL-0005R2-Ow for submit@debbugs.gnu.org; Mon, 18 Nov 2013 11:32:22 -0500 Received: from mtaout23.012.net.il ([80.179.55.175]:39384) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ViRkH-0005Qo-Pb for 15841-done@debbugs.gnu.org; Mon, 18 Nov 2013 11:32:19 -0500 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MWG00D00WK24K00@a-mtaout23.012.net.il> for 15841-done@debbugs.gnu.org; Mon, 18 Nov 2013 18:32:11 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MWG00CSNWLMZQB0@a-mtaout23.012.net.il>; Mon, 18 Nov 2013 18:32:11 +0200 (IST) Date: Mon, 18 Nov 2013 18:32:05 +0200 From: Eli Zaretskii Subject: Re: bug#15841: Display bugs with cache-long-lines non-nil In-reply-to: <82habc6uvo.fsf@gmail.com> X-012-Sender: halo1@inter.net.il To: Andy Moreton , Stephen Berman Message-id: <83zjp1fz7e.fsf@gnu.org> References: <871u2xf9st.fsf@gmail.com> <9jiow9uhoa.fsf@fencepost.gnu.org> <87wqkopylw.fsf@gmail.com> <87bo20fh3h.fsf@web.de> <834n7q95d5.fsf@gnu.org> <87r4aqww3j.fsf@nbtrap.com> <83r4aq3s4r.fsf@gnu.org> <87fvr3ni2o.fsf@rosalinde.fritz.box> <877gceo3n9.fsf@rosalinde.fritz.box> <87mwla6inw.fsf@rosalinde.fritz.box> <83txfh1t0b.fsf@gnu.org> <838uwpipz6.fsf@gnu.org> <82habc6uvo.fsf@gmail.com> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15841-done Cc: 15841-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stephen Berman > Cc: 15841@debbugs.gnu.org > Date: Fri, 15 Nov 2013 19:05:42 +0100 > > Initial tests succeeded: `i' in Dired works as expected and there is no > infloop or display oddities. I'll report back if any problems crop up > on further use. Otherwise, thanks for fixing this! No further problems, so I committed the changes as trunk revision 115138, and I'm closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 20 13:34:21 2013 Received: (at control) by debbugs.gnu.org; 20 Nov 2013 18:34:21 +0000 Received: from localhost ([127.0.0.1]:35042 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjCbV-00070V-It for submit@debbugs.gnu.org; Wed, 20 Nov 2013 13:34:21 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:45174 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VjCbU-00070N-3X for control@debbugs.gnu.org; Wed, 20 Nov 2013 13:34:20 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VjCbT-0007OI-MQ for control@debbugs.gnu.org; Wed, 20 Nov 2013 13:34:19 -0500 Date: Wed, 20 Nov 2013 13:34:19 -0500 Message-Id: Subject: control message for bug 15930 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) forcemerge 15841 15930 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 21 16:31:41 2013 Received: (at control) by debbugs.gnu.org; 21 Nov 2013 21:31:41 +0000 Received: from localhost ([127.0.0.1]:37512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vjbqe-0001LH-NY for submit@debbugs.gnu.org; Thu, 21 Nov 2013 16:31:40 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:48213 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vjbqc-0001L9-TQ for control@debbugs.gnu.org; Thu, 21 Nov 2013 16:31:39 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vjbqc-0004ug-Ew for control@debbugs.gnu.org; Thu, 21 Nov 2013 16:31:38 -0500 Date: Thu, 21 Nov 2013 16:31:38 -0500 Message-Id: Subject: control message for bug 15948 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) forcemerge 15898 15948 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 22 02:11:28 2013 Received: (at control) by debbugs.gnu.org; 22 Nov 2013 07:11:28 +0000 Received: from localhost ([127.0.0.1]:37869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vjktj-0000JU-Rg for submit@debbugs.gnu.org; Fri, 22 Nov 2013 02:11:28 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:59667 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vjkth-0000JL-KI for control@debbugs.gnu.org; Fri, 22 Nov 2013 02:11:25 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vjkth-0000r5-Ab for control@debbugs.gnu.org; Fri, 22 Nov 2013 02:11:25 -0500 Date: Fri, 22 Nov 2013 02:11:25 -0500 Message-Id: Subject: control message for bug 15952 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) forcemerge 15898 15952 From unknown Sat Jun 14 18:01:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Dec 2013 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator