From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 18:17:12 2013 Received: (at submit) by debbugs.gnu.org; 8 Nov 2013 23:17:12 +0000 Received: from localhost ([127.0.0.1]:42819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VevIe-0002W2-14 for submit@debbugs.gnu.org; Fri, 08 Nov 2013 18:17:12 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54408) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VevIb-0002Vn-Ao for submit@debbugs.gnu.org; Fri, 08 Nov 2013 18:17:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VevEe-00016Z-Dw for submit@debbugs.gnu.org; Fri, 08 Nov 2013 18:17:04 -0500 Received: from lists.gnu.org ([2001:4830:134:3::11]:46764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VevEe-00016Q-B2 for submit@debbugs.gnu.org; Fri, 08 Nov 2013 18:13:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VevDa-00025b-75 for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2013 18:13:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vev4h-0005uP-BX for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2013 18:06:53 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:35106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vev4h-0005uJ-4k for bug-gnu-emacs@gnu.org; Fri, 08 Nov 2013 18:02:47 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rA8N2iIr015887 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 8 Nov 2013 23:02:45 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA8N2ikn012882 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 8 Nov 2013 23:02:44 GMT Received: from abhmt103.oracle.com (abhmt103.oracle.com [141.146.116.55]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA8N2hO5002516 for ; Fri, 8 Nov 2013 23:02:43 GMT MIME-Version: 1.0 Message-ID: <51df60b6-e152-4989-a27e-70dadb9b7474@default> Date: Fri, 8 Nov 2013 15:02:42 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. Non-nil `isearch-allow-scroll' lets you use a scroll command (e.g. `C-v') without exiting Isearch. Unfortunately, this is coupled with the hard-coded behavior that you cannot scroll far enough in either direction that point would be moved off screen. That restriction is general for Emacs, and it generally makes sense. It does not necessarily make sense during Isearch, however. Why? Because the search position is one thing, and it is not lost. What you might want to look at temporarily is another thing. It's a bit like using `C-SPC' in a buffer, scrolling up a couple of screenfuls to look at something, and then using `C-u C-SPC' to return. But in Isearch there is no need for `C-SPC' or `C-u C-SPC': the search position is recorded. Search resumes from that same position, no matter how far away one might have scrolled. The enhancement request is to let users choose whether non-nil `isearch-allow-scroll' should limit you to scrolling only enough to keep point in the window or should not limit you. This could be done by recognizing different non-nil values. 2. What's more, the lazy highlighting of search hits is even more limited currently. When you scroll to the current limit, there can be lots of search hits that are not highlighted. One of the reasons for scrolling is to see what search hits lie beyond the currently shown text. This is already partly defeated, in that even when you scroll some of the hits are not highlighted. This seems more like a bug, but if the enhancement of #1 is done then it should (it needs to) take care of #2 as well: Whatever text is shown should have all of its search hits highlighted with lazy highlighting. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-10-19 on LEG570 Bzr revision: 114715 rgm@gnu.org-20131019023520-s8mwtib7xcx9e05w Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1' From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 20:00:13 2013 Received: (at 15839) by debbugs.gnu.org; 9 Nov 2013 01:00:14 +0000 Received: from localhost ([127.0.0.1]:42955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VewuK-0005AH-Md for submit@debbugs.gnu.org; Fri, 08 Nov 2013 20:00:13 -0500 Received: from ps18281.dreamhost.com ([69.163.218.105]:46861 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VewuG-0005A7-To for 15839@debbugs.gnu.org; Fri, 08 Nov 2013 20:00:10 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 3ED22258B9E935; Fri, 8 Nov 2013 17:00:06 -0800 (PST) From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: JURTA References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> Date: Sat, 09 Nov 2013 02:57:23 +0200 In-Reply-To: <51df60b6-e152-4989-a27e-70dadb9b7474@default> (Drew Adams's message of "Fri, 8 Nov 2013 15:02:42 -0800 (PST)") Message-ID: <878uwyo0i4.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > 1. Non-nil `isearch-allow-scroll' lets you use a scroll command > (e.g. `C-v') without exiting Isearch. Unfortunately, this is coupled > with the hard-coded behavior that you cannot scroll far enough in either > direction that point would be moved off screen. You can do what you want with just: (advice-add 'isearch-post-command-hook :override (lambda ())) And if you want more commands to escape this restriction: (mapc (lambda (c) (put c 'isearch-scroll t)) '(forward-char backward-char right-char left-char forward-word backward-word right-word left-word forward-sexp backward-sexp forward-paragraph backward-paragraph move-end-of-line end-of-visual-line move-beginning-of-line beginning-of-visual-line next-line previous-line)) > That restriction is general for Emacs, and it generally makes sense. > It does not necessarily make sense during Isearch, however. Why? Because it is too confusing for users. This is like leaving point in one place, and scrolling without changing the position of point (with inactive Isearch). Isearch should not be different from the default Emacs behavior. > It's a bit like using `C-SPC' in a buffer, scrolling up a couple of > screenfuls to look at something, and then using `C-u C-SPC' to return. > But in Isearch there is no need for `C-SPC' or `C-u C-SPC': the search > position is recorded. Search resumes from that same position, no > matter how far away one might have scrolled. It makes sense to resume search from a new position like you can see using code above. > The enhancement request is to let users choose whether non-nil > `isearch-allow-scroll' should limit you to scrolling only enough to keep > point in the window or should not limit you. This could be done by > recognizing different non-nil values. Maybe a new option of `isearch-allow-scroll' could allow this. > 2. What's more, the lazy highlighting of search hits is even more > limited currently. When you scroll to the current limit, there can be > lots of search hits that are not highlighted. When scrolling outside the window boundaries will be allowed then lazy highlighting should highlight the whole buffer so you could see all matches when you quickly scroll the buffer. But in this case lazy highlighting will become more like hi-lock mode. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 22:10:08 2013 Received: (at 15839) by debbugs.gnu.org; 9 Nov 2013 03:10:08 +0000 Received: from localhost ([127.0.0.1]:43205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Veyw2-0008Tp-VQ for submit@debbugs.gnu.org; Fri, 08 Nov 2013 22:10:08 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:17209) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Veyvy-0008TB-Hp for 15839@debbugs.gnu.org; Fri, 08 Nov 2013 22:10:03 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rA939t4E024516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 9 Nov 2013 03:09:56 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA939tjN002851 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 9 Nov 2013 03:09:55 GMT Received: from abhmt103.oracle.com (abhmt103.oracle.com [141.146.116.55]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rA939sQR002842; Sat, 9 Nov 2013 03:09:54 GMT MIME-Version: 1.0 Message-ID: <2827fd34-4736-4583-a964-5bab51b6b2f1@default> Date: Fri, 8 Nov 2013 19:09:54 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <878uwyo0i4.fsf@mail.jurta.org> In-Reply-To: <878uwyo0i4.fsf@mail.jurta.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > 1. Non-nil `isearch-allow-scroll' lets you use a scroll command > > (e.g. `C-v') without exiting Isearch. Unfortunately, this is > > coupled with the hard-coded behavior that you cannot scroll far > > enough in either direction that point would be moved off screen. >=20 > You can do what you want with just: > (advice-add 'isearch-post-command-hook :override (lambda ())) Good to know that. But see also the bug(s) mentioned below. Such advice will not suffice currently, for the reasons given there. There is neither the proper management of point nor the proper lazy highlighting of the scrolled area. But anyway, I am not looking for a way for an individual user to advise the code - in this case, dynamically neutering the post-command scrolling limitation code. That's not the point (besides not being very elegant). I am asking for a way for users to customize an option, namely the already existing option `isearch-allow-scroll'. I am asking for two scroll-allowing behaviors, giving users an easy choice. > And if you want more commands to escape this restriction: > (mapc (lambda (c) (put c 'isearch-scroll t)) > '(forward-char backward-char right-char left-char > forward-word backward-word right-word left-word > forward-sexp backward-sexp forward-paragraph backward- > paragraph > move-end-of-line end-of-visual-line move-beginning-of-line > beginning-of-visual-line next-line previous-line)) I'm not asking how to define additional scrolling commands. The problem is not insufficient commands that can scroll. The problem is the limitation of what the scrolling behavior is. > > That restriction is general for Emacs, and it generally makes > > sense. It does not necessarily make sense during Isearch, > > however. Why? Note the question (which I answered): Why does this restriction, which generally makes sense for general Emacs, NOT necessarily make sense for Isearch. Is this your answer to that question (?): > Because it is too confusing for users. This is like leaving point > in one place, and scrolling without changing the position of point > (with inactive Isearch). Isearch should not be different from the > default Emacs behavior. I gave a reason why it should be different. Or rather, why it should be allowed to be different (au choix). You gave no reason - you just repeated that it should be the same. At most, you gave the same reason as for Emacs in general, which I explained is not so relevant here. That is, it is not cut & dried. Some users can well prefer to be able to see more context, for the reasons I gave. And that is not so confusing as it is for general Emacs, for the reasons I gave - in particular, resumption from the same search position, with attendent automatic window return to that position. In Emacs in general, if scrolling moved beyond point, and if there were nothing that brought the window back to point when you acted at point (e.g., when finished temporarily scrolling) then you would not see what was happening at point. That would not be good at all, under any circumstances. But even in Emacs in general, if there were such an thing as=20 temporary scrolling, with a well defined finish, and if the window were then automatically restored to show point, which *did not change* by scrolling, that too would not be so confusing. We do not have such a temporary-scrolling behavior in Emacs in general, however. You cannot reasonably compare general Emacs, without any such temporary scrolling and window restoration, with what I proposed for Isearch. Apples & oranges. > > It's a bit like using `C-SPC' in a buffer, scrolling up a couple > > of screenfuls to look at something, and then using `C-u C-SPC' > > to return. But in Isearch there is no need for `C-SPC' or > > `C-u C-SPC': the search position is recorded. Search resumes > > from that same position, no matter how far away one might have > > scrolled. >=20 > It makes sense to resume search from a new position like you can > see using code above. I think you are suggesting that the search position should change when you make use of the temporary scrolling? If so, I strongly disagree. >From my point of view, the current search hit (i.e., point) does not change now, and it should never change, when you scroll. The only thing that would change with my proposal is what is shown in the window. The scrolling would be temporary, and when search is resumed the window would be restored to where it will show the current search hit again. What should happen if, after scrolling, a user quits Isearch? For that case we have a design choice: either move point to somewhere inside where the window is currently (scrolled), or move the window back to show the current search hit, i.e., point (which has not changed). I would be in favor of the latter. I think the former possibility would be problematic. Move point to which position in the window, for instance? I'm open to suggestions about that. But a priori, I would suggest that in all cases when scrolling is done during Isearch the window be restored to show the current search hit. I feel more strongly about resumption of search after scrolling: it should definitely continue where it was. I think (less strongly) that if search is quit after scrolling then the behavior should be the same as quitting at the current search position. > > The enhancement request is to let users choose whether non-nil > > `isearch-allow-scroll' should limit you to scrolling only enough > > to keep point in the window or should not limit you. This could > > be done by recognizing different non-nil values. >=20 > Maybe a new option of `isearch-allow-scroll' could allow this. That's exactly what I suggested. Non-nil always means allow scrolling, and the particular non-nil value would specify the scrolling behavior: limited or not. But see above and below about what unlimited scrolling behavior should be like (highlighting, and no change in point). =20 > > 2. What's more, the lazy highlighting of search hits is even more > > limited currently. When you scroll to the current limit, there > > can be lots of search hits that are not highlighted. >=20 > When scrolling outside the window boundaries will be allowed then > lazy highlighting should highlight the whole buffer so you could see > all matches when you quickly scroll the buffer. But in this case > lazy highlighting will become more like hi-lock mode. I cannot speak to the implementation - whether it is better to highlight the whole buffer or just the part that is currently visible. I would imagine that the latter is better, especially for large buffers. But I'm no expert on the implementation of Isearch. I can say that without the continuation of lazy highlighting into the scrolled area (e.g., what happens with your advice, above), there is little use to scrolling. The point of scrolling is, especially, to see search hits farther down or up the buffer. 3. I just noticed the following problem (emacs -Q). I can file a separate bug report for it, if you prefer. a. Set `isearch-allow-scroll' to t. b. Go to the middle of a long (multi-screenful) buffer, such as isearch.el. c. Search for something common, such as "ear". d. `C-v' a couple times, until you hit the limit. e. `M-v' repeatedly. There is no such limit in this direction. Why not? There should be. Not really consistent for the user. f. `C-v'. The entire window fills with face `isearch' (which should be only for `ear' search hits). Both (e) - its difference from (d) - and (f) seem like bugs to me. With my request (#1), both `C-v' and `M-v' would allow unlimited scrolling. And the current search position would not change by scrolling. It seems that currently `M-v' (past what should be the limit) changes the search position. Whether that's a third bug - call it (g) or is part of the (e) behavior I don't know. And that is also the behavior for `C-v' when I advise the post-command hook as you suggested: point is kept in the window, instead of staying at the current search hit. Isearch behavior should always be that point remains at the current search hit. IMO, when scrolling is restricted, that restriction should apply to both `C-v' and `M-v', and the search position should not change. When scrolling is not restricted (request #1), that non-restriction should apply to both `C-v' and `M-v', and the search position should (still) not change. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 08:46:59 2013 Received: (at 15839) by debbugs.gnu.org; 10 Nov 2013 13:46:59 +0000 Received: from localhost ([127.0.0.1]:45406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfVLv-0003Ss-3c for submit@debbugs.gnu.org; Sun, 10 Nov 2013 08:46:59 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:47083) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfVLr-0003Sc-OS for 15839@debbugs.gnu.org; Sun, 10 Nov 2013 08:46:56 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+LrM/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLY0ZAYNwA4hhnBmBXoMVgUgBHwQ X-IPAS-Result: Av8EABK/CFHO+LrM/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLY0ZAYNwA4hhnBmBXoMVgUgBHwQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37502887" Received: from 206-248-186-204.dsl.teksavvy.com (HELO pastel.home) ([206.248.186.204]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Nov 2013 08:46:48 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5A64C60630; Sun, 10 Nov 2013 08:46:47 -0500 (EST) From: Stefan Monnier To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Message-ID: References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> Date: Sun, 10 Nov 2013 08:46:47 -0500 In-Reply-To: <51df60b6-e152-4989-a27e-70dadb9b7474@default> (Drew Adams's message of "Fri, 8 Nov 2013 15:02:42 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > That restriction is general for Emacs, and it generally makes sense. It makes sense, but it would also be desirable to make it customizable. > It does not necessarily make sense during Isearch, however. Why? To some extent I can see that it is slightly different in the Isearch context. I'm not sure if it is sufficiently different to justify changing the default in Isearch, but I'm not necessarily opposed to it either. IOW, I agree with both feature requests. > 2. What's more, the lazy highlighting of search hits is even more > limited currently. When you scroll to the current limit, there can be > lots of search hits that are not highlighted. Yes, that's a bug. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 11:52:10 2013 Received: (at 15839) by debbugs.gnu.org; 10 Nov 2013 16:52:10 +0000 Received: from localhost ([127.0.0.1]:45725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfYF7-0007t8-73 for submit@debbugs.gnu.org; Sun, 10 Nov 2013 11:52:09 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:45889) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfYF5-0007sm-PQ for 15839@debbugs.gnu.org; Sun, 10 Nov 2013 11:52:08 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rAAGq16c029867 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 10 Nov 2013 16:52:01 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAAGpxXO014831 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 10 Nov 2013 16:51:59 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rAAGpwDP025120; Sun, 10 Nov 2013 16:51:58 GMT MIME-Version: 1.0 Message-ID: <00b78895-dc80-4dc1-9f0b-8f5485da6155@default> Date: Sun, 10 Nov 2013 08:52:00 -0800 (PST) From: Drew Adams To: Stefan Monnier Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > That restriction is general for Emacs, and it generally makes > > sense. >=20 > It makes sense, but it would also be desirable to make it > customizable. I agree. > > It does not necessarily make sense during Isearch, however. Why? >=20 > To some extent I can see that it is slightly different in the > Isearch context. I'm not sure if it is sufficiently different to > justify changing the default in Isearch, but I'm not necessarily > opposed to it either. No need to change the default. `isearch-allow-scroll' should default to nil (less confusing, probably). The only change for it would be to provide a special value, e.g., `unlimited', which would not impose a limit on how much you can scroll. (Scrolling beyond the current limit when the value is `unlimited' should lazy-highlight whatever is shown, and resuming search should resume from the search hit current before scrolling. IOW, scrolling should not change which search hit is current.) > IOW, I agree with both feature requests. Great. > > 2. What's more, the lazy highlighting of search hits is even more > > limited currently. When you scroll to the current limit, there > > can be lots of search hits that are not highlighted. >=20 > Yes, that's a bug. I don't see that all the time, BTW. I don't have a recipe to repro it. The more important bugs are these: a. Scrolling backwards is not limited currently (it should be unlimited only when the option value is `unlimited', i.e., after the requested enhancement). b. Forward scrolling after backward scrolling throws everything off currently: the highlighting that should apply only to the current search hit (face `isearch') is applied to the entire window (buffer?). Bug (b) is the most serious, but I'm guessing that (b) and (a) are due to the same code problem. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 11 14:08:57 2013 Received: (at 15839) by debbugs.gnu.org; 11 Nov 2013 19:08:57 +0000 Received: from localhost ([127.0.0.1]:47336 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vfwr3-0007U1-5c for submit@debbugs.gnu.org; Mon, 11 Nov 2013 14:08:57 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:16614) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vfwr0-0007Tl-CD for 15839@debbugs.gnu.org; Mon, 11 Nov 2013 14:08:54 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rABJ8l47030790 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Nov 2013 19:08:47 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rABJ8j8L023643 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Nov 2013 19:08:45 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rABJ8iBH023616; Mon, 11 Nov 2013 19:08:44 GMT MIME-Version: 1.0 Message-ID: <60b6139e-c202-4a49-b58b-4efd22ce365a@default> Date: Mon, 11 Nov 2013 11:08:43 -0800 (PST) From: Drew Adams To: Stefan Monnier Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <00b78895-dc80-4dc1-9f0b-8f5485da6155@default> In-Reply-To: <00b78895-dc80-4dc1-9f0b-8f5485da6155@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > The more important bugs are these: >=20 > a. Scrolling backwards is not limited currently (it should be > unlimited only when the option value is `unlimited', i.e., after the > requested enhancement). >=20 > b. Forward scrolling after backward scrolling throws everything off > currently: the highlighting that should apply only to the current > search hit (face `isearch') is applied to the entire window > (buffer?). >=20 > Bug (b) is the most serious, but I'm guessing that (b) and (a) are > due to the same code problem. (BTW, (b) is the case symmetrically: if you start searching backward and then scroll up (in the search direction) and then scroll down, you get the same extension of `isearch-overlay' across the whole window.) I've tried to look into (b) a bit. I tried adding some code that calls `isearch-dehighlight' during scrolling and `isearch-highlight' when finished scrolling, just to see. I added calls to `message' to print the value of `isearch-overlay' at various points. It turns out that (because of the call I added to dehighlight) the overlay is properly deleted (overlay in no buffer) but it is still showing. (And it extends across the window.) I tried adding (redisplay t), but that had no effect. So this is apparently a case where a deleted overlay is showing. What's a way to prevent this phenomenon? From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 24 18:00:26 2018 Received: (at 15839) by debbugs.gnu.org; 24 Nov 2018 23:00:26 +0000 Received: from localhost ([127.0.0.1]:45922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQguY-0006FF-08 for submit@debbugs.gnu.org; Sat, 24 Nov 2018 18:00:26 -0500 Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:35820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQguV-0006F4-6Z for 15839@debbugs.gnu.org; Sat, 24 Nov 2018 18:00:24 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E1D46123F93; Sat, 24 Nov 2018 23:00:20 +0000 (UTC) Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.33.121]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id EA6D3123DB8; Sat, 24 Nov 2018 23:00:13 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sat, 24 Nov 2018 23:00:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Wipe-Abaft: 0a16185b1684a1ef_1543100414069_3677068645 X-MC-Loop-Signature: 1543100414069:658967869 X-MC-Ingress-Time: 1543100414069 Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 5690980580; Sat, 24 Nov 2018 15:00:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=HfDJpXzNpvcFG2y3LhRbfKkRaiY=; b= cxLA/UXF0lcCudA7ls46NsnGV3+/idhkb1sVFBDP160cqUYgsIxdsBK7lRiVoKRS t34IbfziQR5eekJSLdRIrR5j2aUI+b3WxIKKsrLbcpGOz6oL2ctk4+3ggVLIxqpe wonuM5o6wsL9DSOZmMy2bCB4ZZFzOJEGJ8H2joRaDsI= Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 6B42580582; Sat, 24 Nov 2018 15:00:06 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> Date: Sun, 25 Nov 2018 00:45:20 +0200 In-Reply-To: <51df60b6-e152-4989-a27e-70dadb9b7474@default> (Drew Adams's message of "Fri, 8 Nov 2013 15:02:42 -0800 (PST)") Message-ID: <8736rqgk6f.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddufedgudeikecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtjedrvdegvdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdejrddvgedvpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughrvgifrdgruggrmhhssehorhgrtghlvgdrtghomhenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > 2. What's more, the lazy highlighting of search hits is even more > limited currently. When you scroll to the current limit, there can be > lots of search hits that are not highlighted. > > One of the reasons for scrolling is to see what search hits lie beyond > the currently shown text. This is already partly defeated, in that > even when you scroll some of the hits are not highlighted. This seems > more like a bug, but if the enhancement of #1 is done then it should > (it needs to) take care of #2 as well: Whatever text is shown should > have all of its search hits highlighted with lazy highlighting. Drew, do you agree that this your request is implemented now with lazy-highlight-buffer, so bug#15839 could be closed? From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 24 22:14:30 2018 Received: (at 15839) by debbugs.gnu.org; 25 Nov 2018 03:14:30 +0000 Received: from localhost ([127.0.0.1]:45978 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQksQ-0003mI-HF for submit@debbugs.gnu.org; Sat, 24 Nov 2018 22:14:30 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:50644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gQksO-0003m5-Ol for 15839@debbugs.gnu.org; Sat, 24 Nov 2018 22:14:29 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAP3EJnT036195; Sun, 25 Nov 2018 03:14:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=9OktFUrnceql8yPinmHLSAqt98E6bGxnMhFfKsa2RmI=; b=BYB2infRVtYs6hkqcBVroUvMv2Jt33HMNS8YKDYH0dx5oa6Ym3BciaWluqZfx7X9tylw CN3+uqL6EvLqG1FnOegCgAJK+OCr2wGgrEosVZGEvMSa/Kxhv7+HciQTSD+xBhBt4Czy Nfir6xRGo5Hv6W5FWu11w3k2bKhoJBSvTk8wrQpadvnaIv98dNpovRbTh1/FfqAC4ERi pwHjSF13KqFxcutfM/9r6HVsHW31tR2RvpynVfbPk28A03yT80QYoFdoD7opWVSvnGh2 DnC3f6t8uf1oWKTz1QOHGsxRFdrwbkaLjrMzC8K6F/VfjEQI8+26hfAuwsHaCIouq39z SA== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2nxxkq1hhd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Nov 2018 03:14:21 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wAP3EJ8I018167 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Nov 2018 03:14:20 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAP3EI5n005832; Sun, 25 Nov 2018 03:14:18 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 24 Nov 2018 19:14:17 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> In-Reply-To: <8736rqgk6f.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9087 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811250029 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > 2. What's more, the lazy highlighting of search hits is even more > > limited currently. When you scroll to the current limit, there can be > > lots of search hits that are not highlighted. > > > > One of the reasons for scrolling is to see what search hits lie beyond > > the currently shown text. This is already partly defeated, in that > > even when you scroll some of the hits are not highlighted. This seems > > more like a bug, but if the enhancement of #1 is done then it should > > (it needs to) take care of #2 as well: Whatever text is shown should > > have all of its search hits highlighted with lazy highlighting. >=20 > Drew, do you agree that this your request is implemented now > with lazy-highlight-buffer, so bug#15839 could be closed? Not as far as I understand. That #2 is only one point (one part) of several making up the bug report. If scrolling forward and backward always shows all search hits lazy-highlighted, then that one part of the bug would seem to be fixed. But that fixed behavior is (needs to be) anyway independent of any customization of `lazy-highlight-buffer'. So no, the addition of option `lazy-highlight-buffer' in no way fixes this bug. Perhaps some infrastructure that has been added now provides for a way to fix part of this bug - dunno. By that I mean only that now Isearch has ways of highlighting more than just a windowful of the buffer. Dunno whether that is helpful here. And as I said in the bug report, even for this one part of it (all visible search hits are not necessarily lazy-highlighted), the lazy-highlighting needed for scrolling could be limited to what is actually made visible by scrolling - not the whole buffer. Dunno whether that is a good optimization to make or not. What counts is the user perspective: scrolling should show all hits highlighted, no matter how far you scroll and no matter which directions. And to get that behavior a user should not need to change option `lazy-highlight-buffer'. That option should have no effect on this behavior, and vice versa. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 25 16:09:57 2018 Received: (at 15839) by debbugs.gnu.org; 25 Nov 2018 21:09:58 +0000 Received: from localhost ([127.0.0.1]:47649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gR1fB-0008QG-EM for submit@debbugs.gnu.org; Sun, 25 Nov 2018 16:09:57 -0500 Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:12936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gR1f9-0008Q7-Jh for 15839@debbugs.gnu.org; Sun, 25 Nov 2018 16:09:56 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 19A4D5C48D2; Sun, 25 Nov 2018 21:09:54 +0000 (UTC) Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id CA2E85C48D9; Sun, 25 Nov 2018 21:09:53 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sun, 25 Nov 2018 21:09:54 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Squirrel-Keen: 74ff7f8114779688_1543180193910_2771350707 X-MC-Loop-Signature: 1543180193909:3454608008 X-MC-Ingress-Time: 1543180193909 Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 91C9481057; Sun, 25 Nov 2018 13:09:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=DnI8+gX3buicryKPY3DcwG475U4=; b= p/2+L+NZ2c3Nqz2PMTBgq7LA1BH+MzHlV0nrOo+xp5MbfxI5m7oOOFq1Y7s+SR6f fui9zBltMT17q5H3iUm8XupKh24M1PnPCd4yjgifvi6KTdoPKv9t7Vg7qYxEFPqL EkzEBbeTHOtIXO5FPWxnp3BsSl39ZwCKwCMJh5clOII= Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 4238E81054; Sun, 25 Nov 2018 13:09:51 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> Date: Sun, 25 Nov 2018 22:15:23 +0200 In-Reply-To: (Drew Adams's message of "Sat, 24 Nov 2018 19:14:17 -0800 (PST)") Message-ID: <87y39gexdo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudduhedgudeglecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtjedrvdegvdenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdejrddvgedvpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughrvgifrdgruggrmhhssehorhgrtghlvgdrtghomhenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > What counts is the user perspective: scrolling should show all > hits highlighted, no matter how far you scroll and no matter > which directions. And to get that behavior a user should not > need to change option `lazy-highlight-buffer'. That option > should have no effect on this behavior, and vice versa. The first part of your request is already implemented as well: you can customize `search-exit-option' to the value `nil' (its tag text is "Don't terminate incremental search"), then it works exactly like you want. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 25 19:17:00 2018 Received: (at 15839) by debbugs.gnu.org; 26 Nov 2018 00:17:00 +0000 Received: from localhost ([127.0.0.1]:47722 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gR4aC-0004YH-8w for submit@debbugs.gnu.org; Sun, 25 Nov 2018 19:17:00 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:47620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gR4aB-0004Y5-6O for 15839@debbugs.gnu.org; Sun, 25 Nov 2018 19:16:59 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAQ0FFQw157263; Mon, 26 Nov 2018 00:16:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=F9tIWTJt16GUzPhoOTXTKYepN7IVkt0qEaBuDeRFT3g=; b=P7jO2wfiWBXdpHm20OsWnzVmfB+MFd4inmpbPVlxqXRdjVIwKkZaIz2aKEpAjjiuEW6p ft9JR+mYAMbS+5waW+ypKO2BUaQYWJJTxeMdPmosFXLmgPyUbP1GjUxMMftFnw/J4Qdh aJRuF4VqIivyEHoDfcQ2zHde3zrGoztdVosQfM2Ty0SpJrvRN/R8vHKNFb3zA4Rea/uv f9aV53b7/Wdgihg10fVGg/fcr9nHAQ5GJwuFEiN3+awpKXyizLz4zsN2t7RzrPMmMAln W6Iq6tV5n2vQtbza6EMA4hEbLRkMpC0/iA/5IJ3n5C3wd9DP2rd+ZNQ+Y6VRdvdRezH8 /Q== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2120.oracle.com with ESMTP id 2nxxkq2xr8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Nov 2018 00:16:53 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAQ0GqRl029920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Nov 2018 00:16:52 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wAQ0GpH1007685; Mon, 26 Nov 2018 00:16:51 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 25 Nov 2018 16:16:50 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> In-Reply-To: <87y39gexdo.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9088 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=899 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811260000 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > What counts is the user perspective: scrolling should show all > > hits highlighted, no matter how far you scroll and no matter > > which directions. And to get that behavior a user should not > > need to change option `lazy-highlight-buffer'. That option > > should have no effect on this behavior, and vice versa. >=20 > The first part of your request is already implemented as well: > you can customize `search-exit-option' to the value `nil' > (its tag text is "Don't terminate incremental search"), > then it works exactly like you want. Sorry, but I don't really understand. There are several parts to this bug report. I don't know what "the first part" refers to. I don't want to have to customize anything (other than a new specific `isearch-allow-scroll' value) to work around the problem. In the Emacs release I have (26.1) there is no such value for `search-exit-option'. And it's not clear to me why I would want to change the value of this option. (I don't even understand the (Emacs 26) doc string of the option: "Non-nil means random control characters terminate incremental search." Random control characters? I think I described the problem pretty clearly. I don't find your description of the solution (or solutions, to parts apparently) clear. What I mean is I don't understand the proposed solution(s), to start with. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 26 19:38:43 2018 Received: (at 15839) by debbugs.gnu.org; 27 Nov 2018 00:38:43 +0000 Received: from localhost ([127.0.0.1]:50242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRROl-0000NE-49 for submit@debbugs.gnu.org; Mon, 26 Nov 2018 19:38:43 -0500 Received: from otter.birch.relay.mailchannels.net ([23.83.209.139]:10802) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRROh-0000N4-Ae for 15839@debbugs.gnu.org; Mon, 26 Nov 2018 19:38:39 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 292DB5C346D; Tue, 27 Nov 2018 00:38:38 +0000 (UTC) Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id D44C85C3403; Tue, 27 Nov 2018 00:38:37 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 27 Nov 2018 00:38:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Hook-Squirrel: 45eaa7320903d66d_1543279117960_414177007 X-MC-Loop-Signature: 1543279117960:1455931430 X-MC-Ingress-Time: 1543279117959 Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 9E986807FD; Mon, 26 Nov 2018 16:38:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=KboLWZbOpxwPEcsDuxzv3hi2wkQ=; b= QTD19nCV1MyDtioo2kfowtMF4IXXQ2YlMTUuRoFzbC+RqGDmAu8dKB39UJE9cMp2 c8KKLF+Uk9ES6fbz8mjWSd+htyQKh4Jug+3UjWOUTGx+04sJgHYHT6YXdfa2F3dn KWDQU0jjSLgDJpXEeVmcFNuNeDWQqL3al1fpTXPFQNY= Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 06E1080801; Mon, 26 Nov 2018 16:38:35 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> Date: Tue, 27 Nov 2018 01:35:31 +0200 In-Reply-To: (Drew Adams's message of "Sun, 25 Nov 2018 16:16:50 -0800 (PST)") Message-ID: <877egzmmyk.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddukedgvdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdegvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgepvd X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Sorry, but I don't really understand. > > There are several parts to this bug report. I don't know > what "the first part" refers to. It refers to your original request cited below: > 1. Non-nil `isearch-allow-scroll' lets you use a scroll command > (e.g. `C-v') without exiting Isearch. Unfortunately, this is coupled > with the hard-coded behavior that you cannot scroll far enough in either > direction that point would be moved off screen. > > That restriction is general for Emacs, and it generally makes sense. > It does not necessarily make sense during Isearch, however. Why? > > Because the search position is one thing, and it is not lost. What you > might want to look at temporarily is another thing. > > It's a bit like using `C-SPC' in a buffer, scrolling up a couple of > screenfuls to look at something, and then using `C-u C-SPC' to return. > But in Isearch there is no need for `C-SPC' or `C-u C-SPC': the search > position is recorded. Search resumes from that same position, no > matter how far away one might have scrolled. This is implemented now with an option `nil' of the customizable variable `search-exit-option'. It lets you use a scroll command (e.g. `C-v') without exiting Isearch, so you can scroll far enough in either direction that point would be moved off screen. > 2. What's more, the lazy highlighting of search hits is even more > limited currently. When you scroll to the current limit, there can be > lots of search hits that are not highlighted. > > One of the reasons for scrolling is to see what search hits lie beyond > the currently shown text. This is already partly defeated, in that > even when you scroll some of the hits are not highlighted. This seems > more like a bug, but if the enhancement of #1 is done then it should > (it needs to) take care of #2 as well: Whatever text is shown should > have all of its search hits highlighted with lazy highlighting. This is implemented now with the customizable variable `lazy-highlight-buffer'. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 26 19:49:32 2018 Received: (at 15839) by debbugs.gnu.org; 27 Nov 2018 00:49:32 +0000 Received: from localhost ([127.0.0.1]:50264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRRZE-0000eF-GB for submit@debbugs.gnu.org; Mon, 26 Nov 2018 19:49:32 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:42062) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRRZC-0000e2-6d for 15839@debbugs.gnu.org; Mon, 26 Nov 2018 19:49:30 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAR0n4ja152451; Tue, 27 Nov 2018 00:49:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=YvMHFWlTx9C43CVmFMEGxv2KKLP5A95QWKW0f9Zn/hQ=; b=pyW5pMiCkFjz1PuimaHrP+r50SFehluaewjAhcQc8UumPlVVoCW3EAFSLOgzOji/VNYo DWUoyCRqAkGukisyMnt5xgptDdbOo3Kztd5G/TCKRXfOLGr78xext8ZU2aF+JfyX52cG 1QEfEVi/rwISozDaHM52csHvrEp4fMNLk5/3Sq4PmppY82ZdWS4HzsZzP49Jh3sr0qDp ZWLD1ILeEk+7aRPk0oaunwtBdDabhFpOBI9FBNgCaxL7gZ2IvEa2A9dzZjyKhjCKHafs UsPGQjKH6x054shFH/UMPC644xc5h3kQBuftd5kQeefv+69BJGLL2CNr1zL9tK93Cnje sA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2nxx2u12gk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Nov 2018 00:49:24 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wAR0nNDB016688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Nov 2018 00:49:23 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wAR0nMAO017653; Tue, 27 Nov 2018 00:49:22 GMT MIME-Version: 1.0 Message-ID: <8af20443-841d-4211-99ae-269e042a9a33@default> Date: Mon, 26 Nov 2018 16:49:21 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> In-Reply-To: <877egzmmyk.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9089 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811270004 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > Sorry, but I don't really understand. > > > > There are several parts to this bug report. I don't know > > what "the first part" refers to. >=20 > It refers to your original request cited below: Thanks for clarifying what you meant. But those points 1,2,... in the bug report are not independent. They are meant to make a logical argument for what's being requested. They are all of a piece. They describe different, but related, aspects of the inconvenience that the requested feature would alleviate. I don't want to customize one variable to be able to scroll farther, and another variable to have what's shown by that scrolling have lazy-highlighting (especially if the latter requires lazy-highlighting the entire buffer, rather than just what I see when scrolling). I want to be able to use `isearch-allow-scroll' to let me scroll as far as I want, and see search hits lazy-highlighted in what parts of the buffer I scroll to. > > 1. Non-nil `isearch-allow-scroll' lets you use a scroll command > > (e.g. `C-v') without exiting Isearch. Unfortunately, this is coupled > > with the hard-coded behavior that you cannot scroll far enough in > > either direction that point would be moved off screen. > > > > That restriction is general for Emacs, and it generally makes sense. > > It does not necessarily make sense during Isearch, however. Why? > > > > Because the search position is one thing, and it is not lost. What > > you might want to look at temporarily is another thing. > > > > It's a bit like using `C-SPC' in a buffer, scrolling up a couple of > > screenfuls to look at something, and then using `C-u C-SPC' to > > return. But in Isearch there is no need for `C-SPC' or `C-u C-SPC': > > the search position is recorded. Search resumes from that same > > position, no matter how far away one might have scrolled. >=20 > This is implemented now with an option `nil' of the customizable > variable `search-exit-option'. It lets you use a scroll command > (e.g. `C-v') without exiting Isearch, so you can scroll far enough > in either direction that point would be moved off screen. >=20 > > 2. What's more, the lazy highlighting of search hits is even more > > limited currently. When you scroll to the current limit, there can > > be lots of search hits that are not highlighted. > > > > One of the reasons for scrolling is to see what search hits lie > > beyond the currently shown text. This is already partly defeated, > > in that even when you scroll some of the hits are not highlighted. > > This seems more like a bug, but if the enhancement of #1 is done > > then it should (it needs to) take care of #2 as well: Whatever > > text is shown should have all of its search hits highlighted with > > lazy highlighting. >=20 > This is implemented now with the customizable variable > `lazy-highlight-buffer'. I do appreciate your letting me know what's newly available; thanks. And thanks for making those improvements. But no, I don't think we have what I requested, and I don't think this bug (enhancement request) should be closed. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 27 19:45:49 2018 Received: (at 15839) by debbugs.gnu.org; 28 Nov 2018 00:45:49 +0000 Received: from localhost ([127.0.0.1]:52647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRnzB-0002nP-KP for submit@debbugs.gnu.org; Tue, 27 Nov 2018 19:45:49 -0500 Received: from purple.birch.relay.mailchannels.net ([23.83.209.150]:35370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gRnzA-0002nA-AA for 15839@debbugs.gnu.org; Tue, 27 Nov 2018 19:45:48 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D8C66502A9A; Wed, 28 Nov 2018 00:45:46 +0000 (UTC) Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.20.98]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8A4FA502935; Wed, 28 Nov 2018 00:45:46 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 28 Nov 2018 00:45:46 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Plucky-Hook: 1f02d0d12573390d_1543365946700_3339434012 X-MC-Loop-Signature: 1543365946700:444537766 X-MC-Ingress-Time: 1543365946699 Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 569B480924; Tue, 27 Nov 2018 16:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Z60tNESlJcsQr/9F4yuqQ1yuFj0=; b= qfVJOOrTr/0CnjP5UV+cKeYUVEurfDONp5awBh1C1Z8va1+ci3X0r4+xwWi/8bVQ +i4AWCXjMLA3dbXLRGNTTyr075K0fnoSYZ7bP8lW3Rf+UC+v0hm7Ogv7IMcF8yzN AdNQ9N7iJC19y3gY0atNEMk7eApriS8YkRcbpRZpjHc= Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 299428091F; Tue, 27 Nov 2018 16:45:44 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> Date: Wed, 28 Nov 2018 02:35:53 +0200 In-Reply-To: <8af20443-841d-4211-99ae-269e042a9a33@default> (Drew Adams's message of "Mon, 26 Nov 2018 16:49:21 -0800 (PST)") Message-ID: <875zwidonq.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddvtddgvdejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdegvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgephe X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I don't want to customize one variable to be able to > scroll farther, and another variable to have what's > shown by that scrolling have lazy-highlighting > (especially if the latter requires lazy-highlighting > the entire buffer, rather than just what I see when > scrolling). Fine. If you are lazy to customize two variables, after you customize one variable we could automatically change the value of the second variable. > I want to be able to use `isearch-allow-scroll' to > let me scroll as far as I want, and see search hits > lazy-highlighted in what parts of the buffer I > scroll to. Fine, we could allow the same feature to be enabled by two different variables. diff --git a/lisp/isearch.el b/lisp/isearch.el index eb0b25f9b1..ac809e4980 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2747,8 +2747,15 @@ isearch-allow-scroll "Whether scrolling is allowed during incremental search. If non-nil, scrolling commands can be used in Isearch mode. However, the current match will never scroll offscreen. +If `unlimited', the current match can scroll offscreen. +This has the same effect as the value `nil' of `search-exit-option'. If nil, scrolling commands will first cancel Isearch mode." - :type 'boolean + :type '(choice boolean + (const :tag "Can scroll offscreen" unlimited)) + :set (lambda (sym val) + (set sym val) + (when (eq val 'unlimited) + (setq lazy-highlight-buffer t))) :group 'isearch) (defcustom isearch-allow-prefix t @@ -2841,11 +2848,11 @@ isearch-pre-command-hook ((or (and isearch-allow-prefix (memq this-command '(universal-argument universal-argument-more digit-argument negative-argument))) - (and isearch-allow-scroll + (and isearch-allow-scroll (not (eq isearch-allow-scroll 'unlimited)) (symbolp this-command) (or (eq (get this-command 'isearch-scroll) t) (eq (get this-command 'scroll-command) t)))) - (when isearch-allow-scroll + (when (and isearch-allow-scroll (not (eq isearch-allow-scroll 'unlimited))) (setq isearch-pre-scroll-point (point)))) ;; A mouse click on the isearch message starts editing the search string. ((and (eq (car-safe main-event) 'down-mouse-1) @@ -2853,6 +2860,7 @@ isearch-pre-command-hook ;; Swallow the up-event. (read-event) (setq this-command 'isearch-edit-string)) + ((eq isearch-allow-scroll 'unlimited)) ;; Don't terminate the search for motion commands. ((or (and (eq search-exit-option 'move) (symbolp this-command) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 28 10:15:21 2018 Received: (at 15839) by debbugs.gnu.org; 28 Nov 2018 15:15:21 +0000 Received: from localhost ([127.0.0.1]:53657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gS1Ye-0000QO-Ny for submit@debbugs.gnu.org; Wed, 28 Nov 2018 10:15:21 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:51322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gS1Yd-0000Q8-36 for 15839@debbugs.gnu.org; Wed, 28 Nov 2018 10:15:19 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wASFD379139058; Wed, 28 Nov 2018 15:15:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=G8VQpO/R7hRM2s25bVTqxoiA+GW4V5shBttg0yIESVk=; b=ATvCe3Zjr5vZqelGTQoJ25pXQU++oJhTF0FDLhw+BY4jOtFT2VSmm4tzZnnMBKHvpgSd vl/tqNf5I+lnj/4EeIiDbu5N6Xu9rzFAd9s/NIkm4WyNDQylYwP1VTTUOLjlNCajUPFt ajkYHSwqPcPSP/ElYfr9YowV8aZDmAMDETfNLh83Zb5XI0FlQuPikDWam6mNX/cS5xjE DO+YwQ8C4txBzzN+UC9+e3LQ6mR3iyq9pkRf6/84FhCKa4Z4FprIb+hS9gK3TH/wEVu9 uqQepRJKB0Z3OQutGdFNdbNhIM2PIqdwRv7lW49SMy4qEhgsm4/7eaP/8hYmZWnerRwc CQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp2120.oracle.com with ESMTP id 2nxy9rares-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Nov 2018 15:15:13 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wASFFCUv014928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Nov 2018 15:15:12 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wASFFBl8014788; Wed, 28 Nov 2018 15:15:11 GMT MIME-Version: 1.0 Message-ID: <178ca8ac-fb45-4cef-a48d-d916a60860be@default> Date: Wed, 28 Nov 2018 07:15:11 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> In-Reply-To: <875zwidonq.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9090 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811280134 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > I don't want to customize one variable to be able to > > scroll farther, and another variable to have what's > > shown by that scrolling have lazy-highlighting > > (especially if the latter requires lazy-highlighting > > the entire buffer, rather than just what I see when > > scrolling). >=20 > Fine. If you are lazy to customize two variables, > after you customize one variable we could automatically > change the value of the second variable. That was not my point. First is a question: Would customizing those two variables in that way affect ONLY the specific behavior I requested? I don't expect so. But even if the answer to that question is yes, it's not clear from the descriptions of those variables that that behavior follows as the only, specific behavior. If you implement code that does what I requested, providing a single place for users to control it (which should logically be `isearch-allow-scroll', I think) - and that controls only it (does not affect some other behavior) that will be great. (Maybe you've done that - if you say so then I'll take a closer look.) IOW, how that implementation gets done under the covers is not so important to a user. If it's best that it somehow make use of existing code - even existing user options, that's OK. It's not clear to me that the purpose of those two variables is to realize the feature requested here. Is it, really? But users should preferably not need to worry about variable interactions. The doc for a given variable should make clear just what it does, and each variable should preferably have one behavior (per value chosen). You should not, e.g., discover that by choosing a var value to make a background red you have also inadvertently turned off the ability to have blue foreground text. > > I want to be able to use `isearch-allow-scroll' to > > let me scroll as far as I want, and see search hits > > lazy-highlighted in what parts of the buffer I > > scroll to. >=20 > Fine, we could allow the same feature to be enabled > by two different variables. >=20 > @@ -2747,8 +2747,15 @@ isearch-allow-scroll > "Whether scrolling is allowed during incremental search. > If non-nil, scrolling commands can be used in Isearch mode. > However, the current match will never scroll offscreen. > +If `unlimited', the current match can scroll offscreen. Those last two sentences should be rephrased in the usual manner: `unlimited' means... Any other non-nil value means...=20 > +This has the same effect as the value `nil' > of `search-exit-option'. Does it really? If that's the only effect of `search-exit-option' then yes, we don't need a separate option. But if that were true then why did `search-exit-option' exist previously, and why didn't it do this previously? And why was it called `search...' and not `isearch...'? I'm guessing that nil `search-exit-option' does not just have "the same effect". But (see above) even if it does, that doesn't mean that option `search-exit-option' has the same effect, because setting it to non-nil, ONLY to NOT have the effect of `unlimited' `isearch-allow-scroll', would presumably also have some other effect unrelated to allowing scrolling. Sorry that I'm arguing from ignorance here so far, and not bothering to get informed in detail about these existing options. I'm essentially guessing that trying to repurpose some combination of them to achieve this request is not a great idea. If I'm wrong, please try to present the counter argument straightforwardly. I'm open to being convinced, but a first sense is that this is likely not the right approach. If you just tell me I'm wrong then I'll take a closer look at what you're proposing. But first please consider what I say here, in case it's valid. > If nil, scrolling commands will first cancel > Isearch mode." BTW, why do we say "first" there? First before what? There is no other action after this, is there? I.e., there is no "second" or "and" that follows this "first", right? Or is there some additional context that makes that "first" mean something? Thanks for working on this. Let me know, if you think I'm wrong and should just take a closer look at what you've proposed. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 28 18:53:46 2018 Received: (at 15839) by debbugs.gnu.org; 28 Nov 2018 23:53:46 +0000 Received: from localhost ([127.0.0.1]:53904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gS9eL-0003yQ-L4 for submit@debbugs.gnu.org; Wed, 28 Nov 2018 18:53:45 -0500 Received: from ostrich.birch.relay.mailchannels.net ([23.83.209.138]:30223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gS9eI-0003yH-Sb for 15839@debbugs.gnu.org; Wed, 28 Nov 2018 18:53:43 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 59C741231C0; Wed, 28 Nov 2018 23:53:41 +0000 (UTC) Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.19.74]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0DB20123A13; Wed, 28 Nov 2018 23:53:41 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Wed, 28 Nov 2018 23:53:41 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Glossy-Befitting: 3a71bc7e4ff5a721_1543449221193_1451276577 X-MC-Loop-Signature: 1543449221192:3536446828 X-MC-Ingress-Time: 1543449221192 Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 473E680A2D; Wed, 28 Nov 2018 15:53:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=90p33M3VJsdN9g+7NuAwbRMaALk=; b= ny7u0FclTEL5ZLFWbmybQaBcZgi3nBTEH0/8VvjauGHFaIfiWRlIaniJhHe7ktSe yWLetFXeOSHbOmaxJdsXInzihg7VUJczTdVrkx16317F/4Q6vsfA0HzROGobq6D4 lHGIEVvlZrJ7AF+sxpectU+Ax1rJkN/AkdD1BHGCoYI= Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id CAE1980A22; Wed, 28 Nov 2018 15:53:38 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> Date: Thu, 29 Nov 2018 01:01:00 +0200 In-Reply-To: <178ca8ac-fb45-4cef-a48d-d916a60860be@default> (Drew Adams's message of "Wed, 28 Nov 2018 07:15:11 -0800 (PST)") Message-ID: <87a7lsu7rn.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddvvddgudejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdegvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > But users should preferably not need to worry > about variable interactions. The doc for a given > variable should make clear just what it does, and > each variable should preferably have one behavior > (per value chosen). I agree that it's better to make it clear in the docstring. Fixed in a new patch below. > I'm guessing that nil `search-exit-option' does > not just have "the same effect". But (see above) > even if it does, that doesn't mean that option > `search-exit-option' has the same effect, because > setting it to non-nil, ONLY to NOT have the > effect of `unlimited' `isearch-allow-scroll', > would presumably also have some other effect > unrelated to allowing scrolling. I agree that `search-exit-option' is too confusing variable for such features. So we have to offload it from all unrelated features. As the first step, I moved the recently added shift-select feature from `search-exit-option' to its own clearly named customizable variable `isearch-allow-shift-select'. For the same reason, unlimited scrolling was moved to the new option `unlimited' of `isearch-allow-scroll'. Now finally everything looks right. Please try a new patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=isearch-allow-scroll-offscreen.2.patch diff --git a/lisp/isearch.el b/lisp/isearch.el index eb0b25f9b1..8c54ab92db 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -72,21 +72,11 @@ search-exit-option If t, random control and meta characters terminate the search and are then executed normally. If `edit', edit the search string instead of exiting. -If `move', extend the search string by motion commands -that have the `isearch-move' property on their symbols -equal to `enabled', or the shift-translated command is -not disabled by the value `disabled' of the same property. -If `shift-move', extend the search string by motion commands -while holding down the shift key. -Both `move' and `shift-move' extend the search string by yanking text -that ends at the new position after moving point in the current buffer. If `append', the characters which you type that are not interpreted by the incremental search are simply appended to the search string. If nil, run the command without exiting Isearch." :type '(choice (const :tag "Terminate incremental search" t) (const :tag "Edit the search string" edit) - (const :tag "Extend the search string by motion commands" move) - (const :tag "Extend the search string by shifted motion keys" shift-move) (const :tag "Append control characters to the search string" append) (const :tag "Don't terminate incremental search" nil)) :version "27.1") @@ -2747,8 +2737,12 @@ isearch-allow-scroll "Whether scrolling is allowed during incremental search. If non-nil, scrolling commands can be used in Isearch mode. However, the current match will never scroll offscreen. +If `unlimited', the current match can scroll offscreen. +You may want to enable `lazy-highlight-buffer' as well. If nil, scrolling commands will first cancel Isearch mode." - :type 'boolean + :type '(choice (const :tag "Disable scrolling" nil) + (const :tag "Allow scrolling within screen" t) + (const :tag "Allow scrolling offscreen" unlimited)) :group 'isearch) (defcustom isearch-allow-prefix t @@ -2812,6 +2806,21 @@ isearch-back-into-window (defvar isearch-pre-scroll-point nil) (defvar isearch-pre-move-point nil) +(defcustom isearch-allow-shift-select nil + "Whether motion is allowed to select text during incremental search. +If t, extend the search string by motion commands while holding down +the shift key. The search string is extended by yanking text that +ends at the new position after moving point in the current buffer. +If `move', extend the search string without the shift key pressed +by motion commands that have the `isearch-move' property on their +symbols equal to `enabled', or the shift-translated command is +not disabled by the value `disabled' of the same property." + :type '(choice (const :tag "Disable shift selection" nil) + (const :tag "Shifted motion keys extend the search string" t) + (const :tag "Motion keys extend the search string" move)) + :group 'isearch + :version "27.1") + (defun isearch-pre-command-hook () "Decide whether to exit Isearch mode before executing the command. Don't exit Isearch if the key sequence that invoked this command @@ -2845,7 +2854,7 @@ isearch-pre-command-hook (symbolp this-command) (or (eq (get this-command 'isearch-scroll) t) (eq (get this-command 'scroll-command) t)))) - (when isearch-allow-scroll + (when (and isearch-allow-scroll (not (eq isearch-allow-scroll 'unlimited))) (setq isearch-pre-scroll-point (point)))) ;; A mouse click on the isearch message starts editing the search string. ((and (eq (car-safe main-event) 'down-mouse-1) @@ -2854,13 +2863,13 @@ isearch-pre-command-hook (read-event) (setq this-command 'isearch-edit-string)) ;; Don't terminate the search for motion commands. - ((or (and (eq search-exit-option 'move) + ((or (and (eq isearch-allow-shift-select 'move) (symbolp this-command) (or (eq (get this-command 'isearch-move) 'enabled) (and (not (eq (get this-command 'isearch-move) 'disabled)) (stringp (nth 1 (interactive-form this-command))) (string-match-p "^^" (nth 1 (interactive-form this-command)))))) - (and (eq search-exit-option 'shift-move) + (and isearch-allow-shift-select (not (eq isearch-allow-shift-select 'move)) this-command-keys-shift-translated)) (setq this-command-keys-shift-translated nil) (setq isearch-pre-move-point (point))) @@ -2883,7 +2892,7 @@ isearch-post-command-hook (goto-char isearch-pre-scroll-point))) (setq isearch-pre-scroll-point nil) (isearch-update)) - ((memq search-exit-option '(move shift-move)) + (isearch-allow-shift-select (when (and isearch-pre-move-point (not (eq isearch-pre-move-point (point)))) (let ((string (buffer-substring-no-properties --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 28 22:36:37 2018 Received: (at 15839) by debbugs.gnu.org; 29 Nov 2018 03:36:37 +0000 Received: from localhost ([127.0.0.1]:53980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSD81-0000n9-0c for submit@debbugs.gnu.org; Wed, 28 Nov 2018 22:36:37 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:52022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSD7z-0000mw-6w for 15839@debbugs.gnu.org; Wed, 28 Nov 2018 22:36:35 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAT3YXeY123846; Thu, 29 Nov 2018 03:36:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=eZeGIzii7vCKny6szre1jDIaEOi73hu96+4geZK+IWU=; b=rjw4joX3qIvlLW3LgW2pCk1eODWoaxb8GQkiJ8fsSpUm4D7BVuxVzgkYlpzSx6BUtE3x naaocycVYFdeSzF6KvJ//xSUaZQ8AN1+dE3fzN+zYOIr3Pqw2tkC43z616j0NS8j3UMa WFNDdqzgw9aj+01OG0/pAFKpFos3F3Dd0wjIeS1lS1vswv+fOWLBYtFu4dg9kNYJEtGQ AfKOGykOaOqbPApqWMUvpGV4S2RtpHZDzoMjgRkCTrj5w4FKPeSn1jPZtFXDhGcMuIHK B9PC28zjoYHPHWdHdLM/TfqND8I+Q2ho8N22r5MwDLv9G34VdlrNX8kcJJzI8K/sqdRu hg== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2nxxkqnt6y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Nov 2018 03:36:29 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wAT3aSkj022987 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Nov 2018 03:36:28 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wAT3aRqB016005; Thu, 29 Nov 2018 03:36:27 GMT MIME-Version: 1.0 Message-ID: <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> Date: Wed, 28 Nov 2018 19:36:26 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> In-Reply-To: <87a7lsu7rn.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9091 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811290028 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > But users should preferably not need to worry > > about variable interactions. The doc for a given > > variable should make clear just what it does, and > > each variable should preferably have one behavior > > (per value chosen). >=20 > I agree that it's better to make it clear in the docstring. > Fixed in a new patch below. >=20 > > I'm guessing that nil `search-exit-option' does > > not just have "the same effect". But (see above) > > even if it does, that doesn't mean that option > > `search-exit-option' has the same effect, because > > setting it to non-nil, ONLY to NOT have the > > effect of `unlimited' `isearch-allow-scroll', > > would presumably also have some other effect > > unrelated to allowing scrolling. >=20 > I agree that `search-exit-option' is too confusing variable > for such features. So we have to offload it from all > unrelated features. >=20 > As the first step, I moved the recently added shift-select > feature from `search-exit-option' to its own clearly named > customizable variable `isearch-allow-shift-select'. >=20 > For the same reason, unlimited scrolling was moved to the new option > `unlimited' of `isearch-allow-scroll'. >=20 > Now finally everything looks right. Please try a new patch: I agree with your summary here, that is, I think we're in agreement. I didn't try to apply your patch, but I took a quick look at it. Here are some questions/comments, in case they help. 1. I'm still puzzled about this: However, the current match will never scroll offscreen. If `unlimited', the current match can scroll offscreen. Those two sentences don't make sense together. If the current match never scrolls offscreen then it can't be true that the current match can scroll offscreen. Something different needs to be said here. 2. And the term "offscreen" doesn't seem like a good choice. Don't we mean just off the window, i.e., out of view? So this too bothers/confuses me: "Allow scrolling within screen" I don't know what is meant by "screen" here. What are the limits of the "screen" within which I can scroll with this option value? 3. I'm also puzzled by this: You may want to enable `lazy-highlight-buffer' as well. Why say that? I think it confuses people, by suggesting that for some reason you might need to do that, in order to see such highlighting if you scroll (e.g. "offscreen"). That's not the case, is it? (I hope not.) I thought that the implementation of `unlimited' automatically lazy-highlights everything that you scroll to. Is that not the case? That's part of this enhancement request: scroll as far as you want, and have search hits highlighted no matter how far you scroll. If that highlighting-as-needed is implemented then I see no need to mention `lazy-highlight-buffer', and I think it's wrong to do so. There should be no more need to enable full-buffer highlighting in the `unlimited' scroll case than in any other case. You enable `lazy-highlight-buffer' when you want to ensure that all search hits are highlighted, even ones you may never look at. If `unlimited' does NOT highlight all hits that come in view then this enhancement request is still not realized, as that's a necessary part of it. 4. I think it would be better for the :tag "Disable scrolling" to say something like this: "Scrolling exits Isearch". It's not that you cannot scroll. It's just that if you do scroll you stop searching. You could say "Disable scrolling while searching", if you prefer to keep the parallel structure of the :tags. 5. Doc string of `*-allow-shift-selection': Whether motion is allowed to select text during incremental search. That will possibly make users think that this is about activating the region (selecting text). The first doc-string line should kind of stand on its own, to give an overall idea. I'd say something more like this: Motion keys yank text to the search string. 6. `*-allow-shift-selection' behavior: Why is the value `move'? Is that the best word? What happens with `move' if you use a shifted motion key? If it acts the same as `t' then what you call "shifted" is really "-only_ when shifted". What you call just "motion" seems like just both shifted and unshifted. Why do we even have two such choices? Why would someone who wants to yank chars by moving over them want to have to use Shift, ever? Is it so that they can use unshifted to exit Isearch and move the cursor? I guess so. Maybe that could be made clearer (dunno). 7. OK, no, `move' is apparently more complicated than that (all the more reason why it shouldn't be called `move'.) This text is a mouthful: by motion commands that have the `isearch-move' property on their symbols equal to `enabled', or [for which] the shift-translated command is not disabled by the value `disabled' of the same property. That sounds a bit like a legal text. You can just repeat "property `isearch-move'" instead of saying "the same property" - that would be clearer. But the sentence probably needs to be split. And it may be a sign that the behavior is too complicated. Why do we have this complicated behavior? Why not just have a `move' value that lets you yank text without having to use Shift (i.e. using Shift or not)? What's the point of having to put such a property on some command symbols? And if there really is a use case for doing that to certain commands, so that _only they_ manifest a difference between `t' and `move' behavior, then why not have only the `move' behavior (no `t' behavior)? I really don't understand the motivations here, sorry. What problem is this option trying to solve? 8.This option should not be called `*-shift-selection' if it is not necessarily about Shift selection. The option is apparently about yanking text you move the cursor over. 9. Again, I'm not crazy about this :tag, for the same reason as above: Disable shift selection A nil option value doesn't disable anything. It just means that cursor motion ends Isearch, so you just move over the buffer text. I apologize in advance for not following some of this. Probably at least some of what I wrote is nonsense based on misunderstanding. At the very least, though, perhaps some of that misunderstanding might indicate that some of the descriptions, or some of the behaviors, are more complicated than necessary. Hope this helps, and thanks for all your work on this stuff. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 17:55:20 2018 Received: (at 15839) by debbugs.gnu.org; 29 Nov 2018 22:55:20 +0000 Received: from localhost ([127.0.0.1]:55261 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSVDL-0008Es-NG for submit@debbugs.gnu.org; Thu, 29 Nov 2018 17:55:20 -0500 Received: from goldenrod.birch.relay.mailchannels.net ([23.83.209.74]:2881) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSVDJ-0008Ei-F2 for 15839@debbugs.gnu.org; Thu, 29 Nov 2018 17:55:18 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id D2442124666; Thu, 29 Nov 2018 22:55:15 +0000 (UTC) Received: from pdx1-sub0-mail-a3.g.dreamhost.com (unknown [100.96.11.179]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 7D1411219C4; Thu, 29 Nov 2018 22:55:15 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a3.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Thu, 29 Nov 2018 22:55:15 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Chemical-Squirrel: 6174a2ba69c4b6f7_1543532115712_3524181244 X-MC-Loop-Signature: 1543532115711:3802910377 X-MC-Ingress-Time: 1543532115711 Received: from pdx1-sub0-mail-a3.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTP id 419B27F6BB; Thu, 29 Nov 2018 14:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=lI+fjHAFCRKe156R3D8IIFbWzuI=; b= yIdrONK4PP3IMFZ97bno30VWrW9Bfs9lg9kZxZ5x1AUJtCqv/fNBp1QSCadmjRnT As0dy7hh1ddzVuzyjzh+3wHLri2oWPv3u6hnx5JkS4YW6odDG8btJBpf3d6tDLvQ AkcakM2o+g0iI2eqyBUGv+Krj2SmvivkTbWUQr9AEww= Received: from mail.jurta.org (m91-129-107-242.cust.tele2.ee [91.129.107.242]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a3.g.dreamhost.com (Postfix) with ESMTPSA id 745F57F6CD; Thu, 29 Nov 2018 14:55:12 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a3 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> Date: Fri, 30 Nov 2018 00:23:38 +0200 In-Reply-To: <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> (Drew Adams's message of "Wed, 28 Nov 2018 19:36:26 -0800 (PST)") Message-ID: <875zwfed5h.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedruddvgedgtdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdejrddvgedvnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtjedrvdegvddprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain > 1. I'm still puzzled about this: > > However, the current match will never scroll offscreen. > If `unlimited', the current match can scroll offscreen. > > Those two sentences don't make sense together. > If the current match never scrolls offscreen then > it can't be true that the current match can scroll > offscreen. Something different needs to be said > here. Do you think this is better? "If non-nil, scrolling commands can be used in Isearch mode. However, the current match can't scroll offscreen if the value is t. But if it's `unlimited', the current match can scroll offscreen. You may want to enable `lazy-highlight-buffer' in this case. If nil, scrolling commands will cancel Isearch mode." If you don't agree, please suggest a better wording. > 2. And the term "offscreen" doesn't seem like a > good choice. Don't we mean just off the window, > i.e., out of view? So this too bothers/confuses me: > > "Allow scrolling within screen" > > I don't know what is meant by "screen" here. > What are the limits of the "screen" within > which I can scroll with this option value? I guess a screen is part of the buffer visible in the window. We use the word "screen" in other docstrings as well. > 3. I'm also puzzled by this: > > You may want to enable `lazy-highlight-buffer' > as well. > > Why say that? I think it confuses people, by > suggesting that for some reason you might need > to do that, in order to see such highlighting > if you scroll (e.g. "offscreen"). > > That's not the case, is it? (I hope not.) I > thought that the implementation of `unlimited' > automatically lazy-highlights everything that > you scroll to. Is that not the case? No, this is not the case. This is very difficult to implement, and not worth the effort because this feature is already available by customizing lazy-highlight-buffer. Moreover, even if implemented, it still makes no sense because it can't highlight as quick as you scroll thru the buffer. The problem is that you haven't tried my patch with lazy-highlight-buffer enabled. If you tried you wouldn't want any other implementation. > 4. I think it would be better for the :tag > "Disable scrolling" to say something like this: > "Scrolling exits Isearch". Thanks, fixed. > 5. Doc string of `*-allow-shift-selection': > > Whether motion is allowed to select text during > incremental search. > > That will possibly make users think that this is > about activating the region (selecting text). > > The first doc-string line should kind of stand on > its own, to give an overall idea. I'd say > something more like this: > > Motion keys yank text to the search string. Thanks, fixed. > 6. `*-allow-shift-selection' behavior: > > Why is the value `move'? Is that the best word? > > What happens with `move' if you use a shifted > motion key? If it acts the same as `t' then what > you call "shifted" is really "-only_ when shifted". > What you call just "motion" seems like just both > shifted and unshifted. > > Why do we even have two such choices? Why would > someone who wants to yank chars by moving over > them want to have to use Shift, ever? Is it so > that they can use unshifted to exit Isearch and > move the cursor? I guess so. Maybe that could > be made clearer (dunno). > > 7. OK, no, `move' is apparently more complicated > than that (all the more reason why it shouldn't > be called `move'.) This text is a mouthful: > > by motion commands that have the `isearch-move' > property on their symbols equal to `enabled', > or [for which] the shift-translated command is > not disabled by the value `disabled' of the same > property. > > That sounds a bit like a legal text. You can just > repeat "property `isearch-move'" instead of saying > "the same property" - that would be clearer. But > the sentence probably needs to be split. And it > may be a sign that the behavior is too complicated. > > Why do we have this complicated behavior? Why > not just have a `move' value that lets you yank > text without having to use Shift (i.e. using Shift > or not)? What's the point of having to put such a > property on some command symbols? > > And if there really is a use case for doing that > to certain commands, so that _only they_ manifest > a difference between `t' and `move' behavior, > then why not have only the `move' behavior (no `t' > behavior)? Sorry, I don't understand what do you suggest here. > 8.This option should not be called `*-shift-selection' > if it is not necessarily about Shift selection. > The option is apparently about yanking text you > move the cursor over. So I renamed it to `isearch-allow-yank-on-move', and its options to `no-shift' and `shift'. > 9. Again, I'm not crazy about this :tag, for the > same reason as above: > > Disable shift selection > > A nil option value doesn't disable anything. It > just means that cursor motion ends Isearch, so you > just move over the buffer text. Thanks for the suggestion, I changed it to "Motion keys exits Isearch". --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=isearch-allow-scroll-offscreen.3.patch diff --git a/lisp/isearch.el b/lisp/isearch.el index eb0b25f9b1..b0284a5972 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -72,21 +72,11 @@ search-exit-option If t, random control and meta characters terminate the search and are then executed normally. If `edit', edit the search string instead of exiting. -If `move', extend the search string by motion commands -that have the `isearch-move' property on their symbols -equal to `enabled', or the shift-translated command is -not disabled by the value `disabled' of the same property. -If `shift-move', extend the search string by motion commands -while holding down the shift key. -Both `move' and `shift-move' extend the search string by yanking text -that ends at the new position after moving point in the current buffer. If `append', the characters which you type that are not interpreted by the incremental search are simply appended to the search string. If nil, run the command without exiting Isearch." :type '(choice (const :tag "Terminate incremental search" t) (const :tag "Edit the search string" edit) - (const :tag "Extend the search string by motion commands" move) - (const :tag "Extend the search string by shifted motion keys" shift-move) (const :tag "Append control characters to the search string" append) (const :tag "Don't terminate incremental search" nil)) :version "27.1") @@ -2746,9 +2736,13 @@ isearch-fallback (defcustom isearch-allow-scroll nil "Whether scrolling is allowed during incremental search. If non-nil, scrolling commands can be used in Isearch mode. -However, the current match will never scroll offscreen. -If nil, scrolling commands will first cancel Isearch mode." - :type 'boolean +However, the current match can't scroll offscreen if the value is t. +But if it's `unlimited', the current match can scroll offscreen. +You may want to enable `lazy-highlight-buffer' in this case. +If nil, scrolling commands will cancel Isearch mode." + :type '(choice (const :tag "Scrolling exits Isearch" nil) + (const :tag "Allow scrolling within screen" t) + (const :tag "Allow scrolling offscreen" unlimited)) :group 'isearch) (defcustom isearch-allow-prefix t @@ -2812,6 +2806,21 @@ isearch-back-into-window (defvar isearch-pre-scroll-point nil) (defvar isearch-pre-move-point nil) +(defcustom isearch-allow-yank-on-move nil + "Motion keys yank text to the search string. +If t, extend the search string by motion commands while holding down +the shift key. The search string is extended by yanking text that +ends at the new position after moving point in the current buffer. +If `move', extend the search string without the shift key pressed +by motion commands that have the `isearch-move' property on their +symbols equal to `enabled', or for which the shift-translated command +is not disabled by the value `disabled' of property `isearch-move'." + :type '(choice (const :tag "Motion keys exits Isearch" nil) + (const :tag "Motion keys extend the search string" no-shift) + (const :tag "Shifted motion keys extend the search string" shift)) + :group 'isearch + :version "27.1") + (defun isearch-pre-command-hook () "Decide whether to exit Isearch mode before executing the command. Don't exit Isearch if the key sequence that invoked this command @@ -2845,7 +2854,7 @@ isearch-pre-command-hook (symbolp this-command) (or (eq (get this-command 'isearch-scroll) t) (eq (get this-command 'scroll-command) t)))) - (when isearch-allow-scroll + (when (and isearch-allow-scroll (not (eq isearch-allow-scroll 'unlimited))) (setq isearch-pre-scroll-point (point)))) ;; A mouse click on the isearch message starts editing the search string. ((and (eq (car-safe main-event) 'down-mouse-1) @@ -2854,13 +2863,13 @@ isearch-pre-command-hook (read-event) (setq this-command 'isearch-edit-string)) ;; Don't terminate the search for motion commands. - ((or (and (eq search-exit-option 'move) + ((or (and (eq isearch-allow-yank-on-move 'no-shift) (symbolp this-command) (or (eq (get this-command 'isearch-move) 'enabled) (and (not (eq (get this-command 'isearch-move) 'disabled)) (stringp (nth 1 (interactive-form this-command))) (string-match-p "^^" (nth 1 (interactive-form this-command)))))) - (and (eq search-exit-option 'shift-move) + (and (eq isearch-allow-yank-on-move 'shift) this-command-keys-shift-translated)) (setq this-command-keys-shift-translated nil) (setq isearch-pre-move-point (point))) @@ -2883,7 +2892,7 @@ isearch-post-command-hook (goto-char isearch-pre-scroll-point))) (setq isearch-pre-scroll-point nil) (isearch-update)) - ((memq search-exit-option '(move shift-move)) + (isearch-allow-yank-on-move (when (and isearch-pre-move-point (not (eq isearch-pre-move-point (point)))) (let ((string (buffer-substring-no-properties --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 29 19:27:24 2018 Received: (at 15839) by debbugs.gnu.org; 30 Nov 2018 00:27:24 +0000 Received: from localhost ([127.0.0.1]:55329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSWeS-0002OT-9B for submit@debbugs.gnu.org; Thu, 29 Nov 2018 19:27:24 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:32924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSWeQ-0002OC-Qy for 15839@debbugs.gnu.org; Thu, 29 Nov 2018 19:27:23 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAU0OXg1131644; Fri, 30 Nov 2018 00:27:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=Tyvpl1DT302BX6rkcNKy+EVsRUAYNXC3qhSxYIas6d4=; b=D5XaVipJNtkIBYEeia/YMWeicPAL54Rdlf7zhYqsxwGqX9wg6gz5hBg6QwIl3ocdaYJZ 1aWl6yVHuHDZjX/Wq7OYqqvz41qDS3vcMc0r2iwkqRy0xsrf6MFrgO/Oec0xegcHepZM zhGJCy+04KY9FwveDFaaO6L/bJBEVabywR6EYLzC5cSUD0Ewa1Yey9/yMgJ6nZFUauzs KZaxzizq37XLFpa6jV+9QSwUaOgBYwD7ajoshnJKl/S+VyLQczWOwqsoQRq0z3ULq/zd UwjJnTJsXNBDsZyoty6FuFuopXE5F5e+OAxrJhKy1biB/sxIXq0XTretEs2q6ttYyWUy BQ== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2120.oracle.com with ESMTP id 2nxxkquasy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Nov 2018 00:27:16 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wAU0RE45029192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Nov 2018 00:27:15 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wAU0REM2013870; Fri, 30 Nov 2018 00:27:14 GMT MIME-Version: 1.0 Message-ID: <5a6a3254-f742-44e9-a498-b6d5a375a873@default> Date: Thu, 29 Nov 2018 16:27:13 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> In-Reply-To: <875zwfed5h.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9092 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811300001 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > 1. I'm still puzzled about this: > > > > However, the current match will never scroll offscreen. > > If `unlimited', the current match can scroll offscreen. > > > > Those two sentences don't make sense together. > > If the current match never scrolls offscreen then > > it can't be true that the current match can scroll > > offscreen. Something different needs to be said > > here. >=20 > Do you think this is better? >=20 > "If non-nil, scrolling commands can be used in Isearch mode. > However, the current match can't scroll offscreen if the value is t. > But if it's `unlimited', the current match can scroll offscreen. > You may want to enable `lazy-highlight-buffer' in this case. > If nil, scrolling commands will cancel Isearch mode." > > If you don't agree, please suggest a better wording. I prefer the standard approach: say first what the default (nil) does. Then say what non-nil does. Then state that specific non-nil values have specific non-nil behaviors - IOW, they all do what the non-nil description says, but with some differences. For example: By default (nil value) scrolling exits Isearch mode. Non-nil means you can scroll while searching, as follows: `unlimited' You can scroll any distance. other non-nil value You cannot scroll far enough that the current search hit is no longer visible (is off screen). (BTW, is it only t or is it any other non-nil value?) > > 2. And the term "offscreen" doesn't seem like a > > good choice. Don't we mean just off the window, > > i.e., out of view? So this too bothers/confuses me: > > > > "Allow scrolling within screen" > > > > I don't know what is meant by "screen" here. > > What are the limits of the "screen" within > > which I can scroll with this option value? >=20 > I guess a screen is part of the buffer visible in the window. > We use the word "screen" in other docstrings as well. Yes, but here I think we need to be clear that the part of the buffer visible in the window is any part that _includes the current search hit_, no? Isn't that what this is about - scrolling so far that that hit is "off screen" means scrolling so far that it is no longer visible in the window. The "screenful" that defines the scrolling limits is not something defined independently of the position of the current search hit. > > 3. I'm also puzzled by this: > > > > You may want to enable `lazy-highlight-buffer' > > as well. > > > > Why say that? I think it confuses people, by > > suggesting that for some reason you might need > > to do that, in order to see such highlighting > > if you scroll (e.g. "offscreen"). > > > > That's not the case, is it? (I hope not.) I > > thought that the implementation of `unlimited' > > automatically lazy-highlights everything that > > you scroll to. Is that not the case? >=20 > No, this is not the case. This is very difficult > to implement, and not worth the effort because this feature > is already available by customizing lazy-highlight-buffer. I see. That disappoints me. We have lazy highlighting but we can't use it lazily, except for the original design of being limited to a windowful? Can't we "just" let scrolling move the "window limits" as you scroll? (Yes, I'm making this up, without looking at the code.) This highlight-as-you-go should really be considered part of this enhancement request, IMO. And I mentioned it as such. But if you don't want to tackle that part initially, or if indeed it ends up being too complex in the end, then so be it, for now. > Moreover, even if implemented, it still makes no sense > because it can't highlight as quick as you scroll > thru the buffer. I don't think I agree that it "makes no sense". 1. You might well scroll slowly sometimes, looking closely at search hits. Being able to see hits highlighted is always better than not. 2. If lazy highlighting can generally keep up with holding down `C-s', which it does pretty well now, then it should be able to do about the same wrt scrolling. Sure, there can be many search hits within a small area of text, but even so, I don't see this as a problem. And just as we (I guess) do for fast highlighting when you hold `C-s' down, we can presumably skip highlighting any hits that are no longer on the screen because you've moved past them. 3. Even if highlighting were sometimes slower than what you might scroll, it would catch up when you stop. Heck, if the alternative is full-buffer highlighting, that has to be even slower, no? > The problem is that you haven't tried my patch > with lazy-highlight-buffer enabled. If you tried > you wouldn't want any other implementation. OK, I'll take your word for it, I guess. But I don't see why highlighting only a portion of the buffer (and it might often be a tiny portion) should be less performant than highlighting the entire buffer. Is that really the case? > > 6. `*-allow-shift-selection' behavior: > > > > Why is the value `move'? Is that the best word? > > > > What happens with `move' if you use a shifted > > motion key? If it acts the same as `t' then what > > you call "shifted" is really "-only_ when shifted". > > What you call just "motion" seems like just both > > shifted and unshifted. > > > > Why do we even have two such choices? Why would > > someone who wants to yank chars by moving over > > them want to have to use Shift, ever? Is it so > > that they can use unshifted to exit Isearch and > > move the cursor? I guess so. Maybe that could > > be made clearer (dunno). > > > > 7. OK, no, `move' is apparently more complicated > > than that (all the more reason why it shouldn't > > be called `move'.) This text is a mouthful: > > > > by motion commands that have the `isearch-move' > > property on their symbols equal to `enabled', > > or [for which] the shift-translated command is > > not disabled by the value `disabled' of the same > > property. > > > > That sounds a bit like a legal text. You can just > > repeat "property `isearch-move'" instead of saying > > "the same property" - that would be clearer. But > > the sentence probably needs to be split. And it > > may be a sign that the behavior is too complicated. Is that part of what I wrote not clear, at least? I do advise splitting that sentence up, at a minimum. > > Why do we have this complicated behavior? Why > > not just have a `move' value that lets you yank > > text without having to use Shift (i.e. using Shift > > or not)? What's the point of having to put such a > > property on some command symbols? > > > > And if there really is a use case for doing that > > to certain commands, so that _only they_ manifest > > a difference between `t' and `move' behavior, > > then why not have only the `move' behavior (no `t' > > behavior)? >=20 > Sorry, I don't understand what do you suggest here. It's not clear to me what the behavior is or what problem it's trying to solve. You want to be able to yank text, that you move the cursor over in the buffer, onto the search string. Case `t': Some people want to do that using Shift selection. Why shift? Why wouldn't they just want to do it by moving the cursor (without bothering to shift)? Is it because they want to be able to, separately, move the unshifted cursor to exit Isearch and move over buffer text? Is that the idea? I guess so. Case `move': And for those people who don't want to give up having cursor movement exit Isearch, and who don't want to have to use Shift, we offer another way to yank to the search string by moving the cursor: Users or libraries can specify, for certain cursor movement commands, that mere unshifted cursor movement will yank. Is that right? This all sounds complicated, but if there really are such use cases (e.g., different users) then OK. For case `move', why do we have two different ways to specify the motion commands that we want to let yank text? 1. commands that have the `isearch-move' property on their symbols equal to `enabled' 2. shift-translated commands that have the `isearch-move' property on their symbols not equal to `disabled' I don't even follow that, especially #2. I guess there are at least 4 possibilities for property `isearch-move'? * `enabled' * not `disabled' (on symbol of shift-translated command) * nil * something else What other values for symbol of shift-translated command, besides `disabled', and what do they do? Why two ways to specify the commands that we let yank by moving the cursor? And what about the use case I mentioned: just be able to use any motion commands to yank text, without using Shift? Why assume that everyone wants to be able to use at least some cursor-motion commands to exit Isearch? This case is like implicitly putting the required `isearch-move' value on all commands. I'm not really arguing for any given behavior. I'm saying I don't really understand where all of this is coming from. Have different users actually requested something for these different possible use cases? Is some other library involved perhaps? What's behind this? It seems like a lot, just to let you yank buffer text by moving the cursor. FWIW, I can give an example of something a bit similar that I have in my code. (I don't know how useful it is.) I mention it because your use of a property value on a command made me think of it. I can see the value of letting only some motion commands (chosen by a user) do something other than exit Isearch. It's option `isearchp-initiate-edit-commands'. Default: (backward-char left-char backward-sexp backward-word left-word) Commands whose key bindings initiate Isearch edit. When invoked by a key sequence, Isearch edits the search string, applying the command to it immediately. Commands you might want to include here are typically commands that move point to the left, possibly deleting text along the way. Set this to `nil' if you always want all such commands to exit Isearch and act on the buffer text. IOW, `C-b' (by default), does not exit Isearch but instead, it's short for `M-e C-b'. The option is intended only for backward motion commands. But the idea seems similar to what you have for value `move': limit the behavior to particular commands. You do it with a symbol property; I did it with a list-valued option. (BTW, with `*-allow-shift-selection', if a user moves the cursor backward do you yank those chars onto the search string? I guess so. In which order: order of traversal or order of appearance in the buffer?) My questions about `*-allow-shift-selection' are first about the use cases, only secondarily about the doc. Both seem complicated to me, and I particularly wonder why the use cases. But I don't really need to understand. I reviewed what you wrote about that only because you included it in a reply to this (other) bug report. Ignore my feedback about `*-allow-shift-selection' if you like - no problem. > > The option is apparently about yanking text you > > move the cursor over. >=20 > So I renamed it to `isearch-allow-yank-on-move', > and its options to `no-shift' and `shift'. I would remove the "allow". The option is named after the non-nil behavior (as is common), which is to yank whatever you move the cursor over. > Thanks for the suggestion, I changed it to > "Motion keys exits Isearch". exits -> exit Thx - Drew From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 30 02:28:23 2018 Received: (at 15839) by debbugs.gnu.org; 30 Nov 2018 07:28:24 +0000 Received: from localhost ([127.0.0.1]:55453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSdDr-0006tJ-F4 for submit@debbugs.gnu.org; Fri, 30 Nov 2018 02:28:23 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSdDq-0006t8-Ga for 15839@debbugs.gnu.org; Fri, 30 Nov 2018 02:28:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gSdDg-0006xJ-FM for 15839@debbugs.gnu.org; Fri, 30 Nov 2018 02:28:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42122) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gSdDc-0006vN-Nt; Fri, 30 Nov 2018 02:28:10 -0500 Received: from [176.228.60.248] (port=3799 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gSdDZ-0000sH-Ce; Fri, 30 Nov 2018 02:28:06 -0500 Date: Fri, 30 Nov 2018 09:28:21 +0200 Message-Id: <83lg5bc9d6.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: <5a6a3254-f742-44e9-a498-b6d5a375a873@default> (message from Drew Adams on Thu, 29 Nov 2018 16:27:13 -0800 (PST)) Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) > Date: Thu, 29 Nov 2018 16:27:13 -0800 (PST) > From: Drew Adams > Cc: 15839@debbugs.gnu.org > > > "If non-nil, scrolling commands can be used in Isearch mode. > > However, the current match can't scroll offscreen if the value is t. > > But if it's `unlimited', the current match can scroll offscreen. > > You may want to enable `lazy-highlight-buffer' in this case. > > If nil, scrolling commands will cancel Isearch mode." > > > > If you don't agree, please suggest a better wording. > > I prefer the standard approach: say first what the default > (nil) does. Then say what non-nil does. I disagree that this should be a guideline. The following two variants are equivalently good documentation, IMO: Variant 1: "If non-nil, scrolling commands can be used in Isearch mode. If nil, the default, scrolling commands will cancel Isearch mode. If the value is t, the current match cannot be scrolled off-screen, but that limitation is removed if the value is `unlimited'. You may want to enable `lazy-highlight-buffer' in this case." Variant 2: "If nil, the default, scrolling commands will cancel Isearch mode. If non-nil, scrolling commands can be used in Isearch mode. If the value is t, the current match cannot be scrolled off-screen, but that limitation is removed if the value is `unlimited'. You may want to enable `lazy-highlight-buffer' in this case." And I think I slightly prefer the first one. Note that I rephrased the last part. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 30 10:33:51 2018 Received: (at 15839) by debbugs.gnu.org; 30 Nov 2018 15:33:51 +0000 Received: from localhost ([127.0.0.1]:56582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSknf-0008Ur-JW for submit@debbugs.gnu.org; Fri, 30 Nov 2018 10:33:51 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:53814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gSknd-0008Ud-I9 for 15839@debbugs.gnu.org; Fri, 30 Nov 2018 10:33:50 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wAUFTV8m036077; Fri, 30 Nov 2018 15:33:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=kiOLWQsWGpFl/0cVU27GbVl91zCU+izth9l+ShBhnwQ=; b=q1AAwTAEmow6k9U2KpXpJWRyyYexloMh+TbYcpKzuB9pJ6dk/WDOamskQ7x4vO1ROxQC zzNeEefwXsFybKzcp4pRPi2K7JAAOmDPwy+lz9BAnKpDfG5UtGj1D/Y+GTc+5N2BqZml 6AXyUYYO2N66SlzOnTNmT/BvaglEkmMpVxMuaAQ7SjgYJT2qTXntO3M60JjEoiBUVss/ MjxVoi2riZYnnz4mocP1U+tyj4JJCP7mLkHzBuH4GHlH08wnXwlEIb6PFzE6ZI04oCg9 vAeWqZ/C79Hu+MF1eSWylkDmZ9gmBcvWrFrJGpdfHVP7aSus7ui/N/OPQ9j+5f5T2hfe mg== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp2120.oracle.com with ESMTP id 2nxxkqxw4d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Nov 2018 15:33:43 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wAUFXgJB012125 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Nov 2018 15:33:42 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wAUFXfdI008559; Fri, 30 Nov 2018 15:33:41 GMT MIME-Version: 1.0 Message-ID: <90b5abf1-8203-4a50-877c-04070376c52a@default> Date: Fri, 30 Nov 2018 07:33:40 -0800 (PST) From: Drew Adams To: Eli Zaretskii , Drew Adams Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <<51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default>> <<83lg5bc9d6.fsf@gnu.org>> In-Reply-To: <<83lg5bc9d6.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9092 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=818 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1811300132 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > > "If non-nil, scrolling commands can be used in Isearch mode. > > > However, the current match can't scroll offscreen if the value is > > > t. > > > But if it's `unlimited', the current match can scroll offscreen. > > > You may want to enable `lazy-highlight-buffer' in this case. > > > If nil, scrolling commands will cancel Isearch mode." > > > > > > If you don't agree, please suggest a better wording. > > > > I prefer the standard approach: say first what the default > > (nil) does. Then say what non-nil does. >=20 > I disagree that this should be a guideline. I should have said "a more typical approach". > The following two variants are equivalently good documentation, IMO: >=20 > Variant 1: >=20 > "If non-nil, scrolling commands can be used in Isearch mode. > If nil, the default, scrolling commands will cancel Isearch mode. >=20 > If the value is t, the current match cannot be scrolled off-screen, > but that limitation is removed if the value is `unlimited'. > You may want to enable `lazy-highlight-buffer' in this case." >=20 > Variant 2: >=20 > "If nil, the default, scrolling commands will cancel Isearch mode. > If non-nil, scrolling commands can be used in Isearch mode. >=20 > If the value is t, the current match cannot be scrolled off-screen, > but that limitation is removed if the value is `unlimited'. > You may want to enable `lazy-highlight-buffer' in this case." >=20 > And I think I slightly prefer the first one. Note that I rephrased > the last part. Yes, both of those variants are also clear. In any case, the fact that nil is the default should be stated clearly, and the nil and non-nil cases should be stated up front. That different non-nil cases exist comes afterward, so it is clear that they have a common non-nil behavior. I think it's can sometimes be clearer to put all of the description(s) of non-nil behavior together, but it's not a requirement for a clear description. Describing the general nil vs non-nil together is usually helpful, I think, before mentioning any particular non-nil behavior (unless it is the default). From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 03 19:42:52 2018 Received: (at 15839-done) by debbugs.gnu.org; 4 Dec 2018 00:42:52 +0000 Received: from localhost ([127.0.0.1]:59622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTynb-0005nb-Rs for submit@debbugs.gnu.org; Mon, 03 Dec 2018 19:42:52 -0500 Received: from quail.birch.relay.mailchannels.net ([23.83.209.151]:28196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gTynZ-0005nS-MA for 15839-done@debbugs.gnu.org; Mon, 03 Dec 2018 19:42:50 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 227255C3776; Tue, 4 Dec 2018 00:42:48 +0000 (UTC) Received: from pdx1-sub0-mail-a54.g.dreamhost.com (unknown [100.96.19.74]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id C282F5C2D59; Tue, 4 Dec 2018 00:42:47 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a54.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 04 Dec 2018 00:42:48 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Gusty-Abaft: 059926185fecc2d3_1543884167874_2037024292 X-MC-Loop-Signature: 1543884167874:2924993049 X-MC-Ingress-Time: 1543884167873 Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id 8956B7FDBA; Mon, 3 Dec 2018 16:42:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=niT9rD/r0IBBEnH5oHsc3YPZhhw=; b= AjEMuicleUMcTU1Rcb1PKFozizK9DD9kGgN7KUyaspMU4g0MxJ6PKlODCd4s+XbE as+Rfc6UD+RjF8/xvrYyQnPLI5EArQV+nsE467IhY5X5NZIKrX+n+BT3OMyJ40Xi T0EXHbF/hEf0CTi1TE005qGWfpGi2XE5a7HcwXo7NOs= Received: from mail.jurta.org (m91-129-103-7.cust.tele2.ee [91.129.103.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id 4D40D7FE29; Mon, 3 Dec 2018 16:42:44 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a54 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> Date: Tue, 04 Dec 2018 02:29:42 +0200 In-Reply-To: <5a6a3254-f742-44e9-a498-b6d5a375a873@default> (Drew Adams's message of "Thu, 29 Nov 2018 16:27:13 -0800 (PST)") Message-ID: <87va4ai16x.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefvddgvdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839-done Cc: 15839-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > But I don't really need to understand. I reviewed > what you wrote about that only because you included > it in a reply to this (other) bug report. Ignore my > feedback about `*-allow-shift-selection' if you like > - no problem. Thank you for your feedback, all your remarks were taken into consideration, committed to master, and this enhancement request closed. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 09:46:15 2018 Received: (at 15839-done) by debbugs.gnu.org; 4 Dec 2018 14:46:15 +0000 Received: from localhost ([127.0.0.1]:59995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUBxl-0008J9-0T for submit@debbugs.gnu.org; Tue, 04 Dec 2018 09:46:14 -0500 Received: from aserp2130.oracle.com ([141.146.126.79]:43220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUBxi-0008Iu-TY for 15839-done@debbugs.gnu.org; Tue, 04 Dec 2018 09:46:11 -0500 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB4EhsqN151775; Tue, 4 Dec 2018 14:46:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=EQGJhplSsnZPPS+un5tySXZXOuCWLhlqF9axnMFhKgE=; b=XnMNPxnsOj41uOlBFjecd3ZjFqYUA/ZLZ8GQolpSEkmZOSiDvxmlxwaalJU/xyUc6IKe 6GL8lfTTyk0A9E2DZLSquNV6+y/xntfoScEe5J0YyOmycBqtGq1hLGAkJM6aMlDc0BEV kM9y9qhrxwDAB0MT7Son4UWiZmHO/+YCcKFadw4pmt7zgS+WmNZ8Enn3lBzcD68XBHHr nQPy3J3yzU9abssA6ok3Tbm/kFg8PSTKkp7fOf9NSmD+JevMIS2r8bD/iqGuXS0Wav7r qq+w69GAJ9+6ZkLP91jkJEg/DN96L5bysmT8Xl3wLR8bVKyganRNZeUDnQ6rx1aYJ6jd 9w== Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp2130.oracle.com with ESMTP id 2p3ftf0rgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Dec 2018 14:46:04 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB4Ek29w029741 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Dec 2018 14:46:03 GMT Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB4Ek1Vq016800; Tue, 4 Dec 2018 14:46:02 GMT MIME-Version: 1.0 Message-ID: <9a36d118-5ee8-4526-bc69-91665a8e801c@default> Date: Tue, 4 Dec 2018 14:46:01 +0000 (UTC) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> In-Reply-To: <87va4ai16x.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9096 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812040126 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839-done Cc: 15839-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > But I don't really need to understand. I reviewed > > what you wrote about that only because you included > > it in a reply to this (other) bug report. Ignore my > > feedback about `*-allow-shift-selection' if you like > > - no problem. >=20 > Thank you for your feedback, all your remarks were > taken into consideration, committed to master, and > this enhancement request closed. I'm amazed by this, Juri. You introduced stuff into this bug thread that is about another bug entirely (`*-allow-shift-selection'). I replied to your feedback about this bug, point by point. And, hoping to help, I also provided some feedback about that other, unrelated bug. What you quote above is about that _other_ bug, not this one. I said that you can, if you like, ignore my feedback about `*-allow-shift-selection'. That bug is not something I'm really concerned about - my feedback about it was just trying to be helpful. As for this bug, I made clear that all that it calls for does not yet seem to be provided by your proposed changes. Yet you reply (only) to my comment that you can ignore my feedback about `*-allow-shift-selection', to say that you have therefore closed _this_ bug. I'm amazed - unless you did this accidentally, confusing the two bugs and meaning to close the other bug instead. If you really intended to close this bug, please say how "all [my] remarks were taken into consideration" and how this enhancement request has been entirely fulfilled. That's not clear to me. >From my point of view, it seems like you've made changes to fix other bugs that incidentally make progress toward also realizing the enhancement requested by this bug. That's all good. But I don't see that this enhancement has been realized. I addressed this in specific ways, none of which you've responded to in this closure message. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 15:47:02 2018 Received: (at 15839-done) by debbugs.gnu.org; 4 Dec 2018 20:47:02 +0000 Received: from localhost ([127.0.0.1]:32780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUHav-0003IS-Rn for submit@debbugs.gnu.org; Tue, 04 Dec 2018 15:47:02 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:56234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUHat-0003IE-Ls for 15839-done@debbugs.gnu.org; Tue, 04 Dec 2018 15:47:00 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB4Kj2Bf063847; Tue, 4 Dec 2018 20:46:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=tQ4yc6ZRdPUH56EwbeS6GW1ToCGnA8T5EV18hlM1hxU=; b=5rYbQCCYlFkh0+BCpnDGq5IJkB/n2ee7LyzfGIE4Ep5RpMx5ysJtxFUL3oav1/CioPxQ rS7ffJc4BqoJnOKYhlg/+K55aFrE+xg4o0Wt+TFlerZudNS9hNbsVE0/p9elm0XC46Ft bt0gzQ2L5BCxijWItZHpNkhSCw+VhD2eyS0FtHlaiPzgQPilT0PpN/4g0Cgv9Wmn15LK kFIP3KkwYuDlsFoHZ4gF25xy89hpK4y0sd9BY94O6Sbm/WnpSdK1YwVkVOR6n3Urw1JP Aep46wht23aWIbTPOkchUTi9zSFUJleLt7Eeu4q8cqlfV0E3yUZ8mnS9o3Tu1R9QFSrY fw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2p3jxrer82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Dec 2018 20:46:53 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB4KkqR4002315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Dec 2018 20:46:53 GMT Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wB4KkqdX016744; Tue, 4 Dec 2018 20:46:52 GMT MIME-Version: 1.0 Message-ID: <4b2833f5-a0d7-408d-8cc0-4479043ef368@default> Date: Tue, 4 Dec 2018 12:46:51 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <9a36d118-5ee8-4526-bc69-91665a8e801c@default> In-Reply-To: <9a36d118-5ee8-4526-bc69-91665a8e801c@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9097 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=994 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812040178 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839-done Cc: 15839-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > -----Original Message----- > From: Drew Adams > Sent: Tuesday, December 4, 2018 6:46 AM > To: Juri Linkov > Cc: 15839-done@debbugs.gnu.org > Subject: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll > point off screen temporarily >=20 > > > But I don't really need to understand. I reviewed > > > what you wrote about that only because you included > > > it in a reply to this (other) bug report. Ignore my > > > feedback about `*-allow-shift-selection' if you like > > > - no problem. > > > > Thank you for your feedback, all your remarks were > > taken into consideration, committed to master, and > > this enhancement request closed. >=20 > I'm amazed by this, Juri. You introduced stuff > into this bug thread that is about another bug > entirely (`*-allow-shift-selection'). >=20 > I replied to your feedback about this bug, point by > point. And, hoping to help, I also provided some > feedback about that other, unrelated bug. >=20 > What you quote above is about that _other_ bug, not > this one. I said that you can, if you like, ignore > my feedback about `*-allow-shift-selection'. That > bug is not something I'm really concerned about - > my feedback about it was just trying to be helpful. >=20 > As for this bug, I made clear that all that it > calls for does not yet seem to be provided by > your proposed changes. >=20 > Yet you reply (only) to my comment that you can > ignore my feedback about `*-allow-shift-selection', > to say that you have therefore closed _this_ bug. >=20 > I'm amazed - unless you did this accidentally, > confusing the two bugs and meaning to close the > other bug instead. >=20 > If you really intended to close this bug, please > say how "all [my] remarks were taken into > consideration" and how this enhancement request > has been entirely fulfilled. That's not clear > to me. >=20 > From my point of view, it seems like you've made > changes to fix other bugs that incidentally make > progress toward also realizing the enhancement > requested by this bug. That's all good. >=20 > But I don't see that this enhancement has been > realized. I addressed this in specific ways, > none of which you've responded to in this > closure message. Apologies, as I seem to have misunderstood. I thought that you were just saying that what you had come up with last time is what you installed. Regarding that, this is what I thought was unfinished: >> No, this is not the case. This is very difficult >> to implement, and not worth the effort because this feature >> is already available by customizing lazy-highlight-buffer. > > I see. That disappoints me. We have lazy > highlighting but we can't use it lazily, except for > the original design of being limited to a windowful? > > Can't we "just" let scrolling move the "window limits" > as you scroll? (Yes, I'm making this up, without > looking at the code.) > > This highlight-as-you-go should really be considered > part of this enhancement request, IMO. And I mentioned > it as such. But if you don't want to tackle that part > initially, or if indeed it ends up being too complex in > the end, then so be it, for now. I thought what you installed still included that telling users that to ensure they get lazy highlighting everywhere they scroll they may need to customize `lazy-highlight-buffer. As you didn't say anything different I assumed that the "very difficult to implement, and not worth the effort" was what was reflected in what you installed. I've now tried what you ended up installing, and I see that that's not the case (and that you removed the advice that you might need to set `lazy-highlight-buffer' to t to see highlighting when scrolling). What you installed does indeed seem to implement this enhancement. Thank you for that, and sorry for not understanding and reacting negatively. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 16:47:29 2018 Received: (at 15839) by debbugs.gnu.org; 4 Dec 2018 21:47:29 +0000 Received: from localhost ([127.0.0.1]:32869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUIXR-0006kc-7e for submit@debbugs.gnu.org; Tue, 04 Dec 2018 16:47:29 -0500 Received: from eastern.maple.relay.mailchannels.net ([23.83.214.55]:7868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUIXN-0006kQ-0l for 15839@debbugs.gnu.org; Tue, 04 Dec 2018 16:47:25 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9DAD65E18EB; Tue, 4 Dec 2018 21:47:23 +0000 (UTC) Received: from pdx1-sub0-mail-a54.g.dreamhost.com (unknown [100.96.20.98]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 65E3F5E223D; Tue, 4 Dec 2018 21:47:23 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a54.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 04 Dec 2018 21:47:23 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Absorbed-Callous: 07a54cb335aa9025_1543960043506_714975969 X-MC-Loop-Signature: 1543960043506:1681287233 X-MC-Ingress-Time: 1543960043505 Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id 2F6BC7FEDF; Tue, 4 Dec 2018 13:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=19gPISKHYA7MTvb4+c+G0KrUzw4=; b= GwA3y6jvZCdA9uu9jjOdYfqKMQzbvq2LTABub67AVJBT0WAnElsCnt0nIl3Ll8es /lfmj/IJFtS4gU7cdfkwGsqqsBBBDLfA1VpesTAnLkTQixdYVZWZDCVWjYsThrrx 0IPLpXZNP1uhwUWBhCxMQtQ2J5X5LMCJVddYvAAH7rQ= Received: from mail.jurta.org (m91-129-103-7.cust.tele2.ee [91.129.103.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id EA0E97FF0A; Tue, 4 Dec 2018 13:47:21 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a54 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <9a36d118-5ee8-4526-bc69-91665a8e801c@default> <4b2833f5-a0d7-408d-8cc0-4479043ef368@default> Date: Tue, 04 Dec 2018 23:38:29 +0200 In-Reply-To: <4b2833f5-a0d7-408d-8cc0-4479043ef368@default> (Drew Adams's message of "Tue, 4 Dec 2018 12:46:51 -0800 (PST)") Message-ID: <87o9a17z1m.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudeffedgudehfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrjeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughrvgifrdgruggrmhhssehorhgrtghlvgdrtghomhenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I've now tried what you ended up installing, and I see > that that's not the case (and that you removed the advice > that you might need to set `lazy-highlight-buffer' to t > to see highlighting when scrolling). > > What you installed does indeed seem to implement this > enhancement. Thank you for that, and sorry for not > understanding and reacting negatively. Sorry for replying to a wrong comment when closing this request, there are so many comments that I picked a wrong one. I completely implemented all points from your original request, and this new feature works so well, that I already customized `isearch-allow-scroll' to `unlimited' and started using it even without enabling `lazy-highlight-buffer'. BTW, regarding another feature that you helped to develop, I just realized that the variable name `isearch-yank-on-move' is not the best one. I propose a better name `isearch-move-to-yank'. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 04 19:32:58 2018 Received: (at 15839) by debbugs.gnu.org; 5 Dec 2018 00:32:58 +0000 Received: from localhost ([127.0.0.1]:32930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUL7a-0002Jf-C0 for submit@debbugs.gnu.org; Tue, 04 Dec 2018 19:32:58 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:41480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUL7X-0002JP-Vt for 15839@debbugs.gnu.org; Tue, 04 Dec 2018 19:32:56 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB50PUpv066033; Wed, 5 Dec 2018 00:32:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=s2jMLVaYUViVnq+1VLsnIK9zscIE67sgYsaD95dBf80=; b=2jYPYhSF1fEMg4QyDH3Y0y7YsPnNT3O30INWexG68rQ1/cBO55vut0uNxPUFuhP81Zxk bgGIXWQXGClUU470t1AQUBvvZJZMWMqSIKeNtQdKZPvKH27KAicARH9hmnerp+D/0Qmq uQsrUqpKh7LrfC+f+e5GKD0e5heBhNUsGWcXqC0kWnslgS7A/XPivrmwgdTHAIhb74cB zWMmt8R1Tp1DIeeDaruf4sBnVIP+Xt7VImUS3Q2aOBuk4ptEApcbjFg9JJs1m897RZ0U svYT8ZtYe1L3N1th+kzo/GISazo8HwSW+Jx+NhcpchMy2mhx7TZKRkY4PFJcyyKT2S61 ng== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2130.oracle.com with ESMTP id 2p3hqtymg2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 05 Dec 2018 00:32:49 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id wB50WmOV018834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 5 Dec 2018 00:32:49 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wB50Wmls007720; Wed, 5 Dec 2018 00:32:48 GMT MIME-Version: 1.0 Message-ID: <8308c90e-e391-428c-ab96-1cf5f5539997@default> Date: Tue, 4 Dec 2018 16:32:47 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <9a36d118-5ee8-4526-bc69-91665a8e801c@default> <4b2833f5-a0d7-408d-8cc0-4479043ef368@default> <87o9a17z1m.fsf@mail.linkov.net> In-Reply-To: <87o9a17z1m.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9097 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812050002 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > I've now tried what you ended up installing, and I see > > that that's not the case (and that you removed the advice > > that you might need to set `lazy-highlight-buffer' to t > > to see highlighting when scrolling). > > > > What you installed does indeed seem to implement this > > enhancement. Thank you for that, and sorry for not > > understanding and reacting negatively. >=20 > Sorry for replying to a wrong comment when closing this request, > there are so many comments that I picked a wrong one. I understand. I too am lost in several threads (not to mention work ;-)). > I completely implemented all points from your original request, > and this new feature works so well, that I already customized > `isearch-allow-scroll' to `unlimited' and started using it > even without enabling `lazy-highlight-buffer'. Yes, it works fine without `lazy-highlight-buffer', AFAICT. What happened to "This is very difficult to implement"? You seem to have silently (and quickly) solved that one somehow. > BTW, regarding another feature that you helped to develop, > I just realized that the variable name `isearch-yank-on-move' is not > the best one. I propose a better name `isearch-move-to-yank'. Sounds good. Except that "move to" has a connotation of moving to some place, e.g., move to a place where something was yanked or will be yanked. What about something like `cursor-movement-yanks' or `movement-yanks' or `moving-yanks'? --- FWIW, all such names, including `move-to-yank' would be clearer with the RMS convention of having suffix `-flag'. That was the Emacs convention, until Stefan I think. I still follow it. And I use suffix `-p' for a non-option variable. (And yes, a Boolean variable can be thought of as a (nullary) predicate.) From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 07:59:56 2018 Received: (at 15839) by debbugs.gnu.org; 5 Dec 2018 12:59:56 +0000 Received: from localhost ([127.0.0.1]:33218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUWmS-0008Ha-Ef for submit@debbugs.gnu.org; Wed, 05 Dec 2018 07:59:56 -0500 Received: from mout.web.de ([212.227.15.4]:33047) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUWmQ-0008HL-27 for 15839@debbugs.gnu.org; Wed, 05 Dec 2018 07:59:54 -0500 Received: from drachen.dragon ([88.67.73.131]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LzbAA-1hXofG1N2Y-014hWw; Wed, 05 Dec 2018 13:59:40 +0100 From: Michael Heerdegen To: 15839@debbugs.gnu.org Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> Date: Wed, 05 Dec 2018 13:59:39 +0100 In-Reply-To: <87va4ai16x.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 04 Dec 2018 02:29:42 +0200") Message-ID: <87zhtk164k.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:UoSRA2YCdQ/v7+lygJhKRjDRegdPe37dAhQifG4OIEbiunsoIUt InNCaZUuKo40s0Z4984nbVpXxsYZKhv0QjY/G0ByGE8RpdUotbX0CDRn3HUdxD/5v9hS93I YjwUgN6lhRwnBhcaawVNffbE51Zq24IXZGw0OnpDZDBECXKsmvQC4UNovi/ZL3pfvbZMFNJ iR81+Pk5NPnsHGps36dBQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ZsYRXJv4s1A=:P0hc6Xi7B11V8BFs3MpsiO K/ghi9IpyjTmuH2R7/9HzTerW3bFK/tcXBOGPFC8G7VKfeU9Dl9hCppf5oMmwsdzGbxIzgGo/ o0IyIH+/OfAUm8DmCkvWnWwsR067gjm+kJwdJ8//DylWRne/QU0/5Q6ohZW8ahASe6AV55jAE jXJwEAxnQZ8cdi0YYTl6FfrDFPV5/nkbQbuhIwnwz5+KTa1fb+eiyD9aowgyJLxidibQbTMfQ 4ysnVQoAhOwbWdVsWc6zPflprzfUuhQ7GQbx5gbW0udKZ+hbkCL8YODOlkljNAJg/zogrXnlG aZz8qlcp+WYuoysQvecOSYM5KIUUZeGmx5bEoX+bcCJi7sxkqETHhLHtIjTxNFJRqHEEgvVzv gA06qGlsHFQwvd6X8GrobDYN5ETaBLa3Fox9mSLBKz6qp1jXgiC6P6XZ4ozwr/+5ryiB0fPcr +N/8otnCCw5r7obf+wlWCTcE1tkg7YJyDVvFRSRZlcSnLuycV/n68qGx0+FJbohtH774vW6Ie 2FT8FCL+UFAgK7iFP32RPIizIjZsdvbs4Y6EYV7Gb2j+Risf5vkPhbftHfTf2CEooOM5+VoCq OWCFIPCUaKir7VsxSLpX2ZlWzgZVBTNOXe01GqFpPNHa49lEdmDHbdz0/Am1/c/w0/tesdbTz Obbg3mR+7mDory2Rg3ZQ1gzRPejcQX4Ge8oULoRh/eQ5lAmOe3+dmxUnyY/GJa/C6RyMv/9zX p+xQZjO/4sl5ASioL8h65SV5ahI59F67sR42m8RRo0Hpb6qlqaRyvhnLr6K++2eF6fdWu90a9 FW8QIatD1GgJVZJi7W5itAxQ7IB9K/Kwqp5yxs0gU3ZCj0o8oPDBD09zem+M8Ja46rK7lV/Az TT3OXPaX3TZ0UGVQbk1okaytcQCkwEgrAUAq1caMiDJaIVt/RB4EafA6FdiSNwjsoOm2afFKr OQBWZkWiGGQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15839 Cc: drew.adams@oracle.com, juri@linkov.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > Thank you for your feedback, all your remarks were taken into > consideration, committed to master, and this enhancement request > closed. Thank you for working on this. I have a question: I customized isearch-yank-on-move now to shift, but left and right still exit isearch, I think because I (well, I guess, not only I) have a global binding of shift-left and shift-right. Is there a way to make shift-left and shift-right work nonetheless? I tried #+begin_src emacs-lisp (define-key isearch-mode-map [(shift left)] nil) (define-key isearch-mode-map [(shift right)] nil) #+end_src but that doesn't seem to do it. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 19:57:33 2018 Received: (at 15839) by debbugs.gnu.org; 6 Dec 2018 00:57:33 +0000 Received: from localhost ([127.0.0.1]:34821 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUhyr-0004YI-8B for submit@debbugs.gnu.org; Wed, 05 Dec 2018 19:57:33 -0500 Received: from eastern.maple.relay.mailchannels.net ([23.83.214.55]:2829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUhyl-0004Y6-IY for 15839@debbugs.gnu.org; Wed, 05 Dec 2018 19:57:27 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 74B5B3E35F0; Thu, 6 Dec 2018 00:57:22 +0000 (UTC) Received: from pdx1-sub0-mail-a54.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2D8F33E31EA; Thu, 6 Dec 2018 00:57:22 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a54.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Thu, 06 Dec 2018 00:57:22 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Dime-Obese: 481b386c2f976c86_1544057842297_672257336 X-MC-Loop-Signature: 1544057842296:3814375179 X-MC-Ingress-Time: 1544057842296 Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id E5A3080077; Wed, 5 Dec 2018 16:57:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=JmvKRPBlQDfiSr2zbJzQkRuH3C0=; b= VGCNplcDBK/C42gX0uuMRl5UObljBb42Fi1Kre8Z/MmW2NwdDvLErY7P9twtE6Ku DpXjc/+wlFVTvVkDpRTZ967zqdKqBkHr6E25EEcUON7h8GjrqroErGuGmF3LIADZ 3TiF2Um8oZlAeekC25VGZH9vV3hCf96HWMJVpz6+v24= Received: from mail.jurta.org (m91-129-103-7.cust.tele2.ee [91.129.103.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id 857808007F; Wed, 5 Dec 2018 16:57:06 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a54 From: Juri Linkov To: Drew Adams Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <9a36d118-5ee8-4526-bc69-91665a8e801c@default> <4b2833f5-a0d7-408d-8cc0-4479043ef368@default> <87o9a17z1m.fsf@mail.linkov.net> <8308c90e-e391-428c-ab96-1cf5f5539997@default> Date: Thu, 06 Dec 2018 01:44:28 +0200 In-Reply-To: <8308c90e-e391-428c-ab96-1cf5f5539997@default> (Drew Adams's message of "Tue, 4 Dec 2018 16:32:47 -0800 (PST)") Message-ID: <87in075xmb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefiedgvdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgepvd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > I've now tried what you ended up installing, and I see >> > that that's not the case (and that you removed the advice >> > that you might need to set `lazy-highlight-buffer' to t >> > to see highlighting when scrolling). >> > >> > What you installed does indeed seem to implement this >> > enhancement. Thank you for that, and sorry for not >> > understanding and reacting negatively. >> >> Sorry for replying to a wrong comment when closing this request, >> there are so many comments that I picked a wrong one. > > I understand. I too am lost in several threads (not to mention work ;-)). > >> I completely implemented all points from your original request, >> and this new feature works so well, that I already customized >> `isearch-allow-scroll' to `unlimited' and started using it >> even without enabling `lazy-highlight-buffer'. > > Yes, it works fine without `lazy-highlight-buffer', AFAICT. > > What happened to "This is very difficult to > implement"? You seem to have silently (and > quickly) solved that one somehow. This is because I misunderstood what you described at first. Later I realized what it's about. >> BTW, regarding another feature that you helped to develop, >> I just realized that the variable name `isearch-yank-on-move' is not >> the best one. I propose a better name `isearch-move-to-yank'. > > Sounds good. > > Except that "move to" has a connotation of moving > to some place, e.g., move to a place where something > was yanked or will be yanked. I see, its ambiguity is like in `move-to-column'. > What about something like `cursor-movement-yanks' > or `movement-yanks' or `moving-yanks'? > > --- > > FWIW, all such names, including `move-to-yank' would > be clearer with the RMS convention of having suffix > `-flag'. > > That was the Emacs convention, until Stefan I think. > I still follow it. And I use suffix `-p' for a > non-option variable. (And yes, a Boolean variable > can be thought of as a (nullary) predicate.) Isn't the suffix `-p' allowed only for predicate functions? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 19:59:25 2018 Received: (at 15839) by debbugs.gnu.org; 6 Dec 2018 00:59:25 +0000 Received: from localhost ([127.0.0.1]:34826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUi0f-0004bB-9r for submit@debbugs.gnu.org; Wed, 05 Dec 2018 19:59:25 -0500 Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:17859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUi0Z-0004az-Kh for 15839@debbugs.gnu.org; Wed, 05 Dec 2018 19:59:19 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 82C2A42EC8; Thu, 6 Dec 2018 00:59:14 +0000 (UTC) Received: from pdx1-sub0-mail-a54.g.dreamhost.com (unknown [100.96.19.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 3C01B42C84; Thu, 6 Dec 2018 00:59:14 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a54.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Thu, 06 Dec 2018 00:59:14 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thread-Plucky: 730350204cfc3fac_1544057954381_585048412 X-MC-Loop-Signature: 1544057954381:511018693 X-MC-Ingress-Time: 1544057954380 Received: from pdx1-sub0-mail-a54.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTP id DD0768007F; Wed, 5 Dec 2018 16:59:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=3OLnTRsCQLaHAhtcKUsUdyE5WFw=; b= F77Z6v7azBgJmiFHVqlHTcX/+47Fs1SsWPEzn7soVZk1uBceTxkynYNPFcY/wvYA IQH1zbq+gqyl6InlCidpFf5ba7PQRFG3pB+NrJ9e7JbM9b5XEQLXBIV0y5jhJEAt NnC6jpksJq/ELdMTaqyKwdQBdEfg9HKsha5eGMTGQis= Received: from mail.jurta.org (m91-129-103-7.cust.tele2.ee [91.129.103.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a54.g.dreamhost.com (Postfix) with ESMTPSA id 7493E80065; Wed, 5 Dec 2018 16:57:51 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a54 From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> Date: Thu, 06 Dec 2018 01:49:30 +0200 In-Reply-To: <87zhtk164k.fsf@web.de> (Michael Heerdegen's message of "Wed, 05 Dec 2018 13:59:39 +0100") Message-ID: <87woon33bp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefiedgvdekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvgenucevlhhushhtvghrufhiiigvpeef X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > I have a question: I customized isearch-yank-on-move now to shift, but > left and right still exit isearch, I think because I (well, I guess, not > only I) have a global binding of shift-left and shift-right. Isn't this binding of shift-left and shift-right from Org mode? I still have no solution how to use this feature in Org mode. Or maybe your shift-left and shift-right bindings come from windmove-default-keybindings? There is still no solution because windmove's global shift-binding exits Isearch and moves to another window. > Is there a way to make shift-left and shift-right work nonetheless? I > tried > > #+begin_src emacs-lisp > (define-key isearch-mode-map [(shift left)] nil) > (define-key isearch-mode-map [(shift right)] nil) > #+end_src > > but that doesn't seem to do it. I tried their original keybindings (define-key isearch-mode-map [(shift left)] 'left-char) (define-key isearch-mode-map [(shift right)] 'right-char) but it still doesn't work. Maybe we should support shift-key in isearch explicitly, not relying on this-command-keys-shift-translated. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 05 20:20:38 2018 Received: (at 15839) by debbugs.gnu.org; 6 Dec 2018 01:20:38 +0000 Received: from localhost ([127.0.0.1]:34840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUiLG-00057P-LH for submit@debbugs.gnu.org; Wed, 05 Dec 2018 20:20:38 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:39806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUiLE-000579-E0 for 15839@debbugs.gnu.org; Wed, 05 Dec 2018 20:20:36 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB61E1eg037350; Thu, 6 Dec 2018 01:20:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=ubEcewUVGqIzI7RIW64wdrk+2epJGsVvM9EW+KTQqTc=; b=J75nXiOgFXNip+To2ck68Of20tfA4MALROCesjJ+vw5UWlJDBgpseBrUSv3B0FxeNBNO B/cco3FmVdTObs4qci7AYK7uegX+DRCI9q/Q2AYcWErSogStDjbQ20RNxTA3LyQSZvTl fM3TXvYJYTP/s4toJONhdTt89QB2+uWFfr1gqeqmXRdcpU9aqZ7YFfxLBApItA4h5x3l 3O8s9dauMHXRuf8EL4JpgKRcZSF+7+YbhJHqTVx32D++zTr/dm+OC/1rSUizpSMt3oK/ 5LJV1PXSwb4oIYj2RHhzujvnc5asFP2lXyb7wSbIg2wfCY+anMMqlwr2CM6LKJM3GTzW 0A== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2p3hqu5q0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 06 Dec 2018 01:20:30 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB61KTrc019482 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 6 Dec 2018 01:20:29 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id wB61KSgW015642; Thu, 6 Dec 2018 01:20:28 GMT MIME-Version: 1.0 Message-ID: <9eee6b87-2837-4e69-8ec1-2b9f02fb7f34@default> Date: Wed, 5 Dec 2018 17:20:27 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <9a36d118-5ee8-4526-bc69-91665a8e801c@default> <4b2833f5-a0d7-408d-8cc0-4479043ef368@default> <87o9a17z1m.fsf@mail.linkov.net> <8308c90e-e391-428c-ab96-1cf5f5539997@default> <87in075xmb.fsf@mail.linkov.net> In-Reply-To: <87in075xmb.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9098 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=943 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812060008 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > FWIW, all such names, including `move-to-yank' would > > be clearer with the RMS convention of having suffix > > `-flag'. > > > > That was the Emacs convention, until Stefan I think. > > I still follow it. And I use suffix `-p' for a > > non-option variable. (And yes, a Boolean variable > > can be thought of as a (nullary) predicate.) >=20 > Isn't the suffix `-p' allowed only for predicate functions? I believe that's the Emacs argument, yes. In particular, I believe it's Stefan's argument - dunno whether it is in some way "official". What I was saying was the _I_ use suffix `-flag' for an option and suffix `-p' (or `p') for a non-option variable. That makes things very clear (to me). Add `-flag' to any of the names considered above, and the ambiguity and lack of clarity is diminished, if not dispelled altogether. And suffix `-flag' is not "disallowed", AFAIK. Of course, Isearch already has other boolean options that do not use such a suffix. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 06 07:16:08 2018 Received: (at 15839) by debbugs.gnu.org; 6 Dec 2018 12:16:08 +0000 Received: from localhost ([127.0.0.1]:35000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUsZY-0006Wr-62 for submit@debbugs.gnu.org; Thu, 06 Dec 2018 07:16:08 -0500 Received: from mout.web.de ([212.227.15.14]:49815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUsZS-0006W2-SD for 15839@debbugs.gnu.org; Thu, 06 Dec 2018 07:16:02 -0500 Received: from drachen.dragon ([88.67.73.131]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MSazE-1gwU5s3ZvY-00RXbg; Thu, 06 Dec 2018 13:15:44 +0100 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> Date: Thu, 06 Dec 2018 13:15:43 +0100 In-Reply-To: <87woon33bp.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 06 Dec 2018 01:49:30 +0200") Message-ID: <87mupij1g0.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:oPaKd1THADjh0mif4JPEBICtM2kDx18fs+ME3e+uYd+g15aAkQF pcRhhFDQllfyOsd+YOuJgwt8jy90g1cpiWrQcw86uOqhv4tznbcJZKoQv76oCYGEYFbPi+D pN/GB9PnU4kkNGAC+h4Uwyk4k8HSvqNIFwtKPu2cxi43jVeALoIAyvFkSM2gxM1PA7SRC/B ky1mIh4bIjnKii9pQUAvA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:kno7uQ2xp4Y=:UQrf2He2qGSe62twDGEFcw nyILhtXHCX7mTPCEP235eDD24X0u4n1T4uEhLA9r96zzJpUVOco0ycAjROtdcRmrR9f63UIb7 xf091yFtNZ5v4lNpCD1WbW18CXvqg6QLquSWqeUJkp6yCUHpQvv+3CctrothORmEY7sD+h1MZ LX1hDPKdo3zBgagk5jKTkiR61wtb2uG++NX2Sd64QvKci6WImKxhKmCp2SBUsWOcBHYaWYnvh gwjl+j5hiVV+JTJDEUI9UPOoAxTvA0hpRyimnS1HW16OkdyljT8DpQBDki+fbvFTswIYG647f XqOm5aX0hVtKy+ocjDD+0Gti1Prer2jCdA/5bx02FbgcpI4Sr9bg6Iopw8ZLOyTmjBiAV6LVP g6I0+ljrj9TnbGcAjwvnil7TBCeNCw3RZp58sy2RrZze8ghj1WJBqFiWLZmgAUlIvXw48ZW/T p+W67rUEsMeIetav8vVUtyTsQHzXjdfJ/f8qqS9ZLMGQtABUr1fH0BsZn9kSWLsNSkwX6IN1c YzF5q3NZtScedVxAlKCN2qBnSxoa4XydGnIslHX7150zz925tFmufVESmJksunqQCCSAVlyuW fMJ1Vu3zNiQRk05++ezx8KYWDkKqiEWdHsZzaHBNFMtGU4ESzR208LI3OCSK+sK99/gqifJtv QvFB1WW7Bpk3JcrUSTKymu5UAlwUi1ZKFU1sItcQXjZN14esinA8Kbr+NOjePVRiTBnOeZeFE c3Uix/K+/7XKBkyYJZk5VhnIhtaBW7mCz8g6/hPPnlB4oy/mXRmobTn7j9seHbfiG70sKCYS+ RumIhS/XeJEXhzC8aCxKWmJDXll1ovyANb5E7wJkr+la/m5il9WDAYx0S6NTD4XkaJPplIDER dXh0bIPKpnMJgvQld68QbpLz1boSE8g8gG/gtKxnrbUb91ZijAiNUSm5aEl+aNocOE7lASEz5 Raz9xl4IT1w== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > Isn't this binding of shift-left and shift-right from Org mode? No, I simply have personal global bindings for these: (global-set-key [(shift left)] #'backward-char) (global-set-key [(shift right)] #'forward-char) > I tried their original keybindings > > (define-key isearch-mode-map [(shift left)] 'left-char) > (define-key isearch-mode-map [(shift right)] 'right-char) > > but it still doesn't work. Maybe we should support shift-key in > isearch explicitly, not relying on this-command-keys-shift-translated. Maybe, I dunno. If something prominent as org-mode interferes with that, it would probably good to find a solution. Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 06 19:00:53 2018 Received: (at 15839) by debbugs.gnu.org; 7 Dec 2018 00:00:54 +0000 Received: from localhost ([127.0.0.1]:36144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gV3ZZ-0001lv-Vt for submit@debbugs.gnu.org; Thu, 06 Dec 2018 19:00:53 -0500 Received: from ladybird.maple.relay.mailchannels.net ([23.83.214.98]:42904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gV3ZU-0001lf-Tz for 15839@debbugs.gnu.org; Thu, 06 Dec 2018 19:00:49 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 6D131435BB; Fri, 7 Dec 2018 00:00:43 +0000 (UTC) Received: from pdx1-sub0-mail-a68.g.dreamhost.com (unknown [100.96.20.98]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 2B33443571; Fri, 7 Dec 2018 00:00:43 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a68.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Fri, 07 Dec 2018 00:00:43 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Shelf-Relation: 4b6e0bc039311ca4_1544140843283_571744823 X-MC-Loop-Signature: 1544140843283:2969612708 X-MC-Ingress-Time: 1544140843283 Received: from pdx1-sub0-mail-a68.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a68.g.dreamhost.com (Postfix) with ESMTP id E0AD47FE56; Thu, 6 Dec 2018 16:00:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=YWqqPc4wZ8jN+N3Oyx+/LgFyn7M=; b= n46AVN+CfOct0t4N8B5Ioydj/VpxNfHNnqOpouK9+HBgCumGkBP7jmx47+2YGj5G unZcVZTUJFfF66wRk5T2a67DTmh7Y1RXB6yOas+/mT00JociLAdC/ah5wnrYS3Kd SYZA1eLqoTHqRQ9ouTEpM2+nh8G9T3VHo2qVWA2c7K8= Received: from mail.jurta.org (m91-129-103-7.cust.tele2.ee [91.129.103.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a68.g.dreamhost.com (Postfix) with ESMTPSA id 896C87FE51; Thu, 6 Dec 2018 16:00:41 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a68 From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> Date: Fri, 07 Dec 2018 01:03:54 +0200 In-Reply-To: <87mupij1g0.fsf@web.de> (Michael Heerdegen's message of "Thu, 06 Dec 2018 13:15:43 +0100") Message-ID: <87o99y5kbp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefkedgudekucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddtfedrjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvgenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> Isn't this binding of shift-left and shift-right from Org mode? > > No, I simply have personal global bindings for these: > > (global-set-key [(shift left)] #'backward-char) > (global-set-key [(shift right)] #'forward-char) Your keybindings are related to cursor motion, so it makes sense to allow them to work in isearch-mode. One way to do this: (define-key isearch-mode-map [(shift left)] (lambda (&optional n) (interactive "^p") (setq isearch-pre-move-point (point)) (call-interactively 'backward-char))) (define-key isearch-mode-map [(shift right)] (lambda (&optional n) (interactive "^p") (setq isearch-pre-move-point (point)) (call-interactively 'forward-char))) Or do you want to be able to put properties to allow a command, e.g.: (put 'backward-char 'isearch-move 'enabled) (put 'forward-char 'isearch-move 'enabled) with such patch diff --git a/lisp/isearch.el b/lisp/isearch.el index dcd119a517..6b0d9f03af 100644 --- a/lisp/isearch.el +++ b/lisp/isearch.el @@ -2871,7 +2871,11 @@ isearch-pre-command-hook (stringp (nth 1 (interactive-form this-command))) (string-match-p "^^" (nth 1 (interactive-form this-command)))))) (and (eq isearch-yank-on-move 'shift) - this-command-keys-shift-translated)) + (or (and this-command-keys-shift-translated + (symbolp this-command) + (not (eq (get this-command 'isearch-move) 'disabled))) + (and (symbolp this-command) + (eq (get this-command 'isearch-move) 'enabled))))) (setq this-command-keys-shift-translated nil) (setq isearch-pre-move-point (point))) ;; Append control characters to the search string I'm still not sure if this needed to be generalized more, and how far. For example, I think that shift-left and shift-right from org-mode should exit Isearch as well as windmove shift-keys should exit Isearch and move focus to another window. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 07 07:42:13 2018 Received: (at 15839) by debbugs.gnu.org; 7 Dec 2018 12:42:14 +0000 Received: from localhost ([127.0.0.1]:36350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVFSP-0001aL-M5 for submit@debbugs.gnu.org; Fri, 07 Dec 2018 07:42:13 -0500 Received: from mout.web.de ([212.227.15.14]:39915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVFSN-0001a6-Cl for 15839@debbugs.gnu.org; Fri, 07 Dec 2018 07:42:12 -0500 Received: from drachen.dragon ([88.67.73.131]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MXHoz-1h1LCe2EYH-00WEY9; Fri, 07 Dec 2018 13:42:01 +0100 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> <87o99y5kbp.fsf@mail.linkov.net> Date: Fri, 07 Dec 2018 13:42:00 +0100 In-Reply-To: <87o99y5kbp.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 07 Dec 2018 01:03:54 +0200") Message-ID: <87o99xbjaf.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:oaI6VtsCePGKFCnMBKMYpZhif3Nu7I3LP3HWI8j3iO7imz4kU5I /TAgRTuxR0g+rWjJxknM5K23jneEXLcrtqKq526XshiF6zPh2uc+83knmSB/Z0rnf4WxeHD G93+KPbViI3icoq+A/ZjJpgULPUB9tl6v9NEEdISQ7423E5zaJlprT/KALFkepXBcRKZh8r 5o0rRTZ6WfYbX/rqnBA7g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:RLdygYhZyQA=:xzBT3QQaiyuVQW91b2lxUH GBwQchOBTfzg19u/xFidS5Z21GzbsgmmE5vaQHYKtrjMvFuvpwf+ShRGtizfZ5eZP+1e3VckJ 6A4DaT7Pftf8Cu9uK4IN/WwhijbMmprNR1oj1gO3BhAyqHCP+nU6DrHRFelIcs53JGY+Dm973 xdLhm3/Lx6D01cmbFjjIJLHHjDPVmrUBeHNy+u2bU+OASZ4MpS4VY94HyYlzowcsKHwyqDSpi C7JFGBGsBH2ojPAiD3YFz0Q8T1d1G1vVPmmfpThQ0qB7YgIP8yTnOba80Nn2i/0BbkNFh7yAM FoWZvOnvcKeYAf5Mzm5LLv/HnmBOCwhbG6PRSaQhRZFSw7KvLM93oXDXRpgIfMHtqbpNlUUJq HsUdfHBOJY6WdDBBBouFnbC4TXYzhvdGnrD6+MxdxfJDyZ0mxJT78TPt74hfkWiFczhuAAnQV NcFiKXbi9MQMU2f6m1lAnoMHFQ9dCI2s7H81ziSCHjCio3g5hyJsRAssy4VVbjGMRcdKE+96l MJ53dWdTU5nCdeyMb7hoDXotH9nyFPXH45htKJUZnoVioH0SdIcvvCscpl6AaHFFgHi+AN2TC W3HHi8tc3YJL0DP4IddIYY5NeDBEY195w4DVsAmsQh0p0f2qgcXsys6th0QqqQv9LQ9nqzAaC JzVjc4vZtVherJ+4cs/8ua8lvHopVBhTA5An4eVZRhZL1W3CE4mt9maBV4s1rOMFj9Uy1IfYc Cj9mIUt4atqftpO62ScFv/HZ6ZyeOf7RLnHAs9jN/eXdz3enBSom5DQsmCuohTPIT4dk1GgNq QdRtwp7j+AItIUXsuG+xuBVU7+ZTaFsAAccihjFKC6dNVBbA1N+UGr88/KucnN9Nu6X7XtaFW Ztls79ViTts4T3xerjpoE84yLKpg5Vm2PaVJ8+vMa4Rr45RUqdQbN1tRxqBf4EH62+BANTuwr Z4M9txDLLFg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > + (or (and this-command-keys-shift-translated > + (symbolp this-command) > + (not (eq (get this-command 'isearch-move) 'disabled))) > + (and (symbolp this-command) > + (eq (get this-command 'isearch-move) 'enabled))))) Yes, that would probably be nice. > I'm still not sure if this needed to be generalized more, and how far. > For example, I think that shift-left and shift-right > from org-mode should exit Isearch as well as windmove shift-keys > should exit Isearch and move focus to another window. This isearch-yank-on-move -> 'shift thing is a difficult matter. I'm not sure any more if it's a good idea. It's confusing if I get a different behavior depending on the current major mode. As a user I would rather expect that the rule would be that Isearch would test any shift binding to see what the binding without shift is doing, and invoke that if it is a moving command. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 19:13:42 2018 Received: (at 15839) by debbugs.gnu.org; 9 Dec 2018 00:13:42 +0000 Received: from localhost ([127.0.0.1]:39030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVmj8-0001Dv-De for submit@debbugs.gnu.org; Sat, 08 Dec 2018 19:13:42 -0500 Received: from purple.birch.relay.mailchannels.net ([23.83.209.150]:58482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVmj5-0001Dk-SO for 15839@debbugs.gnu.org; Sat, 08 Dec 2018 19:13:41 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E60AF12379E; Sun, 9 Dec 2018 00:13:38 +0000 (UTC) Received: from pdx1-sub0-mail-a20.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 920D1123102; Sun, 9 Dec 2018 00:13:38 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a20.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sun, 09 Dec 2018 00:13:38 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Thread-Fearful: 55a328f305a39dd4_1544314418768_2969676438 X-MC-Loop-Signature: 1544314418768:2505998671 X-MC-Ingress-Time: 1544314418767 Received: from pdx1-sub0-mail-a20.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a20.g.dreamhost.com (Postfix) with ESMTP id 3B97580767; Sat, 8 Dec 2018 16:13:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=vsFj455pZ6jjqWI9J1SuK0+ZcTc=; b= g0qYsEK5RuE5eXt8rl7k1PzVrqt/z6YLmDN6iMjnexlHV7zanj314iCo480S2rvS TmVpMqzjp3EYT6rhn9gHP8FTUgOfNLE+5UsvG6Nv2asRyYsUgAJDaLo+Ci4jFzeo oaI9la0pbfjE8oGBnWZFQm4VZnTTDKgqSmNNzoJYPKw= Received: from mail.jurta.org (m91-129-103-7.cust.tele2.ee [91.129.103.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a20.g.dreamhost.com (Postfix) with ESMTPSA id CC1E380761; Sat, 8 Dec 2018 16:13:36 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a20 From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> <87o99y5kbp.fsf@mail.linkov.net> <87o99xbjaf.fsf@web.de> Date: Sun, 09 Dec 2018 01:38:10 +0200 In-Reply-To: <87o99xbjaf.fsf@web.de> (Michael Heerdegen's message of "Fri, 07 Dec 2018 13:42:00 +0100") Message-ID: <87k1kj1sh9.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudeguddgudekfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledruddtfedrjeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepmhhitghhrggvlhgphhgvvghruggvghgvnhesfigvsgdruggvnecuvehluhhsthgvrhfuihiivgepvd X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> I'm still not sure if this needed to be generalized more, and how far. >> For example, I think that shift-left and shift-right >> from org-mode should exit Isearch as well as windmove shift-keys >> should exit Isearch and move focus to another window. > > This isearch-yank-on-move -> 'shift thing is a difficult matter. I'm > not sure any more if it's a good idea. It's confusing if I get a > different behavior depending on the current major mode. As a user I > would rather expect that the rule would be that Isearch would test any > shift binding to see what the binding without shift is doing, and invoke > that if it is a moving command. This is what this-command-keys-shift-translated was intended to do together with ^ in interactive spec. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 08 20:13:29 2018 Received: (at 15839) by debbugs.gnu.org; 9 Dec 2018 01:13:30 +0000 Received: from localhost ([127.0.0.1]:39061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVnez-0002jR-K4 for submit@debbugs.gnu.org; Sat, 08 Dec 2018 20:13:29 -0500 Received: from mout.web.de ([212.227.15.3]:44985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gVnex-0002j7-NL for 15839@debbugs.gnu.org; Sat, 08 Dec 2018 20:13:28 -0500 Received: from drachen.dragon ([88.67.73.131]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MEVU9-1gh37k29sH-00Fltj; Sun, 09 Dec 2018 02:13:17 +0100 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> <87o99y5kbp.fsf@mail.linkov.net> <87o99xbjaf.fsf@web.de> <87k1kj1sh9.fsf@mail.linkov.net> Date: Sun, 09 Dec 2018 02:13:16 +0100 In-Reply-To: <87k1kj1sh9.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 09 Dec 2018 01:38:10 +0200") Message-ID: <8736r7a4er.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ImhsKXRh/GTMIZ7cKZSpfDrrcNjA8LkeviZNBRegWhGr8+r6Xdw 2uTULxF6bfy6pnOUCbOye8QrItxPr/hFwLQwAix/ltZcnKY/+bAhUkLt/6rdth3kYNMCkMx 4d9dqvKfz2+U+EVGMtJY4N//bJfVVldDTNyyzqND+uPE2KlgUbNpTQHxD6aoNKvStKGdpB2 4SAFV3ajS3HyRR5kyRlNw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:iIUXKYzfo/E=:lEspvuqwVUbaeXZvtXkdWl rRNVboXBRAUqqfF9AaBCYU7pO76eoPuNx4SbG5z+2P8AexDFhhvs1QWeWBwGVOkjuIceLuI2I yJYnr4pqtI8xC4F2h/M8NRm9sqc091KGss5w4Xoz7cSVsK9KbqvX+Bhi6+xpZhFOBbkS8JCqi zZG5ksl8uck1Kjby7bR0D7Q9sG4271yHhM7v3K11TH9M1wGq8phR/vad+CDo33TztccNovAl6 Sz9Uzq/Xuw+q1hZMXohkttjTAYymUV+XVgfQEGKZO+fu3W+g4JJ+sD1lguWGjBzM8ckzxmYe+ 3gM+nuOIu278XDqQ4TZWjPbXNgG6NHVBy9KBtSIPqYNG7Go4z+BClfb/dlXJlacQPrvYPCEPi MY5EOMAbAjQWn41nhzp+CZO59VPzI4IWL/BkmrHzkxa0J3kpqzhJYpYP/F2zvdGWWGy1Cny7v eMB0RYlzBWnhACldX3ZFt7tuLvLrxou/VX0ocaJD5hDlhZc57kcFpWyU2EtY0/7Rq+D/yPZ2I vLeZ72eWdspxgzxuoYCftU6eZWSQj91TEb1DrBrdWtdJ/d1rxnbi6TQnXccXiE6JHvVus7njT 3sjdbugeo0JCdTK361fm2hJCNIxEZHQRNfoxLqPECHwqsXSryEwrbzQMLqj2vMDBiFx6rmGrZ Sp0tHz7DZO/KL9P0OdSQfTYJHlDEZhUMq9Z/rSRTJwz0qfx/PgGH0R+eNKrz+3MCd4tPU2Gsp SMCnHgXnbwbBLRpNIOmffGIN9RrjbHsxOMiOa+OxFnhAl2j1B/Bv8P2dvY+ivGnHXbx8/N5gh Xw6ppJ3Ood59OqondjSydwLPeTxO1X3Uvxds/1kzrYG+uCD/E8Fpos35aRYM5uS3WKUo38sMb NbxFV+zfa5K/vAwAS1eNH3vCWYflPTB3pFUN2OZ9Jj2cV+G2Jp+AxY7U5fBl2S8rdK/8Rncof fi93hZZwxYg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > > This isearch-yank-on-move -> 'shift thing is a difficult matter. > > I'm not sure any more if it's a good idea. It's confusing if I get > > a different behavior depending on the current major mode. As a user > > I would rather expect that the rule would be that Isearch would test > > any shift binding to see what the binding without shift is doing, > > and invoke that if it is a moving command. > > This is what this-command-keys-shift-translated was intended to do > together with ^ in interactive spec. I don't follow. If a shifted key, like shift-left, is bound, there is no shift translation happening. So your code doesn't kick in because your condition isn't met, instead of calling the binding of the unshifted key (left in my example). Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 19:37:30 2018 Received: (at 15839) by debbugs.gnu.org; 10 Dec 2018 00:37:31 +0000 Received: from localhost ([127.0.0.1]:40467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW9Zi-0004cY-Ju for submit@debbugs.gnu.org; Sun, 09 Dec 2018 19:37:30 -0500 Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:54910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW9Zg-0004cD-SO for 15839@debbugs.gnu.org; Sun, 09 Dec 2018 19:37:29 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 458705C6A7F; Mon, 10 Dec 2018 00:37:27 +0000 (UTC) Received: from pdx1-sub0-mail-a47.g.dreamhost.com (unknown [100.96.36.160]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id ECA535C5B26; Mon, 10 Dec 2018 00:37:26 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a47.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Mon, 10 Dec 2018 00:37:27 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-White-Shoe: 0ed7668f76fd80c1_1544402247111_3364455303 X-MC-Loop-Signature: 1544402247111:3807311957 X-MC-Ingress-Time: 1544402247111 Received: from pdx1-sub0-mail-a47.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a47.g.dreamhost.com (Postfix) with ESMTP id 9620C805B4; Sun, 9 Dec 2018 16:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=Ip2Ma8fi4yQ9shi9UFGvprjAcg8=; b= l4TX+hOhrFtqdpoX6yNORZoPIoVHl5PMKI4nAgmo1BSYVQj9f+0ak9PLWXp7RM5r VKXUBzdGB1XLEEpJvOrHNZdUTAJsM5yaa5Ez+x80Lzj5pbYXmWk75tWbhIFOjA9x zdT0B0ammy04iiNHs/mB0sZf41tRfhlXfX+OcAJgskY= Received: from mail.jurta.org (m91-129-96-177.cust.tele2.ee [91.129.96.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a47.g.dreamhost.com (Postfix) with ESMTPSA id 85D6C805AE; Sun, 9 Dec 2018 16:37:23 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a47 From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> <87o99y5kbp.fsf@mail.linkov.net> <87o99xbjaf.fsf@web.de> <87k1kj1sh9.fsf@mail.linkov.net> <8736r7a4er.fsf@web.de> Date: Mon, 10 Dec 2018 02:21:51 +0200 In-Reply-To: <8736r7a4er.fsf@web.de> (Michael Heerdegen's message of "Sun, 09 Dec 2018 02:13:16 +0100") Message-ID: <87efaqi5mw.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudeggedgvdeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrudejjeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrudejjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvgenucevlhhushhtvghrufhiiigvpedu X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> > This isearch-yank-on-move -> 'shift thing is a difficult matter. >> > I'm not sure any more if it's a good idea. It's confusing if I get >> > a different behavior depending on the current major mode. As a user >> > I would rather expect that the rule would be that Isearch would test >> > any shift binding to see what the binding without shift is doing, >> > and invoke that if it is a moving command. >> >> This is what this-command-keys-shift-translated was intended to do >> together with ^ in interactive spec. > > I don't follow. If a shifted key, like shift-left, is bound, there is > no shift translation happening. So your code doesn't kick in because > your condition isn't met, instead of calling the binding of the > unshifted key (left in my example). The problem is that some commands that are called with shift-key are unsuitable for isearch, e.g. S-M-< (beginning-of-buffer) should not put all text from the beginning of the buffer to the search string. It seems we can't detect such commands automatically, so one way to support a command is to put a property with the patch that I sent recently, e.g. (put 'backward-char 'isearch-move 'enabled) (put 'forward-char 'isearch-move 'enabled) From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 09 19:58:29 2018 Received: (at 15839) by debbugs.gnu.org; 10 Dec 2018 00:58:29 +0000 Received: from localhost ([127.0.0.1]:40512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW9u1-0005Bk-Ks for submit@debbugs.gnu.org; Sun, 09 Dec 2018 19:58:29 -0500 Received: from mout.web.de ([212.227.15.4]:42545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gW9tz-0005BW-JP for 15839@debbugs.gnu.org; Sun, 09 Dec 2018 19:58:28 -0500 Received: from drachen.dragon ([88.67.73.131]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M6ml2-1hQAs20bcC-00wSZY; Mon, 10 Dec 2018 01:58:18 +0100 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> <87o99y5kbp.fsf@mail.linkov.net> <87o99xbjaf.fsf@web.de> <87k1kj1sh9.fsf@mail.linkov.net> <8736r7a4er.fsf@web.de> <87efaqi5mw.fsf@mail.linkov.net> Date: Mon, 10 Dec 2018 01:58:15 +0100 In-Reply-To: <87efaqi5mw.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 10 Dec 2018 02:21:51 +0200") Message-ID: <87in025haw.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Aj4Jp4/yNFhb2hsvm4o4IxLprEOh6K7esmXJAThyiuKDrU9Flzn dfTVv4lyQYABbzUsozi96FQCXisdtHbNWJ8svcIpposGAmAgd9hrZOO/UATdOvNzvAakluW m+xCbi7QXTswEtEh+vN2UykRfrw2EbMSOuhp5o94V1X8z8WlE3Skb4v37wTELaOyUIx5vFz Y1vXqwshJwpop9oMrJNiQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XuDWZkdr/cg=:bL5Z6yMsN4VQfYtqBcM4qi i4SWBTOWwDt2ypaP5dgthBRMYcl3lIieWOAxY4tYuJfDXcok2vd9R+VelsAE52+qjke/2fHNc g6DRMIbNncaYuyDOsa6bUANvH4/Bwo+7ddLsXVbJPnbO2jPrQ7Vkeof4ZB60N1p7eGOffyrjs F1nAky57xvZjLPVOn9E35GdJatGgyEJEo4rA3VIu7GLJNa+s+IiJLFlB4gau3Hd/pnSG1IWt4 7FmBacZ3/f6QFcpZ/uTWIpABh/K1xX7IiM01Cpeiy0KMgl2m/Z9GwkR6iQRYoY0dzwdgN8GER ps81NRoUkb1doAgvrqteJnhjk4kUPGY7Qn8rMHI/8MbKO+mvGg/bAbRagYb5hUNpL10hqU0ex vEKh4dlSVijvVhU/49x3w5VAnq/ICeFnI584AZFVlbIwZqyrdxuN4qhJfn92rJ8+XDsmt03XO /ENxoDVx0HUEvbgaVqUl6bAlWnPRD+Rm5FB4IO6vpS2BongqQPgufWWxH4LCotkxhKkKC3kES /Ug3WMTVbyYVuVJKl4uktrwVj15uTpwIiYYiTA1KjEZBI8fcueosWxnVDxOvi+aaRA0KmNFWa JaGUbs+IAjMbQdm0pyYZG263idZVv3mxYCqJipApFsH1A55d6Vw6S+mBn7ONDfhQ8LTTexwF2 KNLvbKFmzSHY7b+ER23sPFPAfkBymyZVzE1Q317W3f5c2UAU/Sr/o7eiPTZSpyalJIr/6DRi/ OV75YblYQYzWp/gc4F8w57e3+Z+8OfmGjbBerYcX4PXgZxt9Xv7F/ij0m5BIwh9tRaAnbCuip QhId6Ef1V/VuSJD7CMMvpaLJBD/FqB/v5megdAXzDEmedlJiyDYm2LrCGYQetKwadvygMFxMJ 1HLi4LHTTDh9hTaZGcUVoZYWHUnvNANVxb4vu5W7mY3hmP5Z0yLINW4IS4y8+IUf22lJzDzm+ 3hwyxtwgl5Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > The problem is that some commands that are called with shift-key > are unsuitable for isearch, e.g. S-M-< (beginning-of-buffer) > should not put all text from the beginning of the buffer > to the search string. > > It seems we can't detect such commands automatically, > so one way to support a command is to put a property > with the patch that I sent recently, e.g. > > (put 'backward-char 'isearch-move 'enabled) > (put 'forward-char 'isearch-move 'enabled) That sounds ok to me. It would even give the user a way to configure which commands are ok. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 10 19:37:43 2018 Received: (at 15839) by debbugs.gnu.org; 11 Dec 2018 00:37:43 +0000 Received: from localhost ([127.0.0.1]:42338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWW3S-0006lH-Ec for submit@debbugs.gnu.org; Mon, 10 Dec 2018 19:37:42 -0500 Received: from cichlid.maple.relay.mailchannels.net ([23.83.214.36]:20261) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWW3Q-0006l6-R0; Mon, 10 Dec 2018 19:37:41 -0500 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 4314C283066; Tue, 11 Dec 2018 00:37:39 +0000 (UTC) Received: from pdx1-sub0-mail-a60.g.dreamhost.com (unknown [100.96.19.78]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id EEFA52827ED; Tue, 11 Dec 2018 00:37:38 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Received: from pdx1-sub0-mail-a60.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Tue, 11 Dec 2018 00:37:39 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Inform-Wiry: 447d5da73a03cf06_1544488659128_3760224037 X-MC-Loop-Signature: 1544488659128:4064131639 X-MC-Ingress-Time: 1544488659127 Received: from pdx1-sub0-mail-a60.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a60.g.dreamhost.com (Postfix) with ESMTP id 888FE805FA; Mon, 10 Dec 2018 16:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=y5fCkn1ZBLxEd/WBPrf1HupMdDQ=; b= OSO6flvJ71Gn4GkuCUNSASVpYOeJPcfGzfs/XVjfHdVitvyqdBNEpqm108rH1Y85 nEnp6ogTJapxLR9CrWPTuIm+ZXKFCaTDKLmfnoxGPlDCojZa7TRBiGOVAR/qfBKe AIwbzUbxgO9FW09M3LuI+IQ24LZeQtpfEwR1ZfSsRlo= Received: from mail.jurta.org (m91-129-96-177.cust.tele2.ee [91.129.96.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a60.g.dreamhost.com (Postfix) with ESMTPSA id C5851805F6; Mon, 10 Dec 2018 16:37:36 -0800 (PST) X-DH-BACKEND: pdx1-sub0-mail-a60 From: Juri Linkov To: Michael Heerdegen Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Organization: LINKOV.NET References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> <87o99y5kbp.fsf@mail.linkov.net> <87o99xbjaf.fsf@web.de> <87k1kj1sh9.fsf@mail.linkov.net> <8736r7a4er.fsf@web.de> <87efaqi5mw.fsf@mail.linkov.net> <87in025haw.fsf@web.de> Date: Tue, 11 Dec 2018 02:37:13 +0200 In-Reply-To: <87in025haw.fsf@web.de> (Michael Heerdegen's message of "Mon, 10 Dec 2018 01:58:15 +0100") Message-ID: <87zhtcj3uu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudegiedgvdegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrdeliedrudejjeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrudejjedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehmihgthhgrvghlpghhvggvrhguvghgvghnseifvggsrdguvgenucevlhhushhtvghrufhiiigvpedt X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 15839 fixed close 15839 27.1 thanks >> It seems we can't detect such commands automatically, >> so one way to support a command is to put a property >> with the patch that I sent recently, e.g. >> >> (put 'backward-char 'isearch-move 'enabled) >> (put 'forward-char 'isearch-move 'enabled) > > That sounds ok to me. It would even give the user a way to configure > which commands are ok. Pushed to master. Please try. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 11 13:22:54 2018 Received: (at 15839) by debbugs.gnu.org; 11 Dec 2018 18:22:54 +0000 Received: from localhost ([127.0.0.1]:44176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWmgH-0002zO-To for submit@debbugs.gnu.org; Tue, 11 Dec 2018 13:22:54 -0500 Received: from mout.web.de ([212.227.15.14]:50421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWmgF-0002zA-O0 for 15839@debbugs.gnu.org; Tue, 11 Dec 2018 13:22:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1544552561; bh=urggZM0MYIO8qTbjRMccW19nPL7ZgdIqQCTkDT+TWIw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ko8fky/j1R8iGmR8FZ+cqoajJeFT1g0S94+88Hmml9EIt5ujOEZR+dsd/eWzCw8wi PR2y95A5EfiTXAlZ9PM3HtGBPyV164R0l28GMpp3z9HSGOj30Lr+iKEeVs4MmIbu1n oiFxAt2+UyOsFypqvclF9HUcVtfSZPW+zWM0BMeM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([88.67.73.131]) by smtp.web.de (mrweb002 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LdEif-1hFEIa0j7x-00iWeW; Tue, 11 Dec 2018 19:22:41 +0100 From: Michael Heerdegen To: Juri Linkov Subject: Re: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <87zhtk164k.fsf@web.de> <87woon33bp.fsf@mail.linkov.net> <87mupij1g0.fsf@web.de> <87o99y5kbp.fsf@mail.linkov.net> <87o99xbjaf.fsf@web.de> <87k1kj1sh9.fsf@mail.linkov.net> <8736r7a4er.fsf@web.de> <87efaqi5mw.fsf@mail.linkov.net> <87in025haw.fsf@web.de> <87zhtcj3uu.fsf@mail.linkov.net> Date: Tue, 11 Dec 2018 19:22:39 +0100 In-Reply-To: <87zhtcj3uu.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 11 Dec 2018 02:37:13 +0200") Message-ID: <87ftv3ly8g.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:2d97CpZPePdGF8NiSxzxS5XB4PSt9xYjA0oK3KMn3I0f70H8kY/ fR/9jRhqlmJ0KgIltXMXMIQtlDS8rOA7SWtD9GNfPk9TVvJT4z1TDU4B+73b/DA2c99mpsM nhYu1dAOofo1Xlx03WzoE2eenns0XT3zfCveyuzsrd85CQEQCkJZd1SIrh0NJhXg5Ayp9Fo mPQxszRtPEO7bHq7kW98w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:gCQOtRFMe+Y=:27UDP1UI6wFKuPNJ9xj7Yd qt3PgyxoS298bjSnwwdKBtIN+HI1O8X+UeHr51kc58EWl7TvJTosCaAP5Wm1mBjBtSmxRNaQ0 f11Ji+x2gX5wGfoLYCO/Hz8Ft7E+KxO5QLsbfjKLqD+e9h5paW4jqHlau27KtGHuo2HTbx36B 60G2Tfdb8UHd7HKMfqpk00Il1D2HkKIt3jaFlFsXHftrtJVRDCKyAcubFOHavqNoBW40YNuPU s9NeIAyCULzrIzOmwQ+wCEF7c3FY7c52u9UAvhC5KsxYkNTk3IU3Xv6UDpIGAX1jGu+iI2S1r 5SUE1RkKw43ZLtV9agb3jjfflVIkymqZSe5b3sT7gqF4/Bj6IJ9zpA3uK5XoHd/g80qYACcr8 ph4jWQzMeM93D6YJxzQqh17kUr9xoZlIuyluM2+IGJFf17DSh38uXCqYwUKGlKqlo1E0qD7F9 dH4YFnP4f2BkVVmMHndh9LPGpUDSt3WRoTonXmrX1WfN+rjmM+e62ttf4Skp1Es01kNW+KQS1 kOM3hWLgxLqpR5ZqiHDoVf/RfDmkWuacfDNcNVhAKw6bgp5mwH2Chz2IdN3BXQ7eT1tEMlxjJ /gP6T3lnjdeL8rcxZY100LGI+ijk5mzM0uLUVruvSDFxnNw8DO7HLaaoeEwmV2E62bKboUOuR wdPT0VNZLt3Hie0AgMolLQwAT0Jo/++AmJ8XZDYiSH3yN45myIkjGxVg7h+rOmQv/jyh1b1Hg FjYUumRiHKVNzkc1VfpuryDgFCKiEuPiueVdFgBZncAtVCAX60WJiRnBZpSNyDSGFSr3tLdiO FLOiRzIglzOgPwXJQkgVahNVQuqrcHhwdPjFgwcCiWeUKCwWezmLN8xnz+meia5eGvoub/BV1 PSVWTB554ZHemokbLAugxeNwZ9wR0wp3U7gDJaJSSNeDHyrwKd0s3sxSeLy65Edl6P6HCucVv hkxzkuC174A== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15839 Cc: 15839@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Juri Linkov writes: > Pushed to master. Please try. Works for me - thanks! Michael. From unknown Mon Jun 16 23:44:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 Jan 2019 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator