From unknown Thu Jun 19 16:22:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15835: [PATCH] chmod: change in the inode's st_ctime Resent-From: Guilherme de Almeida Suckevicz Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 08 Nov 2013 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15835 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 15835@debbugs.gnu.org X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138392930726250 (code B ref -1); Fri, 08 Nov 2013 16:49:01 +0000 Received: (at submit) by debbugs.gnu.org; 8 Nov 2013 16:48:27 +0000 Received: from localhost ([127.0.0.1]:41770 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VepEQ-0006pF-U1 for submit@debbugs.gnu.org; Fri, 08 Nov 2013 11:48:27 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58684) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Veln1-00017T-D3 for submit@debbugs.gnu.org; Fri, 08 Nov 2013 08:07:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Velmr-0007fa-6c for submit@debbugs.gnu.org; Fri, 08 Nov 2013 08:07:49 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:44060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Velmr-0007fW-3d for submit@debbugs.gnu.org; Fri, 08 Nov 2013 08:07:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Velml-0000iD-UN for bug-coreutils@gnu.org; Fri, 08 Nov 2013 08:07:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Velmh-0007eO-0D for bug-coreutils@gnu.org; Fri, 08 Nov 2013 08:07:39 -0500 Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:33987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Velmg-0007eC-NK for bug-coreutils@gnu.org; Fri, 08 Nov 2013 08:07:34 -0500 Received: by mail-lb0-f178.google.com with SMTP id l4so1459724lbv.9 for ; Fri, 08 Nov 2013 05:07:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=pl1NCeQXducuQOHKhVZnlH16cW03zceO0aLE7++fXrA=; b=hZiwehTP/N/dvzqIUlL9eSMte1ag+F8UXsYqu85XnziW60Smvv8eJHBVAC5C7z69/5 QeuD0cS5AM0jU3SbjubKxiNC3i8vwEsGth51vzfEyOQgSLhV5ADbdH9BzMAc+Gpht3ip TimrqWdGf6R/tW4UZwOYzmNTOsm+5b2gXjY8OQXImCJ9LGMGmMBeH6NsdUyzKrDiCXXo YFyPiAK7ArYVs6L2GnYJzs3a2W0xqHqkInLJaorwQSdP5Ih9mR3uKg2u+DN7Qgtyxvwm pt8dvajoOWhv/5BCRzSYivaxstXndwRyTEwmFW2ock0SAyOMzoWLFOLGCLAGs4hrfnzK VlWA== MIME-Version: 1.0 X-Received: by 10.152.3.42 with SMTP id 10mr11059861laz.22.1383916052909; Fri, 08 Nov 2013 05:07:32 -0800 (PST) Received: by 10.112.104.40 with HTTP; Fri, 8 Nov 2013 05:07:32 -0800 (PST) Date: Fri, 8 Nov 2013 11:07:32 -0200 Message-ID: From: Guilherme de Almeida Suckevicz Content-Type: multipart/alternative; boundary=089e013d14b2bb937904eaaa1089 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Fri, 08 Nov 2013 11:48:25 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e013d14b2bb937904eaaa1089 Content-Type: text/plain; charset=ISO-8859-1 Hello, I saw this issue on TODO file: "Modify chmod so that it does not change an inode's st_ctime when the selected operation would have no other effect. First suggested by Hans Ecke in http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/2920 Discussed more recently on ." I made a patch just to chmod, for now, to this issue and I would like to ask if it need something else or if you can make some comments about this patch, I really appreciate. --- src/chmod.c 2013-11-08 10:19:48.608214043 -0200 +++ src/chmod-orig.c 2013-11-08 10:16:30.378505318 -0200 @@ -266,7 +266,7 @@ new_mode = mode_adjust (old_mode, S_ISDIR (old_mode) != 0, umask_value, change, NULL); - if (mode_changed (file, old_mode, new_mode) && ! S_ISLNK (old_mode)) + if (! S_ISLNK (old_mode)) { if (chmodat (fts->fts_cwd_fd, file, new_mode) == 0) chmod_succeeded = true; I really thank you, Guilherme Almeida Suckevicz. --089e013d14b2bb937904eaaa1089 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hello,

I saw this issue on TODO file:

"= Modify chmod so that it does not change an inode's st_ctime
=A0 when= the selected operation would have no other effect.
=A0 First suggested = by Hans Ecke <http://hans.ecke.ws>= ; in
=A0=A0=A0 http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/2920
=A0= Discussed more recently on <h= ttp://bugs.debian.org/497514>."

I made a patch just to chmod, for now, to this issue and I would liketo ask if it need something else or if you can make some comments aboutthis patch, I really appreciate.


--- src/chmod.c=A0=A0=A0 2013= -11-08 10:19:48.608214043 -0200
+++ src/chmod-orig.c=A0=A0=A0 2013-11-08 10:16:30.378505318 -0200
@@ -26= 6,7 +266,7 @@
=A0=A0=A0=A0=A0=A0 new_mode =3D mode_adjust (old_mode, S_I= SDIR (old_mode) !=3D 0, umask_value,
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 change, NULL);=A0
-=A0=A0=A0=A0=A0 if (mode_changed (file, old_mode, new_mode) && ! S= _ISLNK (old_mode))
+=A0=A0=A0=A0=A0 if (! S_ISLNK (old_mode))
=A0=A0= =A0=A0=A0=A0=A0=A0 {
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (chmodat (fts->= ;fts_cwd_fd, file, new_mode) =3D=3D 0)
=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0 chmod_succeeded =3D true;


I really thank you,
Guilherme Almeida Suckevicz.
--089e013d14b2bb937904eaaa1089-- From unknown Thu Jun 19 16:22:52 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15835: [PATCH] chmod: change in the inode's st_ctime Resent-From: =?UTF-8?Q?P=C3=A1draig?= Brady Original-Sender: "Debbugs-submit" Resent-CC: bug-coreutils@gnu.org Resent-Date: Fri, 08 Nov 2013 17:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15835 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: Guilherme de Almeida Suckevicz Cc: 15835@debbugs.gnu.org Received: via spool by 15835-submit@debbugs.gnu.org id=B15835.138393024727852 (code B ref 15835); Fri, 08 Nov 2013 17:05:01 +0000 Received: (at 15835) by debbugs.gnu.org; 8 Nov 2013 17:04:07 +0000 Received: from localhost ([127.0.0.1]:41807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VepTa-0007F9-P9 for submit@debbugs.gnu.org; Fri, 08 Nov 2013 12:04:07 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:30892) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VepTZ-0007Ea-8P for 15835@debbugs.gnu.org; Fri, 08 Nov 2013 12:04:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAEkZfVJtTkxL/2dsb2JhbAANTYM/v2aBRoMZAQEBBAECJAsBRhALDQsJFg8JAwIBAgEWLwYNAQcBAYgCCKlMk0CPZweEMAOVQIN+hTWDYYIRiFs Received: from unknown (HELO [192.168.1.79]) ([109.78.76.75]) by mail2.vodafone.ie with ESMTP; 08 Nov 2013 17:03:58 +0000 Message-ID: <527D197D.1070407@draigBrady.com> Date: Fri, 08 Nov 2013 17:03:57 +0000 From: =?UTF-8?Q?P=C3=A1draig?= Brady User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tag 15835 wontfix close 15835 stop On 11/08/2013 01:07 PM, Guilherme de Almeida Suckevicz wrote: > Hello, > > I saw this issue on TODO file: > > "Modify chmod so that it does not change an inode's st_ctime > when the selected operation would have no other effect. > First suggested by Hans Ecke in > http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/2920 > Discussed more recently on ." > > I made a patch just to chmod, for now, to this issue and I would like > to ask if it need something else or if you can make some comments about > this patch, I really appreciate. > > > --- src/chmod.c 2013-11-08 10:19:48.608214043 -0200 > +++ src/chmod-orig.c 2013-11-08 10:16:30.378505318 -0200 > @@ -266,7 +266,7 @@ > new_mode = mode_adjust (old_mode, S_ISDIR (old_mode) != 0, > umask_value, > change, NULL); > > - if (mode_changed (file, old_mode, new_mode) && ! S_ISLNK (old_mode)) > + if (! S_ISLNK (old_mode)) > { > if (chmodat (fts->fts_cwd_fd, file, new_mode) == 0) > chmod_succeeded = true; This has been discussed on and off, most recently at: http://lists.gnu.org/archive/html/coreutils/2013-10/msg00028.html The current thought is that it would be best done in the kernel, as in userspace we haven't visibility of side effects of the call. thanks, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 14:04:53 2013 Received: (at control) by debbugs.gnu.org; 8 Nov 2013 19:04:53 +0000 Received: from localhost ([127.0.0.1]:42029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VerMS-00031w-Kv for submit@debbugs.gnu.org; Fri, 08 Nov 2013 14:04:53 -0500 Received: from mail2.vodafone.ie ([213.233.128.44]:35143) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VerMQ-00031h-UG for control@debbugs.gnu.org; Fri, 08 Nov 2013 14:04:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAEw1fVJtTkxL/2dsb2JhbAANTIM/v2mBRoMZAQEBBAECJAsBVhgLCRYPCQMCAQIBFi8TCAEBiAIIqXSTPY9uFoQaA5VAg36FNYNhghGIWw Received: from unknown (HELO [192.168.1.79]) ([109.78.76.75]) by mail2.vodafone.ie with ESMTP; 08 Nov 2013 19:04:44 +0000 Message-ID: <527D35CC.3010707@draigBrady.com> Date: Fri, 08 Nov 2013 19:04:44 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: bug#15835: [PATCH] chmod: change in the inode's st_ctime References: In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tag 15835 wontfix close 15835 stop On 11/08/2013 01:07 PM, Guilherme de Almeida Suckevicz wrote: > Hello, > > I saw this issue on TODO file: > > "Modify chmod so that it does not change an inode's st_ctime > when the selected operation would have no other effect. > First suggested by Hans Ecke in > http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/2920 > Discussed more recently on ." > > I made a patch just to chmod, for now, to this issue and I would like > to ask if it need something else or if you can make some comments about > this patch, I really appreciate. > > > --- src/chmod.c 2013-11-08 10:19:48.608214043 -0200 > +++ src/chmod-orig.c 2013-11-08 10:16:30.378505318 -0200 > @@ -266,7 +266,7 @@ > new_mode = mode_adjust (old_mode, S_ISDIR (old_mode) != 0, > umask_value, > change, NULL); > > - if (mode_changed (file, old_mode, new_mode) && ! S_ISLNK (old_mode)) > + if (! S_ISLNK (old_mode)) > { > if (chmodat (fts->fts_cwd_fd, file, new_mode) == 0) > chmod_succeeded = true; This has been discussed on and off, most recently at: http://lists.gnu.org/archive/html/coreutils/2013-10/msg00028.html The current thought is that it would be best done in the kernel, as in userspace we haven't visibility of side effects of the call. thanks, Pádraig.