From unknown Mon Sep 08 15:20:52 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15818 <15818@debbugs.gnu.org> To: bug#15818 <15818@debbugs.gnu.org> Subject: Status: src/dfa.c: *MALLOC comment block: Clarify comment wording Reply-To: bug#15818 <15818@debbugs.gnu.org> Date: Mon, 08 Sep 2025 22:20:52 +0000 retitle 15818 src/dfa.c: *MALLOC comment block: Clarify comment wording reassign 15818 grep submitter 15818 behoffski severity 15818 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 22:20:52 2013 Received: (at submit) by debbugs.gnu.org; 6 Nov 2013 03:20:52 +0000 Received: from localhost ([127.0.0.1]:36427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdtfo-0006Y6-72 for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41530) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdtfm-0006Xl-AP for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdtfg-0005zr-55 for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:45 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdtfg-0005zn-1v for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdtfe-0002wP-Oo for bug-grep@gnu.org; Tue, 05 Nov 2013 22:20:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vdtfc-0005yG-96 for bug-grep@gnu.org; Tue, 05 Nov 2013 22:20:42 -0500 Received: from ipmail06.adl6.internode.on.net ([2001:44b8:8060:ff02:300:1:6:6]:28607) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vdtfb-0005xG-Nz for bug-grep@gnu.org; Tue, 05 Nov 2013 22:20:40 -0500 Received: from ppp121-45-64-228.lns20.adl6.internode.on.net (HELO [192.168.1.1]) ([121.45.64.228]) by ipmail06.adl6.internode.on.net with ESMTP; 06 Nov 2013 13:50:31 +1030 Message-ID: <5279B57C.7000202@grouse.com.au> Date: Wed, 06 Nov 2013 13:50:28 +1030 From: behoffski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130911 Thunderbird/17.0.9 MIME-Version: 1.0 To: bug-grep@gnu.org Subject: src/dfa.c: *MALLOC comment block: Clarify comment wording Content-Type: multipart/mixed; boundary="------------010009030909060201070509" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is a multi-part message in MIME format. --------------010009030909060201070509 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit G'day, Attached is a patch clarifying the wording in a comment block in dfa.c, relating to the XNMALLOC/XCALLOC/CALLOC/MALLOC/REALLOC preprocessor function definitions. Change is in comment text only; no functional changes. cheers, behoffski (Brenton Hoff) Programmer, Grouse Software --------------010009030909060201070509 Content-Type: text/x-diff; name="x-alloc.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="x-alloc.patch" diff --git a/src/dfa.c b/src/dfa.c index 92c410e..2063e90 100644 --- a/src/dfa.c +++ b/src/dfa.c @@ -433,7 +433,7 @@ static void dfamust (struct dfa *dfa); static void regexp (void); /* These two macros are identical to the ones in gnulib's xalloc.h, - except that they not to case the result to "(t *)", and thus may + except that they don't cast the result to "(t *)", and thus may be used via type-free CALLOC and MALLOC macros. */ #undef XNMALLOC #undef XCALLOC --------------010009030909060201070509-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 20:43:41 2013 Received: (at 15818) by debbugs.gnu.org; 26 Dec 2013 01:43:41 +0000 Received: from localhost ([127.0.0.1]:42262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvzzB-0001Eq-9T for submit@debbugs.gnu.org; Wed, 25 Dec 2013 20:43:41 -0500 Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:59461) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvzz7-0001Ea-Eu for 15818@debbugs.gnu.org; Wed, 25 Dec 2013 20:43:38 -0500 Received: from ppp118-210-7-38.lns20.adl2.internode.on.net (HELO [192.168.1.1]) ([118.210.7.38]) by ipmail05.adl6.internode.on.net with ESMTP; 26 Dec 2013 12:13:34 +1030 Message-ID: <52BB89C6.9070004@grouse.com.au> Date: Thu, 26 Dec 2013 12:13:34 +1030 From: behoffski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: 15818@debbugs.gnu.org Subject: Re: bug#15818: src/dfa.c: *MALLOC comment block: Clarify comment wording References: <5279B57C.7000202@grouse.com.au> In-Reply-To: <5279B57C.7000202@grouse.com.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15818 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 11/06/13 13:50, behoffski wrote: > G'day, > > Attached is a patch clarifying the wording in a comment block in > dfa.c, relating to the XNMALLOC/XCALLOC/CALLOC/MALLOC/REALLOC > preprocessor function definitions. Change is in comment text only; > no functional changes. > > cheers, > > behoffski (Brenton Hoff) > Programmer, Grouse Software (Patch text included inline here:) ------------------ diff --git a/src/dfa.c b/src/dfa.c index 92c410e..2063e90 100644 --- a/src/dfa.c +++ b/src/dfa.c @@ -433,7 +433,7 @@ static void dfamust (struct dfa *dfa); static void regexp (void); /* These two macros are identical to the ones in gnulib's xalloc.h, - except that they not to case the result to "(t *)", and thus may + except that they don't cast the result to "(t *)", and thus may be used via type-free CALLOC and MALLOC macros. */ #undef XNMALLOC #undef XCALLOC ------------------ Just a reminder that I've had no feedback on this bug, and it's small enough to be included in the upcoming 2.15 release. A number of factors in my life have been really berserk recently (including requiring a total work machine rebuild, still partially in progress), so I haven't checked that the patch line numbering is still valid. cheers, behoffski (Brenton Hoff) Programmer, Grouse Software From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 21:03:48 2013 Received: (at 15818-done) by debbugs.gnu.org; 26 Dec 2013 02:03:48 +0000 Received: from localhost ([127.0.0.1]:42281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vw0Ie-0001rF-7i for submit@debbugs.gnu.org; Wed, 25 Dec 2013 21:03:48 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:52088) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vw0Ic-0001r2-Ce for 15818-done@debbugs.gnu.org; Wed, 25 Dec 2013 21:03:46 -0500 Received: by mail-pd0-f177.google.com with SMTP id q10so7512523pdj.36 for <15818-done@debbugs.gnu.org>; Wed, 25 Dec 2013 18:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=/HLW1RAk98z7IlnMX0Gt4S8Rlyhuo0Zuy0C3XOX0yyU=; b=SAzMNbQEHedbqYVEvc9vzchjcilKwWfOSJ3C3fyrDX1RcHTcv5gmnCnbaK+B0IhHNf 7WmdbgYndtealDO/xSCXeijaw2XREVQ3l0ljpnRd2TOhJ5hl+fXGlmJVlsgL1HVxdDT/ LW8ZPpIuL8Wvol0SglzBr9juxIkqRvEYvx0LzID+17tiUak69QevQQvhcxkoazsATVJ7 5e+dwr5zfAPPjopbHyS1oKh7yfw6XxE6X3YzjIdJKGQ7pZnBMvgO7/u6AH0BhV3dIwOC /0kTdqzEUu5kNhvZBD7rg+Wg7dDIHxQC1IoDaGInp0KnjPh5U6QZuHAf9EHtMq2M/fmW eV2A== X-Received: by 10.68.243.99 with SMTP id wx3mr41017995pbc.29.1388023425261; Wed, 25 Dec 2013 18:03:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Wed, 25 Dec 2013 18:03:25 -0800 (PST) In-Reply-To: <52BB89C6.9070004@grouse.com.au> References: <5279B57C.7000202@grouse.com.au> <52BB89C6.9070004@grouse.com.au> From: Jim Meyering Date: Wed, 25 Dec 2013 18:03:25 -0800 X-Google-Sender-Auth: -ar5-Y54BrGSlVVmCXvytbarLAI Message-ID: Subject: Re: bug#15818: src/dfa.c: *MALLOC comment block: Clarify comment wording To: behoffski Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15818-done Cc: 15818-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Thanks for the reminder. Here's the commit I've created for you, along with a similarly trivial one I spotted recently. Please confirm that the USER NAME and I used in your commit are ok. In any future patches, please submit the output of "git format-patch ...", including a log message, per guidelines in HACKING. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 21:04:51 2013 Received: (at 15818-done) by debbugs.gnu.org; 26 Dec 2013 02:04:51 +0000 Received: from localhost ([127.0.0.1]:42288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vw0Je-0001ti-LB for submit@debbugs.gnu.org; Wed, 25 Dec 2013 21:04:50 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:51660) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vw0Jc-0001tZ-MG for 15818-done@debbugs.gnu.org; Wed, 25 Dec 2013 21:04:49 -0500 Received: by mail-pa0-f45.google.com with SMTP id fb1so7763981pad.18 for <15818-done@debbugs.gnu.org>; Wed, 25 Dec 2013 18:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=/3cLLF8ZwHLtKUsCxgTMSG1RH7tJmvJHVZddBRGVOgk=; b=yiz474p1Kv7iQ/0wgJHjvnOauBjdPoafjd+3pZO/NqDgyPGIgYfJ5Tzql+JPPyI1PH 3cl12s8j8YbxOHA6sno9huBFToUgdKWphT26jtSd2ZVURm6p4HP8M+d/4DLulVxl6eJu 39NKlFuw9jMCmt82iE6S57Zo4skXm89NzPftf52cc1b8km+HfYl7wW8VH2gTjc/D4nh1 wbhdrTmlabHb27Ir86rFLaoMbCeJEg9IkDQGUVUZz6M89i7XMHtFAWo1qKkzrNLdovCr 41tdhYdJVAIOVm7vCEbuoE7KzwapI2V7jDPCNS6TxFU5y5iz27IwNCKBPv8noT2rx9Q2 kxwQ== X-Received: by 10.67.5.233 with SMTP id cp9mr758371pad.147.1388023487930; Wed, 25 Dec 2013 18:04:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Wed, 25 Dec 2013 18:04:27 -0800 (PST) In-Reply-To: References: <5279B57C.7000202@grouse.com.au> <52BB89C6.9070004@grouse.com.au> From: Jim Meyering Date: Wed, 25 Dec 2013 18:04:27 -0800 X-Google-Sender-Auth: XBfblDFlwV9Akl8AKRFOgQXTIxM Message-ID: Subject: Re: bug#15818: src/dfa.c: *MALLOC comment block: Clarify comment wording To: behoffski Content-Type: multipart/mixed; boundary=047d7b15b1e5f0afff04ee6666b9 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15818-done Cc: 15818-done <15818-done@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b15b1e5f0afff04ee6666b9 Content-Type: text/plain; charset=ISO-8859-1 Patch attached, this time: --047d7b15b1e5f0afff04ee6666b9 Content-Type: text/plain; charset=US-ASCII; name="k.txt" Content-Disposition: attachment; filename="k.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hpndbp9d0 RnJvbSA5ZGQ2ZTc2Y2I4NTY5ODUyOTYyNjJmZjU4N2I2ZDZlNDRmNGRmMTU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCcmVudG9uIEhvZmYgPGJlaG9mZnNraUBncm91c2UuY29tLmF1 PgpEYXRlOiBXZWQsIDI1IERlYyAyMDEzIDE3OjU1OjEzIC0wODAwClN1YmplY3Q6IFtQQVRDSCAx LzJdIG1haW50OiBmaXggYSBnYXJibGVkIGNvbW1lbnQKCiogc3JjL2RmYS5jIChYTk1BTExPQywg ZXRjLik6IEZpeCBnYXJibGVkIGNvbW1lbnQgd29yZGluZy4KLS0tCiBzcmMvZGZhLmMgfCAyICst CiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1n aXQgYS9zcmMvZGZhLmMgYi9zcmMvZGZhLmMKaW5kZXggZjE5NmI4YS4uYWYyYjk1ZCAxMDA2NDQK LS0tIGEvc3JjL2RmYS5jCisrKyBiL3NyYy9kZmEuYwpAQCAtNDMzLDcgKzQzMyw3IEBAIHN0YXRp YyB2b2lkIGRmYW11c3QgKHN0cnVjdCBkZmEgKmRmYSk7CiBzdGF0aWMgdm9pZCByZWdleHAgKHZv aWQpOwoKIC8qIFRoZXNlIHR3byBtYWNyb3MgYXJlIGlkZW50aWNhbCB0byB0aGUgb25lcyBpbiBn bnVsaWIncyB4YWxsb2MuaCwKLSAgIGV4Y2VwdCB0aGF0IHRoZXkgbm90IHRvIGNhc2UgdGhlIHJl c3VsdCB0byAiKHQgKikiLCBhbmQgdGh1cyBtYXkKKyAgIGV4Y2VwdCB0aGF0IHRoZXkgZG8gbm90 IGNhc3QgdGhlIHJlc3VsdCB0byAiKHQgKikiLCBhbmQgdGh1cyBtYXkKICAgIGJlIHVzZWQgdmlh IHR5cGUtZnJlZSBDQUxMT0MgYW5kIE1BTExPQyBtYWNyb3MuICAqLwogI3VuZGVmIFhOTUFMTE9D CiAjdW5kZWYgWENBTExPQwotLSAKMS44LjUucmMyLjYuZ2M2ZjFiOTIKCgpGcm9tIDgxNzQ0MTU5 MDExMDZiODIzMjY1ODRmOGU0ZWEwZjE0OTc0YTIxNjkgTW9uIFNlcCAxNyAwMDowMDowMCAyMDAx CkZyb206IEppbSBNZXllcmluZyA8bWV5ZXJpbmdAZmIuY29tPgpEYXRlOiBXZWQsIDI1IERlYyAy MDEzIDE3OjU5OjA1IC0wODAwClN1YmplY3Q6IFtQQVRDSCAyLzJdIG1haW50OiBmaXggaW5jb25z aXN0ZW50IHNwYWNpbmcgaW4gZXhwcmVzc2lvbgoKKiBzcmMvbWFpbi5jIChwcmxpbmUpOiBGaXgg aW5jb25zaXN0ZW50IHNwYWNpbmcgaW4gZXhwcmVzc2lvbjoKcy8gIC8gLy4KLS0tCiBzcmMvbWFp bi5jIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0p CgpkaWZmIC0tZ2l0IGEvc3JjL21haW4uYyBiL3NyYy9tYWluLmMKaW5kZXggOGI3YjQ5Mi4uMWVh NWEzMyAxMDA2NDQKLS0tIGEvc3JjL21haW4uYworKysgYi9zcmMvbWFpbi5jCkBAIC05MzEsNyAr OTMxLDcgQEAgcHJsaW5lIChjaGFyIGNvbnN0ICpiZWcsIGNoYXIgY29uc3QgKmxpbSwgaW50IHNl cCkKICAgICBsaW5lX2NvbG9yID0gbWF0Y2hfY29sb3IgPSBOVUxMOyAvKiBTaG91bGRuJ3QgYmUg dXNlZC4gICovCgogICBpZiAoKG9ubHlfbWF0Y2hpbmcgJiYgbWF0Y2hpbmcpCi0gICAgICB8fCAo Y29sb3Jfb3B0aW9uICAmJiAoKmxpbmVfY29sb3IgfHwgKm1hdGNoX2NvbG9yKSkpCisgICAgICB8 fCAoY29sb3Jfb3B0aW9uICYmICgqbGluZV9jb2xvciB8fCAqbWF0Y2hfY29sb3IpKSkKICAgICB7 CiAgICAgICAvKiBXZSBhbHJlYWR5IGtub3cgdGhhdCBub24tbWF0Y2hpbmcgbGluZXMgaGF2ZSBu byBtYXRjaCAodG8gY29sb3JpemUpLiAqLwogICAgICAgaWYgKG1hdGNoaW5nICYmIChvbmx5X21h dGNoaW5nIHx8ICptYXRjaF9jb2xvcikpCi0tIAoxLjguNS5yYzIuNi5nYzZmMWI5MgoK --047d7b15b1e5f0afff04ee6666b9-- From unknown Mon Sep 08 15:20:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 Jan 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator