Subject: Re: bug#15818: src/dfa.c: *MALLOC comment block: Clarify comment wording

From: behoffski <[email-masked]>
Date: Thu, 26 Dec 2013 12:13:34 +1030

On 11/06/13 13:50, behoffski wrote:
> G'day,
>
> Attached is a patch clarifying the wording in a comment block in
> dfa.c, relating to the XNMALLOC/XCALLOC/CALLOC/MALLOC/REALLOC
> preprocessor function definitions.  Change is in comment text only;
> no functional changes.
>
> cheers,
>
> behoffski (Brenton Hoff)
> Programmer, Grouse Software

(Patch text included inline here:)
------------------
diff --git a/src/dfa.c b/src/dfa.c
index 92c410e..2063e90 100644
--- a/src/dfa.c
+++ b/src/dfa.c
@@ -433,7 +433,7 @@ static void dfamust (struct dfa *dfa);
  static void regexp (void);

  /* These two macros are identical to the ones in gnulib's xalloc.h,
-   except that they not to case the result to "(t *)", and thus may
+   except that they don't cast the result to "(t *)", and thus may
     be used via type-free CALLOC and MALLOC macros.  */
  #undef XNMALLOC
  #undef XCALLOC
------------------

Just a reminder that I've had no feedback on this bug, and it's small
enough to be included in the upcoming 2.15 release.  A number of
factors in my life have been really berserk recently (including
requiring a total work machine rebuild, still partially in progress),
so I haven't checked that the patch line numbering is still valid.

cheers,

behoffski (Brenton Hoff)
Programmer, Grouse Software