From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 15:41:21 2013 Received: (at submit) by debbugs.gnu.org; 5 Nov 2013 20:41:21 +0000 Received: from localhost ([127.0.0.1]:36240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdnRA-0005Qp-Vy for submit@debbugs.gnu.org; Tue, 05 Nov 2013 15:41:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49691) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdnR7-0005QW-Av for submit@debbugs.gnu.org; Tue, 05 Nov 2013 15:41:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdnQv-0002RF-6Q for submit@debbugs.gnu.org; Tue, 05 Nov 2013 15:41:11 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdnQv-0002R8-3Z for submit@debbugs.gnu.org; Tue, 05 Nov 2013 15:41:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdnQp-00026w-2l for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 15:41:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdnQj-0002Py-2W for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 15:40:59 -0500 Received: from qproxy1-pub.mail.unifiedlayer.com ([173.254.64.10]:57438) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1VdnQi-0002Pr-P1 for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 15:40:52 -0500 Received: (qmail 24167 invoked by uid 0); 5 Nov 2013 20:40:26 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by qproxy1.mail.unifiedlayer.com with SMTP; 5 Nov 2013 20:40:26 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=67kzcdYLDbSwKsAVMM5GuFMY8BSoAeLsSmvbmNdxKNw=; b=QfaAJpbskpEo4eT+k1UkzIednKoIz1AJGg/oSP0UybzNK8jRjkb4HSFbB11/BIpKaIVfKNG5npWLQHRR3us9jXUh9yRYq+VZEGOGFi/Vr6AhkIsDVdoy3JjhNlU7wUVp; Received: from [50.90.253.209] (port=49297 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VdnQH-00040L-Lt for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 13:40:26 -0700 From: Nathan Trapuzzano To: bug-gnu-emacs@gnu.org Subject: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Date: Tue, 05 Nov 2013 15:40:22 -0500 Message-ID: <87k3gmmvk9.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) --=-=-= Content-Type: text/plain `cl-symbol-macrolet' silently accepts both of the following forms: (cl-symbol-macrolet ((foo bar baz) ...) ...) (cl-symbol-macrolet ((foo) ...) ...) In the former case, baz is ignored; in the latter case, foo is bound to nil. According to the CL docs, neither of these is valid. (Not to mention, they are both errors in Common Lisp.) The attached patch asserts properly formed bindings. I checked the Emacs source to make sure there's no code in there relying on this behavior. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=cl-macs.el.patch >From d6feb1195b8dc8f204d49761bfa828facbb4ba57 Mon Sep 17 00:00:00 2001 From: Nathan Trapuzzano Date: Tue, 5 Nov 2013 14:36:32 -0500 Subject: [PATCH] Signal error with malformed bindings in cl-symbol-macrolet. --- lisp/ChangeLog | 5 +++++ lisp/emacs-lisp/cl-macs.el | 2 ++ 2 files changed, 7 insertions(+) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 828fcda..a4ae0ca 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2013-11-05 Nathan Trapuzzano + + * emacs-lisp/cl-macs.el (cl-symbol-macrolet): Signal error with + malformed bindings form. + 2013-11-05 Eli Zaretskii * international/quail.el (quail-help): Be more explicit about the diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 60fdc09..1e277f7 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -1988,6 +1988,8 @@ by EXPANSION, and (setq NAME ...) will act like (setf EXPANSION ...). (cl-symbol-macrolet ,(cdr bindings) ,@body))) ((null bindings) (macroexp-progn body)) (t + (cl-assert (and (cdar bindings) (null (cl-cddar bindings))) nil + "Malformed `cl-symbol-macrolet' binding: %S" (car bindings)) (let ((previous-macroexpand (symbol-function 'macroexpand))) (unwind-protect (progn -- 1.8.4.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 19:46:54 2013 Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 00:46:54 +0000 Received: from localhost ([127.0.0.1]:36369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdrGn-0002rQ-MY for submit@debbugs.gnu.org; Tue, 05 Nov 2013 19:46:53 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:52959) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdrGl-0002rC-Ic for 15814@debbugs.gnu.org; Tue, 05 Nov 2013 19:46:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCSxH5AOkQoDiGGcGYFegxU X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCSxH5AOkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37179989" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Nov 2013 19:46:45 -0500 Received: by pastel.home (Postfix, from userid 20848) id 290FB60A07; Tue, 5 Nov 2013 19:46:45 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> Date: Tue, 05 Nov 2013 19:46:45 -0500 In-Reply-To: <87k3gmmvk9.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Tue, 05 Nov 2013 15:40:22 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > --- a/lisp/emacs-lisp/cl-macs.el > +++ b/lisp/emacs-lisp/cl-macs.el > @@ -1988,6 +1988,8 @@ by EXPANSION, and (setq NAME ...) will act like (setf EXPANSION ...). > (cl-symbol-macrolet ,(cdr bindings) ,@body))) > ((null bindings) (macroexp-progn body)) > (t > + (cl-assert (and (cdar bindings) (null (cl-cddar bindings))) nil > + "Malformed `cl-symbol-macrolet' binding: %S" (car bindings)) > (let ((previous-macroexpand (symbol-function 'macroexpand))) > (unwind-protect > (progn Good idea. Could you try and use macroexp--warn-and-return instead, so we get a file&line location when byte-compiling? BTW, the same holds for the "let" sanity checks you added to cconv (which should probably be moved to macroexp, now that I think about it, so we can remove them from bytecomp.el). Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 21:19:21 2013 Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 02:19:21 +0000 Received: from localhost ([127.0.0.1]:36409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdsiG-00057E-QL for submit@debbugs.gnu.org; Tue, 05 Nov 2013 21:19:21 -0500 Received: from [74.220.205.131] (port=50301 helo=alt-proxy3.mail.unifiedlayer.com) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VdsiE-000575-3o for 15814@debbugs.gnu.org; Tue, 05 Nov 2013 21:19:19 -0500 Received: (qmail 5488 invoked by uid 0); 6 Nov 2013 02:19:16 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy19-pub.mail.unifiedlayer.com with SMTP; 6 Nov 2013 02:19:16 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=GdTty4YtmsD7oLAGs7/Heh5CDylutb4HY4ch9vYNQ1M=; b=ocHl9P1ZZR3jdkvqIRfFkbu4xwoCGEjwE9wCcWdiw5EsMHMve4ZYLlBXP/XfnbMx2ln5n4nXkqPJ3uMwO3TmLiKKkgyIovm15BkKSVtSLegEzcqpAKWPMQBSRLh2qSfi; Received: from [50.90.253.209] (port=50322 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VdsiB-0005EN-Iv; Tue, 05 Nov 2013 19:19:16 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> Date: Tue, 05 Nov 2013 21:19:06 -0500 In-Reply-To: (Stefan Monnier's message of "Tue, 05 Nov 2013 19:46:45 -0500") Message-ID: <87a9himfvp.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier writes: > Good idea. Could you try and use macroexp--warn-and-return instead, so > we get a file&line location when byte-compiling? I'm not certain what you mean here. You seem to agree that this is an error, but `macroexp--warn-and-return' doesn't signal an error--it just prints a warning. If we do something like this: [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.220.205.131 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier writes: > Good idea. Could you try and use macroexp--warn-and-return instead, so > we get a file&line location when byte-compiling? I'm not certain what you mean here. You seem to agree that this is an error, but `macroexp--warn-and-return' doesn't signal an error--it just prints a warning. If we do something like this: [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.220.205.131 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Stefan Monnier writes: > Good idea. Could you try and use macroexp--warn-and-return instead, so > we get a file&line location when byte-compiling? I'm not certain what you mean here. You seem to agree that this is an error, but `macroexp--warn-and-return' doesn't signal an error--it just prints a warning. If we do something like this: (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S" (car bindings)))) (macroexp--warn-and-return msg `(error "%s" ,msg))) we'll get a warning at compile time and an error at run time. Is this what you have in mind? Shouldn't we signal the error as early as possible? Perhaps there is some Emacs convention that I'm not aware of in this regard. > BTW, the same holds for the "let" sanity checks you added to cconv > (which should probably be moved to macroexp, now that I think about it, > so we can remove them from bytecomp.el). I don't understand this either. By "moved to macroexp", do you just mean that the sanity checks should be performed using macroexp--warn-and-return in the manner given above? Sorry for my confusion. Nathan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 22:20:47 2013 Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 03:20:47 +0000 Received: from localhost ([127.0.0.1]:36424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdtfi-0006Xo-Ie for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:46 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31208) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdtff-0006XZ-Ru for 15814@debbugs.gnu.org; Tue, 05 Nov 2013 22:20:44 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GsR+QDpEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37193761" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Nov 2013 22:20:37 -0500 Received: by pastel.home (Postfix, from userid 20848) id 8212F60A07; Tue, 5 Nov 2013 22:20:37 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> Date: Tue, 05 Nov 2013 22:20:37 -0500 In-Reply-To: <87a9himfvp.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Tue, 05 Nov 2013 21:19:06 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Good idea. Could you try and use macroexp--warn-and-return instead, so >> we get a file&line location when byte-compiling? > I'm not certain what you mean here. You seem to agree that this is an > error, but `macroexp--warn-and-return' doesn't signal an error--it just > prints a warning. If we do something like this: > (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S" > (car bindings)))) > (macroexp--warn-and-return msg `(error "%s" ,msg))) > we'll get a warning at compile time and an error at run time. Is this > what you have in mind? Shouldn't we signal the error as early as > possible? Perhaps there is some Emacs convention that I'm not aware of > in this regard. Signaling an error stops the whole compilation, so you only get one error at a time. Better make it a warning, even though it is indeed a programming error. >> BTW, the same holds for the "let" sanity checks you added to cconv >> (which should probably be moved to macroexp, now that I think about it, >> so we can remove them from bytecomp.el). > I don't understand this either. By "moved to macroexp", do you just > mean that the sanity checks should be performed using > macroexp--warn-and-return in the manner given above? No, I mean that they should be performed in macroexp--expand-all rather than in cconv, so they're performed regardless of lexical-binding (currently they're done once in cconv.el and once in bytecomp.el). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 06:17:07 2013 Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 11:17:07 +0000 Received: from localhost ([127.0.0.1]:36738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve16g-0001lo-0L for submit@debbugs.gnu.org; Wed, 06 Nov 2013 06:17:06 -0500 Received: from oproxy1-pub.mail.unifiedlayer.com ([66.147.249.253]:55607) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1Ve16d-0001ld-Ep for 15814@debbugs.gnu.org; Wed, 06 Nov 2013 06:17:04 -0500 Received: (qmail 20034 invoked by uid 0); 6 Nov 2013 11:16:59 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy1.mail.unifiedlayer.com with SMTP; 6 Nov 2013 11:16:59 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=tV5CyvDY+s5Njk3nJGBY6EdwWQJo5PvBH/NxZMWsiAU=; b=tx9gXI42vgJzjQ1DZgNOrGcMr72t3l63bdDCm4wKnVUaPlDz0sXo5SOnIwgvShGZHtUEq9SZRmHKrfoSAeCLDph0NRgXZvIP5rOwgBsV4InmI7ILrx6qjPIIcROB7t96; Received: from [50.90.253.209] (port=48185 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1Ve16Z-0007Zd-8g; Wed, 06 Nov 2013 04:16:59 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> Date: Wed, 06 Nov 2013 06:16:55 -0500 In-Reply-To: (Stefan Monnier's message of "Tue, 05 Nov 2013 22:20:37 -0500") Message-ID: <87ppqd2314.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S" >> (car bindings)))) >> (macroexp--warn-and-return msg `(error "%s" ,msg))) > > Signaling an error stops the whole compilation, so you only get one > error at a time. Better make it a warning, even though it is indeed > a programming error. And then signal the error at run time? Do I understand you correctly about that? What if we're not compiling? If you don't want the error to abort the build process, it seems that the ideal solution would be, in the compiled case, to print a warning during compilation and signal an error at run time; and in the interpreted case, to signal the error at macro expansion time. > No, I mean that they should be performed in macroexp--expand-all rather > than in cconv, so they're performed regardless of lexical-binding > (currently they're done once in cconv.el and once in bytecomp.el). This wouldn't work since there's no guarantee that any particular form passes through macroexp--expand-all, not in the interpreter at least. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 08:45:33 2013 Received: (at 15814) by debbugs.gnu.org; 6 Nov 2013 13:45:33 +0000 Received: from localhost ([127.0.0.1]:36915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve3QK-0007jw-Pa for submit@debbugs.gnu.org; Wed, 06 Nov 2013 08:45:32 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:3656) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Ve3QI-0007ji-L1 for 15814@debbugs.gnu.org; Wed, 06 Nov 2013 08:45:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37209241" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Nov 2013 08:45:24 -0500 Received: by pastel.home (Postfix, from userid 20848) id 211266009C; Wed, 6 Nov 2013 08:45:24 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> Date: Wed, 06 Nov 2013 08:45:24 -0500 In-Reply-To: <87ppqd2314.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Wed, 06 Nov 2013 06:16:55 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >>> (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S" >>> (car bindings)))) >>> (macroexp--warn-and-return msg `(error "%s" ,msg))) >> Signaling an error stops the whole compilation, so you only get one >> error at a time. Better make it a warning, even though it is indeed >> a programming error. > And then signal the error at run time? Do I understand you correctly > about that? Check other uses of macroexp--warn-and-return (there aren't many). It doesn't signal any error at all. But they do emit warnings either during compilation or while loading an interpreted file. >> No, I mean that they should be performed in macroexp--expand-all rather >> than in cconv, so they're performed regardless of lexical-binding >> (currently they're done once in cconv.el and once in bytecomp.el). > This wouldn't work since there's no guarantee that any particular form > passes through macroexp--expand-all, not in the interpreter at least. As I said, currently it's performed in bytecomp.el and cconv.el, and there's no way to get to either of those two without going through macroexp--expand-all first. So, yes, there is a guarantee. When loading an interpreted file, we go through macroexp--expand-all as well (not not through cconv.el nor through bytecomp.el). Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 20:14:46 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 01:14:46 +0000 Received: from localhost ([127.0.0.1]:38001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeEBK-0002eP-2C for submit@debbugs.gnu.org; Wed, 06 Nov 2013 20:14:46 -0500 Received: from oproxy19-pub.mail.unifiedlayer.com ([70.40.200.33]:54153) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VeEBH-0002eH-NB for 15814@debbugs.gnu.org; Wed, 06 Nov 2013 20:14:44 -0500 Received: (qmail 19451 invoked by uid 0); 7 Nov 2013 01:14:40 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy19.mail.unifiedlayer.com with SMTP; 7 Nov 2013 01:14:40 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=zonoFRtjYDzh0lLwA5JUlCjzc06phMzbPSthN8ete74=; b=r/zeZwl1zC13ZFZQizP7kmNAZCUhTJd72zJkW+QlqcAdgSf/ewibXxTA3zp8PJb5oboarrfcZUtkAou5E+aGVsULZ0WpqJViPhRHlmNhk/s1SKduHN6MReOgi+q1Nd3t; Received: from [50.90.253.209] (port=51540 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VeEBD-0003BM-Uh; Wed, 06 Nov 2013 18:14:40 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> Date: Wed, 06 Nov 2013 20:14:37 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 06 Nov 2013 08:45:24 -0500") Message-ID: <871u2tgghu.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >>>> (let ((msg (format "Malformed `cl-symbol-macrolet' binding: %S" >>>> (car bindings)))) >>>> (macroexp--warn-and-return msg `(error "%s" ,msg))) > > Check other uses of macroexp--warn-and-return (there aren't many). > It doesn't signal any error at all. But they do emit warnings either > during compilation or while loading an interpreted file. In the example I gave, the second argument to macroexp--warn-and-return is an (error ...) form, which will be evaluated at run time. That's what I meant. If we're going to use macroexp--warn-and-return, it seems this is the only sensible thing to do (in this case that is). What's the alternative? Transform malformed let in some undefined way? At the very least, the behavior when compiled/evaluated should be the same as when interpreted, i.e. an error. But more generally, what's wrong with signalling the error at compile time? Sure, it would cause the Emacs build to fail, but I would call that an advantage. Not to mention, it's especially easy to miss the warnings during the build process, as opposed to compiling individual files manually. > As I said, currently it's performed in bytecomp.el and cconv.el, and > there's no way to get to either of those two without going through > macroexp--expand-all first. So, yes, there is a guarantee. > > When loading an interpreted file, we go through macroexp--expand-all as > well (not not through cconv.el nor through bytecomp.el). It doesn't look like evaluation via M-: has to go through macroexp--expand-all. Try: M-: (let ((foo 'bar)) foo) RET Though I guess in the specific case of malformed `let', this doesn't really matter, since the interpreter will catch the error. From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 21:08:50 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 02:08:50 +0000 Received: from localhost ([127.0.0.1]:38029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeF1d-00040z-MD for submit@debbugs.gnu.org; Wed, 06 Nov 2013 21:08:49 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:28609) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeF1a-00040j-M4 for 15814@debbugs.gnu.org; Wed, 06 Nov 2013 21:08:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37266869" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Nov 2013 21:08:40 -0500 Received: by pastel.home (Postfix, from userid 20848) id D679C602A1; Wed, 6 Nov 2013 21:08:39 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> Date: Wed, 06 Nov 2013 21:08:39 -0500 In-Reply-To: <871u2tgghu.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Wed, 06 Nov 2013 20:14:37 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > What's the alternative? Transform malformed let in some undefined way? Yup. Just like we've done so far. > very least, the behavior when compiled/evaluated should be the same as > when interpreted, i.e. an error. For incorrect syntax, it's perfectly OK to misbehave differently in the two cases. Especially, the interpreted case without going through eager macroexpansion (i.e. through macroexpand-all) is largely irrelevant. > But more generally, what's wrong with signalling the error at compile > time? I explained that already: the first error stops everything, so you only get one error report even when there are several errors. >> When loading an interpreted file, we go through macroexp--expand-all as >> well (not not through cconv.el nor through bytecomp.el). > It doesn't look like evaluation via M-: has to go through > macroexp--expand-all. No, because M-: is not "loading an interpreted file". But sooner or later M-: will also go through macroexpand-all. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 22:22:39 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 03:22:39 +0000 Received: from localhost ([127.0.0.1]:38072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeGB4-0005zm-En for submit@debbugs.gnu.org; Wed, 06 Nov 2013 22:22:38 -0500 Received: from oproxy16-pub.mail.unifiedlayer.com ([69.89.22.201]:42980) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VeGB0-0005zc-Lk for 15814@debbugs.gnu.org; Wed, 06 Nov 2013 22:22:35 -0500 Received: (qmail 11586 invoked by uid 0); 7 Nov 2013 03:22:32 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy16.mail.unifiedlayer.com with SMTP; 7 Nov 2013 03:22:32 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=7zavRxXb5pcw0glfHG/4Vac5cvJBz3OCv9urjOuGLZo=; b=lj03+vvEgycBWotYmve6hPnza4X6g5DhRfLWJJHs14NstCRAQoQc5R1Fnv9s8b1RRBYgGzvd7RtPvrdhcgVGHZhZBpf8fQrzTv9OA39HqMp+zDPdFJ9dNb/4gVnKvyx0; Received: from [50.90.253.209] (port=52342 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VeGAy-0001OR-CW; Wed, 06 Nov 2013 20:22:32 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> Date: Wed, 06 Nov 2013 22:22:30 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 06 Nov 2013 21:08:39 -0500") Message-ID: <87mwlggakp.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> What's the alternative? Transform malformed let in some undefined way? > > Yup. Just like we've done so far. I think I understand what you want. This patch uses macroexp--warn-and-return. I'll try to move the checks in bytecomp.el/cconv.el later. Nathan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=cl-macs.el.patch >From 3843a58d0ebcaea9e6c9446ca6b6f52611c8097d Mon Sep 17 00:00:00 2001 From: Nathan Trapuzzano Date: Tue, 5 Nov 2013 14:36:32 -0500 Subject: [PATCH] Print warning for malformed bindings in cl-symbol-macrolet. --- lisp/ChangeLog | 5 +++++ lisp/emacs-lisp/cl-macs.el | 18 +++++++++++++----- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 828fcda..824e73c 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,8 @@ +2013-11-05 Nathan Trapuzzano + + * emacs-lisp/cl-macs.el (cl-symbol-macrolet): Print warning for + malformed bindings form. + 2013-11-05 Eli Zaretskii * international/quail.el (quail-help): Be more explicit about the diff --git a/lisp/emacs-lisp/cl-macs.el b/lisp/emacs-lisp/cl-macs.el index 60fdc09..9cdde5e 100644 --- a/lisp/emacs-lisp/cl-macs.el +++ b/lisp/emacs-lisp/cl-macs.el @@ -1992,11 +1992,19 @@ by EXPANSION, and (setq NAME ...) will act like (setf EXPANSION ...). (unwind-protect (progn (fset 'macroexpand #'cl--sm-macroexpand) - ;; FIXME: For N bindings, this will traverse `body' N times! - (macroexpand-all (cons 'progn body) - (cons (list (symbol-name (caar bindings)) - (cl-cadar bindings)) - macroexpand-all-environment))) + (let ((expansion + ;; FIXME: For N bindings, this will traverse `body' + ;; N times! + (macroexpand-all (cons 'progn body) + (cons (list (symbol-name (caar bindings)) + (cl-cadar bindings)) + macroexpand-all-environment)))) + (if (or (null (cdar bindings)) (cl-cddar bindings)) + (macroexp--warn-and-return + (format "Malformed `cl-symbol-macrolet' binding: %S" + (car bindings)) + expansion) + expansion))) (fset 'macroexpand previous-macroexpand)))))) ;;; Multiple values. -- 1.8.4.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 23:38:42 2013 Received: (at 15814-done) by debbugs.gnu.org; 7 Nov 2013 04:38:42 +0000 Received: from localhost ([127.0.0.1]:38102 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeHMg-0007tA-59 for submit@debbugs.gnu.org; Wed, 06 Nov 2013 23:38:42 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:15628) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeHMd-0007su-T4 for 15814-done@debbugs.gnu.org; Wed, 06 Nov 2013 23:38:40 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37277841" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Nov 2013 23:38:33 -0500 Received: by pastel.home (Postfix, from userid 20848) id 86E2D60E3C; Wed, 6 Nov 2013 23:38:33 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> Date: Wed, 06 Nov 2013 23:38:33 -0500 In-Reply-To: <87mwlggakp.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Wed, 06 Nov 2013 22:22:30 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I think I understand what you want. This patch uses > macroexp--warn-and-return. Perfect. Installed. > I'll try to move the checks in bytecomp.el/cconv.el later. Thanks, no hurry. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 02:08:55 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 07:08:55 +0000 Received: from localhost ([127.0.0.1]:38244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeJi2-0003AZ-Q9 for submit@debbugs.gnu.org; Thu, 07 Nov 2013 02:08:55 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:52740) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeJhx-0003AI-UW for 15814@debbugs.gnu.org; Thu, 07 Nov 2013 02:08:51 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id A479739E8105 for <15814@debbugs.gnu.org>; Wed, 6 Nov 2013 23:08:43 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KfFLuv5VCfZy for <15814@debbugs.gnu.org>; Wed, 6 Nov 2013 23:08:43 -0800 (PST) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4AF6A39E80F8 for <15814@debbugs.gnu.org>; Wed, 6 Nov 2013 23:08:43 -0800 (PST) Message-ID: <527B3C7A.5080300@cs.ucla.edu> Date: Wed, 06 Nov 2013 23:08:42 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: 15814@debbugs.gnu.org Subject: bootstrap fails due to recent cl-symbol-macrolet patch X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15814 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Unfortunately that patch seems to have broken 'make bootstrap'. The problem first appeared in trunk bzr 115013. Here are the symptoms: Compiling progmodes/cc-cmds.el In toplevel form: progmodes/cc-cmds.el:4624:1:Error: Invalid function: (--dolist-tail-- ad-advice-classes) Makefile:267: recipe for target 'progmodes/cc-cmds.elc' failed make[2]: *** [progmodes/cc-cmds.elc] Error 1 make[2]: Leaving directory '/home/eggert/src/gnu/emacs/static-checking/lisp' Makefile:295: recipe for target 'compile-main' failed make[1]: *** [compile-main] Error 2 make[1]: Leaving directory '/home/eggert/src/gnu/emacs/static-checking/lisp' Makefile:378: recipe for target 'lisp' failed make: *** [lisp] Error 2 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 07:58:45 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 12:58:45 +0000 Received: from localhost ([127.0.0.1]:38763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VePAa-0004M5-Fa for submit@debbugs.gnu.org; Thu, 07 Nov 2013 07:58:45 -0500 Received: from oproxy1-pub.mail.unifiedlayer.com ([66.147.249.253]:38790) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VePAW-0004Ls-BM for 15814@debbugs.gnu.org; Thu, 07 Nov 2013 07:58:41 -0500 Received: (qmail 25372 invoked by uid 0); 7 Nov 2013 12:58:38 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy1.mail.unifiedlayer.com with SMTP; 7 Nov 2013 12:58:38 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=QWkDrt+39aWkeaEoERokmjvinhI8/Di2mXRrqhwQwgI=; b=uaXZDsjbJuKwFUpDvOQHqC3bEqjY4XhQKha9p9aV6IOxgFiOixhEbY7GDAZBknTbZObYQYNFn9OX5ubVdJF8XG4UoSPtc0adX7RALoXSeKxasBzmdItLrR8QxcVHJLWf; Received: from [50.90.253.209] (port=48486 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VePAT-0000PD-Ht; Thu, 07 Nov 2013 05:58:38 -0700 From: Nathan Trapuzzano To: Paul Eggert Subject: Re: bug#15814: bootstrap fails due to recent cl-symbol-macrolet patch References: <87k3gmmvk9.fsf@nbtrap.com> <527B3C7A.5080300@cs.ucla.edu> Date: Thu, 07 Nov 2013 07:58:32 -0500 In-Reply-To: <527B3C7A.5080300@cs.ucla.edu> (Paul Eggert's message of "Wed, 06 Nov 2013 23:08:42 -0800") Message-ID: <87siv8jrlz.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814 Cc: 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Paul Eggert writes: > Unfortunately that patch seems to have broken 'make bootstrap'. > The problem first appeared in trunk bzr 115013. It looks like the offending change from that patch was the line in the cl--block-wrapper definition. I'm not sure if Stefan meant to include that line or just forgot to clean his directory before intsalling the patch. Either way, it's not really clear why it broke anything. The only thing I can think of is macroexp-progn assumes its argument satisfies listp and calls cdr on it, which would cause a compile-time error. Whereas without the patch, there would have been (progn . ATOM), an error that wouldn't have been detected at build time (so far as I know). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 14:46:19 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 19:46:19 +0000 Received: from localhost ([127.0.0.1]:39823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeVX1-0006A3-7n for submit@debbugs.gnu.org; Thu, 07 Nov 2013 14:46:19 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:62748) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeVWy-00069n-P0 for 15814@debbugs.gnu.org; Thu, 07 Nov 2013 14:46:17 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37325915" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Nov 2013 14:46:10 -0500 Received: by pastel.home (Postfix, from userid 20848) id 59EAD60109; Thu, 7 Nov 2013 14:46:10 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: bootstrap fails due to recent cl-symbol-macrolet patch Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <527B3C7A.5080300@cs.ucla.edu> <87siv8jrlz.fsf@nbtrap.com> Date: Thu, 07 Nov 2013 14:46:10 -0500 In-Reply-To: <87siv8jrlz.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Thu, 07 Nov 2013 07:58:32 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814 Cc: Paul Eggert , 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > It looks like the offending change from that patch was the line in the > cl--block-wrapper definition. I'm not sure if Stefan meant to include > that line or just forgot to clean his directory before intsalling the > patch. My directories are never clean, so I regularly fall into this trap. Should be fixed now, Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 14:51:42 2013 Received: (at 15814-done) by debbugs.gnu.org; 7 Nov 2013 19:51:42 +0000 Received: from localhost ([127.0.0.1]:39833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeVcE-0006I0-6N for submit@debbugs.gnu.org; Thu, 07 Nov 2013 14:51:42 -0500 Received: from [74.220.218.8] (port=51080 helo=alt-proxy7.mail.unifiedlayer.com) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VeVc9-0006Hm-TR for 15814-done@debbugs.gnu.org; Thu, 07 Nov 2013 14:51:40 -0500 Received: (qmail 12401 invoked by uid 0); 7 Nov 2013 19:51:35 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy4.mail.unifiedlayer.com with SMTP; 7 Nov 2013 19:51:35 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=N7EmLyRc1dFY0DI0VMWjByuv1ODDq9EF7yO5UY+Y11g=; b=OpJaqwhKQvs91Dm8UGRHlhTJoGjdqpyQC0uIUd619h5ijWK0B318ipJjAR7NUa4qMy52Z8/9bPYWK/3DPjTmdZ/BXD2l6LLrlu0LykOaPvwy/iFJupZrwvjsQpuopk4/; Received: from [50.90.253.209] (port=51830 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VeVc7-0000bc-KK; Thu, 07 Nov 2013 12:51:35 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> Date: Thu, 07 Nov 2013 14:51:33 -0500 In-Reply-To: (Stefan Monnier's message of "Wed, 06 Nov 2013 23:38:33 -0500") Message-ID: <87r4as6ldm.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier writes: >> I'll try to move the checks in bytecomp.el/cconv.el later. > > Thanks, no hurry. Do you want all of the syntactial sanity checks moved, or just let/let*? [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.220.218.8 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier writes: >> I'll try to move the checks in bytecomp.el/cconv.el later. > > Thanks, no hurry. Do you want all of the syntactial sanity checks moved, or just let/let*? [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [74.220.218.8 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Stefan Monnier writes: >> I'll try to move the checks in bytecomp.el/cconv.el later. > > Thanks, no hurry. Do you want all of the syntactial sanity checks moved, or just let/let*? From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 16:03:21 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 21:03:22 +0000 Received: from localhost ([127.0.0.1]:39962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeWjY-0001rL-Db for submit@debbugs.gnu.org; Thu, 07 Nov 2013 16:03:21 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:45981 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeWjV-0001rB-QX for 15814@debbugs.gnu.org; Thu, 07 Nov 2013 16:03:18 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VeWjQ-0001g2-KQ; Thu, 07 Nov 2013 16:03:12 -0500 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#15814: bootstrap fails due to recent cl-symbol-macrolet patch References: <87k3gmmvk9.fsf@nbtrap.com> <527B3C7A.5080300@cs.ucla.edu> <87siv8jrlz.fsf@nbtrap.com> X-Spook: oil clandestine North Korea White House colonel Forte X-Ran: U@Ue!;g9Sm^/~;T2#g.,i0nfycJEV^*6CcL^7g8H&k~wqaG(t;ZXiwo5LD2#s!\'ss (Stefan Monnier's message of "Thu, 07 Nov 2013 14:46:10 -0500") Message-ID: <0yr4araprj.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 15814 Cc: Nathan Trapuzzano , Paul Eggert , 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Stefan Monnier wrote: >> It looks like the offending change from that patch was the line in the >> cl--block-wrapper definition. I'm not sure if Stefan meant to include >> that line or just forgot to clean his directory before intsalling the >> patch. > > My directories are never clean, so I regularly fall into this trap. This is a problem, isn't it? I mean, what happens when you accidentally commit something that causes a non-obvious problem? For example, in the course of bisecting something today, I came across r112851, http://lists.gnu.org/archive/html/emacs-diffs/2013-06/msg00043.html, which seems to include an unrelated change to subr.el that has no ChangeLog entry AFAICS. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 17:07:34 2013 Received: (at 15814) by debbugs.gnu.org; 7 Nov 2013 22:07:34 +0000 Received: from localhost ([127.0.0.1]:40059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeXji-0003Qr-AK for submit@debbugs.gnu.org; Thu, 07 Nov 2013 17:07:34 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:47508 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeXjg-0003Qj-67 for 15814@debbugs.gnu.org; Thu, 07 Nov 2013 17:07:32 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VeXje-0001Lg-Po; Thu, 07 Nov 2013 17:07:30 -0500 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#15814: bootstrap fails due to recent cl-symbol-macrolet patch References: <87k3gmmvk9.fsf@nbtrap.com> <527B3C7A.5080300@cs.ucla.edu> <87siv8jrlz.fsf@nbtrap.com> <0yr4araprj.fsf@fencepost.gnu.org> X-Spook: Bush Wired airframe Capricorn assassination George W. X-Ran: +PmRsjzjy$-;n;jq#K1xBuYA,)=Y!CC`W6*msiE#PiOy8;Q!(pF]ChR:vpGu(<-bSF34K? X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 07 Nov 2013 17:07:30 -0500 In-Reply-To: <0yr4araprj.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu, 07 Nov 2013 16:03:12 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 15814 Cc: Nathan Trapuzzano , Paul Eggert , 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) PS I find what works for me is to have several local branches in various degress of messiness, but to try to keep a pristine one from which to commit patches (especially ones from other people). From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 20:21:57 2013 Received: (at 15814-done) by debbugs.gnu.org; 8 Nov 2013 01:21:57 +0000 Received: from localhost ([127.0.0.1]:40301 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vealo-0007vH-SO for submit@debbugs.gnu.org; Thu, 07 Nov 2013 20:21:57 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:18328) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vealm-0007v4-Qk for 15814-done@debbugs.gnu.org; Thu, 07 Nov 2013 20:21:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpYcs/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFpYcs/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37347413" Received: from 69-165-135-44.dsl.teksavvy.com (HELO pastel.home) ([69.165.135.44]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Nov 2013 20:21:48 -0500 Received: by pastel.home (Postfix, from userid 20848) id 845DC606C4; Thu, 7 Nov 2013 20:21:48 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> Date: Thu, 07 Nov 2013 20:21:48 -0500 In-Reply-To: <87r4as6ldm.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Thu, 07 Nov 2013 14:51:33 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >>> I'll try to move the checks in bytecomp.el/cconv.el later. >> Thanks, no hurry. > Do you want all of the syntactial sanity checks moved, or just let/let*? Are there others in cconv.el? Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 20:29:48 2013 Received: (at 15814-done) by debbugs.gnu.org; 8 Nov 2013 01:29:49 +0000 Received: from localhost ([127.0.0.1]:40322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VeatQ-00087O-1a for submit@debbugs.gnu.org; Thu, 07 Nov 2013 20:29:48 -0500 Received: from oproxy1-pub.mail.unifiedlayer.com ([66.147.249.253]:33475) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VeatM-00087E-VE for 15814-done@debbugs.gnu.org; Thu, 07 Nov 2013 20:29:46 -0500 Received: (qmail 17717 invoked by uid 0); 8 Nov 2013 01:29:40 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy1.mail.unifiedlayer.com with SMTP; 8 Nov 2013 01:29:39 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=xbcY6Grb+RXOEdJFQ9IPXalAjyuKWSE2g5xhLuU3zlc=; b=FFIWS9nAyfFPX05W5DICRu0eeYebVLkFAhe2rIk6eOM0WEv+Rt339fRhdZ0Do9ITp8BegBAuDKmiXotEW05UPdMr1sNUupJkZxwmAEVvllDulNO4gGPhlNt8/BuhEQZ5; Received: from [50.90.253.209] (port=53996 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VeatH-0004Zs-Fe; Thu, 07 Nov 2013 18:29:39 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> Date: Thu, 07 Nov 2013 20:29:37 -0500 In-Reply-To: (Stefan Monnier's message of "Thu, 07 Nov 2013 20:21:48 -0500") Message-ID: <87zjpfof3y.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: > Are there others in cconv.el? Don't think so, but I'm talking about the ones byte*.el in addition to cconv.el. E.g. in byte-optimize-form-code-walker. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 20:34:25 2013 Received: (at 15814) by debbugs.gnu.org; 8 Nov 2013 01:34:25 +0000 Received: from localhost ([127.0.0.1]:40328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Veaxt-0008Ev-92 for submit@debbugs.gnu.org; Thu, 07 Nov 2013 20:34:25 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:3215) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Veaxr-0008Ei-Fb for 15814@debbugs.gnu.org; Thu, 07 Nov 2013 20:34:23 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpYcs/2dsb2JhbABEvw4Xc4IeAQEBAQIBAQJTIwULCw4mEhQUBA0kiB4GDMEhkQoDiGGKfoNKjVGBXoMV X-IPAS-Result: Av8EABK/CFFFpYcs/2dsb2JhbABEvw4Xc4IeAQEBAQIBAQJTIwULCw4mEhQUBA0kiB4GDMEhkQoDiGGKfoNKjVGBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37347891" Received: from 69-165-135-44.dsl.teksavvy.com (HELO pastel.home) ([69.165.135.44]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Nov 2013 20:34:17 -0500 Received: by pastel.home (Postfix, from userid 20848) id 92ADF606C4; Thu, 7 Nov 2013 20:34:17 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#15814: bootstrap fails due to recent cl-symbol-macrolet patch Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <527B3C7A.5080300@cs.ucla.edu> <87siv8jrlz.fsf@nbtrap.com> <0yr4araprj.fsf@fencepost.gnu.org> Date: Thu, 07 Nov 2013 20:34:17 -0500 In-Reply-To: (Glenn Morris's message of "Thu, 07 Nov 2013 17:07:30 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814 Cc: Nathan Trapuzzano , Paul Eggert , 15814@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > PS I find what works for me is to have several local branches in > various degress of messiness, but to try to keep a pristine one from > which to commit patches (especially ones from other people). That's also what I try to do, but it's still littered with things that are "about to be installed" (like the macroexp-progn that introduced this bug, or the add-to-list compiler-macro of http://lists.gnu.org/archive/html/emacs-diffs/2013-06/msg00043.html). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 07 22:03:08 2013 Received: (at 15814-done) by debbugs.gnu.org; 8 Nov 2013 03:03:09 +0000 Received: from localhost ([127.0.0.1]:40408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VecLk-0001tg-Bt for submit@debbugs.gnu.org; Thu, 07 Nov 2013 22:03:08 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:53109) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VecLg-0001t9-Ah for 15814-done@debbugs.gnu.org; Thu, 07 Nov 2013 22:03:05 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpYcs/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFFpYcs/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37357236" Received: from 69-165-135-44.dsl.teksavvy.com (HELO pastel.home) ([69.165.135.44]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Nov 2013 22:02:58 -0500 Received: by pastel.home (Postfix, from userid 20848) id E946E606C4; Thu, 7 Nov 2013 22:02:56 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> Date: Thu, 07 Nov 2013 22:02:56 -0500 In-Reply-To: <87zjpfof3y.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Thu, 07 Nov 2013 20:29:37 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Are there others in cconv.el? > Don't think so, but I'm talking about the ones byte*.el in addition to > cconv.el. E.g. in byte-optimize-form-code-walker. I think they're OK there for now. Now that I think about it, maybe an alternative for the "let format checks" is to keep them in bytecomp.el and change cconv so that the problems are *preserved* (and hence later detected by bytecomp). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 06:40:29 2013 Received: (at 15814-done) by debbugs.gnu.org; 8 Nov 2013 11:40:29 +0000 Received: from localhost ([127.0.0.1]:40966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VekQO-0006JK-7L for submit@debbugs.gnu.org; Fri, 08 Nov 2013 06:40:28 -0500 Received: from [66.147.241.60] (port=51884 helo=alt-proxy17.mail.unifiedlayer.com) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VekQJ-0006J8-Ts for 15814-done@debbugs.gnu.org; Fri, 08 Nov 2013 06:40:25 -0500 Received: (qmail 5430 invoked by uid 0); 8 Nov 2013 11:40:22 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy18.mail.unifiedlayer.com with SMTP; 8 Nov 2013 11:40:21 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=V3GbLREkcLh0WX0oMFiMKQwBzgB9I0MHxPU8pzpbPg0=; b=qcU78swQbZu/CyjQ54QYSrK7sB+lhJm8HR7+mMYVAK3FwkYouF4B2gguVxoVbxQ/tjmDFBsZMalHlKjfHh1S0J1tW7PZRAWO2zjH9upyn79kMuCSVniUeCseotOYrgya; Received: from [50.90.253.209] (port=51366 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VekQH-0002kw-Kz; Fri, 08 Nov 2013 04:40:21 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> Date: Fri, 08 Nov 2013 06:40:10 -0500 In-Reply-To: (Stefan Monnier's message of "Thu, 07 Nov 2013 22:02:56 -0500") Message-ID: <87zjpf5dgl.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier writes: > Now that I think about it, maybe an alternative for the "let format > checks" is to keep them in bytecomp.el and change cconv so that the > problems are *preserved* (and hence later detected by bytecomp). [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [66.147.241.60 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Stefan Monnier writes: > Now that I think about it, maybe an alternative for the "let format > checks" is to keep them in bytecomp.el and change cconv so that the > problems are *preserved* (and hence later detected by bytecomp). [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [66.147.241.60 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid Stefan Monnier writes: > Now that I think about it, maybe an alternative for the "let format > checks" is to keep them in bytecomp.el and change cconv so that the > problems are *preserved* (and hence later detected by bytecomp). I thought the point of moving them to macroexp was so the checks happen even when we're not compiling. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 08:34:04 2013 Received: (at 15814-done) by debbugs.gnu.org; 8 Nov 2013 13:34:04 +0000 Received: from localhost ([127.0.0.1]:41150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VemCK-0001lT-8Q for submit@debbugs.gnu.org; Fri, 08 Nov 2013 08:34:04 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:33235) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VemCH-0001kx-94 for 15814-done@debbugs.gnu.org; Fri, 08 Nov 2013 08:34:02 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpYcl/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhiT+SWoFegxU X-IPAS-Result: Av8EABK/CFFFpYcl/2dsb2JhbABEuzWDWRdzgh4BAQQBViMQCw4mEhQYDSSIHgbBLZEKA4hhiT+SWoFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37374639" Received: from 69-165-135-37.dsl.teksavvy.com (HELO pastel.home) ([69.165.135.37]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Nov 2013 08:33:55 -0500 Received: by pastel.home (Postfix, from userid 20848) id 1A59760090; Fri, 8 Nov 2013 08:33:55 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> Date: Fri, 08 Nov 2013 08:33:55 -0500 In-Reply-To: <87zjpf5dgl.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Fri, 08 Nov 2013 06:40:10 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Now that I think about it, maybe an alternative for the "let format >> checks" is to keep them in bytecomp.el and change cconv so that the >> problems are *preserved* (and hence later detected by bytecomp). > I thought the point of moving them to macroexp was so the checks happen > even when we're not compiling. No, the point was mainly to consolidate the checks from 2 places to a single place. If people don't compile their code, they get very little feedback about the quality of their code, and I don't think it's important to change this state of affair. macroexp--warn* is handy when you need it (e.g. in cl-symbol-macrolet), but it's a hack, so if we don't need to use it, better. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 09:39:26 2013 Received: (at 15814-done) by debbugs.gnu.org; 8 Nov 2013 14:39:26 +0000 Received: from localhost ([127.0.0.1]:41273 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VenDa-0003OJ-1j for submit@debbugs.gnu.org; Fri, 08 Nov 2013 09:39:26 -0500 Received: from oproxy17-pub.mail.unifiedlayer.com ([74.220.201.171]:51562) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1VenDX-0003OA-MC for 15814-done@debbugs.gnu.org; Fri, 08 Nov 2013 09:39:24 -0500 Received: (qmail 30013 invoked by uid 0); 8 Nov 2013 14:39:19 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy17-pub.mail.unifiedlayer.com with SMTP; 8 Nov 2013 14:39:19 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=kVx/tIEohAnVJ5LdQuwU3ecZzx6EYrE38bcq54U86w8=; b=DWBxjqWk60R1b4M+rv9hDZLHsTQkzVGFGTAVG4h9m0CMY9CrdngvybuFi3+Vp5L/SQ3GMCzz9wPBmCwoGNTbo6LYzVZ44LSssfaSB4eb5zfmQ1BBCMC0cDrr8zepXnmE; Received: from [50.90.253.209] (port=53988 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VenDT-0002Pl-B1; Fri, 08 Nov 2013 07:39:19 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> Date: Fri, 08 Nov 2013 09:39:06 -0500 In-Reply-To: (Stefan Monnier's message of "Fri, 08 Nov 2013 08:33:55 -0500") Message-ID: <87ob5vj6ut.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >>> Now that I think about it, maybe an alternative for the "let format >>> checks" is to keep them in bytecomp.el and change cconv so that the >>> problems are *preserved* (and hence later detected by bytecomp). We can make cconv work while preserving the malformed bindings, but when the compiler prints the warnings, there's a good chance that the malformed binding that gets printed will not look like the binding as it appears in the source, since cconv might transform the VALUE part. Therefore I think it's preferable to use byte-compile-log-warning in cconv. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 14:06:52 2013 Received: (at 15814-done) by debbugs.gnu.org; 8 Nov 2013 19:06:52 +0000 Received: from localhost ([127.0.0.1]:42040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VerOO-00035h-9e for submit@debbugs.gnu.org; Fri, 08 Nov 2013 14:06:52 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:46067) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VerOL-00035Y-TS for 15814-done@debbugs.gnu.org; Fri, 08 Nov 2013 14:06:50 -0500 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rA8J6nGI003884; Fri, 8 Nov 2013 14:06:49 -0500 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id E1CE4B4327; Fri, 8 Nov 2013 14:06:48 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> <87ob5vj6ut.fsf@nbtrap.com> Date: Fri, 08 Nov 2013 14:06:48 -0500 In-Reply-To: <87ob5vj6ut.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Fri, 08 Nov 2013 09:39:06 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4756=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4756> : inlines <207> : streams <1070268> : uri <1589499> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >>>> Now that I think about it, maybe an alternative for the "let format >>>> checks" is to keep them in bytecomp.el and change cconv so that the >>>> problems are *preserved* (and hence later detected by bytecomp). > We can make cconv work while preserving the malformed bindings, but when > the compiler prints the warnings, there's a good chance that the > malformed binding that gets printed will not look like the binding as it > appears in the source, since cconv might transform the VALUE part. > Therefore I think it's preferable to use byte-compile-log-warning in > cconv. OK, fair enough, Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 21:06:43 2013 Received: (at 15814-done) by debbugs.gnu.org; 9 Nov 2013 02:06:43 +0000 Received: from localhost ([127.0.0.1]:43150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vexwg-0006wX-CZ for submit@debbugs.gnu.org; Fri, 08 Nov 2013 21:06:42 -0500 Received: from oproxy7-pub.mail.unifiedlayer.com ([67.222.55.9]:51381) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1Vexwc-0006wM-NN for 15814-done@debbugs.gnu.org; Fri, 08 Nov 2013 21:06:40 -0500 Received: (qmail 26040 invoked by uid 0); 9 Nov 2013 02:06:36 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy7.mail.unifiedlayer.com with SMTP; 9 Nov 2013 02:06:36 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=BiMpO/4QfvdE3iZkpRrulZFmTRqfJXiiMykb4btE36U=; b=HC7kvRS4WEqsKn6qBvT7U73tltqthwFFvQFn/lS+A6K9H/j8A48zdFDskOzVb+vvZIcwEb3GL+mhrD7rVp1kdjoNG9zO2bilAYDG8qKgnkTYH9mqBKzxFFh+QuweCrfu; Received: from [50.90.253.209] (port=59837 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1Vexwa-0002za-9P; Fri, 08 Nov 2013 19:06:36 -0700 From: Nathan Trapuzzano To: Stefan Monnier Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> <87ob5vj6ut.fsf@nbtrap.com> Date: Fri, 08 Nov 2013 21:06:34 -0500 In-Reply-To: (Stefan Monnier's message of "Fri, 08 Nov 2013 14:06:48 -0500") Message-ID: <87fvr69vmd.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814-done Cc: 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Stefan Monnier writes: >> We can make cconv work while preserving the malformed bindings, but when >> the compiler prints the warnings, there's a good chance that the >> malformed binding that gets printed will not look like the binding as it >> appears in the source, since cconv might transform the VALUE part. >> Therefore I think it's preferable to use byte-compile-log-warning in >> cconv. > > OK, fair enough, --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=cconv.el.patch # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: nbtrap@nbtrap.com-20131109010452-m4od51q5sllj5llv # target_branch: file:///home/nathan/opt/etc/bzr-repos/emacs/trunk/ # testament_sha1: a475ad3ca1826fb0b56abf8dfb460185dd5fd144 # timestamp: 2013-11-08 20:28:15 -0500 # base_revision_id: dgutov@yandex.ru-20131108112252-g8bofo4jray5k45v # # Begin patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2013-11-08 11:22:52 +0000 +++ lisp/ChangeLog 2013-11-09 01:04:52 +0000 @@ -1,3 +1,8 @@ +2013-11-09 Nathan Trapuzzano + + * emacs-lisp/cconv.el (cconv-convert): Print warning instead of + throwing error over malrofmed let/let*. + 2013-11-08 Dmitry Gutov * progmodes/ruby-mode.el (ruby-smie--indent-to-stmt): Use === modified file 'lisp/emacs-lisp/cconv.el' --- lisp/emacs-lisp/cconv.el 2013-11-04 19:48:07 +0000 +++ lisp/emacs-lisp/cconv.el 2013-11-08 16:50:27 +0000 @@ -291,9 +291,9 @@ (let* ((value nil) (var (if (not (consp binder)) (prog1 binder (setq binder (list binder))) - (cl-assert (null (cdr (cdr binder))) nil - "malformed let binding: `%s'" - (prin1-to-string binder)) + (when (cddr binder) + (byte-compile-log-warning + (format "Malformed `%S' binding: %S" letsym binder))) (setq value (cadr binder)) (car binder))) (new-val # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWRnlTkQABHp/gACwCwBS9/// XidMAP////BgCA+8Z97xsBoDebjpkOglRp2BKQU9UfqnpMI0PU/RTxGmoNMQDI0yaYAJJEYIGgFP U1GUZPU0MjQ0AABoOaYmTJowmCYmmATAIYIwIwCRTKTCnio9TyjRmmmo8k9Q0aA0Ho1D1DQEVJqY 1TGUaPUaZGgPUGjQAAAACKSNAJonpT0wQk/KZpqbSTTTEAaBo9RyIxPii2QhWaJaTPGncduwU8JV tiNejlnkn5/tvMJdOQlOOpSuAb3NjlYVVPCUSpJknRSakAoE03Ty47/u+HblepbjEaTGDr3iuhVg +PwkDIKposzzzxhBQczVnzJmW8O3DeZPBofIejbkpNvikmzmIX9/fCigsKsclOqZXLk6K8IJURVK oSssX65FBc9N8i4psuFhFEprxi9LHy0z56llkdMTTo6nvpfX9wGucy8pERWmxJiahjUYTHVuIWet qMIJ6KXNc3hHvMSSm5K4UVgwoMHdyHKGwGNwMwlxtoiMxmdpLeJxmCKGa7hudG9/lgS12QlJLkPX 8CsrKFy1wwc5znO8CJMQdlFDjO5M7vkFYTLBlQqwFW4sPfSbUPESeqVNiQMc/KuduONgShQqn86B pSjG2SFK4mcotzkZrWt3BeX9Q565LXMws82kPugaIGEXeOniyrFaksC9JIUsmqecNKN65oz3Yyzm hVnTwSt4oMgxLJiOyxUw0UkWoKR+uagB5RJSqlnQWC0rV+4/a2JQ7vTEXec5wIj7C0HCGE0n6IPc wkrEdzVpr2KBTYgwwRwaI9gyP8LTWDkG+2NMQvvcZ8PEXQLBcMOhGjLSVatY8SVIGIjaxGvYl1sS drtIyOovU8sGgGy3HwWOqwVhjO6K2tyyJnuERQPnohhFut/F6DCMUO3ObSNXJFqLAoDhYBu/Syb+ wUhyPCLJigtBOwKmw1kfQHMaQ2FZEBpQyikuGwJjelxBozaqaiYZSIUIc0LJFeTgmOPeiMvhD3is FujMMDFsRx35VaDujRgiOQNsdecqXmu1z58LblhY8kayhkr3q+TCHVGZoka0hoPtucYyRS5yxWKD IiWJ843Xo+QO5A4MS9F2HQyMqIsvckG8zMhiaVWphALaXi0L7t7wgobJifpDdw/xz4lnbvCDuD5S u7OIoao8V9XCZrjEHUdJrM3EDmxcDG5Q8VuoiGVKxpkee4OR5lB5kc+yeC0SrPpZWDLAW4Wpk1LQ zLcEoYoQaGE4yEpoYPWnMlo4Qyuq8Q2zQL0ttvZpW5UW31IS6QsvQ0DGfjXa4lkYkg9wwld5Yqgj 16pFUbbbcuisFbrK/KynUHgDpegmdh5Ms/72mnPSgVm6my6EdTa3+5q5okEcuoLXWeIUBoCkVcDX 1KyOgWYJm+oSbi0LhPPI1nX9ntQ8TeXITPDnPndNu7skOt7Q7neIuxPp3ozsMDT005yiCo++G3HM wc+RBBqmR0+WJk7MpWRb9SLU89ZWZRYkm8VPCkYkJsWHgceLWoKcDT8B2FV63IV1X0srELdva7Sc dU98iJ77W+B2aws5DSHEMDF01J8Q+BxYYOPI5FHOCmcNPlRUQ7966PVxPq3j1QjCMWZ0uxt6ik7K Ha2hBcrJb4izTlcZphGEy011nVgtPHF9yM/BYo3CW271ipb9608k1221ssCT3S9X0aRtMOXiayWs cEJSElsLmUbbH199kyo4NLNtdo3CSB1BYFAlyHyEqeLq2fJLPsknI3VGvtPXNOYTLqOwkSqkWNPj eRMYT2F+ofcJ/D3vY6dkBI6QHk7ghkTnCQGAeoKNyDYqDEdNB40OQNJszKUDgFYHAgwLEEgY9CRk JqZBwc0YOh9EIZTZjPQhsR9kDBMcXLgJ0QxvzwYRDXg7dzk2PbmNYP928ge1JeDsqaVxDwDftE7w k9Ym8TsEo8wv9ZBEBEA4A4MgdxWxCHvdDmY5CWh0uJ7qbx2Mx4OQ4lldaFHZ4eCDUMBS4hMCtYfZ G3udIqJ2KMK1QUK2qQcENCdLUaEJZzMOxDKDoDKDpzharhliSYMLliXEASDOhBK4ZwrqDikiv6w6 FaJSEkLJCCMrA6+JdSF6NQoxT0B3HkXOkBedzBexcsjYBYF7wEdeFKPtpQyqkE9NGT1osXskWe5h hCgbGG3bMJvArDihsTmP4CU8zDPRKJAyE2vUIvoHzDO0Vq1enUaHm5DUYeVlZZJGYb7u2ut2fEuA n9oST0z0HtKc3t4UPTLzrMuWrLYdBhmTZq8FDY7IYgiLzzG6oLmIcxcJSxXPEn6RjGe1kykzaHeM 33SZE2dreOtrQpChD+ZOq9xHQVF4SpCwMgizEWFMEK8DJyk4QbJnOv9CFr3sX7LzHYPqcHIZiTUD zGwdkZLkcEIoIjG4KqCiBwewNr7w8mn3I4RcwTCoMkHrDNLJlmHX0g4Rxdkgf8wUEeISBy7B/4u5 IpwoSAzypyIA --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 03:36:41 2013 Received: (at 15814-done) by debbugs.gnu.org; 9 Nov 2013 08:36:41 +0000 Received: from localhost ([127.0.0.1]:43550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf424-0008KA-SB for submit@debbugs.gnu.org; Sat, 09 Nov 2013 03:36:41 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:33229) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf423-0008K1-97 for 15814-done@debbugs.gnu.org; Sat, 09 Nov 2013 03:36:40 -0500 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3dGsC74Ldbz3hhqk; Sat, 9 Nov 2013 09:36:35 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3dGsC722ZRzbbfY; Sat, 9 Nov 2013 09:36:35 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id mqtujcYl6ppL; Sat, 9 Nov 2013 09:36:34 +0100 (CET) X-Auth-Info: UMhArG57X1QmNswBjvObwM8hOjhei0zLn2j/NNKgGlk= Received: from linux.local (ppp-88-217-38-96.dynamic.mnet-online.de [88.217.38.96]) by mail.mnet-online.de (Postfix) with ESMTPA; Sat, 9 Nov 2013 09:36:30 +0100 (CET) Received: by linux.local (Postfix, from userid 501) id D61E61E5788; Sat, 9 Nov 2013 09:36:26 +0100 (CET) From: Andreas Schwab To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> <87ob5vj6ut.fsf@nbtrap.com> <87fvr69vmd.fsf@nbtrap.com> X-Yow: YOW!! Date: Sat, 09 Nov 2013 09:36:26 +0100 In-Reply-To: <87fvr69vmd.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Fri, 08 Nov 2013 21:06:34 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814-done Cc: Stefan Monnier , 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Nathan Trapuzzano writes: > + * emacs-lisp/cconv.el (cconv-convert): Print warning instead of > + throwing error over malrofmed let/let*. s/malrofmed/malformed/ Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 09 07:00:57 2013 Received: (at 15814-done) by debbugs.gnu.org; 9 Nov 2013 12:00:57 +0000 Received: from localhost ([127.0.0.1]:43763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vf7Dk-00055R-0L for submit@debbugs.gnu.org; Sat, 09 Nov 2013 07:00:56 -0500 Received: from oproxy16-pub.mail.unifiedlayer.com ([69.89.22.201]:44208) by debbugs.gnu.org with smtp (Exim 4.80) (envelope-from ) id 1Vf7Dg-00055G-QW for 15814-done@debbugs.gnu.org; Sat, 09 Nov 2013 07:00:54 -0500 Received: (qmail 23049 invoked by uid 0); 9 Nov 2013 12:00:48 -0000 Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy16.mail.unifiedlayer.com with SMTP; 9 Nov 2013 12:00:47 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=3hiDhJryh8ooMd/KOQhUVKJ+VOxXz/Kr7kCL07UZRmc=; b=WW5TjtbnAJ3K4tx4ULDF7+pkF8tuwugSXmMA4oJkGAvJdtg+RmMBlIDIDD1uRjGvhosok+EpDcQrM+ONXKc+Iv9GgnjllBhkBHBna+C2UjoFJFpALffm5MZ7B4FoK1gA; Received: from [50.90.253.209] (port=41788 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1Vf7Da-0006Is-Dq; Sat, 09 Nov 2013 05:00:47 -0700 From: Nathan Trapuzzano To: Andreas Schwab Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> <87ob5vj6ut.fsf@nbtrap.com> <87fvr69vmd.fsf@nbtrap.com> Date: Sat, 09 Nov 2013 07:00:38 -0500 In-Reply-To: (Andreas Schwab's message of "Sat, 09 Nov 2013 09:36:26 +0100") Message-ID: <87txfldbtl.fsf@nbtrap.com> User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15814-done Cc: Stefan Monnier , 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain Andreas Schwab writes: >> + * emacs-lisp/cconv.el (cconv-convert): Print warning instead of >> + throwing error over malrofmed let/let*. > > s/malrofmed/malformed/ Thanks. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=fixed-cconv.el.patch # Bazaar merge directive format 2 (Bazaar 0.90) # revision_id: nbtrap@nbtrap.com-20131109115727-jhn9e1k2ua493zox # target_branch: file:///home/nathan/opt/etc/bzr-repos/emacs/trunk/ # testament_sha1: 73a49428b51bbcbec941aab9e1b5eec802a8ab58 # timestamp: 2013-11-09 06:58:55 -0500 # base_revision_id: dgutov@yandex.ru-20131108112252-g8bofo4jray5k45v # # Begin patch === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2013-11-08 11:22:52 +0000 +++ lisp/ChangeLog 2013-11-09 11:57:27 +0000 @@ -1,3 +1,8 @@ +2013-11-09 Nathan Trapuzzano + + * emacs-lisp/cconv.el (cconv-convert): Print warning instead of + throwing error over malformed let/let*. + 2013-11-08 Dmitry Gutov * progmodes/ruby-mode.el (ruby-smie--indent-to-stmt): Use === modified file 'lisp/emacs-lisp/cconv.el' --- lisp/emacs-lisp/cconv.el 2013-11-04 19:48:07 +0000 +++ lisp/emacs-lisp/cconv.el 2013-11-08 16:50:27 +0000 @@ -291,9 +291,9 @@ (let* ((value nil) (var (if (not (consp binder)) (prog1 binder (setq binder (list binder))) - (cl-assert (null (cdr (cdr binder))) nil - "malformed let binding: `%s'" - (prin1-to-string binder)) + (when (cddr binder) + (byte-compile-log-warning + (format "Malformed `%S' binding: %S" letsym binder))) (setq value (cadr binder)) (car binder))) (new-val # Begin bundle IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWfliC0cABdr/gACwCwBS9/// XydMAP////BgCc+KkAAAAAAAAAAABKUzU9RT1GTT1APNSP1Q09QGnqAA0yaNNqDmjJiYAJiMCNMC DEYJkwCMOaMmJgAmIwI0wIMRgmTAIw5oyYmACYjAjTAgxGCZMAjDmjJiYAJiMCNMCDEYJkwCMCqI gAgCaNBDQaE9Q0mSaPUPKaNo1GRHhT4xpKqoTSgUo3zvoxRoNIr9VDC5nTmjNNGEb/62ZjzvmVFs 8ERfIZmmzjNuCVx50mlq2KG6yOyAqhyyt4e/9//J/+/bfPuP+o2RMEpTMTf+8GVS9EujmqlVbYpH GeVlOhMXVUttut5cSW/RDLezDUwkqOjnZy6m4os+FHhd+/jgeTkt9nWqoVtZrhNVhWttkUiw3109 9gqyny0sGdmGShnn8KW5Cuzvo4DFHLYOMAxEicQNi5tjjovHgISyzTKckgISZ9eHYqFshjLbLivB uqjytO2Qdw7e0G9cGMIBpDWHttPWIEnv8X4HkdTeeaKoWnwvqhR6nuF31OrfWD1ynpnW/T7rL/ls U5cxDGI7TD2lm7C67M4660pSlKUpTyYRkI7yamxbmNp30Ly1ghSsEJLurB8vxtdYKoW86WYCUJyf P64XZbGzEpMQWXT/WqFglFduNIKzEwbWauO1OuJea9Tfq1oL7ZpBfa0w9Sw+0orKExEFneOPmYbB DUci/AVRS8wNV1xxrnZwtyrgnEpdBC0f8RGw49maSNpblEPA2n9MzkjRGUL4O1XG/IvHxwY48IOi eWY2lOfKrjNL09ltzJ3e+5F6HF2t9b2CxasKIShONeBH5yIWDuncyce5kZcl0pNcJmt6yTc/hc28 cLUWQc+G3HPaa60cOysIv1pN600So7KKfmjHKdVI5MtcpsqIZ3G1DfYOXgw2OvJzZV52Ytzr0wsh m37cFMDodFbzTipv7GqbS1S5u0v2Yxjvv37WTsQwg0RZZpyN6cqoWc6bum0jfhaKZty0v30ItFiM iiG053Wcc+yq/OneaY7UXrDGYmSWo5Cm1c3psv9580LDkvJk3Qcc6cFzRCuRehcaWMKtEm/s4buL suRf01VLaMc192xZtYtmrcyUf6GGPuP9IWIdg5Gxtnao67d87L68nPlQxW1golyd3ipdwpLXYnTn hnbl0OeyRi27b+jHfXBWbTZZDZEYTBdNW5VSk4MEUTuyvzVXYXVbMIZM8Kmw2EZbmK2LLMNNR8zt goZtEZ7tnclG/OFut1UOcwTk4OOG4v3lidbi2rK7RGfBOLPhy1MTDkS14e8wqyt9nDs35zblddTs T9G/jNF4nfFUNd9IiJnNtKUbViMrcZt4UWujpaYRLpgpHRo9h0MoiJOF836b+PxRTy2HVVxwq4uv rntOyDhjTkb6RJqO0tJJvLikFkRFxUiS4m0YQi+4k/SH4w+I6w+h1M0pS8h0mZmZn4ew/Uoen1EP Uw0iJiEzMx+/sxTWbKRXYshP6phYbTYUhHr7bBa+OOO/wvD2Mvf4zj7vsiiv4lrTSju912zy1bXk sbVnw/n7Onh5Re57866R3HlCPLKbf8ZGk3rkeB3wxPB8ysRvhZCENG7eQo9TDRGv8QoZMTJD7+Du dO/7oPD6vJnBc6+V131zujP6+L284O6ND2HiEOo/b0gW4Mtjn58OdtjgmWEfnMZ7tpL6/FKXS1OX z3bnE9uLFzqa7BDYfba2vpERVhGbZHaitU069vod9uzj4dcVvAt/JDuX6waEX3a2FMCMeucdzZdT hd30Td35RpKN+fQx+QtPM1bTlcPzPyecSS8/k+SvzlZbMWfWtyTs746+kzh0nrbXpKPS6++y+ZpG Ha5ejLGzJ3zbk8V8dpuOzbHCSYmhpHAmEbMlzly4suEwubNtdBw8jaOcMObOpsMObn1OPxiMMsvX ErsaVM/ZZ2fsWjQ2+nzdyncNpFKQijqyik9+B7fjgtXPMsi0xjvGUIoHaYFUMiP0QuPfHTv6v0hj 50h6Oq32YL+6r3Xj6FzOvivVVvoxi356ptEj4xh2D8EP3PkeJy7pKPWYfcd8JKLbZRMRocivfB2l ImEetCdlHceT4cSyCahhD+8VNWEFg2er70VjjCOwpDzjZOpvP5IkpaWi3fB3Ij4SJWjbHHzhH4Qb M9yWkzF+kde84mB5au0P/cfQPJFPkf47ry2IbTtR6HjqiqHyKnRDwhHkhX8DT3JTJMhqGpQO9eTM Q/I4GpPzQxh97Jb32Zodxah5nBDYYX3oivj6ekQLkJhZGyFqF4mPhLv9hxFCcCut5QVjG2yE1VmD 70SKVyR7BDm5JxhKiaEqJpCVE090MjNLBBJJkbWSsFkRL5wWHv3F90PgKL/4mNxCtKQikRFCJTxw h0+L0ztNB70K7YnyP8x3w90RENX+ZD7HjYmYGENJbIR/bSwNthHC6ha41ZI4HYIToUELupJJFRiT Hsz63Fx5sIe+DuHoh+iFn0a71aJpCKQjqcQh/MPwNsVvIXfzvbj6HAXNPuwvYUC08MvK+86vpGSG P9jCKxNSPsy6aT7cnww8jezOMxyUulKYTvNAkwjtmJlMxM5vVDK6GRMmrKEWRN9uxb/M7J24lClC 0qd4tPZQotLcTMdC+CyFYP7qHPM2DcuZwjUjkeIQorE3yRs3mEYfQuJP6o51jPX84Pkd8tnOPF4H 9KQ7TjEROR4t54DbHauqmZTN5F8S7A3QZQUPvOemh8pxdw7BnV3SqZFN5NEQ9ThBuk4GH5FEOzs1 3QWfWGaHtMYUPojwh/+LuSKcKEh8sQWjgA== --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 23:56:08 2013 Received: (at 15814-done) by debbugs.gnu.org; 11 Nov 2013 04:56:08 +0000 Received: from localhost ([127.0.0.1]:46152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfjXj-0001va-Ig for submit@debbugs.gnu.org; Sun, 10 Nov 2013 23:56:07 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:35964) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VfjXh-0001v6-Nq for 15814-done@debbugs.gnu.org; Sun, 10 Nov 2013 23:56:06 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCqr1/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFMCqr1/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37546572" Received: from 76-10-170-245.dsl.teksavvy.com (HELO pastel.home) ([76.10.170.245]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Nov 2013 23:55:59 -0500 Received: by pastel.home (Postfix, from userid 20848) id 9349E60E1D; Sun, 10 Nov 2013 23:55:59 -0500 (EST) From: Stefan Monnier To: Nathan Trapuzzano Subject: Re: bug#15814: 24.3.50; Signal error on malformed bindings in `cl-symbol-macrolet' (patch) Message-ID: References: <87k3gmmvk9.fsf@nbtrap.com> <87a9himfvp.fsf@nbtrap.com> <87ppqd2314.fsf@nbtrap.com> <871u2tgghu.fsf@nbtrap.com> <87mwlggakp.fsf@nbtrap.com> <87r4as6ldm.fsf@nbtrap.com> <87zjpfof3y.fsf@nbtrap.com> <87zjpf5dgl.fsf@nbtrap.com> <87ob5vj6ut.fsf@nbtrap.com> <87fvr69vmd.fsf@nbtrap.com> <87txfldbtl.fsf@nbtrap.com> Date: Sun, 10 Nov 2013 23:55:59 -0500 In-Reply-To: <87txfldbtl.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Sat, 09 Nov 2013 07:00:38 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15814-done Cc: Andreas Schwab , 15814-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Thanks. Installed, Stefan From unknown Sat Sep 06 02:44:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 Dec 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator