GNU bug report logs - #15809
24.3.50; wrong defcustom type for `suggest-key-bindings'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Tue, 5 Nov 2013 15:32:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 24.3.50

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Drew Adams <drew.adams <at> oracle.com>
To: Stefan Kangas <stefan <at> marxist.se>, Mattias Engdegård <mattiase <at> acm.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, "15809 <at> debbugs.gnu.org" <15809 <at> debbugs.gnu.org>
Subject: bug#15809: [External] : Re: bug#15809: 24.3.50; wrong defcustom type for `suggest-key-bindings'
Date: Sat, 25 Sep 2021 15:31:46 +0000

> >> (define-widget 'natnum 'restricted-sexp
> >>   "A nonnegative integer."
> >>   :tag "Integer (positive)"
> >
> > Sorry, but this is just wrong. 0 is not a positive integer.
> 
> The text does not say that zero is positive.

The doc string doesn't, but the tag appears to.
The tag should anyway say what the field is for,
not (usually) what its type is.

If you do add indication of the type to the tag
(i.e., in addition to the field description -
what the field is for / means), then please use
what you have in the doc string.

The field value must be a nonnegative integer.
It need not be a positive integer.
This bug report was last modified 3 years and 243 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.