GNU bug report logs - #15809
24.3.50; wrong defcustom type for `suggest-key-bindings'

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Tue, 5 Nov 2013 15:32:01 UTC

Severity: minor

Tags: fixed, patch

Found in version 24.3.50

Done: Mattias Engdegård <mattiase <at> acm.org>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 15809 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 15809 <at> debbugs.gnu.org
Subject: RE: bug#15809: 24.3.50; wrong defcustom type for
 `suggest-key-bindings'
Date: Sat, 8 Feb 2014 18:14:42 -0800 (PST)

> > Instead of `integer' the `choice' should use `number' (and the
> > code should then ignore negative values) or `restricted-sexp'
> > with a test that the time be non-negative.
> 
> Or to be more general, perhaps there should be a custom interval
> type?  Like (integer :minimum 1)
> Or just `natnum'?

That's what `restricted-sexp' is for.  In this case it is a simple
expression.

(And what you suggest is not more general but less general than
`restricted-sexp'.  But that's OK too.)
This bug report was last modified 3 years and 243 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.