GNU bug report logs - #15808
24.3; thing-at-point slow for url and email

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Liu <sdl.web <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15808: closed (24.3; thing-at-point slow for url and email)
Date: Wed, 06 Nov 2013 09:12:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 06 Nov 2013 17:10:56 +0800
with message-id <m1mwlh3nfj.fsf <at> gmail.com>
and subject line Re: bug#15808: 24.3; thing-at-point slow for url and email
has caused the debbugs.gnu.org bug report #15808,
regarding 24.3; thing-at-point slow for url and email
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15808: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15808
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; thing-at-point slow for url and email
Date: Tue, 05 Nov 2013 10:52:10 +0800

GNU Emacs 24.3.1 (i386-apple-darwin13.0.0, Carbon Version 1.6.0 AppKit
1265) of 2013-10-27 on localhost

While using M-w in simple.el using easy-kill I noticed some delays which
are due to slow (thing-at-point 'url) and (thing-at-point 'email).

If I narrow the buffer, they become instant. However slowness doesn't
appear to be proportional to buffer-size, I tried the org.el file and
they were instant there.

For example

1. goto function next-error-buffer-p in simple.el
2. eval (benchmark-run 10 (thing-at-point 'email))
3. eval (benchmark-run 10 (thing-at-point 'url))

email: (4.415538 0 0.0)
url: (6.74361 0 0.0)

What is choking the regexp engine?

Leo

[Message part 3 (message/rfc822, inline)]

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 15808-done <at> debbugs.gnu.org
Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email
Date: Wed, 06 Nov 2013 17:10:56 +0800

Fixed in 24.4.

On 2013-11-06 14:55 +0800, Stefan Monnier wrote:
> Looks OK, thanks.  Maybe other calls to thing-at-point-looking-at could
> benefit as well.

Both url and email used to use thing-at-point-looking-at. But the URL
case has been re-written. So there is only one use of
thing-at-point-looking-at i.e. it's all covered.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.