From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 21:52:49 2013 Received: (at submit) by debbugs.gnu.org; 5 Nov 2013 02:52:49 +0000 Received: from localhost ([127.0.0.1]:34870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdWl6-0000uX-Ss for submit@debbugs.gnu.org; Mon, 04 Nov 2013 21:52:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37009) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdWl5-0000uK-22 for submit@debbugs.gnu.org; Mon, 04 Nov 2013 21:52:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdWkr-0006nU-I4 for submit@debbugs.gnu.org; Mon, 04 Nov 2013 21:52:41 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37637) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdWkr-0006nP-F3 for submit@debbugs.gnu.org; Mon, 04 Nov 2013 21:52:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdWkj-00006W-1X for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 21:52:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdWka-0006lp-Kd for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 21:52:24 -0500 Received: from mail-pd0-x229.google.com ([2607:f8b0:400e:c02::229]:65268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdWka-0006ll-DJ for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 21:52:16 -0500 Received: by mail-pd0-f169.google.com with SMTP id q10so7540704pdj.14 for ; Mon, 04 Nov 2013 18:52:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=TwLSc7jMSlbbAyeqjeaC0ekMj9OVPOkyPTACm6ci6uM=; b=lBu3s9e4MsmoufS3VKQ6CdrRj30PnaqbE1QsLyyrrMViMB3PTQqBse/2PgJo3HnXNQ Kajd1SaNxD7BGr5QYeSkbV3DMhEbhjdpViKuxnTzPZX/u2BUa0V4U49a0ZXdCfOt0B4W +CA+tVECVWzK8kBMqsJVNpavWt+4hC9CxMYWImb2jnHcJpA9ufutAYsev2czg8oHrbOp HLNtL5UYn5fQ1K3AiQvPE3OV0pdVM/8YEWLZIW5cmeEa19NPt0Z3w2YuheW4vu+NAlQs pYfsp8dQM/B+yU42fK6DRhHf5Ta7OCrAN7GFAksvLevpoUplR34chsSeC7SsdiQ2FD/E Vfjw== X-Received: by 10.68.130.36 with SMTP id ob4mr766472pbb.180.1383619935176; Mon, 04 Nov 2013 18:52:15 -0800 (PST) Received: from localhost ([221.217.232.4]) by mx.google.com with ESMTPSA id hu10sm31220849pbc.11.2013.11.04.18.52.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Nov 2013 18:52:14 -0800 (PST) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; thing-at-point slow for url and email X-Debbugs-CC: Date: Tue, 05 Nov 2013 10:52:10 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) GNU Emacs 24.3.1 (i386-apple-darwin13.0.0, Carbon Version 1.6.0 AppKit 1265) of 2013-10-27 on localhost While using M-w in simple.el using easy-kill I noticed some delays which are due to slow (thing-at-point 'url) and (thing-at-point 'email). If I narrow the buffer, they become instant. However slowness doesn't appear to be proportional to buffer-size, I tried the org.el file and they were instant there. For example 1. goto function next-error-buffer-p in simple.el 2. eval (benchmark-run 10 (thing-at-point 'email)) 3. eval (benchmark-run 10 (thing-at-point 'url)) email: (4.415538 0 0.0) url: (6.74361 0 0.0) What is choking the regexp engine? Leo From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 03:39:43 2013 Received: (at submit) by debbugs.gnu.org; 5 Nov 2013 08:39:43 +0000 Received: from localhost ([127.0.0.1]:35000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdcAp-0001G7-8W for submit@debbugs.gnu.org; Tue, 05 Nov 2013 03:39:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59797) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdcAm-0001Ft-It for submit@debbugs.gnu.org; Tue, 05 Nov 2013 03:39:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdcAX-0001tq-S9 for submit@debbugs.gnu.org; Tue, 05 Nov 2013 03:39:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdcAX-0001ti-PL for submit@debbugs.gnu.org; Tue, 05 Nov 2013 03:39:25 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdcAQ-0004lP-F9 for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 03:39:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdcAG-0001j5-Du for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 03:39:18 -0500 Received: from moutng.kundenserver.de ([212.227.126.186]:53595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdcAG-0001hO-4K for bug-gnu-emacs@gnu.org; Tue, 05 Nov 2013 03:39:08 -0500 Received: from purzel.sitgens (brln-4db90e22.pool.mediaWays.net [77.185.14.34]) by mrelayeu.kundenserver.de (node=mrbap0) with ESMTP (Nemesis) id 0LtlMD-1VngM82q0b-0112S4; Tue, 05 Nov 2013 09:39:06 +0100 Message-ID: <5278AF4E.1050508@easy-emacs.de> Date: Tue, 05 Nov 2013 09:41:50 +0100 From: =?ISO-8859-15?Q?Andreas_R=F6hler?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:Xrt9xUsRQ2STJIZaLbPy1/oMSQbH5VvxBQUmWBVeRJ5 1/zNl2NkTJLb0wPP6ZCFeYtjP6IdHcz8PrO6UNz7RUnI16TriE LFswcfikQVmDnsP/kRVSNMugo0MQtzzqp6IFzGntJoyNGSAlTJ pgTJhZepmjKMqS4C4rXV1vVnwfPEL+srWD6Ct4fDvoFae9iCRX yZPar3WFcVVhbFz48yB5sCxOynVztnQDVXVoMp1EtiORVWaHRl sIT34PUq9bIfrTedD2LEiIZq/L+Z4KZuOyxLKbF/oVxWY2zWBs 36XUU9hfYz4jm/YH6MY2Ga0owA5pxQqnMQhu1er10oXzN6IzLR US41D2uq7JC0EcNTxXnY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Am 05.11.2013 03:52, schrieb Leo Liu: > GNU Emacs 24.3.1 (i386-apple-darwin13.0.0, Carbon Version 1.6.0 AppKit > 1265) of 2013-10-27 on localhost > > While using M-w in simple.el using easy-kill I noticed some delays which > are due to slow (thing-at-point 'url) and (thing-at-point 'email). > > If I narrow the buffer, they become instant. However slowness doesn't > appear to be proportional to buffer-size, I tried the org.el file and > they were instant there. > > For example > > 1. goto function next-error-buffer-p in simple.el > 2. eval (benchmark-run 10 (thing-at-point 'email)) > 3. eval (benchmark-run 10 (thing-at-point 'url)) > > email: (4.415538 0 0.0) > url: (6.74361 0 0.0) > > What is choking the regexp engine? > > Leo > > > > WRT the url-matter: There is no need to delegate proceeding upon a separate function dealing with URL, as the basic scheme already accepts a function. Just put the appropriate one there. Also thing-at-point--bounds-of-well-formed-url seems doing a kind of double-check, which seems good as analyze-tool when bug-reporting, but nothing to fire up all the time. Etc. HTH, Andreas From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 11:32:43 2013 Received: (at 15808) by debbugs.gnu.org; 5 Nov 2013 16:32:43 +0000 Received: from localhost ([127.0.0.1]:36005 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdjYY-0005ZB-SF for submit@debbugs.gnu.org; Tue, 05 Nov 2013 11:32:43 -0500 Received: from relais.videotron.ca ([24.201.245.36]:9618) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdjYX-0005Z2-GP for 15808@debbugs.gnu.org; Tue, 05 Nov 2013 11:32:41 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR002.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MVS00AV8TYGOA90@VL-VM-MR002.ip.videotron.ca> for 15808@debbugs.gnu.org; Tue, 05 Nov 2013 11:32:41 -0500 (EST) Received: by ceviche.home (Postfix, from userid 20848) id 497CA6609C; Tue, 05 Nov 2013 11:32:40 -0500 (EST) From: Stefan Monnier To: Leo Liu Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email Message-id: References: Date: Tue, 05 Nov 2013 11:32:40 -0500 In-reply-to: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15808 Cc: 15808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > What is choking the regexp engine? Try it with M-x profiler-start RET RET ... M-x profiler-report RET. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 19:59:59 2013 Received: (at 15808) by debbugs.gnu.org; 6 Nov 2013 00:59:59 +0000 Received: from localhost ([127.0.0.1]:36381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdrTS-0003Ab-Ob for submit@debbugs.gnu.org; Tue, 05 Nov 2013 19:59:58 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:45526) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdrTQ-0003AN-Iz for 15808@debbugs.gnu.org; Tue, 05 Nov 2013 19:59:57 -0500 Received: by mail-pa0-f48.google.com with SMTP id kq14so9625956pab.7 for <15808@debbugs.gnu.org>; Tue, 05 Nov 2013 16:59:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=UMfqbAvedVYJ0fippKconba+Js0G0WyTHQCtWxMIP2A=; b=B9tfledxcW7yFfgw8TlViys/De+oxbby28DDmEmOCm15vVQyjD1+Yh7NPLnrie2E99 /gmwZ7mHBHFX4VuCeUnEhKJrWjyLWqN7eSErHf6Q2JWJY6dh1oAkMvghFbyWpLNo8d/h RF7BPw8K0k399QO8uV80usPAm8ItNJAf2kI9Chx8ROX80C9lJFkAKc/2Ad6XgKabENq8 Dowtp4IyVhbrOkZv3Z/nTOFkpzF0Aao/SEPi0GpTQvgkVPyqE3WTZ5ypRH3rISVkZAtz XbgtOaSC5kPD/1xTlAOtm7APOuiuOJ5iR7hijNBUwZESRbrIWRd6zhqwc1sloAWAAtFD NZZA== X-Received: by 10.66.147.38 with SMTP id th6mr1189261pab.66.1383699590126; Tue, 05 Nov 2013 16:59:50 -0800 (PST) Received: from localhost ([221.217.232.4]) by mx.google.com with ESMTPSA id xs1sm43575583pac.7.2013.11.05.16.59.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2013 16:59:49 -0800 (PST) From: Leo Liu To: Stefan Monnier Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Wed, 06 Nov 2013 08:59:42 +0800 In-Reply-To: (Stefan Monnier's message of "Tue, 05 Nov 2013 11:32:40 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15808 Cc: 15808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2013-11-06 00:32 +0800, Stefan Monnier wrote: > Try it with M-x profiler-start RET RET ... M-x profiler-report RET. > > > Stefan I got the following which doesn't seem useful. Am I wrong? Thanks - Leo CPU: + if 144 35% + let 141 34% + call-interactively 83 20% Automatic GC 20 4% redisplay_internal (C function) 11 2% + read-from-minibuffer 4 0% + easy-kill 1 0% + list 1 0% MEM: + call-interactively 6,531,039 99% redisplay_internal (C function) 14,256 0% + let 74 0% From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 21:19:01 2013 Received: (at 15808) by debbugs.gnu.org; 6 Nov 2013 02:19:01 +0000 Received: from localhost ([127.0.0.1]:36406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdshx-00056O-BG for submit@debbugs.gnu.org; Tue, 05 Nov 2013 21:19:01 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:22010) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdshv-000569-23 for 15808@debbugs.gnu.org; Tue, 05 Nov 2013 21:18:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GsR+QDo0Pg3sDiGGcGYFegxWBUQ X-IPAS-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GsR+QDo0Pg3sDiGGcGYFegxWBUQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37183812" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 05 Nov 2013 21:18:52 -0500 Received: by pastel.home (Postfix, from userid 20848) id 9570A60A07; Tue, 5 Nov 2013 21:18:52 -0500 (EST) From: Stefan Monnier To: Leo Liu Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email Message-ID: References: Date: Tue, 05 Nov 2013 21:18:52 -0500 In-Reply-To: (Leo Liu's message of "Wed, 06 Nov 2013 08:59:42 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15808 Cc: 15808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> Try it with M-x profiler-start RET RET ... M-x profiler-report RET. > I got the following which doesn't seem useful. Am I wrong? Thanks - Leo You need to `C-u RET' on the lines with the + to see more details. > + if 144 35% The count is too small: this is a sample-based profiler, so you need a long enough runtime to get meaningful results (otherwise, the various stack fragments collected can't be pieced together to get the whole tree). Also, it seems some of the code is interpreted. If the result is still hard to interpret, you might want to try and byte-compile that code. > + call-interactively 6,531,039 99% That looks much more promising. What does C-u RET show? Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 22:35:53 2013 Received: (at 15808) by debbugs.gnu.org; 6 Nov 2013 03:35:53 +0000 Received: from localhost ([127.0.0.1]:36437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdtuK-0006us-KJ for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:35:52 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:37062) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdtuJ-0006ue-2H for 15808@debbugs.gnu.org; Tue, 05 Nov 2013 22:35:51 -0500 Received: by mail-pd0-f170.google.com with SMTP id v10so9685937pde.1 for <15808@debbugs.gnu.org>; Tue, 05 Nov 2013 19:35:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=K6N7uksfcTshKOAbQyPZzdpb3AHl35/TMvb09WgLXgY=; b=a41ReONEtpy3J9kBdn/sQ68xGchmnf3TvsFgmg9G20duT9hLDpMUU8j9eawLAn8EA6 5ZR7QIPdgTwla89gpnGOta6pTRLOdY7GyQ8NqMbOXb9xphR65dpRE069sTMe5j3srYLU 6LJpnLk48lMKuwEpQre5aVopVtNUaQ2yI6LnkE5O/PIK+43w80snbv+1FJ2x4KRL4UtF luSUg4yU0wox3+paPxbggBfHUWPFpfghEx7wZau5EMFKUG32arZ/yRrZvPmjIIU65ZOU 0kVdmOMX6wd6MZhZ58lO9ENMAjJJ8EKgErKhF+60PjH1TS5KqQkoPfrzaaYzoosP+GZ1 kr/g== X-Received: by 10.66.7.163 with SMTP id k3mr1688569paa.11.1383708944699; Tue, 05 Nov 2013 19:35:44 -0800 (PST) Received: from localhost ([221.217.232.4]) by mx.google.com with ESMTPSA id pl1sm37944870pbb.20.2013.11.05.19.35.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2013 19:35:44 -0800 (PST) From: Leo Liu To: Stefan Monnier Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Wed, 06 Nov 2013 11:35:39 +0800 In-Reply-To: (Stefan Monnier's message of "Tue, 05 Nov 2013 21:18:52 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15808 Cc: 15808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 2013-11-06 10:18 +0800, Stefan Monnier wrote: > The count is too small: this is a sample-based profiler, so you need > a long enough runtime to get meaningful results (otherwise, the various > stack fragments collected can't be pieced together to get the whole tree). > > Also, it seems some of the code is interpreted. If the result is still > hard to interpret, you might want to try and byte-compile that code. I tried the thingatpt.el and the URL case is not slow there but email is. Profiler says most time is spent in thing-at-point-looking-at. I propose the following fix? Comments? === modified file 'lisp/thingatpt.el' --- lisp/thingatpt.el 2013-08-10 15:17:29 +0000 +++ lisp/thingatpt.el 2013-11-06 03:32:52 +0000 @@ -476,7 +476,7 @@ ;; matches that straddle the start position so we search forwards once ;; and then back repeatedly and then back up a char at a time. -(defun thing-at-point-looking-at (regexp) +(defun thing-at-point-looking-at (regexp &optional limit) "Return non-nil if point is in or just after a match for REGEXP. Set the match data from the earliest such match ending at or after point." @@ -487,7 +487,7 @@ (setq match (point))) ;; Search back repeatedly from end of next match. ;; This may fail if next match ends before this match does. - (re-search-forward regexp nil 'limit) + (re-search-forward regexp limit 'limit) (while (and (re-search-backward regexp nil t) (or (> (match-beginning 0) old-point) (and (looking-at regexp) ; Extend match-end past search start @@ -518,7 +518,8 @@ (put 'email 'bounds-of-thing-at-point (lambda () - (let ((thing (thing-at-point-looking-at thing-at-point-email-regexp))) + (let ((thing (thing-at-point-looking-at thing-at-point-email-regexp + (+ (point) 500)))) (if thing (let ((beginning (match-beginning 0)) (end (match-end 0))) From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 22:45:38 2013 Received: (at 15808) by debbugs.gnu.org; 6 Nov 2013 03:45:38 +0000 Received: from localhost ([127.0.0.1]:36444 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdu3l-0007B8-VC for submit@debbugs.gnu.org; Tue, 05 Nov 2013 22:45:38 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:53602) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdu3i-0007Au-Gd for 15808@debbugs.gnu.org; Tue, 05 Nov 2013 22:45:35 -0500 Received: by mail-pb0-f43.google.com with SMTP id md4so8372725pbc.2 for <15808@debbugs.gnu.org>; Tue, 05 Nov 2013 19:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=1TI2f06b+tmgoAo47QK36KKhTvK+I5GKUGBB1oGUgds=; b=GTC3lWofftn+l9l533crLybxYKCH11ve+YNrzKzc5bZT4JshrSZ9mNGPliA5nyJ0GX PUOUveV4QN9cpnvUNd54kDCf4Wq+vpFKNISRsXUeIWJtfnkSeBpkywzRZ2cU6HkrnZhz iOMZ9FEYc9eLH7qIVi5qIB+pNqm2rAwvLMRi19UCjao6/MDKw65h1TETgo4MsKQ/gRCu Zmb6RiITeDFWA/4KpGchKSQZNvjSghY9Q2ui46I5I76Y4h1/mSh/C8ZPti3ZemwQNUUm 1I3i/SGIfwhTWWgcjLBXacjIqXBLshkQnbvEF5eDWLANI9jEOjAUkM2ptFFnubFSOM5T qwpg== X-Received: by 10.68.138.199 with SMTP id qs7mr144593pbb.199.1383709528308; Tue, 05 Nov 2013 19:45:28 -0800 (PST) Received: from localhost ([221.217.232.4]) by mx.google.com with ESMTPSA id j9sm44320818paj.18.2013.11.05.19.45.25 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Nov 2013 19:45:27 -0800 (PST) From: Leo Liu To: Stefan Monnier Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Wed, 06 Nov 2013 11:45:21 +0800 In-Reply-To: (Stefan Monnier's message of "Tue, 05 Nov 2013 21:18:52 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15808 Cc: 15808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Revised patch: === modified file 'lisp/thingatpt.el' --- lisp/thingatpt.el 2013-08-10 15:17:29 +0000 +++ lisp/thingatpt.el 2013-11-06 03:43:24 +0000 @@ -476,19 +476,22 @@ ;; matches that straddle the start position so we search forwards once ;; and then back repeatedly and then back up a char at a time. -(defun thing-at-point-looking-at (regexp) +(defun thing-at-point-looking-at (regexp &optional distance) "Return non-nil if point is in or just after a match for REGEXP. Set the match data from the earliest such match ending at or after point." (save-excursion - (let ((old-point (point)) match) + (let ((old-point (point)) + (forward-bound (and distance (+ (point) distance))) + (backward-bound (and distance (- (point) distance))) + match) (and (looking-at regexp) (>= (match-end 0) old-point) (setq match (point))) ;; Search back repeatedly from end of next match. ;; This may fail if next match ends before this match does. - (re-search-forward regexp nil 'limit) - (while (and (re-search-backward regexp nil t) + (re-search-forward regexp forward-bound 'limit) + (while (and (re-search-backward regexp backward-bound t) (or (> (match-beginning 0) old-point) (and (looking-at regexp) ; Extend match-end past search start (>= (match-end 0) old-point) @@ -518,7 +521,8 @@ (put 'email 'bounds-of-thing-at-point (lambda () - (let ((thing (thing-at-point-looking-at thing-at-point-email-regexp))) + (let ((thing (thing-at-point-looking-at + thing-at-point-email-regexp 500))) (if thing (let ((beginning (match-beginning 0)) (end (match-end 0))) From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 01:55:31 2013 Received: (at 15808) by debbugs.gnu.org; 6 Nov 2013 06:55:31 +0000 Received: from localhost ([127.0.0.1]:36543 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdx1W-0003XW-6B for submit@debbugs.gnu.org; Wed, 06 Nov 2013 01:55:31 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:43917) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdx1T-0003XI-H5 for 15808@debbugs.gnu.org; Wed, 06 Nov 2013 01:55:27 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBrMwjX2ND4N7A4hhnBmBXoJqK4FR X-IPAS-Result: Av4EABK/CFFFxLzd/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBrMwjX2ND4N7A4hhnBmBXoJqK4FR X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37198359" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Nov 2013 01:55:21 -0500 Received: by pastel.home (Postfix, from userid 20848) id 4673960E3C; Wed, 6 Nov 2013 01:55:21 -0500 (EST) From: Stefan Monnier To: Leo Liu Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email Message-ID: References: Date: Wed, 06 Nov 2013 01:55:21 -0500 In-Reply-To: (Leo Liu's message of "Wed, 06 Nov 2013 11:45:21 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15808 Cc: 15808@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Revised patch: Looks OK, thanks. Maybe other calls to thing-at-point-looking-at could benefit as well. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 06 04:11:12 2013 Received: (at 15808-done) by debbugs.gnu.org; 6 Nov 2013 09:11:12 +0000 Received: from localhost ([127.0.0.1]:36640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdz8p-0006zL-PQ for submit@debbugs.gnu.org; Wed, 06 Nov 2013 04:11:12 -0500 Received: from mail-pb0-f43.google.com ([209.85.160.43]:60186) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vdz8n-0006z8-I6 for 15808-done@debbugs.gnu.org; Wed, 06 Nov 2013 04:11:09 -0500 Received: by mail-pb0-f43.google.com with SMTP id md4so8760899pbc.30 for <15808-done@debbugs.gnu.org>; Wed, 06 Nov 2013 01:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Avzum4OMzJcyBYi4VzSAuli45JpVSrDCfY6IIRSx2T8=; b=rDVZfV4MM2Dnc1pReA/2ihvoGnRyB3emyHmmmyLsYx0dArNgf6RAQr+MmBa7brgBGE IPyAcWvtaFEY+PvbuYWU/YCYCQkwDWEqhZmk/8w3QcWgC/Chj/o5y4Pqp8VxE1XNAEyg Zsrhf2py3RwDZ1NNyyGaJXP1HE4WLFhjNVCmhhcqlUnY7JSugSv14q9BcRda2EPTV13n 1BHDh8IElVoX0qatH00DHTQUy2m6vRfd0RzEZ5D0w98+Xl7+D9l6dAOb832ucjzRyTx7 4K5OZIIl0RXxaVO8QMqJdnXD4/8kH4rgclBFMqyfFuB9g3/YqjVIWz4UIqAZCAKCtCKH q/7g== X-Received: by 10.68.209.232 with SMTP id mp8mr2135597pbc.129.1383729063238; Wed, 06 Nov 2013 01:11:03 -0800 (PST) Received: from localhost ([221.217.232.4]) by mx.google.com with ESMTPSA id nj9sm39948242pbc.13.2013.11.06.01.11.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Nov 2013 01:11:02 -0800 (PST) From: Leo Liu To: Stefan Monnier Subject: Re: bug#15808: 24.3; thing-at-point slow for url and email References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Wed, 06 Nov 2013 17:10:56 +0800 In-Reply-To: (Stefan Monnier's message of "Wed, 06 Nov 2013 01:55:21 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15808-done Cc: 15808-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in 24.4. On 2013-11-06 14:55 +0800, Stefan Monnier wrote: > Looks OK, thanks. Maybe other calls to thing-at-point-looking-at could > benefit as well. Both url and email used to use thing-at-point-looking-at. But the URL case has been re-written. So there is only one use of thing-at-point-looking-at i.e. it's all covered. Leo From unknown Mon Jun 23 02:26:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Dec 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator