From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 13:42:24 2013 Received: (at submit) by debbugs.gnu.org; 4 Nov 2013 18:42:24 +0000 Received: from localhost ([127.0.0.1]:34537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdP6W-0002cd-6y for submit@debbugs.gnu.org; Mon, 04 Nov 2013 13:42:24 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51753) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdOxn-0002Mk-Pt for submit@debbugs.gnu.org; Mon, 04 Nov 2013 13:33:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdOxY-0006ZM-Uu for submit@debbugs.gnu.org; Mon, 04 Nov 2013 13:33:18 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:35456) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOxY-0006ZI-Rb for submit@debbugs.gnu.org; Mon, 04 Nov 2013 13:33:08 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOxR-0004Db-7A for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 13:33:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VdOxJ-0006UG-Sb for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 13:33:01 -0500 Received: from st11p02mm-asmtpout004.mac.com ([17.172.220.239]:38342 helo=st11p02mm-asmtp004.mac.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VdOxJ-0006Ta-OO for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 13:32:53 -0500 Received: from [172.20.199.13] (h-46-59-42-57.na.cust.bahnhof.se [46.59.42.57]) by st11p02mm-asmtp004.mac.com (Oracle Communications Messaging Server 7u4-27.08(7.0.4.27.7) 64bit (built Aug 22 2013)) with ESMTPSA id <0MVR0074V4UF2PB0@st11p02mm-asmtp004.mac.com> for bug-gnu-emacs@gnu.org; Mon, 04 Nov 2013 18:32:41 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794,1.0.431,0.0.0000 definitions=2013-11-04_01:2013-11-04,2013-11-04,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=1 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1308280000 definitions=main-1311040129 From: =?iso-8859-1?Q?Jan_Dj=E4rv?= Content-type: text/plain; charset=us-ascii Content-transfer-encoding: quoted-printable Subject: 24.3.50; PUSH_HANDLER leaks memory? Message-id: <674ECE0A-ED5C-41A0-A4E8-417318065CC0@me.com> Date: Mon, 04 Nov 2013 19:32:39 +0100 To: bug-gnu-emacs@gnu.org MIME-version: 1.0 (Mac OS X Mail 7.0 \(1816\)) X-Mailer: Apple Mail (2.1816) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 04 Nov 2013 13:42:23 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello. While running leaks on OSX, it indicated that PUSH_HANDLER. I can't = find anywhere where handlerlist members are freed. Consider handlerlist =3D NULL. One PUSH_HANDLER will then allocate one struct handler that becomes = handlerlist, next is NULL and nextfree is NULL. In the code, for example internal_condition_case_1, the code simply does handlerlist =3D handlerllist->next thus loosing the allocated struct. There must be a corresponding xfree = somewhere but I can't find it. Jan D. In GNU Emacs 24.3.50.1 (x86_64-apple-darwin13.0.0, NS = apple-appkit-1265.00) of 2013-11-04 on zeplin Bzr revision: 114945 jan.h.d@swipnet.se-20131104175717-8j1fzo686naq33js Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --verbose --with-ns CFLAGS=3D-g3' Important settings: value of $LC_COLLATE: C value of $LANG: sv_SE.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: x r e p o r t - e m Recent messages: Unable to load color "unspecified-fg" For information about GNU Emacs and the GNU system, type C-h C-a. Unable to load color "unspecified-fg" [2 times] Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 15:10:32 2013 Received: (at 15802) by debbugs.gnu.org; 4 Nov 2013 20:10:32 +0000 Received: from localhost ([127.0.0.1]:34632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdQTn-0004nn-SM for submit@debbugs.gnu.org; Mon, 04 Nov 2013 15:10:32 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:52305) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdQTm-0004nZ-1L for 15802@debbugs.gnu.org; Mon, 04 Nov 2013 15:10:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhlnuFHoFegxU X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhlnuFHoFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37073400" Received: from 69-196-188-221.dsl.teksavvy.com (HELO pastel.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Nov 2013 15:10:24 -0500 Received: by pastel.home (Postfix, from userid 20848) id E9CF460D75; Mon, 4 Nov 2013 15:10:21 -0500 (EST) From: Stefan Monnier To: Jan =?windows-1252?Q?Dj=E4rv?= Subject: Re: bug#15802: 24.3.50; PUSH_HANDLER leaks memory? Message-ID: References: <674ECE0A-ED5C-41A0-A4E8-417318065CC0@me.com> Date: Mon, 04 Nov 2013 15:10:21 -0500 In-Reply-To: <674ECE0A-ED5C-41A0-A4E8-417318065CC0@me.com> ("Jan =?windows-1252?Q?Dj=E4rv=22's?= message of "Mon, 04 Nov 2013 19:32:39 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15802 Cc: 15802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > While running leaks on OSX, it indicated that PUSH_HANDLER. I can't find anywhere where > handlerlist members are freed. They're never freed. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 16:49:25 2013 Received: (at 15802) by debbugs.gnu.org; 4 Nov 2013 21:49:25 +0000 Received: from localhost ([127.0.0.1]:34695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdS1V-0008FM-8G for submit@debbugs.gnu.org; Mon, 04 Nov 2013 16:49:25 -0500 Received: from st11p02mm-asmtp004.mac.com ([17.172.220.239]:42157) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdS1S-0008F8-EK for 15802@debbugs.gnu.org; Mon, 04 Nov 2013 16:49:23 -0500 Received: from [172.20.199.13] (h-46-59-42-57.na.cust.bahnhof.se [46.59.42.57]) by st11p02mm-asmtp004.mac.com (Oracle Communications Messaging Server 7u4-27.08(7.0.4.27.7) 64bit (built Aug 22 2013)) with ESMTPSA id <0MVR00063DY1PL10@st11p02mm-asmtp004.mac.com> for 15802@debbugs.gnu.org; Mon, 04 Nov 2013 21:49:16 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794,1.0.431,0.0.0000 definitions=2013-11-04_04:2013-11-04,2013-11-04,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=12 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1308280000 definitions=main-1311040168 Content-type: text/plain; charset=us-ascii MIME-version: 1.0 (Mac OS X Mail 7.0 \(1816\)) Subject: Re: bug#15802: 24.3.50; PUSH_HANDLER leaks memory? From: =?iso-8859-1?Q?Jan_Dj=E4rv?= In-reply-to: Date: Mon, 04 Nov 2013 22:49:13 +0100 Content-transfer-encoding: quoted-printable Message-id: <54B313E1-5371-402E-A84C-246D3629F087@me.com> References: <674ECE0A-ED5C-41A0-A4E8-417318065CC0@me.com> To: Stefan Monnier X-Mailer: Apple Mail (2.1816) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15802 Cc: 15802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello. 4 nov 2013 kl. 21:10 skrev Stefan Monnier : >> While running leaks on OSX, it indicated that PUSH_HANDLER. I can't = find anywhere where >> handlerlist members are freed. >=20 > They're never freed. >=20 That must be a leak then. If you start with a NULL handlerlist, add = one, and then remove it, it is leaked. Then add one and remove, more = leakage. And so on. Why are they never released? Jan D. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 21:48:28 2013 Received: (at 15802) by debbugs.gnu.org; 5 Nov 2013 02:48:29 +0000 Received: from localhost ([127.0.0.1]:34862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdWgu-0000nn-CJ for submit@debbugs.gnu.org; Mon, 04 Nov 2013 21:48:28 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:61629) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdWgr-0000nZ-IJ for 15802@debbugs.gnu.org; Mon, 04 Nov 2013 21:48:26 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhlnuFHoFegxU X-IPAS-Result: Av8EABK/CFFFxLzd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhlnuFHoFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="37104891" Received: from 69-196-188-221.dsl.teksavvy.com (HELO ceviche.home) ([69.196.188.221]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 04 Nov 2013 21:48:19 -0500 Received: by ceviche.home (Postfix, from userid 20848) id 2D624660A2; Mon, 4 Nov 2013 21:48:19 -0500 (EST) From: Stefan Monnier To: Jan =?windows-1252?Q?Dj=E4rv?= Subject: Re: bug#15802: 24.3.50; PUSH_HANDLER leaks memory? Message-ID: References: <674ECE0A-ED5C-41A0-A4E8-417318065CC0@me.com> <54B313E1-5371-402E-A84C-246D3629F087@me.com> Date: Mon, 04 Nov 2013 21:48:19 -0500 In-Reply-To: <54B313E1-5371-402E-A84C-246D3629F087@me.com> ("Jan =?windows-1252?Q?Dj=E4rv=22's?= message of "Mon, 04 Nov 2013 22:49:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15802 Cc: 15802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > That must be a leak then. If you start with a NULL handlerlist, add one, > and then remove it, it is leaked. Then add one and remove, more leakage. > And so on. Why are they never released? You might be right that the NULL case is not handled. Once we move past NULL, they are still not freed, but they're kept in "nextfree" and hence reused. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 01:54:06 2013 Received: (at 15802) by debbugs.gnu.org; 5 Nov 2013 06:54:06 +0000 Received: from localhost ([127.0.0.1]:34954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdaWb-00078R-GR for submit@debbugs.gnu.org; Tue, 05 Nov 2013 01:54:06 -0500 Received: from st11p02mm-asmtpout003.mac.com ([17.172.220.238]:64516 helo=st11p02mm-asmtp003.mac.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdaWW-00077t-55 for 15802@debbugs.gnu.org; Tue, 05 Nov 2013 01:54:01 -0500 Received: from [172.20.199.13] (h-46-59-42-57.na.cust.bahnhof.se [46.59.42.57]) by st11p02mm-asmtp003.mac.com (Oracle Communications Messaging Server 7u4-27.08(7.0.4.27.7) 64bit (built Aug 22 2013)) with ESMTPSA id <0MVS00BIG35N1A50@st11p02mm-asmtp003.mac.com> for 15802@debbugs.gnu.org; Tue, 05 Nov 2013 06:53:49 +0000 (GMT) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794,1.0.431,0.0.0000 definitions=2013-11-05_03:2013-11-05,2013-11-05,1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1308280000 definitions=main-1311040294 Content-type: text/plain; charset=us-ascii MIME-version: 1.0 (Mac OS X Mail 7.0 \(1816\)) Subject: Re: bug#15802: 24.3.50; PUSH_HANDLER leaks memory? From: =?iso-8859-1?Q?Jan_Dj=E4rv?= In-reply-to: Date: Tue, 05 Nov 2013 07:53:47 +0100 Content-transfer-encoding: 7bit Message-id: <02F4E04B-C60F-481D-B381-79F1F8867D59@me.com> References: <674ECE0A-ED5C-41A0-A4E8-417318065CC0@me.com> <54B313E1-5371-402E-A84C-246D3629F087@me.com> To: Stefan Monnier X-Mailer: Apple Mail (2.1816) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15802 Cc: 15802@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hello. 5 nov 2013 kl. 03:48 skrev Stefan Monnier : >> That must be a leak then. If you start with a NULL handlerlist, add one, >> and then remove it, it is leaked. Then add one and remove, more leakage. >> And so on. Why are they never released? > > You might be right that the NULL case is not handled. > Once we move past NULL, they are still not freed, but they're kept in > "nextfree" and hence reused. The NULL case must be fairly common, i.e just one PUSH and then unwind. Jan D. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 11:28:06 2013 Received: (at 15802-done) by debbugs.gnu.org; 5 Nov 2013 16:28:07 +0000 Received: from localhost ([127.0.0.1]:35980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdjU6-0005PY-1b for submit@debbugs.gnu.org; Tue, 05 Nov 2013 11:28:06 -0500 Received: from relais.videotron.ca ([24.201.245.36]:64612) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdjU3-0005PQ-Ky for 15802-done@debbugs.gnu.org; Tue, 05 Nov 2013 11:28:04 -0500 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR001.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MVS00HNOTQPE2C0@VL-VM-MR001.ip.videotron.ca> for 15802-done@debbugs.gnu.org; Tue, 05 Nov 2013 11:28:02 -0500 (EST) Received: by ceviche.home (Postfix, from userid 20848) id 14F086609C; Tue, 05 Nov 2013 11:28:00 -0500 (EST) From: Stefan Monnier To: Jan =?windows-1252?Q?Dj=E4rv?= Subject: Re: bug#15802: 24.3.50; PUSH_HANDLER leaks memory? Message-id: References: <674ECE0A-ED5C-41A0-A4E8-417318065CC0@me.com> <54B313E1-5371-402E-A84C-246D3629F087@me.com> <02F4E04B-C60F-481D-B381-79F1F8867D59@me.com> Date: Tue, 05 Nov 2013 11:28:00 -0500 In-reply-to: <02F4E04B-C60F-481D-B381-79F1F8867D59@me.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15802-done Cc: 15802-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > The NULL case must be fairly common, i.e just one PUSH and then unwind. I'm not sure it's that common, since command_loop pushes a `top-level' catcher, so as long as we stay within command_loop_2 it doesn't go back to NULL. This said we should eliminate the NULL case by putting a "sentinel" at the beginning, so as to avoid this problem. I've done that with the patch below, Stefan === modified file 'src/ChangeLog' --- src/ChangeLog 2013-11-05 09:00:52 +0000 +++ src/ChangeLog 2013-11-05 16:26:47 +0000 @@ -1,3 +1,12 @@ +2013-11-05 Stefan Monnier + + * eval.c (handlerlist_sentinel): New variable (bug#15802). + (init_eval): Use it to ensure handlerlist is non-NULL. + (unwind_to_catch): Make sure we never set handlerlist to NULL. + (Fsignal): Adjust NULLness test of handlerlist. + + * lisp.h (PUSH_HANDLER): Assume handlerlist is non-NULL. + 2013-11-05 Xue Fuqiao * xdisp.c (syms_of_xdisp): Mention the active display table in doc === modified file 'src/eval.c' --- src/eval.c 2013-10-29 14:46:23 +0000 +++ src/eval.c 2013-11-05 16:24:40 +0000 @@ -237,11 +237,22 @@ Vrun_hooks = Qnil; } +static struct handler handlerlist_sentinel; + void init_eval (void) { specpdl_ptr = specpdl; - handlerlist = NULL; + { /* Put a dummy catcher at top-level so that handlerlist is never NULL. + This is important since handlerlist->nextfree holds the freelist + which would otherwise leak every time we unwind back to top-level. */ + struct handler *c; + handlerlist = handlerlist_sentinel.nextfree = &handlerlist_sentinel; + PUSH_HANDLER (c, Qunbound, CATCHER); + eassert (c == &handlerlist_sentinel); + handlerlist_sentinel.nextfree = NULL; + handlerlist_sentinel.next = NULL; + } Vquit_flag = Qnil; debug_on_next_call = 0; lisp_eval_depth = 0; @@ -1129,6 +1140,8 @@ { bool last_time; + eassert (catch->next); + /* Save the value in the tag. */ catch->val = value; @@ -1542,7 +1555,10 @@ } else { - if (handlerlist != 0) + if (handlerlist != &handlerlist_sentinel) + /* FIXME: This will come right back here if there's no `top-level' + catcher. A better solution would be to abort here, and instead + add a catch-all condition handler so we never come here. */ Fthrow (Qtop_level, Qt); } === modified file 'src/lisp.h' --- src/lisp.h 2013-11-05 07:11:24 +0000 +++ src/lisp.h 2013-11-05 15:48:45 +0000 @@ -2873,13 +2873,12 @@ /* Fill in the components of c, and put it on the list. */ #define PUSH_HANDLER(c, tag_ch_val, handlertype) \ - if (handlerlist && handlerlist->nextfree) \ + if (handlerlist->nextfree) \ (c) = handlerlist->nextfree; \ else \ { \ (c) = xmalloc (sizeof (struct handler)); \ (c)->nextfree = NULL; \ - if (handlerlist) \ handlerlist->nextfree = (c); \ } \ (c)->type = (handlertype); \ From unknown Mon Jun 23 09:37:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 04 Dec 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator