GNU bug report logs - #15782
24.3.50; common-lisp-indent-function for with-compilation-unit

Previous Next

Package: emacs;

Reported by: Helmut Eller <eller.helmut <at> gmail.com>

Date: Fri, 1 Nov 2013 14:23:01 UTC

Severity: minor

Tags: patch

Found in version 24.3.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15782 in the body.
You can then email your comments to 15782 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#15782; Package emacs. (Fri, 01 Nov 2013 14:23:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Helmut Eller <eller.helmut <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 01 Nov 2013 14:23:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Helmut Eller <eller.helmut <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; common-lisp-indent-function for with-compilation-unit
Date: Fri, 01 Nov 2013 15:22:09 +0100

By default, common-lisp-indent-function indents with-compilation-unit
not very nicely. E.g.:

  (with-compilation-unit (:option1 foo
                                   :option2 bar)
    x)

With the patch below it will look better, like so:

  (with-compilation-unit (:option1 foo
                          :option2 bar)
    x)


diff --git a/lisp/emacs-lisp/cl-indent.el b/lisp/emacs-lisp/cl-indent.el
index bbfe9ec..cc7d2a8 100644
--- a/lisp/emacs-lisp/cl-indent.el
+++ b/lisp/emacs-lisp/cl-indent.el
@@ -756,6 +756,7 @@ optional\\|rest\\|key\\|allow-other-keys\\|aux\\|whole\\|body\\|environment\
            (when 1)
            (with-accessors . multiple-value-bind)
            (with-condition-restarts . multiple-value-bind)
+	   (with-compilation-unit (&lambda &body))
            (with-output-to-string (4 2))
            (with-slots . multiple-value-bind)
            (with-standard-io-syntax (2)))))
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#15782; Package emacs. (Mon, 04 Nov 2013 19:52:02 GMT) Full text and rfc822 format available.

Message #8 received at 15782 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Helmut Eller <eller.helmut <at> gmail.com>
Cc: 15782 <at> debbugs.gnu.org
Subject: Re: bug#15782: 24.3.50;
 common-lisp-indent-function for with-compilation-unit
Date: Mon, 04 Nov 2013 14:51:09 -0500

> With the patch below it will look better, like so:

>   (with-compilation-unit (:option1 foo
>                           :option2 bar)
>     x)

Thanks, installed,


        Stefan
bug closed, send any further explanations to 15782 <at> debbugs.gnu.org and Helmut Eller <eller.helmut <at> gmail.com> Request was from Stefan Monnier <monnier <at> iro.umontreal.ca> to control <at> debbugs.gnu.org. (Mon, 04 Nov 2013 20:12:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 03 Dec 2013 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 204 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.