GNU bug report logs - #15778
24.3; cperl-mode causes emacs to lock up

Previous Next

Package: emacs;

Reported by: Nathan Trapuzzano <nbtrap <at> nbtrap.com>

Date: Fri, 1 Nov 2013 11:21:02 UTC

Severity: normal

Found in version 24.3

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Nathan Trapuzzano <nbtrap <at> nbtrap.com>
Cc: Stephen Berman <stephen.berman <at> gmx.net>, 15778 <at> debbugs.gnu.org
Subject: bug#15778: 24.3; cperl-mode causes emacs to lock up
Date: Sun, 03 Nov 2013 20:48:46 -0500

> -      (if (setq beg (cperl-beginning-of-property beg 'syntax-type))
> -	  (goto-char beg)))
> +      (let ((new-beg (cperl-beginning-of-property beg 'syntax-type)))
> +	(setq beg (if (= new-beg beg) nil new-beg))
> +	(goto-char new-beg)))

Hmm... what if new-beg is nil?
The current code explicitly tests this case to avoid calling
`goto-char', whereas your code calls goto-char unconditionally.
Why?


        Stefan
This bug report was last modified 11 years and 202 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.