GNU bug report logs - #15775
24.3.50; "WARNING: terminal is not fully functional" in Comint and Eshell

Previous Next

Full log

Message #14 received at 15775 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 15775 <at> debbugs.gnu.org,
 Jan Djärv <jan.h.d <at> swipnet.se>,
 schwab <at> linux-m68k.org, Ulrich Neumerkel <ulrich <at> complang.tuwien.ac.at>,
 4359 <at> debbugs.gnu.org
Subject: Re: bug#15775: 24.3.50; "WARNING: terminal is not fully functional"
 in Comint and Eshell
Date: Thu, 05 May 2022 14:42:49 +0200

This change makes "git grep" work as a grep command with `M-x grep' (if
you remove --null).  It's shouldn't have a negative impact on much
anything else (because no pagers should be used anywhere here), but
perhaps it should be done in grep.el instead of compile.el...

Anybody got any comments?

diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el
index 6753cf0b02..c88eb10693 100644
--- a/lisp/progmodes/compile.el
+++ b/lisp/progmodes/compile.el
@@ -1895,6 +1895,9 @@ compilation-start
               (and (derived-mode-p 'comint-mode)
                    (comint-term-environment))
 	      (list (format "INSIDE_EMACS=%s,compile" emacs-version))
+              ;; Some external programs (like "git grep") use a pager;
+              ;; defeat that.
+              (list "PAGER=")
 	      (copy-sequence process-environment))))
         (setq-local compilation-arguments
                     (list command mode name-function highlight-regexp))


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.