GNU bug report logs - #15767
24.3; [patch] electric-indent-mode bug

Previous Next

Full log

View this message in rfc822 format

From: Dave Abrahams <dave <at> boostpro.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: "15767 <at> debbugs.gnu.org" <15767 <at> debbugs.gnu.org>
Subject: bug#15767: closed (Re: bug#15767: 24.3; [patch] electric-indent-mode bug)
Date: Tue, 5 Nov 2013 07:54:35 -0800

Ok thanks for making it right then!

Sent from my moss-covered three-handled family gradunza

On Nov 5, 2013, at 7:44 AM, Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

>> Well, the problem I see is that you left the call to line-beginning-position
>> where it was in the original call.  At that point, point may be
>> on a different line than it started on, so it’s actually getting information
>> about the wrong line.  It’s possible that your patch somehow makes
>> everything work out, but leaving the call to line-beginning-position where
>> it is seems at best fragile to me.
> 
> On the contrary, moving the call like you did was wrong, IMO.  The test
> against line-beginning-position is meant to check if pos is on
> a previous line, in which case we also need to reindent that previous
> line, whereas with your patch it reduces to just check if pos is at
> (bolp) which is not as interesting (tho it will often work as well for
> the newline case).
> 
> 
>        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.