From unknown Fri Jun 20 19:52:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15758 <15758@debbugs.gnu.org> To: bug#15758 <15758@debbugs.gnu.org> Subject: Status: grep 2.15 calls abort() on larger searches with -P Reply-To: bug#15758 <15758@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:52:29 +0000 retitle 15758 grep 2.15 calls abort() on larger searches with -P reassign 15758 grep submitter 15758 Dave Reisner severity 15758 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 13:39:25 2013 Received: (at submit) by debbugs.gnu.org; 30 Oct 2013 17:39:25 +0000 Received: from localhost ([127.0.0.1]:53120 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbZjo-0007dA-Md for submit@debbugs.gnu.org; Wed, 30 Oct 2013 13:39:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37311) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbZTL-0007CX-0a for submit@debbugs.gnu.org; Wed, 30 Oct 2013 13:22:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbZT6-0006i4-IX for submit@debbugs.gnu.org; Wed, 30 Oct 2013 13:22:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbZT6-0006i0-Fl for submit@debbugs.gnu.org; Wed, 30 Oct 2013 13:22:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbZSz-00035q-5y for bug-grep@gnu.org; Wed, 30 Oct 2013 13:22:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VbZSr-0006g5-S3 for bug-grep@gnu.org; Wed, 30 Oct 2013 13:22:01 -0400 Received: from gerolde.archlinux.org ([66.211.214.132]:38615) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VbZSr-0006fx-Nb for bug-grep@gnu.org; Wed, 30 Oct 2013 13:21:53 -0400 Received: from localhost (ool-4a588d72.dyn.optonline.net [74.88.141.114]) by gerolde.archlinux.org (Postfix) with ESMTPSA id 97DDC90317 for ; Wed, 30 Oct 2013 12:42:36 -0400 (EDT) Date: Wed, 30 Oct 2013 12:42:35 -0400 From: Dave Reisner To: bug-grep@gnu.org Subject: grep 2.15 calls abort() on larger searches with -P Message-ID: <20131030164235.GK735@rampage> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 30 Oct 2013 13:39:23 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi, A user reported a regression with grep 2.15 which is reasonably easy to reproduce with an invocation such as: ``grep -Pr foo''. The root cause is that pcre_exec returns an unhandled error (PCRE_ERROR_BADUTF8) causing grep to call abort(). I bisected the breakage to commit 67436786c110bbb565 (and verified that it still exists at git HEAD) which essentially introduces utf-8 validation for data. On a large enough file hierarchy, I suppose it's inevitable that invalid UTF-8 data is encountered. I was able to fix this with the inline diff which follows: diff --git a/src/pcresearch.c b/src/pcresearch.c index ad5999d..ce55ab3 100644 --- a/src/pcresearch.c +++ b/src/pcresearch.c @@ -176,6 +176,9 @@ Pexecute (char const *buf, size_t size, size_t *match_size, switch (e) { case PCRE_ERROR_NOMATCH: +#ifdef HAVE_LANGINFO_CODESET + case PCRE_ERROR_BADUTF8: +#endif return -1; case PCRE_ERROR_NOMEMORY: I don't know if this is considered to be a correct fix, but I offer it as a starting point for a discussion. Cheers, Dave P.S. Please CC me on replies as I am not subscribed to the list. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 17:19:44 2013 Received: (at 15758) by debbugs.gnu.org; 30 Oct 2013 21:19:44 +0000 Received: from localhost ([127.0.0.1]:53542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbdB1-0005hF-NK for submit@debbugs.gnu.org; Wed, 30 Oct 2013 17:19:43 -0400 Received: from mail-wg0-f49.google.com ([74.125.82.49]:37894) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbdAz-0005gu-3b; Wed, 30 Oct 2013 17:19:41 -0400 Received: by mail-wg0-f49.google.com with SMTP id x12so1871071wgg.28 for ; Wed, 30 Oct 2013 14:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=oCU0PmZtuCdq7gMFMELBMDHHdGWDdbjUsr4noQHxpxM=; b=gdQ4+Le9LpT6/wXFHxtKrDwdrv8h5Hhs3R+4jEDQ1r/VIjxiCo3kvjAc9F3VwXi83D WZxBkMwO3lNucA13JFUBsWGEf/AjXpmDqxrU4k8QXOsie1FNAq1vSvNF6iRLQ+PReC0D xX/aWjUqeWLuC8dZsCx7Rjp911xIi2HjR1JU/CI3v+MDh84jKYaeArw7ZoR2QLm4IcdZ y9h2N0IyRmOXMuswMIZL9+C3XfqNi5EP/OB5TuJk/SuRsGj+bLuDu557I5gEme3AuSXv 5xza3+5G3tLAJVyq8mo1d2QLnY4CgyvGhrfiXUHgh5eorby76yo9kvYhNxJp1Hrvf6Pg 7amw== X-Received: by 10.181.12.75 with SMTP id eo11mr3929745wid.24.1383167975258; Wed, 30 Oct 2013 14:19:35 -0700 (PDT) Received: from [192.168.1.11] ([79.97.144.61]) by mx.google.com with ESMTPSA id y20sm47006wib.0.2013.10.30.14.19.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 30 Oct 2013 14:19:34 -0700 (PDT) Message-ID: <527177E5.1090600@gmail.com> Date: Wed, 30 Oct 2013 21:19:33 +0000 From: Stefano Lattarini MIME-Version: 1.0 To: Dave Reisner Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P References: <20131030164235.GK735@rampage> In-Reply-To: <20131030164235.GK735@rampage> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15759@debbugs.gnu.org, 15758@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) merge 15758 15759 stop bug#15758 is the same as bug#15759, so I'm merging them, to avoid confusion or the risk of dispersing the discussion. Regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 31 11:26:39 2013 Received: (at 15758) by debbugs.gnu.org; 31 Oct 2013 15:26:40 +0000 Received: from localhost ([127.0.0.1]:54960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vbu8t-0002vR-EC for submit@debbugs.gnu.org; Thu, 31 Oct 2013 11:26:39 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:52644) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vbu8q-0002vA-FH; Thu, 31 Oct 2013 11:26:37 -0400 Received: by mail-pd0-f178.google.com with SMTP id x10so2511493pdj.23 for ; Thu, 31 Oct 2013 08:26:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ABxPVd3AZSY1sUlmLbxC3NACcEtTJQgPyF30L3ecBzw=; b=QXf5drlIADYqQwKuGbzDewvobXN6tD6IVykLDM1zKtnc6EMd2XBv2khtw3PuiTAbu6 asAEpFAiQF956UfiSH8r+oOC/pqyoCVvCx22gFLoKulUvTrcYWxNMiS2sSobjoGUxGa8 s1A8Xn6FmIp7J+N6OEN5oQbfFYHGoPwgT1Ii6ppI+U6RtitkpIhAW7fcMwQ+8juBGtON QgLePRGmWG1GmzZp+kp6cXSZjoPnyoQiaUBBoIHbg+al04pwI6Z5Qqx7IW9DWnbql0FT JBhKGxsDQ2429VvFOzaoVrYs0Sn7pxanCzP0VywznPQHfkc1/9241113xS+pTlDCsbQM TGVQ== X-Received: by 10.68.225.164 with SMTP id rl4mr2559114pbc.100.1383233190322; Thu, 31 Oct 2013 08:26:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Thu, 31 Oct 2013 08:26:10 -0700 (PDT) In-Reply-To: <527177E5.1090600@gmail.com> References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> From: Jim Meyering Date: Thu, 31 Oct 2013 08:26:10 -0700 X-Google-Sender-Auth: KaxEvFldlXySreV9vHbqcro81XM Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Stefano Lattarini Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15758 Cc: 15759@debbugs.gnu.org, 15758@debbugs.gnu.org, Dave Reisner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > bug#15758 is the same as bug#15759, so I'm merging them, > to avoid confusion or the risk of dispersing the discussion. Thanks, Stefano and Dave. With this and the nit about --version output being wrong, I now have two reasons to make a new release. I will take a look at the mass of PCRE_ERROR* cases today. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 19:06:22 2013 Received: (at 15758) by debbugs.gnu.org; 2 Nov 2013 23:06:22 +0000 Received: from localhost ([127.0.0.1]:60126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VckGr-0001v8-U8 for submit@debbugs.gnu.org; Sat, 02 Nov 2013 19:06:22 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:62665) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VckGo-0001uo-NI; Sat, 02 Nov 2013 19:06:20 -0400 Received: by mail-pa0-f50.google.com with SMTP id fb1so5523521pad.9 for ; Sat, 02 Nov 2013 16:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=HpqJsyudsRjfkFxHuzW7cZ/gXiTRS6v6NGRHJvbOK1Y=; b=TyxnrpTfQ4g4d7qAAIBR6gLLUA8EK18iE1OgMsT8E87TnlSajyEvKNnZ+Q8q+YolZp zLq8BZht+K9YxLsjTEv0gVFVGh86zvxxszwVT83epiO/qhXEUNhaca1rYzC5I9HE2RjQ zFUWxB+WPn9kvVwFW2VON3mmvHFm+K8uZApcjG10funjQvjIaaKhqCycWL0squlpjL/r SiRiVo1UomnA/HD01lyjc7CBH5kexG9NE73A7rT5PCIarYTYV/iNE22eKpYqu3SuMfG7 d3eQxARaxlf89zSG8/Hv8+v1pnsvTFusULRoRaTPH4VJL0zKTVY5kWEJQUWj42xc5uWc ytcQ== X-Received: by 10.66.145.40 with SMTP id sr8mr3830588pab.60.1383433572563; Sat, 02 Nov 2013 16:06:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Sat, 2 Nov 2013 16:05:52 -0700 (PDT) In-Reply-To: References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> From: Jim Meyering Date: Sat, 2 Nov 2013 16:05:52 -0700 X-Google-Sender-Auth: _OD8Fdwg__vtucjAu-qSUYEXXV0 Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Stefano Lattarini Content-Type: multipart/mixed; boundary=047d7b6da6f2ab15e804ea39bad7 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15759@debbugs.gnu.org, 15758@debbugs.gnu.org, Dave Reisner X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b6da6f2ab15e804ea39bad7 Content-Type: text/plain; charset=ISO-8859-1 On Thu, Oct 31, 2013 at 8:26 AM, Jim Meyering wrote: ... > With this and the nit about --version output being wrong, I now have > two reasons to make a new release. Thanks again for the report, Dave. Here's the fix I expect to push: --047d7b6da6f2ab15e804ea39bad7 Content-Type: text/plain; charset=US-ASCII; name="k.txt" Content-Disposition: attachment; filename="k.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnjgjwkd0 RnJvbSA5YTliNGM1OWJhYmM2MGUxNWE3OWNmN2RiODE2N2Q0MmU2OGU0NGI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog U2F0LCAyIE5vdiAyMDEzIDEyOjE1OjQ4IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gZ3JlcDogZml4 IHJlZ3Jlc3Npb24gd2l0aCAtUCB2cy4gaW52YWxpZCBVVEYtOCBpbnB1dAoKKiBzcmMvcGNyZXNl YXJjaC5jIChQZXhlY3V0ZSk6IERvbid0IGFib3J0IHVwb24gdW5leHBlY3RlZApQQ1JFLXNwZWNp ZmljIGVycm9yIGNvZGUuICBFeHBsaWNpdGx5IGhhbmRsZSBQQ1JFX0VSUk9SX0JBRFVURjgsCmFu ZCBjaGFuZ2UgdGhlIGRlZmF1bHQgdG8gcHJpbnQgYSBkaWFnbm9zdGljIGluY2x1ZGluZyB0aGUg dW5oYW5kbGVkCmludGVnZXIgUENSRSBlcnJvciBjb2RlIGFuZCBleGl0IHdpdGggc3RhdHVzIDIu CiogdGVzdHMvcGNyZS1pbnZhbGlkLXV0ZjgtaW5wdXQ6IE5ldyBmaWxlLgoqIHRlc3RzL01ha2Vm aWxlLmFtIChURVNUUyk6IEFkZCBpdC4KKiBORVdTIChCdWcgZml4ZXMpOiBNZW50aW9uIGl0Lgoq IFRIQU5LUzogVXBkYXRlLgpSZXBvcnRlZCBieSBEYXZlIFJlaXNuZXIgaW4gaHR0cDovL2J1Z3Mu Z251Lm9yZy8xNTc1OC4KLS0tCiBORVdTICAgICAgICAgICAgICAgICAgICAgICAgICB8ICA2ICsr KysrKwogVEhBTktTICAgICAgICAgICAgICAgICAgICAgICAgfCAgMSArCiBzcmMvcGNyZXNlYXJj aC5jICAgICAgICAgICAgICB8IDEzICsrKysrKysrKysrKy0KIHRlc3RzL01ha2VmaWxlLmFtICAg ICAgICAgICAgIHwgIDEgKwogdGVzdHMvcGNyZS1pbnZhbGlkLXV0ZjgtaW5wdXQgfCAyNSArKysr KysrKysrKysrKysrKysrKysrKysrCiA1IGZpbGVzIGNoYW5nZWQsIDQ1IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb24oLSkKIGNyZWF0ZSBtb2RlIDEwMDc1NSB0ZXN0cy9wY3JlLWludmFsaWQtdXRm OC1pbnB1dAoKZGlmZiAtLWdpdCBhL05FV1MgYi9ORVdTCmluZGV4IDA3OGQxM2IuLmU5NzRmMjkg MTAwNjQ0Ci0tLSBhL05FV1MKKysrIGIvTkVXUwpAQCAtMTQsNiArMTQsMTIgQEAgR05VIGdyZXAg TkVXUyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIC0qLSBvdXRsaW5lIC0qLQog ICBGb3IgZXhhbXBsZSwgXHMqLCBccyssIFxzPyBhbmQgXHN7M30gd291bGQgYWxsIG1hbGZ1bmN0 aW9uIGluIGEKICAgbXVsdGktYnl0ZSBsb2NhbGUuICBbYnVnIGludHJvZHVjZWQgaW4gZ3JlcC0y LjE1XQoKKyAgVGhlIGZpeCB0byBtYWtlIGdyZXAgLVAgd29yayBiZXR0ZXIgd2l0aCBVVEYtOCBt YWRlIGl0IHBvc3NpYmxlIGZvcgorICBncmVwIHRvIGV2b2tlIGEgbGFyZ2VyIHNldCBvZiBQQ1JF IGVycm9ycywgc29tZSBvZiB3aGljaCBjb3VsZCB0cmlnZ2VyCisgIGFuIGFib3J0LiAgRS5nLiwg dGhpcyB3b3VsZCBhYm9ydDoKKyAgICBwcmludGYgJ1x4ODInfExDX0FMTD1lbl9VUy5VVEYtOCBn cmVwIC1QIHkKKyAgTm93IGdyZXAgaGFuZGxlcyBhcmJpdHJhcnkgUENSRSBlcnJvcnMuICBbYnVn IGludHJvZHVjZWQgaW4gZ3JlcC0yLjE1XQorCgogKiBOb3Rld29ydGh5IGNoYW5nZXMgaW4gcmVs ZWFzZSAyLjE1ICgyMDEzLTEwLTI2KSBbc3RhYmxlXQoKZGlmZiAtLWdpdCBhL1RIQU5LUyBiL1RI QU5LUwppbmRleCA0NzVjNTFlLi4wMmVmMjQ2IDEwMDY0NAotLS0gYS9USEFOS1MKKysrIGIvVEhB TktTCkBAIC0yMCw2ICsyMCw3IEBAIENocmlzdGlhbiBHcm9lc3NsZXIgICAgICAgIDxjcGdAYWxh ZGRpbi5kZT4KIENvcmlubmEgVmluc2NoZW4gICAgICAgICAgIDx2aW5zY2hlbkByZWRoYXQuY29t PgogRGFnb2JlcnQgTWljaGVsc2VuICAgICAgICAgPGRhbUBvcGVuY3N3Lm9yZz4KIERhaXN1a2Ug R09UTyAgICAgICAgICAgICAgIDxnb3RvaEBtLWRlc2lnbi5jb20+CitEYXZlIFJlaXNuZXIgICAg ICAgICAgICAgICA8ZEBmYWxjb25pbmR5LmNvbT4KIERhdmlkIENsaXNzb2xkICAgICAgICAgICAg IDxjbGlzc0BhdXN0aW4uaWJtLmNvbT4KIERhdmlkIEogTWFjS2VuemllICAgICAgICAgIDxkam1A Y2F0YXB1bHQudmEucHVibml4LmNvbT4KIERhdmlkIE8nQnJpZW4gICAgICAgICAgICAgIDxvYnJp ZW5AZnJlZWJzZC5vcmc+CmRpZmYgLS1naXQgYS9zcmMvcGNyZXNlYXJjaC5jIGIvc3JjL3BjcmVz ZWFyY2guYwppbmRleCBhZDU5OTlkLi45YmExMjI3IDEwMDY0NAotLS0gYS9zcmMvcGNyZXNlYXJj aC5jCisrKyBiL3NyYy9wY3Jlc2VhcmNoLmMKQEAgLTE4NSw5ICsxODUsMjAgQEAgUGV4ZWN1dGUg KGNoYXIgY29uc3QgKmJ1Ziwgc2l6ZV90IHNpemUsIHNpemVfdCAqbWF0Y2hfc2l6ZSwKICAgICAg ICAgICBlcnJvciAoRVhJVF9UUk9VQkxFLCAwLAogICAgICAgICAgICAgICAgICBfKCJleGNlZWRl ZCBQQ1JFJ3MgYmFja3RyYWNraW5nIGxpbWl0IikpOwoKKyAgICAgICAgY2FzZSBQQ1JFX0VSUk9S X0JBRFVURjg6CisgICAgICAgICAgZXJyb3IgKEVYSVRfVFJPVUJMRSwgMCwKKyAgICAgICAgICAg ICAgICAgXygiaW52YWxpZCBVVEYtOCBieXRlIHNlcXVlbmNlIGluIGlucHV0IikpOworCiAgICAg ICAgIGRlZmF1bHQ6Ci0gICAgICAgICAgYWJvcnQgKCk7CisgICAgICAgICAgLyogRm9yIG5vdywg d2UgbHVtcCBhbGwgcmVtYWluaW5nIFBDUkUgZmFpbHVyZXMgaW50byB0aGlzIGJhc2tldC4KKyAg ICAgICAgICAgICBJZiBhbnlvbmUgY2FyZXMgdG8gcHJvdmlkZSBzYW1wbGUgZ3JlcCB1c2FnZSB0 aGF0IGNhbiB0cmlnZ2VyCisgICAgICAgICAgICAgcGFydGljdWxhciBQQ1JFIGVycm9ycywgd2Ug Y2FuIGFkZCB0byB0aGUgbGlzdCAoYWJvdmUpIG9mIG1vcmUKKyAgICAgICAgICAgICBkZXRhaWxl ZCBkaWFnbm9zdGljcy4gICovCisgICAgICAgICAgZXJyb3IgKEVYSVRfVFJPVUJMRSwgMCwgXygi aW50ZXJuYWwgUENSRSBlcnJvcjogJWQiKSwgZSk7CiAgICAgICAgIH0KKworICAgICAgLyogTk9U UkVBQ0hFRCAqLworICAgICAgcmV0dXJuIC0xOwogICAgIH0KICAgZWxzZQogICAgIHsKZGlmZiAt LWdpdCBhL3Rlc3RzL01ha2VmaWxlLmFtIGIvdGVzdHMvTWFrZWZpbGUuYW0KaW5kZXggOTcwYTlk ZS4uNzZiOGM1MiAxMDA2NDQKLS0tIGEvdGVzdHMvTWFrZWZpbGUuYW0KKysrIGIvdGVzdHMvTWFr ZWZpbGUuYW0KQEAgLTc5LDYgKzc5LDcgQEAgVEVTVFMgPQkJCQkJCVwKICAgb3B0aW9ucwkJCQkJ XAogICBwY3JlCQkJCQkJXAogICBwY3JlLWFib3J0CQkJCQlcCisgIHBjcmUtaW52YWxpZC11dGY4 LWlucHV0CQkJXAogICBwY3JlLXV0ZjgJCQkJCVwKICAgcGNyZS16CQkJCQlcCiAgIHByZWZpeC1v Zi1tdWx0aWJ5dGUJCQkJXApkaWZmIC0tZ2l0IGEvdGVzdHMvcGNyZS1pbnZhbGlkLXV0ZjgtaW5w dXQgYi90ZXN0cy9wY3JlLWludmFsaWQtdXRmOC1pbnB1dApuZXcgZmlsZSBtb2RlIDEwMDc1NQpp bmRleCAwMDAwMDAwLi41MmE1NDMyCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdHMvcGNyZS1pbnZh bGlkLXV0ZjgtaW5wdXQKQEAgLTAsMCArMSwyNSBAQAorIyEgL2Jpbi9zaAorIyBFbnN1cmUgdGhh dCBncmVwIC1QIGRvZXNuJ3QgYWJvcnQgZm9yIGludmFsaWQgbXVsdGktYnl0ZSBpbnB1dAorIwor IyBDb3B5cmlnaHQgKEMpIDIwMTMgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uLCBJbmMuCisjCisj IENvcHlpbmcgYW5kIGRpc3RyaWJ1dGlvbiBvZiB0aGlzIGZpbGUsIHdpdGggb3Igd2l0aG91dCBt b2RpZmljYXRpb24sCisjIGFyZSBwZXJtaXR0ZWQgaW4gYW55IG1lZGl1bSB3aXRob3V0IHJveWFs dHkgcHJvdmlkZWQgdGhlIGNvcHlyaWdodAorIyBub3RpY2UgYW5kIHRoaXMgbm90aWNlIGFyZSBw cmVzZXJ2ZWQuCisKKy4gIiR7c3JjZGlyPS59L2luaXQuc2giOyBwYXRoX3ByZXBlbmRfIC4uL3Ny YworcmVxdWlyZV9wY3JlXworcmVxdWlyZV9lbl91dGY4X2xvY2FsZV8KKworZmFpbD0wCisKK3By aW50ZiAnXDIwMlxuJyA+IGluIHx8IGZyYW1ld29ya19mYWlsdXJlXworcHJpbnRmICdncmVwOiBp bnZhbGlkIFVURi04IGJ5dGUgc2VxdWVuY2UgaW4gaW5wdXRcbicgXAorICAgPiBleHAtZXJyIHx8 IGZyYW1ld29ya19mYWlsdXJlXworCitMQ19BTEw9ZW5fVVMuVVRGLTggZ3JlcCAtUCBhbnl0aGlu ZyBpbiA+IG91dCAyPiBlcnIKK3Rlc3QgJD8gPSAyIHx8IGZhaWw9MQorY29tcGFyZSAvZGV2L251 bGwgb3V0IHx8IGZhaWw9MQorY29tcGFyZSBleHAtZXJyIGVyciB8fCBmYWlsPTEKKworRXhpdCAk ZmFpbAotLSAKMS44LjUucmMwLjIzLmdhYTI3MDY0Cgo= --047d7b6da6f2ab15e804ea39bad7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 04 14:38:56 2013 Received: (at 15758) by debbugs.gnu.org; 4 Nov 2013 19:38:56 +0000 Received: from localhost ([127.0.0.1]:34594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdPzE-00041R-Cu for submit@debbugs.gnu.org; Mon, 04 Nov 2013 14:38:56 -0500 Received: from mail-qa0-f45.google.com ([209.85.216.45]:36966) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdPz6-00040X-V6 for 15758@debbugs.gnu.org; Mon, 04 Nov 2013 14:38:54 -0500 Received: by mail-qa0-f45.google.com with SMTP id hu16so362540qab.11 for <15758@debbugs.gnu.org>; Mon, 04 Nov 2013 11:38:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=ff4gMBrWNzJ+L3wDb2kPliGR0JH9U2OPF6As9qC2AjY=; b=MQMNP8HEtl7UC0iChOdyR82Fdg2w6XXzNgqkW97f1MWLZCfGzEZp9peiznF2YyDxuy 5Y+Wm/vgRgAbdSy2urARh9RlbSD2AyXyoju311IS32xDGg1GodGuwnAMZrMhnQ7SFwSs rvryfJk5CSWYiMwcu+ovaieEHvjTk18ejXDUlY+6oRWiUamcttpeh2lW1A5tjeeplHIU ZD3aYVI4oZdQSXX0kJPBsCxUvLPmY4nzY64YQO26uFKl6ORubtIx+powKpsKsdc7e4/C 6bU5rIdQXdkU6bzaC+UEopeXxQmHoXpnYrc0eEil/H5yKo0u4WmVeLzcayJFMjiUgqr8 +vLg== X-Gm-Message-State: ALoCoQkNcbZ3eWgLFpvV+rs38rXsJ2pxd9CqghUEyaQcsUxyHbjBMY4A0QUg80VywtFrOGZvqnEY X-Received: by 10.224.92.81 with SMTP id q17mr24584903qam.51.1383593923512; Mon, 04 Nov 2013 11:38:43 -0800 (PST) Received: from localhost (ool-4a588d72.dyn.optonline.net. [74.88.141.114]) by mx.google.com with ESMTPSA id x10sm58163023qas.5.2013.11.04.11.38.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Nov 2013 11:38:42 -0800 (PST) Date: Mon, 4 Nov 2013 14:38:40 -0500 From: Dave Reisner To: Jim Meyering Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P Message-ID: <20131104193840.GU735@rampage> References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15759@debbugs.gnu.org, 15758@debbugs.gnu.org, Dave Reisner , Stefano Lattarini X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Nov 02, 2013 at 04:05:52PM -0700, Jim Meyering wrote: > On Thu, Oct 31, 2013 at 8:26 AM, Jim Meyering wrote: > ... > > With this and the nit about --version output being wrong, I now have > > two reasons to make a new release. > > Thanks again for the report, Dave. > Here's the fix I expect to push: Thanks Jim. Apologies for not responding to this sooner. I tested your patch and can confirm that the behavior is better, but the new behavior still seems like a regression. Take, for example, the simple instance of grep'ing grep's own git repo. # with grep 2.14 $ grep -rPw GNULIB gnulib/m4/bison.m4:dnl Declaring YACC & YFLAGS precious will not be necessary after GNULIB gnulib/lib/glob.c: HAVE_STRUCT_DIRENT_D_TYPE plays the same role in GNULIB. */ gnulib/lib/netdb.in.h: GNULIB getaddrinfo() replacement, so are not yet needed. gnulib/lib/argp.h:/* GNULIB makes sure both program_invocation_name and # with grep built from HEAD $ ./src/grep -rPw GNULIB ./src/grep: invalid UTF-8 byte sequence in input I would expect that the invalid UTF-8 wouldn't stop grep cold, but continue on, ignoring the non-matching data, just as grep without the -P flag does. Cheers, Dave From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 11:17:49 2013 Received: (at 15758) by debbugs.gnu.org; 5 Nov 2013 16:17:49 +0000 Received: from localhost ([127.0.0.1]:35953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdjK7-00058X-Ts for submit@debbugs.gnu.org; Tue, 05 Nov 2013 11:17:48 -0500 Received: from mail-pa0-f42.google.com ([209.85.220.42]:53219) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VdjK5-000588-AG; Tue, 05 Nov 2013 11:17:46 -0500 Received: by mail-pa0-f42.google.com with SMTP id kp14so9078886pab.29 for ; Tue, 05 Nov 2013 08:17:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=U5G/xDY78UcbZgPSJqc3IoJk321qHzedq+NOOrf6hdU=; b=z0mcGBAOR8FPI1hkFgzc+vEVXp7vdq0I5jXi0e7n7uODh6X7HGI2/4PjgswFya7BZI tkhEIENhdlUhRkLGQWBp7ufOuxrn9AAbc9oZ1XKCTN4XKm0peEGIP7TKuvVmkliWY1kR AbsFCd3EH1/kBOBNDPGE4TrYragtm8WOzKDBUcKGCxq+t3wewGR14zwApWcXpjKFAFxq js6zHPRP4R+FHVBBjRvQSC2E00IKSpEE+EtXbH5mxzpkR9eJHUQtWNIvyp+mEchR3C5w TbnEmtp+2vAgqN46N9M/LtvJUm06hldcPo4mxpYLtTSyUU4HQI8DSB6hLCp1Elom9S+K DriA== X-Received: by 10.68.166.3 with SMTP id zc3mr23900551pbb.95.1383668258898; Tue, 05 Nov 2013 08:17:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Tue, 5 Nov 2013 08:17:15 -0800 (PST) In-Reply-To: <20131104193840.GU735@rampage> References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> From: Jim Meyering Date: Tue, 5 Nov 2013 08:17:15 -0800 X-Google-Sender-Auth: 2ROPe5cU_xShcbGebPAQWnQ0wKc Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Dave Reisner Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15759@debbugs.gnu.org, 15758@debbugs.gnu.org, Dave Reisner , Stefano Lattarini X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, Nov 4, 2013 at 11:38 AM, Dave Reisner wrote: > On Sat, Nov 02, 2013 at 04:05:52PM -0700, Jim Meyering wrote: >> On Thu, Oct 31, 2013 at 8:26 AM, Jim Meyering wrote: >> ... >> > With this and the nit about --version output being wrong, I now have >> > two reasons to make a new release. >> >> Thanks again for the report, Dave. >> Here's the fix I expect to push: > > Thanks Jim. > > Apologies for not responding to this sooner. I tested your patch and can > confirm that the behavior is better, but the new behavior still seems > like a regression. Take, for example, the simple instance of grep'ing > grep's own git repo. > > # with grep 2.14 > $ grep -rPw GNULIB > gnulib/m4/bison.m4:dnl Declaring YACC & YFLAGS precious will not be necessary after GNULIB > gnulib/lib/glob.c: HAVE_STRUCT_DIRENT_D_TYPE plays the same role in GNULIB. */ > gnulib/lib/netdb.in.h: GNULIB getaddrinfo() replacement, so are not yet needed. > gnulib/lib/argp.h:/* GNULIB makes sure both program_invocation_name and > > # with grep built from HEAD > $ ./src/grep -rPw GNULIB > ./src/grep: invalid UTF-8 byte sequence in input > > I would expect that the invalid UTF-8 wouldn't stop grep cold, but > continue on, ignoring the non-matching data, just as grep without the -P > flag does. Hi Dave, I agree, and so does pcregrep. There are a few other problems with grep's PCRE driver code: for example, a problem (no matter how serious) in one file should not cause the entire grep run to exit; grep should continue processing remaining files. And when grep reports the problem, it should include at least the file name in the diagnostic. I will fix those before the upcoming snapshot. Thanks, Jim From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 26 09:30:31 2013 Received: (at 15758) by debbugs.gnu.org; 26 Nov 2013 14:30:32 +0000 Received: from localhost ([127.0.0.1]:45612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlJen-0006AZ-Pp for submit@debbugs.gnu.org; Tue, 26 Nov 2013 09:30:30 -0500 Received: from mx1.riseup.net ([198.252.153.129]:53854) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlJei-0006A6-Eg for 15758@debbugs.gnu.org; Tue, 26 Nov 2013 09:30:25 -0500 Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Gandi Standard SSL CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4C40A4B8C8; Tue, 26 Nov 2013 06:30:23 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: santiagorr@fruiteater.riseup.net) with ESMTPSA id D0E8D686 Received: by holmon (sSMTP sendmail emulation); Tue, 26 Nov 2013 15:30:03 +0100 Date: Tue, 26 Nov 2013 15:30:03 +0100 From: Santiago To: Jim Meyering Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P Message-ID: <20131126143003.GA30472@holmon> References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="tThc/1wpZn/ma/RB" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.97.8 at mx1 X-Virus-Status: Clean X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758@debbugs.gnu.org, 730472@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --tThc/1wpZn/ma/RB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 05, 2013 at 08:17:15AM -0800, Jim Meyering wrote: ... > > Hi Dave, > > I agree, and so does pcregrep. There are a few other problems with > grep's PCRE driver code: for example, a problem (no matter how serious) > in one file should not cause the entire grep run to exit; grep should > continue processing remaining files. And when grep reports the problem, > it should include at least the file name in the diagnostic. > > I will fix those before the upcoming snapshot. > > Thanks, > Jim > > > Hi there, This bug was also reported in Debian ( http://bugs.debian.org/730472 ). Taking a look on it, I think the most suitable solution for the moment is to flag PCRE_NO_UTF8_CHECK instead of PCRE_UTF8, so PCRE does not check if inputs are UTF8 valid. Resulting behavior is similar to pre-grep-2.15. (See 15758-PCRE-no-check-UTF8.patch) $ grep -Pr "DEFINE" /usr/lib/linux-kbuild-3.2/ /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_SINGLE_EVENT\((.*?),/) { /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_EVENT\((.*?),(.*?),/) { /usr/lib/linux-kbuild-3.2/scripts/kernel-doc:## if ($prototype =~ m/SYSCALL_DEFINE0\s*\(\s*(a-zA-Z0-9_)*\s*\)/) { ... I have also tested printing a message when a file was invalid, but the results can be annoying (15758-PCRE-no-exit-UTF8.patch), since a warning is shown even if files do not match: $ grep -Pr "DEFINE" /usr/lib/linux-kbuild-3.2/ grep: invalid UTF-8 byte sequence in input grep: invalid UTF-8 byte sequence in input grep: invalid UTF-8 byte sequence in input grep: invalid UTF-8 byte sequence in input grep: invalid UTF-8 byte sequence in input grep: invalid UTF-8 byte sequence in input ... /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_SINGLE_EVENT\((.*?),/) { /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_EVENT\((.*?),(.*?),/) { /usr/lib/linux-kbuild-3.2/scripts/kernel-doc:## if ($prototype =~ m/SYSCALL_DEFINE0\s*\(\s*(a-zA-Z0-9_)*\s*\)/) { ... I propose 15758-PCRE-no-check-UTF8.patch as solution, at least temporal. Regards, Santiago --tThc/1wpZn/ma/RB Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="15758-PCRE-no-check-UTF8.patch" diff --git a/src/pcresearch.c b/src/pcresearch.c index 9ba1227..939e8d6 100644 --- a/src/pcresearch.c +++ b/src/pcresearch.c @@ -62,7 +62,7 @@ Pcompile (char const *pattern, size_t size) #if defined HAVE_LANGINFO_CODESET if (STREQ (nl_langinfo (CODESET), "UTF-8")) - flags |= PCRE_UTF8; + flags |= PCRE_NO_UTF8_CHECK; #endif /* FIXME: Remove these restrictions. */ --tThc/1wpZn/ma/RB Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="15758-PCRE-no-exit-UTF8.patch" diff --git a/src/pcresearch.c b/src/pcresearch.c index 9ba1227..8002507 100644 --- a/src/pcresearch.c +++ b/src/pcresearch.c @@ -186,8 +186,9 @@ Pexecute (char const *buf, size_t size, size_t *match_size, _("exceeded PCRE's backtracking limit")); case PCRE_ERROR_BADUTF8: - error (EXIT_TROUBLE, 0, + error (0, 0, _("invalid UTF-8 byte sequence in input")); + break; default: /* For now, we lump all remaining PCRE failures into this basket. --tThc/1wpZn/ma/RB-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 13 13:33:59 2013 Received: (at 15758-done) by debbugs.gnu.org; 13 Dec 2013 18:33:59 +0000 Received: from localhost ([127.0.0.1]:48811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrXYl-0004Bh-2J for submit@debbugs.gnu.org; Fri, 13 Dec 2013 13:33:59 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:51585) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrXYi-0004BV-VF for 15758-done@debbugs.gnu.org; Fri, 13 Dec 2013 13:33:57 -0500 Received: by mail-pb0-f41.google.com with SMTP id jt11so2931381pbb.28 for <15758-done@debbugs.gnu.org>; Fri, 13 Dec 2013 10:33:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=0UqRDSMDfXfANVEuyXOi4CDYscchtNQ5cHDjrjw2cgA=; b=t/CBiT7h52sUeUtEZwG/WFw6GoWpXWgkWDp6vPDZO+w5LmB4EKgWZY5g2TDTbH2p8X kstOIfYmBok4F0tuNj4wXvh76cSd9uX+EP/XPBBIUQZ+36077W4Yw1p5FUNN6todLR8D DAxm2+8UfE4HUKGiHKUWU0SKR7HzFfJIoex9SxiwrWgibXihFEkL1Ebo+DUoQya8rKhz ySUU8Qj2yXL79smcZBH3aCLqf19cbjU0CburAxF8vHCKCyI6702eI0hPwO4R0dCuQf3q NJAEIXd9b5JGO9Qv42ziWw6PpQ/JrXpg2/p72lrnHw+O0bU9pKttOJfpdPpP6jajn/C6 /f0A== X-Received: by 10.67.5.233 with SMTP id cp9mr4775465pad.147.1386959636074; Fri, 13 Dec 2013 10:33:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Fri, 13 Dec 2013 10:33:35 -0800 (PST) In-Reply-To: <20131126143003.GA30472@holmon> References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> From: Jim Meyering Date: Fri, 13 Dec 2013 10:33:35 -0800 X-Google-Sender-Auth: _tIgOWAKb9R3KAQ7rd1vM6rb1jQ Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Santiago Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758-done Cc: 15758-done@debbugs.gnu.org, 730472@bugs.debian.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Nov 26, 2013 at 6:30 AM, Santiago wrote: > This bug was also reported in Debian ( http://bugs.debian.org/730472 ). > > Taking a look on it, I think the most suitable solution for the moment > is to flag PCRE_NO_UTF8_CHECK instead of PCRE_UTF8, so > PCRE does not check if inputs are UTF8 valid. Resulting behavior is > similar to pre-grep-2.15. (See 15758-PCRE-no-check-UTF8.patch) Thanks for the suggested patches and report. Your first patch is almost right. The problem is that we cannot remove the PCRE_UTF8 flag. If we did that, it would disable UTF-8, reverting an older fix. See tests/pcre-utf8 for examples, or run this: printf '\342\202\254\n' | LC_ALL=en_US.UTF-8 src/grep -P '^\p{S}' I've added a commit log, improved a related test and attached a slightly different patch, but left you as the "Author". I'll wait for an explicit ACK before pushing it. With that, there is no need to handle PCRE_ERROR_BADUTF8 because that should not happen. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 13 14:05:49 2013 Received: (at 15758-done) by debbugs.gnu.org; 13 Dec 2013 19:05:49 +0000 Received: from localhost ([127.0.0.1]:48845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrY3Z-00051X-4s for submit@debbugs.gnu.org; Fri, 13 Dec 2013 14:05:49 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:41379) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrY3W-00051P-MD for 15758-done@debbugs.gnu.org; Fri, 13 Dec 2013 14:05:47 -0500 Received: by mail-pa0-f41.google.com with SMTP id lf10so407821pab.28 for <15758-done@debbugs.gnu.org>; Fri, 13 Dec 2013 11:05:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=csTfI1p2uoQAVRZLJfYq1QtZRyL7FowHGxO2Uyjm9Ls=; b=QpmEhJpBrhq4XxdVKNrYLVb1UjsjbSYMKsU4tEWIy+rSHZyesyy/LRkGdxmAvr3z8p q4+pIusbYQVuxPre0REc6ILg6XtKY5JI663cajoJJ3FjoMvyMh6iMIGR1v0Gwp/jMReY bKvT/fIpzcM6KcgWuUCRGVUXqiknPtvJo0sKVyQo8G7jVE21EHQGUgUDoPtF0IljcirH 6nU8n3Gpz8tb8AyCc+pxVM5tiE+cl9a52N90MaU0+gPrxVh7Kpocd9G3mUmFL65+NSxJ K83W+Y3xtcOpVyqHkXUb8F16IVP65UzlsscC1iG2MslxilZqClnA6Jfc+c3pDHVmibtI xrxA== X-Received: by 10.66.192.74 with SMTP id he10mr5173123pac.126.1386961545724; Fri, 13 Dec 2013 11:05:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Fri, 13 Dec 2013 11:05:24 -0800 (PST) In-Reply-To: References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> From: Jim Meyering Date: Fri, 13 Dec 2013 11:05:24 -0800 X-Google-Sender-Auth: mUaBbVVUrJgxPMdo4zQWPnu3-vQ Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Santiago Content-Type: multipart/mixed; boundary=047d7bdc9ebc401c6404ed6f26b9 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758-done Cc: 15758-done <15758-done@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7bdc9ebc401c6404ed6f26b9 Content-Type: text/plain; charset=ISO-8859-1 On Fri, Dec 13, 2013 at 10:33 AM, Jim Meyering wrote: ... > Thanks for the suggested patches and report. Your first patch is > almost right. The problem is that we cannot remove the PCRE_UTF8 flag. > If we did that, it would disable UTF-8, reverting an older fix. > See tests/pcre-utf8 for examples, or run this: > > printf '\342\202\254\n' | LC_ALL=en_US.UTF-8 src/grep -P '^\p{S}' > > I've added a commit log, improved a related test and attached > a slightly different patch, but left you as the "Author". > I'll wait for an explicit ACK before pushing it. > > With that, there is no need to handle PCRE_ERROR_BADUTF8 > because that should not happen. Patch attached, this time. Thanks to Eric Blake for the quick off-list prod :-) --047d7bdc9ebc401c6404ed6f26b9 Content-Type: text/plain; charset=UTF-8; name="k.txt" Content-Disposition: attachment; filename="k.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hp5t1tg30 RnJvbSAyNWI2NjVjMGViMDRjOGZiNjgwMzRjYzdkYjFjZWVhMDhlNjI1YjVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/U2FudGlhZ289MjBSdWFubz0yMFJpbmM9QzM9 QjNuPz0gPHNhbnRpYWdvQGRlYmlhbi5vcmc+CkRhdGU6IEZyaSwgMTMgRGVjIDIwMTMgMDc6NTM6 MzcgLTA4MDAKU3ViamVjdDogW1BBVENIXSBQQ1JFOiB0ZWxsIGdyZXAgLVAgdG8gcmVsYXggaXRz IHN0YW5jZSBvbiBpbnZhbGlkIG11bHRpYnl0ZQogY2hhcnMKTUlNRS1WZXJzaW9uOiAxLjAKQ29u dGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFyc2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5j b2Rpbmc6IDhiaXQKCkRvIG5vdCBleGl0LTIgZm9yIGludmFsaWQgVVRGLTggY2hhcmFjdGVycy4g IEp1c3QgcHJpb3IgdG8gdGhpcwpjaGFuZ2UsIHRoaXMgY29tbWFuZCB3b3VsZCBtYXRjaCBubyBs aW5lcyBhbmQgZmFpbCBsaWtlIHRoaXM6CiAgJCBwcmludGYgJ2pceDgyXG5qXG4nfExDX0FMTD1l bl9VUy5VVEYtOCBncmVwIC1QIGp8Y2F0IC1BOyBlY2hvICQ/CiAgc3JjL2dyZXA6IGludmFsaWQg VVRGLTggYnl0ZSBzZXF1ZW5jZSBpbiBpbnB1dAogIDIKQWZ0ZXIgdGhpcyBjaGFuZ2UsIHRoZSBz YW1lIGNvbW1hbmQgbWF0Y2hlcyBib3RoIGxpbmVzLCBhbmQgc3VjY2VlZHM6CiAgak0tXkIkCiAg aiQKICAwCiogc3JjL3BjcmVzZWFyY2guYyAoUGNvbXBpbGUpOiBVc2UgUENSRV9OT19VVEY4X0NI RUNLLCB0b28sIGFuZAphZGQgYSBjb21tZW50LgoqIHRlc3RzL3BjcmUtdXRmODogQWRkIGEgdGVz dCBhbmQgYSBjb21tZW50LgpCYXNlZCBvbiBhIHBhdGNoIGJ5IFNhbnRpYWdvIFJ1YW5vIFJpbmPD s24uClNlZSBodHRwOi8vYnVncy5nbnUub3JnLzE1NzU4LwotLS0KIHNyYy9wY3Jlc2VhcmNoLmMg fCA2ICsrKysrLQogdGVzdHMvcGNyZS11dGY4ICB8IDYgKysrKysrCiAyIGZpbGVzIGNoYW5nZWQs IDExIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9zcmMvcGNyZXNl YXJjaC5jIGIvc3JjL3BjcmVzZWFyY2guYwppbmRleCA5YmExMjI3Li40Mzk4OGM2IDEwMDY0NAot LS0gYS9zcmMvcGNyZXNlYXJjaC5jCisrKyBiL3NyYy9wY3Jlc2VhcmNoLmMKQEAgLTYyLDcgKzYy LDExIEBAIFBjb21waWxlIChjaGFyIGNvbnN0ICpwYXR0ZXJuLCBzaXplX3Qgc2l6ZSkKCiAjaWYg ZGVmaW5lZCBIQVZFX0xBTkdJTkZPX0NPREVTRVQKICAgaWYgKFNUUkVRIChubF9sYW5naW5mbyAo Q09ERVNFVCksICJVVEYtOCIpKQotICAgIGZsYWdzIHw9IFBDUkVfVVRGODsKKyAgICB7CisgICAg ICAvKiBFbmFibGUgUENSRSdzIFVURi04IG1hdGNoaW5nLCBidXQgZGlzYWJsZSB0aGUgY2hlY2sg dGhhdCB3b3VsZAorICAgICAgICAgbWFrZSBhbiBpbnZhbGlkIGJ5dGUgc2VxZW5jZSAqaW4gdGhl IGlucHV0KiB0cmlnZ2VyIGEgZmFpbHVyZS4gICAqLworICAgICAgZmxhZ3MgfD0gUENSRV9VVEY4 IHwgUENSRV9OT19VVEY4X0NIRUNLOworICAgIH0KICNlbmRpZgoKICAgLyogRklYTUU6IFJlbW92 ZSB0aGVzZSByZXN0cmljdGlvbnMuICAqLwpkaWZmIC0tZ2l0IGEvdGVzdHMvcGNyZS11dGY4IGIv dGVzdHMvcGNyZS11dGY4CmluZGV4IGI4MjI4ZDUuLmEzYjkzOTAgMTAwNzU1Ci0tLSBhL3Rlc3Rz L3BjcmUtdXRmOAorKysgYi90ZXN0cy9wY3JlLXV0ZjgKQEAgLTE5LDkgKzE5LDE1IEBAIGVjaG8g JyQnIHwgTENfQUxMPWVuX1VTLlVURi04IGdyZXAgLXFQICdccHtTfScgXAogZXVybz0nXDM0Mlwy MDJcMjU0IGV1cm8nCiBwcmludGYgIiRldXJvXFxuIiA+IGluIHx8IGZyYW1ld29ya19mYWlsdXJl XwoKKyMgVGhlIGV1cm8gc2lnbiBoYXMgdGhlIHVuaWNvZGUgIlN5bWJvbCIgcHJvcGVydHksIHNv IHRoaXMgbXVzdCBtYXRjaDoKIExDX0FMTD1lbl9VUy5VVEYtOCBncmVwIC1QICdeXHB7U30nIGlu ID4gb3V0IHx8IGZhaWw9MQogY29tcGFyZSBpbiBvdXQgfHwgZmFpbD0xCgorIyBUaGlzIFJFIG11 c3QgKm5vdCogbWF0Y2ggaW4gdGhlIEMgbG9jYWxlLCBiZWNhdXNlIHRoZSBmaXJzdAorIyBieXRl IGlzIG5vdCBhICJTeW1ib2wiLgorTENfQUxMPUMgZ3JlcCAtUCAnXlxwe1N9JyBpbiA+IG91dCAm JiBmYWlsPTEKK2NvbXBhcmUgL2Rldi9udWxsIG91dCB8fCBmYWlsPTEKKwogTENfQUxMPWVuX1VT LlVURi04IGdyZXAgLVAgJ14uIGV1cm8kJyBpbiA+IG91dDIgfHwgZmFpbD0xCiBjb21wYXJlIGlu IG91dDIgfHwgZmFpbD0xCgotLSAKMS44LjUucmMyLjYuZ2M2ZjFiOTIKCg== --047d7bdc9ebc401c6404ed6f26b9-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 11:51:14 2013 Received: (at 15758) by debbugs.gnu.org; 18 Dec 2013 16:51:14 +0000 Received: from localhost ([127.0.0.1]:57457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtKL4-0000k3-Av for submit@debbugs.gnu.org; Wed, 18 Dec 2013 11:51:14 -0500 Received: from mx1.riseup.net ([198.252.153.129]:60581) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtKL1-0000jt-ED for 15758@debbugs.gnu.org; Wed, 18 Dec 2013 11:51:12 -0500 Received: from fulvetta.riseup.net (fulvetta-pn.riseup.net [10.0.1.75]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Gandi Standard SSL CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 7E735515C3; Wed, 18 Dec 2013 08:51:10 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: santiagorr@fulvetta.riseup.net) with ESMTPSA id 4969D1D7 Received: by nomada (sSMTP sendmail emulation); Wed, 18 Dec 2013 11:53:01 -0500 Date: Wed, 18 Dec 2013 11:53:01 -0500 From: Santiago To: Jim Meyering Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P Message-ID: <20131218165301.GB29298@nomada> References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.97.8 at mx1 X-Virus-Status: Clean X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758-done <15758@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) El 13/12/13 a las 11:05, Jim Meyering escribió: > On Fri, Dec 13, 2013 at 10:33 AM, Jim Meyering wrote: > ... > > Thanks for the suggested patches and report. Your first patch is > > almost right. The problem is that we cannot remove the PCRE_UTF8 flag. > > If we did that, it would disable UTF-8, reverting an older fix. > > See tests/pcre-utf8 for examples, or run this: > > > > printf '\342\202\254\n' | LC_ALL=en_US.UTF-8 src/grep -P '^\p{S}' > > > > I've added a commit log, improved a related test and attached > > a slightly different patch, but left you as the "Author". > > I'll wait for an explicit ACK before pushing it. > > > > With that, there is no need to handle PCRE_ERROR_BADUTF8 > > because that should not happen. > > Patch attached, this time. > Thanks to Eric Blake for the quick off-list prod :-) Hi Jim, Thanks for your work, but I'm not sure using both flags works as we need. Actually, I had tried that before submitting my patch. I got this using your changes: $ src/grep -Pr "DEFINE" /usr/lib/linux-kbuild-3.2/ src/grep: invalid UTF-8 byte sequence in input When I'd expected something like: $ LC_ALL=C src/grep -Pr "DEFINE" /usr/lib/linux-kbuild-3.2/ /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_SINGLE_EVENT\((.*?),/) { /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_EVENT\((.*?),(.*?),/) { /usr/lib/linux-kbuild-3.2/scripts/kernel-doc:## if ($prototype =~ m/SYSCALL_DEFINE0\s*\(\s*(a-zA-Z0-9_)*\s*\)/) { /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/SYSCALL_DEFINE0/) { ... Maybe, it is a pcre (v. 8.31) issue. Regards, Santiago From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 12:46:16 2013 Received: (at 15758) by debbugs.gnu.org; 18 Dec 2013 17:46:16 +0000 Received: from localhost ([127.0.0.1]:57512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtLCK-0002FP-4s for submit@debbugs.gnu.org; Wed, 18 Dec 2013 12:46:16 -0500 Received: from mail-pd0-f179.google.com ([209.85.192.179]:40352) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtLCG-0002FE-Ov for 15758@debbugs.gnu.org; Wed, 18 Dec 2013 12:46:13 -0500 Received: by mail-pd0-f179.google.com with SMTP id r10so8550764pdi.38 for <15758@debbugs.gnu.org>; Wed, 18 Dec 2013 09:46:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=pHyG9fJONBVRyjVcp+new0iFztr8oWY8lJ5ckXnmDI8=; b=fbZUybYHzfbbBAhPGejRoozXt0eHN0AgrF2Ltg5yAccNi5U1MNx6X8imjcg9O+4Bx6 SuxBzSV6xy4TQe9wXMC2YBhcp1h9OIBMOGNsaEZb6s4l/zi4IVe4D/lHmcuzD2m/VDQa 4ft3KsXssfEQzVsknZfJQh55DHQdPOvvfgp4yxKKT5TKWVbxDO6TKyECRuHnEoxPgakr VzVF6K1dnFiDIvaMogb7pauVURxofuTShomQn5DyTfhrjNkIjncl7jZiqkErcV7HmzlT 5TbswHb/JgCTDR1Ex+LQGx1tMShEyRm2H/rcXQ2AMTy3UPKcxifvapSR2mogIOiXeoKE 6LjQ== X-Received: by 10.66.192.74 with SMTP id he10mr35484588pac.126.1387388771592; Wed, 18 Dec 2013 09:46:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Wed, 18 Dec 2013 09:45:51 -0800 (PST) In-Reply-To: <20131218165301.GB29298@nomada> References: <20131030164235.GK735@rampage> <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> <20131218165301.GB29298@nomada> From: Jim Meyering Date: Wed, 18 Dec 2013 09:45:51 -0800 X-Google-Sender-Auth: 91Aj8tOw0kzj3VtHJ8_n7qYjQ_E Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Santiago Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758-done <15758@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Wed, Dec 18, 2013 at 8:53 AM, Santiago wrote: ... > $ src/grep -Pr "DEFINE" /usr/lib/linux-kbuild-3.2/ > src/grep: invalid UTF-8 byte sequence in input > > When I'd expected something like: > > $ LC_ALL=C src/grep -Pr "DEFINE" /usr/lib/linux-kbuild-3.2/ > /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_SINGLE_EVENT\((.*?),/) { > /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/DEFINE_EVENT\((.*?),(.*?),/) { > /usr/lib/linux-kbuild-3.2/scripts/kernel-doc:## if ($prototype =~ m/SYSCALL_DEFINE0\s*\(\s*(a-zA-Z0-9_)*\s*\)/) { > /usr/lib/linux-kbuild-3.2/scripts/kernel-doc: if ($prototype =~ m/SYSCALL_DEFINE0/) { > ... > > Maybe, it is a pcre (v. 8.31) issue. Hi Santiago, Thanks for testing that. What do you get when you run the stand-alone example I gave in the commit log and in the test? printf 'j\x82\nj\n'|LC_ALL=en_US.UTF-8 grep -P j|cat -A; echo $? For me (using pcre-8.33), it works the way I want and both matches: jM-^B$ j$ 0 Hmm... I see that with debian unstable's 8.31-2, it does indeed act differently. I may have to think about excluding pcre support when the version doesn't work the way I want. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 18 18:08:07 2013 Received: (at 15758) by debbugs.gnu.org; 18 Dec 2013 23:08:07 +0000 Received: from localhost ([127.0.0.1]:57838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtQDn-00038G-C1 for submit@debbugs.gnu.org; Wed, 18 Dec 2013 18:08:07 -0500 Received: from mx1.riseup.net ([198.252.153.129]:54840) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtQDk-000387-8e for 15758@debbugs.gnu.org; Wed, 18 Dec 2013 18:08:05 -0500 Received: from fruiteater.riseup.net (fruiteater-pn.riseup.net [10.0.1.74]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Gandi Standard SSL CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 9F47C52110; Wed, 18 Dec 2013 15:08:03 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: santiagorr@fruiteater.riseup.net) with ESMTPSA id 81A57E10 Received: by nomada (sSMTP sendmail emulation); Wed, 18 Dec 2013 18:09:55 -0500 Date: Wed, 18 Dec 2013 18:09:55 -0500 From: Santiago To: Jim Meyering Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P Message-ID: <20131218230955.GA20728@nomada> References: <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> <20131218165301.GB29298@nomada> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.97.8 at mx1 X-Virus-Status: Clean X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: El 18/12/13 a las 09:45, Jim Meyering escribió: ... > > Hi Santiago, > Thanks for testing that. > What do you get when you run the stand-alone example I gave in the > commit log and in the test? > > printf 'j\x82\nj\n'|LC_ALL=en_US.UTF-8 grep -P j|cat -A; echo $? > > For me (using pcre-8.33), it works the way I want and both matches: > > jM-^B$ > j$ > 0 > > Hmm... I see that with debian unstable's 8.31-2, it does indeed act differently. > I may have to think about excluding pcre support when the version > doesn't work the way I want. [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [198.252.153.129 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: 15758 Cc: 15758@debbugs.gnu.org, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: El 18/12/13 a las 09:45, Jim Meyering escribió: ... > > Hi Santiago, > Thanks for testing that. > What do you get when you run the stand-alone example I gave in the > commit log and in the test? > > printf 'j\x82\nj\n'|LC_ALL=en_US.UTF-8 grep -P j|cat -A; echo $? > > For me (using pcre-8.33), it works the way I want and both matches: > > jM-^B$ > j$ > 0 > > Hmm... I see that with debian unstable's 8.31-2, it does indeed act differently. > I may have to think about excluding pcre support when the version > doesn't work the way I want. [...] Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [198.252.153.129 listed in list.dnswl.org] 1.2 RCVD_IN_BL_SPAMCOP_NET RBL: Received via a relay in bl.spamcop.net [Blocked - see ] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines El 18/12/13 a las 09:45, Jim Meyering escribió: ... > > Hi Santiago, > Thanks for testing that. > What do you get when you run the stand-alone example I gave in the > commit log and in the test? > > printf 'j\x82\nj\n'|LC_ALL=en_US.UTF-8 grep -P j|cat -A; echo $? > > For me (using pcre-8.33), it works the way I want and both matches: > > jM-^B$ > j$ > 0 > > Hmm... I see that with debian unstable's 8.31-2, it does indeed act differently. > I may have to think about excluding pcre support when the version > doesn't work the way I want. I get this: $ printf 'j\x82\nj\n'|LC_ALL=en_US.UTF-8 src/grep -P j|cat -A; echo $? src/grep: invalid UTF-8 byte sequence in input 0 I've also tried building debian packages for pcre 8.33 and 8.34, with same results. I need to take a look if a debian patch is giving trouble. Cheers! Santiago From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 19 13:34:30 2013 Received: (at 15758) by debbugs.gnu.org; 19 Dec 2013 18:34:30 +0000 Received: from localhost ([127.0.0.1]:58914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtiQY-0006s8-4F for submit@debbugs.gnu.org; Thu, 19 Dec 2013 13:34:30 -0500 Received: from mail-pb0-f41.google.com ([209.85.160.41]:65419) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtiQV-0006rw-0H for 15758@debbugs.gnu.org; Thu, 19 Dec 2013 13:34:27 -0500 Received: by mail-pb0-f41.google.com with SMTP id jt11so1510749pbb.28 for <15758@debbugs.gnu.org>; Thu, 19 Dec 2013 10:34:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type:content-transfer-encoding; bh=wCnlIYs+LGZAkLoiiedsQWin1wqCe4eh2/33EgkF7fI=; b=1G7RgA/V+c71wD3yxZguoS0qj05CJ9A/7qCAak4OMmUoYbBhh5ls8FlbVisgXVrx8l x8OPpFTlNB0HGdtA/xZodq5I+YI6aok2oYjPGQQvIotWkc3fRUFm0aCGMb9H77xiP8LU u9gc/cxCe405GfBVmDA7Az97ELWqTlPNM/xvKWoYiAIs7+sHekeghP1+LOkWda395Pek Ga2q4ejLlQTl4XFCjbpo0kadH9BEwODMalzNBpGzqlbIsqKtugDAZz32Zt5NFbVnuaXe YFbH37TSl8YukIdFiiudcM/5FZNvgVyHDpzycMuOOnaDrBSZBsdU/x9EaKNXceo4MK81 WYJw== X-Received: by 10.69.31.170 with SMTP id kn10mr3408481pbd.106.1387478065934; Thu, 19 Dec 2013 10:34:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Thu, 19 Dec 2013 10:34:05 -0800 (PST) In-Reply-To: <20131218230955.GA20728@nomada> References: <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> <20131218165301.GB29298@nomada> <20131218230955.GA20728@nomada> From: Jim Meyering Date: Thu, 19 Dec 2013 10:34:05 -0800 X-Google-Sender-Auth: c1r6BorqW2m7diN6iruvMDR1YYI Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Santiago Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758-done <15758@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Wed, Dec 18, 2013 at 3:09 PM, Santiago wrote: > El 18/12/13 a las 09:45, Jim Meyering escribi=F3: ... >> printf 'j\x82\nj\n'|LC_ALL=3Den_US.UTF-8 grep -P j|cat -A; echo $? >> >> For me (using pcre-8.33), it works the way I want and both matches: >> >> jM-^B$ >> j$ >> 0 >> >> Hmm... I see that with debian unstable's 8.31-2, it does indeed act diff= erently. >> I may have to think about excluding pcre support when the version >> doesn't work the way I want. > > I get this: > > $ printf 'j\x82\nj\n'|LC_ALL=3Den_US.UTF-8 src/grep -P j|cat -A; echo $? > src/grep: invalid UTF-8 byte sequence in input > 0 > > I've also tried building debian packages for pcre 8.33 and 8.34, with sam= e > results. I need to take a look if a debian patch is giving trouble. I have confirmed that grep linked with libpcre.a built from upstream sources [commit f9d3a72ea5e86a674a9836b462e1231ecce0d739] (8.34) also works way I expect. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 13:46:45 2013 Received: (at 15758) by debbugs.gnu.org; 21 Dec 2013 18:46:45 +0000 Received: from localhost ([127.0.0.1]:33535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuRZU-0008G3-4Y for submit@debbugs.gnu.org; Sat, 21 Dec 2013 13:46:44 -0500 Received: from mail-pb0-f47.google.com ([209.85.160.47]:33012) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuRZP-0008Fk-TI for 15758@debbugs.gnu.org; Sat, 21 Dec 2013 13:46:40 -0500 Received: by mail-pb0-f47.google.com with SMTP id um1so3891498pbc.20 for <15758@debbugs.gnu.org>; Sat, 21 Dec 2013 10:46:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=hQMvPzie+t2qOWaQ/P3MZgtrsCk1rOqc0f3fQEMwe0s=; b=qykeSN4xHymJW5g8c1O2mJyci46tSi5O+Hjxm0IOjdsySe22SC9uCSRnDR10mBhLeO 8w+V0QwZxH2F78cyoFPIjNSvsdi8Ay5JFjvLvDrReU81wq0Qc16RlX13fHgQkuSHNdjl QQHQNm98nZFtckbuu/q6R9w8DUN57SzVKr6uHyhnX/hgAYKExUnE0dGURM6pcGq6d2IV HZu3B/0Aw+tZRDhsD9pGxqThqwJ3nN6+GNvUE5MxsBtXPa1SqTHKPHPTgVfdtf5P+iWE CDDt95Fbq0LoRPRrzefeGBZSY/3BNvQMZwz13wKJBxNdd/ekcGpVsF5g6Izi2aHyoxlc Y0Zg== X-Received: by 10.66.159.132 with SMTP id xc4mr16157313pab.27.1387651598775; Sat, 21 Dec 2013 10:46:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Sat, 21 Dec 2013 10:46:18 -0800 (PST) In-Reply-To: References: <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> <20131218165301.GB29298@nomada> <20131218230955.GA20728@nomada> From: Jim Meyering Date: Sat, 21 Dec 2013 10:46:18 -0800 X-Google-Sender-Auth: gqO__bCuA2nTsbUV_grmOzNWrbg Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Santiago Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758-done <15758@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Dec 19, 2013 at 10:34 AM, Jim Meyering wrote: > I have confirmed that grep linked with libpcre.a built from upstream > sources [commit f9d3a72ea5e86a674a9836b462e1231ecce0d739] (8.34) also > works the way I expect. More data points: Fedora 20 and OS/X work both with pcre-8.33, so I conclude this is a problem specific to some Debian-specific patch. I expect to push that patch as-is and defer to a separate commit (or maybe even skip altogether) any portability hack that might warn or disable PCRE support when detecting the broken library. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 21 14:01:48 2013 Received: (at 15758) by debbugs.gnu.org; 21 Dec 2013 19:01:49 +0000 Received: from localhost ([127.0.0.1]:33568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuRo4-0000Ke-0S for submit@debbugs.gnu.org; Sat, 21 Dec 2013 14:01:48 -0500 Received: from mail-pb0-f49.google.com ([209.85.160.49]:58625) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuRo1-0000KU-HH for 15758@debbugs.gnu.org; Sat, 21 Dec 2013 14:01:46 -0500 Received: by mail-pb0-f49.google.com with SMTP id jt11so3867978pbb.22 for <15758@debbugs.gnu.org>; Sat, 21 Dec 2013 11:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=ZLCiHIse1IYoazypSalAQAOQlE9DkXWeORbMsjltuCM=; b=u1WQalZii4d2p3fcaYmMLKO4Z56vxzN2w403hzmMOQeZLdSRB+xE0VCVxQhzMg6hW9 1hgqddo2lch1MKvkAnCm6LSbfD6Aky6cOLD3mvCy4/oIviw+OkQL9UDebfHMrWpFrns/ XlWq45sIuTWMQeSY02kbFjdIyiQk+qJHGAEOdkvR3JZt8Bl4X/IE+HBoFvIm7sNFrcDO NOw0eiETPbiI9gBvcw2lSzLtjk9z06Qvh0AIR9X4s7Id5Lr6yf5dyM44JWkUJ7kBhYF2 ptPs476mnXBLQXzqBOtH57C4zIlWqgNfwqBFZchsRiR4GTH9qQqsD0w6tiSNdWZ5sjr4 ueCg== X-Received: by 10.68.241.134 with SMTP id wi6mr16249727pbc.44.1387652504530; Sat, 21 Dec 2013 11:01:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Sat, 21 Dec 2013 11:01:24 -0800 (PST) In-Reply-To: References: <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> <20131218165301.GB29298@nomada> <20131218230955.GA20728@nomada> From: Jim Meyering Date: Sat, 21 Dec 2013 11:01:24 -0800 X-Google-Sender-Auth: 50XTO4LDGmmG-4DdYHSB8Iituz0 Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Santiago Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758-done <15758@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sat, Dec 21, 2013 at 10:46 AM, Jim Meyering wrote: > I expect to push that patch as-is and defer to a separate commit > (or maybe even skip altogether) any portability hack that might warn > or disable PCRE support when detecting the broken library. Pushed. Let's take any discussion of grep's workaround for Debian's PCRE problem to a new thread/issue. From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 31 13:53:38 2013 Received: (at 15758) by debbugs.gnu.org; 31 Dec 2013 18:53:38 +0000 Received: from localhost ([127.0.0.1]:54974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vy4Rd-0003Fu-RF for submit@debbugs.gnu.org; Tue, 31 Dec 2013 13:53:38 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:37716) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vy4Rb-0003Fj-19 for 15758@debbugs.gnu.org; Tue, 31 Dec 2013 13:53:35 -0500 Received: by mail-pa0-f53.google.com with SMTP id hz1so12983422pad.12 for <15758@debbugs.gnu.org>; Tue, 31 Dec 2013 10:53:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=8y+ELcRXpLAy/Ihs/6oFUBJD9F/rFJxdbnh07bIraSg=; b=cEYVaKBk+uKGWq3kGyB4yPc6glg0aaA7OyXZP/aCbh0rDm4nv3Asj6/NAaRJiEkKpg tSRQEdvIqySgi6V2FQAJt/sNC87CUdRUB5/++jXZGagl2fCfffkRNJo/4TTnK5AEhnBb F3GbjnmhJ1NuHpXo3v+E0N0GES6RtqgNpXMSsEG1y5AAJSfBUa4/s/LwRoUBVIKNSZN4 wcvZmg8u9beZe4fYZ0qZIAx5RM7bOyYQu7r2uNwQyb58Mw8CXGtebByONKlhrzmdDMsJ HDRwsg/5+jI8La4vXkMqLxIL2uaWFoKVCx9md1tD3dh1sbpLOItUMl9ab+zrAQCoHWKP v+iw== X-Received: by 10.66.159.132 with SMTP id xc4mr76958677pab.27.1388516013754; Tue, 31 Dec 2013 10:53:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.6.66 with HTTP; Tue, 31 Dec 2013 10:53:13 -0800 (PST) In-Reply-To: References: <527177E5.1090600@gmail.com> <20131104193840.GU735@rampage> <20131126143003.GA30472@holmon> <20131218165301.GB29298@nomada> <20131218230955.GA20728@nomada> From: Jim Meyering Date: Tue, 31 Dec 2013 10:53:13 -0800 X-Google-Sender-Auth: NkZxKjQYJH4phlcjl-O6YD2A4fQ Message-ID: Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P To: Santiago Content-Type: multipart/mixed; boundary=047d7b6d7a10c436ff04eed913a1 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758-done <15758@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --047d7b6d7a10c436ff04eed913a1 Content-Type: text/plain; charset=ISO-8859-1 On Sat, Dec 21, 2013 at 11:01 AM, Jim Meyering wrote: > On Sat, Dec 21, 2013 at 10:46 AM, Jim Meyering wrote: >> I expect to push that patch as-is and defer to a separate commit >> (or maybe even skip altogether) any portability hack that might warn >> or disable PCRE support when detecting the broken library. > > Pushed. Let's take any discussion of grep's workaround for Debian's > PCRE problem to a new thread/issue. Hmm... I was chagrined not to be able to reproduce the output I quoted above, so dug into it and found the real error (mine), fixed it and adjusted the test: --047d7b6d7a10c436ff04eed913a1 Content-Type: text/plain; charset=US-ASCII; name="k.txt" Content-Disposition: attachment; filename="k.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hpvijrl00 RnJvbSA5MzExY2Y5YzRmMWU2YTk3YzJlMDFlNGE4NmY4ZjkzN2M4MDEwYTAxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gTWV5ZXJpbmcgPG1leWVyaW5nQGZiLmNvbT4KRGF0ZTog VHVlLCAzMSBEZWMgMjAxMyAwODoxNTowNyAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIHBjcmU6IHVz ZSBQQ1JFX05PX1VURjhfQ0hFQ0sgcHJvcGVybHkKCkluIG9yZGVyIHRvIG9idGFpbiB0aGUgYmVo YXZpb3Igd2Ugd2FudCwgaS5lLiwgdG8gZGlzYWJsZQplcnJvci1vbi1pbnZhbGlkLVVURi1pbi1p bnB1dCwgYXBwbHkgdGhpcyBQQ1JFIG9wdGlvbiBpbgpwY3JlX2V4ZWMsIG5vdCB3aGVuIGNvbXBp bGluZy4KKiBzcmMvcGNyZXNlYXJjaC5jIChQZXhlY3V0ZSk6IFVzZSBQQ1JFX05PX1VURjhfQ0hF Q0sgaGVyZSwgLi4uCihQY29tcGlsZSk6IC4uLnJhdGhlciB0aGFuIGhlcmUuCiogdGVzdHMvcGNy ZS1pbnZhbGlkLXV0ZjgtaW5wdXQ6IEFkanVzdCB0ZXN0IGNhc2UgdG8gdGVzdCBmb3IgdGhpcy4K LS0tCiBzcmMvcGNyZXNlYXJjaC5jICAgICAgICAgICAgICB8IDEyICsrKysrKysrLS0tLQogdGVz dHMvcGNyZS1pbnZhbGlkLXV0ZjgtaW5wdXQgfCAxMSArKysrLS0tLS0tLQogMiBmaWxlcyBjaGFu Z2VkLCAxMiBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMv cGNyZXNlYXJjaC5jIGIvc3JjL3BjcmVzZWFyY2guYwppbmRleCA2NjQwNzBkLi40YWJkOWMyIDEw MDY0NAotLS0gYS9zcmMvcGNyZXNlYXJjaC5jCisrKyBiL3NyYy9wY3Jlc2VhcmNoLmMKQEAgLTYz LDkgKzYzLDkgQEAgUGNvbXBpbGUgKGNoYXIgY29uc3QgKnBhdHRlcm4sIHNpemVfdCBzaXplKQog IyBpZiBkZWZpbmVkIEhBVkVfTEFOR0lORk9fQ09ERVNFVAogICBpZiAoU1RSRVEgKG5sX2xhbmdp bmZvIChDT0RFU0VUKSwgIlVURi04IikpCiAgICAgewotICAgICAgLyogRW5hYmxlIFBDUkUncyBV VEYtOCBtYXRjaGluZywgYnV0IGRpc2FibGUgdGhlIGNoZWNrIHRoYXQgd291bGQKLSAgICAgICAg IG1ha2UgYW4gaW52YWxpZCBieXRlIHNlcWVuY2UgKmluIHRoZSBpbnB1dCogdHJpZ2dlciBhIGZh aWx1cmUuICAgKi8KLSAgICAgIGZsYWdzIHw9IFBDUkVfVVRGOCB8IFBDUkVfTk9fVVRGOF9DSEVD SzsKKyAgICAgIC8qIEVuYWJsZSBQQ1JFJ3MgVVRGLTggbWF0Y2hpbmcuICBOb3RlIGFsc28gdGhl IHVzZSBvZgorICAgICAgICAgUENSRV9OT19VVEY4X0NIRUNLIHdoZW4gY2FsbGluZyBwY3JlX2V4 dHJhLCBiZWxvdy4gICAqLworICAgICAgZmxhZ3MgfD0gUENSRV9VVEY4OwogICAgIH0KICMgZW5k aWYKCkBAIC0xNTgsNiArMTU4LDEwIEBAIFBleGVjdXRlIChjaGFyIGNvbnN0ICpidWYsIHNpemVf dCBzaXplLCBzaXplX3QgKm1hdGNoX3NpemUsCiAgICAgICAgZSA9PSBQQ1JFX0VSUk9SX05PTUFU Q0ggJiYgbGluZV9uZXh0IDwgYnVmICsgc2l6ZTsKICAgICAgICBzdGFydF9vZnMgLT0gbGluZV9u ZXh0IC0gbGluZV9idWYpCiAgICAgeworICAgICAgLyogRGlzYWJsZSB0aGUgY2hlY2sgdGhhdCB3 b3VsZCBtYWtlIGFuIGludmFsaWQgYnl0ZQorICAgICAgICAgc2VxZW5jZSAqaW4gdGhlIGlucHV0 KiB0cmlnZ2VyIGEgZmFpbHVyZS4gICAqLworICAgICAgaW50IG9wdGlvbnMgPSBQQ1JFX05PX1VU RjhfQ0hFQ0s7CisKICAgICAgIGxpbmVfYnVmID0gbGluZV9uZXh0OwogICAgICAgbGluZV9lbmQg PSBtZW1jaHIgKGxpbmVfYnVmLCBlb2xieXRlLCAoYnVmICsgc2l6ZSkgLSBsaW5lX2J1Zik7CiAg ICAgICBpZiAobGluZV9lbmQgPT0gTlVMTCkKQEAgLTE3Miw3ICsxNzYsNyBAQCBQZXhlY3V0ZSAo Y2hhciBjb25zdCAqYnVmLCBzaXplX3Qgc2l6ZSwgc2l6ZV90ICptYXRjaF9zaXplLAogICAgICAg ICBlcnJvciAoRVhJVF9UUk9VQkxFLCAwLCBfKCJleGNlZWRlZCBQQ1JFJ3MgbGluZSBsZW5ndGgg bGltaXQiKSk7CgogICAgICAgZSA9IHBjcmVfZXhlYyAoY3JlLCBleHRyYSwgbGluZV9idWYsIGxp bmVfZW5kIC0gbGluZV9idWYsCi0gICAgICAgICAgICAgICAgICAgICBzdGFydF9vZnMgPCAwID8g MCA6IHN0YXJ0X29mcywgMCwKKyAgICAgICAgICAgICAgICAgICAgIHN0YXJ0X29mcyA8IDAgPyAw IDogc3RhcnRfb2ZzLCBvcHRpb25zLAogICAgICAgICAgICAgICAgICAgICAgc3ViLCBzaXplb2Yg c3ViIC8gc2l6ZW9mICpzdWIpOwogICAgIH0KCmRpZmYgLS1naXQgYS90ZXN0cy9wY3JlLWludmFs aWQtdXRmOC1pbnB1dCBiL3Rlc3RzL3BjcmUtaW52YWxpZC11dGY4LWlucHV0CmluZGV4IDUyYTU0 MzIuLmM3MDk1MWYgMTAwNzU1Ci0tLSBhL3Rlc3RzL3BjcmUtaW52YWxpZC11dGY4LWlucHV0Cisr KyBiL3Rlc3RzL3BjcmUtaW52YWxpZC11dGY4LWlucHV0CkBAIC0xMywxMyArMTMsMTAgQEAgcmVx dWlyZV9lbl91dGY4X2xvY2FsZV8KCiBmYWlsPTAKCi1wcmludGYgJ1wyMDJcbicgPiBpbiB8fCBm cmFtZXdvcmtfZmFpbHVyZV8KLXByaW50ZiAnZ3JlcDogaW52YWxpZCBVVEYtOCBieXRlIHNlcXVl bmNlIGluIGlucHV0XG4nIFwKLSAgID4gZXhwLWVyciB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KK3By aW50ZiAnalwyMDJcbmpcbicgPiBpbiB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KCi1MQ19BTEw9ZW5f VVMuVVRGLTggZ3JlcCAtUCBhbnl0aGluZyBpbiA+IG91dCAyPiBlcnIKLXRlc3QgJD8gPSAyIHx8 IGZhaWw9MQotY29tcGFyZSAvZGV2L251bGwgb3V0IHx8IGZhaWw9MQotY29tcGFyZSBleHAtZXJy IGVyciB8fCBmYWlsPTEKK0xDX0FMTD1lbl9VUy5VVEYtOCBncmVwIC1QIGogaW4gPiBvdXQgMj4m MSB8fCBmYWlsPTEKK2NvbXBhcmUgaW4gb3V0IHx8IGZhaWw9MQorY29tcGFyZSAvZGV2L251bGwg ZXJyIHx8IGZhaWw9MQoKIEV4aXQgJGZhaWwKLS0gCjEuOC41LnJjMi42LmdjNmYxYjkyCgo= --047d7b6d7a10c436ff04eed913a1-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 04:04:47 2014 Received: (at 15758) by debbugs.gnu.org; 23 Jan 2014 09:04:47 +0000 Received: from localhost ([127.0.0.1]:32957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6GDP-0005b1-4J for submit@debbugs.gnu.org; Thu, 23 Jan 2014 04:04:47 -0500 Received: from mx1.riseup.net ([198.252.153.129]:43128) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6GDN-0005at-Pt for 15758@debbugs.gnu.org; Thu, 23 Jan 2014 04:04:46 -0500 Received: from fulvetta.riseup.net (fulvetta-pn.riseup.net [10.0.1.75]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.riseup.net", Issuer "Gandi Standard SSL CA" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 124454E63D; Thu, 23 Jan 2014 01:04:45 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: santiagorr@fulvetta.riseup.net) with ESMTPSA id CDB5823F Received: by holmon (sSMTP sendmail emulation); Thu, 23 Jan 2014 10:03:25 +0100 Date: Thu, 23 Jan 2014 10:03:25 +0100 From: Santiago To: Jim Meyering Subject: Re: bug#15758: grep 2.15 calls abort() on larger searches with -P Message-ID: <20140123090325.GA18258@holmon> References: <20131126143003.GA30472@holmon> <20131218165301.GB29298@nomada> <20131218230955.GA20728@nomada> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Virus-Scanned: clamav-milter 0.97.8 at mx1 X-Virus-Status: Clean X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15758 Cc: 15758 <15758@debbugs.gnu.org>, 730472 <730472@bugs.debian.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On Tue, Dec 31, 2013 at 10:53:13AM -0800, Jim Meyering wrote: > On Sat, Dec 21, 2013 at 11:01 AM, Jim Meyering wrote: > > On Sat, Dec 21, 2013 at 10:46 AM, Jim Meyering wrote: > >> I expect to push that patch as-is and defer to a separate commit > >> (or maybe even skip altogether) any portability hack that might warn > >> or disable PCRE support when detecting the broken library. > > > > Pushed. Let's take any discussion of grep's workaround for Debian's > > PCRE problem to a new thread/issue. > > Hmm... I was chagrined not to be able to reproduce the output I quoted > above, so dug into it and found the real error (mine), fixed it and > adjusted the test: (Sorry, I was forgetting to answer you, my holidays were quite long.) Great! It works and it's on debian unstable now. Thanks, Santiago From unknown Fri Jun 20 19:52:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Feb 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator