GNU bug report logs - #15745
[PATCH] Define semantic-idle-symbol-highlight-face with defface

Previous Next

Package: emacs;

Reported by: Barry OReilly <gundaetiapo <at> gmail.com>

Date: Mon, 28 Oct 2013 21:05:02 UTC

Severity: wishlist

Tags: patch

Done: Barry OReilly <gundaetiapo <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 15745 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 15745 <at> debbugs.gnu.org
Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face
 with defface
Date: Mon, 28 Oct 2013 17:38:47 -0400

New face names should not end in -face.

The standard backwards-compatible way to make a change like this is:

1) Add:
(defface semantic-idle-symbol-highlight ...)

2) Change:
(defvar semantic-idle-symbol-highlight-face 'semantic-idle-symbol-highlight)

3) Mark semantic-idle-symbol-highlight-face the variable obsolete,
in favour of semantic-idle-symbol-highlight the face.

See eg diary-face.
This bug report was last modified 11 years and 208 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.