GNU bug report logs - #15745
[PATCH] Define semantic-idle-symbol-highlight-face with defface

Previous Next

Full log

View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 15745 <at> debbugs.gnu.org
Subject: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface
Date: Mon, 28 Oct 2013 22:29:57 -0400

Barry OReilly wrote:

> Thanks, how is the attached revised patch?

Not quite what I had in mind (taking something that was a variable and
turning it into a face alias won't work right, will it?).

-(defvar semantic-idle-symbol-highlight-face 'region
-  "Face used for highlighting local symbols.")
+(defface semantic-idle-symbol-highlight
+  '((((class color) (background dark))
+     ;; Put this back to something closer to black later.
+     (:background "gray20"))
+    (((class color) (background light))
+     (:background "gray90")))
+  "Face used for highlighting local symbols."
+  :group 'semantic-faces)

As has been said:

  (defface semantic-idle-symbol-highlight '((t (:inherit region))) ...)

+(define-obsolete-face-alias
+  'semantic-idle-symbol-highlight-face
+  'semantic-idle-symbol-highlight
+  "24.4")

Rather than the above, I meant:

  (make-obsolete-variable 'semantic-idle-symbol-highlight-face
    "customize the face `semantic-idle-symbol-highlight' instead" "24.4" 'set)

Then these bits:

-                     region semantic-idle-symbol-highlight-face)
+                     region 'semantic-idle-symbol-highlight)

are not necessary (or appropriate).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.