From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 17:04:13 2013 Received: (at submit) by debbugs.gnu.org; 28 Oct 2013 21:04:13 +0000 Received: from localhost ([127.0.0.1]:49881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vatyu-0004op-FX for submit@debbugs.gnu.org; Mon, 28 Oct 2013 17:04:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35916) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vatyr-0004oZ-Py for submit@debbugs.gnu.org; Mon, 28 Oct 2013 17:04:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vatyl-0003A2-N1 for submit@debbugs.gnu.org; Mon, 28 Oct 2013 17:04:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vatyl-00039v-JN for submit@debbugs.gnu.org; Mon, 28 Oct 2013 17:04:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37623) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vatyk-0003Aa-Rd for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2013 17:04:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vatyj-00039R-Tz for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2013 17:04:02 -0400 Received: from mail-oa0-x231.google.com ([2607:f8b0:4003:c02::231]:50755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vatyj-000399-Gv for bug-gnu-emacs@gnu.org; Mon, 28 Oct 2013 17:04:01 -0400 Received: by mail-oa0-f49.google.com with SMTP id j10so4238976oah.36 for ; Mon, 28 Oct 2013 14:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=8gMAz7Cl0p6fnE1XmZB4/poe27Kl1yFYrHZq2rctp9M=; b=XW4jR4tGfyI6mSKYTRNYfZf5C+l3xNPrAEZL4Zbr0OgRsPXOyjVLbeAvIDCZbcOp8Y BqJdR4Zlqaiote/JTmopHIYl2dyqzctiEv1sWHScZstWl94Qlq1hQtWRKT2mBFuHq1fC +MfMClQWK8wMm6YeyC5pADKa8+tcRSUkbFXCexqqproBm3BYSWtVQeiBnifTr/GeMlm6 riyt3UDiIc0/jOfZRPw9s6qmuoywuDryNLSdSlclU4ihbBePoMvXHta/lu7hGNyKLWCh EJoED9ocHXNCKdhYLTq93Saeiy51YcYAMDy6LvlWxjUca8TxALY+EUkrUaWZkblkdDXi Ae6A== MIME-Version: 1.0 X-Received: by 10.182.117.195 with SMTP id kg3mr16508438obb.17.1382994240314; Mon, 28 Oct 2013 14:04:00 -0700 (PDT) Received: by 10.76.156.103 with HTTP; Mon, 28 Oct 2013 14:04:00 -0700 (PDT) Date: Mon, 28 Oct 2013 17:04:00 -0400 Message-ID: Subject: [PATCH] Define semantic-idle-symbol-highlight-face with defface From: Barry OReilly To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary=089e0149c5066dc0d204e9d3708b X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --089e0149c5066dc0d204e9d3708b Content-Type: multipart/alternative; boundary=089e0149c5066dc0ce04e9d37089 --089e0149c5066dc0ce04e9d37089 Content-Type: text/plain; charset=ISO-8859-1 It would be more convenient to customize semantic-idle-symbol-highlight-face in the manner defface usually allows. However, semantic-idle-symbol-highlight-face is currently defined with defvar. The attached patch implements the fix. --089e0149c5066dc0ce04e9d37089 Content-Type: text/html; charset=ISO-8859-1
It would be more convenient to customize
semantic-idle-symbol-highlight-face in the manner defface usually
allows. However, semantic-idle-symbol-highlight-face is currently
defined with defvar.

The attached patch implements the fix.

--089e0149c5066dc0ce04e9d37089-- --089e0149c5066dc0d204e9d3708b Content-Type: application/octet-stream; name="semantic-face.diff" Content-Disposition: attachment; filename="semantic-face.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnc71u870 ZGlmZiAtLWdpdCBhL2xpc3AvY2VkZXQvQ2hhbmdlTG9nIGIvbGlzcC9jZWRldC9DaGFuZ2VMb2cK aW5kZXggNjg2MjE4MS4uMjg5MjgwYyAxMDA2NDQKLS0tIGEvbGlzcC9jZWRldC9DaGFuZ2VMb2cK KysrIGIvbGlzcC9jZWRldC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMy0xMC0yOCAg QmFycnkgTydSZWlsbHkgIDxndW5kYWV0aWFwb0BnbWFpbC5jb20+CisKKyAgICAgICAqIHNlbWFu dGljL2lkbGUuZWwgKHNlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdodC1mYWNlKTogRGVmaW5l CisgICAgICAgZmFjZSB1c2luZyBkZWZmYWNlIGluc3RlYWQgb2YgZGVmdmFyLgorICAgICAgIChz ZW1hbnRpYy1pZGxlLXN5bWJvbC1tYXliZS1oaWdobGlnaHQpCisgICAgICAgKHNlbWFudGljLWlk bGUtbG9jYWwtc3ltYm9sLWhpZ2hsaWdodCk6IFBhc3MgZmFjZSBhcyBzeW1ib2wKKyAgICAgICAq IHB1bHNlLmVsIChwdWxzZS1tb21lbnRhcnktaGlnaGxpZ2h0LW92ZXJsYXkpCisgICAgICAgKHB1 bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtcmVnaW9uKTogRml4IHR5cG8gaW4gZG9jCisKIDIwMTMt MTAtMjAgIEpvaGFuIEJvY2tnw6VyZCAgPGJvam9oYW5AZ251Lm9yZz4KIAogICAgICAgICogc2Vt YW50aWMvZGItbW9kZS5lbCAoZ2xvYmFsLXNlbWFudGljZGItbWlub3ItbW9kZSk6IFJlbW92ZSBo b29rcwpkaWZmIC0tZ2l0IGEvbGlzcC9jZWRldC9wdWxzZS5lbCBiL2xpc3AvY2VkZXQvcHVsc2Uu ZWwKaW5kZXggMjY4YmVlZC4uNGEzYjUwMSAxMDA2NDQKLS0tIGEvbGlzcC9jZWRldC9wdWxzZS5l bAorKysgYi9saXNwL2NlZGV0L3B1bHNlLmVsCkBAIC0xODAsNyArMTgwLDcgQEAgQmUgc3VyZSB0 byBjYWxsIGBwdWxzZS1yZXNldC1mYWNlJyBhZnRlciBjYWxsaW5nIHB1bHNlLiIKIAogKGRlZnVu IHB1bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtb3ZlcmxheSAobyAmb3B0aW9uYWwgZmFjZSkKICAg IlB1bHNlIHRoZSBvdmVybGF5IE8sIHVuaGlnaGxpZ2h0aW5nIGJlZm9yZSBuZXh0IGNvbW1hbmQu Ci1PcHRpb25hbCBhcmd1bWVudCBGQUNFIHNwZWNpZmllcyB0aGUgZmFjdCB0byBkbyB0aGUgaGln aGxpZ2h0aW5nLiIKK09wdGlvbmFsIGFyZ3VtZW50IEZBQ0Ugc3BlY2lmaWVzIHRoZSBmYWNlIHRv IGRvIHRoZSBoaWdobGlnaHRpbmcuIgogICAob3ZlcmxheS1wdXQgbyAnb3JpZ2luYWwtZmFjZSAo b3ZlcmxheS1nZXQgbyAnZmFjZSkpCiAgIChhZGQtdG8tbGlzdCAncHVsc2UtbW9tZW50YXJ5LW92 ZXJsYXkgbykKICAgKGlmIChlcSBwdWxzZS1mbGFnICduZXZlcikKQEAgLTIzNyw3ICsyMzcsNyBA QCBPcHRpb25hbCBhcmd1bWVudCBGQUNFIHNwZWNpZmllcyB0aGUgZmFjZSB0byBkbyB0aGUgaGln aGxpZ2h0aW5nLiIKIAogKGRlZnVuIHB1bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtcmVnaW9uIChz dGFydCBlbmQgJm9wdGlvbmFsIGZhY2UpCiAgICJIaWdobGlnaHQgYmV0d2VlbiBTVEFSVCBhbmQg RU5ELCB1bmhpZ2hsaWdodGluZyBiZWZvcmUgbmV4dCBjb21tYW5kLgotT3B0aW9uYWwgYXJndW1l bnQgRkFDRSBzcGVjaWZpZXMgdGhlIGZhY3QgdG8gZG8gdGhlIGhpZ2hsaWdodGluZy4iCitPcHRp b25hbCBhcmd1bWVudCBGQUNFIHNwZWNpZmllcyB0aGUgZmFjZSB0byBkbyB0aGUgaGlnaGxpZ2h0 aW5nLiIKICAgKGxldCAoKG8gKG1ha2Utb3ZlcmxheSBzdGFydCBlbmQpKSkKICAgICA7OyBNYXJr IGl0IGZvciBkZWxldGlvbgogICAgIChvdmVybGF5LXB1dCBvICdwdWxzZS1kZWxldGUgdCkKZGlm ZiAtLWdpdCBhL2xpc3AvY2VkZXQvc2VtYW50aWMvaWRsZS5lbCBiL2xpc3AvY2VkZXQvc2VtYW50 aWMvaWRsZS5lbAppbmRleCBkMDI0ZTVkLi4yMjEyOTJhIDEwMDY0NAotLS0gYS9saXNwL2NlZGV0 L3NlbWFudGljL2lkbGUuZWwKKysrIGIvbGlzcC9jZWRldC9zZW1hbnRpYy9pZGxlLmVsCkBAIC04 MzAsOCArODMwLDE0IEBAIHR1cm5lZCBvbiBpbiBldmVyeSBTZW1hbnRpYy1zdXBwb3J0ZWQgYnVm ZmVyLiIKIDs7IG9mIGFsbCB1c2VzIG9mIHRoZSBzeW1ib2wgdGhhdCBpcyB1bmRlciB0aGUgY3Vy c29yLgogOzsKIDs7IFRoaXMgaXMgdG8gbWltaWMgdGhlIEVjbGlwc2UgdG9vbCBvZiBhIHNpbWls YXIgbmF0dXJlLgotKGRlZnZhciBzZW1hbnRpYy1pZGxlLXN5bWJvbC1oaWdobGlnaHQtZmFjZSAn cmVnaW9uCi0gICJGYWNlIHVzZWQgZm9yIGhpZ2hsaWdodGluZyBsb2NhbCBzeW1ib2xzLiIpCiso ZGVmZmFjZSBzZW1hbnRpYy1pZGxlLXN5bWJvbC1oaWdobGlnaHQtZmFjZQorICAnKCgoKGNsYXNz IGNvbG9yKSAoYmFja2dyb3VuZCBkYXJrKSkKKyAgICAgOzsgUHV0IHRoaXMgYmFjayB0byBzb21l dGhpbmcgY2xvc2VyIHRvIGJsYWNrIGxhdGVyLgorICAgICAoOmJhY2tncm91bmQgImdyYXkyMCIp KQorICAgICgoKGNsYXNzIGNvbG9yKSAoYmFja2dyb3VuZCBsaWdodCkpCisgICAgICg6YmFja2dy b3VuZCAiZ3JheTkwIikpKQorICAiRmFjZSB1c2VkIGZvciBoaWdobGlnaHRpbmcgbG9jYWwgc3lt Ym9scy4iCisgIDpncm91cCAnc2VtYW50aWMtZmFjZXMpCiAKIChkZWZ1biBzZW1hbnRpYy1pZGxl LXN5bWJvbC1tYXliZS1oaWdobGlnaHQgKHRhZykKICAgIlBlcmhhcHMgYWRkIGhpZ2hsaWdodGlu ZyB0byB0aGUgc3ltYm9sIHJlcHJlc2VudGVkIGJ5IFRBRy4KQEAgLTg1NywxMiArODYzLDEyIEBA IHZpc2libGUsIHRoZW4gaGlnaGxpZ2h0IGl0LiIKIAkJICAgICAgKHBvaW50KSAoZ2V0LWJ1ZmZl ci13aW5kb3cgKGN1cnJlbnQtYnVmZmVyKSAndmlzaWJsZSkpCiAJCSAoaWYgKDwgKHNlbWFudGlj LW92ZXJsYXktZW5kIHJlZ2lvbikgKHBvaW50LWF0LWVvbCkpCiAJCSAgICAgKHB1bHNlLW1vbWVu dGFyeS1oaWdobGlnaHQtb3ZlcmxheQotCQkgICAgICByZWdpb24gc2VtYW50aWMtaWRsZS1zeW1i b2wtaGlnaGxpZ2h0LWZhY2UpCisJCSAgICAgIHJlZ2lvbiAnc2VtYW50aWMtaWRsZS1zeW1ib2wt aGlnaGxpZ2h0LWZhY2UpCiAJCSAgIDs7IE5vdCB0aGUgc2FtZQogCQkgICAocHVsc2UtbW9tZW50 YXJ5LWhpZ2hsaWdodC1yZWdpb24KIAkJICAgIChzZW1hbnRpYy1vdmVybGF5LXN0YXJ0IHJlZ2lv bikKIAkJICAgIChwb2ludC1hdC1lb2wpCi0JCSAgICBzZW1hbnRpYy1pZGxlLXN5bWJvbC1oaWdo bGlnaHQtZmFjZSkpKSkKKwkJICAgICdzZW1hbnRpYy1pZGxlLXN5bWJvbC1oaWdobGlnaHQtZmFj ZSkpKSkKIAkgICAgICkpCiAJICAoKHZlY3RvcnAgcmVnaW9uKQogCSAgIChsZXQgKChzdGFydCAo YXJlZiByZWdpb24gMCkpCkBAIC04ODIsNyArODg4LDcgQEAgdmlzaWJsZSwgdGhlbiBoaWdobGln aHQgaXQuIgogCQkgICAocHVsc2UtbW9tZW50YXJ5LWhpZ2hsaWdodC1yZWdpb24KIAkJICAgIHN0 YXJ0IChpZiAoPD0gZW5kIChwb2ludC1hdC1lb2wpKSBlbmQKIAkJCSAgICAocG9pbnQtYXQtZW9s KSkKLQkJICAgIHNlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdodC1mYWNlKSkpCisJCSAgICAn c2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZhY2UpKSkKIAkgICAgICAgKSkpKQogICAg IG5pbCkpCiAKQEAgLTkxMyw3ICs5MTksNyBAQCBDYWxsIGBzZW1hbnRpYy1zeW1yZWYtaGl0cy1p bi1yZWdpb24nIHRvIGlkZW50aWZ5IGxvY2FsIHJlZmVyZW5jZXMuIgogCSAgIHRhcmdldCAobGFt YmRhIChzdGFydCBlbmQgcHJlZml4KQogCQkgICAgKHdoZW4gKC89IHN0YXJ0IChjYXIgSGJvdW5k cykpCiAJCSAgICAgIChwdWxzZS1tb21lbnRhcnktaGlnaGxpZ2h0LXJlZ2lvbgotCQkgICAgICAg c3RhcnQgZW5kIHNlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdodC1mYWNlKSkKKwkJICAgICAg IHN0YXJ0IGVuZCAnc2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZhY2UpKQogCQkgICAg KHNlbWFudGljLXRocm93LW9uLWlucHV0ICdzeW1yZWYtaGlnaGxpZ2h0KQogCQkgICAgKQogCSAg IChzZW1hbnRpYy10YWctc3RhcnQgdGFnKQpkaWZmIC0tZ2l0IGEvc3JjL2V2YWwuYyBiL3NyYy9l dmFsLmMKaW5kZXggMWUwYTYzYS4uNDI1OGI2OCAxMDA2NDQK --089e0149c5066dc0d204e9d3708b-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 17:38:51 2013 Received: (at 15745) by debbugs.gnu.org; 28 Oct 2013 21:38:51 +0000 Received: from localhost ([127.0.0.1]:49937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VauWQ-0005ef-TT for submit@debbugs.gnu.org; Mon, 28 Oct 2013 17:38:51 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:53352 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VauWP-0005eX-1i for 15745@debbugs.gnu.org; Mon, 28 Oct 2013 17:38:49 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VauWN-0005uf-Ex; Mon, 28 Oct 2013 17:38:47 -0400 From: Glenn Morris To: Barry OReilly Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface References: X-Spook: Bush Wired 22nd SAS Saddam Hussein NASA AK-47 IRA Consul X-Ran: ,dLz=1~j>q4S.{|D?vy|]x:>/_2$fpum=#WO-r.}B_qsb>xooNp\FE`o#W3M1Nv@10k~=f X-Hue: white X-Attribution: GM Date: Mon, 28 Oct 2013 17:38:47 -0400 Message-ID: <5htxg1jct4.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15745 Cc: 15745@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) New face names should not end in -face. The standard backwards-compatible way to make a change like this is: 1) Add: (defface semantic-idle-symbol-highlight ...) 2) Change: (defvar semantic-idle-symbol-highlight-face 'semantic-idle-symbol-highlight) 3) Mark semantic-idle-symbol-highlight-face the variable obsolete, in favour of semantic-idle-symbol-highlight the face. See eg diary-face. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 18:36:59 2013 Received: (at 15745) by debbugs.gnu.org; 28 Oct 2013 22:36:59 +0000 Received: from localhost ([127.0.0.1]:50037 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VavQh-00088u-5a for submit@debbugs.gnu.org; Mon, 28 Oct 2013 18:36:59 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:55444) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VavQf-00088g-BS for 15745@debbugs.gnu.org; Mon, 28 Oct 2013 18:36:57 -0400 Received: by mail-ob0-f180.google.com with SMTP id wo20so4420519obc.11 for <15745@debbugs.gnu.org>; Mon, 28 Oct 2013 15:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=1wQ5ZNvo5f4sa0okHSK7HxDzA/dKOJ4O/DJlpC98tT4=; b=k/z31EmLYKDaQSdmfAsk49Lj3mq17933VHA1+VKCYdkNGKpE3KZYxn3kQEdKtf/24y g/H/HtWRNv493vSmj6eJCvpBSNx9B09cvZBPTAjyzXlXFTnzrgPcrtfjLGGfU3ZY+/c7 Lu1k8t1a8Ks4MCH1VN9mhhrgDW0ufJeiYdoGYv+aj0F9a8XEIE3xbcORXhYf8t4tujPM D47h0x6qTwvyKXQhdTG8ETm2RJRlujWP9ZAaZsYprC8EWb/nCh6IFMuyvfHuWToqdUy/ 2vbdzauN7vmDBfbKWRvdSBq9NzLpS/BDPz3XgWxRh7Ne5jQOWfNla7RICClWB5hkcgWM R3vQ== MIME-Version: 1.0 X-Received: by 10.60.42.203 with SMTP id q11mr3367398oel.54.1382999811304; Mon, 28 Oct 2013 15:36:51 -0700 (PDT) Received: by 10.76.156.103 with HTTP; Mon, 28 Oct 2013 15:36:51 -0700 (PDT) In-Reply-To: <5htxg1jct4.fsf@fencepost.gnu.org> References: <5htxg1jct4.fsf@fencepost.gnu.org> Date: Mon, 28 Oct 2013 18:36:51 -0400 Message-ID: Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface From: Barry OReilly To: Glenn Morris Content-Type: multipart/mixed; boundary=001a11c207f07a8f3904e9d4bc2c X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15745 Cc: 15745@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a11c207f07a8f3904e9d4bc2c Content-Type: multipart/alternative; boundary=001a11c207f07a8f3604e9d4bc2a --001a11c207f07a8f3604e9d4bc2a Content-Type: text/plain; charset=ISO-8859-1 Thanks, how is the attached revised patch? --001a11c207f07a8f3604e9d4bc2a Content-Type: text/html; charset=ISO-8859-1
Thanks, how is the attached revised patch?

--001a11c207f07a8f3604e9d4bc2a-- --001a11c207f07a8f3904e9d4bc2c Content-Type: application/octet-stream; name="semantic-face.diff" Content-Disposition: attachment; filename="semantic-face.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hncacvab0 ZGlmZiAtLWdpdCBhL2xpc3AvY2VkZXQvQ2hhbmdlTG9nIGIvbGlzcC9jZWRldC9DaGFuZ2VMb2cK aW5kZXggNjg2MjE4MS4uNGUzYTU1MyAxMDA2NDQKLS0tIGEvbGlzcC9jZWRldC9DaGFuZ2VMb2cK KysrIGIvbGlzcC9jZWRldC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMy0xMC0yOCAg QmFycnkgTydSZWlsbHkgIDxndW5kYWV0aWFwb0BnbWFpbC5jb20+CisKKyAgICAgICAqIHNlbWFu dGljL2lkbGUuZWwgKHNlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdodCkKKyAgICAgICAoc2Vt YW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZhY2UpOiBEZWZpbmUgZmFjZSB3aXRoIGRlZmZh Y2UKKyAgICAgICBhbmQgb2Jzb2xldGUgdGhlIHJlcGxhY2VkIG9uZSBkZWZpbmVkIHdpdGggZGVm dmFyLgorICAgICAgIChzZW1hbnRpYy1pZGxlLXN5bWJvbC1tYXliZS1oaWdobGlnaHQpCisgICAg ICAgKHNlbWFudGljLWlkbGUtbG9jYWwtc3ltYm9sLWhpZ2hsaWdodCk6IFBhc3MgZmFjZSBhcyBz eW1ib2wKKyAgICAgICAqIHB1bHNlLmVsIChwdWxzZS1tb21lbnRhcnktaGlnaGxpZ2h0LW92ZXJs YXkpCisgICAgICAgKHB1bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtcmVnaW9uKTogRml4IHR5cG8g aW4gZG9jCisKIDIwMTMtMTAtMjAgIEpvaGFuIEJvY2tnw6VyZCAgPGJvam9oYW5AZ251Lm9yZz4K IAogICAgICAgICogc2VtYW50aWMvZGItbW9kZS5lbCAoZ2xvYmFsLXNlbWFudGljZGItbWlub3It bW9kZSk6IFJlbW92ZSBob29rcwpkaWZmIC0tZ2l0IGEvbGlzcC9jZWRldC9wdWxzZS5lbCBiL2xp c3AvY2VkZXQvcHVsc2UuZWwKaW5kZXggMjY4YmVlZC4uNGEzYjUwMSAxMDA2NDQKLS0tIGEvbGlz cC9jZWRldC9wdWxzZS5lbAorKysgYi9saXNwL2NlZGV0L3B1bHNlLmVsCkBAIC0xODAsNyArMTgw LDcgQEAgQmUgc3VyZSB0byBjYWxsIGBwdWxzZS1yZXNldC1mYWNlJyBhZnRlciBjYWxsaW5nIHB1 bHNlLiIKIAogKGRlZnVuIHB1bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtb3ZlcmxheSAobyAmb3B0 aW9uYWwgZmFjZSkKICAgIlB1bHNlIHRoZSBvdmVybGF5IE8sIHVuaGlnaGxpZ2h0aW5nIGJlZm9y ZSBuZXh0IGNvbW1hbmQuCi1PcHRpb25hbCBhcmd1bWVudCBGQUNFIHNwZWNpZmllcyB0aGUgZmFj dCB0byBkbyB0aGUgaGlnaGxpZ2h0aW5nLiIKK09wdGlvbmFsIGFyZ3VtZW50IEZBQ0Ugc3BlY2lm aWVzIHRoZSBmYWNlIHRvIGRvIHRoZSBoaWdobGlnaHRpbmcuIgogICAob3ZlcmxheS1wdXQgbyAn b3JpZ2luYWwtZmFjZSAob3ZlcmxheS1nZXQgbyAnZmFjZSkpCiAgIChhZGQtdG8tbGlzdCAncHVs c2UtbW9tZW50YXJ5LW92ZXJsYXkgbykKICAgKGlmIChlcSBwdWxzZS1mbGFnICduZXZlcikKQEAg LTIzNyw3ICsyMzcsNyBAQCBPcHRpb25hbCBhcmd1bWVudCBGQUNFIHNwZWNpZmllcyB0aGUgZmFj ZSB0byBkbyB0aGUgaGlnaGxpZ2h0aW5nLiIKIAogKGRlZnVuIHB1bHNlLW1vbWVudGFyeS1oaWdo bGlnaHQtcmVnaW9uIChzdGFydCBlbmQgJm9wdGlvbmFsIGZhY2UpCiAgICJIaWdobGlnaHQgYmV0 d2VlbiBTVEFSVCBhbmQgRU5ELCB1bmhpZ2hsaWdodGluZyBiZWZvcmUgbmV4dCBjb21tYW5kLgot T3B0aW9uYWwgYXJndW1lbnQgRkFDRSBzcGVjaWZpZXMgdGhlIGZhY3QgdG8gZG8gdGhlIGhpZ2hs aWdodGluZy4iCitPcHRpb25hbCBhcmd1bWVudCBGQUNFIHNwZWNpZmllcyB0aGUgZmFjZSB0byBk byB0aGUgaGlnaGxpZ2h0aW5nLiIKICAgKGxldCAoKG8gKG1ha2Utb3ZlcmxheSBzdGFydCBlbmQp KSkKICAgICA7OyBNYXJrIGl0IGZvciBkZWxldGlvbgogICAgIChvdmVybGF5LXB1dCBvICdwdWxz ZS1kZWxldGUgdCkKZGlmZiAtLWdpdCBhL2xpc3AvY2VkZXQvc2VtYW50aWMvaWRsZS5lbCBiL2xp c3AvY2VkZXQvc2VtYW50aWMvaWRsZS5lbAppbmRleCBkMDI0ZTVkLi40YmRlOGE1IDEwMDY0NAot LS0gYS9saXNwL2NlZGV0L3NlbWFudGljL2lkbGUuZWwKKysrIGIvbGlzcC9jZWRldC9zZW1hbnRp Yy9pZGxlLmVsCkBAIC04MzAsOCArODMwLDE5IEBAIHR1cm5lZCBvbiBpbiBldmVyeSBTZW1hbnRp Yy1zdXBwb3J0ZWQgYnVmZmVyLiIKIDs7IG9mIGFsbCB1c2VzIG9mIHRoZSBzeW1ib2wgdGhhdCBp cyB1bmRlciB0aGUgY3Vyc29yLgogOzsKIDs7IFRoaXMgaXMgdG8gbWltaWMgdGhlIEVjbGlwc2Ug dG9vbCBvZiBhIHNpbWlsYXIgbmF0dXJlLgotKGRlZnZhciBzZW1hbnRpYy1pZGxlLXN5bWJvbC1o aWdobGlnaHQtZmFjZSAncmVnaW9uCi0gICJGYWNlIHVzZWQgZm9yIGhpZ2hsaWdodGluZyBsb2Nh bCBzeW1ib2xzLiIpCisoZGVmZmFjZSBzZW1hbnRpYy1pZGxlLXN5bWJvbC1oaWdobGlnaHQKKyAg JygoKChjbGFzcyBjb2xvcikgKGJhY2tncm91bmQgZGFyaykpCisgICAgIDs7IFB1dCB0aGlzIGJh Y2sgdG8gc29tZXRoaW5nIGNsb3NlciB0byBibGFjayBsYXRlci4KKyAgICAgKDpiYWNrZ3JvdW5k ICJncmF5MjAiKSkKKyAgICAoKChjbGFzcyBjb2xvcikgKGJhY2tncm91bmQgbGlnaHQpKQorICAg ICAoOmJhY2tncm91bmQgImdyYXk5MCIpKSkKKyAgIkZhY2UgdXNlZCBmb3IgaGlnaGxpZ2h0aW5n IGxvY2FsIHN5bWJvbHMuIgorICA6Z3JvdXAgJ3NlbWFudGljLWZhY2VzKQorKGRlZnZhciBzZW1h bnRpYy1pZGxlLXN5bWJvbC1oaWdobGlnaHQtZmFjZSAnc2VtYW50aWMtaWRsZS1zeW1ib2wtaGln aGxpZ2h0KQorKGRlZmluZS1vYnNvbGV0ZS1mYWNlLWFsaWFzCisgICdzZW1hbnRpYy1pZGxlLXN5 bWJvbC1oaWdobGlnaHQtZmFjZQorICAnc2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0Cisg ICIyNC40IikKIAogKGRlZnVuIHNlbWFudGljLWlkbGUtc3ltYm9sLW1heWJlLWhpZ2hsaWdodCAo dGFnKQogICAiUGVyaGFwcyBhZGQgaGlnaGxpZ2h0aW5nIHRvIHRoZSBzeW1ib2wgcmVwcmVzZW50 ZWQgYnkgVEFHLgpAQCAtODU3LDEyICs4NjgsMTIgQEAgdmlzaWJsZSwgdGhlbiBoaWdobGlnaHQg aXQuIgogICAgICAgICAgICAgICAgICAgICAgKHBvaW50KSAoZ2V0LWJ1ZmZlci13aW5kb3cgKGN1 cnJlbnQtYnVmZmVyKSAndmlzaWJsZSkpCiAgICAgICAgICAgICAgICAgKGlmICg8IChzZW1hbnRp Yy1vdmVybGF5LWVuZCByZWdpb24pIChwb2ludC1hdC1lb2wpKQogICAgICAgICAgICAgICAgICAg ICAocHVsc2UtbW9tZW50YXJ5LWhpZ2hsaWdodC1vdmVybGF5Ci0gICAgICAgICAgICAgICAgICAg ICByZWdpb24gc2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZhY2UpCisgICAgICAgICAg ICAgICAgICAgICByZWdpb24gJ3NlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdodCkKICAgICAg ICAgICAgICAgICAgIDs7IE5vdCB0aGUgc2FtZQogICAgICAgICAgICAgICAgICAgKHB1bHNlLW1v bWVudGFyeS1oaWdobGlnaHQtcmVnaW9uCiAgICAgICAgICAgICAgICAgICAgKHNlbWFudGljLW92 ZXJsYXktc3RhcnQgcmVnaW9uKQogICAgICAgICAgICAgICAgICAgIChwb2ludC1hdC1lb2wpCi0g ICAgICAgICAgICAgICAgICAgc2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZhY2UpKSkp CisgICAgICAgICAgICAgICAgICAgJ3NlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdodCkpKSkK ICAgICAgICAgICAgICkpCiAgICAgICAgICAoKHZlY3RvcnAgcmVnaW9uKQogICAgICAgICAgIChs ZXQgKChzdGFydCAoYXJlZiByZWdpb24gMCkpCkBAIC04ODIsNyArODkzLDcgQEAgdmlzaWJsZSwg dGhlbiBoaWdobGlnaHQgaXQuIgogICAgICAgICAgICAgICAgICAgKHB1bHNlLW1vbWVudGFyeS1o aWdobGlnaHQtcmVnaW9uCiAgICAgICAgICAgICAgICAgICAgc3RhcnQgKGlmICg8PSBlbmQgKHBv aW50LWF0LWVvbCkpIGVuZAogICAgICAgICAgICAgICAgICAgICAgICAgICAgKHBvaW50LWF0LWVv bCkpCi0gICAgICAgICAgICAgICAgICAgc2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZh Y2UpKSkKKyAgICAgICAgICAgICAgICAgICAnc2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0 KSkpCiAgICAgICAgICAgICAgICkpKSkKICAgICBuaWwpKQogCkBAIC05MTMsNyArOTI0LDcgQEAg Q2FsbCBgc2VtYW50aWMtc3ltcmVmLWhpdHMtaW4tcmVnaW9uJyB0byBpZGVudGlmeSBsb2NhbCBy ZWZlcmVuY2VzLiIKICAgICAgICAgICB0YXJnZXQgKGxhbWJkYSAoc3RhcnQgZW5kIHByZWZpeCkK ICAgICAgICAgICAgICAgICAgICAod2hlbiAoLz0gc3RhcnQgKGNhciBIYm91bmRzKSkKICAgICAg ICAgICAgICAgICAgICAgIChwdWxzZS1tb21lbnRhcnktaGlnaGxpZ2h0LXJlZ2lvbgotICAgICAg ICAgICAgICAgICAgICAgIHN0YXJ0IGVuZCBzZW1hbnRpYy1pZGxlLXN5bWJvbC1oaWdobGlnaHQt ZmFjZSkpCisgICAgICAgICAgICAgICAgICAgICAgc3RhcnQgZW5kICdzZW1hbnRpYy1pZGxlLXN5 bWJvbC1oaWdobGlnaHQpKQogICAgICAgICAgICAgICAgICAgIChzZW1hbnRpYy10aHJvdy1vbi1p bnB1dCAnc3ltcmVmLWhpZ2hsaWdodCkKICAgICAgICAgICAgICAgICAgICApCiAgICAgICAgICAg KHNlbWFudGljLXRhZy1zdGFydCB0YWcpCg== --001a11c207f07a8f3904e9d4bc2c-- From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 21:38:48 2013 Received: (at 15745) by debbugs.gnu.org; 29 Oct 2013 01:38:49 +0000 Received: from localhost ([127.0.0.1]:50267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VayGe-0006GS-J5 for submit@debbugs.gnu.org; Mon, 28 Oct 2013 21:38:48 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:29606) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VayGd-0006GG-Gh for 15745@debbugs.gnu.org; Mon, 28 Oct 2013 21:38:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFsoXfp/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCTBLZEKA6R6gV6DEw X-IPAS-Result: Av4EABK/CFFsoXfp/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCTBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="36558604" Received: from 108-161-119-233.dsl.teksavvy.com (HELO pastel.home) ([108.161.119.233]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 28 Oct 2013 21:38:41 -0400 Received: by pastel.home (Postfix, from userid 20848) id 9F86D60020; Mon, 28 Oct 2013 21:38:41 -0400 (EDT) From: Stefan Monnier To: Barry OReilly Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface Message-ID: References: Date: Mon, 28 Oct 2013 21:38:41 -0400 In-Reply-To: (Barry OReilly's message of "Mon, 28 Oct 2013 17:04:00 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15745 Cc: 15745@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > -(defvar semantic-idle-symbol-highlight-face 'region > - "Face used for highlighting local symbols.") > +(defface semantic-idle-symbol-highlight-face > + '((((class color) (background dark)) > + ;; Put this back to something closer to black later. > + (:background "gray20")) > + (((class color) (background light)) > + (:background "gray90"))) > + "Face used for highlighting local symbols." > + :group 'semantic-faces) Just define the new face to inherit from `region', so as to preserve the old behavior: (defface semantic-idle-symbol-highlight '((t :inherit region)) "Face used for highlighting local symbols.") Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 28 22:30:00 2013 Received: (at 15745) by debbugs.gnu.org; 29 Oct 2013 02:30:01 +0000 Received: from localhost ([127.0.0.1]:50321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vaz4C-0007Um-C4 for submit@debbugs.gnu.org; Mon, 28 Oct 2013 22:30:00 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56909 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vaz4A-0007Uf-LA for 15745@debbugs.gnu.org; Mon, 28 Oct 2013 22:29:59 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vaz49-0004rS-Cj; Mon, 28 Oct 2013 22:29:57 -0400 From: Glenn Morris To: Barry OReilly Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface References: <5htxg1jct4.fsf@fencepost.gnu.org> X-Spook: 9/11 counter intelligence electronic surveillance brigand X-Ran: 1c[.lZc}}9'Y"NQ:Zz\JsCV^pVV;o}S$7E(=sR"~)he7mwOOyYd|W%`KZI9uuHj,mg]-5m X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 28 Oct 2013 22:29:57 -0400 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15745 Cc: 15745@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) Barry OReilly wrote: > Thanks, how is the attached revised patch? Not quite what I had in mind (taking something that was a variable and turning it into a face alias won't work right, will it?). -(defvar semantic-idle-symbol-highlight-face 'region - "Face used for highlighting local symbols.") +(defface semantic-idle-symbol-highlight + '((((class color) (background dark)) + ;; Put this back to something closer to black later. + (:background "gray20")) + (((class color) (background light)) + (:background "gray90"))) + "Face used for highlighting local symbols." + :group 'semantic-faces) As has been said: (defface semantic-idle-symbol-highlight '((t (:inherit region))) ...) +(define-obsolete-face-alias + 'semantic-idle-symbol-highlight-face + 'semantic-idle-symbol-highlight + "24.4") Rather than the above, I meant: (make-obsolete-variable 'semantic-idle-symbol-highlight-face "customize the face `semantic-idle-symbol-highlight' instead" "24.4" 'set) Then these bits: - region semantic-idle-symbol-highlight-face) + region 'semantic-idle-symbol-highlight) are not necessary (or appropriate). From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 29 11:57:01 2013 Received: (at 15745) by debbugs.gnu.org; 29 Oct 2013 15:57:01 +0000 Received: from localhost ([127.0.0.1]:51349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbBfA-0003qo-EQ for submit@debbugs.gnu.org; Tue, 29 Oct 2013 11:57:00 -0400 Received: from mail-oa0-f45.google.com ([209.85.219.45]:37128) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbBf8-0003qb-9s for 15745@debbugs.gnu.org; Tue, 29 Oct 2013 11:56:58 -0400 Received: by mail-oa0-f45.google.com with SMTP id i4so56969oah.18 for <15745@debbugs.gnu.org>; Tue, 29 Oct 2013 08:56:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HiFFkTTi8LMCt010jnTZuIIkl5XVzzdveyoJuvotWQ0=; b=k1UhYTjq5HkJXh4IPbmhklStyfPlkD+OWBTRT/HarU5LISm1emoOJiAFSOHAbw5rb2 3GKNl9sFWoIziX9e4Y1TIw7hL5Qer+FiuNSmxiIYiKSrp3qqVoQZQ5eCCliIn0EhdOyD c6Dzh1/NbJC97UPN9vArqwq/P18rUR53SFejpOVfob8EDI2TY4jytXFNctzeg6I3P5K7 V+v3adcpX00s54c1oExzSo2TlHM6w5a6aZu8eiPLGmJgZqyRwfWB0l71wcCIeh/Yt14z KfVNpMEk76YRvYhG3ocBB2opDRWAJ1cw3AS1I/y4q0sv738DuV0P1DqXNHGsd9Rpw9T1 182w== MIME-Version: 1.0 X-Received: by 10.182.144.136 with SMTP id sm8mr117962obb.63.1383062212159; Tue, 29 Oct 2013 08:56:52 -0700 (PDT) Received: by 10.76.156.103 with HTTP; Tue, 29 Oct 2013 08:56:51 -0700 (PDT) In-Reply-To: References: <5htxg1jct4.fsf@fencepost.gnu.org> Date: Tue, 29 Oct 2013 11:56:51 -0400 Message-ID: Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface From: Barry OReilly To: Glenn Morris Content-Type: multipart/mixed; boundary=089e0149cd5eddc44d04e9e3433f X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15745 Cc: 15745@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e0149cd5eddc44d04e9e3433f Content-Type: multipart/alternative; boundary=089e0149cd5eddc44a04e9e3433d --089e0149cd5eddc44a04e9e3433d Content-Type: text/plain; charset=ISO-8859-1 Thank you for your patience and guidance. > Just define the new face to inherit from `region', so as to preserve > the old behavior: > > (defface semantic-idle-symbol-highlight > '((t :inherit region)) > "Face used for highlighting local symbols.") It's weird that the region face would be used for this, because it has nothing to do with the region. The fact that it can make me think I have a region marked when I don't is a motivator for this bug report. My primary concern is that I can customize it personally, so I revised the patch to have the face inherit region. > Not quite what I had in mind (taking something that was a variable > and turning it into a face alias won't work right, will it?). I probably misinterpreted your earlier tip. I looked off of diary-face: (define-obsolete-face-alias 'diary-face 'diary "22.1") I tested the last patch before sending it and it worked. Although that patch used the defface variable and not the obsoleted one. > Then these bits: > > - region semantic-idle-symbol-highlight-face) > + region 'semantic-idle-symbol-highlight) > > are not necessary (or appropriate). I don't know why using obsolete variables is most appropriate, but I've done as requested in the revised attached patch. --089e0149cd5eddc44a04e9e3433d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thank you for your patience and guidance.

> Just= define the new face to inherit from `region', so as to preserve
>= ; the old behavior:
>
> (defface semantic-idle-symbol-highligh= t
>=A0=A0 '((t :inherit region))
>=A0=A0 "Face used for hig= hlighting local symbols.")

It's weird that the region face = would be used for this, because it has
nothing to do with the region. Th= e fact that it can make me think I
have a region marked when I don't is a motivator for this bug report.My primary concern is that I can customize it personally, so I revisedthe patch to have the face inherit region.

> Not quite what I ha= d in mind (taking something that was a variable
> and turning it into a face alias won't work right, will it?).
<= br>I probably misinterpreted your earlier tip. I looked off of
diary-fac= e:

=A0 (define-obsolete-face-alias 'diary-face 'diary "= 22.1")

I tested the last patch before sending it and it worked. Although that<= br>patch used the defface variable and not the obsoleted one.

> T= hen these bits:
>
> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 region semantic-idle-symbol-highlight-face)
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 region &= #39;semantic-idle-symbol-highlight)
>
> are not necessary (or = appropriate).

I don't know why using obsolete variables is most = appropriate, but
I've done as requested in the revised attached patc= h.

--089e0149cd5eddc44a04e9e3433d-- --089e0149cd5eddc44d04e9e3433f Content-Type: application/octet-stream; name="semantic-face.diff" Content-Disposition: attachment; filename="semantic-face.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hndbfykj0 ZGlmZiAtLWdpdCBhL2xpc3AvY2VkZXQvQ2hhbmdlTG9nIGIvbGlzcC9jZWRldC9DaGFuZ2VMb2cK aW5kZXggNjg2MjE4MS4uNjVmNzMzMCAxMDA2NDQKLS0tIGEvbGlzcC9jZWRldC9DaGFuZ2VMb2cK KysrIGIvbGlzcC9jZWRldC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAxMy0xMC0yOCAg QmFycnkgTydSZWlsbHkgIDxndW5kYWV0aWFwb0BnbWFpbC5jb20+CisKKyAgICAgICAqIHNlbWFu dGljL2lkbGUuZWwgKHNlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdodCkKKyAgICAgICAoc2Vt YW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZhY2UpOiBEZWZpbmUgZmFjZSB3aXRoIGRlZmZh Y2UKKyAgICAgICBhbmQgb2Jzb2xldGUgdGhlIHJlcGxhY2VkIG9uZSBkZWZpbmVkIHdpdGggZGVm dmFyLgorICAgICAgICogcHVsc2UuZWwgKHB1bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtb3Zlcmxh eSkKKyAgICAgICAocHVsc2UtbW9tZW50YXJ5LWhpZ2hsaWdodC1yZWdpb24pOiBGaXggdHlwbyBp biBkb2MKKwogMjAxMy0xMC0yMCAgSm9oYW4gQm9ja2fDpXJkICA8Ym9qb2hhbkBnbnUub3JnPgog CiAgICAgICAgKiBzZW1hbnRpYy9kYi1tb2RlLmVsIChnbG9iYWwtc2VtYW50aWNkYi1taW5vci1t b2RlKTogUmVtb3ZlIGhvb2tzCmRpZmYgLS1naXQgYS9saXNwL2NlZGV0L3B1bHNlLmVsIGIvbGlz cC9jZWRldC9wdWxzZS5lbAppbmRleCAyNjhiZWVkLi40YTNiNTAxIDEwMDY0NAotLS0gYS9saXNw L2NlZGV0L3B1bHNlLmVsCisrKyBiL2xpc3AvY2VkZXQvcHVsc2UuZWwKQEAgLTE4MCw3ICsxODAs NyBAQCBCZSBzdXJlIHRvIGNhbGwgYHB1bHNlLXJlc2V0LWZhY2UnIGFmdGVyIGNhbGxpbmcgcHVs c2UuIgogCiAoZGVmdW4gcHVsc2UtbW9tZW50YXJ5LWhpZ2hsaWdodC1vdmVybGF5IChvICZvcHRp b25hbCBmYWNlKQogICAiUHVsc2UgdGhlIG92ZXJsYXkgTywgdW5oaWdobGlnaHRpbmcgYmVmb3Jl IG5leHQgY29tbWFuZC4KLU9wdGlvbmFsIGFyZ3VtZW50IEZBQ0Ugc3BlY2lmaWVzIHRoZSBmYWN0 IHRvIGRvIHRoZSBoaWdobGlnaHRpbmcuIgorT3B0aW9uYWwgYXJndW1lbnQgRkFDRSBzcGVjaWZp ZXMgdGhlIGZhY2UgdG8gZG8gdGhlIGhpZ2hsaWdodGluZy4iCiAgIChvdmVybGF5LXB1dCBvICdv cmlnaW5hbC1mYWNlIChvdmVybGF5LWdldCBvICdmYWNlKSkKICAgKGFkZC10by1saXN0ICdwdWxz ZS1tb21lbnRhcnktb3ZlcmxheSBvKQogICAoaWYgKGVxIHB1bHNlLWZsYWcgJ25ldmVyKQpAQCAt MjM3LDcgKzIzNyw3IEBAIE9wdGlvbmFsIGFyZ3VtZW50IEZBQ0Ugc3BlY2lmaWVzIHRoZSBmYWNl IHRvIGRvIHRoZSBoaWdobGlnaHRpbmcuIgogCiAoZGVmdW4gcHVsc2UtbW9tZW50YXJ5LWhpZ2hs aWdodC1yZWdpb24gKHN0YXJ0IGVuZCAmb3B0aW9uYWwgZmFjZSkKICAgIkhpZ2hsaWdodCBiZXR3 ZWVuIFNUQVJUIGFuZCBFTkQsIHVuaGlnaGxpZ2h0aW5nIGJlZm9yZSBuZXh0IGNvbW1hbmQuCi1P cHRpb25hbCBhcmd1bWVudCBGQUNFIHNwZWNpZmllcyB0aGUgZmFjdCB0byBkbyB0aGUgaGlnaGxp Z2h0aW5nLiIKK09wdGlvbmFsIGFyZ3VtZW50IEZBQ0Ugc3BlY2lmaWVzIHRoZSBmYWNlIHRvIGRv IHRoZSBoaWdobGlnaHRpbmcuIgogICAobGV0ICgobyAobWFrZS1vdmVybGF5IHN0YXJ0IGVuZCkp KQogICAgIDs7IE1hcmsgaXQgZm9yIGRlbGV0aW9uCiAgICAgKG92ZXJsYXktcHV0IG8gJ3B1bHNl LWRlbGV0ZSB0KQpkaWZmIC0tZ2l0IGEvbGlzcC9jZWRldC9zZW1hbnRpYy9pZGxlLmVsIGIvbGlz cC9jZWRldC9zZW1hbnRpYy9pZGxlLmVsCmluZGV4IGQwMjRlNWQuLmMxNWI2YmYgMTAwNjQ0Ci0t LSBhL2xpc3AvY2VkZXQvc2VtYW50aWMvaWRsZS5lbAorKysgYi9saXNwL2NlZGV0L3NlbWFudGlj L2lkbGUuZWwKQEAgLTgzMCw4ICs4MzAsMTQgQEAgdHVybmVkIG9uIGluIGV2ZXJ5IFNlbWFudGlj LXN1cHBvcnRlZCBidWZmZXIuIgogOzsgb2YgYWxsIHVzZXMgb2YgdGhlIHN5bWJvbCB0aGF0IGlz IHVuZGVyIHRoZSBjdXJzb3IuCiA7OwogOzsgVGhpcyBpcyB0byBtaW1pYyB0aGUgRWNsaXBzZSB0 b29sIG9mIGEgc2ltaWxhciBuYXR1cmUuCi0oZGVmdmFyIHNlbWFudGljLWlkbGUtc3ltYm9sLWhp Z2hsaWdodC1mYWNlICdyZWdpb24KKyhkZWZmYWNlIHNlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hs aWdodAorICAnKCh0IDppbmhlcml0IHJlZ2lvbikpCisgICJGYWNlIHVzZWQgZm9yIGhpZ2hsaWdo dGluZyBsb2NhbCBzeW1ib2xzLiIKKyAgOmdyb3VwICdzZW1hbnRpYy1mYWNlcykKKyhkZWZ2YXIg c2VtYW50aWMtaWRsZS1zeW1ib2wtaGlnaGxpZ2h0LWZhY2UgJ3NlbWFudGljLWlkbGUtc3ltYm9s LWhpZ2hsaWdodAogICAiRmFjZSB1c2VkIGZvciBoaWdobGlnaHRpbmcgbG9jYWwgc3ltYm9scy4i KQorKG1ha2Utb2Jzb2xldGUtdmFyaWFibGUgJ3NlbWFudGljLWlkbGUtc3ltYm9sLWhpZ2hsaWdo dC1mYWNlCisgICAgImN1c3RvbWl6ZSB0aGUgZmFjZSBgc2VtYW50aWMtaWRsZS1zeW1ib2wtaGln aGxpZ2h0JyBpbnN0ZWFkIiAiMjQuNCIgJ3NldCkKIAogKGRlZnVuIHNlbWFudGljLWlkbGUtc3lt Ym9sLW1heWJlLWhpZ2hsaWdodCAodGFnKQogICAiUGVyaGFwcyBhZGQgaGlnaGxpZ2h0aW5nIHRv IHRoZSBzeW1ib2wgcmVwcmVzZW50ZWQgYnkgVEFHLgo= --089e0149cd5eddc44d04e9e3433f-- From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 29 18:37:56 2013 Received: (at 15745) by debbugs.gnu.org; 29 Oct 2013 22:37:56 +0000 Received: from localhost ([127.0.0.1]:51610 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbHv4-0005h3-T5 for submit@debbugs.gnu.org; Tue, 29 Oct 2013 18:37:52 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:49823 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbHv1-0005gu-Vu for 15745@debbugs.gnu.org; Tue, 29 Oct 2013 18:37:48 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VbHv0-0001TZ-5A; Tue, 29 Oct 2013 18:37:46 -0400 From: Glenn Morris To: Barry OReilly Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface References: <5htxg1jct4.fsf@fencepost.gnu.org> X-Spook: Venezuela fundamentalist offensive information warfare X-Ran: `"Oge:S#/~$1:5ZLcmLuW")}!c=y#4!y.w>l}"q>}uuq"Wfd:NKN+QPoqiWabZj>|^)r]1 X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 29 Oct 2013 18:37:45 -0400 In-Reply-To: (Barry OReilly's message of "Tue, 29 Oct 2013 11:56:51 -0400") Message-ID: <26fvrjputi.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15745 Cc: 15745@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) Barry OReilly wrote: > It's weird that the region face would be used for this, because it has > nothing to do with the region. The fact that it can make me think I > have a region marked when I don't is a motivator for this bug report. Wanting to change the default appearance is a separate issue! :) You could ask cedet-devel. > I probably misinterpreted your earlier tip. I looked off of > diary-face: > > (define-obsolete-face-alias 'diary-face 'diary "22.1") Sorry, diary-face was a bad, confusing example for me to pick. I was looking in diary-lib.el, not calendar.el. > I've done as requested in the revised attached patch. Looks fine to me. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 30 21:55:41 2013 Received: (at 15745-done) by debbugs.gnu.org; 31 Oct 2013 01:55:41 +0000 Received: from localhost ([127.0.0.1]:53787 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbhU5-00061X-0E for submit@debbugs.gnu.org; Wed, 30 Oct 2013 21:55:41 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:38308) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VbhU2-00061G-3K for 15745-done@debbugs.gnu.org; Wed, 30 Oct 2013 21:55:39 -0400 Received: by mail-ob0-f178.google.com with SMTP id wm4so2349170obc.23 for <15745-done@debbugs.gnu.org>; Wed, 30 Oct 2013 18:55:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:cc :content-type; bh=Gisc3CzIeSOkJsbWr7F3JjQZGs4fI42Y5VE8d1bhitY=; b=BMojpuoQH1NkPuAlpTkBXVVvEmDMYOVzHVgF11yexpIVWmy0mWD+xmvznrFf9UaChi kPpTc7/LJGCWJjmkAHC5ypIrt2WFh5nv5ZvxakXpVXZ3TuaxplcRT+GbkLXHfB+XBZkK nkV7C9KCHhz4bFTY03e4AhSY84DREDFymbAKTf3fhfWKXIpnMjfhFl9CUjC342K2C1w1 wvnON88xBP5MrR5x8SL4t6/NQa0p3eh2MtZm7rHo3Ai1TqWhnhCq908hOTUhEgJt0k/V azrfu06mn9pgaKF/J+05khEZqhJnsRsCl2nCVlXkgnK/fECd3lVkOfXp82pJ/BSJE4JX dQVQ== MIME-Version: 1.0 X-Received: by 10.60.42.203 with SMTP id q11mr573617oel.54.1383184531641; Wed, 30 Oct 2013 18:55:31 -0700 (PDT) Received: by 10.76.156.103 with HTTP; Wed, 30 Oct 2013 18:55:31 -0700 (PDT) In-Reply-To: <26fvrjputi.fsf@fencepost.gnu.org> References: <5htxg1jct4.fsf@fencepost.gnu.org> <26fvrjputi.fsf@fencepost.gnu.org> Date: Wed, 30 Oct 2013 21:55:31 -0400 Message-ID: Subject: Re: bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface From: Barry OReilly Content-Type: multipart/alternative; boundary=001a11c207f0aadac704e9ffbe70 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 15745-done Cc: 15745-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --001a11c207f0aadac704e9ffbe70 Content-Type: text/plain; charset=ISO-8859-1 Rev 114879 --001a11c207f0aadac704e9ffbe70 Content-Type: text/html; charset=ISO-8859-1
Rev 114879

--001a11c207f0aadac704e9ffbe70-- From unknown Sat Aug 16 15:59:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 28 Nov 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator