From unknown Sat Aug 16 16:01:11 2025
X-Loop: help-debbugs@gnu.org
Subject: bug#15707: [PATCH 5/8] EWW: Option to always use external-browser for certain content.
Resent-From: =?UTF-8?Q?R=C3=BCdiger?= Sonderfeld <ruediger@c-plusplus.de>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Thu, 24 Oct 2013 23:45:06 +0000
Resent-Message-ID: <handler.15707.B.138265827822808@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: report 15707
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 15707@debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi@gnus.org>
X-Debbugs-Original-To: bug-gnu-emacs@gnu.org
Received: via spool by submit@debbugs.gnu.org id=B.138265827822808
          (code B ref -1); Thu, 24 Oct 2013 23:45:06 +0000
Received: (at submit) by debbugs.gnu.org; 24 Oct 2013 23:44:38 +0000
Received: from localhost ([127.0.0.1]:42081 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1VZUZx-0005vn-V4
	for submit@debbugs.gnu.org; Thu, 24 Oct 2013 19:44:38 -0400
Received: from eggs.gnu.org ([208.118.235.92]:59529)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <ruediger@c-plusplus.de>) id 1VZUZr-0005vW-N0
 for submit@debbugs.gnu.org; Thu, 24 Oct 2013 19:44:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ruediger@c-plusplus.de>) id 1VZUZf-00078e-Q6
 for submit@debbugs.gnu.org; Thu, 24 Oct 2013 19:44:26 -0400
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled
 version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:33105)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <ruediger@c-plusplus.de>) id 1VZUZf-00078a-N5
 for submit@debbugs.gnu.org; Thu, 24 Oct 2013 19:44:19 -0400
Received: from eggs.gnu.org ([2001:4830:134:3::10]:32905)
 by lists.gnu.org with esmtp (Exim 4.71)
 (envelope-from <ruediger@c-plusplus.de>) id 1VZUZZ-00060Q-Ll
 for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 19:44:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ruediger@c-plusplus.de>) id 1VZUZT-00074F-Lr
 for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 19:44:13 -0400
Received: from ptmx.org ([178.63.28.110]:41440)
 by eggs.gnu.org with esmtp (Exim 4.71)
 (envelope-from <ruediger@c-plusplus.de>) id 1VZUZT-000746-FX
 for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 19:44:07 -0400
Received: from localhost (localhost [127.0.0.1])
 by ptmx.org (Postfix) with ESMTP id DB6632B155;
 Fri, 25 Oct 2013 01:44:06 +0200 (CEST)
X-Virus-Scanned: Debian amavisd-new at ptmx.org
Received: from ptmx.org ([127.0.0.1])
 by localhost (ptmx.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id ymn+nRA+UKTE; Fri, 25 Oct 2013 01:44:05 +0200 (CEST)
Received: from descartes.localnet (chello080108246092.7.14.vie.surfer.at
 [80.108.246.92]) by ptmx.org (Postfix) with ESMTPSA id B1F2E2AEE8;
 Fri, 25 Oct 2013 01:44:04 +0200 (CEST)
From: =?UTF-8?Q?R=C3=BCdiger?= Sonderfeld <ruediger@c-plusplus.de>
Date: Fri, 25 Oct 2013 01:44 +0200
Message-ID: <1579034.yJTXVbOWVp@descartes>
User-Agent: KMail/4.11.2 (Linux/3.11.0-12-generic; KDE/4.11.2; x86_64; ; )
In-Reply-To: <cover.1382658061.git.ruediger@c-plusplus.de>
References: <cover.1382658061.git.ruediger@c-plusplus.de>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
 (bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -5.0 (-----)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -5.0 (-----)

Emacs can not display videos and has only limited audio support.
Therefore it makes sense to call an external browser for links of that
kind.  This is also a problem because shr turns <video> and <audio>
tags into links to the media.

* lisp/net/eww.el (eww-use-external-browser-for-content-type): New
  customizable variable.
  (eww-render): Handle `eww-use-external-browser-for-content-type'.
  Use \\` to match beginning of string instead of ^.
  (eww-browse-with-external-browser): Provide optional URL parameter.

Signed-off-by: R=C3=BCdiger Sonderfeld <ruediger@c-plusplus.de>
---
 lisp/net/eww.el | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index ccc2399..6335bd8 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -75,6 +75,14 @@ (defcustom eww-form-checkbox-symbol "[ ]"
                  (const "=E2=98=90")            ; Unicode BALLOT BOX
                  string))
=20
+(defcustom eww-use-external-browser-for-content-type
+  "\\`\\(video/\\|audio/\\|application/ogg\\)"
+  "Always use external browser for specified content-type."
+  :version "24.4"
+  :group 'eww
+  :type '(choice (const :tag "Never" nil)
+                 regexp))
+
 (defface eww-form-submit
   '((((type x w32 ns) (class color))=09; Like default mode line
      :box (:line-width 2 :style released-button)
@@ -173,10 +181,14 @@ (defun eww-render (status url &optional point)
     (unwind-protect
 =09(progn
 =09  (cond
+           ((and eww-use-external-browser-for-content-type
+                 (string-match-p eww-use-external-browser-for-content-=
type
+                                 (car content-type)))
+            (eww-browse-with-external-browser url))
 =09   ((equal (car content-type) "text/html")
 =09    (eww-display-html charset url))
-=09   ((string-match "^image/" (car content-type))
-=09    (eww-display-image))
+=09   ((string-match-p "\\`image/" (car content-type))
+=09    (eww-display-image url))
 =09   (t
 =09    (eww-display-raw)))
 =09  (setq eww-current-url url
@@ -929,11 +941,11 @@ (defun eww-submit ()
 =09"?"
 =09(mm-url-encode-www-form-urlencoded values))))))
=20
-(defun eww-browse-with-external-browser ()
+(defun eww-browse-with-external-browser (&optional url)
   "Browse the current URL with an external browser.
 The browser to used is specified by the `shr-external-browser' variabl=
e."
   (interactive)
-  (funcall shr-external-browser eww-current-url))
+  (funcall shr-external-browser (or url eww-current-url)))
=20
 (defun eww-copy-page-url ()
   (interactive)
--=20
1.8.4.1






From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 24 19:54:19 2013
Received: (at control) by debbugs.gnu.org; 24 Oct 2013 23:54:19 +0000
Received: from localhost ([127.0.0.1]:42125 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1VZUjK-0006D0-UE
	for submit@debbugs.gnu.org; Thu, 24 Oct 2013 19:54:19 -0400
Received: from fencepost.gnu.org ([208.118.235.10]:34179 ident=Debian-exim)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <rgm@gnu.org>) id 1VZUjJ-0006Cr-Kw
 for control@debbugs.gnu.org; Thu, 24 Oct 2013 19:54:18 -0400
Received: from rgm by fencepost.gnu.org with local (Exim 4.71)
 (envelope-from <rgm@gnu.org>) id 1VZUjJ-00056p-3X
 for control@debbugs.gnu.org; Thu, 24 Oct 2013 19:54:17 -0400
Date: Thu, 24 Oct 2013 19:54:17 -0400
Message-Id: <E1VZUjJ-00056p-3X@fencepost.gnu.org>
Subject: control message for bug 15710
To: <control@debbugs.gnu.org>
X-Mailer: mail (GNU Mailutils 2.1)
From: Glenn Morris <rgm@gnu.org>
X-Spam-Score: -5.4 (-----)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: -5.4 (-----)

merge 15702 15703 15704 15705 15706 15707 15708 15709 15710




From unknown Sat Aug 16 16:01:11 2025
X-Loop: help-debbugs@gnu.org
Subject: bug#15707: [PATCH 5/8] EWW: Option to always use external-browser for certain content.
Resent-From: Lars Magne Ingebrigtsen <larsi@gnus.org>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Sun, 01 Dec 2013 15:45:02 +0000
Resent-Message-ID: <handler.15707.B15707.138591269819967@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 15707
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: =?UTF-8?Q?R=C3=BCdiger?= Sonderfeld <ruediger@c-plusplus.de>
Cc: 15708@debbugs.gnu.org, 15707@debbugs.gnu.org
Received: via spool by 15707-submit@debbugs.gnu.org id=B15707.138591269819967
          (code B ref 15707); Sun, 01 Dec 2013 15:45:02 +0000
Received: (at 15707) by debbugs.gnu.org; 1 Dec 2013 15:44:58 +0000
Received: from localhost ([127.0.0.1]:53276 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1Vn9Cc-0005Bs-Ay
	for submit@debbugs.gnu.org; Sun, 01 Dec 2013 10:44:58 -0500
Received: from hermes.netfonds.no ([80.91.224.195]:58268)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <larsi@gnus.org>)
 id 1Vn9CZ-0005Bb-HI; Sun, 01 Dec 2013 10:44:55 -0500
Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]
 helo=stories.gnus.org)
 by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <larsi@gnus.org>)
 id 1Vn9CM-0006Yn-8V; Sun, 01 Dec 2013 16:44:42 +0100
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
References: <cover.1382658061.git.ruediger@c-plusplus.de>
 <1579034.yJTXVbOWVp@descartes>
X-Now-Playing: The Knife's _Shaking The Habitual (2)_: "Fracking Fluid
 Injection"
X-Hashcash: 1:23:131201:ruediger@c-plusplus.de::2TM7njvI1aaYl+3Y:0000000000000000000000000000000000000001SPI
X-Hashcash: 1:23:131201:15707@debbugs.gnu.org::9+TkEWQ58wM8Mm/t:0000000000000000000000000000000000000000I+9K
X-Hashcash: 1:23:131201:15708@debbugs.gnu.org::CTL+v4cJ5CeQ3Xo4:0000000000000000000000000000000000000001JC44
Date: Sun, 01 Dec 2013 16:44:41 +0100
In-Reply-To: <1579034.yJTXVbOWVp@descartes> ("=?UTF-8?Q?R=C3=BCdiger?=
 Sonderfeld"'s message of "Fri, 25 Oct 2013 01:44 +0200")
Message-ID: <m3bo10bmom.fsf@stories.gnus.org>
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
X-MailScanner-ID: 1Vn9CM-0006Yn-8V
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@gnus.org
MailScanner-NULL-Check: 1386517482.5839@UrMnTjrZOna33Mp9TXGt3w
X-Spam-Status: No
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

R=FCdiger Sonderfeld <ruediger@c-plusplus.de> writes:

> Emacs can not display videos and has only limited audio support.
> Therefore it makes sense to call an external browser for links of that
> kind.  This is also a problem because shr turns <video> and <audio>
> tags into links to the media.
>
> * lisp/net/eww.el (eww-use-external-browser-for-content-type): New
>   customizable variable.
>   (eww-render): Handle `eww-use-external-browser-for-content-type'.
>   Use \\` to match beginning of string instead of ^.
>   (eww-browse-with-external-browser): Provide optional URL parameter.

Thanks; applied.

--=20
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 01 10:53:40 2013
Received: (at control) by debbugs.gnu.org; 1 Dec 2013 15:53:41 +0000
Received: from localhost ([127.0.0.1]:53314 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.80)
	(envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
	id 1Vn9L2-0005R2-Ai
	for submit@debbugs.gnu.org; Sun, 01 Dec 2013 10:53:40 -0500
Received: from hermes.netfonds.no ([80.91.224.195]:48342)
 by debbugs.gnu.org with esmtp (Exim 4.80)
 (envelope-from <larsi@gnus.org>) id 1Vn9L0-0005Qt-I4
 for control@debbugs.gnu.org; Sun, 01 Dec 2013 10:53:38 -0500
Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]
 helo=stories.gnus.org)
 by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
 (Exim 4.72) (envelope-from <larsi@gnus.org>) id 1Vn9Km-0006mW-RL
 for control@debbugs.gnu.org; Sun, 01 Dec 2013 16:53:24 +0100
Date: Sun, 01 Dec 2013 16:53:24 +0100
Message-Id: <m3r49wa7pn.fsf@stories.gnus.org>
To: control@debbugs.gnu.org
From: Lars Magne Ingebrigtsen <larsi@gnus.org>
Subject: control message for bug #15708
X-MailScanner-ID: 1Vn9Km-0006mW-RL
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@gnus.org
MailScanner-NULL-Check: 1386518005.81136@CFIiy/IGdow13yc6LadfOA
X-Spam-Status: No
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <http://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=unsubscribe>
List-Archive: <http://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit@debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request@debbugs.gnu.org?subject=help>
List-Subscribe: <http://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request@debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
X-Spam-Score: 0.0 (/)

tags 15708 fixed
close 15708 24.4