From unknown Tue Jun 17 01:40:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15699: 24.3.50; lisp-cl-font-lock-keywords-2 Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2013 15:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 15699@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13826269813804 (code B ref -1); Thu, 24 Oct 2013 15:03:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Oct 2013 15:03:01 +0000 Received: from localhost ([127.0.0.1]:41256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZMRA-0000zH-Sf for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:03:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37855) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZMR9-0000yk-F7 for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:02:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZMQv-0004BK-WC for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:02:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZMQv-0004BG-T5 for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:02:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZMQn-0002JV-GM for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 11:02:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZMQd-00047I-BQ for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 11:02:37 -0400 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:52928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZMQd-00047C-4M for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 11:02:27 -0400 Received: by mail-ee0-f48.google.com with SMTP id e50so1179418eek.35 for ; Thu, 24 Oct 2013 08:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=aHQIa0gU80OsZ91dfdBAibDAFNJXtWeviYciKfkjY/g=; b=NFsaLQGS2baObp8ii8I6jKioDowiyPZZ1Zc4ROiTHgFapL13mieSDNWLtvZO0sMxdZ v1MPh4Ioeh22aMXjXgSWzhix5SY2VYijFRn+s5ln0qOuueZYC3StR4GjIiB8/YZ9hTRx 9SKK5BNRQ/cV3zEGKYkDBzOskvTGrVLfQjWkNNPBCZdHXMIxMv++ZUQSekxhQKfsXWT7 AipxoQL4/yY6LNWDBM4FPqmrxn0p+jSjKs+6pFpRwFIr0sNzuPyRKXiN0jrpT2T2wPw7 dzi3GrOCFx+ApJ4M19HPvV7RsXOkWBSEDSITXqLsAyCabuayV50cLfkpFtLeotU9eB6h 26QA== X-Received: by 10.14.182.72 with SMTP id n48mr2404562eem.113.1382626945754; Thu, 24 Oct 2013 08:02:25 -0700 (PDT) Received: from ix (dial-185234.pool.broadband44.net. [212.46.185.234]) by mx.google.com with ESMTPSA id f49sm5433203eec.7.2013.10.24.08.02.23 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Oct 2013 08:02:24 -0700 (PDT) Received: from helmut by ix with local (Exim 4.80) (envelope-from ) id 1VZMQY-0000uG-SJ for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 17:02:22 +0200 From: Helmut Eller Date: Thu, 24 Oct 2013 17:02:22 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain In lisp-mode, "labels" and "flet" are not highlighted while stuff like "letrec" and "save-excursion" are (wrongly) highlighted. To see that, open a file with name "foo.lisp" and insert something like: (labels ((foo ())) (letrec ((bar bar)))) I think that the patch below would fix this problem. The patch also removes "featurep" because that's not a defined operator in Common Lisp. I can also write a ERT test if needed. In GNU Emacs 24.3.50.4 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2013-10-19 on ix Bzr revision: 114715 rgm@gnu.org-20131019023520-s8mwtib7xcx9e05w --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=lisp-mode.patch === modified file 'lisp/emacs-lisp/lisp-mode.el' --- lisp/emacs-lisp/lisp-mode.el 2013-10-08 14:57:18 +0000 +++ lisp/emacs-lisp/lisp-mode.el 2013-10-24 14:57:07 +0000 @@ -251,9 +251,7 @@ (cons "go" (mapcar (lambda (s) (concat "cl-" s)) (remove "go" cl-lib-kw)))) t) - (regexp-opt (append lisp-kw el-kw eieio-kw - (cons "go" (mapcar (lambda (s) (concat "cl-" s)) - (remove "go" cl-kw)))) + (regexp-opt (append lisp-kw cl-kw eieio-kw cl-lib-kw) t) ;; Elisp and Common Lisp "errors". @@ -360,7 +358,7 @@ ;; Control structures. Common Lisp forms. (,(concat "(" cl-kws-re "\\_>") . 1) ;; Exit/Feature symbols as constants. - (,(concat "(\\(catch\\|throw\\|featurep\\|provide\\|require\\)\\_>" + (,(concat "(\\(catch\\|throw\\|provide\\|require\\)\\_>" "[ \t']*\\(\\(?:\\sw\\|\\s_\\)+\\)?") (1 font-lock-keyword-face) (2 font-lock-constant-face nil t)) --=-=-=-- From unknown Tue Jun 17 01:40:58 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15699: 24.3.50; lisp-cl-font-lock-keywords-2 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Oct 2013 17:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Helmut Eller Cc: 15699@debbugs.gnu.org Received: via spool by 15699-submit@debbugs.gnu.org id=B15699.138263644619231 (code B ref 15699); Thu, 24 Oct 2013 17:41:02 +0000 Received: (at 15699) by debbugs.gnu.org; 24 Oct 2013 17:40:46 +0000 Received: from localhost ([127.0.0.1]:41523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZOtp-000507-VN for submit@debbugs.gnu.org; Thu, 24 Oct 2013 13:40:46 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31850) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZOtn-0004zs-E4 for 15699@debbugs.gnu.org; Thu, 24 Oct 2013 13:40:43 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZ4I/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFFpZ4I/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="36267228" Received: from 69-165-158-8.dsl.teksavvy.com (HELO pastel.home) ([69.165.158.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Oct 2013 13:40:37 -0400 Received: by pastel.home (Postfix, from userid 20848) id 538986070E; Thu, 24 Oct 2013 13:40:37 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Thu, 24 Oct 2013 13:40:37 -0400 In-Reply-To: (Helmut Eller's message of "Thu, 24 Oct 2013 17:02:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > In lisp-mode, "labels" and "flet" are not highlighted while stuff like Indeed, you should use cl-lib (and hence cl-labels and cl-flet). Stefan From unknown Tue Jun 17 01:40:58 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Helmut Eller Subject: bug#15699: closed (Re: bug#15699: 24.3.50; lisp-cl-font-lock-keywords-2) Message-ID: References: X-Gnu-PR-Message: they-closed 15699 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 15699@debbugs.gnu.org Date: Thu, 24 Oct 2013 17:50:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1382637004-20141-1" This is a multi-part message in MIME format... ------------=_1382637004-20141-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #15699: 24.3.50; lisp-cl-font-lock-keywords-2 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 15699@debbugs.gnu.org. --=20 15699: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15699 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1382637004-20141-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 15699-done) by debbugs.gnu.org; 24 Oct 2013 17:49:54 +0000 Received: from localhost ([127.0.0.1]:41537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZP2g-0005ES-3y for submit@debbugs.gnu.org; Thu, 24 Oct 2013 13:49:54 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:60863) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZP2e-0005EA-HN for 15699-done@debbugs.gnu.org; Thu, 24 Oct 2013 13:49:52 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpZ4I/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFFpZ4I/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="36268138" Received: from 69-165-158-8.dsl.teksavvy.com (HELO pastel.home) ([69.165.158.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Oct 2013 13:49:46 -0400 Received: by pastel.home (Postfix, from userid 20848) id BA85C6070E; Thu, 24 Oct 2013 13:49:46 -0400 (EDT) From: Stefan Monnier To: Helmut Eller Subject: Re: bug#15699: 24.3.50; lisp-cl-font-lock-keywords-2 Message-ID: References: Date: Thu, 24 Oct 2013 13:49:46 -0400 In-Reply-To: (Helmut Eller's message of "Thu, 24 Oct 2013 17:02:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15699-done Cc: 15699-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > In lisp-mode, "labels" and "flet" are not highlighted while stuff like > "letrec" and "save-excursion" are (wrongly) highlighted. To see that, > open a file with name "foo.lisp" and insert something like: Hmm... duh... sorry for the previous message, I misread and fired too quickly. I installed your patch into trunk, thank you, Stefan ------------=_1382637004-20141-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Oct 2013 15:03:01 +0000 Received: from localhost ([127.0.0.1]:41256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZMRA-0000zH-Sf for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:03:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37855) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZMR9-0000yk-F7 for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:02:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZMQv-0004BK-WC for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:02:54 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45177) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZMQv-0004BG-T5 for submit@debbugs.gnu.org; Thu, 24 Oct 2013 11:02:45 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZMQn-0002JV-GM for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 11:02:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZMQd-00047I-BQ for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 11:02:37 -0400 Received: from mail-ee0-x230.google.com ([2a00:1450:4013:c00::230]:52928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZMQd-00047C-4M for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 11:02:27 -0400 Received: by mail-ee0-f48.google.com with SMTP id e50so1179418eek.35 for ; Thu, 24 Oct 2013 08:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=aHQIa0gU80OsZ91dfdBAibDAFNJXtWeviYciKfkjY/g=; b=NFsaLQGS2baObp8ii8I6jKioDowiyPZZ1Zc4ROiTHgFapL13mieSDNWLtvZO0sMxdZ v1MPh4Ioeh22aMXjXgSWzhix5SY2VYijFRn+s5ln0qOuueZYC3StR4GjIiB8/YZ9hTRx 9SKK5BNRQ/cV3zEGKYkDBzOskvTGrVLfQjWkNNPBCZdHXMIxMv++ZUQSekxhQKfsXWT7 AipxoQL4/yY6LNWDBM4FPqmrxn0p+jSjKs+6pFpRwFIr0sNzuPyRKXiN0jrpT2T2wPw7 dzi3GrOCFx+ApJ4M19HPvV7RsXOkWBSEDSITXqLsAyCabuayV50cLfkpFtLeotU9eB6h 26QA== X-Received: by 10.14.182.72 with SMTP id n48mr2404562eem.113.1382626945754; Thu, 24 Oct 2013 08:02:25 -0700 (PDT) Received: from ix (dial-185234.pool.broadband44.net. [212.46.185.234]) by mx.google.com with ESMTPSA id f49sm5433203eec.7.2013.10.24.08.02.23 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 24 Oct 2013 08:02:24 -0700 (PDT) Received: from helmut by ix with local (Exim 4.80) (envelope-from ) id 1VZMQY-0000uG-SJ for bug-gnu-emacs@gnu.org; Thu, 24 Oct 2013 17:02:22 +0200 From: Helmut Eller To: bug-gnu-emacs@gnu.org Subject: 24.3.50; lisp-cl-font-lock-keywords-2 Date: Thu, 24 Oct 2013 17:02:22 +0200 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain In lisp-mode, "labels" and "flet" are not highlighted while stuff like "letrec" and "save-excursion" are (wrongly) highlighted. To see that, open a file with name "foo.lisp" and insert something like: (labels ((foo ())) (letrec ((bar bar)))) I think that the patch below would fix this problem. The patch also removes "featurep" because that's not a defined operator in Common Lisp. I can also write a ERT test if needed. In GNU Emacs 24.3.50.4 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2013-10-19 on ix Bzr revision: 114715 rgm@gnu.org-20131019023520-s8mwtib7xcx9e05w --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=lisp-mode.patch === modified file 'lisp/emacs-lisp/lisp-mode.el' --- lisp/emacs-lisp/lisp-mode.el 2013-10-08 14:57:18 +0000 +++ lisp/emacs-lisp/lisp-mode.el 2013-10-24 14:57:07 +0000 @@ -251,9 +251,7 @@ (cons "go" (mapcar (lambda (s) (concat "cl-" s)) (remove "go" cl-lib-kw)))) t) - (regexp-opt (append lisp-kw el-kw eieio-kw - (cons "go" (mapcar (lambda (s) (concat "cl-" s)) - (remove "go" cl-kw)))) + (regexp-opt (append lisp-kw cl-kw eieio-kw cl-lib-kw) t) ;; Elisp and Common Lisp "errors". @@ -360,7 +358,7 @@ ;; Control structures. Common Lisp forms. (,(concat "(" cl-kws-re "\\_>") . 1) ;; Exit/Feature symbols as constants. - (,(concat "(\\(catch\\|throw\\|featurep\\|provide\\|require\\)\\_>" + (,(concat "(\\(catch\\|throw\\|provide\\|require\\)\\_>" "[ \t']*\\(\\(?:\\sw\\|\\s_\\)+\\)?") (1 font-lock-keyword-face) (2 font-lock-constant-face nil t)) --=-=-=-- ------------=_1382637004-20141-1--