From unknown Fri Jun 20 18:15:40 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15682 <15682@debbugs.gnu.org> To: bug#15682 <15682@debbugs.gnu.org> Subject: Status: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' Reply-To: bug#15682 <15682@debbugs.gnu.org> Date: Sat, 21 Jun 2025 01:15:40 +0000 retitle 15682 24.3.50; `:link' in `defgroup' does not respect `mouse-1-clic= k-follows-link' reassign 15682 emacs submitter 15682 Drew Adams severity 15682 minor tag 15682 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 22 11:28:56 2013 Received: (at submit) by debbugs.gnu.org; 22 Oct 2013 15:28:57 +0000 Received: from localhost ([127.0.0.1]:35303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYdt9-0008OO-E5 for submit@debbugs.gnu.org; Tue, 22 Oct 2013 11:28:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50239) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VYdt5-0008O8-Ur for submit@debbugs.gnu.org; Tue, 22 Oct 2013 11:28:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYdss-0002gZ-8u for submit@debbugs.gnu.org; Tue, 22 Oct 2013 11:28:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:36197) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYdss-0002gR-5P for submit@debbugs.gnu.org; Tue, 22 Oct 2013 11:28:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYdsk-0002OQ-LK for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2013 11:28:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VYdsd-0002bL-0H for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2013 11:28:30 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:28915) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VYdsc-0002bG-Qi for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2013 11:28:22 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9MFSLD0019560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 22 Oct 2013 15:28:22 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9MFSLXL020152 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 22 Oct 2013 15:28:21 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9MFSKvI017418 for ; Tue, 22 Oct 2013 15:28:20 GMT MIME-Version: 1.0 Message-ID: <203eab8f-376f-423b-8347-3a0d354bb3e3@default> Date: Tue, 22 Oct 2013 08:28:06 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q In *scratch*, evaluate this: (defgroup foo nil "..." :prefix "foo-" :group 'editing :link '(url-link "http://www.emacswiki.org/")) (defcustom foobar t "..." :type 'boolean :group 'foo) M-x set-variable mouse-1-click-follows-link nil M-x customize-option foobar Click the link `http://www.emacswiki.org/' using `mouse-1'. The link is followed - it should not be followed. Note that `mouse-on-link-p' returns `t' for positions on this link, and such positions have face `custom-link', property `follow-link' with value `mouse-face', and property `mouse-face' with a face value, all of which show further that the behavior violates the mandate of `mouse-1-click-follows-link'. Quite annoying. Emacs should not overrule user settings like this. This is not a regression: it has been broken from the outset (broken in all Emacs versions that support `:link'). In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-10-19 on LEG570 Bzr revision: 114715 rgm@gnu.org-20131019023520-s8mwtib7xcx9e05w Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1' From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 22:45:24 2014 Received: (at control) by debbugs.gnu.org; 8 Feb 2014 03:45:24 +0000 Received: from localhost ([127.0.0.1]:55819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WByr5-0008GL-KM for submit@debbugs.gnu.org; Fri, 07 Feb 2014 22:45:23 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:53224) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WByr2-0008BY-AD for control@debbugs.gnu.org; Fri, 07 Feb 2014 22:45:22 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WByql-0004OM-Os for control@debbugs.gnu.org; Sat, 08 Feb 2014 04:45:04 +0100 Date: Fri, 07 Feb 2014 19:43:56 -0800 Message-Id: <87mwi28e0z.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #15682 X-MailScanner-ID: 1WByql-0004OM-Os X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392435905.35861@7PEkpFeRUPGwjFqGOKbaAQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) merge 15682 52 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 12:09:27 2016 Received: (at 15682) by debbugs.gnu.org; 27 Apr 2016 16:09:27 +0000 Received: from localhost ([127.0.0.1]:50248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avS1m-00068W-Rv for submit@debbugs.gnu.org; Wed, 27 Apr 2016 12:09:27 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:45625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avS1k-00068G-1x; Wed, 27 Apr 2016 12:09:25 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avS1f-0007qU-T0; Wed, 27 Apr 2016 18:09:23 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <203eab8f-376f-423b-8347-3a0d354bb3e3@default> Date: Wed, 27 Apr 2016 18:09:19 +0200 In-Reply-To: <203eab8f-376f-423b-8347-3a0d354bb3e3@default> (Drew Adams's message of "Tue, 22 Oct 2013 08:28:06 -0700 (PDT)") Message-ID: <87inz3hw40.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, 52@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > (defgroup foo nil > "..." :prefix "foo-" :group 'editing > :link '(url-link "http://www.emacswiki.org/")) > > (defcustom foobar t "..." :type 'boolean :group 'foo) > > M-x set-variable mouse-1-click-follows-link nil > M-x customize-option foobar > > Click the link `http://www.emacswiki.org/' using `mouse-1'. The link is > followed - it should not be followed. > > Note that `mouse-on-link-p' returns `t' for positions on this link, and > such positions have face `custom-link', property `follow-link' with > value `mouse-face', and property `mouse-face' with a face value, all of > which show further that the behavior violates the mandate of > `mouse-1-click-follows-link'. I've had another peek at this, but the main problem is that I don't quite understand why the Widget code is so... complicated. Why does it do all the stuff below? I mean, no other modes that react to mouse clicks need to ... do all that... (defun widget-button-click (event) "Invoke the button that the mouse is pointing at." (interactive "e") (if (widget-event-point event) (let* ((oevent event) (mouse-1 (memq (event-basic-type event) '(mouse-1 down-mouse-1))) (pos (widget-event-point event)) (start (event-start event)) (button (get-char-property pos 'button (and (windowp (posn-window start)) (window-buffer (posn-window start))))) newpoint) (when (or (null button) (catch 'button-press-cancelled ;; Mouse click on a widget button. Do the following ;; in a save-excursion so that the click on the button ;; doesn't change point. (save-selected-window (select-window (posn-window (event-start event))) (save-excursion (goto-char (posn-point (event-start event))) (let* ((overlay (widget-get button :button-overlay)) (pressed-face (or (widget-get button :pressed-face) widget-button-pressed-face)) (face (overlay-get overlay 'face)) (mouse-face (overlay-get overlay 'mouse-face))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 12:24:49 2016 Received: (at 15682) by debbugs.gnu.org; 27 Apr 2016 16:24:49 +0000 Received: from localhost ([127.0.0.1]:50277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avSGe-00089i-Qh for submit@debbugs.gnu.org; Wed, 27 Apr 2016 12:24:49 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:44793) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avSGa-00089H-Tx; Wed, 27 Apr 2016 12:24:45 -0400 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3RGObO1001892 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 Apr 2016 16:24:37 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u3RGOa4C014598 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Apr 2016 16:24:36 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3RGOa37009821; Wed, 27 Apr 2016 16:24:36 GMT MIME-Version: 1.0 Message-ID: <89237c28-b7ed-4621-9baf-908fe99a6c9d@default> Date: Wed, 27 Apr 2016 09:24:34 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <203eab8f-376f-423b-8347-3a0d354bb3e3@default> <87inz3hw40.fsf@gnus.org> In-Reply-To: <87inz3hw40.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: userv0022.oracle.com [156.151.31.74] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, 52@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I've had another peek at this,=20 Thanks for looking into it. > but the main problem is that I don't quite understand why the > Widget code is so... complicated. I sympathize, and I agree that is difficult to fathom. Can't help with the understanding, however. > Why does it do all the stuff below? I mean, no other modes > that react to mouse clicks need to ... do all that... Dunno. But just because the code can be difficult to follow is not a reason to assume that it does unnecessary things, in general. The widget code that I've been able to follow does DTRT, generally (AFAICT). I doubt that anyone left understands the widget code well. Maybe you can find Per Abrahamsen and get him to take a look? The URLs for him listed here are dead, but maybe looking here would be a start: https://www.emacswiki.org/emacs/PerAbrahamsen. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 12:53:22 2016 Received: (at 15682) by debbugs.gnu.org; 27 Apr 2016 16:53:22 +0000 Received: from localhost ([127.0.0.1]:50345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avSiI-0000Sz-CK for submit@debbugs.gnu.org; Wed, 27 Apr 2016 12:53:22 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:46238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avSiG-0000Sm-EP; Wed, 27 Apr 2016 12:53:20 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1avSiD-0008Q2-Ld; Wed, 27 Apr 2016 18:53:19 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <203eab8f-376f-423b-8347-3a0d354bb3e3@default> <87inz3hw40.fsf@gnus.org> <89237c28-b7ed-4621-9baf-908fe99a6c9d@default> Date: Wed, 27 Apr 2016 18:53:17 +0200 In-Reply-To: <89237c28-b7ed-4621-9baf-908fe99a6c9d@default> (Drew Adams's message of "Wed, 27 Apr 2016 09:24:34 -0700 (PDT)") Message-ID: <87potbgfia.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, 52@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > Dunno. But just because the code can be difficult to follow > is not a reason to assume that it does unnecessary things, in > general. The widget code that I've been able to follow does > DTRT, generally (AFAICT). It does, but the logic is very hard to follow. Custom/widget works by inserting text into the buffer, and then "converting" it to a widget, or by creating a widget and then inserting it. And it does it all with overlays, and seems like it's created its own event handling distinct from the normal Emacs event handler, sort of. There are, of course, historical reasons for this. Per wrote Widget in the mid 90s when many of these issues hadn't been resolved, and it worked across many Emacs versions. I kinda think it might be time to consider doing a rewrite from scratch using modern Emacs features, and then things like this bug report would start working automatically. How big a task would this be? I mean, of course we'd keep compatibility (the defcustom language is fine), but just rewrite the UI `M-x customize' bits... Hm... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 27 13:18:21 2016 Received: (at 15682) by debbugs.gnu.org; 27 Apr 2016 17:18:21 +0000 Received: from localhost ([127.0.0.1]:50375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avT6T-0004No-0I for submit@debbugs.gnu.org; Wed, 27 Apr 2016 13:18:21 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:45249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avT6Q-0004NR-Lk; Wed, 27 Apr 2016 13:18:18 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3RHICnQ013869 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Apr 2016 17:18:12 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.13.8/8.13.8) with ESMTP id u3RHIB1U004165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Apr 2016 17:18:12 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3RHIAIs008429; Wed, 27 Apr 2016 17:18:11 GMT MIME-Version: 1.0 Message-ID: <3c72ce34-13d3-4ecd-8731-8408fa1a023a@default> Date: Wed, 27 Apr 2016 10:18:09 -0700 (PDT) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <203eab8f-376f-423b-8347-3a0d354bb3e3@default> <87inz3hw40.fsf@gnus.org> <89237c28-b7ed-4621-9baf-908fe99a6c9d@default> <87potbgfia.fsf@gnus.org> In-Reply-To: <87potbgfia.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, 52@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I kinda think it might be time to consider doing a rewrite from scratch > using modern Emacs features, and then things like this bug report would > start working automatically. >=20 > How big a task would this be? I mean, of course we'd keep compatibility > (the defcustom language is fine), but just rewrite the UI `M-x > customize' bits... Hm... I can't speak to this, sorry. I'll just mention that I think: (1) it could be a large undertaking and (2) there is existing code out there that depends on or enhances cus*.el and wid*.el code. Personally, I would prefer that we live with it, and try to improve it incrementally, rather than opting for a rewrite or replacement. I'd like to see a resident Emacs expert on wid* and cus*, rather than someone who doesn't master it just trying for a replacement. (Yes, I'm conservative wrt this stuff. Emacs is one of the few things I'm conservative about. ;-)) From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 23 16:42:05 2019 Received: (at 15682) by debbugs.gnu.org; 23 Aug 2019 20:42:05 +0000 Received: from localhost ([127.0.0.1]:41275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1GNo-0000YM-RG for submit@debbugs.gnu.org; Fri, 23 Aug 2019 16:42:05 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:44430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1GNn-0000Xs-FW for 15682@debbugs.gnu.org; Fri, 23 Aug 2019 16:42:04 -0400 Received: by mail-lj1-f171.google.com with SMTP id e24so10001443ljg.11 for <15682@debbugs.gnu.org>; Fri, 23 Aug 2019 13:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to:cc; bh=nYKcYuNF6uhSQKgFtVNRna5co8/mpEk0NdohRNfeOzg=; b=sGyvozAzeAu1cndB0s+DIsIz3ksxBV5wcFJ4aq3FqZ88B4RYwf/6s/MxBRsEun42Wp lhEzNcel8wsIcurR9NjpOqBp4HJ5QNPR7LvLEylT+DfZzBHsojQz8dESRJifmWt8VoVF 0fizfIycC6YDCDBqL4yxeTj9DPYk8J474qziqb081fv0x4KMDKbPIM5qq9ac5qeBSC7H 56nZgKBbAlOFfV/SYXoWFl4aImVZ7HUFeCs2sejDjh+23QkOmjjKMIGlYu8UuZEv7+c5 x8cRGX6pqb5+uwigagFs9nzoETvauWb7x46sEQEh3cUcsCNgA/iYKZEnx2P/vDR8AM5M EZQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=nYKcYuNF6uhSQKgFtVNRna5co8/mpEk0NdohRNfeOzg=; b=s3e/mkZOPIO/1FrLwps9wiQ9WhR8eY0XrqOqExf9XLKXH7V/cjrKy4/60zjTEzbVxM C+q18+v98MASnZ2jhBodPGV6rVDFhnRqXHXZNDCA5uqxy6QpqRwNcsPToqPaJZnjwwPZ hZK30TWF7A1BOg+OzbXpOxmZW8f/AUNuODmNz4XdwVo68E8okLjt5Vdj3xq0x9xYp5So Xj18gp8O5eV5S8vq+7Wy80tHUZveRn/J5gIyiAbHF6t/WfEss/sxIxjOJ1Q2QyIVKBna Hi6uvAtXupV1uHDeOaQFCJclaBIakoJVBQgPX7qmaayQHplswr8xRnQMfARigGI6cxsA JfKw== X-Gm-Message-State: APjAAAXviyovohpbyCts3RFPP8BLtVFBkEo2Y61mv4QwPWD/+NuQT4HE xhh91IeGqYHVaBc2d1ZWRWk1dJPzKaTssmLc4nNUvrP5GmY= X-Google-Smtp-Source: APXvYqwnc5dq8p3aTBG8IYqNXSmVIzbabKSm+b/IavgF5Qof+7k6QzB6kDpJNBN9qsS/ofRFHZEZW354DSI6GWZNQDM= X-Received: by 2002:a2e:a310:: with SMTP id l16mr3366526lje.47.1566592917041; Fri, 23 Aug 2019 13:41:57 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Fri, 23 Aug 2019 17:41:45 -0300 Message-ID: Subject: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' To: 15682@debbugs.gnu.org Content-Type: multipart/mixed; boundary="000000000000549e420590ced6c8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: Lars Ingebrigtsen , drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000549e420590ced6c8 Content-Type: multipart/alternative; boundary="000000000000549e400590ced6c6" --000000000000549e400590ced6c6 Content-Type: text/plain; charset="UTF-8" I took a look at this bug and it turned out to be really tricky. So I did all the research I could, to try to find a good fix. Because the widget-button-click code was written before the addition of mouse-1-click-follows-link, there is some work to be done to adapt it. Even though there were some attempts [1], they weren't enough. The attached patch tries to fix this bug, while trying to not change too much of the code of the widget library. It introduces a keymap for the link widgets, and only binds mouse-2 events. Since widget-button-click isn't changed, it has to bind down-mouse-2 too. In this fix, I also have been careful to not reintroduce bugs that have come up by changing the keybindings in the widget-keymap, such as here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23571 I investigated the emacs sources, and have noticed that this patch could cause problems with three pieces of code: 1) recentf.el: Because of Bug#22434, puts a nil :follow-link property to the link widget. https://debbugs.gnu.org/cgi/bugreport.cgi?bug=22434 The patch would make that mouse-1 isn't translated to mouse-2, but since this was a workaround, changing this code would be OK, I think. Without overriding :follow-link, I have checked that recentf.el works like it should, with this patch applied. 2) epa.el: Typing M-x epa-encrypt-file brings up a *Keys* buffer. This buffer has clickable text: [Cancel] and [OK]. The epa code create this as a link widget, and when mouse-1-click-follows-link is nil, this text becomes not responsive with mouse-1. I'd say this are more buttons than links, so a fix for it (if it is considered it needs fixing) would be to turn them into push-button widgets. 3) mh-mime.el: I have never used MH-E. But there is some code in mh-mime.el that creates a link widget, with an action mh-widget-press-button, and it looks like it has a keymap of its own. I don't know if the behavior could change here. I haven't found any other code in the Emacs sources that could have problems. And fixing this would make code that depends on the link widgets to behave as expected, when mouse-1-click-follows-link is customized to a nil value. So I think it would be good to fix this. [1] https://lists.gnu.org/archive/html/emacs-devel/2008-03/msg01312.html --000000000000549e400590ced6c6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I took a look at this bug and it turned out to be really t= ricky.=C2=A0 So I did
all the research I could, to try to find a good fi= x.

Because the widget-button-click code was written before the addit= ion of
mouse-1-click-follows-link, there is some work to be done to adap= t it.=C2=A0 Even
though there were some attempts [1], they weren't e= nough.

The attached patch tries to fix this bug, while trying to not= change too much
of the code of the widget library.=C2=A0 It introduces = a keymap for the link widgets,
and only binds mouse-2 events.=C2=A0 Sinc= e widget-button-click isn't changed, it
has to bind down-mouse-2 too= .=C2=A0 In this fix, I also have been careful to not
reintroduce bugs th= at have come up by changing the keybindings in the
widget-keymap, such a= s here: h= ttps://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D23571

I investiga= ted the emacs sources, and have noticed that this patch could cause
prob= lems with three pieces of code:

1) recentf.el: Because of Bug#22434,= puts a nil :follow-link property to the
link widget. =C2=A0https://debbugs.gnu.o= rg/cgi/bugreport.cgi?bug=3D22434
The patch would make that mouse-1 i= sn't translated to mouse-2, but since this
was a workaround, changin= g this code would be OK, I think.=C2=A0 Without
overriding :follow-link,= I have checked that recentf.el works like it should,
with this patch ap= plied.

2) epa.el: Typing M-x epa-encrypt-file brings up a *Keys* buf= fer.=C2=A0 This buffer
has clickable text: [Cancel] and [OK].=C2=A0 The = epa code create this as a link
widget, and when mouse-1-click-follo= ws-link is nil, this text becomes not
responsive with mouse-= 1.=C2=A0 I'd say this are more buttons than links,
so a fix f= or it (if it is considered it needs fixing) would be to turn them into
push-button widgets.

3) mh-mime.el: I have never used MH= -E.=C2=A0 But there is some code in mh-mime.el
that creates a link widge= t, with an action mh-widget-press-button, and it
looks like it has a key= map of its own.=C2=A0 I don't know if the behavior could
change here= .

I haven't found any other code in the Emacs sources that could= have problems.
And fixing this would make code that depends on the link= widgets to behave as
expected, when mouse-1-click-follows-link is custo= mized to a nil value.=C2=A0 So I
think it would be good to fix this.
=
[1] https://lists.gnu.org/archive/html/emacs-devel/2008-03/msg013= 12.html

--000000000000549e400590ced6c6-- --000000000000549e420590ced6c8 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-link-widgets-obey-mouse-1-click-follows-link.patch" Content-Disposition: attachment; filename="0001-Make-link-widgets-obey-mouse-1-click-follows-link.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzokut0o0 RnJvbSBkNDBmOGExZmEzMGZjYzY3NDQ0YjZhZmZmZDgxNDlkOWU5YjlhZjFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFR1ZSwgMjAgQXVnIDIwMTkgMjA6MzI6NDEgLTAzMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIGxpbmsgd2lkZ2V0cyBvYmV5IG1vdXNlLTEtY2xpY2stZm9sbG93cy1saW5rCgoqIGxpc3Av d2lkLWVkaXQuZWwgKHdpZGdldC1saW5rLWtleW1hcCk6IE5ldyB2YXJpYWJsZSwgYSBrZXltYXAg dG8gdXNlCmluc2lkZSBhIGxpbmsgd2lkZ2V0LgooJ2xpbmsgd2lkZ2V0KTogUmVzdG9yZSB0aGUg OmZvbGxvdy1saW5rIHByb3BlcnR5IGFuZCBhZGQgd2lkZ2V0LWxpbmsta2V5bWFwCmFzIHRoZSA6 a2V5bWFwIHByb3BlcnR5LiAgKEJ1ZyMxNTY4MikKLS0tCiBsaXNwL3dpZC1lZGl0LmVsIHwgMTkg KysrKysrKysrKysrLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC93aWQtZWRpdC5lbCBiL2xpc3Avd2lkLWVk aXQuZWwKaW5kZXggZGQwM2EyNC4uMWRkYzQ2MSAxMDA2NDQKLS0tIGEvbGlzcC93aWQtZWRpdC5l bAorKysgYi9saXNwL3dpZC1lZGl0LmVsCkBAIC0xNzkwLDE3ICsxNzkwLDIyIEBAIHdpZGdldC1s aW5rLXN1ZmZpeAogICA6dHlwZSAnc3RyaW5nCiAgIDpncm91cCAnd2lkZ2V0LWJ1dHRvbikKIAor KGRlZnZhciB3aWRnZXQtbGluay1rZXltYXAKKyAgKGxldCAoKG1hcCAoY29weS1rZXltYXAgd2lk Z2V0LWtleW1hcCkpKQorICAgIDs7IE9ubHkgYmluZCBtb3VzZS0yLCBzaW5jZSBtb3VzZS0xIHdp bGwgYmUgdHJhbnNsYXRlZCBhY2NvcmRpbmdseSB0bworICAgIDs7IHRoZSBjdXN0b21pemF0aW9u IG9mIGBtb3VzZS0xLWNsaWNrLWZvbGxvd3MtbGluaycuCisgICAgKGRlZmluZS1rZXkgbWFwIFtk b3duLW1vdXNlLTFdIChsb29rdXAta2V5IHdpZGdldC1nbG9iYWwtbWFwIFtkb3duLW1vdXNlLTFd KSkKKyAgICAoZGVmaW5lLWtleSBtYXAgW2Rvd24tbW91c2UtMl0gJ3dpZGdldC1idXR0b24tY2xp Y2spCisgICAgKGRlZmluZS1rZXkgbWFwIFttb3VzZS0yXSAnd2lkZ2V0LWJ1dHRvbi1jbGljaykK KyAgICBtYXApCisgICJLZXltYXAgdXNlZCBpbnNpZGUgYSBsaW5rIHdpZGdldC4iKQorCiAoZGVm aW5lLXdpZGdldCAnbGluayAnaXRlbQogICAiQW4gZW1iZWRkZWQgbGluay4iCiAgIDpidXR0b24t cHJlZml4ICd3aWRnZXQtbGluay1wcmVmaXgKICAgOmJ1dHRvbi1zdWZmaXggJ3dpZGdldC1saW5r LXN1ZmZpeAotICA7OyBUaGUgYGZvbGxvdy1saW5rJyBwcm9wZXJ0eSBzaG91bGQgb25seSBiZSB1 c2VkIGluIHRob3NlIGNvbnRleHRzIHdoZXJlIHRoZQotICA7OyBtb3VzZS0xIGV2ZW50IG5vcm1h bGx5IGRvZXNuJ3QgZm9sbG93IHRoZSBsaW5rLCB5ZXQgdGhlIGBsaW5rJyB3aWRnZXQKLSAgOzsg c2VlbXMgdG8gYWxtb3N0IGFsd2F5cyBiZSB1c2VkIGluIGNvbnRleHRzIHdoZXJlIChkb3duLSlt b3VzZS0xIGlzIGJvdW5kCi0gIDs7IHRvIGB3aWRnZXQtYnV0dG9uLWNsaWNrJyBhbmQgaGVuY2Ug dGhlICJtb3VzZS0xIHRvIG1vdXNlLTIiIHJlbWFwcGluZyBpcwotICA7OyBub3QgbmVjZXNzYXJ5 IChhbmQgY2FuIGV2ZW4gYmUgaGFybWZ1bCkuICBTbyBsZXQncyBub3QgYWRkIGEgOmZvbGxvdy1s aW5rCi0gIDs7IGJ5IGRlZmF1bHQuICBTZWUgKGJ1ZyMyMjQzNCkuCi0gIDs7IDpmb2xsb3ctbGlu ayAnbW91c2UtZmFjZQorICA6Zm9sbG93LWxpbmsgJ21vdXNlLWZhY2UKKyAgOmtleW1hcCB3aWRn ZXQtbGluay1rZXltYXAKICAgOmhlbHAtZWNobyAiRm9sbG93IHRoZSBsaW5rLiIKICAgOmZvcm1h dCAiJVsldCVdIikKIAotLSAKMi43LjQKCg== --000000000000549e420590ced6c8-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 01:47:08 2019 Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 05:47:08 +0000 Received: from localhost ([127.0.0.1]:43463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1lMq-00087E-8F for submit@debbugs.gnu.org; Sun, 25 Aug 2019 01:47:08 -0400 Received: from quimby.gnus.org ([80.91.231.51]:57834) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1lMo-00085d-C1 for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 01:47:06 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1lMk-0001XY-L7; Sun, 25 Aug 2019 07:47:05 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: Date: Sun, 25 Aug 2019 07:47:02 +0200 In-Reply-To: (Mauro Aranda's message of "Fri, 23 Aug 2019 17:41:45 -0300") Message-ID: <8736hpajah.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > The attached patch tries to fix this bug, while trying to not change > too much of the code of the widget library. It introduces a keymap > for the link widgets, and only binds mouse-2 events. Since [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > The attached patch tries to fix this bug, while trying to not change > too much of the code of the widget library. It introduces a keymap > for the link widgets, and only binds mouse-2 events. Since > widget-button-click isn't changed, it has to bind down-mouse-2 too. > In this fix, I also have been careful to not reintroduce bugs that > have come up by changing the keybindings in the widget-keymap, such as > here: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=23571 I think this makes sense. > I investigated the emacs sources, and have noticed that this patch could cause > problems with three pieces of code: Would it be possible for you to come up with patches for fixing these three pieces, too? And then we could apply all four patches at the same time and not break anything. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 11:07:36 2019 Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 15:07:36 +0000 Received: from localhost ([127.0.0.1]:44966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1u7E-0001I2-46 for submit@debbugs.gnu.org; Sun, 25 Aug 2019 11:07:36 -0400 Received: from mail-lf1-f52.google.com ([209.85.167.52]:45748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1u7B-0001Hp-Gy for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 11:07:34 -0400 Received: by mail-lf1-f52.google.com with SMTP id o11so1071587lfb.12 for <15682@debbugs.gnu.org>; Sun, 25 Aug 2019 08:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AXZPakLmb3j7ChgU3bCPWakyPZ8VCizjt7GrOWTjKhQ=; b=VT3eUfgqxd/ZNxsTzVUvwp4w75RtvG0kRtL5/YqKUmGaNQ7nc3g6ZJ3BFVlCMZBKF5 tcIYiXGivgMwnqZyYGxlgVH0/xocnSyEkaDa+2P9WrvGwlt1Bdo9TXI87UabYyj+vQOR 4XzDxOoqKf5QbmR0kCfOr1JA4YhkpsOmCB/rQH8db8szEz9Npt2SJOdCoc2t5JJBbuf4 0YE3VUDoLUXHwYZouO9g0GRedM+XMmYy9t8br12UuxZtMfjQ3KoVV8ywpBxBNJFZRBoC tDJ/2wcXS/t6Wf6hYMXPWrDusHYPQH7l+zd6turYFtj6qVxL9iEHhomtfXIofTQWHgmV zhCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AXZPakLmb3j7ChgU3bCPWakyPZ8VCizjt7GrOWTjKhQ=; b=PAZct+s9CMXQLFUfbasUYOVa1HxUAUAkjwbYMYbNaCrNhDgczWB88aDyAFB8h02ngD k9lNGRq8SFWOUecFKlI8P2oZWS12JL4puB8FoV4eBENaqS0dfMKD9Nc4+YkOjG4JZ6Y8 Ky7xZVWnYKzdJzXpxSlX7cS11SVGCsdTzQVkvPgTtin1Et2acVQd9U+LYcZK5bltncI+ 9nQqFLa5FHzISptOyWVPZ5T2w1eYwNw/GJIinbQW5hmNFWRCAooSVNMHwsE08YUHiiQf IALfCNuj3cNZ/tjnmbshoy96tZUpuCBd7trR4hqJSAAIR1jNqkmm44J8aYlVctiZUOR3 IrEQ== X-Gm-Message-State: APjAAAX9s+JYGg+w4pCEg4U74gp7cz1aDsXgkzqY4V5fFTWrsu/Qp+X4 4yDoNzHNmjDmH3W/Uayn89HxCoGC70gqWqmb6Xo= X-Google-Smtp-Source: APXvYqw2KYc1bySWV1Y+qAZnzQpqKUUYo+UR90n8taI4VGXKccNqk8spdFzSVzPrfxSEwkxUycWBmeHEfTEe49jgTHM= X-Received: by 2002:a19:e204:: with SMTP id z4mr881525lfg.157.1566745647545; Sun, 25 Aug 2019 08:07:27 -0700 (PDT) MIME-Version: 1.0 References: <8736hpajah.fsf@gnus.org> In-Reply-To: <8736hpajah.fsf@gnus.org> From: Mauro Aranda Date: Sun, 25 Aug 2019 12:07:14 -0300 Message-ID: Subject: Re: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' To: Lars Ingebrigtsen Content-Type: multipart/mixed; boundary="000000000000c71af60590f265e7" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c71af60590f265e7 Content-Type: multipart/alternative; boundary="000000000000c71af40590f265e5" --000000000000c71af40590f265e5 Content-Type: text/plain; charset="UTF-8" Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> I investigated the emacs sources, and have noticed that this patch could cause >> problems with three pieces of code: > > Would it be possible for you to come up with patches for fixing these > three pieces, too? And then we could apply all four patches at the same > time and not break anything. Sure. I attach 3 patches. The same one I attached in my previous message, one patch for recentf.el and one patch for epa.el. I tried MH-E, to test the mh-mime.el code, and doesn't seem to misbehave with the change in wid-edit.el, so I didn't touch it. Best regards, Mauro. --000000000000c71af40590f265e5 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Lars Ingebrigtsen <la= rsi@gnus.org> writes:

> Mauro Aranda <maurooaranda@gmail.com> writes:
>
= >> I investigated the emacs sources, and have noticed that this patch= could cause
>> problems with three pieces of code:
>
>= ; Would it be possible for you to come up with patches for fixing these
= > three pieces, too?=C2=A0 And then we could apply all four patches at t= he same
> time and not break anything.

Sure.=C2=A0 I attach 3 = patches.=C2=A0 The same one I attached in my previous
message, one patch= for recentf.el and one patch for epa.el.

I tried MH-E, to test the = mh-mime.el code, and doesn't seem to misbehave
with the change in wi= d-edit.el, so I didn't touch it.

Best regards,
Mauro.
--000000000000c71af40590f265e5-- --000000000000c71af60590f265e7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Make-link-widgets-obey-mouse-1-click-follows-link.patch" Content-Disposition: attachment; filename="0001-Make-link-widgets-obey-mouse-1-click-follows-link.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzr3umvg0 RnJvbSA1ODNjZGU2NWIwMzc3ZTU2YzcxODYzNTQ1NzFjY2UyMjZlODI3Y2M1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFR1ZSwgMjAgQXVnIDIwMTkgMjA6MzI6NDEgLTAzMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIGxpbmsgd2lkZ2V0cyBvYmV5IG1vdXNlLTEtY2xpY2stZm9sbG93cy1saW5rCgoqIGxpc3Av d2lkLWVkaXQuZWwgKHdpZGdldC1saW5rLWtleW1hcCk6IE5ldyB2YXJpYWJsZSwgYSBrZXltYXAg dG8gdXNlCmluc2lkZSBhIGxpbmsgd2lkZ2V0LgooJ2xpbmsgd2lkZ2V0KTogUmVzdG9yZSB0aGUg OmZvbGxvdy1saW5rIHByb3BlcnR5IGFuZCBhZGQKd2lkZ2V0LWxpbmsta2V5bWFwIGFzIHRoZSA6 a2V5bWFwIHByb3BlcnR5LiAgKEJ1ZyMxNTY4MikKLS0tCiBsaXNwL3dpZC1lZGl0LmVsIHwgMTkg KysrKysrKysrKysrLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC93aWQtZWRpdC5lbCBiL2xpc3Avd2lkLWVk aXQuZWwKaW5kZXggZGQwM2EyNC4uMWRkYzQ2MSAxMDA2NDQKLS0tIGEvbGlzcC93aWQtZWRpdC5l bAorKysgYi9saXNwL3dpZC1lZGl0LmVsCkBAIC0xNzkwLDE3ICsxNzkwLDIyIEBAIHdpZGdldC1s aW5rLXN1ZmZpeAogICA6dHlwZSAnc3RyaW5nCiAgIDpncm91cCAnd2lkZ2V0LWJ1dHRvbikKIAor KGRlZnZhciB3aWRnZXQtbGluay1rZXltYXAKKyAgKGxldCAoKG1hcCAoY29weS1rZXltYXAgd2lk Z2V0LWtleW1hcCkpKQorICAgIDs7IE9ubHkgYmluZCBtb3VzZS0yLCBzaW5jZSBtb3VzZS0xIHdp bGwgYmUgdHJhbnNsYXRlZCBhY2NvcmRpbmdseSB0bworICAgIDs7IHRoZSBjdXN0b21pemF0aW9u IG9mIGBtb3VzZS0xLWNsaWNrLWZvbGxvd3MtbGluaycuCisgICAgKGRlZmluZS1rZXkgbWFwIFtk b3duLW1vdXNlLTFdIChsb29rdXAta2V5IHdpZGdldC1nbG9iYWwtbWFwIFtkb3duLW1vdXNlLTFd KSkKKyAgICAoZGVmaW5lLWtleSBtYXAgW2Rvd24tbW91c2UtMl0gJ3dpZGdldC1idXR0b24tY2xp Y2spCisgICAgKGRlZmluZS1rZXkgbWFwIFttb3VzZS0yXSAnd2lkZ2V0LWJ1dHRvbi1jbGljaykK KyAgICBtYXApCisgICJLZXltYXAgdXNlZCBpbnNpZGUgYSBsaW5rIHdpZGdldC4iKQorCiAoZGVm aW5lLXdpZGdldCAnbGluayAnaXRlbQogICAiQW4gZW1iZWRkZWQgbGluay4iCiAgIDpidXR0b24t cHJlZml4ICd3aWRnZXQtbGluay1wcmVmaXgKICAgOmJ1dHRvbi1zdWZmaXggJ3dpZGdldC1saW5r LXN1ZmZpeAotICA7OyBUaGUgYGZvbGxvdy1saW5rJyBwcm9wZXJ0eSBzaG91bGQgb25seSBiZSB1 c2VkIGluIHRob3NlIGNvbnRleHRzIHdoZXJlIHRoZQotICA7OyBtb3VzZS0xIGV2ZW50IG5vcm1h bGx5IGRvZXNuJ3QgZm9sbG93IHRoZSBsaW5rLCB5ZXQgdGhlIGBsaW5rJyB3aWRnZXQKLSAgOzsg c2VlbXMgdG8gYWxtb3N0IGFsd2F5cyBiZSB1c2VkIGluIGNvbnRleHRzIHdoZXJlIChkb3duLSlt b3VzZS0xIGlzIGJvdW5kCi0gIDs7IHRvIGB3aWRnZXQtYnV0dG9uLWNsaWNrJyBhbmQgaGVuY2Ug dGhlICJtb3VzZS0xIHRvIG1vdXNlLTIiIHJlbWFwcGluZyBpcwotICA7OyBub3QgbmVjZXNzYXJ5 IChhbmQgY2FuIGV2ZW4gYmUgaGFybWZ1bCkuICBTbyBsZXQncyBub3QgYWRkIGEgOmZvbGxvdy1s aW5rCi0gIDs7IGJ5IGRlZmF1bHQuICBTZWUgKGJ1ZyMyMjQzNCkuCi0gIDs7IDpmb2xsb3ctbGlu ayAnbW91c2UtZmFjZQorICA6Zm9sbG93LWxpbmsgJ21vdXNlLWZhY2UKKyAgOmtleW1hcCB3aWRn ZXQtbGluay1rZXltYXAKICAgOmhlbHAtZWNobyAiRm9sbG93IHRoZSBsaW5rLiIKICAgOmZvcm1h dCAiJVsldCVdIikKIAotLSAKMi43LjQKCg== --000000000000c71af60590f265e7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Adapt-recentf.el-to-the-change-in-the-Widget-Library.patch" Content-Disposition: attachment; filename="0001-Adapt-recentf.el-to-the-change-in-the-Widget-Library.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzr3uu6d1 RnJvbSA5OGE0ZjI0YjBiYzg1YzViYzNmNzQ5YTEzYjUxYjhkZTM1NzIwYzJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFN1biwgMjUgQXVnIDIwMTkgMTE6Mzc6MTYgLTAzMDAKU3ViamVjdDogW1BBVENIXSBB ZGFwdCByZWNlbnRmLmVsIHRvIHRoZSBjaGFuZ2UgaW4gdGhlIFdpZGdldCBMaWJyYXJ5CgoqIGxp c3AvcmVjZW50Zi5lbCAocmVjZW50Zi1vcGVuLWZpbGVzLWl0ZW0pOiBTdG9wIG92ZXJyaWRpbmcK OmZvbGxvdy1saW5rIHByb3BlcnR5IG9mIHRoZSBsaW5rIHdpZGdldHMsIHNpbmNlIG5vdyBpdCBz aG91bGQgd29yayBhcwpleHBlY3RlZC4KLS0tCiBsaXNwL3JlY2VudGYuZWwgfCAzIC0tLQogMSBm aWxlIGNoYW5nZWQsIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9yZWNlbnRmLmVs IGIvbGlzcC9yZWNlbnRmLmVsCmluZGV4IDQxMTJiNDQuLjI3MjAyODYgMTAwNjQ0Ci0tLSBhL2xp c3AvcmVjZW50Zi5lbAorKysgYi9saXNwL3JlY2VudGYuZWwKQEAgLTExODQsOSArMTE4NCw2IEBA IHJlY2VudGYtb3Blbi1maWxlcy1pdGVtCiAgICAgICAgICAgIDpmb3JtYXQgIiVbJXRcbiVdIgog ICAgICAgICAgICA6aGVscC1lY2hvICwoY29uY2F0ICJPcGVuICIgKGNkciBtZW51LWVsZW1lbnQp KQogICAgICAgICAgICA6YWN0aW9uIHJlY2VudGYtb3Blbi1maWxlcy1hY3Rpb24KLSAgICAgICAg ICAgOzsgT3ZlcnJpZGUgdGhlIChwcm9ibGVtYXRpYykgZm9sbG93LWxpbmsgcHJvcGVydHkgb2Yg dGhlCi0gICAgICAgICAgIDs7IGBsaW5rJyB3aWRnZXQgKGJ1ZyMyMjQzNCkuCi0gICAgICAgICAg IDpmb2xsb3ctbGluayBuaWwKICAgICAgICAgICAgLChjZHIgbWVudS1lbGVtZW50KSkpKQogCiAo ZGVmdW4gcmVjZW50Zi1vcGVuLWZpbGVzLWl0ZW1zIChmaWxlcykKLS0gCjIuNy40Cgo= --000000000000c71af60590f265e7 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Create-push-button-widgets-instead-of-links-in-epa-K.patch" Content-Disposition: attachment; filename="0001-Create-push-button-widgets-instead-of-links-in-epa-K.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzr3uzm72 RnJvbSA0Y2MwNmY3ZWM2ZTAyOWFjNWNjMzFkMWRjNDRlNWY5NTA5NTc0NDFlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IFN1biwgMjUgQXVnIDIwMTkgMTE6MzM6NTQgLTAzMDAKU3ViamVjdDogW1BBVENIXSBD cmVhdGUgcHVzaC1idXR0b24gd2lkZ2V0cyBpbnN0ZWFkIG9mIGxpbmtzIGluIGVwYSAqS2V5cyoK IGJ1ZmZlcgoKKiBsaXNwL2VwYS5lbCAoZXBhLS1zZWxlY3Qta2V5cyk6IE9LIGFuZCBDYW5jZWwg c2hvdWxkIGJlIGJ1dHRvbnMuCi0tLQogbGlzcC9lcGEuZWwgfCA0ICsrLS0KIDEgZmlsZSBjaGFu Z2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9l cGEuZWwgYi9saXNwL2VwYS5lbAppbmRleCA5ZTZlZGY0Li5iNTVhNTVmIDEwMDY0NAotLS0gYS9s aXNwL2VwYS5lbAorKysgYi9saXNwL2VwYS5lbApAQCAtNDQwLDEyICs0NDAsMTIgQEAgZXBhLS1z ZWxlY3Qta2V5cwogCSAgICAgIChzdWJzdGl0dXRlLWNvbW1hbmQta2V5cyAiXAogLSBgXFxbZXBh LW1hcmsta2V5XScgdG8gbWFyayBhIGtleSBvbiB0aGUgbGluZQogLSBgXFxbZXBhLXVubWFyay1r ZXldJyB0byB1bm1hcmsgYSBrZXkgb24gdGhlIGxpbmVcbiIpKQotICAgICAgKHdpZGdldC1jcmVh dGUgJ2xpbmsKKyAgICAgICh3aWRnZXQtY3JlYXRlICdwdXNoLWJ1dHRvbgogCQkgICAgIDpub3Rp ZnkgKGxhbWJkYSAoJnJlc3QgX2lnbm9yZSkgKGFib3J0LXJlY3Vyc2l2ZS1lZGl0KSkKIAkJICAg ICA6aGVscC1lY2hvCiAJCSAgICAgIkNsaWNrIGhlcmUgb3IgXFxbYWJvcnQtcmVjdXJzaXZlLWVk aXRdIHRvIGNhbmNlbCIKIAkJICAgICAiQ2FuY2VsIikKLSAgICAgICh3aWRnZXQtY3JlYXRlICds aW5rCisgICAgICAod2lkZ2V0LWNyZWF0ZSAncHVzaC1idXR0b24KIAkJICAgICA6bm90aWZ5IChs YW1iZGEgKCZyZXN0IF9pZ25vcmUpIChleGl0LXJlY3Vyc2l2ZS1lZGl0KSkKIAkJICAgICA6aGVs cC1lY2hvCiAJCSAgICAgIkNsaWNrIGhlcmUgb3IgXFxbZXhpdC1yZWN1cnNpdmUtZWRpdF0gdG8g ZmluaXNoIgotLSAKMi43LjQKCg== --000000000000c71af60590f265e7-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 12:19:34 2019 Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 16:19:34 +0000 Received: from localhost ([127.0.0.1]:45006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vEr-000379-BK for submit@debbugs.gnu.org; Sun, 25 Aug 2019 12:19:34 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:50738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vEp-00036w-SB for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 12:19:32 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7PGIfxZ164272; Sun, 25 Aug 2019 16:19:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=2804tuAY8sUrVRTa/CZZ5ln5s8G0iNx9bA/zogjKzPg=; b=pNLON7Y6IFdV1+Y2KRqTc9c0fhkQp8xtyO0jBOUB11ZWvUR4cGbaOSluiAHcjzpazzny /3m8s2oulmuaUuHeOpLO4b99DcbeDNR0vm4Z1CzRtQL+akYR6r4l6J2wdcxp/EbIcTUL BvI3f7PLGVpslRa3bvpAZxwRmBVFVBkdtmx2YBNoyq+wm+qrNnNsWw+wQEHUh8yn9DbK T8XBtz1YKr3yQajXNSYUMHNEd+dmXmZchnyqCSJ47AAc4wQ9TQ8hBZC6PkB+cp8SLYSx xYGxsvjpFOTfLkUAuJgdCRDqGrymo00h7dUjEUPlKlRXMYrJ48B25wxAwHamgp0M3R0d qQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2ujwvq4fxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Aug 2019 16:19:26 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7PGIWZ5044630; Sun, 25 Aug 2019 16:19:25 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userp3020.oracle.com with ESMTP id 2ujw6gwbp0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Aug 2019 16:19:25 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7PGJO5K017085; Sun, 25 Aug 2019 16:19:24 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 25 Aug 2019 09:19:23 -0700 (PDT) From: Drew Adams To: Mauro Aranda , Lars Ingebrigtsen Subject: RE: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <8736hpajah.fsf@gnus.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=771 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908250182 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=840 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908250182 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) What happened to the bug # in the Subject line? Please restore it. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 12:23:04 2019 Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 16:23:04 +0000 Received: from localhost ([127.0.0.1]:45013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vIG-0003Dj-4F for submit@debbugs.gnu.org; Sun, 25 Aug 2019 12:23:04 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:39322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vIE-0003D2-H4 for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 12:23:03 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7PGIhor172694; Sun, 25 Aug 2019 16:22:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=7WVxCIKJG12YTkZHETxhw58Fir/WCPCXQwFkDcblMro=; b=M6hd7aUw5iIdqIJrkmOn5CSm3GXah2R5u+Qk9ywTYGwjffTKU6O/Re4kPwKAZ9Cp+FPP CPQh5sw/DpUovNMAJaHI/WCphsTlEWq5P7MrvlVXkGpOeeNzrzhUCRtLyy4duL+Dc0fM ujiUrWva3a7NRDYkTh4yGyMXNSsqV5Ac442EzTryv6HZNgUn3xlo7siSF8S1sAZLDEP8 He2rIYlpHsVHMLpM0iDrkLnDCUIHqAdYin+0x5capQeYh+j4Ppb8xfARWxrSdGovFfuB swOetk/K3qxfMkCETBJosba1z2p49jPbUeom3cN4wQaKLP13AvPTqYdSLbXDI+tlgFhY Sg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2ujw6yvkkh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Aug 2019 16:22:56 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7PGHpZB157623; Sun, 25 Aug 2019 16:22:56 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 2ujw6u19xn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 25 Aug 2019 16:22:55 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x7PGMtg2006072; Sun, 25 Aug 2019 16:22:55 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 25 Aug 2019 09:22:54 -0700 (PDT) From: Drew Adams To: Mauro Aranda , Lars Ingebrigtsen Subject: RE: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <8736hpajah.fsf@gnus.org> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908250182 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9360 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908250182 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > What happened to the bug # in the Subject line? > Please restore it. Hm. I see it got restored by my reply. Why was it missing from Mauro's and Lars's mails? E.g.: > From: Lars Ingebrigtsen > Sent: Saturday, August 24, 2019 10:47 PM > To: Mauro Aranda > Cc: 15682@debbugs.gnu.org; Drew Adams > Subject: Re: 24.3.50; `:link' in `defgroup' does not respect `mouse-1- > click-follows-link' From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 12:41:30 2019 Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 16:41:30 +0000 Received: from localhost ([127.0.0.1]:45029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1va6-0003s4-HF for submit@debbugs.gnu.org; Sun, 25 Aug 2019 12:41:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55574) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1va5-0003ro-5r for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 12:41:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52043) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1i1vZz-0004Ug-J1; Sun, 25 Aug 2019 12:41:23 -0400 Received: from [176.228.60.248] (port=4411 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1i1vZy-0001lf-Ih; Sun, 25 Aug 2019 12:41:23 -0400 Date: Sun, 25 Aug 2019 19:41:21 +0300 Message-Id: <83d0gtgpu6.fsf@gnu.org> From: Eli Zaretskii To: Drew Adams In-reply-to: (message from Drew Adams on Sun, 25 Aug 2019 09:22:54 -0700 (PDT)) Subject: Re: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <8736hpajah.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, larsi@gnus.org, maurooaranda@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 25 Aug 2019 09:22:54 -0700 (PDT) > From: Drew Adams > Cc: 15682@debbugs.gnu.org > > > What happened to the bug # in the Subject line? > > Please restore it. > > Hm. I see it got restored by my reply. > Why was it missing from Mauro's and Lars's > mails? E.g.: > > > From: Lars Ingebrigtsen > > Sent: Saturday, August 24, 2019 10:47 PM > > To: Mauro Aranda > > Cc: 15682@debbugs.gnu.org; Drew Adams > > Subject: Re: 24.3.50; `:link' in `defgroup' does not respect `mouse-1- > > click-follows-link' You need to get a better email client. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 12:51:10 2019 Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 16:51:10 +0000 Received: from localhost ([127.0.0.1]:45035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vjS-00049R-Fb for submit@debbugs.gnu.org; Sun, 25 Aug 2019 12:51:10 -0400 Received: from mail-io1-f41.google.com ([209.85.166.41]:38349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vjP-00049A-4O for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 12:51:08 -0400 Received: by mail-io1-f41.google.com with SMTP id p12so31716727iog.5 for <15682@debbugs.gnu.org>; Sun, 25 Aug 2019 09:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version; bh=q2kI9c0oWDDeKAyDPg/xkB6NfBJLLMdHgPYJTDBCZzo=; b=c1e2YbHtPCpmokXViEQ6milsmVvlwgFO4TaDRCDZZVCmCCq4JyE5pa4llk0zEfHmBI BQojVYA6fcESS994wjOaeGNNnpNyS+iLFIRp6z6hCYRrFFkuWm22RA2A+gGMBo3eOnQY A6uevYqSA8Ts61L7WXaPXJsN/emL2BGinbU3+bz+IJV+I9aQPgAamdzsOrusHN5rHODO yRPWKASPaj5CgL4hO+rmHc2BvYkISA5dJv1LYDoiV93Q/gk+XKE1wSeRbbfGCXo0OZR9 lJlL6eoTRdn6TYwf9df81BYKzS3rrMdIFjERLvLVWj2yIR1z8ScaNAZaDUR5qXB2fwce 78uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version; bh=q2kI9c0oWDDeKAyDPg/xkB6NfBJLLMdHgPYJTDBCZzo=; b=Mq8l0i/kgzq2LjchyXCwVzvGBe2IHAQ/rHBJsPwalWpE2HEGpQJWy3vZEaJH6daVGy 1cqYynFsIqU8X8yZv2sdMIeMGWJujf5lCY5p/IzxhjHs8zSHLrQwX7jeSYuqRAIrSu79 PSUOrxwIkbNei1wNRrXfAZXy9F4GoH8uLAszL3cxC1xCAbKY8CJr5EeqVsaotfanxyxY SyJI92K5bvTJnrAbzDADKTmpjqxgqYNOblZ8W7p3HIsPg5YZ3THSAgzOxnWfV78V2V0y /xKkWJGtywYY3YDYVg3LvpBzLsbsQd5nvMyqAeGxxZ2ewJMZqb2kQs5Wbv9KWj6qec90 kiWg== X-Gm-Message-State: APjAAAWdV0fZ31wTgD8CEaIEbuOvnBOoBScqTpBaCEDmSiz+kHS0H0tR ERsBjO/Wi+k+soCXwHwqSTn9OBcV X-Google-Smtp-Source: APXvYqxuEL6bV1k2Dr54krOUdcI62sJQBU6OCG9yPVaZZIVVde4WCnT0tW0tkqFvYDeHfGR2YJTrqg== X-Received: by 2002:a02:5ec9:: with SMTP id h192mr9317555jab.25.1566751861323; Sun, 25 Aug 2019 09:51:01 -0700 (PDT) Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id k24sm6832368ioj.39.2019.08.25.09.51.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 25 Aug 2019 09:51:00 -0700 (PDT) From: Noam Postavsky To: Drew Adams Subject: Re: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' In-Reply-To: (Drew Adams's message of "Sun, 25 Aug 2019 09:22:54 -0700 (PDT)") References: <8736hpajah.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Date: Sun, 25 Aug 2019 12:50:59 -0400 Message-ID: <87sgppmbnw.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, Lars Ingebrigtsen , Mauro Aranda X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: >> What happened to the bug # in the Subject line? >> Please restore it. > > Hm. I see it got restored by my reply. > Why was it missing from Mauro's and Lars's > mails? E.g.: I guess Mauro just copied the subject from https://debbugs.gnu.org/15682#5, which doesn't include the bug number (because it shows mail as it was originally sent, before the bug number was assigned). When someone sends a message without the bug number to a nnnnn@debbugs.gnu.org address, the bug list mail server adds the bug number back; but if you're on Cc, then you'll get the message directly from the sender (i.e., not from the server, and so you won't see the number added back in. I think you would *also* get the message from the server with the bug number, but depending on your mail setup, it might get hidden/deleted as a duplicate). From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 25 12:58:52 2019 Received: (at 15682) by debbugs.gnu.org; 25 Aug 2019 16:58:52 +0000 Received: from localhost ([127.0.0.1]:45039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vqu-0004Kj-Bd for submit@debbugs.gnu.org; Sun, 25 Aug 2019 12:58:52 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:38045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1vqs-0004KU-OR for 15682@debbugs.gnu.org; Sun, 25 Aug 2019 12:58:51 -0400 Received: by mail-lj1-f170.google.com with SMTP id x3so12981529lji.5 for <15682@debbugs.gnu.org>; Sun, 25 Aug 2019 09:58:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rhA5yx12EwFi1rsQeP5DwBF+Y6MI+PaELMHcCmD9bms=; b=Vs3FE9b2MlcBblLyhGNVQ5zV3kNtzTxb+3mhEuQ4UEK0XAYkZvXJ1ChVhO0sNqnb6E KNwz1wROhTA0u5ZaNehayJIr9XIchkr8g3pXCqH0xPPzb339qphSXa0lK1weslozHqsz QAz94maCwFokYhxLo8GD1Quy0soUEVibH7lJEMN6ihOPcjfMY06s4z52TAU9CVlrMi+f VursnU1gMfZTBbhWRO/mOKy2a2a2i0pd0MkyND6lRGHoVH1g5yFidyo17opuUXQzvVKJ 8g56iVJku6ySfeJ4ue5dzCzvrX/7fKSIf+EK/LKCc1CuhFSF32DvcY/SwIL96JIFvmUA VLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rhA5yx12EwFi1rsQeP5DwBF+Y6MI+PaELMHcCmD9bms=; b=i678ELop13QVGualRZ2+L3+CSVOvVlAIxUtwAwUg9lFxXBVnttRTBNpd7zr1jjVXo6 rjlPP7L6cHWhOmxFdhz/jhq4itBDqXKxqjdwgO0+WeSqdt/Q6LrAfQL6bIK2SXusiiX4 TjsQVw1e4xGKyQvh8Z4nuFd9nRHISVCQts9CLR3zIaKbWGm6O38JdPQB0CTKF5rKcEWA EBTTSmGi06bcCyXrBqsdmi8turkx/DgNzoKcMMDrwfcIp0im3VxQ96vNKLvqGvITIGn1 cWUXBELcUmI4GtIEBKi9khBKeae6+IDgegbH0CaafVHb4XDGSMWYzoz31faUCBT9XfHa lbXw== X-Gm-Message-State: APjAAAWj0mn66ToNWLYj9pQtoAQMEmAbLq010oJ9Wd093qgZLgJ8QbwG Ly+8lWypzfL/DOqtjaWDvq2YyOeqBhYJvHdSJwju08QzTn8aSg== X-Google-Smtp-Source: APXvYqx5ueYPei4qe+JZA94VbEwvs3fv+zwia/0ICIJ1EzzUQ389/LuSx7xomzQHBS+nRuOxlGwoIAN8GcfCRahD3Dg= X-Received: by 2002:a05:651c:282:: with SMTP id b2mr8369289ljo.208.1566752324509; Sun, 25 Aug 2019 09:58:44 -0700 (PDT) MIME-Version: 1.0 References: <8736hpajah.fsf@gnus.org> <87sgppmbnw.fsf@gmail.com> In-Reply-To: <87sgppmbnw.fsf@gmail.com> From: Mauro Aranda Date: Sun, 25 Aug 2019 13:58:32 -0300 Message-ID: Subject: Re: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' To: 15682@debbugs.gnu.org Content-Type: multipart/alternative; boundary="000000000000c0e51e0590f3f3ac" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: Lars Ingebrigtsen , Noam Postavsky , Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000c0e51e0590f3f3ac Content-Type: text/plain; charset="UTF-8" Noam Postavsky writes: > Drew Adams writes: > >>> What happened to the bug # in the Subject line? >>> Please restore it. >> >> Hm. I see it got restored by my reply. >> Why was it missing from Mauro's and Lars's >> mails? E.g.: > > I guess Mauro just copied the subject from > https://debbugs.gnu.org/15682#5, which doesn't include the bug number > (because it shows mail as it was originally sent, before the bug number > was assigned). > That might be what happened. Sorry for the inconvenience. --000000000000c0e51e0590f3f3ac Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Noam Postavsky <n= postavs@gmail.com> writes:

> Drew Adams <drew.adams@oracle.com> writes:
>>>> What happened to the bug # in the Subject line?
>>&g= t; Please restore it.
>>
>> Hm. I see it got restored by = my reply.
>> Why was it missing from Mauro's and Lars's>> mails?=C2=A0 E.g.:
>
> I guess Mauro just copied the = subject from
> https://de= bbugs.gnu.org/15682#5, which doesn't include the bug number
>= (because it shows mail as it was originally sent, before the bug number> was assigned).
>

That might be what happened.

Sor= ry for the inconvenience.
--000000000000c0e51e0590f3f3ac-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 27 02:42:37 2019 Received: (at 15682) by debbugs.gnu.org; 27 Aug 2019 06:42:37 +0000 Received: from localhost ([127.0.0.1]:47533 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2VBd-0007cb-0j for submit@debbugs.gnu.org; Tue, 27 Aug 2019 02:42:37 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2VBb-0007cR-Qh for 15682@debbugs.gnu.org; Tue, 27 Aug 2019 02:42:36 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2VBX-0004Jd-HI; Tue, 27 Aug 2019 08:42:33 +0200 From: Lars Ingebrigtsen To: Mauro Aranda Subject: Re: bug#15682: 24.3.50; `:link' in `defgroup' does not respect `mouse-1-click-follows-link' References: <8736hpajah.fsf@gnus.org> Date: Tue, 27 Aug 2019 08:42:31 +0200 In-Reply-To: (Mauro Aranda's message of "Sun, 25 Aug 2019 12:07:14 -0300") Message-ID: <87blwb3y94.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > Sure. I attach 3 patches. The same one I attached in my previous > message, one patch for recentf.el and one patch for epa.el. > > I tried MH-E, to test the mh-mime.el code, and doesn't seem to misb [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15682 Cc: 15682@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > Sure. I attach 3 patches. The same one I attached in my previous > message, one patch for recentf.el and one patch for epa.el. > > I tried MH-E, to test the mh-mime.el code, and doesn't seem to misbehave > with the change in wid-edit.el, so I didn't touch it. Thanks; I've now applied all three patches to the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 27 02:42:42 2019 Received: (at control) by debbugs.gnu.org; 27 Aug 2019 06:42:42 +0000 Received: from localhost ([127.0.0.1]:47536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2VBi-0007cu-CN for submit@debbugs.gnu.org; Tue, 27 Aug 2019 02:42:42 -0400 Received: from quimby.gnus.org ([80.91.231.51]:37162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2VBg-0007cl-O1 for control@debbugs.gnu.org; Tue, 27 Aug 2019 02:42:40 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i2VBe-0004Jm-3U for control@debbugs.gnu.org; Tue, 27 Aug 2019 08:42:40 +0200 Date: Tue, 27 Aug 2019 08:42:37 +0200 Message-Id: <87a7bv3y8y.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #15682 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 15682 fixed close 15682 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 15682 fixed close 15682 27.1 quit From unknown Fri Jun 20 18:15:40 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 24 Sep 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator