From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 19 11:33:59 2013 Received: (at submit) by debbugs.gnu.org; 19 Oct 2013 15:33:59 +0000 Received: from localhost ([127.0.0.1]:58043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VXYXP-0006M6-5Q for submit@debbugs.gnu.org; Sat, 19 Oct 2013 11:33:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36446) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VXYXN-0006Lq-Ep for submit@debbugs.gnu.org; Sat, 19 Oct 2013 11:33:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VXYX8-0005qM-2p for submit@debbugs.gnu.org; Sat, 19 Oct 2013 11:33:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34149) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXYX7-0005qI-Vp for submit@debbugs.gnu.org; Sat, 19 Oct 2013 11:33:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXYWz-0007ZQ-Cf for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2013 11:33:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VXYWq-0005n1-QU for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2013 11:33:33 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VXYWq-0005mx-Ik for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2013 11:33:24 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9JFXMRZ019710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 19 Oct 2013 15:33:23 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9JFXLsq014814 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 19 Oct 2013 15:33:22 GMT Received: from abhmt117.oracle.com (abhmt117.oracle.com [141.146.116.69]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9JFXLOP028071 for ; Sat, 19 Oct 2013 15:33:21 GMT MIME-Version: 1.0 Message-ID: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> Date: Sat, 19 Oct 2013 08:33:20 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) `menu-bar-select-buffer' is defined in `menu-bar.el'. It used to be used there as well, in function `menu-bar-update-buffers'. Now, the latter function uses `menu-bar-select-buffer-function' instead (which makes no use of `menu-bar-select-buffer'). The only place `menu-bar-select-buffer' is used now is in `msb.el'. Why not remove `menu-bar-select-buffer' or move it to `msb.el'? In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-10-09 on LEG570 Bzr revision: 114596 jan.h.d@swipnet.se-20131009185014-vynfyw4o8p5fge54 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1' From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 29 10:00:26 2016 Received: (at 15651) by debbugs.gnu.org; 29 Apr 2016 14:00:26 +0000 Received: from localhost ([127.0.0.1]:55331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw8y1-0006oB-Oy for submit@debbugs.gnu.org; Fri, 29 Apr 2016 10:00:25 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:55739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aw8xz-0006lW-E4 for 15651@debbugs.gnu.org; Fri, 29 Apr 2016 10:00:23 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1aw8xo-0000gw-8m; Fri, 29 Apr 2016 16:00:22 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? References: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> Date: Fri, 29 Apr 2016 16:00:11 +0200 In-Reply-To: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> (Drew Adams's message of "Sat, 19 Oct 2013 08:33:20 -0700 (PDT)") Message-ID: <87mvoc7bx0.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15651 Cc: 15651@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > `menu-bar-select-buffer' is defined in `menu-bar.el'. It used to be > used there as well, in function `menu-bar-update-buffers'. > > Now, the latter function uses `menu-bar-select-buffer-function' instead > (which makes no use of `menu-bar-select-buffer'). The only place > `menu-bar-select-buffer' is used now is in `msb.el'. > > Why not remove `menu-bar-select-buffer' or move it to `msb.el'? Well, there may be third party usages of this very important function, I guess? (defun menu-bar-select-buffer () (interactive) (switch-to-buffer last-command-event)) And it's unclear whether it's used in msb.el. The only mention is: (defun msb--make-keymap-menu (raw-menu) (let ((end 'menu-bar-select-buffer) (mcount 0)) But it could be funcalled afterwards... the logic is unclear... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 01:50:07 2021 Received: (at 15651) by debbugs.gnu.org; 30 May 2021 05:50:07 +0000 Received: from localhost ([127.0.0.1]:58202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnEKt-0004GZ-IW for submit@debbugs.gnu.org; Sun, 30 May 2021 01:50:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45262) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnEKr-0004Fp-0e for 15651@debbugs.gnu.org; Sun, 30 May 2021 01:50:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=w+DSAgfWKOhj+m08eU1fr0IGZQqFuZhYudzCof8nm/c=; b=RGrVL21rn7ogvGXcBcAuPYoYIe d0V205Mi2IQ7qTT6Dju7PFNq6l0QnY4V3M5g71Bxusf7tqjqAsj70XWnABfKlQTLumkz+i4g9lfe4 FVHTaUdC3b135ruYzdM1h2rniNZbMMDz/YKbLV4SwMFUseQrBWbmiBQvXXoWgfm+rVxI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnEKi-0006q4-QQ; Sun, 30 May 2021 07:49:59 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? References: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> <87mvoc7bx0.fsf@gnus.org> X-Now-Playing: Alva Noto and Ryuichi Sakamoto's _Two_: "Morning (Live)" Date: Sun, 30 May 2021 07:49:56 +0200 In-Reply-To: <87mvoc7bx0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 29 Apr 2016 16:00:11 +0200") Message-ID: <87tumk3h4r.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> Why not remove `menu-bar-select-buffer' or move it to `msb.el'? > > Well, there may be third party usages of this very important function, I > guess? > > (defun menu-bar-select-buffer () > (interac [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15651 Cc: 15651@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> Why not remove `menu-bar-select-buffer' or move it to `msb.el'? > > Well, there may be third party usages of this very important function, I > guess? > > (defun menu-bar-select-buffer () > (interactive) > (switch-to-buffer last-command-event)) So moving it might break something for some users, but I think it's highly unlikely. So I've now moved it in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 01:50:15 2021 Received: (at control) by debbugs.gnu.org; 30 May 2021 05:50:15 +0000 Received: from localhost ([127.0.0.1]:58205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnEL0-0004Gz-OZ for submit@debbugs.gnu.org; Sun, 30 May 2021 01:50:14 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnEKz-0004Gh-Q0 for control@debbugs.gnu.org; Sun, 30 May 2021 01:50:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mgMUNmOpcRxV7fAxJF6Gs3HmI05d4g/JX/SBxDa6LG4=; b=TvHablqpxT5P8SOBdNtAL5TlRL 6TLCLgX5UqwsnFHDLLsE74n38lnRsBhzPiAh0IINbiWq+21N7XUlS0QV/60LUZxbRPOcc7kak3CNw Ji36aSEj0ESC05XbfFnjzlhBZs1yaLdkanAGkSIJUaQ6b24TblG8ovfREuLankn3BYj8=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnEKs-0006qM-CI for control@debbugs.gnu.org; Sun, 30 May 2021 07:50:08 +0200 Date: Sun, 30 May 2021 07:50:05 +0200 Message-Id: <87sg243h4i.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #15651 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 15651 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 15651 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 04:47:40 2021 Received: (at 15651) by debbugs.gnu.org; 30 May 2021 08:47:41 +0000 Received: from localhost ([127.0.0.1]:58395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnH6i-00036t-Nr for submit@debbugs.gnu.org; Sun, 30 May 2021 04:47:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48314) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnH6h-00036h-2y for 15651@debbugs.gnu.org; Sun, 30 May 2021 04:47:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35764) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnH6b-0005EL-P3; Sun, 30 May 2021 04:47:33 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2576 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnH6b-0007No-Bj; Sun, 30 May 2021 04:47:33 -0400 Date: Sun, 30 May 2021 11:47:45 +0300 Message-Id: <83k0ng4ngu.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87tumk3h4r.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 30 May 2021 07:49:56 +0200) Subject: Re: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? References: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> <87mvoc7bx0.fsf@gnus.org> <87tumk3h4r.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15651 Cc: 15651@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Sun, 30 May 2021 07:49:56 +0200 > Cc: 15651@debbugs.gnu.org > > Lars Ingebrigtsen writes: > > >> Why not remove `menu-bar-select-buffer' or move it to `msb.el'? > > > > Well, there may be third party usages of this very important function, I > > guess? > > > > (defun menu-bar-select-buffer () > > (interactive) > > (switch-to-buffer last-command-event)) > > So moving it might break something for some users, but I think it's > highly unlikely. So I've now moved it in Emacs 28. Should it be autoloaded now? menu-bar.el is preloaded, whereas msb.el isn't, so 3rd-party packages which expect the function to be available could be in trouble now. From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 05:37:35 2021 Received: (at 15651) by debbugs.gnu.org; 30 May 2021 09:37:35 +0000 Received: from localhost ([127.0.0.1]:58415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnHt1-0004Md-JP for submit@debbugs.gnu.org; Sun, 30 May 2021 05:37:35 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnHsw-0004MK-Jt for 15651@debbugs.gnu.org; Sun, 30 May 2021 05:37:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pZJfoAO35CHlN1k5Yadn9xFo96ZQIk81b1/27LIp2bY=; b=WiVp1yWdDO9f/RrtXsyNiUpBhp X4JajM1+G9svrec7moWjElb6brgsV4GGFbMgOZiLzQ/8l3//RpM2GTfvlrXHA8FQMDVPuhg+P+Ivu DqOBWAgEkqQ0okI9JJvYkRMsQKijTgvgW4e78rQxT6S7OLnb41FzAYgJab7loiCaoA+Y=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnHsn-0000VL-7Y; Sun, 30 May 2021 11:37:23 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? References: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> <87mvoc7bx0.fsf@gnus.org> <87tumk3h4r.fsf@gnus.org> <83k0ng4ngu.fsf@gnu.org> X-Now-Playing: After the Mountain Fire's _Sleep Deprivation_: "Satellite (Guster Cover)" Date: Sun, 30 May 2021 11:37:20 +0200 In-Reply-To: <83k0ng4ngu.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 May 2021 11:47:45 +0300") Message-ID: <87v970zhnz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> So moving it might break something for some users, but I think it's >> highly unlikely. So I've now moved it in Emacs 28. > > Should it be autoloaded now? menu-bar.el is preloaded, whereas msb.el > [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15651 Cc: 15651@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> So moving it might break something for some users, but I think it's >> highly unlikely. So I've now moved it in Emacs 28. > > Should it be autoloaded now? menu-bar.el is preloaded, whereas msb.el > isn't, so 3rd-party packages which expect the function to be available > could be in trouble now. We could do that, but since the command is so trivial (and undocumented and uncommented) that I find it unlikely that anybody is using it. But if that turns out to be the case, we should autoload it. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun May 30 06:01:58 2021 Received: (at 15651) by debbugs.gnu.org; 30 May 2021 10:01:58 +0000 Received: from localhost ([127.0.0.1]:58424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnIGb-0004ym-Sk for submit@debbugs.gnu.org; Sun, 30 May 2021 06:01:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnIGa-0004yZ-Fe for 15651@debbugs.gnu.org; Sun, 30 May 2021 06:01:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36720) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lnIGU-0004pv-Tk; Sun, 30 May 2021 06:01:50 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3267 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lnIGT-0004VK-U6; Sun, 30 May 2021 06:01:50 -0400 Date: Sun, 30 May 2021 13:02:01 +0300 Message-Id: <83czt84k12.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87v970zhnz.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 30 May 2021 11:37:20 +0200) Subject: Re: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? References: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> <87mvoc7bx0.fsf@gnus.org> <87tumk3h4r.fsf@gnus.org> <83k0ng4ngu.fsf@gnu.org> <87v970zhnz.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15651 Cc: 15651@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: drew.adams@oracle.com, 15651@debbugs.gnu.org > Date: Sun, 30 May 2021 11:37:20 +0200 > > Eli Zaretskii writes: > > >> So moving it might break something for some users, but I think it's > >> highly unlikely. So I've now moved it in Emacs 28. > > > > Should it be autoloaded now? menu-bar.el is preloaded, whereas msb.el > > isn't, so 3rd-party packages which expect the function to be available > > could be in trouble now. > > We could do that, but since the command is so trivial (and undocumented > and uncommented) that I find it unlikely that anybody is using it. > > But if that turns out to be the case, we should autoload it. I think we should autoload it without waiting for complaints. Autoloading one function has a negligible cost. From debbugs-submit-bounces@debbugs.gnu.org Mon May 31 01:31:39 2021 Received: (at 15651) by debbugs.gnu.org; 31 May 2021 05:31:39 +0000 Received: from localhost ([127.0.0.1]:60749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnaWZ-00061g-8m for submit@debbugs.gnu.org; Mon, 31 May 2021 01:31:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lnaWX-00061L-5S for 15651@debbugs.gnu.org; Mon, 31 May 2021 01:31:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xf5jxXYDEzPWbCWFxl518LVvnJ3Oo0AksmdV3YKSZU0=; b=VdGWDWGCmro22onAg/2vlrW3SW UxUxG/U5VbEP9NCUV1gLh4RHkQL9AGRn22rfx5hYUhYUAif+Z4nG0QW4wZRbayttqZWH75CqYPYxN FcdYLw1zhNWtsXnX4FMbYv5v1BiZPeMVzppKBbpuQxpNA6cS1JDbe7Rw7NnAGWavT6hI=; Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lnaWO-0005qf-DM; Mon, 31 May 2021 07:31:30 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#15651: 24.3.50; `menu-bar-select-buffer' - Remove it? Move it to msb.el? References: <6ecdc9dd-852f-4049-b484-a6702eff67b3@default> <87mvoc7bx0.fsf@gnus.org> <87tumk3h4r.fsf@gnus.org> <83k0ng4ngu.fsf@gnu.org> <87v970zhnz.fsf@gnus.org> <83czt84k12.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEUWEhJEOztlW1qG eneMgHzQw7+ompgsJib///9RCNRGAAAAAWJLR0QIht6VegAAAAd0SU1FB+UFHwUdOJti/kEAAAGB SURBVDjLlZLNUoMwEMeDOubKojNcJTjj1YGOD9AyvEE5Oy3Ea9bLvr7ZTUhbpH78Lwn7y36jVGYW atvWPCml7gbrNe0v9O7BjRX5r4gP9ji9JjAJkOPQW8uhbgUMU4woh4AY6lKXoOskGTuugGkFjLGK YT2HpP9j8iUY/g2uhfJjb/s1oJRGMPVbsPiRjb7PXCVpAihMUTe8q8axxWlSJMICvIoKDIMMkubl Ajipatx+NiFEUgD247zkbtN3uzxsMOcm4+7suOl2Au73+zwzddtJM/3o17INyTkiXxT6eoBTv6gf pQmdIkdYPR4qIOR+KFFCKOpW1ts82zgSlP4B0Gz4Bxv6NESf2vlo3qt6aIQec8lBbPUHcWG1qWvT MsgqKLXYS/+EV9A0RjxKQgSKcvwAIY4doZQiifjCjwSUyCHkvQwfZwDhoBmVyUMsM4mppEEh0ceF I4yDUtTZpNUpuO9kOV4X/egbUYlcYyH27zrz16GB9BUb0os0p1ZPtx/0BRDzCCYXISHNAAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIxLTA1LTMxVDA1OjI5OjU2KzAwOjAwSqpf2wAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMS0wNS0zMVQwNToyOTo1NiswMDowMDv352cAAAAASUVORK5CYII= X-Now-Playing: Scorn's _Cafe Mor_: "Elephant" Date: Mon, 31 May 2021 07:31:27 +0200 In-Reply-To: <83czt84k12.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 30 May 2021 13:02:01 +0300") Message-ID: <87y2bvlb9s.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think we should autoload it without waiting for complaints. > Autoloading one function has a negligible cost. What we wanted to achieve in this bug report was to remove a useless command from the preloaded namespace, so adding an autoload here doesn't really help with that. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15651 Cc: 15651@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I think we should autoload it without waiting for complaints. > Autoloading one function has a negligible cost. What we wanted to achieve in this bug report was to remove a useless command from the preloaded namespace, so adding an autoload here doesn't really help with that. So instead I reverted the patch, and I made the original command obsolete and added a private command to msb.el. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sat Jun 21 05:14:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 28 Jun 2021 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator