GNU bug report logs - #15618
24.3.50; Region face takes priority over any overlay faces inside?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15618 in the body.
You can then email your comments to 15618 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Region face takes priority over any overlay faces inside?
Date: Tue, 15 Oct 2013 06:53:56 +0300

I'm seeing inconsistent behavior with this.

There is an overlay inside the active region, it has a `face' property.
With default theme, the foreground and background attributes of that
face are never used, the values from `region' face are used.

But if I switch to another theme (e.g. M-x load-theme RET leuven), the
inner overlay becomes easily visible.

Backstory here: https://github.com/leoliu/easy-kill/issues/3

To reproduce:

1. Install `easy-mark' from https://github.com/leoliu/easy-kill.git
2. Open a buffer with some Elisp, move point to where some text is, type
`M-x easy-mark'.
3. Some part of the buffer becomes selected with an active region. The
previous position of point is marked by the "origin" overlay, with face
that's inheriting from `error'. However, the colors don't come through.

Here's how it looks for me: http://imgur.com/a/2VZyZ

Here's how it looks for Leo:
http://i.imgur.com/i8pxksI.png

This is also what I see (except for the exact colors) if I use one of
many other themes (such as leuven, adwaita, dichromacy).

Curiously, wheatgrass behaves the same as the default one in this
respect. And if I switch to wheatgrass and only then to leuven, then I
also see the same behavior there.

Which is the right behavior? Like I mentioned in the discussion there,
Displaying Faces[0] seems to indicate that `region' face should prevail
at all times.

[0] http://www.gnu.org/software/emacs/manual/html_node/elisp/Displaying-Faces.html

In GNU Emacs 24.3.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.6.4)
 of 2013-10-15 on axl
Bzr revision: 114665 dgutov <at> yandex.ru-20131015012122-lo6jx0rfcpjoi6ls
Windowing system distributor `The X.Org Foundation', version 11.0.11303000
System Description:	Ubuntu 13.04

Message #8 received at 15618 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 15618 <at> debbugs.gnu.org
Subject: Re: bug#15618: 24.3.50;
 Region face takes priority over any overlay faces inside?
Date: Wed, 16 Oct 2013 10:57:38 +0800

On 2013-10-15 11:53 +0800, Dmitry Gutov wrote:
> To reproduce:
>
> 1. Install `easy-mark' from https://github.com/leoliu/easy-kill.git
> 2. Open a buffer with some Elisp, move point to where some text is, type
> `M-x easy-mark'.
> 3. Some part of the buffer becomes selected with an active region. The
> previous position of point is marked by the "origin" overlay, with face
> that's inheriting from `error'. However, the colors don't come through.
>
> Here's how it looks for me: http://imgur.com/a/2VZyZ
>
> Here's how it looks for Leo:
> http://i.imgur.com/i8pxksI.png

I built emacs-trunk on centos 6.4 just now and still couldn't reproduce
the bug, sadly.

Leo

Message #11 received at 15618 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 15618 <at> debbugs.gnu.org
Subject: Re: bug#15618: 24.3.50;
 Region face takes priority over any overlay faces inside?
Date: Tue, 29 Oct 2013 13:30:22 -0400

> I'm seeing inconsistent behavior with this.

I just installed a patch which makes the region's highlight into
a plain-old overlay, so your problem is probably replaced by new ones ;-)


        Stefan

Message #16 received at 15618-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 15618-done <at> debbugs.gnu.org
Subject: Re: bug#15618: 24.3.50; Region face takes priority over any overlay
 faces inside?
Date: Wed, 30 Oct 2013 06:13:33 +0400

On 29.10.2013 21:30, Stefan Monnier wrote:
> I just installed a patch which makes the region's highlight into
> a plain-old overlay, so your problem is probably replaced by new ones ;-)

So far it seems fixed though. Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.