From unknown Wed Jun 18 23:09:39 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#15613 <15613@debbugs.gnu.org> To: bug#15613 <15613@debbugs.gnu.org> Subject: Status: Wrong indentation in Shell-script[sh] mode? Reply-To: bug#15613 <15613@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:09:39 +0000 retitle 15613 Wrong indentation in Shell-script[sh] mode? reassign 15613 emacs submitter 15613 Angelo Graziosi severity 15613 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 14 16:53:44 2013 Received: (at submit) by debbugs.gnu.org; 14 Oct 2013 20:53:44 +0000 Received: from localhost ([127.0.0.1]:49373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVp95-0001Wo-B6 for submit@debbugs.gnu.org; Mon, 14 Oct 2013 16:53:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45517) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VVp91-0001WT-Pk for submit@debbugs.gnu.org; Mon, 14 Oct 2013 16:53:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVp8o-0000Bb-Ix for submit@debbugs.gnu.org; Mon, 14 Oct 2013 16:53:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVp8o-0000BT-Fy for submit@debbugs.gnu.org; Mon, 14 Oct 2013 16:53:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47168) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVp8h-00065c-IF for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 16:53:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VVp8a-00008o-Vg for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 16:53:19 -0400 Received: from smtp203.alice.it ([82.57.200.99]:36890) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VVp8a-00008c-Nw for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 16:53:12 -0400 Received: from [192.168.1.100] (79.9.171.144) by smtp203.alice.it (8.6.060.28) (authenticated as angelo.graziosi@alice.it) id 52494B4301387FCA for bug-gnu-emacs@gnu.org; Mon, 14 Oct 2013 22:53:10 +0200 Message-ID: <525C59B0.7090804@alice.it> Date: Mon, 14 Oct 2013 22:53:04 +0200 From: Angelo Graziosi User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: bug-emacs Subject: Wrong indentation in Shell-script[sh] mode? Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In the current trunk the indentation for bash scripts looks as in this test case: $ cat test_indent.sh #!/bin/bash if [ "${foo_a}" != "${foo_b}" ]; then if [ "${foo_c}" = "${foo_d}" ]; then echo echo "Hello..." echo exit 1 fi fi The inner if-fi looks ok but in the outer one expects the last fi under the first if.. Or not? This happens with $ emacs -Q & and using TAB to indent.. Ciao, Angelo. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 10:37:47 2013 Received: (at 15613) by debbugs.gnu.org; 15 Oct 2013 14:37:47 +0000 Received: from localhost ([127.0.0.1]:51248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VW5ko-0007XY-Kj for submit@debbugs.gnu.org; Tue, 15 Oct 2013 10:37:47 -0400 Received: from relais.videotron.ca ([24.201.245.36]:23543) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VW5km-0007XQ-Pe for 15613@debbugs.gnu.org; Tue, 15 Oct 2013 10:37:45 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from ceviche.home ([24.201.53.56]) by VL-VM-MR006.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0MUP000R6SMWVBB0@VL-VM-MR006.ip.videotron.ca> for 15613@debbugs.gnu.org; Tue, 15 Oct 2013 10:37:44 -0400 (EDT) Received: by ceviche.home (Postfix, from userid 20848) id D4FCF6609A; Tue, 15 Oct 2013 10:37:44 -0400 (EDT) From: Stefan Monnier To: Angelo Graziosi Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? Message-id: References: <525C59B0.7090804@alice.it> Date: Tue, 15 Oct 2013 10:37:44 -0400 In-reply-to: <525C59B0.7090804@alice.it> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 15613 Cc: 15613@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > In the current trunk the indentation for bash scripts looks as in this test > case: > $ cat test_indent.sh > #!/bin/bash > if [ "${foo_a}" != "${foo_b}" ]; then > if [ "${foo_c}" = "${foo_d}" ]; then > echo > echo "Hello..." > echo > exit 1 > fi > fi This works correctly if you use (setq sh-use-smie t) which I recommend. It is currently not the default setting because it doesn't yet support all the indentation-config variables of the old indentation code, and doesn't support the "guess indentation settings" feature either. But in most other respects it should work "as well or better". Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 10:56:14 2013 Received: (at 15613) by debbugs.gnu.org; 15 Oct 2013 14:56:14 +0000 Received: from localhost ([127.0.0.1]:51323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VW62g-00082h-7D for submit@debbugs.gnu.org; Tue, 15 Oct 2013 10:56:14 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37215 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VW62e-00082Z-1k for 15613@debbugs.gnu.org; Tue, 15 Oct 2013 10:56:12 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VW62b-0004rh-Im; Tue, 15 Oct 2013 10:56:09 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? References: <525C59B0.7090804@alice.it> X-Spook: Nazi Ft. Bragg UFO Uzi Agfa INS data haven South Africa X-Ran: b]TT{a'"%q8J&K^.lh[\:fO}a7)Lh8$i13oF/Kt3:P,Ou=/iZ-lU_YJ+6'X7?HZk/`Ku6_ X-Hue: magenta X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 15 Oct 2013 10:56:09 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 15 Oct 2013 10:37:44 -0400") Message-ID: <6wsiw2zipi.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15613 Cc: 15613@debbugs.gnu.org, Angelo Graziosi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) Stefan Monnier wrote: > This works correctly if you use (setq sh-use-smie t) which I recommend. It works fine in 24.3 out-of-the-box. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 18:23:52 2013 Received: (at submit) by debbugs.gnu.org; 15 Oct 2013 22:23:52 +0000 Received: from localhost ([127.0.0.1]:52675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWD1r-0003lX-Hn for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:23:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60819) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWD1p-0003lH-PG for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:23:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWD1c-00061C-JX for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:23:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWD1c-000618-H6 for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:23:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWD1V-0005nJ-Uz for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2013 18:23:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWD1P-0005x6-7m for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2013 18:23:29 -0400 Received: from smtp203.alice.it ([82.57.200.99]:29516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWD1O-0005wb-Sw for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2013 18:23:23 -0400 Received: from [192.168.1.100] (95.246.9.207) by smtp203.alice.it (8.6.060.28) (authenticated as angelo.graziosi@alice.it) id 52494B43014EE2A1; Wed, 16 Oct 2013 00:23:18 +0200 Message-ID: <525DC053.9050601@alice.it> Date: Wed, 16 Oct 2013 00:23:15 +0200 From: Angelo Graziosi User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Stefan Monnier Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? References: <525C59B0.7090804@alice.it> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-emacs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Il 15/10/2013 16.37, Stefan Monnier ha scritto: >> In the current trunk the indentation for bash scripts looks as in this test >> case: > >> $ cat test_indent.sh >> #!/bin/bash > >> if [ "${foo_a}" != "${foo_b}" ]; then > >> if [ "${foo_c}" = "${foo_d}" ]; then >> echo >> echo "Hello..." >> echo >> exit 1 >> fi > >> fi > > This works correctly if you use (setq sh-use-smie t) which I recommend. > > It is currently not the default setting because it doesn't yet support > all the indentation-config variables of the old indentation code, and > doesn't support the "guess indentation settings" feature either. But in > most other respects it should work "as well or better". Why, by default, the last "fi" should be under the previous and not under _its_ "if"? Should "indent" mean that the matching if-fi, {-}, begin-end, if-endif etc. start the same column? Instead the test case shows that all statements after the first "if" if [ "${foo_a}" != "${foo_b}" ]; then are considered belonging to its block statements. All the next formatted code is lost. This should be called "regression".. Ciao, Angelo. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 15 18:26:56 2013 Received: (at submit) by debbugs.gnu.org; 15 Oct 2013 22:26:56 +0000 Received: from localhost ([127.0.0.1]:52688 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWD4p-0003qb-KQ for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:26:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWD4o-0003qQ-HO for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:26:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWD4Z-0007D9-Vi for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:26:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWD4Z-0007D5-SY for submit@debbugs.gnu.org; Tue, 15 Oct 2013 18:26:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35099) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWD4S-00069g-FE for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2013 18:26:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWD4L-0007BR-4x for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2013 18:26:32 -0400 Received: from smtp203.alice.it ([82.57.200.99]:30493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWD4C-00078M-TI; Tue, 15 Oct 2013 18:26:17 -0400 Received: from [192.168.1.100] (95.246.9.207) by smtp203.alice.it (8.6.060.28) (authenticated as angelo.graziosi@alice.it) id 52494B43014EED17; Wed, 16 Oct 2013 00:26:16 +0200 Message-ID: <525DC105.7000909@alice.it> Date: Wed, 16 Oct 2013 00:26:13 +0200 From: Angelo Graziosi User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Glenn Morris , Stefan Monnier Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? References: <525C59B0.7090804@alice.it> <6wsiw2zipi.fsf@fencepost.gnu.org> In-Reply-To: <6wsiw2zipi.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-emacs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Il 15/10/2013 16.56, Glenn Morris ha scritto: > Stefan Monnier wrote: > >> This works correctly if you use (setq sh-use-smie t) which I recommend. > > It works fine in 24.3 out-of-the-box. > Also in trunk rev. 114585 (09 October 2013). So, some recent changes have broken the indentation of Shell-script[sh] mode... Ciao, Angelo. From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 18:41:32 2013 Received: (at 15613) by debbugs.gnu.org; 16 Oct 2013 22:41:33 +0000 Received: from localhost ([127.0.0.1]:54712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWZmW-0008NE-Fu for submit@debbugs.gnu.org; Wed, 16 Oct 2013 18:41:32 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37308 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWZmU-0008N4-20 for 15613@debbugs.gnu.org; Wed, 16 Oct 2013 18:41:30 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VWZmR-0007XJ-SW; Wed, 16 Oct 2013 18:41:28 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? References: <525C59B0.7090804@alice.it> X-Spook: Defcon csystems Verisign North Korea illuminati World X-Ran: BRRO;#`^_@_/a0Xo=l*xPM#RFSzz&7>YIJcw@ES&i}=B%!_}![lwzP5G0d@m`gIH//X*D" X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 16 Oct 2013 18:41:27 -0400 In-Reply-To: (Stefan Monnier's message of "Tue, 15 Oct 2013 10:37:44 -0400") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15613 Cc: 15613@debbugs.gnu.org, Angelo Graziosi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) By experiment, reverting the "Always setup SMIE..." part of your 2013-10-11 change fixes this regression. *** lisp/progmodes/sh-script.el 2013-10-13 23:21:56 +0000 --- lisp/progmodes/sh-script.el 2013-10-16 22:35:56 +0000 *************** *** 2248,2253 **** --- 2248,2254 ---- (sh-feature sh-indent-supported)) (progn (message "Setting up indent for shell type %s" sh-shell) + (if sh-use-smie (let ((mksym (lambda (name) (intern (format "sh-smie-%s-%s" sh-indent-supported-here name))))) *************** *** 2255,2261 **** (funcall mksym "rules") :forward-token (funcall mksym "forward-token") :backward-token (funcall mksym "backward-token"))) - (unless sh-use-smie (setq-local parse-sexp-lookup-properties t) (setq-local sh-kw-alist (sh-feature sh-kw)) (let ((regexp (sh-feature sh-kws-for-done))) --- 2256,2261 ---- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 21:03:52 2013 Received: (at 15613) by debbugs.gnu.org; 17 Oct 2013 01:03:52 +0000 Received: from localhost ([127.0.0.1]:54761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWc0F-0003Gh-Si for submit@debbugs.gnu.org; Wed, 16 Oct 2013 21:03:52 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:2928) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWc0D-0003GS-BZ for 15613@debbugs.gnu.org; Wed, 16 Oct 2013 21:03:49 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCo0c/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IPAS-Result: Av4EABK/CFFMCo0c/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="35675731" Received: from 76-10-141-28.dsl.teksavvy.com (HELO pastel.home) ([76.10.141.28]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Oct 2013 21:03:43 -0400 Received: by pastel.home (Postfix, from userid 20848) id D002B60A82; Wed, 16 Oct 2013 21:03:42 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? Message-ID: References: <525C59B0.7090804@alice.it> Date: Wed, 16 Oct 2013 21:03:42 -0400 In-Reply-To: (Glenn Morris's message of "Wed, 16 Oct 2013 18:41:27 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15613 Cc: 15613@debbugs.gnu.org, Angelo Graziosi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > By experiment, reverting the "Always setup SMIE..." part of your > 2013-10-11 change fixes this regression. Aha! I'll try and see why that introduces such breakage. Probably a call to backward-sexp somewhere. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 22:03:19 2013 Received: (at 15613) by debbugs.gnu.org; 17 Oct 2013 02:03:19 +0000 Received: from localhost ([127.0.0.1]:54790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWcvm-0004gv-Uw for submit@debbugs.gnu.org; Wed, 16 Oct 2013 22:03:19 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39697 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWcvk-0004gn-Fz for 15613@debbugs.gnu.org; Wed, 16 Oct 2013 22:03:16 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VWcvi-0006cN-I7; Wed, 16 Oct 2013 22:03:14 -0400 From: Glenn Morris To: Stefan Monnier Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? References: <525C59B0.7090804@alice.it> X-Spook: cryptographic Jyllandsposten M-14 MIT-LL constitution X-Ran: yB!d?DH`*\uM%&wer@6^Dlg"g{zaVA>A0$f{ev7>W]dS'hzUlR<]8ONN)YL(!w{)'<+EOq X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 16 Oct 2013 22:03:14 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 16 Oct 2013 21:03:42 -0400") Message-ID: <2by55sr6vx.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.5 (-----) X-Debbugs-Envelope-To: 15613 Cc: 15613@debbugs.gnu.org, Angelo Graziosi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.5 (-----) Stefan Monnier wrote: >> By experiment, reverting the "Always setup SMIE..." part of your >> 2013-10-11 change fixes this regression. > > Aha! I'll try and see why that introduces such breakage. > Probably a call to backward-sexp somewhere. This specific problem seems due to smie-setup's (setq-local forward-sexp-function #'smie-forward-sexp-command) From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 16 23:57:43 2013 Received: (at 15613) by debbugs.gnu.org; 17 Oct 2013 03:57:43 +0000 Received: from localhost ([127.0.0.1]:54877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWeiV-0007Uh-E2 for submit@debbugs.gnu.org; Wed, 16 Oct 2013 23:57:43 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:36500) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWeiS-0007US-KD for 15613@debbugs.gnu.org; Wed, 16 Oct 2013 23:57:41 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCo0c/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCTBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFMCo0c/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCTBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="35691394" Received: from 76-10-141-28.dsl.teksavvy.com (HELO pastel.home) ([76.10.141.28]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Oct 2013 23:57:34 -0400 Received: by pastel.home (Postfix, from userid 20848) id 1CC2660A82; Wed, 16 Oct 2013 23:57:34 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? Message-ID: References: <525C59B0.7090804@alice.it> <2by55sr6vx.fsf@fencepost.gnu.org> Date: Wed, 16 Oct 2013 23:57:34 -0400 In-Reply-To: <2by55sr6vx.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 16 Oct 2013 22:03:14 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 15613 Cc: 15613@debbugs.gnu.org, Angelo Graziosi X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) I installed the patch below which should fix it, thank you, Stefan --- lisp/progmodes/sh-script.el 2013-10-13 23:21:56 +0000 +++ lisp/progmodes/sh-script.el 2013-10-17 03:53:43 +0000 @@ -3097,6 +3097,7 @@ OPEN and CLOSE are regexps denoting the tokens to be matched. Optional parameter DEPTH (usually 1) says how many to look for." (let ((parse-sexp-ignore-comments t) + (forward-sexp-function nil) prev) (setq depth (or depth 1)) (save-excursion From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 12:47:04 2013 Received: (at submit) by debbugs.gnu.org; 17 Oct 2013 16:47:04 +0000 Received: from localhost ([127.0.0.1]:55721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWqj1-0002CE-RX for submit@debbugs.gnu.org; Thu, 17 Oct 2013 12:47:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55645) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWqiz-0002Bk-Fp for submit@debbugs.gnu.org; Thu, 17 Oct 2013 12:47:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWqik-0004jK-Gp for submit@debbugs.gnu.org; Thu, 17 Oct 2013 12:46:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWqik-0004jF-Dm for submit@debbugs.gnu.org; Thu, 17 Oct 2013 12:46:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57306) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWqid-00051G-0w for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2013 12:46:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VWqiV-0004hL-Jd for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2013 12:46:38 -0400 Received: from smtp204.alice.it ([82.57.200.100]:38628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VWqiN-0004fs-Mr; Thu, 17 Oct 2013 12:46:23 -0400 Received: from [192.168.1.100] (79.11.41.85) by smtp204.alice.it (8.6.060.28) (authenticated as angelo.graziosi@alice.it) id 524A99080156C1C7; Thu, 17 Oct 2013 18:46:20 +0200 Message-ID: <5260144F.5000107@alice.it> Date: Thu, 17 Oct 2013 18:46:07 +0200 From: Angelo Graziosi User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Stefan Monnier , Glenn Morris Subject: Re: bug#15613: Wrong indentation in Shell-script[sh] mode? References: <525C59B0.7090804@alice.it> <2by55sr6vx.fsf@fencepost.gnu.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: bug-emacs X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Il 17/10/2013 5.57, Stefan Monnier ha scritto: > I installed the patch below which should fix it, thank you, Confirmed! Thanks, Angelo. > > --- lisp/progmodes/sh-script.el 2013-10-13 23:21:56 +0000 > +++ lisp/progmodes/sh-script.el 2013-10-17 03:53:43 +0000 > @@ -3097,6 +3097,7 @@ > OPEN and CLOSE are regexps denoting the tokens to be matched. > Optional parameter DEPTH (usually 1) says how many to look for." > (let ((parse-sexp-ignore-comments t) > + (forward-sexp-function nil) > prev) > (setq depth (or depth 1)) > (save-excursion > From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 17 13:19:44 2013 Received: (at control) by debbugs.gnu.org; 17 Oct 2013 17:19:44 +0000 Received: from localhost ([127.0.0.1]:55760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWrEd-0002zj-HA for submit@debbugs.gnu.org; Thu, 17 Oct 2013 13:19:43 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56212 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VWrEb-0002za-ID for control@debbugs.gnu.org; Thu, 17 Oct 2013 13:19:41 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VWrEb-0001Sr-0U for control@debbugs.gnu.org; Thu, 17 Oct 2013 13:19:41 -0400 Date: Thu, 17 Oct 2013 13:19:41 -0400 Message-Id: Subject: control message for bug 15613 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.4 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.4 (-----) close 15613 24.4 From unknown Wed Jun 18 23:09:39 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 Nov 2013 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator