GNU bug report logs - #15591
gpt mishandles non ascii partition names

Previous Next

Full log

Message #61 received at 15591 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 15591 <at> debbugs.gnu.org
Subject: Re: [PATCH] libparted: handle i18n gpt partition names correctly
Date: Sun, 22 Dec 2013 18:45:31 -0800

On Sun, Dec 22, 2013 at 6:17 PM, Phillip Susi <psusi <at> ubuntu.com> wrote:
> +# check for expected output
> +dd if=$dev bs=1 skip=$(($sector_size_+$sector_size_+58)) count=10 2>/dev/null | od -An -tx1 > out || fail=1
> +echo \ 66 00 6f 00 6f 00 24 1d 00 00 >> exp

Thank you.  That looks correct and is now more portable.
To avoid minor "reviewer surprise", I suggest to drop the use of
backslash-space and instead use single quotes around the
entire line, and use ">" rather than ">>", e.g.,

  echo ' 66 00 6f 00 6f 00 24 1d 00 00' > exp

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.