GNU bug report logs - #15589
[PATCH] `how-many' throws when called with two arguments.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Oleh <oleh.krehel <at> gmail.com>
Subject: bug#15589: closed (Re: bug#15589: [PATCH] `how-many' throws when
 called with two arguments.)
Date: Sun, 13 Oct 2013 05:31:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#15589: [PATCH] `how-many' throws when called with two arguments.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 15589 <at> debbugs.gnu.org.

-- 
15589: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15589
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 15589-done <at> debbugs.gnu.org
Subject: Re: bug#15589: [PATCH] `how-many' throws when called with two
 arguments.
Date: Sun, 13 Oct 2013 01:30:36 -0400

Version: 24.4

Thanks; applied.

[Message part 3 (message/rfc822, inline)]

From: Oleh <oleh.krehel <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] `how-many' throws when called with two arguments.
Date: Fri, 11 Oct 2013 16:33:29 +0200

[Message part 4 (text/plain, inline)]

Hi,

It's strange that it throws, since there's a sane default for `rend'
which is (point-max). It's currently used when neither `rstart' or
`rend' are provided.

I attach a patch.

[0001-replace.el-how-many-rend-argument-defaults-to-point-.patch (text/x-diff, inline)]

From e315068e21519a11b0f28e8d45fb08b5bab35850 Mon Sep 17 00:00:00 2001
From: Oleh Krehel <ohwoeowho <at> gmail.com>
Date: Fri, 11 Oct 2013 16:27:20 +0200
Subject: [PATCH] * replace.el (how-many): rend argument defaults to
 (point-max) if not provided.

---
 replace.el | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/replace.el b/replace.el
index abb59a6..d92fb68 100644
--- a/replace.el
+++ b/replace.el
@@ -810,9 +810,12 @@ a previously found match."
    (keep-lines-read-args "How many matches for regexp"))
   (save-excursion
     (if rstart
-	(progn
-	  (goto-char (min rstart rend))
-	  (setq rend (max rstart rend)))
+        (if rend
+            (progn
+              (goto-char (min rstart rend))
+              (setq rend (max rstart rend)))
+          (goto-char rstart)
+          (setq rend (point-max)))
       (if (and interactive transient-mark-mode mark-active)
 	  (setq rstart (region-beginning)
 		rend (region-end))
-- 
1.8.4

[Message part 6 (text/plain, inline)]

regards,
Oleh

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.