GNU bug report logs - #15588
[PATCH] cp: correct error message for invalid arguments of '--no-preserve'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ovasik <at> redhat.com
Subject: bug#15588: closed (Re: bug#15588: [PATCH] cp: correct error
 message for invalid arguments of '--no-preserve')
Date: Fri, 11 Oct 2013 16:13:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#15588: [PATCH] cp: correct error message for invalid arguments of '--no-preserve'

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 15588 <at> debbugs.gnu.org.

-- 
15588: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15588
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: ovasik <at> redhat.com
Cc: 15588-done <at> debbugs.gnu.org
Subject: Re: bug#15588: [PATCH] cp: correct error message for invalid arguments
 of '--no-preserve'
Date: Fri, 11 Oct 2013 17:12:09 +0100

On 10/11/2013 02:07 PM, Ondrej Vasik wrote:
> * src/cp.c (decode_preserve_arg) :
> Correct error message for invalid arguments of '--no-preserve'.
> Reported by M.Vadkerti in rhbz #1018206.
> ---
>  src/cp.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/src/cp.c b/src/cp.c
> index e235b32..7bc8630 100644
> --- a/src/cp.c
> +++ b/src/cp.c
> @@ -854,7 +854,8 @@ decode_preserve_arg (char const *arg, struct
> cp_options *x, bool on_off)
>          *comma++ = 0;
>  
>        /* process S.  */
> -      val = XARGMATCH ("--preserve", s, preserve_args, preserve_vals);
> +      val = XARGMATCH (on_off ? "--preserve" : "--no-preserve",
> +                       s, preserve_args, preserve_vals);
>        switch (val)
>          {
>          case PRESERVE_MODE:
> 

Pushed.

thanks!
Pádraig.

[Message part 3 (message/rfc822, inline)]

From: Ondrej Vasik <ovasik <at> redhat.com>
To: CoreutilsBugs <bug-coreutils <at> gnu.org>
Subject: [PATCH] cp: correct error message for invalid arguments of
 '--no-preserve'
Date: Fri, 11 Oct 2013 15:07:04 +0200

* src/cp.c (decode_preserve_arg) :
Correct error message for invalid arguments of '--no-preserve'.
Reported by M.Vadkerti in rhbz #1018206.
---
 src/cp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/src/cp.c b/src/cp.c
index e235b32..7bc8630 100644
--- a/src/cp.c
+++ b/src/cp.c
@@ -854,7 +854,8 @@ decode_preserve_arg (char const *arg, struct
cp_options *x, bool on_off)
         *comma++ = 0;
 
       /* process S.  */
-      val = XARGMATCH ("--preserve", s, preserve_args, preserve_vals);
+      val = XARGMATCH (on_off ? "--preserve" : "--no-preserve",
+                       s, preserve_args, preserve_vals);
       switch (val)
         {
         case PRESERVE_MODE:
-- 
1.7.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.