GNU bug report logs - #15580
[PATCH] 24.3.50; subword-capitalize at the end of a buffer jumps to the beginning

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Dima Kogan <dima <at> secretsauce.net>
Subject: bug#15580: closed (Re: bug#15580: [PATCH] 24.3.50;
 subword-capitalize at the end of a buffer jumps to the beginning)
Date: Tue, 15 Oct 2013 12:35:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#15580: [PATCH] 24.3.50; subword-capitalize at the end of a buffer jumps to the beginning

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 15580 <at> debbugs.gnu.org.

-- 
15580: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15580
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 15580-done <at> debbugs.gnu.org
Subject: Re: bug#15580: [PATCH] 24.3.50;
 subword-capitalize at the end of a buffer jumps to the beginning
Date: Mon, 14 Oct 2013 15:25:17 -0400

> and uses the results of this search even if it failed. The attached
> patch explicitly checks for search failure and exits the function in
> that case.

Thanks.  I slightly simplified your patch (since re-search-forward
already signal search-failed if the 3rd arg is nil) and installed it.


        Stefan


PS: This is at least the second "tiny" patch you contributed, so you're
on course to hit the limit of what we can accept without
copyright paperwork.  If you'd like to sign this paperwork already to
avoid future delays, I can send you the needed forms.

[Message part 3 (message/rfc822, inline)]

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 24.3.50;
 subword-capitalize at the end of a buffer jumps to the beginning
Date: Thu, 10 Oct 2013 00:01:22 -0700

[Message part 4 (text/plain, inline)]

Hi.

I'm observing subword-capitalize get confused when called near the end
of a buffer. Instead of doing nothing like capitalize-word does,
subword-capitalize jumps to around the beginning of the buffer and
capitalizes something there.

The cause is simple. subword-capitalize does

(re-search-forward "[[:alpha:]]" ....)

and uses the results of this search even if it failed. The attached
patch explicitly checks for search failure and exits the function in
that case.

[0001-subword-capitalize-now-fails-gracefully-at-end-of-bu.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.