From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 00:05:10 2013 Received: (at submit) by debbugs.gnu.org; 7 Oct 2013 04:05:10 +0000 Received: from localhost ([127.0.0.1]:58889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VT24C-00016B-UT for submit@debbugs.gnu.org; Mon, 07 Oct 2013 00:05:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42676) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VT248-000160-8L for submit@debbugs.gnu.org; Mon, 07 Oct 2013 00:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VT23x-0001s0-Oj for submit@debbugs.gnu.org; Mon, 07 Oct 2013 00:05:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51903) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT23x-0001rw-Mh for submit@debbugs.gnu.org; Mon, 07 Oct 2013 00:04:53 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT23o-0007DB-Vq for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2013 00:04:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VT23g-0001qC-FC for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2013 00:04:44 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:51799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VT23g-0001q8-7F for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2013 00:04:36 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r9744YUV014782 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 7 Oct 2013 04:04:35 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9744XMm011176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 7 Oct 2013 04:04:34 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r9744X4R019250 for ; Mon, 7 Oct 2013 04:04:33 GMT MIME-Version: 1.0 Message-ID: Date: Sun, 6 Oct 2013 21:04:33 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; doc string of `isearch-cmds' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) 1. The first element of the vector is missing from the description. It is the symbol `cl-struct-isearch--state'. The vector has 13 elements, not 12. 2. It would be a little clearer to say that the value is a *list* that is *used* as a stack. 3. Better to just say "vectors", not "sets", since the order is important (and the reader is right-away presented with the vector description). In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-09-30 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --enable-checking 'CFLAGS=3D-O0 -g3' CPPFLAGS=3D-DGLYPH_DEBUG= =3D1' From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 07 00:55:29 2013 Received: (at 15547) by debbugs.gnu.org; 7 Oct 2013 04:55:29 +0000 Received: from localhost ([127.0.0.1]:58949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VT2qt-0002KJ-U5 for submit@debbugs.gnu.org; Mon, 07 Oct 2013 00:55:28 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:34918) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VT2qn-0002K5-Jg for 15547@debbugs.gnu.org; Mon, 07 Oct 2013 00:55:22 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r974tJm8017478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <15547@debbugs.gnu.org>; Mon, 7 Oct 2013 04:55:20 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r974tJ2E000628 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <15547@debbugs.gnu.org>; Mon, 7 Oct 2013 04:55:19 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r974tIrE029254 for <15547@debbugs.gnu.org>; Mon, 7 Oct 2013 04:55:19 GMT MIME-Version: 1.0 Message-ID: <60fb0470-bd15-447f-8e03-9ffc8eb57d0e@default> Date: Sun, 6 Oct 2013 21:55:19 -0700 (PDT) From: Drew Adams To: 15547@debbugs.gnu.org Subject: RE: bug#15547: 24.3.50; doc string of `isearch-cmds' References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 15547 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > 1. The first element of the vector is missing from the description. It > is the symbol `cl-struct-isearch--state'. The vector has 13 elements, > not 12. >=20 > 2. It would be a little clearer to say that the value is a *list* that > is *used* as a stack. >=20 > 3. Better to just say "vectors", not "sets", since the order is > important (and the reader is right-away presented with the vector > description). And I forgot perhaps the most important of all: please describe each of the vector elements. Say what they correspond to, e.g., `isearch--state-barrier' corresponds to variable `isearch-barrier' (which has a doc string describing it). From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 23:00:50 2014 Received: (at 15547) by debbugs.gnu.org; 8 Feb 2014 04:00:50 +0000 Received: from localhost ([127.0.0.1]:55855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBz61-0001my-4F for submit@debbugs.gnu.org; Fri, 07 Feb 2014 23:00:49 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:57380) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBz5x-0001jG-Iu for 15547@debbugs.gnu.org; Fri, 07 Feb 2014 23:00:45 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBz5j-0004a9-8O; Sat, 08 Feb 2014 05:00:31 +0100 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#15547: 24.3.50; doc string of `isearch-cmds' References: Date: Fri, 07 Feb 2014 19:59:23 -0800 In-Reply-To: (Drew Adams's message of "Sun, 6 Oct 2013 21:04:33 -0700 (PDT)") Message-ID: <87wqh66yqs.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WBz5j-0004a9-8O X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392436831.76591@rX4no6nK/AMLxEcpL4fIrQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 15547 Cc: 15547@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > 1. The first element of the vector is missing from the description. It > is the symbol `cl-struct-isearch--state'. The vector has 13 elements, > not 12. I don't think it should say "vector" at all. It's a list of structs. That the structs are implemented internally as vectors should be irrelevant. I'll change the doc string. > 2. It would be a little clearer to say that the value is a *list* that > is *used* as a stack. Uhm... I don't think that's necessary. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 23:00:55 2014 Received: (at control) by debbugs.gnu.org; 8 Feb 2014 04:00:55 +0000 Received: from localhost ([127.0.0.1]:55858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBz67-0001sa-D5 for submit@debbugs.gnu.org; Fri, 07 Feb 2014 23:00:55 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:57386) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBz63-0001pX-O7 for control@debbugs.gnu.org; Fri, 07 Feb 2014 23:00:52 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBz5p-0004aI-TM for control@debbugs.gnu.org; Sat, 08 Feb 2014 05:00:38 +0100 Date: Fri, 07 Feb 2014 19:59:29 -0800 Message-Id: <87vbwq6yqm.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #15547 X-MailScanner-ID: 1WBz5p-0004aI-TM X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392436838.45872@tB2de6abyiosf5pvGcxxwQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 15547 24.4 From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 21:42:48 2014 Received: (at 15547) by debbugs.gnu.org; 9 Feb 2014 02:42:48 +0000 Received: from localhost ([127.0.0.1]:58539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCKM3-00078V-GW for submit@debbugs.gnu.org; Sat, 08 Feb 2014 21:42:47 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:43722) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCKM1-00078N-Bz for 15547@debbugs.gnu.org; Sat, 08 Feb 2014 21:42:45 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s192gijh004864 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <15547@debbugs.gnu.org>; Sun, 9 Feb 2014 02:42:44 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s192ghTP024531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <15547@debbugs.gnu.org>; Sun, 9 Feb 2014 02:42:44 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s192ghep024527 for <15547@debbugs.gnu.org>; Sun, 9 Feb 2014 02:42:43 GMT MIME-Version: 1.0 Message-ID: <10ad2e6b-7393-4ecd-9672-527484aee22d@default> Date: Sat, 8 Feb 2014 18:42:41 -0800 (PST) From: Drew Adams To: 15547@debbugs.gnu.org Subject: RE: bug#15547: 24.3.50; doc string of `isearch-cmds' References: <60fb0470-bd15-447f-8e03-9ffc8eb57d0e@default> In-Reply-To: <60fb0470-bd15-447f-8e03-9ffc8eb57d0e@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 15547 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > > > 1. The first element of the vector is missing from the > > > description. It is the symbol `cl-struct-isearch--state'. > > > The vector has 13 elements, not 12. >=20 > I don't think it should say "vector" at all. It's a list of > structs. That the structs are implemented internally as vectors > should be irrelevant. I'll change the doc string. No, it is not irrelevant. See below, about correspondences with important Isearch variables, as one indication. > > > 2. It would be a little clearer to say that the value is a *list* > > > that is *used* as a stack. >=20 > Uhm... I don't think that's necessary. > > > > 3. Better to just say "vectors", not "sets", since > > > the order is important (and the reader is right-away presented ^^^^^^^^^^^^^^^^^^^^^^ > > > with the vector description). These are vectors. They are sequences; they have order. > > And I forgot perhaps the most important of all: please describe > > each of the vector elements. Say what they correspond to, e.g., ^^^^^^^^^^^^^^^^^^^^^^^ > > `isearch--state-barrier' corresponds to variable `isearch-barrier' > > (which has a doc string describing it). Without knowing those correspondences the code is impenetrable, and anyone trying to make use of it (e.g., adapt parts of it) is at a loss. More generally, any Lisp programmer working with isearch code these days needs to understand the things I reported that are not clear. There are many people out there who write their own code that involves adaptation (and sometimes improvement) of distributed Emacs code. They invent new features and sometimes better ways of doing things. That is the point of free software, and Emacs in particular. Adding, rather than removing, obstacles to understanding is perverse. It is akin to obfuscating code. The Isearch code is particularly dense and deserves better documentation. Users deserve better. From unknown Mon Jun 23 18:29:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug No longer marked as fixed in versions 24.4 and reopened. Date: Sun, 09 Feb 2014 23:17:01 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug No longer marked as fixed in versions 24.4 and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 10 02:54:40 2014 Received: (at control) by debbugs.gnu.org; 10 Feb 2014 07:54:40 +0000 Received: from localhost ([127.0.0.1]:33919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WClhP-0005C4-HT for submit@debbugs.gnu.org; Mon, 10 Feb 2014 02:54:39 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:56001) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WClhM-0005Bo-S4 for control@debbugs.gnu.org; Mon, 10 Feb 2014 02:54:37 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WClh3-00015Q-Cd for control@debbugs.gnu.org; Mon, 10 Feb 2014 08:54:17 +0100 Date: Sun, 09 Feb 2014 23:53:04 -0800 Message-Id: <874n471k0v.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #15547 X-MailScanner-ID: 1WClh3-00015Q-Cd X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392623658.2616@DPlvmJ0q1YKng1DZIf9RLA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 15547 From unknown Mon Jun 23 18:29:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Mar 2014 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator