From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 06 18:40:16 2013 Received: (at submit) by debbugs.gnu.org; 6 Oct 2013 22:40:16 +0000 Received: from localhost ([127.0.0.1]:58376 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSwzl-0001Uk-7N for submit@debbugs.gnu.org; Sun, 06 Oct 2013 18:40:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50485) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VSt8v-00045N-Qy for submit@debbugs.gnu.org; Sun, 06 Oct 2013 14:33:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSt8o-00034k-Eg for submit@debbugs.gnu.org; Sun, 06 Oct 2013 14:33:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_BL_SPAMCOP_NET autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:33629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSt8o-00034g-Bb for submit@debbugs.gnu.org; Sun, 06 Oct 2013 14:33:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSt8i-0001nP-3k for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2013 14:33:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VSt8a-000325-Iy for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2013 14:33:12 -0400 Received: from mout.web.de ([212.227.15.3]:54537) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VSt8a-00031l-9L for bug-gnu-emacs@gnu.org; Sun, 06 Oct 2013 14:33:04 -0400 Received: from localhost ([2.241.140.92]) by smtp.web.de (mrweb103) with ESMTPA (Nemesis) id 0LdmyV-1WAzWv1t7T-00j5Qq for ; Sun, 06 Oct 2013 20:33:02 +0200 Date: Sun, 06 Oct 2013 20:33:24 +0200 (CEST) Message-Id: <20131006.203324.1423473957775252510.Svante.v.Erichsen@web.de> To: bug-gnu-emacs@gnu.org Subject: 24.3; Common Lisp simple loop differentiation From: Svante Carl v. Erichsen X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:D42sP8phRB2wK50NkZ9QoMfbi4Sz0qrStB9zzBHfwyKn6rzqAvE Vy9mX+p/VZ6lA15JGzXuaZ1oqlYUewi3SSk2Yo+9P59bdpQXINA6IYQ5DEWnSLP0538TKFt Y7gh6kH6gb7jaNTGVdGpaZTjNYv7+yHJVXDvEflX0FGQCP9Mik9QIRGBWI+m6GxSZiHHlJg uGEtEA3p7GYDf1l2lmc6g== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 06 Oct 2013 18:40:11 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) When common-lisp-indent-function is active, the indentation of loop forms is not correct when keywords are used as loop keyword designators (e.g. ":for" instead of "for"). This is caused by extended-loop-p not recognizing a \: as starting an extended loop keyword. Extended loops thus get incorrectly treated as simple loops in this case. Common-lisp-loop-part-indentation (which is the next toplevel form in cl-indent.el) treats \: correctly. A simple patch could be like this: -------------------------------------------------- --- /usr/share/emacs/24.3/lisp/emacs-lisp/cl-indent.el 2013-01-01 21:37:17.000000000 +0100 +++ cl-indent.el 2013-10-06 20:18:15.591013753 +0200 @@ -151,7 +151,7 @@ (forward-char 1) (forward-sexp 2) (backward-sexp 1) - (looking-at "\\sw")) + (looking-at "\\(:\\|\\sw\\)")) (error t))) -------------------------------------------------- Best wishes Svante v. Erichsen In GNU Emacs 24.3.1 (x86_64-pc-linux-gnu, Motif Version 2.3.4) of 2013-08-20 on alraune Windowing system distributor `The X.Org Foundation', version 11.0.11403000 Configured using: `configure '--prefix=/usr' '--build=x86_64-pc-linux-gnu' '--host=x86_64-pc-linux-gnu' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--datadir=/usr/share' '--sysconfdir=/etc' '--localstatedir=/var/lib' '--libdir=/usr/lib64' '--disable-dependency-tracking' '--program-suffix=-emacs-24' '--infodir=/usr/share/info/emacs-24' '--enable-locallisppath=/etc/emacs:/usr/share/emacs/site-lisp' '--with-crt-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/4.6.3/../../../../lib64' '--with-gameuser=games' '--without-compress-info' '--without-hesiod' '--without-kerberos' '--without-kerberos5' '--without-gpm' '--without-dbus' '--without-gnutls' '--without-xml2' '--without-selinux' '--without-wide-int' '--with-sound' '--with-x' '--without-ns' '--without-gconf' '--without-gsettings' '--without-toolkit-scroll-bars' '--with-gif' '--with-jpeg' '--with-png' '--with-rsvg' '--with-tiff' '--with-xpm' '--with-imagemagick' '--without-xft' '--without-libotf' '--without-m17n-flt' '--with-x-toolkit=motif' 'GENTOO_PACKAGE=app-editors/emacs-24.3-r2' 'build_alias=x86_64-pc-linux-gnu' 'host_alias=x86_64-pc-linux-gnu' 'CFLAGS=-O2 -march=core2 -pipe' 'LDFLAGS=-Wl,-O1 -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_CTYPE: de_DE.UTF-8 value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: paredit-mode: t recentf-mode: t display-battery-mode: t show-paren-mode: t display-time-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t Recent input: M-b M-b M-b M-f M-f M-f M-f M-b M-b M-b M-b t o SPC v e r t e x SPC ~ s SPC M-f M-f M-f M-f . C-f SPC e d g e SPC g v e r t e x C-x C-s M-b M-b C-b C-x C-s C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-p C-e C-b C-b C-b C-SPC C-n C-b C-n C-b M-w C-p C-p C-p C-p C-p C-p C-p C-e C-b C-y C-p C-e C-b M-b M-d g i r l C-x C-s M-q C-_ C-n M-q M-q C-p C-e M-q M-q C-n C-n C-n C-n C-n C-n C-n C-n C-n C-x C-s M-> C-p M-m C-M-k M-^ C-x C-s C-x C-f C-g C-x C-y C-n C-n C-n C-n C-n C-n C-n C-n C-n M-> C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-e C-p C-k C-x C-s C-p C-e ( l o a d - u s e r - f i l e SPC " r e p a i r - l o o p - i n d e n t . e l C-x C-s C-x C-f r e p a i r - l o o p - i n d e n t . e l ( C-y C-_ ) C-x C-s C-p C-f C-f C-f C-f C-f C-f \ \ ( C-f C-f C-f C-f \ \ ) C-b C-b C-b C-b C-b C-b C-b : \ \ | C-x C-s C-n C-x C-e C-n C-n C-n C-c s l M-q C-x C-y C-n M-x r e p o r t - e m a c s - b u g Recent messages: Missing closing delimiter: ) Saving file /home/svante/.emacs.d/repair-loop-indent.el... Wrote /home/svante/.emacs.d/repair-loop-indent.el Saving file /home/svante/.emacs.d/repair-loop-indent.el... Wrote /home/svante/.emacs.d/repair-loop-indent.el extended-loop-p byte-code: End of buffer [2 times] Select [4?cdeilnqrstv]: Open /home/svante/.emacs.d/repair-loop-indent.el Making completion list... Load-path shadows: None found. Features: (shadow emacsbug message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils cus-edit cus-start cus-load etags tabify sgml-mode org-wl org-w3m org-vm org-rmail org-mhe org-mew org-irc org-jsinfo org-infojs org-html org-exp ob-exp org-exp-blocks org-agenda org-info org-gnus org-docview org-bibtex bibtex org-bbdb org ob-tangle ob-ref ob-lob ob-table org-footnote org-src ob-comint ob-keys org-pcomplete pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob org-compat org-macs ob-eval org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs conf-mode slime-asdf misearch multi-isearch compile mule-util w3m-form w3m-bookmark w3m-tabmenu w3m-session w3m doc-view jka-compr dired image-mode timezone w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-ccl ccl w3m-favicon w3m-image w3m-proc w3m-util eldoc warnings slime-fancy slime-fontifying-fu slime-package-fu slime-references slime-scratch slime-presentations slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc advice advice-preload slime-parse slime-repl slime derived help-fns easy-mmode comint ansi-color ring hyperspec cl-macs gv thingatpt browse-url cl cl-lib help-mode pp network-stream auth-source eieio byte-opt bytecomp byte-compile cconv gnus-util mm-util mail-prsvr password-cache starttls tls mew-varsx mew-unix mew-auth mew-config mew-imap2 mew-imap mew-nntp2 mew-nntp mew-pop mew-smtp mew-ssl mew-ssh mew-net mew-highlight mew-sort mew-fib mew-ext mew-refile mew-demo mew-attach mew-draft mew-message mew-thread mew-virtual mew-summary4 mew-summary3 mew-summary2 mew-summary mew-search mew-pick mew-passwd mew-scan mew-syntax mew-bq mew-smime mew-pgp mew-header mew-exec mew-mark mew-mime mew-edit mew-decode mew-encode mew-cache mew-minibuf mew-complete mew-addrbook mew-local mew-vars3 mew-vars2 mew-vars mew-env mew-mule3 mew-mule mew-gemacs mew-key mew-func mew-blvs mew-const mew paredit edmacro kmacro info-look info slime-autoloads recentf tree-widget wid-edit easymenu battery paren time server site-gentoo w3m-load tex-site auto-loads time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dynamic-setting motif x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Sat May 27 16:09:57 2017 Received: (at 15543) by debbugs.gnu.org; 27 May 2017 20:09:57 +0000 Received: from localhost ([127.0.0.1]:41091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dEi29-000191-EI for submit@debbugs.gnu.org; Sat, 27 May 2017 16:09:57 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:35911) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dEi27-00018j-AN; Sat, 27 May 2017 16:09:55 -0400 Received: by mail-io0-f193.google.com with SMTP id f102so4061989ioi.3; Sat, 27 May 2017 13:09:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=0qtZDtbKR/M5Qfk/tuW/+7BMhkD9WW4Ic8qwnov/8Pw=; b=p+DYaBkVyQ0Pf6QBBQRymoa9u/4mR3oOutmAwF3/OYFEamSmHfITP9rqj+s1UKJ3DE /pWShCHSeV6uxbJsTligNjEo0d3ivoNHFqC3pzjj6c9RBgUXBK0333lJAg8E7ItNlJ74 jUGgJp9rA4Madj/VRN3pK1I5xZcnrOBo8D+AsNtOpDncgaaF9T/j2FW/SGKeEw+jfZNM 0dpyVNwSiTgID0mAc8u/Skeq7X+ABj8FXlb6TBulld5O7PN/6RaU+CjPKG4mN8/zei0w awVvwJ0gDH3u/pfpjxbnKhPfAFYv//+GcJcEztH+CEOK5zYZRiyPOK1Y6AX3xnC4G+ZT 64FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=0qtZDtbKR/M5Qfk/tuW/+7BMhkD9WW4Ic8qwnov/8Pw=; b=I9XM7rHE5CtnQq8uPu2m4v2vRqs8bnmfnMlOru2kVCAP39XtuSES1RzGRdoxtl/xQw 8hXelPTWMDnyvGEdSdFjng4YMYH9uquatSUO0w4i3uRdp/6jRNiTkRZvUttEsYCSlrNC y6TkOL01hPhKH6rhIXLNYQxet14zZ8tJ2GtBwyFQDPOJwrF2UPJl6jgVgCx6r+/781bH mbrqxRzOrnt6urPDJZERbXDUCEbEubnslOhhmxegxSNMuV1p8CaZHI3tftJMkMs7RjKj b1d0NhTfv2/vO2V25yTer3yxqIrttAp4getfaNfChxZS6yeyJ/1EWhAlA06R2ztps2Dq A+Qw== X-Gm-Message-State: AODbwcAjeASRzkCqr4GwGC+easI4ndCw3bGrmi9JGKyxA59fjTQdQx9M ffoxOLTtoQshtsRU X-Received: by 10.107.183.197 with SMTP id h188mr8400367iof.105.1495915789444; Sat, 27 May 2017 13:09:49 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id n14sm690662itg.0.2017.05.27.13.09.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 27 May 2017 13:09:48 -0700 (PDT) From: npostavs@users.sourceforge.net To: Svante Carl v. Erichsen Subject: Re: bug#15543: 24.3; Common Lisp simple loop differentiation References: <20131006.203324.1423473957775252510.Svante.v.Erichsen@web.de> Date: Sat, 27 May 2017 16:11:25 -0400 In-Reply-To: <20131006.203324.1423473957775252510.Svante.v.Erichsen@web.de> (Svante Carl v. Erichsen's message of "Sun, 06 Oct 2013 20:33:24 +0200 (CEST)") Message-ID: <877f125ac2.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 15543 Cc: 15543@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) tags 15543 fixed close 15543 26.1 quit Svante Carl v. Erichsen writes: > When common-lisp-indent-function is active, the indentation of loop > forms is not correct when keywords are used as loop keyword > designators (e.g. ":for" instead of "for"). This is caused by > extended-loop-p not recognizing a \: as starting an extended loop > keyword. Extended loops thus get incorrectly treated as simple loops > in this case. > > Common-lisp-loop-part-indentation (which is the next toplevel form in > cl-indent.el) treats \: correctly. > > A simple patch could be like this: > -------------------------------------------------- > --- /usr/share/emacs/24.3/lisp/emacs-lisp/cl-indent.el 2013-01-01 21:37:17.000000000 +0100 > +++ cl-indent.el 2013-10-06 20:18:15.591013753 +0200 > @@ -151,7 +151,7 @@ > (forward-char 1) > (forward-sexp 2) > (backward-sexp 1) > - (looking-at "\\sw")) > + (looking-at "\\(:\\|\\sw\\)")) > (error t))) Thanks, pushed to master [1: 527a7cc942]. [1: 527a7cc942]: 2017-05-27 16:08:35 -0400 Fix cl-indent for `loop' with :keywords (Bug#15543) http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=527a7cc9425370f7217a4d2b6914b96dff6f5ec1 From unknown Fri Aug 15 18:11:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 25 Jun 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator