GNU bug report logs - #15540
Circular module imports vs. #:select (2.0.9)

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andy Wingo <wingo <at> pobox.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15540: closed (Circular module imports vs. #:select (2.0.9))
Date: Tue, 28 Feb 2017 10:51:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 28 Feb 2017 11:50:00 +0100
with message-id <874lzepp2f.fsf <at> pobox.com>
and subject line Re: bug#15540: Circular module imports vs. #:select (2.0.9)
has caused the debbugs.gnu.org bug report #15540,
regarding Circular module imports vs. #:select (2.0.9)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15540: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15540
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: bug-guile <at> gnu.org
Subject: Circular module imports vs. #:select (2.0.9)
Date: Sun, 06 Oct 2013 21:36:42 +0200

[Message part 3 (text/plain, inline)]

Consider these two modules:

--8<---------------cut here---------------start------------->8---
(define-module (a) #:use-module (b) #:export (from-a))
(define from-a 1)
--8<---------------cut here---------------end--------------->8---

and:

--8<---------------cut here---------------start------------->8---
(define-module (b) #:use-module ((a) #:select (from-a)) #:export (from-b))
(define from-b 2)
--8<---------------cut here---------------end--------------->8---

This fails:

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(a)
While executing meta-command:
ERROR: no binding `from-a' in module (a)
--8<---------------cut here---------------end--------------->8---

whereas this succeeds (starting from a fresh Guile):

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(b)
scheme@(guile-user)> from-b
$1 = 2
--8<---------------cut here---------------end--------------->8---

Problem is that ‘define-module*’ processes exports after imports.

What about a patch along these lines:

[Message part 4 (text/x-patch, inline)]

diff --git a/module/ice-9/boot-9.scm b/module/ice-9/boot-9.scm
index c825b35..24b8f4c 100644
--- a/module/ice-9/boot-9.scm
+++ b/module/ice-9/boot-9.scm
@@ -2872,11 +2872,8 @@ VALUE."
               (error "expected list of integers for version"))
           (set-module-version! module version)
           (set-module-version! (module-public-interface module) version)))
-    (let ((imports (resolve-imports imports)))
     (call-with-deferred-observers
      (lambda ()
-         (if (pair? imports)
-             (module-use-interfaces! module imports))
        (if (list-of valid-export? exports)
            (if (pair? exports)
                (module-export! module exports))
@@ -2885,6 +2882,9 @@ VALUE."
            (if (pair? replacements)
                (module-replace! module replacements))
            (error "expected replacements to be a list of symbols or symbol pairs"))
+       (let ((imports (resolve-imports module)))
+         (if (pair? imports)
+             (module-use-interfaces! module imports)))
        (if (list-of valid-export? re-exports)
            (if (pair? re-exports)
                (module-re-export! module re-exports))
@@ -2896,7 +2896,7 @@ VALUE."
        ;; handlers.
        (if (pair? duplicates)
            (let ((handlers (lookup-duplicates-handlers duplicates)))
-               (set-module-duplicates-handlers! module handlers))))))
+             (set-module-duplicates-handlers! module handlers)))))
 
     (if transformer
         (if (and (pair? transformer) (list-of symbol? transformer))

[Message part 5 (text/plain, inline)]

Thanks,
Ludo’.

[Message part 6 (message/rfc822, inline)]

From: Andy Wingo <wingo <at> pobox.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 15540-done <at> debbugs.gnu.org
Subject: Re: bug#15540: Circular module imports vs. #:select (2.0.9)
Date: Tue, 28 Feb 2017 11:50:00 +0100

On Sun 06 Oct 2013 21:36, ludo <at> gnu.org (Ludovic Courtès) writes:

> Consider these two modules:
>
> (define-module (a) #:use-module (b) #:export (from-a))
> (define from-a 1)
>
>
> and:
>
> (define-module (b) #:use-module ((a) #:select (from-a)) #:export (from-b))
> (define from-b 2)
>
>
> This fails:
>
> scheme@(guile-user)> ,use(a)
> While executing meta-command:
> ERROR: no binding `from-a' in module (a)
>
>
> whereas this succeeds (starting from a fresh Guile):
>
> scheme@(guile-user)> ,use(b)
> scheme@(guile-user)> from-b
> $1 = 2
>
> Problem is that ‘define-module*’ processes exports after imports.

Applied a version of your patch to master.  Making the test was quite
tricky!

Andy

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.